Scott Taylor
c403768fa2
Remove some dead variable assignments.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28629
git-svn-id: http://core.svn.wordpress.org/trunk@28449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 16:59:14 +00:00
Sergey Biryukov
219321eedc
Fix inconsistent header underlining and spacing in background update emails.
...
fixes #28306 .
Built from https://develop.svn.wordpress.org/trunk@28537
git-svn-id: http://core.svn.wordpress.org/trunk@28363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 09:41:15 +00:00
Scott Taylor
1383990ae2
Add access modifier (public
) to methods and members of WP_Upgrader
and its subclasses.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28496
git-svn-id: http://core.svn.wordpress.org/trunk@28322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:29:15 +00:00
Scott Taylor
b9afafffe3
hackificator
complains if you call include 'file.php'
without the parens, needs to be include( 'file.php' )
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28479
git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 20:52:15 +00:00
Scott Taylor
4ce9706db1
Add inline comment after fix in [28467].
...
Props jesin.
Fixes #28292 .
Built from https://develop.svn.wordpress.org/trunk@28468
git-svn-id: http://core.svn.wordpress.org/trunk@28295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 15:42:14 +00:00
Scott Taylor
bdd1ae2fc7
Restore $soucrce
in WP_Upgrader::install_package()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28467
git-svn-id: http://core.svn.wordpress.org/trunk@28294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 15:40:15 +00:00
Scott Taylor
b2d1e73fd5
Eliminate the use of extract()
in WP_Upgrader
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28418
git-svn-id: http://core.svn.wordpress.org/trunk@28245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:02:14 +00:00
Sergey Biryukov
997cbaa03c
Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.
...
props GaVrA.
fixes #28124 .
Built from https://develop.svn.wordpress.org/trunk@28253
git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 08:26:24 +00:00
Dion Hulse
ca0b5c9859
Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815
...
Built from https://develop.svn.wordpress.org/trunk@28137
git-svn-id: http://core.svn.wordpress.org/trunk@27968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 10:57:14 +00:00
Andrew Nacin
fa3900168e
Allow the API to add text to auto update emails.
...
fixes #27812 .
Built from https://develop.svn.wordpress.org/trunk@28134
git-svn-id: http://core.svn.wordpress.org/trunk@27965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 08:52:15 +00:00
Dion Hulse
50a7503c2e
Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633
...
Built from https://develop.svn.wordpress.org/trunk@27905
git-svn-id: http://core.svn.wordpress.org/trunk@27736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-02 13:05:15 +00:00
Andrew Nacin
c3ca81ba94
Always decode special characters for email subjects.
...
props tlovett1, jeremyfelt.
fixes #25346 .
Built from https://develop.svn.wordpress.org/trunk@27801
git-svn-id: http://core.svn.wordpress.org/trunk@27636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 02:44:15 +00:00
Drew Jaynes
0cee31065e
Inline documentation for wp-admin/includes/class-wp-upgrader.php.
...
Props kpdesign for some minor cleanup.
Fixes #27436 .
Built from https://develop.svn.wordpress.org/trunk@27673
git-svn-id: http://core.svn.wordpress.org/trunk@27516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:00:15 +00:00
Andrew Nacin
0c16c0477b
Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
...
props Ipstenu, markjaquith.
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@27369
git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 02:34:27 +00:00
Andrew Nacin
13e868ac55
Decrement update count bubbles as plugins/themes are updated, live.
...
props gcorne, mitchoyoshitaka.
fixes #17703 .
Built from https://develop.svn.wordpress.org/trunk@27280
git-svn-id: http://core.svn.wordpress.org/trunk@27136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 06:55:14 +00:00
Drew Jaynes
b977d778b2
Inline documentation for hooks in wp-admin/includes/update-core.php.
...
Props JoshuaAbenazer, kpdesign.
Fixes #25998 .
Built from https://develop.svn.wordpress.org/trunk@27047
git-svn-id: http://core.svn.wordpress.org/trunk@26921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 08:02:14 +00:00
Sergey Biryukov
a25d9ae3ba
Make sure "UPDATE LOG" in debug emails matches the underlining when translated.
...
fixes #26621 .
Built from https://develop.svn.wordpress.org/trunk@26883
git-svn-id: http://core.svn.wordpress.org/trunk@26766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-31 10:27:10 +00:00
Ryan Boren
07c16fd23c
The Pinking Shears stir from their slumber, awakened by what may seem, to those
...
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!
One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.
Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.
Built from https://develop.svn.wordpress.org/trunk@26851
git-svn-id: http://core.svn.wordpress.org/trunk@26738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-11 19:49:11 +00:00
Andrew Nacin
7e1431aac1
Use wp_specialchars_decode() in the upgrade debugging email subject, same as the production email.
...
props markoheijnen.
fixes #26471 .
Built from https://develop.svn.wordpress.org/trunk@26762
git-svn-id: http://core.svn.wordpress.org/trunk@26650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 01:15:10 +00:00
Drew Jaynes
7bf5470bab
Inline documentation fixes for hooks and functions introduced in 3.8.0.
...
Built from https://develop.svn.wordpress.org/trunk@26736
git-svn-id: http://core.svn.wordpress.org/trunk@26625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:18:11 +00:00
Dion Hulse
5624f82c38
Use numbered string replacements in 2 new strings. Props dimadin. Fixes #25667
...
Built from https://develop.svn.wordpress.org/trunk@26346
git-svn-id: http://core.svn.wordpress.org/trunk@26247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 06:10:10 +00:00
Dion Hulse
b7872fd70a
Use static strings instead of a impossible-to-translate string in the Automatic updates debug email. Props SergeyBiryukov. Fixes #25667
...
Built from https://develop.svn.wordpress.org/trunk@26313
git-svn-id: http://core.svn.wordpress.org/trunk@26217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:00:10 +00:00
Dion Hulse
0755f5a2dc
Translate the debug update email for development installs. Props Nao for initial patch. See #25667
...
Built from https://develop.svn.wordpress.org/trunk@26279
git-svn-id: http://core.svn.wordpress.org/trunk@26184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 02:04:10 +00:00
Dion Hulse
9109f107c4
Bacground Updates: Move the 'automatic_updates_complete' hook to only fire when some updates have actually been completed. Props nacin. Fixes #25841
...
Built from https://develop.svn.wordpress.org/trunk@26164
git-svn-id: http://core.svn.wordpress.org/trunk@26075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 06:29:09 +00:00
Dion Hulse
4fbc450f52
Background Updates: Add a 'automatic_updates_complete' hook that fires after any updates have run. Props pento. Fixes #25841
...
Built from https://develop.svn.wordpress.org/trunk@26155
git-svn-id: http://core.svn.wordpress.org/trunk@26066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:08:09 +00:00
Dion Hulse
02841470a1
Background Updates: Fix a PHP Fatal error which could be encountered on some systems when using FTP. Fixes #25817 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@26148
git-svn-id: http://core.svn.wordpress.org/trunk@26059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 02:02:09 +00:00
Sergey Biryukov
e15b51efa3
Pass correct 'type' parameter to 'upgrader_process_complete' action in Theme_Upgrader.
...
props bamadesigner.
fixes #25882 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26049
git-svn-id: http://core.svn.wordpress.org/trunk@25974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 17:04:09 +00:00
Dion Hulse
c9683257db
Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772
...
Built from https://develop.svn.wordpress.org/trunk@26017
git-svn-id: http://core.svn.wordpress.org/trunk@25948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 06:23:10 +00:00
Dion Hulse
9d011a0556
Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk
...
Built from https://develop.svn.wordpress.org/trunk@26016
git-svn-id: http://core.svn.wordpress.org/trunk@25947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 06:20:09 +00:00
Dion Hulse
38a69e4ccc
Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470
...
Built from https://develop.svn.wordpress.org/trunk@26015
git-svn-id: http://core.svn.wordpress.org/trunk@25946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 05:48:10 +00:00
Dion Hulse
21a3164b3b
Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756
...
Built from https://develop.svn.wordpress.org/trunk@26013
git-svn-id: http://core.svn.wordpress.org/trunk@25944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 02:15:10 +00:00
Andrew Nacin
d0cfa40983
Add jshintrc to qunit.
...
props jorbin.
see #25187 .
Built from https://develop.svn.wordpress.org/trunk@25992
git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Andrew Nacin
70fd806759
Revert r25824:25875 from the core.svn.wordpress.org repository.
...
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin
ac2e70227f
Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
...
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.
This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.
fixes #25654 .
Built from https://develop.svn.wordpress.org/trunk@25873
git-svn-id: http://core.svn.wordpress.org/trunk@25873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 23:00:01 +00:00
Andrew Nacin
ff711dba63
"some files" instead of "certain files". Less stuffy.
...
props markjaquith.
see #25652 .
Built from https://develop.svn.wordpress.org/trunk@25871
git-svn-id: http://core.svn.wordpress.org/trunk@25871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:45 +00:00
Andrew Nacin
bed7a78426
New, better error message when we realize we won't be able to copy a file and continue with the update.
...
fixes #25652 .
Built from https://develop.svn.wordpress.org/trunk@25870
git-svn-id: http://core.svn.wordpress.org/trunk@25870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:37 +00:00
Andrew Nacin
3b7e540f00
Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
...
props dd32 for initial patch.
fixes #25657 .
Built from https://develop.svn.wordpress.org/trunk@25863
git-svn-id: http://core.svn.wordpress.org/trunk@25863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:40 +00:00
Andrew Nacin
de7977d66c
Move upgrader_process_complete for core to its proper place in Core_Upgrader.
...
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.
props dd32.
fixes #25659 .
Built from https://develop.svn.wordpress.org/trunk@25861
git-svn-id: http://core.svn.wordpress.org/trunk@25861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:23 +00:00
Andrew Nacin
b134f540e2
Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
...
fixes #25653 . Also:
* Fully document all new hooks, methods, and classes in the upgrader.
* Rename 'language' to 'translation' inside the upgrader.
* Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.
Built from https://develop.svn.wordpress.org/trunk@25859
git-svn-id: http://core.svn.wordpress.org/trunk@25859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:58 +00:00
Andrew Nacin
04bbb52c7c
Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
...
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25851
git-svn-id: http://core.svn.wordpress.org/trunk@25851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:54 +00:00
Andrew Nacin
aea50d4b4c
Use correct variable. fixes #10787 .
...
Built from https://develop.svn.wordpress.org/trunk@25843
git-svn-id: http://core.svn.wordpress.org/trunk@25843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:46 +00:00
Andrew Nacin
83b20ee7f9
Notify administrators of successful, failed, and pending core updates.
...
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.
fixes #10787 .
Built from https://develop.svn.wordpress.org/trunk@25841
git-svn-id: http://core.svn.wordpress.org/trunk@25841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:30 +00:00
Andrew Nacin
fa4f4033f7
Introduce email templates for automatic background updates.
...
The four templates are:
1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
2. We are not configured to update their site, so we notify them of the new release. ('notify')
3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2 , plus one sentence. ('fail')
4. We tried to update their site, and failed while copying files. ('critical')
With assistance from markjaquith.
see #10787 .
Built from https://develop.svn.wordpress.org/trunk@25837
git-svn-id: http://core.svn.wordpress.org/trunk@25837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:54 +00:00
Andrew Nacin
a3561e7e07
In automatic background updates, standardize on 'update'.
...
New, final filter names:
* auto_update_{$type} (plugin, theme, core, language)
* automatic_updates_is_vcs_checkout
* automatic_updates_disabled
New class name is WP_Automatic_Updater. Method names include update() and should_update().
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25835
git-svn-id: http://core.svn.wordpress.org/trunk@25835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:38 +00:00
Dion Hulse
66f01957a0
For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
...
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704
Built from https://develop.svn.wordpress.org/trunk@25828
git-svn-id: http://core.svn.wordpress.org/trunk@25828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:40 +00:00
Andrew Nacin
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
0976999929
Remove debug code from WP_Automatic_Updater::send_email().
...
props markmcwilliams for initial patch.
see #25678 .
Built from https://develop.svn.wordpress.org/trunk@25891
git-svn-id: http://core.svn.wordpress.org/trunk@25803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 01:51:09 +00:00
Andrew Nacin
7b772e5c58
Introduce a send_core_update_notification_email filter to control whether to send update notifications.
...
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.
This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.
see #25603 .
Built from https://develop.svn.wordpress.org/trunk@25882
git-svn-id: http://core.svn.wordpress.org/trunk@25794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 19:47:09 +00:00
Ryan Boren
b87d4b77e5
Pinking shears
...
Built from https://develop.svn.wordpress.org/trunk@25880
git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Andrew Nacin
a387c3bef9
Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
...
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.
This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.
fixes #25654 .
Built from https://develop.svn.wordpress.org/trunk@25873
git-svn-id: http://core.svn.wordpress.org/trunk@25785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:19:09 +00:00