Commit Graph

85 Commits

Author SHA1 Message Date
Helen Hou-Sandí
28c1600e6e Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.

Built from https://develop.svn.wordpress.org/trunk@33130


git-svn-id: http://core.svn.wordpress.org/trunk@33101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:03:24 +00:00
Scott Taylor
c502a281bb After [32656], add @access annotations to methods that have no doc block in wp-includes/*.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32657


git-svn-id: http://core.svn.wordpress.org/trunk@32627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:37:24 +00:00
Scott Taylor
bd8fafea54 Use void instead of null where appropriate when pipe-delimiting @return types. If a @return only contains void, remove it.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32568


git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-24 05:40:25 +00:00
Scott Taylor
f7098c8c2e In class-wp-admin-bar.php, clarify/add some doc blocks.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32534


git-svn-id: http://core.svn.wordpress.org/trunk@32504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:39:24 +00:00
Dominik Schilling
a7ba89b027 Accessibility: Add landmark roles to WordPress admin areas.
props afercia, joedolson.
fixes #31450.
Built from https://develop.svn.wordpress.org/trunk@31955


git-svn-id: http://core.svn.wordpress.org/trunk@31934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:17:27 +00:00
Scott Taylor
0a4af6d45c In wp-includes/class-wp-admin-bar.php, break is unreachabled after return.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28318


git-svn-id: http://core.svn.wordpress.org/trunk@28146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:29:15 +00:00
Drew Jaynes
d2014cfce3 Convert argument array documentation to the hash-notation style for WP_Admin_Bar::add_node() and WP_Admin_Bar::add_group().
Fixes #27258.

Built from https://develop.svn.wordpress.org/trunk@27370


git-svn-id: http://core.svn.wordpress.org/trunk@27220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 06:11:13 +00:00
Andrew Nacin
83a0b00489 Accept rel attributes in the toolbar's add_node() method.
props stephcook22.
fixes #27234.

Built from https://develop.svn.wordpress.org/trunk@27367


git-svn-id: http://core.svn.wordpress.org/trunk@27217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 02:14:13 +00:00
Matt Thomas
2adf09fea9 Bring in the responsive component of MP6. See #25858.
* Makes the admin fully responsive down to 320px wide.
* Adds a touch-optimized main menu that can be opened and closed from the toolbar.
* Size and positioning adjustments to icons, buttons, and text elements for better touch usability.

A few changes since MP6:

* Removed jQuery mobile. This script was used to add swipe controls to open/close the sidebar menu. This feature was apparently buggy and due to the pending demise of jQuery mobile, it was removed.
* Removed use of Backbone.js. Adding Backbone.js to this script would add a dependency of Backbone.js for all of the admin. Additionally, it was used to add a menu item. Instead of doing that, it was added via the admin menu API. This also fixes a bad delay in the item showing in the menu.
* CSS layout is standardized. Comments have also been cleaned up.
* Jetpack and Akismet code is removed.
* RTL CSS is removed.
* JS passes hinting other than one small issue that will likely be removed when parts of the code are reviewed.

A number of areas for improvement remain; we're tracking these issues in the comments of #25858.

Props to tollmanz, tillkruess, helen, dd32, and apeatling.


Built from https://develop.svn.wordpress.org/trunk@26134


git-svn-id: http://core.svn.wordpress.org/trunk@26046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 18:00:10 +00:00
Andrew Nacin
70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository.
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Ryan Boren
b87d4b77e5 Pinking shears
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Drew Jaynes
fda48c2462 Improve inline comment for removing default padding styles for the Toolbar.
Props nofearinc.
Fixes #25373.

Built from https://develop.svn.wordpress.org/trunk@25563


git-svn-id: http://core.svn.wordpress.org/trunk@25481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-22 14:34:11 +00:00
Sergey Biryukov
794414c412 Correct @since for hooks in wp-includes/class-wp-admin-bar.php. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25478


git-svn-id: http://core.svn.wordpress.org/trunk@25399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 11:58:19 +00:00
Peter Westwood
b3689b7a35 Inline documentation for hooks in wp-includes/class-wp-admin-bar.php
See #25229 props betzster

Built from https://develop.svn.wordpress.org/trunk@25475


git-svn-id: http://core.svn.wordpress.org/trunk@25396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 07:42:09 +00:00
Andrew Nacin
5f1a1eb77c Don't render the screen reader shortcut 'Log Out' link in the toolbar when the user is not logged in.
props SergeyBiryukov.
fixes #23178.



git-svn-id: http://core.svn.wordpress.org/trunk@24442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-19 08:15:04 +00:00
Andrew Ozz
769e1236af Skip To links: visually hide by only setting top: -1000em; (this should make them work well in all screen readers), fixes #21312
git-svn-id: http://core.svn.wordpress.org/trunk@22730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 21:14:49 +00:00
Andrew Ozz
e8b10439bb Accessibility shortcuts: new looks and fix for the WebKit focus bug, props lessbloat, fixes #21471
git-svn-id: http://core.svn.wordpress.org/trunk@22249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-16 21:26:59 +00:00
Andrew Nacin
1d46178afd Remove the @return for WP_Admin_Bar::remove_node(). props scribu. fixes #20906.
git-svn-id: http://core.svn.wordpress.org/trunk@21608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-24 17:34:52 +00:00
azaozz
4ef4df2f3e Accessibility: add off-screen Log Out link in the toolbar, tweak the class names of the accessible links in #adminbar, see #21312
git-svn-id: http://core.svn.wordpress.org/trunk@21452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-06 00:34:44 +00:00
azaozz
6bf5d66d5b Add "Skip to toolbar" accessibility shortcut, see #21471
git-svn-id: http://core.svn.wordpress.org/trunk@21423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-05 18:41:52 +00:00
nacin
189e833139 Admin bar: When calling add_node() for an existing node, all properties should be merged into the existing arguments, including individual meta arguments. Corrects a logic inversion. fixes #21117.
git-svn-id: http://core.svn.wordpress.org/trunk@21259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-10 21:26:35 +00:00
nacin
6cb67e8817 Tabs, not spaces for intendation. Add a docblock to the file/class.
git-svn-id: http://core.svn.wordpress.org/trunk@21257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-10 20:32:48 +00:00
nacin
4664d4bed8 Don't output empty class names or ones with leading/trailing spaces. props MattyRob for the initial patch. fixes #20698.
git-svn-id: http://core.svn.wordpress.org/trunk@21193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 11:47:21 +00:00
azaozz
1d12cd07b0 Introduce wp_is_mobile() and use it instead of $is_iphone global, see #20014
git-svn-id: http://svn.automattic.com/wordpress/trunk@20417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 01:19:30 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin
aa3cf9d286 Make sure that _render() is only called with a valid root object. As in, render() can only be validly called once and must not fail on the second call. props SergeyBiryukov, see #19642 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-30 23:04:28 +00:00
ryan
d295e6e600 Introduce user-actions group and move profile and logout menu items to it and change priority. Props koopersmith. fixes #19425
git-svn-id: http://svn.automattic.com/wordpress/trunk@19559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 03:51:58 +00:00
ryan
06a1675a3c Admin bar API improvements. Props koopersmith. fixes #19416 #19371
git-svn-id: http://svn.automattic.com/wordpress/trunk@19558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 03:42:11 +00:00
ryan
0112c9d628 Don't drop dollars. see #19426
git-svn-id: http://svn.automattic.com/wordpress/trunk@19556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 00:46:03 +00:00
ryan
a39bffbadb Add back compat support for my-account-with-avatar admin bar node id. fixes #19426
git-svn-id: http://svn.automattic.com/wordpress/trunk@19555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-06 00:31:11 +00:00
azaozz
f6047c397e Remove role="menu" and role="menuitem" for now, fixes #19394
git-svn-id: http://svn.automattic.com/wordpress/trunk@19548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-05 17:47:23 +00:00
koopersmith
74e1b3ea68 Remove the shortlink item from the toolbar, but keep the function for plugins. fixes #19407.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:25:54 +00:00
koopersmith
39ac39ef2c In toolbar, move search item to the right of the account menu and make it icon-only. fixes #19370, #19406.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:03:12 +00:00
nacin
a109cf8c6b Finalize the WP_Admin_Bar architecture for 3.3.
* Introduce a get_node() method for plugins.
 * Deprecate $wp_admin_bar->menu. Plugins will need to use get_node(), remove_node(), add_node() to make modifications. This finalizes a backwards incompatible change made earlier in the cycle.
 * Allow add_node() to take a node object (which could come from get_node(), then be modified).
 * Ensure that our underlying storage (the nodes property) is private to core. Introduce _set_node, _unset_node, _get_nodes, get_nodes as the only ways to interface with this.
 * Protect and finalize _render_item, and _render_group. render() remains public and technically overridable, though I would discourage this of plugin authors.
 * Deprecate recursive_render(). Use render() or _render_item().

More about the internals:
 * Late-binds a node's 'children' array.
 * Eliminates the root property, leverages a 'root' node.
 * Splits render() into _bind() and _render(), both protected and finalized.

Fixes #19371.


git-svn-id: http://svn.automattic.com/wordpress/trunk@19501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:25:04 +00:00
koopersmith
7c6cd25f00 Print title attributes for linkless toolbar items. see #19277.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 23:59:10 +00:00
azaozz
7f81dbfe3f Add ARIA related attributes (first take), props DrewAPicture, see #19394
git-svn-id: http://svn.automattic.com/wordpress/trunk@19484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 01:27:33 +00:00
nacin
18e0faf83e Use an 'appearance' group in the admin bar. fixes #19245.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 23:01:20 +00:00
koopersmith
eecf9dc3c1 Admin Bar: Secondary is so passé. Groups are the new black. fixes #19136.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 21:46:47 +00:00
azaozz
34d1e6c8f2 Admin bar: add class for IE9 and fix background color in search, props SergeyBiryukov, see #19151
git-svn-id: http://svn.automattic.com/wordpress/trunk@19407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-22 21:35:08 +00:00
ryan
28152dfd20 Don't show Add New and Comments admin bar menus in network or user admins. Add tooltip to comments menu. Props ocean90. fixes #19327
git-svn-id: http://svn.automattic.com/wordpress/trunk@19398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-22 16:19:05 +00:00
koopersmith
46dbae63e6 Slight rearrangements in admin bar render logic. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 23:07:54 +00:00
azaozz
eb5dbde246 Admin bar IE7, iPad and rtl refresh, see #81197
git-svn-id: http://svn.automattic.com/wordpress/trunk@19368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 02:03:02 +00:00
nacin
249cee46a3 Handle 'appearance' as a admin bar menu parent in a backwards compatible way. fixes #19245.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-20 18:39:54 +00:00
koopersmith
924ed5885c Allow linkless items in the admin bar. Improve non-jQuery admin bar tabbing. fixes #19277, #19149, #19164, #15519. see #18197, #19088.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-18 00:12:57 +00:00
koopersmith
9057e02e72 More admin bar markup improvements. Make primary and secondary submenu groups siblings (and prevent ul nesting issues). see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 11:05:37 +00:00
koopersmith
f099d03f84 Improve admin bar markup. Un-nest top level secondary menu. Remove unnecessary span. see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-12 00:26:55 +00:00
koopersmith
5299994ce5 Add general top-level class to the secondary admin menu. Fixes hover styling and tabbing JS. fixes #19220.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-10 20:46:29 +00:00
nacin
c3fb2795b0 Promote secondary admin bar items to primary if there are no primary items at time of render. see #19136, #19221.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-10 00:42:39 +00:00
koopersmith
4de1815c67 Add secondary flag to admin bar. fixes #19136.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-09 19:12:48 +00:00