Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-30 21:17:57 +01:00
Code Issues Projects Releases Wiki Activity
40,753 Commits 50 Branches 749 Tags 806 MiB
99f11a6af2
Commit Graph

40753 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sergey Biryukov
736403a26e REST API: Combine array and object cases in WP_REST_Meta_Fields::get_default_for_type() to remove duplicated line. 
Add missing description for `$type` parameter.

Props itowhid06, dkarfa.
Fixes #48169.
Built from https://develop.svn.wordpress.org/trunk@46346


git-svn-id: http://core.svn.wordpress.org/trunk@46145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 22:34:57 +00:00
Andrea Fercia
dfcdb40c8f Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment. 
Props desrosj, garrett-eclipse, afercia.
See #47498.

Built from https://develop.svn.wordpress.org/trunk@46345


git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 21:56:56 +00:00
Andrea Fercia
8ef586a897 Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue. 
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904.

Built from https://develop.svn.wordpress.org/trunk@46344


git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 21:53:57 +00:00
Sergey Biryukov
7da7edbc57 Coding Standards: Remove inline assignments and extra whitespace in tests/multisite/network.php. 
Props garrett-eclipse, jrf.
See #48142.
Built from https://develop.svn.wordpress.org/trunk@46343


git-svn-id: http://core.svn.wordpress.org/trunk@46142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 12:22:57 +00:00
Sergey Biryukov
7a91c1ee74 Docs: Improve comments in tests/multisite/network.php per the documentation standards. 
Props garrett-eclipse, jrf.
See #48142.
Built from https://develop.svn.wordpress.org/trunk@46342


git-svn-id: http://core.svn.wordpress.org/trunk@46141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 12:19:57 +00:00
Sergey Biryukov
5f2c7142a1 Docs: Improve documentation for ::display() methods in various list tables. 
Props itowhid06.
Fixes #47947.
Built from https://develop.svn.wordpress.org/trunk@46341


git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 11:04:58 +00:00
Andrea Fercia
55b1dc642e Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states. 
See #47477.
See #48128.

Built from https://develop.svn.wordpress.org/trunk@46340


git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:45:57 +00:00
Andrea Fercia
7d769a9234 Accessibility: Improve and modernize user interface controls. Style the select elements disabled state. 
Props adhitya03, MarcosAlexandre, kjellr.
See #47477.
Fixes #48129.

Built from https://develop.svn.wordpress.org/trunk@46339


git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:35:59 +00:00
Andrew Ozz
dd44ab5a58 Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen. 
Props masummdar, audrasjb, afercia.
Fixes #47318.
Built from https://develop.svn.wordpress.org/trunk@46338


git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:20:57 +00:00
Andrea Fercia
becc682bcf Accessibility: Improve and modernize user interface controls. Make the select elements background white. 
Props adhitya03.
See #47477.
Fixes #48128.

Built from https://develop.svn.wordpress.org/trunk@46337


git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:15:59 +00:00
Sergey Biryukov
07a753cb35 Docs: Add documentation for WP_Comments_List_Table::display(). 
Props itowhid06, dinhtungdu.
Fixes #47929.
Built from https://develop.svn.wordpress.org/trunk@46336


git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-27 23:03:58 +00:00
whyisjake
d4c6ebeb89 Comments: Avoid PHP notice in get_comment_reply_link() for null comment. 
If there is no global comment, or the input comment is null, return early to prevent warnings.

Fixes #41846
Props birgire, earnjam


Built from https://develop.svn.wordpress.org/trunk@46335


git-svn-id: http://core.svn.wordpress.org/trunk@46134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-27 14:46:57 +00:00
Andrea Fercia
188416bd55 Login and Registration: Revert divs and restore paragraphs after [46256]. 
Fixes #42888.

Built from https://develop.svn.wordpress.org/trunk@46334


git-svn-id: http://core.svn.wordpress.org/trunk@46133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 22:20:56 +00:00
whyisjake
304c19dbac Options: register_uninstall_hook() causes large amounts of unnecessary option updates. 
Prevent extra database read/writes from the the hook.

Props jeichorn, MikeHansenMe, DrewAPicture, Rahe, tha_sun, mikeschroder.
Fixes #31792.


Built from https://develop.svn.wordpress.org/trunk@46333


git-svn-id: http://core.svn.wordpress.org/trunk@46132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 22:08:57 +00:00
whyisjake
b6f7c0cbc4 Administration: Ensure visual consistency with large titles in the sidebar. 
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201

Built from https://develop.svn.wordpress.org/trunk@46332


git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 21:51:57 +00:00
Andrea Fercia
66dd6814e7 Media: Restore the original Image Editor columns layout after [46326]. 
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46331


git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:37:57 +00:00
whyisjake
c034f5b4c3 Menus: Replace http with https in placeholders. 
Encourage the use of https with the placeholder text in menus.

Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.

Built from https://develop.svn.wordpress.org/trunk@46330


git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:32:55 +00:00
Sergey Biryukov
1d334b273e Tests: Correct ::assertArrayHasKey() capitalization in [46252]. 
Props dkarfa, david.binda.
Fixes #48155.
Built from https://develop.svn.wordpress.org/trunk@46329


git-svn-id: http://core.svn.wordpress.org/trunk@46128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:31:58 +00:00
John Blackbourn
f73a22a98a Themes: Add a test to ensure get_template_part() does not return a value. 
This function must not be modified to return anything due to existing themes which output the return value, for example via `echo get_template_part( ... )`.

See #40969

Built from https://develop.svn.wordpress.org/trunk@46328


git-svn-id: http://core.svn.wordpress.org/trunk@46127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:26:59 +00:00
whyisjake
3c0f10e397 Themes: Docblock cleanup for get_theme_root_uri() 
In the function docblock of `get_theme_root_uri()`, the argument types of `$stylesheet_or_template` and `$theme_root` do not match. Default values of arguments are boolean but in function doc they are stated as strings.

Props subrataemfluence, williampatton, garrett-eclipse.
Fixes #44397.

Built from https://develop.svn.wordpress.org/trunk@46327


git-svn-id: http://core.svn.wordpress.org/trunk@46126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:21:58 +00:00
Andrea Fercia
93dd6d907a Accessibility: Media: Make the Image Editor buttons text visible. 
User interface controls that use only icons aren't ideal for many users. 

Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.

- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group

Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46326


git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 17:16:57 +00:00
desrosj
8affbd6404 Docs: Correct typos introduced in [46324] 
Props TimothyBlynJacobs.
See #48153.
Built from https://develop.svn.wordpress.org/trunk@46325


git-svn-id: http://core.svn.wordpress.org/trunk@46124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 16:32:58 +00:00
desrosj
1e8ed99eca Site Health: Consolidate documentation for the admin_email_check_interval filter. 
See #48153.
Built from https://develop.svn.wordpress.org/trunk@46324


git-svn-id: http://core.svn.wordpress.org/trunk@46123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 15:45:58 +00:00
desrosj
0f99e345fa Site Health: Allow the capability required for the site admin email verification screen to be filtered. 
Props desrosj, Clorith.
Fixes #48153.
Built from https://develop.svn.wordpress.org/trunk@46323


git-svn-id: http://core.svn.wordpress.org/trunk@46122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 15:41:57 +00:00
Sergey Biryukov
8bb8e77ace Code Modernisation: Introduce the spread operator in do_action(). 
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46322


git-svn-id: http://core.svn.wordpress.org/trunk@46121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 13:53:58 +00:00
Andrea Fercia
abb00ee8a4 Media: Fix JavaScript TypeError after [45376]. 
Props desrosj, afercia.
Fixes #48021.

Built from https://develop.svn.wordpress.org/trunk@46321


git-svn-id: http://core.svn.wordpress.org/trunk@46120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 13:06:56 +00:00
Gary Pendergast
2a8854ca9d Build Tools: Pass the current uid/gid to Docker containers. 
This prepares for an upcoming change to the Docker images, which improves file permission handling.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@46320


git-svn-id: http://core.svn.wordpress.org/trunk@46119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 04:58:58 +00:00
Sergey Biryukov
0a5cd17f98 Login and Registration: Standardize on 6 * MONTH_IN_SECONDS over 180 * DAY_IN_SECONDS for admin_email_check_interval filter. 
[45788] changed the first instance, but not the second.

Props tmatsuur.
Fixes #48144.
Built from https://develop.svn.wordpress.org/trunk@46319


git-svn-id: http://core.svn.wordpress.org/trunk@46118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 02:29:58 +00:00
Sergey Biryukov
8ef4150dc6 REST API: Use delta comparison for floating date test added in [46279] to avoid race conditions. 
See #48113.
Built from https://develop.svn.wordpress.org/trunk@46318


git-svn-id: http://core.svn.wordpress.org/trunk@46117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:40:58 +00:00
Sergey Biryukov
da8ebc6fc9 Coding Standards: Remove inline assignment in test_wp_delete_term_should_invalidate_cache(). 
See #48142.
Built from https://develop.svn.wordpress.org/trunk@46317


git-svn-id: http://core.svn.wordpress.org/trunk@46116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:34:58 +00:00
Sergey Biryukov
6e8f550770 General: Correct strict comparison in WP_Links_List_Table::column_categories() introduced in [46313]. 
`$cat_id` is a string, `$category` is an integer.

See #48142.
Built from https://develop.svn.wordpress.org/trunk@46316


git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:24:56 +00:00
Sergey Biryukov
148322a970 Docs: Improve documentation for _post_states() and get_post_states(). 
Add documentation for `_media_states()`.

See #47110.
Built from https://develop.svn.wordpress.org/trunk@46315


git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 00:57:58 +00:00
whyisjake
a351243928 General: Further phpcs cleanup. 
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.

Props: whyisjake, garrett-eclipse, desrosj

Built from https://develop.svn.wordpress.org/trunk@46314


git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 00:37:58 +00:00
whyisjake
d53b773a47 General: Further phpcs cleanup. 
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.
Props whyisjake, garrett-eclipse.

Built from https://develop.svn.wordpress.org/trunk@46313


git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 23:38:57 +00:00
whyisjake
38dc032e66 General: Linter cleanup 
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.

Fixes #48142
Props whyisjake

Built from https://develop.svn.wordpress.org/trunk@46312


git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:53:58 +00:00
Peter Wilson
22cba90dea Docs: Fix typo in wp_print_scripts()' reference to WP_Scripts::do_item(). 
Fixes #48141.

Built from https://develop.svn.wordpress.org/trunk@46311


git-svn-id: http://core.svn.wordpress.org/trunk@46110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:23:55 +00:00
whyisjake
2822281c57 Themes: Fix javascript regression that linter found. 
Tests were failing from line length optimizations and double quotes. 

Fixes #37536

Built from https://develop.svn.wordpress.org/trunk@46310


git-svn-id: http://core.svn.wordpress.org/trunk@46109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:12:57 +00:00
whyisjake
b4ab6b7e14 Menus: Duplicate Page Entry in View All Pages when generating a Menu 
Simplifies the interface in menu creation.

Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks


Built from https://develop.svn.wordpress.org/trunk@46309


git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 21:51:58 +00:00
whyisjake
0acc444279 Themes: Improve Twenty Fifteen sticky sidebar logic 
The current logic in TwentyFifteen (#30366) for making the sidebar sticky while still allowing to scroll through it when the sidebar height is larger than the viewport height is flawed and massively overcomplicated.
This can be mitigated by removing the admin bar specific logic and leaving most of the heavy lifting up to the browser.

Fixes #37536

Props DvanKooten, lukecavanagh, karmatosed, ianbelanger, davidbaumwald


Built from https://develop.svn.wordpress.org/trunk@46308


git-svn-id: http://core.svn.wordpress.org/trunk@46107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 21:38:58 +00:00
desrosj
285ae90032 Build/Test Tools: Remove stray + introduced in [45979]. 
Props david.binda.
Fixes #48127.
Built from https://develop.svn.wordpress.org/trunk@46294


git-svn-id: http://core.svn.wordpress.org/trunk@46106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 19:55:58 +00:00
Andrea Fercia
f8a25a89c9 Accessibility: Implement the new focus styles on the login screen after [46247]. 
Props @kjellr.
See #47153.

Built from https://develop.svn.wordpress.org/trunk@46293


git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 16:40:00 +00:00
Sergey Biryukov
547be72c3b Pings/Trackbacks: Use correct variable in a foreach() loop in do_all_pings(). 
Props itowhid06.
Fixes #48094. See #36824.
Built from https://develop.svn.wordpress.org/trunk@46292


git-svn-id: http://core.svn.wordpress.org/trunk@46104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 15:50:58 +00:00
desrosj
6ff7ff50cd Build/Test Tools: Move Composer script command line directives to the PHPCS ruleset. 
Also, move all arguments up to the top of the custom ruleset to make it easier to understand the conditions the ruleset is run under.

Props desrosj, jrf.
See #46152.
Built from https://develop.svn.wordpress.org/trunk@46291


git-svn-id: http://core.svn.wordpress.org/trunk@46103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 14:02:57 +00:00
desrosj
894e133d0c Build/Test Tools: Introduce automated PHP compatibility checking. 
This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`).

The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced.

Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors.
Fixes #46152.
Built from https://develop.svn.wordpress.org/trunk@46290


git-svn-id: http://core.svn.wordpress.org/trunk@46102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 13:47:58 +00:00
gziolo
bd344c19ea Block Editor: Align the version of React with the one used in Gutenberg plugin 
Gutenberg 6.5 works with react and react-dom set to v16.9.0. This change aligns both.

Props youknowriad.
Fixes #48121.



Built from https://develop.svn.wordpress.org/trunk@46289


git-svn-id: http://core.svn.wordpress.org/trunk@46101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 08:20:57 +00:00
Sergey Biryukov
c7f4cbc62c Docs: Improve consistency in @since tags for parameters that were made optional. 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@46288


git-svn-id: http://core.svn.wordpress.org/trunk@46100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 12:54:57 +00:00
Sergey Biryukov
b35c5b9746 Script Loader: Add function_exists() checks for is_admin() and current_theme_supports(), to accomodate for using WP_Dependencies as a standalone class. 
Remove `<![CDATA[` when outputting HTML5 script tags. 

Props azaozz.
Fixes #42804.
Built from https://develop.svn.wordpress.org/trunk@46287


git-svn-id: http://core.svn.wordpress.org/trunk@46099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 02:56:57 +00:00
desrosj
c00074e6aa Post WordPress 5.3 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46286


git-svn-id: http://core.svn.wordpress.org/trunk@46098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 00:17:56 +00:00
desrosj
3bd737c1b7 WordPress 5.3 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@46285


git-svn-id: http://core.svn.wordpress.org/trunk@46097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:54:56 +00:00
Sergey Biryukov
a943fd64bc Coding Standards: Fix WPCS issue in [46283]. 
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46284


git-svn-id: http://core.svn.wordpress.org/trunk@46096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:24:57 +00:00