Andrew Nacin
9b56d4d11f
Parse absolute paths out of error data. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25780
git-svn-id: http://core.svn.wordpress.org/trunk@25693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 22:25:08 +00:00
Dion Hulse
4dcca90887
Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
...
See #22704
Built from https://develop.svn.wordpress.org/trunk@25779
git-svn-id: http://core.svn.wordpress.org/trunk@25692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:55:09 +00:00
Andrew Nacin
4fa3687e6a
Account for the possible failure of disk_free_space() in update_core().
...
see #22704 , #25576 .
Built from https://develop.svn.wordpress.org/trunk@25778
git-svn-id: http://core.svn.wordpress.org/trunk@25691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:15:10 +00:00
Andrew Nacin
3e3c085db3
Auto updates: Only attempt a roll back when we've hit a critical error code.
...
Specifically, this means when we've failed in copying files.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25777
git-svn-id: http://core.svn.wordpress.org/trunk@25690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:03:09 +00:00
Andrew Nacin
145dbde82f
Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files.
...
see #25576 .
Built from https://develop.svn.wordpress.org/trunk@25776
git-svn-id: http://core.svn.wordpress.org/trunk@25689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:58:09 +00:00
Andrew Nacin
1516b990f1
In the upgrader, only print additional error data if it is a string.
...
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.
see #25576 .
Built from https://develop.svn.wordpress.org/trunk@25775
git-svn-id: http://core.svn.wordpress.org/trunk@25688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:20:10 +00:00
Andrew Nacin
d68a80217f
In unzip_file(), confirm we have enough available disk space before extracting.
...
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.
props dd32.
fixes #25576 .
Built from https://develop.svn.wordpress.org/trunk@25774
git-svn-id: http://core.svn.wordpress.org/trunk@25687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:15:09 +00:00
Andrew Nacin
2d898df04f
More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25772
git-svn-id: http://core.svn.wordpress.org/trunk@25685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 19:38:10 +00:00
Andrew Nacin
4c90c3cb31
Add explicit link to the installation being updated in debugging emails. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25770
git-svn-id: http://core.svn.wordpress.org/trunk@25683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-12 20:18:10 +00:00
Andrew Nacin
de1d3c8261
Silence possible warnings from is_dir(). fixes #25572 .
...
Built from https://develop.svn.wordpress.org/trunk@25764
git-svn-id: http://core.svn.wordpress.org/trunk@25677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 17:11:10 +00:00
Andrew Nacin
29f5f5b5fd
Refine error codes throughout the upgrader so we can better detect at what stage updates fail.
...
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25763
git-svn-id: http://core.svn.wordpress.org/trunk@25676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 16:06:11 +00:00
Andrew Nacin
2a8dcbae1f
Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25755
git-svn-id: http://core.svn.wordpress.org/trunk@25668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 14:46:11 +00:00
Dion Hulse
186a5379e8
After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704
...
Built from https://develop.svn.wordpress.org/trunk@25752
git-svn-id: http://core.svn.wordpress.org/trunk@25665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 01:57:08 +00:00
Dion Hulse
0b9f198994
In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful.
...
See #22704
Built from https://develop.svn.wordpress.org/trunk@25750
git-svn-id: http://core.svn.wordpress.org/trunk@25663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 01:32:09 +00:00
Andrew Nacin
f0eb99952c
Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height.
...
props plocha.
fixes #25038 .
Built from https://develop.svn.wordpress.org/trunk@25744
git-svn-id: http://core.svn.wordpress.org/trunk@25657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:07:17 +00:00
Helen Hou-Sandí
75eb364ced
Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410 .
...
Built from https://develop.svn.wordpress.org/trunk@25741
git-svn-id: http://core.svn.wordpress.org/trunk@25654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 18:47:09 +00:00
Dion Hulse
543d84a379
Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069
...
Built from https://develop.svn.wordpress.org/trunk@25739
git-svn-id: http://core.svn.wordpress.org/trunk@25652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 16:47:09 +00:00
Scott Taylor
7a7b9c89ec
Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video
in attachment_submitbox_metadata()
.
...
Props kovshenin.
See #23926 .
Built from https://develop.svn.wordpress.org/trunk@25727
git-svn-id: http://core.svn.wordpress.org/trunk@25640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 15:32:10 +00:00
Andrew Nacin
a00df382a3
Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping.
...
props SergeyBiryukov.
see #25023 .
for trunk.
Built from https://develop.svn.wordpress.org/trunk@25719
git-svn-id: http://core.svn.wordpress.org/trunk@25632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 18:35:09 +00:00
Drew Jaynes
ec96affcad
Inline documentation for hooks in wp-admin/includes/bookmark.php.
...
Props johnafish, kpdesign.
Fixes #25494 .
Built from https://develop.svn.wordpress.org/trunk@25706
git-svn-id: http://core.svn.wordpress.org/trunk@25620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 02:19:09 +00:00
Andrew Nacin
a8ea7828e9
Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates.
...
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25700
git-svn-id: http://core.svn.wordpress.org/trunk@25615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 15:46:09 +00:00
Andrew Nacin
f29acee299
Don't modify post_author during a quick edit when the post type doesn't support authors.
...
props ocean90.
fixes #16645 .
Built from https://develop.svn.wordpress.org/trunk@25698
git-svn-id: http://core.svn.wordpress.org/trunk@25613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 13:15:09 +00:00
Andrew Nacin
e8e5f48905
Run _fix_attachment_links() when post_status is future or private in addition to publish.
...
Fixes regression caused by [20308].
props jond3r.
fixes #25268 .
Built from https://develop.svn.wordpress.org/trunk@25697
git-svn-id: http://core.svn.wordpress.org/trunk@25612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 12:56:09 +00:00
Andrew Nacin
d93d8b850d
Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid.
...
props garyc40, wonderboymusic.
fixes #14578 .
Built from https://develop.svn.wordpress.org/trunk@25695
git-svn-id: http://core.svn.wordpress.org/trunk@25610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 10:56:09 +00:00
Andrew Nacin
e4dc691e75
Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override.
...
props azaozz.
fixes #24930 .
Built from https://develop.svn.wordpress.org/trunk@25694
git-svn-id: http://core.svn.wordpress.org/trunk@25609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 10:46:09 +00:00
Andrew Nacin
8392f942a4
Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009 .
...
Built from https://develop.svn.wordpress.org/trunk@25691
git-svn-id: http://core.svn.wordpress.org/trunk@25607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-05 10:59:12 +00:00
Andrew Nacin
4c63d45139
Avoid counting auto-drafts in sticky.
...
props nofearinc.
fixes #25127 .
Built from https://develop.svn.wordpress.org/trunk@25678
git-svn-id: http://core.svn.wordpress.org/trunk@25594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:16:10 +00:00
Andrew Nacin
49af5f34d7
Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses.
...
props creativeinfusion.
fixes #24818 .
Built from https://develop.svn.wordpress.org/trunk@25676
git-svn-id: http://core.svn.wordpress.org/trunk@25592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:00:09 +00:00
Andrew Nacin
be366723d2
Don't use a double negative.
...
props TobiasBg.
fixes #18201 .
Built from https://develop.svn.wordpress.org/trunk@25674
git-svn-id: http://core.svn.wordpress.org/trunk@25590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:50:09 +00:00
Andrew Nacin
524b62c5f6
Links manager: Restrict field length based on DB schema.
...
props solarissmoke, vinod-dalvi.
fixes #17296 , #12264 .
Built from https://develop.svn.wordpress.org/trunk@25670
git-svn-id: http://core.svn.wordpress.org/trunk@25586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:11:10 +00:00
Dominik Schilling
e4c8d56b76
Replace use of global $user_ID
in favor of get_current_user_id()
. fixes #25372 .
...
Built from https://develop.svn.wordpress.org/trunk@25669
git-svn-id: http://core.svn.wordpress.org/trunk@25585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:10:09 +00:00
Andrew Nacin
7de2054ece
Show a proper error message on the dashboard when the current theme is broken.
...
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.
Clean up broken/ugly "alt" row styling when we are displaying broken themes.
props johnbillion for initial patch.
fixes #21670 .
Built from https://develop.svn.wordpress.org/trunk@25666
git-svn-id: http://core.svn.wordpress.org/trunk@25582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 20:50:09 +00:00
Scott Taylor
6a5d2f8fb0
Rather than adding a taxonomy
arg to get_category()
, convert all uses of get_category()
in core to get_term()
. By doing so, we negate the need to call _make_cat_compat()
in a few places that are only looking for a single property.
...
Fixes #8722 .
Built from https://develop.svn.wordpress.org/trunk@25662
git-svn-id: http://core.svn.wordpress.org/trunk@25578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 19:59:10 +00:00
Andrew Nacin
01484339b9
More string cleanups.
...
Built from https://develop.svn.wordpress.org/trunk@25658
git-svn-id: http://core.svn.wordpress.org/trunk@25575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 18:51:10 +00:00
Andrew Nacin
bc842ab011
This error message should have a period.
...
Built from https://develop.svn.wordpress.org/trunk@25656
git-svn-id: http://core.svn.wordpress.org/trunk@25573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 17:45:09 +00:00
Andrew Nacin
32376e99be
Rollback is not a verb.
...
Built from https://develop.svn.wordpress.org/trunk@25655
git-svn-id: http://core.svn.wordpress.org/trunk@25572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 17:44:09 +00:00
Dion Hulse
55822259df
Automatic Updates: Remove some debug from [25649] See #22704
...
Built from https://develop.svn.wordpress.org/trunk@25651
git-svn-id: http://core.svn.wordpress.org/trunk@25568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-30 00:30:10 +00:00
Dion Hulse
30b921d10e
Automatic Updates: Disable Automatic updates for Mercurial(HG) and Bazaar(bzr) version control systems in addition to Git and SVN. Props jamescollins. See #22704
...
Built from https://develop.svn.wordpress.org/trunk@25650
git-svn-id: http://core.svn.wordpress.org/trunk@25567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-30 00:25:10 +00:00
Dion Hulse
75475ed773
Automatic Updates: Add a rollback functionality upon installation failure, the rollback package will be available for partial-updates for automatic updates and be similar to our existing partial builds (but in reverse).
...
A further iteration of this is to also detect whitescreens (fatals) after a auto update, and trigger the rollback for that too.
See #22704
Built from https://develop.svn.wordpress.org/trunk@25649
git-svn-id: http://core.svn.wordpress.org/trunk@25566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-30 00:21:09 +00:00
Dion Hulse
7ed4059230
MD5 file verification: Prevent md5_file() warnings when files don't exist, additionally, don't verify wp-content files as they can be updated separately, as well as WP_CONTENT_DIR being set elsewhere. See #22704 See #18201
...
Built from https://develop.svn.wordpress.org/trunk@25648
git-svn-id: http://core.svn.wordpress.org/trunk@25565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-29 23:08:09 +00:00
Dion Hulse
6e9ba8be22
Automatic Updates: Skip doing the sanity checking MD5 before deciding if we should use a partial build or not, This change means we always use a partial build for automatic updates. See #22704
...
Built from https://develop.svn.wordpress.org/trunk@25647
git-svn-id: http://core.svn.wordpress.org/trunk@25564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-29 23:00:09 +00:00
Drew Jaynes
39d7e0df8a
Improve inline documentation for Walker_Nav_Menu
, Walker_Nav_Menu_Edit
, Walker_Nav_Menu_Checklist
.
...
Includes previously undocumented parameters.
See #23406 .
Built from https://develop.svn.wordpress.org/trunk@25643
git-svn-id: http://core.svn.wordpress.org/trunk@25560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 21:02:09 +00:00
Drew Jaynes
858343ed71
Inline documentation for Walker_Category_Checklist
.
...
See #23406 .
Built from https://develop.svn.wordpress.org/trunk@25642
git-svn-id: http://core.svn.wordpress.org/trunk@25559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 18:08:10 +00:00
Andrew Nacin
e3798dc013
Fix strict notice. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25635
git-svn-id: http://core.svn.wordpress.org/trunk@25552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 06:33:10 +00:00
Andrew Nacin
00d2c39c48
Changes to automatic background updates in preparation for Beta 1.
...
* Show a notice for beta testers on update-core.php explaining the status of their install. Three possibilities: auto updates are enabled, auto updates are disabled because the install doesn't support SSL HTTP requests, and auto updates are disabled because it is a VCS checkout.
* Improve the output of the email, for maximum debugging potential. Failures are clearly labeled and the email leads testers to the support forums and Trac.
* Try to create wp-content/languages in the upgrader if it doesn't exist. Our mkdir isn't recursive, so trying to create wp-content/languages/plugins could fail.
* Abstract out version control checkout determination into a public method. The filter is now auto_upgrade_is_vcs_checkout, still subject to change.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25633
git-svn-id: http://core.svn.wordpress.org/trunk@25550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-27 23:21:10 +00:00
Drew Jaynes
2befec291f
Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php.
...
Props naomicbush.
Fixes #25357 .
Built from https://develop.svn.wordpress.org/trunk@25630
git-svn-id: http://core.svn.wordpress.org/trunk@25547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-26 02:48:09 +00:00
Helen Hou-Sandí
9d5c2eb55f
Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170 .
...
Built from https://develop.svn.wordpress.org/trunk@25608
git-svn-id: http://core.svn.wordpress.org/trunk@25525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 20:23:10 +00:00
Andrew Nacin
00c545606e
Introduce wp_get_user_contact_methods() as a public version of _wp_get_user_contactmethods.
...
props johnnyb.
fixes #24273 .
Built from https://develop.svn.wordpress.org/trunk@25606
git-svn-id: http://core.svn.wordpress.org/trunk@25523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 18:14:09 +00:00
Dion Hulse
7669224311
Automatic Updates: Correct a typo of a constant, s/DISABLE_FILE_MODS/DISALLOW_FILE_MODS/. See #22704
...
Built from https://develop.svn.wordpress.org/trunk@25599
git-svn-id: http://core.svn.wordpress.org/trunk@25516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 07:16:09 +00:00
Dion Hulse
65caf043c0
Automatic Core Updates: Enable Core Automatic Updates for Security releases, Development nightly releases, and, Language packs. See #22704
...
For more information on Automatic Core Updates, See #22704 and http://wp.me/p2AvED-1Lo
Built from https://develop.svn.wordpress.org/trunk@25598
git-svn-id: http://core.svn.wordpress.org/trunk@25515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 03:36:09 +00:00