ryelle
afc3958ab1
Twenty Twenty-One: Add the px unit to the admin bar height custom property.
...
The admin bar height custom property is used in `calc` functions, which require consistent unit use, even when the value is zero. A unitless value returns an invalid value for the "height" property, where this variable is used. This also changes the stylelint rule in the theme to allow zero values with a unit, just in custom properties.
Props nico23.
Fixes #52564 .
Built from https://develop.svn.wordpress.org/trunk@50388
git-svn-id: http://core.svn.wordpress.org/trunk@49999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 20:46:09 +00:00
desrosj
02701a5060
Build/Test Tools: Update actions within test workflows to the latest versions.
...
This updates two published GitHub actions to their latest versions:
- `actions/setup-node` from `v1` to `v2`.
- `styfle/cancel-workflow-action` from `0.5.0` to `0.8.0`.
See #50401 .
Built from https://develop.svn.wordpress.org/trunk@50387
git-svn-id: http://core.svn.wordpress.org/trunk@49998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 18:47:05 +00:00
ryelle
6e895528e7
Customizer: Bring admin color schemes back into the customizer.
...
In #50547 , the admin color schemes were added to the customizer UI, but at some point specificity changed and the colors were overridden by the defaults. This brings the color schemes back into the customizer, using the button color as a highlight, with the link color for text to keep things readable.
Follow up to [48371].
Props audrasjb, peterwilsoncc.
Fixes #52230 .
Built from https://develop.svn.wordpress.org/trunk@50386
git-svn-id: http://core.svn.wordpress.org/trunk@49997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 16:51:05 +00:00
ryelle
369c43ff2e
Administration: Apply background color to updated message in plugin list table.
...
Follow-up to [50025].
Props afragen.
Fixes #52452 .
Built from https://develop.svn.wordpress.org/trunk@50385
git-svn-id: http://core.svn.wordpress.org/trunk@49996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 15:16:03 +00:00
Sergey Biryukov
c9220d8cab
Tests: Rename stick_post()
and unstick_post()
tests for a bit more clarity.
...
Add missing DocBlock for `test_unstick_post_updates_option()`.
Follow-up to [50380].
See #52007 .
Built from https://develop.svn.wordpress.org/trunk@50384
git-svn-id: http://core.svn.wordpress.org/trunk@49995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 12:04:02 +00:00
Sergey Biryukov
488ebec933
External Libraries: Revert the change to the tb_click()
function in the Thickbox library.
...
The `blur()` method there is not the jQuery method, but is an HTML DOM method instead.
This makes the Close button on the "View details" modal on Plugins screen functional again.
Follow-up to [50367].
Props afragen.
See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50383
git-svn-id: http://core.svn.wordpress.org/trunk@49994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 11:28:06 +00:00
Peter Wilson
9bc5ccb4a5
Editor: Additional tests for reusable blocks.
...
Ensure that subsequent renders of a reusable block will render correctly and that recursively inserting a reusable block into itself does not cause an internal server (500) error.
Props bernhard-reiter, SergeyBiryukov.
Fixes #52364 .
Built from https://develop.svn.wordpress.org/trunk@50382
git-svn-id: http://core.svn.wordpress.org/trunk@49993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-18 01:13:02 +00:00
Peter Wilson
c6af819b3a
Site Health: Use home page for loopback test.
...
Use `home_url()` for asynchronous loopback test to ensure correct results on sites with WordPress installed elsewhere, for example WordPress in a sub-directory.
Props Levdbas.
Fixes #52547 .
Built from https://develop.svn.wordpress.org/trunk@50381
git-svn-id: http://core.svn.wordpress.org/trunk@49992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 23:10:04 +00:00
Peter Wilson
23ca4ed304
Posts/Post Types: Prevent duplicates in sticky posts option.
...
In `unstick_post()` if a post ID is duplicated in the `sticky_posts` option remove all instances.
In both `stick_post()` and `unstick_post()` check for duplicate IDs already stored in the `sticky_post` option and remove them if the option is updated.
Props rahmohn, archon810.
Fixes #52007 .
Built from https://develop.svn.wordpress.org/trunk@50380
git-svn-id: http://core.svn.wordpress.org/trunk@49991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 22:58:05 +00:00
John Blackbourn
64b43a44db
Build/Test Tools: Split the single site and Multisite PHPUnit test runs on CI into separate jobs so they run in parallel.
...
This reduces the total duration of the test suite from ~26 minutes to ~16 minutes. Hurrah!
Fixes #52548
Built from https://develop.svn.wordpress.org/trunk@50379
git-svn-id: http://core.svn.wordpress.org/trunk@49990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 19:33:07 +00:00
John Blackbourn
dd53775247
Comments: Revert the introduction of the opt-in comment approval notification feature.
...
This reverts the following commits: [50113], [50112], [50109].
See #33717
Built from https://develop.svn.wordpress.org/trunk@50375
git-svn-id: http://core.svn.wordpress.org/trunk@49986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 13:08:05 +00:00
Sergey Biryukov
dcbe3cb7b8
Privacy: Suggest wp_add_privacy_policy_content()
as an alternative for the deprecated wp_get_default_privacy_policy_content
hook.
...
Follow-up to [50161].
See #49264 .
Built from https://develop.svn.wordpress.org/trunk@50374
git-svn-id: http://core.svn.wordpress.org/trunk@49985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 12:45:04 +00:00
Sergey Biryukov
f331ff5a7a
Docs: Correct the alternative hook name for the deprecated whitelist_options
hook.
...
Follow-up to [48121].
See #51800 .
Built from https://develop.svn.wordpress.org/trunk@50373
git-svn-id: http://core.svn.wordpress.org/trunk@49984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 12:42:03 +00:00
Sergey Biryukov
3fbc0e5a9b
Docs: Correct the type of $widget_id
argument in is_active_widget()
.
...
See #51800 .
Built from https://develop.svn.wordpress.org/trunk@50372
git-svn-id: http://core.svn.wordpress.org/trunk@49983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 11:48:12 +00:00
Sergey Biryukov
a9d04adf20
Robots: Rename wp_embed_no_robots
to wp_robots_noindex_embeds()
.
...
This brings the naming in line with `wp_robots_noindex_search()`.
Follow-up to [49992], [50370].
See #51511 , #52457 .
Built from https://develop.svn.wordpress.org/trunk@50371
git-svn-id: http://core.svn.wordpress.org/trunk@49982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-17 10:51:04 +00:00
Peter Wilson
b51a707468
General: Add noindex
robots meta tag to search results.
...
Prevent search engines indexing internal search results to protect against reflected web spam attacks.
Props abagtcs, audrasjb, ayeshrajans, burtrw, johnbillion, jonoaldersonwp, peterwilsoncc, poena, sabernhardt, xkon.
Fixes #52457
Built from https://develop.svn.wordpress.org/trunk@50370
git-svn-id: http://core.svn.wordpress.org/trunk@49981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 23:38:06 +00:00
John Blackbourn
a4493bf242
Post WordPress 5.7 Beta 3 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@50369
git-svn-id: http://core.svn.wordpress.org/trunk@49980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 21:20:05 +00:00
John Blackbourn
65e9e123ed
WordPress 5.7 beta 3.
...
Built from https://develop.svn.wordpress.org/trunk@50368
git-svn-id: http://core.svn.wordpress.org/trunk@49979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:57:05 +00:00
Sergey Biryukov
8080762e93
External Libraries: Further fix jQuery deprecations in WordPress core.
...
This addresses `JQMIGRATE` warnings in some admin files and the Thickbox library.
Follow-up to [50001], [50270].
Props bordoni, poena.
See #51812 .
Built from https://develop.svn.wordpress.org/trunk@50367
git-svn-id: http://core.svn.wordpress.org/trunk@49978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:25:03 +00:00
Sergey Biryukov
c4da0c6fc2
Twenty Nineteen: Add some space between the cookies checkbox and label in comment form.
...
Props sabernhardt, garrett-eclipse, mukesh27, monikarao, Boniu91.
Fixes #46601 .
Built from https://develop.svn.wordpress.org/trunk@50365
git-svn-id: http://core.svn.wordpress.org/trunk@49976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:15:05 +00:00
ryelle
455bc37c68
Twenty Twenty-One: Remove background color from Social Links the dark gray style.
...
This block variation doesn't support custom colors, so allowing a background color leads to a mismatch between frontend and editor styles.
Props poena, paaljoachim, audrasjb.
Fixes #52499 .
Built from https://develop.svn.wordpress.org/trunk@50364
git-svn-id: http://core.svn.wordpress.org/trunk@49975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:12:02 +00:00
Sergey Biryukov
b50e49f5c1
Accessibility: Taxonomy: Correct keyboard navigation for the Tags meta box in classic editor.
...
Props sabernhardt, almendron, jose64, alexstine, joedolson, ryokuhi.
Fixes #52408 .
Built from https://develop.svn.wordpress.org/trunk@50363
git-svn-id: http://core.svn.wordpress.org/trunk@49974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:04:07 +00:00
Sergey Biryukov
e99d544215
Administration: Apply the months_dropdown_results
filter separately from pre_months_dropdown_query
.
...
Follow-up to [50163].
Props hellofromTonya.
Fixes #51660 .
Built from https://develop.svn.wordpress.org/trunk@50362
git-svn-id: http://core.svn.wordpress.org/trunk@49973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:58:05 +00:00
Sergey Biryukov
070dcd980b
Twenty Ten: Correct the fallback to the default header if the featured image width is narrower than the twentyten_header_image_width
setting.
...
Follow-up to [45581].
Props sabernhardt, macmanx, audrasjb.
Fixes #52516 .
Built from https://develop.svn.wordpress.org/trunk@50361
git-svn-id: http://core.svn.wordpress.org/trunk@49972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:28:04 +00:00
Sergey Biryukov
9aaa579f0d
Twenty Eleven: Correct the fallback to the default header if the featured image width is narrower than the twentyeleven_header_image_width
setting.
...
Follow-up to [45581].
Props sabernhardt, macmanx, audrasjb.
See #52516 .
Built from https://develop.svn.wordpress.org/trunk@50360
git-svn-id: http://core.svn.wordpress.org/trunk@49971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:26:06 +00:00
Sergey Biryukov
95094becee
Twenty Twenty: Make sure the RTL list styles are preserved after npm run build
.
...
Adjust the padding value for better consistency.
Props desrosj, sabernhardt, ryelle, mukesh27.
Fixes #52401 .
Built from https://develop.svn.wordpress.org/trunk@50359
git-svn-id: http://core.svn.wordpress.org/trunk@49970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:11:05 +00:00
ryelle
5f56591fe5
Bundled Themes: Fix alignment and styles for quote, verse, and code blocks.
...
Updates older themes to fix alignment, spacing, and font issues to better match the frontend display. Applies to themes: Twenty Eleven, Twenty Thirteen, Twenty Fourteen, Twenty Sixteen, Twenty Seventeen, and Twenty Twenty.
Props burnuser, talldanwp, cristinasoponar, poena, kjellr
Fixes #52009 .
Built from https://develop.svn.wordpress.org/trunk@50358
git-svn-id: http://core.svn.wordpress.org/trunk@49969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:59:04 +00:00
John Blackbourn
6cb1eaa583
Posts, Post Types: Update the styling of the legacy Links editing screen.
...
This brings its styling inline with other meta boxes in the admin area.
Props antonlukin, kburgoine, grzim, sabernhardt, pbiron, audrasjb
Fixes #48782
Built from https://develop.svn.wordpress.org/trunk@50357
git-svn-id: http://core.svn.wordpress.org/trunk@49968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:50:03 +00:00
Sergey Biryukov
dbaee6b550
Filesystem API: Make sure to only call fread()
on non-empty files in the PclZip library.
...
This avoids a fatal error on PHP 8 caused by passing a zero value to `fread()` as the `$length` argument, which must be greater than zero.
Props yakimun, fierevere, jrf, DavidAnderson, SergeyBiryukov.
Fixes #52018 .
Built from https://develop.svn.wordpress.org/trunk@50355
git-svn-id: http://core.svn.wordpress.org/trunk@49966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:42:03 +00:00
John Blackbourn
f955bcce54
Feeds: Fix the URL returned by get_feed_link()
when pretty permalinks are not in use.
...
Props hauvong, peterwilsoncc, SergeyBiryukov
Fixes #51839
Built from https://develop.svn.wordpress.org/trunk@50354
git-svn-id: http://core.svn.wordpress.org/trunk@49965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 17:34:04 +00:00
Sergey Biryukov
ec94c354e2
XML-RPC: Pass the method arguments and the XML-RPC server instance to the xmlrpc_call
action.
...
This provides better context and makes the action easier to use when the call passes specific content in the payload of the request.
Props dd32.
Fixes #52524 .
Built from https://develop.svn.wordpress.org/trunk@50353
git-svn-id: http://core.svn.wordpress.org/trunk@49964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 17:03:05 +00:00
joedolson
7b5e14e987
Media: Associate upload errors and field with controls.
...
Adds an explicit relationship between the upload button and the maximum upload limit, moves focus to the error dismiss button if an error occurs, and adds a call to wp.a11y.speak to report the error after it occurs.
Props afercia, anevins, antpb, adamsilverstein, poena
Fixes #47120
Built from https://develop.svn.wordpress.org/trunk@50352
git-svn-id: http://core.svn.wordpress.org/trunk@49963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 04:05:07 +00:00
Peter Wilson
147852757c
Twenty Twenty-One: Display inline-images inline.
...
Remove `display: block` property from inline images and display them center aligned vertically.
Props jeroenrotty, melchoyce, mukesh27, paaljoachim, poena, talldanwp.
Fixes #52287 .
Built from https://develop.svn.wordpress.org/trunk@50351
git-svn-id: http://core.svn.wordpress.org/trunk@49962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 02:26:08 +00:00
Peter Wilson
49f0fc9e53
Twenty Twenty-One: Match bullets between editor and frontend.
...
Change bullet style on frontend nested unordered lists to `circle` to match the editor styles.
Props poena, mukesh27, mahfuz01, tejwanihemant.
Fixes #52412 .
Built from https://develop.svn.wordpress.org/trunk@50350
git-svn-id: http://core.svn.wordpress.org/trunk@49961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:52:04 +00:00
Peter Wilson
3ed24991ba
Bundled Themes: Synchronise .gitignore
with themes' svn ignore property.
...
Add `node_modules` directories within Twenty Twenty-One, Twenty Twenty and Twenty Nineteen to the `.gitignore` file.
Fixes #52502 .
Built from https://develop.svn.wordpress.org/trunk@50349
git-svn-id: http://core.svn.wordpress.org/trunk@49960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:19:07 +00:00
Peter Wilson
8665ca27cc
Twenty Twenty-One: Add CSS source map files to committed files.
...
Remove `*.css.map` files from the ignore properties of Twenty Twenty-One directories, add the unignored files.
Props poena, peterwilsoncc.
Fixes #52377 .
Built from https://develop.svn.wordpress.org/trunk@50348
git-svn-id: http://core.svn.wordpress.org/trunk@49959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:11:07 +00:00
ryelle
0e7386521b
Bundled Themes: Support font size option for code block.
...
Adds font-size support to Twenty Fourteen, Twenty Sixteen, and Twenty Seventeen.
Props poena, paaljoachim, peterwilsoncc.
Fixes #52431 .
Built from https://develop.svn.wordpress.org/trunk@50347
git-svn-id: http://core.svn.wordpress.org/trunk@49958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 18:56:04 +00:00
ryelle
ec38e1434a
Twenty Thirteen: Fix alignment of child blocks within the Cover block.
...
Props kjellr, melchoyce.
Fixes #51224 .
Built from https://develop.svn.wordpress.org/trunk@50346
git-svn-id: http://core.svn.wordpress.org/trunk@49957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 18:33:05 +00:00
Sergey Biryukov
18a16e0a91
Tests: Rename two classes in phpunit/tests/http/
to match the function names.
...
See #51802 .
Built from https://develop.svn.wordpress.org/trunk@50345
git-svn-id: http://core.svn.wordpress.org/trunk@49956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 14:07:06 +00:00
Sergey Biryukov
0bbe650e69
Tests: Add missing @covers
tags for files in phpunit/tests/http/
.
...
Props patopaiar, jrf.
See #39265 .
Built from https://develop.svn.wordpress.org/trunk@50344
git-svn-id: http://core.svn.wordpress.org/trunk@49955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 14:02:07 +00:00
youknowriad
e276187b9a
Block Editor: Update packages with bug fixes to be included in WP 5.7 beta 3.
...
The updated packages are:
@wordpress/block-directory: 1.18.6 -> 1.18.7
@wordpress/block-editor: 5.2.6 -> 5.2.7
@wordpress/block-library: 2.28.3 -> 2.28.4
@wordpress/edit-post: 3.26.6 -> 3.26.7
@wordpress/editor: 9.25.6 -> 9.25.7
@wordpress/format-library: 1.26.6 -> 1.26.7
@wordpress/reusable-blocks: 1.1.6 -> 1.1.7
Props isabel_brison.
Fixes #52525 .
Built from https://develop.svn.wordpress.org/trunk@50343
git-svn-id: http://core.svn.wordpress.org/trunk@49954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 08:29:31 +00:00
Sergey Biryukov
f1d362a2f3
Tests: Rename classes in phpunit/tests/hooks/
per the naming conventions.
...
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization
Follow-up to [47780], [48911], [49327], [50291], [50292].
See #51802 .
Built from https://develop.svn.wordpress.org/trunk@50342
git-svn-id: http://core.svn.wordpress.org/trunk@49953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-14 12:22:02 +00:00
Sergey Biryukov
2d9dc11508
Tests: Add missing @covers
tags for files in phpunit/tests/hooks/
.
...
Props patopaiar, jrf.
See #39265 .
Built from https://develop.svn.wordpress.org/trunk@50341
git-svn-id: http://core.svn.wordpress.org/trunk@49952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-14 12:11:08 +00:00
Dominik Schilling
4491708fd1
Docs: Improve parameter types for various URL functions and filters that also accept null
.
...
See #51800 .
Built from https://develop.svn.wordpress.org/trunk@50340
git-svn-id: http://core.svn.wordpress.org/trunk@49951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 15:16:08 +00:00
Sergey Biryukov
96edb89edb
Tests: Add missing @covers
tags for files in phpunit/tests/general/
.
...
Props patopaiar, jrf.
See #39265 .
Built from https://develop.svn.wordpress.org/trunk@50339
git-svn-id: http://core.svn.wordpress.org/trunk@49950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 13:49:03 +00:00
Sergey Biryukov
8fdd713cb2
Tests: Simplify @covers
tags in editor/wpEditors.php
using @coversDefaultClass
annotation.
...
Follow-up to [50288].
See #39265 .
Built from https://develop.svn.wordpress.org/trunk@50338
git-svn-id: http://core.svn.wordpress.org/trunk@49949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 13:47:11 +00:00
Sergey Biryukov
e56a6d1a71
Tests: Use @ticket
annotation for ticket numbers, for clarity.
...
See #51802 .
Built from https://develop.svn.wordpress.org/trunk@50337
git-svn-id: http://core.svn.wordpress.org/trunk@49948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 12:19:06 +00:00
gziolo
fde749f4e4
Tests: Fix failing unit test for block settings
...
Follow-up to [50297].
Fixes #52512 .
Built from https://develop.svn.wordpress.org/trunk@50300
git-svn-id: http://core.svn.wordpress.org/trunk@49945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:41:03 +00:00
desrosj
00e80bf777
Build/Test Tools: Run xDebug tests on PHP 8.0.
...
The PHP 8 Docker container for the local WordPress environment now contains xDebug 3.x (the version required for running on PHP 8), so the `xdebug` test group can now be run.
See #50401 , #51802 .
Built from https://develop.svn.wordpress.org/trunk@50299
git-svn-id: http://core.svn.wordpress.org/trunk@49944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:38:04 +00:00
desrosj
741e056ed7
Build/Test Tools: Run automated testing when tags are created.
...
This expands the list of events that triggers automated testing to include tags.
It also refines the matched version ranges for several workflows.
See #50401 .
Built from https://develop.svn.wordpress.org/trunk@50298
git-svn-id: http://core.svn.wordpress.org/trunk@49943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:03:10 +00:00