Scott Taylor
9bdbd50ac0
In general-template.php
- remove dead code:
...
* In `get_calendar()`, `$cache` is set twice. The first is useless.
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary.
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28274
git-svn-id: http://core.svn.wordpress.org/trunk@28102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:58:16 +00:00
Scott Taylor
dd73ad4299
In edit_form_image_editor()
, $filename
and $title
are set and then unused. They shall be removed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28271
git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:45:16 +00:00
Andrew Nacin
962e8113ab
Customizer: Only tie header button action events to the header controls.
...
props danielbachhuber.
fixes #28046 . see #27848 .
Built from https://develop.svn.wordpress.org/trunk@28269
git-svn-id: http://core.svn.wordpress.org/trunk@28097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:30:23 +00:00
Scott Taylor
644024dfc4
Dead code in wp-admin/includes/file.php
:
...
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28268
git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:22:14 +00:00
Andrew Nacin
6295631a4b
Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers.
...
props rzen, ehg.
fixes #27848 .
Built from https://develop.svn.wordpress.org/trunk@28266
git-svn-id: http://core.svn.wordpress.org/trunk@28094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:14:14 +00:00
Scott Taylor
00b03fe04f
Remove duplicate variable setting for $link
in wp_list_authors()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28265
git-svn-id: http://core.svn.wordpress.org/trunk@28093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:52:15 +00:00
Scott Taylor
3d7a4e6798
Remove unused variable setting for $revisions
in wp_prepare_revisions_for_js()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28264
git-svn-id: http://core.svn.wordpress.org/trunk@28092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:45:14 +00:00
Scott Taylor
21379dcde0
Remove a dead variable, $start
, from wp_dashboard_recent_comments()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28263
git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:35:14 +00:00
Andrew Nacin
f44e4226fa
Move 'home' option to the top of populate_options().
...
fixes #28141 .
Built from https://develop.svn.wordpress.org/trunk@28260
git-svn-id: http://core.svn.wordpress.org/trunk@28088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 21:57:14 +00:00
Scott Taylor
b663fffe24
Add .dfxp
and .srt
files to mime-type whitelist in wp_get_mime_types()
. They are both captioning formats supported by MediaElement.
...
Props joedolson.
Fixes #27643 .
Built from https://develop.svn.wordpress.org/trunk@28259
git-svn-id: http://core.svn.wordpress.org/trunk@28087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 20:08:16 +00:00
Scott Taylor
511145b418
When $type
is atom
in get_the_category_rss()
, use get_bloginfo_rss( 'url' )
when setting the scheme
attribute for the <category>
node.
...
Props ejdanderson.
Fixes #24444 .
Built from https://develop.svn.wordpress.org/trunk@28258
git-svn-id: http://core.svn.wordpress.org/trunk@28086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 19:05:14 +00:00
Scott Taylor
5e7ac8de94
Remove by-reference modifiers from arguments in wp_remote_retrieve_*
functions.
...
Props jesin.
Fixes #27687 .
Built from https://develop.svn.wordpress.org/trunk@28257
git-svn-id: http://core.svn.wordpress.org/trunk@28085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 18:46:15 +00:00
Sergey Biryukov
751e624ff7
Deprecate unused argument of delete_plugins(). Clarify @return value.
...
props jdgrimes for initial patch.
fixes #28111 .
Built from https://develop.svn.wordpress.org/trunk@28256
git-svn-id: http://core.svn.wordpress.org/trunk@28084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 10:24:15 +00:00
Sergey Biryukov
13cbcc92cf
Fix closing tag in image editor.
...
props t4k1s.
fixes #28130 .
Built from https://develop.svn.wordpress.org/trunk@28255
git-svn-id: http://core.svn.wordpress.org/trunk@28083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 10:17:19 +00:00
Sergey Biryukov
db4423c5cd
Avoid displaying a negative number of plugin updates in admin menu.
...
fixes #28073 .
Built from https://develop.svn.wordpress.org/trunk@28254
git-svn-id: http://core.svn.wordpress.org/trunk@28082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 09:39:17 +00:00
Sergey Biryukov
997cbaa03c
Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.
...
props GaVrA.
fixes #28124 .
Built from https://develop.svn.wordpress.org/trunk@28253
git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 08:26:24 +00:00
Scott Taylor
f90a558df4
In WP_Date_Query::get_sql_for_subquery()
, don't parse duplicate parameters - only parse one of w
and week
or month
and monthnum
.
...
Adds unit tests.
Props oso96_2000, ChriCo.
Fixes #25835 .
Built from https://develop.svn.wordpress.org/trunk@28252
git-svn-id: http://core.svn.wordpress.org/trunk@28080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 23:07:14 +00:00
Scott Taylor
a2067a7324
Set the proper value for wp_title()
when is_author()
and is_post_type_archive()
are both true. post_type
should always win due to the precedence indicated in get_queried_object()
.
...
Props mordauk.
Fixes #25398 .
Built from https://develop.svn.wordpress.org/trunk@28251
git-svn-id: http://core.svn.wordpress.org/trunk@28079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 22:21:22 +00:00
Sergey Biryukov
2c97f4640b
Prevent 'Page %s' from being added to page title on 404 error pages in bundled themes.
...
props psoluch, rob1n.
fixes #16468 .
Built from https://develop.svn.wordpress.org/trunk@28250
git-svn-id: http://core.svn.wordpress.org/trunk@28078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:28 +00:00
Sergey Biryukov
0b08cd7a25
Prevent 'paged-*' from being added to body classes on 404 error pages.
...
props psoluch.
see #16468 .
Built from https://develop.svn.wordpress.org/trunk@28249
git-svn-id: http://core.svn.wordpress.org/trunk@28077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:15 +00:00
Sergey Biryukov
9998560152
Twenty Fourteen: Avoid a PHP notice in Ephemera widget.
...
props jartes.
fixes #28055 .
Built from https://develop.svn.wordpress.org/trunk@28248
git-svn-id: http://core.svn.wordpress.org/trunk@28076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 18:46:17 +00:00
Drew Jaynes
a5366db845
Improve inline documentation for the wpdb::$show_errors property.
...
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.
Props ericlewis.
Fixes #16615 .
Built from https://develop.svn.wordpress.org/trunk@28243
git-svn-id: http://core.svn.wordpress.org/trunk@28071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 12:19:15 +00:00
Sergey Biryukov
7214648764
Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu().
...
props Tmeister.
fixes #27745 .
Built from https://develop.svn.wordpress.org/trunk@28242
git-svn-id: http://core.svn.wordpress.org/trunk@28070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:59:14 +00:00
Sergey Biryukov
3ad1c8897c
Correct 'show_in_menu' parameter description in register_taxonomy().
...
fixes #27943 .
Built from https://develop.svn.wordpress.org/trunk@28241
git-svn-id: http://core.svn.wordpress.org/trunk@28069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:29:13 +00:00
Sergey Biryukov
58dcece494
Correct @return value for current_time().
...
props arnee.
fixes #27940 .
Built from https://develop.svn.wordpress.org/trunk@28240
git-svn-id: http://core.svn.wordpress.org/trunk@28068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:25:15 +00:00
Dominik Schilling
e6644720f9
Color Picker: Close color picker when clicking outside of them and when opening another one.
...
props mattwiebe.
fixes #25539 .
Built from https://develop.svn.wordpress.org/trunk@28239
git-svn-id: http://core.svn.wordpress.org/trunk@28067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:18:15 +00:00
Dominik Schilling
c7adbde777
Update jQuery to 1.11.1.
...
fixes #28103 .
Built from https://develop.svn.wordpress.org/trunk@28238
git-svn-id: http://core.svn.wordpress.org/trunk@28066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 09:29:16 +00:00
Sergey Biryukov
e9e2cf05d8
Twenty Eleven: Correct description for twentyeleven_theme_options_render_page().
...
props ericlewis.
fixes #28057 .
Built from https://develop.svn.wordpress.org/trunk@28237
git-svn-id: http://core.svn.wordpress.org/trunk@28065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 00:43:16 +00:00
Sergey Biryukov
d882dc9782
Fix arrow positioning in "Insert/edit link" modal.
...
props avryl, sergej.mueller.
fixes #28096 .
Built from https://develop.svn.wordpress.org/trunk@28236
git-svn-id: http://core.svn.wordpress.org/trunk@28064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 21:21:15 +00:00
Dominik Schilling
8e7e53b22e
Widgets: Toggle widget arrow when widget is open/closed.
...
props MikeHansenMe.
fixes #26748 .
Built from https://develop.svn.wordpress.org/trunk@28235
git-svn-id: http://core.svn.wordpress.org/trunk@28063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 14:09:16 +00:00
Dominik Schilling
a0086bd102
Quick Draft: Use text cursor for description label.
...
fixes #27766 .
Built from https://develop.svn.wordpress.org/trunk@28234
git-svn-id: http://core.svn.wordpress.org/trunk@28062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 13:12:16 +00:00
Andrew Nacin
ba0168819c
Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets.
...
props gcorne.
props Clorith, jorbin for tests.
see #27907 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@28223
git-svn-id: http://core.svn.wordpress.org/trunk@28051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 03:37:13 +00:00
Andrew Nacin
9f00179c58
Improve TinyMCE string for paste command browser support.
...
props ebinnion.
fixes #27988 .
Built from https://develop.svn.wordpress.org/trunk@28220
git-svn-id: http://core.svn.wordpress.org/trunk@28050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 21:20:14 +00:00
Dominik Schilling
20c10c5e2c
Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.
...
Add tests.
see #27936 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28219
git-svn-id: http://core.svn.wordpress.org/trunk@28049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 20:25:19 +00:00
Dominik Schilling
b6e3942bdd
Revert [28217].
...
Misfired commit for #27936 .
Built from https://develop.svn.wordpress.org/trunk@28218
git-svn-id: http://core.svn.wordpress.org/trunk@28048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 20:18:16 +00:00
Dominik Schilling
1849473907
Recent Posts Widget: Use ob_end_flush()
instead of ob_flush()
.
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28217
git-svn-id: http://core.svn.wordpress.org/trunk@28047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 14:21:15 +00:00
Drew Jaynes
058ff61dec
Mark the $hook
and $page_hook
hooks as @internal
to skip parsing.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28216
git-svn-id: http://core.svn.wordpress.org/trunk@28046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:54:21 +00:00
Drew Jaynes
d77e78d685
Clean up duplicate hook notations and adjacency for calls to the wp_signup_location
filter.
...
Also adds braces missed in [25535].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28215
git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:12:14 +00:00
Drew Jaynes
8161668689
Ensure the wp_set_comment_status
action hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28214
git-svn-id: http://core.svn.wordpress.org/trunk@28044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:55:14 +00:00
Drew Jaynes
029dd247be
Ensure the wp_edit_nav_menu_walker
filter is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28213
git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:50:15 +00:00
Drew Jaynes
ef643d9136
Ensure all duplicate calls of the wp_create_file_in_uploads
filter are labeled as such.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28212
git-svn-id: http://core.svn.wordpress.org/trunk@28042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:46:19 +00:00
Drew Jaynes
a866838b31
Ensure adjacency of a duplicate hook comment for a the_category
filter call.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28211
git-svn-id: http://core.svn.wordpress.org/trunk@28041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:43:16 +00:00
Drew Jaynes
73c851c227
Ensure the submitlink_box
action hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28210
git-svn-id: http://core.svn.wordpress.org/trunk@28040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:34:15 +00:00
Drew Jaynes
aa20678c48
Ensure the style_loader_tag
filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28209
git-svn-id: http://core.svn.wordpress.org/trunk@28039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:29:14 +00:00
Drew Jaynes
05537ab967
Ensure the register
filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28208
git-svn-id: http://core.svn.wordpress.org/trunk@28038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:24:15 +00:00
Drew Jaynes
a9b74e2088
Ensure the nav_menu_meta_box_object
filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28207
git-svn-id: http://core.svn.wordpress.org/trunk@28037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:14:15 +00:00
Mark Jaquith
a43313fe12
Use '— Select —' instead of '-- Select --' for nav menus. Looks nicer.
...
see #27878
Built from https://develop.svn.wordpress.org/trunk@28205
git-svn-id: http://core.svn.wordpress.org/trunk@28035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 00:35:25 +00:00
Mark Jaquith
8c830cef80
Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX
...
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.
fixes #27878 for trunk. props westonruter
Built from https://develop.svn.wordpress.org/trunk@28197
git-svn-id: http://core.svn.wordpress.org/trunk@28027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 20:45:31 +00:00
Dominik Schilling
77beef348d
Recent Posts Widget: Use ob_end_flush()
instead of ob_flush()
.
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28195
git-svn-id: http://core.svn.wordpress.org/trunk@28025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 19:48:19 +00:00
John Blackbourn
ab041987d3
Remove some unnecessary abstraction introduced in [28191]. See #27985 .
...
Built from https://develop.svn.wordpress.org/trunk@28194
git-svn-id: http://core.svn.wordpress.org/trunk@28024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 11:55:22 +00:00