desrosj
25c841026d
General: More PHP compatibility adjustments.
...
In this round:
- Removed references to `safe_mode` in `class-php3.php`. This was removed in PHP 5.4.
- Add inline exclude comments for compatibility checks in getID3.
Follow up of [47735-47736].
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47737
git-svn-id: http://core.svn.wordpress.org/trunk@47513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 20:12:06 +00:00
desrosj
791e3bdb38
General: Fix typo within phpcs:ignore
inline comment.
...
Follow up of [47735].
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47736
git-svn-id: http://core.svn.wordpress.org/trunk@47512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:36:06 +00:00
desrosj
89ddd19884
General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.
...
As part of the continued effort to improve PHP compatibility, the following improvments are being made:
- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.
Props desrosj, earnjam, dryanpress.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47735
git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:07:09 +00:00
Sergey Biryukov
589666abc3
External Libraries: Revert [47603].
...
With the Docker image for PHP 7.4 updated to stable version, this should no longer be necessary.
See https://github.com/WordPress/wpdev-docker-images/pull/26
Props ocean90.
Fixes #49945 .
Built from https://develop.svn.wordpress.org/trunk@47604
git-svn-id: http://core.svn.wordpress.org/trunk@47379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 15:41:08 +00:00
Sergey Biryukov
e9e5d8e2b2
External Libraries: Comment out magic quote functions in getID3().
...
For some reason, the `version_compare()` check does not work as expected on Travis.
Follow-up to [46113], [47601].
See #49945 .
Built from https://develop.svn.wordpress.org/trunk@47603
git-svn-id: http://core.svn.wordpress.org/trunk@47378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 12:12:06 +00:00
Sergey Biryukov
1bac2cbe66
External Libraries: Backport a commit from getID3() trunk to fix a PHP 7.4+ notice.
...
This addresses a "Trying to access array offset on value of type bool" notice in the `getid3_mp3::MPEGaudioHeaderValid()` method.
Props schlessera.
Fixes #49945 .
Built from https://develop.svn.wordpress.org/trunk@47602
git-svn-id: http://core.svn.wordpress.org/trunk@47377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 11:34:07 +00:00
Sergey Biryukov
694bec2071
External Libraries: Update getID3() to 1.9.19.
...
Changelog: https://github.com/JamesHeinrich/getID3/compare/v1.9.18...v1.9.19
Props ayeshrajans, schlessera.
See #49945 .
Built from https://develop.svn.wordpress.org/trunk@47601
git-svn-id: http://core.svn.wordpress.org/trunk@47376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 11:13:07 +00:00
Aaron Jorbin
9ed7b79387
External Library: Update getid3 to 1.9.18
...
Follow up to r46112 as getid3 has tagged an official release.
Changes: 00f3fbfd77
...v1.9.18
Props desrosj, jkitchen.
Fixes #47751 #40883 #43836 .
Built from https://develop.svn.wordpress.org/trunk@46166
git-svn-id: http://core.svn.wordpress.org/trunk@45978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-18 14:54:57 +00:00
Aaron Jorbin
ecd822a880
Comment out magic quote functions
...
Follow up to r46112.
See: #47751,#47783, #48040 .
Built from https://develop.svn.wordpress.org/trunk@46113
git-svn-id: http://core.svn.wordpress.org/trunk@45925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-14 19:23:55 +00:00
Aaron Jorbin
1ed691f574
Update getID3 library to fix issues with PHP7.4
...
Updates to trunk version that includes fixes for PHP7.4
Changelog:
https://github.com/JamesHeinrich/getID3/compare/v1.9.14...00f3fbfd77e583099ca70a3cf0bc092e113d2b20
See: #47751,#47783.
Fixes : #48040 .
Built from https://develop.svn.wordpress.org/trunk@46112
git-svn-id: http://core.svn.wordpress.org/trunk@45924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-14 19:07:57 +00:00
Scott Taylor
6bcf4d6f63
Media: update the getID3
library to version 1.9.14
to avoid fatal errors in PHP7.
...
Props MyThemeShop for the initial patch.
Fixes #41496 .
Built from https://develop.svn.wordpress.org/trunk@41196
git-svn-id: http://core.svn.wordpress.org/trunk@41036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-31 19:50:45 +00:00
Scott Taylor
a59b2ffcae
Update getID3 to 1.9.9
...
Changelog:
* https://github.com/JamesHeinrich/getID3/blob/master/changelog.txt
* https://github.com/JamesHeinrich/getID3/compare/v1.9.8...v1.9.9
Fixes #32806 .
Built from https://develop.svn.wordpress.org/trunk@32979
git-svn-id: http://core.svn.wordpress.org/trunk@32950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 00:17:25 +00:00
Scott Taylor
ac02e9951e
Update getID3 library to 1.9.8.
...
Changes:
https://github.com/JamesHeinrich/getID3/compare/1.9.7...v1.9.8
Fixes #29627 .
Built from https://develop.svn.wordpress.org/trunk@29734
git-svn-id: http://core.svn.wordpress.org/trunk@29508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-11 19:07:17 +00:00
Andrew Nacin
e46e52ec0f
ID3 1.9.7.
...
props wonderboymusic.
fixes #24737 .
git-svn-id: http://core.svn.wordpress.org/trunk@24696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-13 00:37:36 +00:00