Commit Graph

15237 Commits

Author SHA1 Message Date
Dominik Schilling
9fb5c540bb Users: Allow to create users without sending an email to the new user.
This adds a checkbox to `wp-admin/user-new.php` to prevent sending an email with the username and a password reset link to the new user. Restores the behavior of pre-4.3.

Fixes #33504.
Props tharsheblows, SergeyBiryukov, DrewAPicture, ocean90.
Built from https://develop.svn.wordpress.org/trunk@35742


git-svn-id: http://core.svn.wordpress.org/trunk@35706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:38:29 +00:00
Helen Hou-Sandí
e24681632e Avoid potential fatal errors after [35718].
While these classes are intended for admin use, there are developers out there who include `wp-admin/includes/template.php` to access them in other contexts. There is no intention to continue to support this indefinitely, but a breaking change like that would need to happen very early in a cycle and communicated loudly.

In the meantime, if you're reading this commit message and you do the above, please update your code to not do that. Thank you :)

fixes #33413.

Built from https://develop.svn.wordpress.org/trunk@35740


git-svn-id: http://core.svn.wordpress.org/trunk@35704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 22:19:26 +00:00
Scott Taylor
79a2915a9b Upgrade: New themes are not automatically installed on upgrade. This can still be explicitly asked for by defining CORE_UPGRADE_SKIP_NEW_BUNDLED as false.
In `populate_options()`, if the theme specified by `WP_DEFAULT_THEME` doesn't exist, fall back to the latest core default theme. If we can't find a core default theme, `WP_DEFAULT_THEME` is the best we can do. 

Props nacin, jeremyfelt, dd32.
See #34306.

Built from https://develop.svn.wordpress.org/trunk@35738


git-svn-id: http://core.svn.wordpress.org/trunk@35702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-25 21:45:25 +00:00
Dominik Schilling
7f3082491d Passwords: Re-enable password fields before submitting the form.
Avoids an PHP undefined notice when creating new users.

Fixes #33699.
Built from https://develop.svn.wordpress.org/trunk@35733


git-svn-id: http://core.svn.wordpress.org/trunk@35697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-24 21:17:27 +00:00
Sergey Biryukov
60c8e272f5 Docs: Improve DocBlock formatting for add_menu_page() and add_submenu_page() wrappers.
See #34360.
Built from https://develop.svn.wordpress.org/trunk@35731


git-svn-id: http://core.svn.wordpress.org/trunk@35695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:56:26 +00:00
Helen Hou-Sandí
2cdeac7cf6 Pass the $post object as context to postmeta_form_keys.
see #33885, #18979.

Built from https://develop.svn.wordpress.org/trunk@35730


git-svn-id: http://core.svn.wordpress.org/trunk@35694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:15:29 +00:00
Gary Pendergast
d04396d0ad Docs: Replace a reference to WP.org with WordPress.org.
Built from https://develop.svn.wordpress.org/trunk@35729


git-svn-id: http://core.svn.wordpress.org/trunk@35693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 22:38:26 +00:00
Andrew Ozz
91759029e9 TinyMCE: fix the regexp used to protect line breaks inside script and pre tags to match <script> that load external scripts.
Fixes #34760.
Built from https://develop.svn.wordpress.org/trunk@35727


git-svn-id: http://core.svn.wordpress.org/trunk@35691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 19:13:28 +00:00
Sergey Biryukov
ae04eba0b6 Comments: After [35670], change the CSS class for the pending comments count back to moderated.
Fixes #34680.
Built from https://develop.svn.wordpress.org/trunk@35726


git-svn-id: http://core.svn.wordpress.org/trunk@35690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 15:23:26 +00:00
Sergey Biryukov
bc1e479fd0 After [35718], update the location of some files in This filter is documented in docs.
Partially reverts [33954].

Fixes #33413.
Built from https://develop.svn.wordpress.org/trunk@35725


git-svn-id: http://core.svn.wordpress.org/trunk@35689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 03:51:28 +00:00
Sergey Biryukov
17af54fc7c Customizer: Use correct context and translator comments for menu location strings.
See #33431.
Built from https://develop.svn.wordpress.org/trunk@35722


git-svn-id: http://core.svn.wordpress.org/trunk@35686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 17:46:25 +00:00
Helen Hou-Sandí
277747f944 Postbox handle buttons don't need a focus outline.
see #33808, #34242.

Built from https://develop.svn.wordpress.org/trunk@35721


git-svn-id: http://core.svn.wordpress.org/trunk@35685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 15:56:25 +00:00
Andrew Nacin
1579e45d41 Simplify the include graph after work to split out classes.
see #33413. More details there.

Built from https://develop.svn.wordpress.org/trunk@35718


git-svn-id: http://core.svn.wordpress.org/trunk@35682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 07:24:30 +00:00
Helen Hou-Sandí
e549e56f02 Custom fields: Allow for short-circuiting the meta key dropdown.
Adds the `postmeta_form_keys` filter which allows for a potentially expensive query against postmeta to be avoided.

props ericmann, tollmanz, nacin.
see #33885.

Built from https://develop.svn.wordpress.org/trunk@35717


git-svn-id: http://core.svn.wordpress.org/trunk@35681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:16:50 +00:00
Sergey Biryukov
cc7736a024 ru_RU: In back-compat styles for admin menu, inherit the width from the parent element, #adminmenuwrap, to account for media queries.
See #20974.
Built from https://develop.svn.wordpress.org/trunk@35712


git-svn-id: http://core.svn.wordpress.org/trunk@35676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 01:40:25 +00:00
Sergey Biryukov
3418279862 ru_RU: After [35710], remove fixed width for admin menu, as it does not account for media queries.
See #20974.
Built from https://develop.svn.wordpress.org/trunk@35711


git-svn-id: http://core.svn.wordpress.org/trunk@35675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 01:04:25 +00:00
Sergey Biryukov
a1116d9534 Add some back-compat styles for ru_RU.
This prevents the admin menu from disappearing if an old `ru_RU.php` file is left over after updating directly from 3.1.x or an older version to the latest release.

See #20974.
Built from https://develop.svn.wordpress.org/trunk@35710


git-svn-id: http://core.svn.wordpress.org/trunk@35674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 00:36:27 +00:00
Helen Hou-Sandí
f6651352d9 Color picker: update to the new button style.
props paulwilde.
fixes #34734.

Built from https://develop.svn.wordpress.org/trunk@35703


git-svn-id: http://core.svn.wordpress.org/trunk@35667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 14:37:33 +00:00
Boone Gorges
f173cdfb18 On 4.4 upgrade, remove the unused 'add_users' cap from all roles.
Fixes #16719.
Built from https://develop.svn.wordpress.org/trunk@35701


git-svn-id: http://core.svn.wordpress.org/trunk@35665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 03:53:28 +00:00
Scott Taylor
a99f7baa5a List Tables: Fix PHP error notice when $columns is null
Use of `register_column_headers()` and `print_column_headers()` creates a `_WP_List_Table_Compat` without any columns. When the List Table object doesn't have any columns, there's naturally no primary column.

Props danielbachhuber.
Fixes #34148.

Built from https://develop.svn.wordpress.org/trunk@35698


git-svn-id: http://core.svn.wordpress.org/trunk@35662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:01:26 +00:00
Jeremy Felt
f7b29ecd1b Multisite: Re-Account for striped table rows with .site-* classes.
[34356] removed the table row specificity on rules for `.site-deleted`, `.site-spammed`, `.site-archived`, and `.site-matured` so that the styles would be properly applied to other elements. Now, the zebra striping rules override these styles on even rows.

We can account for `tr` specific and more generic applications of these classes.

Fixes #33595.

Built from https://develop.svn.wordpress.org/trunk@35692


git-svn-id: http://core.svn.wordpress.org/trunk@35656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:59:26 +00:00
Boone Gorges
b17cb707dc Eliminate a db query when building the admin menu for non-privileged users.
Users who cannot `edit_posts` do not see the Comments nav item anyway, so
don't bother running a query that gets a comment count to display in the menu.

Props bordoni, johnbillion.
Fixes #19372.
Built from https://develop.svn.wordpress.org/trunk@35691


git-svn-id: http://core.svn.wordpress.org/trunk@35655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:34:26 +00:00
Aaron Jorbin
e8d8e79371 Revert [34291] bringing back my-hacks
Keeping myhacks support is a small price to pay for not breaking people's sites.  Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.

https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.

Fixes #33741.



Built from https://develop.svn.wordpress.org/trunk@35688


git-svn-id: http://core.svn.wordpress.org/trunk@35652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:49:26 +00:00
Dominik Schilling
c25efe2d52 Revert [35336] and [35337].
See #28344.
Built from https://develop.svn.wordpress.org/trunk@35685


git-svn-id: http://core.svn.wordpress.org/trunk@35649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:30:25 +00:00
Aaron Jorbin
d507b5636f Set cssmin compatibility to ie7
This matches the autoprefixer setting. This changes all compiled CSS.

Fixes #34540.
Props christophherr, peterwilsoncc, netweb


Built from https://develop.svn.wordpress.org/trunk@35684


git-svn-id: http://core.svn.wordpress.org/trunk@35648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:28:25 +00:00
Scott Taylor
19834a4c21 List Tables: After [35622] and [34271], improve pagination logic when queries are altered.
Props bradyvercher.
Fixes #29870.

Built from https://develop.svn.wordpress.org/trunk@35683


git-svn-id: http://core.svn.wordpress.org/trunk@35647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:25:26 +00:00
Scott Taylor
af0498989c List Tables: After [34728], don't try to infer orderby from query params.
List tables are really good.

Props cklosows.
Fixes #25493.

Built from https://develop.svn.wordpress.org/trunk@35682


git-svn-id: http://core.svn.wordpress.org/trunk@35646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:19:26 +00:00
Scott Taylor
8caf5d9759 Plugins: add dismissible notices to update failures.
Adds unit test.

Props afercia, mehulkaklotar.
Fixes #33465.

Built from https://develop.svn.wordpress.org/trunk@35681


git-svn-id: http://core.svn.wordpress.org/trunk@35645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:10:26 +00:00
Scott Taylor
f2e9e98fa6 Media: in media_send_to_editor(), use wp_json_encode() instead of addslashes().
Props TobiasBg.
Fixes #22135.

Built from https://develop.svn.wordpress.org/trunk@35677


git-svn-id: http://core.svn.wordpress.org/trunk@35641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:40:27 +00:00
Scott Taylor
838592c1ba List Tables: because we can never eradicate the existence of globals, ensure that $comment is hoisted into the global space inside WP_Comments_List_Table::single_row().
Fixes #34654.

Built from https://develop.svn.wordpress.org/trunk@35674


git-svn-id: http://core.svn.wordpress.org/trunk@35638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:05:30 +00:00
Scott Taylor
f0bbe00890 After [35616], improve the consistency of tabs styling.
Props afercia.
Fixes #34214.

Built from https://develop.svn.wordpress.org/trunk@35673


git-svn-id: http://core.svn.wordpress.org/trunk@35637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:55:26 +00:00
Sergey Biryukov
bc41f44158 I18N: After [34424], replace the placeholder with comments count after translate_nooped_plural() runs, not before.
Props hnle.
Fixes #34680.
Built from https://develop.svn.wordpress.org/trunk@35670


git-svn-id: http://core.svn.wordpress.org/trunk@35634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:04:28 +00:00
Drew Jaynes
283b7d0a66 Plugins: Rename the delete_plugin action hook (introduced in [35094]) to deleted_plugin as it fires ''following'' a plugin deletion attempt.
Further, introduce a new `delete_plugin` action hook, to be fired ''before'' a plugin deletion attempt. Both changes bring parity with other such transactional hooks in core that fire before and after certain actions, including on plugin activation/deactivation and install/uninstall, among others.

Props johnjamesjacoby.
Fixes #26904.

Built from https://develop.svn.wordpress.org/trunk@35669


git-svn-id: http://core.svn.wordpress.org/trunk@35633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:58:26 +00:00
Sergey Biryukov
0d4cf36199 I18N: Remove <a> tag from translatable string in wp-admin/includes/class-wp-comments-list-table.php.
Props ramiy.
Fixes #34686.
Built from https://develop.svn.wordpress.org/trunk@35666


git-svn-id: http://core.svn.wordpress.org/trunk@35630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:34:27 +00:00
Sergey Biryukov
7cb5ca6b33 I18N: Remove <a> tag from translatable string in wp-admin/comment.php.
Props ramiy.
See #34686.
Built from https://develop.svn.wordpress.org/trunk@35665


git-svn-id: http://core.svn.wordpress.org/trunk@35629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:33:30 +00:00
Sergey Biryukov
5539193dd0 I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpsockets.php.
Fixes #34684.
Built from https://develop.svn.wordpress.org/trunk@35664


git-svn-id: http://core.svn.wordpress.org/trunk@35628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:23:29 +00:00
Sergey Biryukov
a7c5161db1 I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpext.php.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35663


git-svn-id: http://core.svn.wordpress.org/trunk@35627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:22:27 +00:00
Sergey Biryukov
0237fadd3a I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-base.php.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35662


git-svn-id: http://core.svn.wordpress.org/trunk@35626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:21:26 +00:00
Sergey Biryukov
6b94d7c89c I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ssh2.php.
Props ramiy.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35661


git-svn-id: http://core.svn.wordpress.org/trunk@35625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:18:40 +00:00
Dominik Schilling
9df7c4edea Passwords: Only disable hidden password fields if they are really hidden.
Makes the password field on install and for password resets editable again. Both fields were accidentally set to disabled in [35603].

Props adamsilverstein, flixos90.
Fixes #33699.
Built from https://develop.svn.wordpress.org/trunk@35649


git-svn-id: http://core.svn.wordpress.org/trunk@35613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 20:49:26 +00:00
Dominik Schilling
c29fe96196 Thickbox: Change only the background-image property for HiDPI screens.
`background` resets `background-size` and makes the spinner fuzzy. Introduced in [35418].

See #33311.
Built from https://develop.svn.wordpress.org/trunk@35648


git-svn-id: http://core.svn.wordpress.org/trunk@35612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 20:33:25 +00:00
Dominik Schilling
a7848ea08b Themes: Hide the favorites form when performing a search.
The search is global and ignores the user setting. Same for filters.

See #34206.
Built from https://develop.svn.wordpress.org/trunk@35647


git-svn-id: http://core.svn.wordpress.org/trunk@35611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:50:26 +00:00
Dominik Schilling
99f4fc4404 Themes: Check if the browse view is set in wp_ajax_query_themes() to avoid a PHP notice when searching for new themes.
Introduced in [35527].

See #34206.
Built from https://develop.svn.wordpress.org/trunk@35646


git-svn-id: http://core.svn.wordpress.org/trunk@35610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:47:54 +00:00
Dion Hulse
42ff945649 Decrease the chances that wp_tempnam() will conflict with an existing file by suffixing a random ID to the generated filename.
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.

Fixes #34562

Built from https://develop.svn.wordpress.org/trunk@35644


git-svn-id: http://core.svn.wordpress.org/trunk@35608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 05:33:25 +00:00
Weston Ruter
acba061485 Customize: Ensure multi-line label alignment for checkbox/radio inputs on both desktop and mobile.
Follow-up to [35608].

Props bordoni, delawski.
Fixes #34607.

Built from https://develop.svn.wordpress.org/trunk@35643


git-svn-id: http://core.svn.wordpress.org/trunk@35607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 04:44:26 +00:00
Dion Hulse
be94558c46 Upgrader: Pass the $args['hook_extra'] context to the upgrader_source_selection filter.
Props afragen
Fixes #34696

Built from https://develop.svn.wordpress.org/trunk@35642


git-svn-id: http://core.svn.wordpress.org/trunk@35606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 02:47:25 +00:00
Dominik Schilling
40b303069a Schema: Increase length of user_pass and user_activation_key fields to 255.
Props grvrulz and Miglosh for testing.
Fixes #33904.
Built from https://develop.svn.wordpress.org/trunk@35638


git-svn-id: http://core.svn.wordpress.org/trunk@35602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-15 14:19:28 +00:00
Helen Hou-Sandí
ae9e173082 Buttons: Standardize on .button-link for link-like buttons.
This serves as both a reset and some basic styling. The class name also aligns with parallel components in other popular projects.

props paulwilde for the initial patch.
fixes #34242.

Built from https://develop.svn.wordpress.org/trunk@35636


git-svn-id: http://core.svn.wordpress.org/trunk@35600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-13 15:47:27 +00:00
Sergey Biryukov
95c55ca251 Cast 'illegal_user_logins' filter result to array.
See #27317.
Built from https://develop.svn.wordpress.org/trunk@35630


git-svn-id: http://core.svn.wordpress.org/trunk@35594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:34:27 +00:00
Sergey Biryukov
b08ae1d60b Users: After [35189], make 'illegal_user_logins' check case-insensitive.
Props juliobox.
Fixes #27317.
Built from https://develop.svn.wordpress.org/trunk@35629


git-svn-id: http://core.svn.wordpress.org/trunk@35593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:30:28 +00:00