Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 14:45:45 +01:00
Code Issues Projects Releases Wiki Activity
40,920 Commits 50 Branches 748 Tags 792 MiB
9fc09b2720
Commit Graph

60 Commits

Author SHA1 Message Date
Sergey Biryukov
001ffe81fb Docs: Improve inline comments per the documentation standards. 
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:45:18 +00:00
Sergey Biryukov
e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation. 
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-03 00:41:05 +00:00
Gary Pendergast
4803fc405e Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45590


git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 23:42:58 +00:00
Adam Silverstein
b287642342 Feeds: improve structure and naming of feed build date helper function. 
Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming `get_last_build_date` to `get_feed_build_date`.

Props pento, spacedmonkey.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@45247


git-svn-id: http://core.svn.wordpress.org/trunk@45056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 17:08:52 +00:00
Sergey Biryukov
373a759c6b Feeds: Amend [45208] to avoid phpcs:ignore. 
See #46922.
Built from https://develop.svn.wordpress.org/trunk@45215


git-svn-id: http://core.svn.wordpress.org/trunk@45024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 15:46:52 +00:00
Sergey Biryukov
f25f241573 Feeds: Remove whitespace from <updated> elements in Atom feeds. 
Per Atom format's RFC, there must not be any whitespace in a Date construct or in any IRI.

Props josephwa.
Fixes #46922.
Built from https://develop.svn.wordpress.org/trunk@45208


git-svn-id: http://core.svn.wordpress.org/trunk@45017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 00:46:51 +00:00
Adam Silverstein
4268033aaf Feeds: ensure build/update date matches current query. 
Displaying the correct build date in feeds is as important today as it was twelve years ago when this ticket was opened.

Fix an issue where all feeds in WordPress showed the same date for their last build date (the datapoint is `lastBuildDate`, `updated` or `dc:date` depending on the feed type). 

Introduce a new `get_last_build_date` filter to adjust the date used for `lastBuildDate`. Developers who previously filtered `get_lastcommentmodified` to alter feed dates should use this filter instead.

* `get_last_build_date` extracts the latest post (or comment) in the current WP_Query object.
* In all feed templates, use `get_last_build_date` vs `get_lastpostmodified( 'GMT' );`.

Props stevenkword, spacedmonkey, ryanshoover, mauteri, nacin, jorbin, MikeNGarrett, Denis-de-Bernardy, peaceablewhale.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@44948


git-svn-id: http://core.svn.wordpress.org/trunk@44779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-20 20:39:00 +00:00
Gary Pendergast
7a617078fa Coding Standards: Upgrade WPCS to 1.2.1. 
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.


Built from https://develop.svn.wordpress.org/trunk@44574


git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Sergey Biryukov
4848a09b35 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders. 
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.

Fixes #43523.
Built from https://develop.svn.wordpress.org/trunk@42827


git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-11 16:44:34 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Dion Hulse
f794939ed3 Feeds: Do not translate the lastBuildDate field in RSS feeds. 
Props stevenkword, dd32.
Fixes #39141

Built from https://develop.svn.wordpress.org/trunk@39613


git-svn-id: http://core.svn.wordpress.org/trunk@39553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-12-16 06:39:41 +00:00
John Blackbourn
4cf5550d8d I18n: Begin introducing translator comments for strings which include placeholders but no accompanying translator comment. 
Adds context to one string used in two different contexts for the new user and new site signup email notification.

More to come.

See #38882

Built from https://develop.svn.wordpress.org/trunk@39323


git-svn-id: http://core.svn.wordpress.org/trunk@39263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-11-21 01:22:32 +00:00
Rachel Baker
2f263fce99 Feeds: Always return a valid timestamp for the Last-Modified header of comment or post feeds. 
Fixes bug where an invalid Last-Modified value would be returned in feed requests for sites that had 0 items to return. Comment or post feeds will now return the current timestamp as the Last-Modified header value.  Example: a request for the comments feed for a site without any comments.

Replaced use of the local static variable `$cache_lastcommentmodified` to store the modified date in `get_lastcommentmodified()` with the Object Cache API.  The `get_lastcommentmodified()` function returns early if there is a cached value and returns `false` if there where no comments found. Introduced `_clear_modified_cache_on_transition_comment_status()` to flush the `lastcommentmodified` cache key when a comment enters or leaves approval status. In `get_lastpostmodified()` return early if there is a cached value and return `false` if there are no posts found.

Props swissspidy, rachelbaker, dllh, leobaiano.
Fixes #38027.
Built from https://develop.svn.wordpress.org/trunk@38925


git-svn-id: http://core.svn.wordpress.org/trunk@38868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-25 20:48:29 +00:00
Peter Wilson
47d26cd9fb DOCS: Replace HTTP links with HTTPS. 
Replaces unsecure links in documentation and translator comments with their secure versions.

Props johnpgreen, netweb

Fixes #36993

Built from https://develop.svn.wordpress.org/trunk@37674


git-svn-id: http://core.svn.wordpress.org/trunk@37640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-10 04:50:33 +00:00
Konstantin Obenland
c69e96422b Themes: Improve document title output. 
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.


Built from https://develop.svn.wordpress.org/trunk@35294


git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-20 16:21:25 +00:00
Scott Taylor
5c6b63d3a6 if is a statment, not a function. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:01:25 +00:00
Sergey Biryukov
c321e40016 Introduce 'rss_tag_pre' action, which fires between the xml and rss tags in a feed. 
props solarissmoke, wonderboymusic, DrewAPicture.
fixes #19017.
Built from https://develop.svn.wordpress.org/trunk@29014


git-svn-id: http://core.svn.wordpress.org/trunk@28802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 10:18:15 +00:00
Drew Jaynes
88952445cf Inline documentation for hooks in wp-includes/feed-atom-comments.php. 
Props dustyf, piontkowski, kpdesign.
Fixes #26532.

Built from https://develop.svn.wordpress.org/trunk@26863


git-svn-id: http://core.svn.wordpress.org/trunk@26749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-21 20:22:12 +00:00
Andrew Nacin
5361a8abca Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Andrew Nacin
74488bdcb0 Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-22 17:22:11 +00:00
Helen Hou-Sandí
b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665. 
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-20 15:55:32 +00:00
Andrew Nacin
30d048a1e7 Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate. 
props markjaquith, SergeyBiryukov. fixes #21841.



git-svn-id: http://core.svn.wordpress.org/trunk@22431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 19:56:10 +00:00
ryan
29e6ade734 Use get_search_query() in feed-rss2-comments.php. Props SergeyBiryukov. fixes #21365 
git-svn-id: http://core.svn.wordpress.org/trunk@21332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-25 18:04:17 +00:00
nacin
bdd70470e2 Use the site's locale for the feed language. Provides the same result as language_attributes(). Removes the rss_language option. fixes #13440. see #5517. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-29 19:56:33 +00:00
westi
0826f08315 Set up the post global variable in the comment feed loops so that any calls to post related template tags work correctly. 
Ensures that atom feeds show threading for top-level comments correctly.
Fixes #14908 props solarissmoke and SergeyBiryukov.

git-svn-id: http://svn.automattic.com/wordpress/trunk@18716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-19 12:39:59 +00:00
westi
11f0a387cd Some more url escaping in feeds. See #13555. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 17:47:29 +00:00
westi
8b4a635d8b Move the escaping into get_guid() so we don't have to repeat ourselves. See #13555. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 17:27:18 +00:00
westi
b54183ae4c Escape the guid urls when placing them in feeds and other xml locations. See #13555. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 17:01:21 +00:00
nacin
6efe44acbc Have get_search_query() escape by default, like it's echoing counterpart the_search_query(). see #12780 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-03 23:38:38 +00:00
westi
d8490aeea2 Add the generator element in feeds through the {rss2|atom|rdf|rss|opml}_head hooks. Fixes #6947 props sivel. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-13 16:45:16 +00:00
ryan
94859834fc i18n fixes. Props nbachiyski. fixes #11954 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-21 21:37:43 +00:00
ryan
ec8e347792 Introduce home_url(). Props Denis-de-Bernardy, hakre. see #9008 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-04 17:23:29 +00:00
westi
9105b46360 Use _deprecated_argument() in get_bloginfo() and then don't pass deprecated argument to get_bloginfo(). Fixes #11652 props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-30 17:05:02 +00:00
ryan
1354d0660a Don't localize dates where not appropriate. Props Denis-de-Bernardy, hakre. fixes #9730 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-14 02:00:32 +00:00
ryan
c90e3f5f81 Feed namespace hooks. Props Denis-de-Bernardy, peaceablewhale. fixes #9792 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-12 16:57:49 +00:00
markjaquith
6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-05 19:43:53 +00:00
ryan
2d489767bb s/attribute_escape/attr/. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-28 05:58:45 +00:00
ryan
a61bc0ec8a Trailing whitespace cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-20 18:18:39 +00:00
ryan
2724d67ab9 Add comments_atom_head action. Props neoxx, Denis-de-Bernardy. fixes #6186 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-17 07:09:06 +00:00
ryan
ee73ce298c Use guid instead of link for atom comment IDs. fixes #8708 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-20 20:55:03 +00:00
azaozz
3949fb7e90 Add support for automatic feed links in themes, props Viper007Bond, see #8878 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-19 05:04:58 +00:00
ryan
158b45fb7b Add thread xmlns. Props neoxx. fixes #8626 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-17 00:14:58 +00:00
ryan
4483f075d5 ref not rel. Props oddthinking. fixes #8292 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-10 05:51:56 +00:00
ryan
fe44ea7c48 No named entities in comment feeds. Props nbachiyski. fixes #8464 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-04 17:47:50 +00:00
ryan
ed01be1927 Use post_password_required() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-20 19:10:31 +00:00
ryan
5783e5ff6e Add threaded comment info to atom feed. Props dtsn. fixes #8292 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-20 19:08:41 +00:00
ryan
84a3a81bb8 Improve metadata for atom comment search feeds. Props ionfish. fixes #5493 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-13 18:29:10 +00:00
ryan
d88983793b Trailing whitespace cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-05 06:47:27 +00:00