Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 14:45:45 +01:00
Code Issues Projects Releases Wiki Activity
38,997 Commits 50 Branches 748 Tags 792 MiB
9fc53b8461
Commit Graph

101 Commits

Author SHA1 Message Date
Andrea Fercia
3578f89900 Accessibility: Improve the way Internet Explorer 11 and JAWS announce fieldset legends. 
When Internet Explorer encounters a non interactive element with a `tabindex`
attribute, it adds the element to the accessibility tree with a `role=group` and
an accessible name computed from the element. This prevents JAWS from announcing
any fieldset legend within the element.

- removes `tabindex="0"` from the content and the toolbar containers: these tabindex attributes are no longer needed
- removes `aria-label="Main content"` from the content container: not needed
- keeps the media modal focus fallback introduced in [38142] by making the `#wpbody-content` element focusable only when needed

Props stevefaulkner, aardrian.
Fixes #43154.

Built from https://develop.svn.wordpress.org/trunk@44639


git-svn-id: http://core.svn.wordpress.org/trunk@44470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-17 11:55:51 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Gary Pendergast
39a3fe9180 Admin Bar: Fix another HTML error introduced in [42128]. 
Props Otto42.
See #41057.


Built from https://develop.svn.wordpress.org/trunk@42131


git-svn-id: http://core.svn.wordpress.org/trunk@41962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-08 23:13:46 +00:00
Gary Pendergast
e822e4578a Admin Bar: Fix a HTML error introduced in [42128]. 
Props swissspidy.
See #41057.


Built from https://develop.svn.wordpress.org/trunk@42129


git-svn-id: http://core.svn.wordpress.org/trunk@41960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-08 08:52:48 +00:00
Gary Pendergast
bde3b95936 Admin Bar: Reformat the render methods. 
The admin bar render methods use some cute tricks which don't come close to the WordPress coding standards. So that we can more easily apply automated code fixing to the codebase, these tricks need to be removed.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42128


git-svn-id: http://core.svn.wordpress.org/trunk@41959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-08 08:35:51 +00:00
Drew Jaynes
0860bb2771 Docs: Remove @access notations from method DocBlocks in wp-includes/* classes. 
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.

See #41452.

Built from https://develop.svn.wordpress.org/trunk@41162


git-svn-id: http://core.svn.wordpress.org/trunk@41002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-27 00:41:44 +00:00
Drew Jaynes
97ef1ca74b Docs: Add missing deprecation, introduction, and summary information to the DocBlock for WP_Admin_Bar::recursive_render(). 
Props coffee2code.
Fixes #40840.

Built from https://develop.svn.wordpress.org/trunk@40947


git-svn-id: http://core.svn.wordpress.org/trunk@40797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-25 21:58:41 +00:00
Andrea Fercia
7b3445c312 Accessibility: Revert [38984] as it needs to be better communicated to plugin authors. 
See #37513.

Built from https://develop.svn.wordpress.org/trunk@39147


git-svn-id: http://core.svn.wordpress.org/trunk@39087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-11-05 16:28:33 +00:00
Andrea Fercia
7b0abd1cea Accessibility: Hide the Toolbar sub-menu icons from assistive technologies. 
CSS generated content is going to be rendered for speech output more and more in
the next future. When it's not intended to be available for speech output, for
example with font icons, then special care should be used to hide it from
assistive technologies. At the moment, the only reliable way to do this is making 
use of a wrapper element and set `aria-hidden="true"` on it.

Fixes #37513.

Built from https://develop.svn.wordpress.org/trunk@38984


git-svn-id: http://core.svn.wordpress.org/trunk@38927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-27 20:53:30 +00:00
Scott Taylor
0eebbed6b2 General: revert [38467], wp_is_IE() should not exist. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38468


git-svn-id: http://core.svn.wordpress.org/trunk@38409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-31 15:22:31 +00:00
Scott Taylor
021e23e70b General: use a new function, wp_is_IE(), instead of the $is_IE global in a number of places. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38467


git-svn-id: http://core.svn.wordpress.org/trunk@38408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-31 06:42:33 +00:00
Dominik Schilling
f160f2afd1 Toolbar: Allow 0 as a value for the tabindex property of a menu item. 
To enhance accessibility for items without a link you can now define `tabindex="0"`, which makes descendant dropdowns accessible.

Props joedolson, afercia, ocean90.
Fixes #32495.
Built from https://develop.svn.wordpress.org/trunk@38035


git-svn-id: http://core.svn.wordpress.org/trunk@37976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-12 11:18:30 +00:00
Sergey Biryukov
139387b7e5 Docs: Use 3-digit, x.x.x-style semantic versioning for _doing_it_wrong(), _deprecated_function(), _deprecated_argument(), and _deprecated_file() throughout core. 
Props metodiew.
Fixes #36495.
Built from https://develop.svn.wordpress.org/trunk@37985


git-svn-id: http://core.svn.wordpress.org/trunk@37926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-06 12:40:29 +00:00
Drew Jaynes
2802e067a1 Docs: Improve the DocBlock summary and add a missing initial @since version for WP_Admin_Bar::add_node(). 
See #32246. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36833


git-svn-id: http://core.svn.wordpress.org/trunk@36800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-03 15:58:27 +00:00
Pascal Birchler
59351cb62d Toolbar: Allow adding lang and dir attributes to toolbar items. 
This is useful from a multilingual and accessibility perspective.

Props Chouby, leemon.
Fixes #33513.
Built from https://develop.svn.wordpress.org/trunk@35795


git-svn-id: http://core.svn.wordpress.org/trunk@35759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-06 21:37:25 +00:00
Drew Jaynes
d01f1c2e15 Docs: Add missing file headers to two Toolbar API files: wp-includes/admin-bar.php and wp-includes/class-wp-admin-bar.php. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35157


git-svn-id: http://core.svn.wordpress.org/trunk@35123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 17:27:25 +00:00
Helen Hou-Sandí
28c1600e6e Toolbar: Disambiguate links to the dashboard vs. to the customizer. 
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.

Built from https://develop.svn.wordpress.org/trunk@33130


git-svn-id: http://core.svn.wordpress.org/trunk@33101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-08 20:03:24 +00:00
Scott Taylor
c502a281bb After [32656], add @access annotations to methods that have no doc block in wp-includes/*. 
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32657


git-svn-id: http://core.svn.wordpress.org/trunk@32627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:37:24 +00:00
Scott Taylor
bd8fafea54 Use void instead of null where appropriate when pipe-delimiting @return types. If a @return only contains void, remove it. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32568


git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:40:25 +00:00
Scott Taylor
f7098c8c2e In class-wp-admin-bar.php, clarify/add some doc blocks. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32534


git-svn-id: http://core.svn.wordpress.org/trunk@32504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:39:24 +00:00
Dominik Schilling
a7ba89b027 Accessibility: Add landmark roles to WordPress admin areas. 
props afercia, joedolson.
fixes #31450.
Built from https://develop.svn.wordpress.org/trunk@31955


git-svn-id: http://core.svn.wordpress.org/trunk@31934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 13:17:27 +00:00
Scott Taylor
0a4af6d45c In wp-includes/class-wp-admin-bar.php, break is unreachabled after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28318


git-svn-id: http://core.svn.wordpress.org/trunk@28146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:29:15 +00:00
Drew Jaynes
d2014cfce3 Convert argument array documentation to the hash-notation style for WP_Admin_Bar::add_node() and WP_Admin_Bar::add_group(). 
Fixes #27258.

Built from https://develop.svn.wordpress.org/trunk@27370


git-svn-id: http://core.svn.wordpress.org/trunk@27220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 06:11:13 +00:00
Andrew Nacin
83a0b00489 Accept rel attributes in the toolbar's add_node() method. 
props stephcook22.
fixes #27234.

Built from https://develop.svn.wordpress.org/trunk@27367


git-svn-id: http://core.svn.wordpress.org/trunk@27217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 02:14:13 +00:00
Matt Thomas
2adf09fea9 Bring in the responsive component of MP6. See #25858. 
* Makes the admin fully responsive down to 320px wide.
* Adds a touch-optimized main menu that can be opened and closed from the toolbar.
* Size and positioning adjustments to icons, buttons, and text elements for better touch usability.

A few changes since MP6:

* Removed jQuery mobile. This script was used to add swipe controls to open/close the sidebar menu. This feature was apparently buggy and due to the pending demise of jQuery mobile, it was removed.
* Removed use of Backbone.js. Adding Backbone.js to this script would add a dependency of Backbone.js for all of the admin. Additionally, it was used to add a menu item. Instead of doing that, it was added via the admin menu API. This also fixes a bad delay in the item showing in the menu.
* CSS layout is standardized. Comments have also been cleaned up.
* Jetpack and Akismet code is removed.
* RTL CSS is removed.
* JS passes hinting other than one small issue that will likely be removed when parts of the code are reviewed.

A number of areas for improvement remain; we're tracking these issues in the comments of #25858.

Props to tollmanz, tillkruess, helen, dd32, and apeatling.


Built from https://develop.svn.wordpress.org/trunk@26134


git-svn-id: http://core.svn.wordpress.org/trunk@26046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-13 18:00:10 +00:00
Andrew Nacin
70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository. 
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-25 02:29:52 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Ryan Boren
b87d4b77e5 Pinking shears 
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-23 14:38:10 +00:00
Drew Jaynes
fda48c2462 Improve inline comment for removing default padding styles for the Toolbar. 
Props nofearinc.
Fixes #25373.

Built from https://develop.svn.wordpress.org/trunk@25563


git-svn-id: http://core.svn.wordpress.org/trunk@25481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-22 14:34:11 +00:00
Sergey Biryukov
794414c412 Correct @since for hooks in wp-includes/class-wp-admin-bar.php. see #25229. 
Built from https://develop.svn.wordpress.org/trunk@25478


git-svn-id: http://core.svn.wordpress.org/trunk@25399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-18 11:58:19 +00:00
Peter Westwood
b3689b7a35 Inline documentation for hooks in wp-includes/class-wp-admin-bar.php 
See #25229 props betzster

Built from https://develop.svn.wordpress.org/trunk@25475


git-svn-id: http://core.svn.wordpress.org/trunk@25396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-18 07:42:09 +00:00
Andrew Nacin
5f1a1eb77c Don't render the screen reader shortcut 'Log Out' link in the toolbar when the user is not logged in. 
props SergeyBiryukov.
fixes #23178.



git-svn-id: http://core.svn.wordpress.org/trunk@24442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-19 08:15:04 +00:00
Andrew Ozz
769e1236af Skip To links: visually hide by only setting top: -1000em; (this should make them work well in all screen readers), fixes #21312 
git-svn-id: http://core.svn.wordpress.org/trunk@22730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-20 21:14:49 +00:00
Andrew Ozz
e8b10439bb Accessibility shortcuts: new looks and fix for the WebKit focus bug, props lessbloat, fixes #21471 
git-svn-id: http://core.svn.wordpress.org/trunk@22249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-16 21:26:59 +00:00
Andrew Nacin
1d46178afd Remove the @return for WP_Admin_Bar::remove_node(). props scribu. fixes #20906. 
git-svn-id: http://core.svn.wordpress.org/trunk@21608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-24 17:34:52 +00:00
azaozz
4ef4df2f3e Accessibility: add off-screen Log Out link in the toolbar, tweak the class names of the accessible links in #adminbar, see #21312 
git-svn-id: http://core.svn.wordpress.org/trunk@21452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-06 00:34:44 +00:00
azaozz
6bf5d66d5b Add "Skip to toolbar" accessibility shortcut, see #21471 
git-svn-id: http://core.svn.wordpress.org/trunk@21423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-05 18:41:52 +00:00
nacin
189e833139 Admin bar: When calling add_node() for an existing node, all properties should be merged into the existing arguments, including individual meta arguments. Corrects a logic inversion. fixes #21117. 
git-svn-id: http://core.svn.wordpress.org/trunk@21259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-10 21:26:35 +00:00
nacin
6cb67e8817 Tabs, not spaces for intendation. Add a docblock to the file/class. 
git-svn-id: http://core.svn.wordpress.org/trunk@21257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-10 20:32:48 +00:00
nacin
4664d4bed8 Don't output empty class names or ones with leading/trailing spaces. props MattyRob for the initial patch. fixes #20698. 
git-svn-id: http://core.svn.wordpress.org/trunk@21193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-30 11:47:21 +00:00
azaozz
1d12cd07b0 Introduce wp_is_mobile() and use it instead of $is_iphone global, see #20014 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-10 01:19:30 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
nacin
aa3cf9d286 Make sure that _render() is only called with a valid root object. As in, render() can only be validly called once and must not fail on the second call. props SergeyBiryukov, see #19642 for trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-30 23:04:28 +00:00
ryan
d295e6e600 Introduce user-actions group and move profile and logout menu items to it and change priority. Props koopersmith. fixes #19425 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-06 03:51:58 +00:00
ryan
06a1675a3c Admin bar API improvements. Props koopersmith. fixes #19416 #19371 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-06 03:42:11 +00:00
ryan
0112c9d628 Don't drop dollars. see #19426 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-06 00:46:03 +00:00
ryan
a39bffbadb Add back compat support for my-account-with-avatar admin bar node id. fixes #19426 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-06 00:31:11 +00:00
azaozz
f6047c397e Remove role="menu" and role="menuitem" for now, fixes #19394 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-05 17:47:23 +00:00
koopersmith
74e1b3ea68 Remove the shortlink item from the toolbar, but keep the function for plugins. fixes #19407. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-01 03:25:54 +00:00
koopersmith
39ac39ef2c In toolbar, move search item to the right of the account menu and make it icon-only. fixes #19370, #19406. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-01 03:03:12 +00:00