Commit Graph

72 Commits

Author SHA1 Message Date
Andrea Fercia
c443d45708 Admin: Ensure notices with the below-h2 class are not repositioned after [35238].
Keeps the `.below-h2` class for backwards compatibility with plugins that are (incorrectly) using it. Plugins should use `.inline` instead.

Props stephenharris.
Fixes #34570. See #34294.
Built from https://develop.svn.wordpress.org/trunk@35516


git-svn-id: http://core.svn.wordpress.org/trunk@35480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:27:26 +00:00
Scott Taylor
e525ab849d Administration: the current admin menu item should have an aria-haspopup attribute when the menu is folded.
Unify the jQuery selector caching for `window`, `document`, and `body`.

Props afercia.
Fixes #32578.

Built from https://develop.svn.wordpress.org/trunk@35313


git-svn-id: http://core.svn.wordpress.org/trunk@35279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:41:24 +00:00
Ella Iseulde Van Dorpe
47e364de42 Admin: fix repositioning notices
Fixes #34294.
Props afercia.

Built from https://develop.svn.wordpress.org/trunk@35238


git-svn-id: http://core.svn.wordpress.org/trunk@35204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:04:26 +00:00
Scott Taylor
28964445d4 Admin: when toggling select/deselect "all" via JS - :visible needs to be bound to not toggle disabled inputs.
Props tywayne.
Fixes #32309.

Built from https://develop.svn.wordpress.org/trunk@34325


git-svn-id: http://core.svn.wordpress.org/trunk@34289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:41:24 +00:00
Helen Hou-Sandí
0b046085ae Show row actions on focus for the dashboard comment list.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33106


git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:26:24 +00:00
Helen Hou-Sandí
f85306c65a Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.

Built from https://develop.svn.wordpress.org/trunk@33056


git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Helen Hou-Sandí
8eb7f71e6b List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33016


git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:31:25 +00:00
Aaron Jorbin
c9307fc95a Update Grunt dev-dependencies
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).

Props wonderboymusic
See #31700


Built from https://develop.svn.wordpress.org/trunk@32988


git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
Konstantin Obenland
7dc1d06e64 Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Konstantin Obenland
c1a9c4b7b8 Semanticize Help and Screen Options toggle.
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.


Built from https://develop.svn.wordpress.org/trunk@32844


git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 16:36:25 +00:00
Scott Taylor
18827ed337 In wp_ajax_hidden_columns(), don't explode() on an empty string.
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.

Built from https://develop.svn.wordpress.org/trunk@32751


git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:00:25 +00:00
Helen Hou-Sandí
c87224eaf6 List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.

Built from https://develop.svn.wordpress.org/trunk@32724


git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
Helen Hou-Sandí
fbb83441cb After [32644], sanity for a pile of selectors.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32645


git-svn-id: http://core.svn.wordpress.org/trunk@32615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 03:00:26 +00:00
Andrew Ozz
999ae33a2e Widgets:
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes #32094 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32480


git-svn-id: http://core.svn.wordpress.org/trunk@32450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 00:32:31 +00:00
Helen Hou-Sandí
d85f8fe326 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
Helen Hou-Sandí
007665e7be Admin menu: Revert [31720] for swipe open/closed.
This is problematic on any device that uses swipe for history navigation, particularly iOS. It's also quite unrefined from an interaction point of view and would not be material for this release either way.

see #31187.

Built from https://develop.svn.wordpress.org/trunk@31910


git-svn-id: http://core.svn.wordpress.org/trunk@31889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 17:48:30 +00:00
Andrew Ozz
321b551650 Fix focusing in the plugin and theme editors. Update the help.
Props afercia, Cheffheid. Fixes #31415.
Built from https://develop.svn.wordpress.org/trunk@31908


git-svn-id: http://core.svn.wordpress.org/trunk@31887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 22:35:27 +00:00
Andrew Ozz
4eba346517 Allow swiping of the admin menu on touch devices.
Props iseulde, ninnypants. See #31187.
Built from https://develop.svn.wordpress.org/trunk@31720


git-svn-id: http://core.svn.wordpress.org/trunk@31701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 16:29:26 +00:00
Jeremy Felt
0f34b98bcf Reveal row actions on focus in the network users list table.
In the future, we'll re-factor this selector pile in a way that makes things cleaner. See #25408.

Props afercia.

Fixes #31003.

Built from https://develop.svn.wordpress.org/trunk@31674


git-svn-id: http://core.svn.wordpress.org/trunk@31655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 02:27:27 +00:00
Sergey Biryukov
0231047071 Delegate focusin and focusout events for row actions to make sure the actions are always revealed on focus.
props afercia.
fixes #29765.
Built from https://develop.svn.wordpress.org/trunk@31509


git-svn-id: http://core.svn.wordpress.org/trunk@31490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 20:14:25 +00:00
Sergey Biryukov
19e51601ab Revert [31173] and target only taxonomy and link manager tables in keyboard focus code.
props afercia.
fixes #30980.
Built from https://develop.svn.wordpress.org/trunk@31177


git-svn-id: http://core.svn.wordpress.org/trunk@31158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 14:01:22 +00:00
Sergey Biryukov
3ac60370b8 Reveal row actions on focus on taxonomy screens.
props afercia.
fixes #30980.
Built from https://develop.svn.wordpress.org/trunk@31173


git-svn-id: http://core.svn.wordpress.org/trunk@31154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 07:02:22 +00:00
Andrew Ozz
e0189c3686 Move the (recently added) .notice admin notices below the first H2, same as the .updated and .error notices. Props sippis, fixes #30885.
Built from https://develop.svn.wordpress.org/trunk@31023


git-svn-id: http://core.svn.wordpress.org/trunk@31004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 18:52:23 +00:00
Andrew Ozz
ee67cd96be Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize.
See #30692.
Built from https://develop.svn.wordpress.org/trunk@30852


git-svn-id: http://core.svn.wordpress.org/trunk@30842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 00:11:24 +00:00
Andrew Ozz
910bb84c89 Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS.
See #30692.
Built from https://develop.svn.wordpress.org/trunk@30844


git-svn-id: http://core.svn.wordpress.org/trunk@30834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-14 01:47:23 +00:00
John Blackbourn
afd0dd5ece Avoid adjusting the current submenu position when tabbing through the admin menu.
Fixes #30349
Props 5um17

Built from https://develop.svn.wordpress.org/trunk@30352


git-svn-id: http://core.svn.wordpress.org/trunk@30351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 02:22:21 +00:00
Andrew Ozz
ecdc8d3baf Admin menu:
- Fix scrolling the pinned menu with a mouse wheel.
- Fix pinning when the menu is only slightly taller than the viewport.
- Disable pinning on IE8, updating CSS top makes it jump when scrolling with a mouse wheel.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29978


git-svn-id: http://core.svn.wordpress.org/trunk@29724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-21 06:12:20 +00:00
Andrew Ozz
f19ad10571 Admin menu:
- Fix pinning after resizing the window.
- Merge the two DOM ready callbacks in common.js
- Fix the submenus position adjustment on focus.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29898


git-svn-id: http://core.svn.wordpress.org/trunk@29653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 06:05:18 +00:00
Andrew Ozz
f98106769d Pin the admin menu on scrolling similarly to how the side metaboxes are pinned on the Edit Post screen, first run. See #29806.
Built from https://develop.svn.wordpress.org/trunk@29835


git-svn-id: http://core.svn.wordpress.org/trunk@29599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-05 03:09:20 +00:00
Andrew Ozz
0a4d4a3d93 Fix tapping on the menu in iOS and Android, fixes #29365 for trunk
Built from https://develop.svn.wordpress.org/trunk@29770


git-svn-id: http://core.svn.wordpress.org/trunk@29542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-26 23:02:16 +00:00
Dominik Schilling
27e564113d Admin Menu: Auto fold the menu at 960px.
This gives us some more room at the post edit screen.

props vinod dalvi for initial patch.
fixes #28592.
Built from https://develop.svn.wordpress.org/trunk@29518


git-svn-id: http://core.svn.wordpress.org/trunk@29294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 14:15:17 +00:00
Helen Hou-Sandí
448275cce4 Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.

Built from https://develop.svn.wordpress.org/trunk@29280


git-svn-id: http://core.svn.wordpress.org/trunk@29062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 05:26:15 +00:00
Andrew Ozz
9175194785 Fix admin menu open/close issues on some mobile devices, props adamsilverstein, fixes #27980.
Built from https://develop.svn.wordpress.org/trunk@29247


git-svn-id: http://core.svn.wordpress.org/trunk@29031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 18:55:16 +00:00
Scott Taylor
ea42b8e48e Media Grid:
* Move the grid down via CSS transition when the Screen Options slide open.
* Remove some unused CSS for grid options.

See #24716.

Built from https://develop.svn.wordpress.org/trunk@29086


git-svn-id: http://core.svn.wordpress.org/trunk@28872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 05:34:14 +00:00
Scott Taylor
b16d3bd6ad Media Grid: make registering Screen Options for non-list tables more generic.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29079


git-svn-id: http://core.svn.wordpress.org/trunk@28865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:44:16 +00:00
Scott Taylor
a9fb59151b Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29078


git-svn-id: http://core.svn.wordpress.org/trunk@28864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:26:16 +00:00
Scott Taylor
a89060013b Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29077


git-svn-id: http://core.svn.wordpress.org/trunk@28863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:00:17 +00:00
Andrew Ozz
5e4a020ff8 Enhance the editor on the Add/Edit Post screens, first run. Props avril, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29049


git-svn-id: http://core.svn.wordpress.org/trunk@28837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-09 22:06:15 +00:00
Helen Hou-Sandí
831e5aa049 Don't switch contextual help tabs when tabbing around. props neil_pie. see #28209.
Built from https://develop.svn.wordpress.org/trunk@28869


git-svn-id: http://core.svn.wordpress.org/trunk@28669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-27 19:10:16 +00:00
Andrew Nacin
ce1ace6347 Fix flyout menus on most mobile devices.
props ocean90.
fixes #26482.

Built from https://develop.svn.wordpress.org/trunk@27775


git-svn-id: http://core.svn.wordpress.org/trunk@27612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 06:30:14 +00:00
Andrew Ozz
2f6d9d37cc Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854.
Built from https://develop.svn.wordpress.org/trunk@27080


git-svn-id: http://core.svn.wordpress.org/trunk@26953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 05:31:14 +00:00
Scott Taylor
0347a8944e Update the versions of several devDependencies in package.json. grunt-cssjanus has been updated to 0.2.2, we no longer need the fork. Run npm install to receive updates for node_modules in the project root.
Props yoavf, TobiasBg.
Fixes #26073.


Built from https://develop.svn.wordpress.org/trunk@27053


git-svn-id: http://core.svn.wordpress.org/trunk@26927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-29 04:43:30 +00:00
Andrew Ozz
33c41db77a Improve keyboard accessibility for the admin menu when in responsive mode, props SergeyBiryukov, fixes #26639 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27011


git-svn-id: http://core.svn.wordpress.org/trunk@26888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 20:08:11 +00:00
Andrew Ozz
2a68f85fa1 Comment moderation shortcuts:
- Fix "toggle checkboxes" (shift+x).
- Add noDisable selector and use it to stop disabling the shortcuts when a select-comment checkbox is focused.
See #26755.
Built from https://develop.svn.wordpress.org/trunk@26889


git-svn-id: http://core.svn.wordpress.org/trunk@26772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-02 00:11:14 +00:00
Andrew Ozz
95a02fbe43 Fake a "non-responsive" window width for IE < 9 when folding/unfolding the menu (old IE doesn't support @media), fixes #26458.
Built from https://develop.svn.wordpress.org/trunk@26785


git-svn-id: http://core.svn.wordpress.org/trunk@26672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 18:46:11 +00:00
Andrew Ozz
2da2559d26 Responsive menu: fix calculation of the responsive trigger width from JS. It is affected by a vertical scrollbar width in some browsers. See #26458.
Built from https://develop.svn.wordpress.org/trunk@26743


git-svn-id: http://core.svn.wordpress.org/trunk@26632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 20:50:10 +00:00
Andrew Ozz
830bcf9957 Make the responsive menu usable with a mouse, fix non-folded and :focus styles, toggle the submenus on touchend/click. Fixes #26086.
Built from https://develop.svn.wordpress.org/trunk@26516


git-svn-id: http://core.svn.wordpress.org/trunk@26409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:19:11 +00:00
Andrew Ozz
758a07bfd3 Remove cloning of the search box with JS and move it to the bottom of the screen with CSS instead, see #26086
Built from https://develop.svn.wordpress.org/trunk@26421


git-svn-id: http://core.svn.wordpress.org/trunk@26321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 22:19:14 +00:00
Andrew Ozz
b8984636c2 Clean up the sticky menu and responsive tweaks JS:
- More descriptive names.
- Share cached jQuery elements.
- Fix re-enabling of touch events on the admin menu.
- Fix disabling/enabling of UI Sortable.
Props tollmanz, props sanchothefat, see #26086, fixes #26088.
Built from https://develop.svn.wordpress.org/trunk@26402


git-svn-id: http://core.svn.wordpress.org/trunk@26302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 08:57:10 +00:00
Andrew Nacin
d7423a466e Residual JSHint fixes in common.js and edit-comments.js.
see #25912, #25979.

Built from https://develop.svn.wordpress.org/trunk@26208


git-svn-id: http://core.svn.wordpress.org/trunk@26116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 06:37:09 +00:00