Commit Graph

17 Commits

Author SHA1 Message Date
atimmer
f6a37e7d39 Docs: Remove @summary tags from JSDoc.
As decided in the JavaScript core chat. With a few reasons:

* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.

The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.

Props herregroen.
Fixes #42901.

Built from https://develop.svn.wordpress.org/trunk@42411


git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00
atimmer
1f707de9dd Docs: Improve wp-admin JSDoc structural data globally.
JSDoc takes it structural data from `@namespace`, `@lends` and `@memberOf`. This change fixes these tags for all JavaScript files in the wp-admin folder.

* Add jsdoc configuration to parse wp-admin/js files. Use `jsdoc -c jsdoc.conf.json` to generate JSDoc.
* Define all used namespaces using `@namespace`.
* Define each usage of the extend function as a prototype assignment using `@lends`.
* Add `@alias` if JSDoc cannot detect the correct name automatically.

This has previously been corrected for all `wp-includes` JavaScript files: [41351].

Props herregroen.
Fixes #42485.

Built from https://develop.svn.wordpress.org/trunk@42403


git-svn-id: http://core.svn.wordpress.org/trunk@42232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-15 13:42:46 +00:00
Peter Wilson
f617a2d6d9 Comments: Modernise JavaScript for comment reply links.
Update the comment reply JavaScript to be unobtrusive and use events rather than inline `onclick` attributes. 

Along with bringing the code into the 2010s this prevents an edge-case in which `addComment.moveForm()` could be called before the JavaScript has loaded.

Props peterwilsoncc, bradparbs.
Fixes #31590.

Built from https://develop.svn.wordpress.org/trunk@42360


git-svn-id: http://core.svn.wordpress.org/trunk@42189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-03 22:37:45 +00:00
Scott Taylor
10177e7fbb Docs: improve JS docs for comment-reply.js
Props andizer, ireneyoast.
Fixes #41548.

Built from https://develop.svn.wordpress.org/trunk@41314


git-svn-id: http://core.svn.wordpress.org/trunk@41145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-24 17:58:44 +00:00
Scott Taylor
f1d0763785 Comments: after [35593], extend support to IE8 and improve checking for elements hidden with CSS
Props afercia.
Fixes #29974.

Built from https://develop.svn.wordpress.org/trunk@35675


git-svn-id: http://core.svn.wordpress.org/trunk@35639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:15:28 +00:00
Andrea Fercia
e6e4496822 Comments: in comment_form() when replying to a comment ensure to set focus on the first focusable form element, regardless of what that form element is.
Props azaozz.
See #29974.
Built from https://develop.svn.wordpress.org/trunk@35593


git-svn-id: http://core.svn.wordpress.org/trunk@35557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-10 00:43:26 +00:00
Andrew Nacin
a87fec4616 Fix JSHint errors in six files.
props mdbitz.
fixes ##26011, #26012, #26013, #26014, #26038, #26039.

Built from https://develop.svn.wordpress.org/trunk@26195


git-svn-id: http://core.svn.wordpress.org/trunk@26103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 04:42:09 +00:00
Andrew Nacin
2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
azaozz
a750885c8e Minify all js and add the non-minified files as .dev.js
git-svn-id: http://svn.automattic.com/wordpress/trunk@10291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-02 15:08:58 +00:00
azaozz
1dca6a90ec Enable support for threaded comments and comment reply on index page, props yoavf, fixes #8550
git-svn-id: http://svn.automattic.com/wordpress/trunk@10169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-10 11:49:37 +00:00
azaozz
9ce8d0f70e Use no-js reply on error in comment-reply.js, see #7635
git-svn-id: http://svn.automattic.com/wordpress/trunk@9114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-09 20:27:39 +00:00
azaozz
c506412ad6 No jQuery requirement for comment-reply.js, see #7635
git-svn-id: http://svn.automattic.com/wordpress/trunk@9113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-09 11:11:56 +00:00
azaozz
2bd7d9960d No-JS mode for replying to comments and some improvements/cleanup of comment-reply.js, includes patch by Viper007Bond, see #7635
git-svn-id: http://svn.automattic.com/wordpress/trunk@9112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-09 07:37:05 +00:00
azaozz
90792c9a3d Move all of comment-reply.js to jQuery + trim filesize in half, props Viper007Bond, see #7635
git-svn-id: http://svn.automattic.com/wordpress/trunk@9082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-04 06:11:33 +00:00
ryan
eef17ba0a5 Hide reply link by default. Enable with JS. Props Viper007Bond. see #7635
git-svn-id: http://svn.automattic.com/wordpress/trunk@9037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-30 17:27:15 +00:00
ryan
dcf62be039 Add respondID and respondRoot args to cancelCommentReply(). see #7635
git-svn-id: http://svn.automattic.com/wordpress/trunk@8877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-12 21:19:40 +00:00
ryan
5828310157 wp_list_comments() and threaded comment support. First cut. see #7635
git-svn-id: http://svn.automattic.com/wordpress/trunk@8869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-11 19:25:50 +00:00