Commit Graph

15646 Commits

Author SHA1 Message Date
Jeremy Felt
ced66ed4e7 Multisite: Use the admin-multisite Dashicon for sites
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37365


git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 17:13:26 +00:00
Jeremy Felt
db3d5a6bea Revert [37362], which incorrectly changed Dashicons CSS
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.

Built from https://develop.svn.wordpress.org/trunk@37364


git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:29:27 +00:00
Helen Hou-Sandí
610215ceb1 Revive grunt-rtlcss, which does not appear to enjoy syntax errors.
props netweb.
see #36753, #29792.

Built from https://develop.svn.wordpress.org/trunk@37363


git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:22:27 +00:00
Jeremy Felt
172af4e0ce Multisite: Use the admin-multisite Dashicon in the admin menu and bar
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37362


git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 04:29:26 +00:00
Helen Hou-Sandí
a800cf654b Drop Open Sans in the admin in favor of system fonts.
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37361


git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 22:07:37 +00:00
Drew Jaynes
ebfc1467bb Links: Rename the $link_id parameter in get_link_to_edit() to $link to better reflect that it can accept a link ID or object.
Props tloureiro for the initial patch.
Fixes #36736.

Built from https://develop.svn.wordpress.org/trunk@37353


git-svn-id: http://core.svn.wordpress.org/trunk@37319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:43:27 +00:00
Drew Jaynes
3470faa683 Links: Clarify documentation for the $link_id parameter to mention that it accepts either an integer or object.
Props tloureiro.
See #36736.

Built from https://develop.svn.wordpress.org/trunk@37351


git-svn-id: http://core.svn.wordpress.org/trunk@37317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:40:27 +00:00
Weston Ruter
3a37220f2a Customize: Allow Esc key to collapse the currently-expanded panel, section (or control).
Pressing Esc collapses any expanded widget or nav menu item controls, or any control that implements the expanding interface. Also improves alignment between `WidgetControl` and `MenuItemControl`, adding the `expanded` state and associated `expand`/`collapse` methods to nav menu items.

Props purcebr, celloexpressions, westonruter.
Fixes #22237.

Built from https://develop.svn.wordpress.org/trunk@37347


git-svn-id: http://core.svn.wordpress.org/trunk@37313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:52:28 +00:00
Weston Ruter
a0d7e83beb Customize: Ensure settings modified during an open save request remain dirty when save request completes.
Also disables Save & Publish button while save request is open. After the save request completes, any settings changed during the request can then be saved via an additional click to the button.

Props chandrapatel, westonruter.
Fixes #32941.

Built from https://develop.svn.wordpress.org/trunk@37346


git-svn-id: http://core.svn.wordpress.org/trunk@37312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:13:26 +00:00
Drew Jaynes
fe3b007fdd Docs: Remove inline @see tags from function, class, and method references in inline docs.
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.

Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@37342


git-svn-id: http://core.svn.wordpress.org/trunk@37308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 04:00:28 +00:00
Dominik Schilling
9354965638 Customize: Increase the target size of the expand/collapse button in the customizer.
To improve accessibility on touch devices increase the size of the button in the collapsed view from 24×28 to 44×45 pixel.

Props celloexpressions.
Fixes #36093.
Built from https://develop.svn.wordpress.org/trunk@37341


git-svn-id: http://core.svn.wordpress.org/trunk@37307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 20:29:27 +00:00
Dominik Schilling
823ec71cd6 Customize: Don't auto-close the customizer when a new theme is activated.
Props celloexpressions.
Fixes #35320.
Built from https://develop.svn.wordpress.org/trunk@37339


git-svn-id: http://core.svn.wordpress.org/trunk@37305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 19:54:27 +00:00
Andrea Fercia
22bae92301 Themes: restore Theme Installer missing spinner.
Fixes #36730.
Built from https://develop.svn.wordpress.org/trunk@37336


git-svn-id: http://core.svn.wordpress.org/trunk@37302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 15:43:27 +00:00
Sergey Biryukov
dc5815146e Dashboard: Display the comment counts in wp_dashboard_right_now() in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work.
Props afercia.
Fixes #35519.
Built from https://develop.svn.wordpress.org/trunk@37335


git-svn-id: http://core.svn.wordpress.org/trunk@37301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 11:06:28 +00:00
Dominik Schilling
697a6d5560 Plugins: In uninstall_plugin() pass the plugin file to wp_register_plugin_realpath().
`wp_register_plugin_realpath()` calls `dirname( $file );` to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.

Props andy.
Fixes #36709.
Built from https://develop.svn.wordpress.org/trunk@37331


git-svn-id: http://core.svn.wordpress.org/trunk@37297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 15:04:27 +00:00
Andrea Fercia
93c8cdbaed Accessibility: improve the Star Ratings hiding empty elements for assistive technologies.
Fixes #36725.
Built from https://develop.svn.wordpress.org/trunk@37330


git-svn-id: http://core.svn.wordpress.org/trunk@37296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 14:33:29 +00:00
Rachel Baker
15eaa665c1 Widgets: When the Inactive Widgets section is hidden also hide the “Clear Inactive Widgets” button description text.
Props welcher.

Fixes #35592.


Built from https://develop.svn.wordpress.org/trunk@37323


git-svn-id: http://core.svn.wordpress.org/trunk@37289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-28 20:40:28 +00:00
Michael Arestad
7726afe693 Component: Administration
Setting the background color on `body` is more flexible than on the `html` element. This patch assigns the background color to `body` instead of the `html` element.

Fixes #35314

Built from https://develop.svn.wordpress.org/trunk@37321


git-svn-id: http://core.svn.wordpress.org/trunk@37287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-28 03:16:28 +00:00
Rachel Baker
56c18bb5af Users: Remove the “Name” column of the Users table from appearing sortable.
The “Name” column of the Users WP List Table is not sortable because this column displays a concatenation of two optional values, `first_name` and `last_name`. Even if WP_User_Query supported ordering queries in this manner, the resulting sequence would be chaotic.

Fixes #28064.

Props jesin, and rachelbaker.
Built from https://develop.svn.wordpress.org/trunk@37314


git-svn-id: http://core.svn.wordpress.org/trunk@37280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-26 20:35:29 +00:00
Rachel Baker
e02de569a6 Comments: Add unordered list styling to Comments List Table rows and Moderate Comment screen.
Fixes #36160

Props juanfra.
Built from https://develop.svn.wordpress.org/trunk@37304


git-svn-id: http://core.svn.wordpress.org/trunk@37270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 21:47:26 +00:00
Rachel Baker
8b0e1859bc Comments: Keep comments safe in the Edit Post screen.
Warns users that have added a new Comment or began editing an existing without saving their changes, before they press the “update” button which would wipe out their comment changes.

Fixes #32818.

Props polevaultweb.
Built from https://develop.svn.wordpress.org/trunk@37303


git-svn-id: http://core.svn.wordpress.org/trunk@37269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 21:43:28 +00:00
Scott Taylor
be59d289b7 Dashboard: toggle the "View" link for comments when Approving / Unapproving from the Dashboard widget.
Fixes #35518.

Built from https://develop.svn.wordpress.org/trunk@37302


git-svn-id: http://core.svn.wordpress.org/trunk@37268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 21:30:28 +00:00
Sergey Biryukov
45b7930627 Text Changes: Consistently refer to https://wordpress.org/plugins/ and https://wordpress.org/themes/ as WordPress Plugin Directory and WordPress Theme Directory, respectively.
Props mpol.
Fixes #35938.
Built from https://develop.svn.wordpress.org/trunk@37297


git-svn-id: http://core.svn.wordpress.org/trunk@37263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 06:57:26 +00:00
Dominik Schilling
c3fe61770c Media: Remove an extra quote when sending a link of a media file to the editor.
Introduced in [37035].

Props joemcgill, swissspidy, boonebgorges.
Fixes #36578.
Built from https://develop.svn.wordpress.org/trunk@37288


git-svn-id: http://core.svn.wordpress.org/trunk@37254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 21:21:28 +00:00
Dominik Schilling
93eaf20f29 Themes: Update list of WordPress theme features.
* Remove color tags.
* Layout: Add Grid Layout, remove Fixed Layout, Fluid Layout, and Responsive Layout.
* Features: Add Footer Widgets, remove Blavatar.
* Subject: Add Blog, E-Commerce, Education, Entertainment, Food & Drink, Holiday, News, Photography and Portfolio, remove Photoblogging and Seasonal.

Props grapplerulrich, davewarfel.
Fixes #33407.
Built from https://develop.svn.wordpress.org/trunk@37287


git-svn-id: http://core.svn.wordpress.org/trunk@37253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 21:11:29 +00:00
Sergey Biryukov
1bd88850f7 Administration: Introduce admin_print_footer_scripts-$hook_suffix", a dynamic version of the admin_print_footer_scripts hook.
This is now more consistent with the generic `admin_print_scripts` and the dynamic `admin_print_scripts-$hook_suffix` hooks fired in `wp-admin/admin-header.php`.

Props tfrommen.
Fixes #34334.
Built from https://develop.svn.wordpress.org/trunk@37279


git-svn-id: http://core.svn.wordpress.org/trunk@37245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 15:17:27 +00:00
Pascal Birchler
a47fa4f197 Rewrite Rules: After [36953], correctly replace existing rules on IIS when updating them.
Props WiZZarD_.
Fixes #36506 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37273


git-svn-id: http://core.svn.wordpress.org/trunk@37239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 09:33:27 +00:00
Dominik Schilling
7b03510520 Upgrader: Clear plugin/theme caches directly after a plugin/theme has been updated.
`wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches, `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.

This is a follow-up to [34751].

See #34029.
Fixes #36383.
Built from https://develop.svn.wordpress.org/trunk@37272


git-svn-id: http://core.svn.wordpress.org/trunk@37238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 09:09:28 +00:00
Drew Jaynes
852e6921d2 Docs: Add missing return descriptions for WP_Filesystem_SSH2::chown() and WP_Filesystem_SSH2::run_command().
Fixes #30989.

Built from https://develop.svn.wordpress.org/trunk@37270


git-svn-id: http://core.svn.wordpress.org/trunk@37236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-21 02:38:29 +00:00
Aaron Jorbin
ee0ef3ca36 Use px instead of in in device preview
Devices are not consistent in how they handle `in` units. `in` was an attempt to cleverly disguise the exact size of the 'tablet'. The PHP code standards mentions avoiding clever code ( https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#clever-code ) but we should extend that idea to the css code as well.

Props celloexpressions
Fixes #36457


Built from https://develop.svn.wordpress.org/trunk@37247


git-svn-id: http://core.svn.wordpress.org/trunk@37213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-19 20:50:29 +00:00
Boone Gorges
6771f0e83e Include taxonomy term metadata in WXR export.
Because term XML nodes now include termmeta and can thus be much larger, this
changeset also includes adds some newlines and indentation to make the XML
easier to read.

Props Chouby.
See #34062.
Built from https://develop.svn.wordpress.org/trunk@37240


git-svn-id: http://core.svn.wordpress.org/trunk@37206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 03:38:27 +00:00
Sergey Biryukov
f79aad8e0c Theme Editor: After [37217], add other embed templates to file descriptions.
Props Frozzare.
Fixes #34561. See #34561.
Built from https://develop.svn.wordpress.org/trunk@37232


git-svn-id: http://core.svn.wordpress.org/trunk@37198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 01:05:27 +00:00
Andrea Fercia
26148850c5 Accessibility: change the close "X" in the Media "Attach to existing content" modal in a button.
Props joedolson.

Fixes #36554.
Built from https://develop.svn.wordpress.org/trunk@37231


git-svn-id: http://core.svn.wordpress.org/trunk@37197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 16:58:26 +00:00
Andrea Fercia
e38ab38b1f Accessibility: Customizer, improve UI controls in customize.php
- makes the mobile preview/customize toggle a button
- changes the "Close" link hidden text from 'Cancel' to 'Close the Customizer and go back to the previous page'
- adds a missing `type="button"` attribute
- removes unnecessary `keydown` events and `preventDefault()`: buttons don't need a keydown event and when they have a `type="button"` attribute there's no default action to prevent

Props Cheffheid, afercia.

Fixes #31487.
Built from https://develop.svn.wordpress.org/trunk@37230


git-svn-id: http://core.svn.wordpress.org/trunk@37196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 15:41:27 +00:00
Pascal Birchler
026ed07458 Admin: Fix default avatar handling in Settings -> Discussion.
By passing the `force_default` argument to `get_avatar()` instead of using `preg_replace`, we make it easier for developers to override the output.

Props henry.wright.
Fixes #34744.
Built from https://develop.svn.wordpress.org/trunk@37227


git-svn-id: http://core.svn.wordpress.org/trunk@37193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 10:19:28 +00:00
Andrea Fercia
76a6260353 Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page.
Props Ipstenu, ericlewis, michaelarestad.

Fixes #35429.
Built from https://develop.svn.wordpress.org/trunk@37221


git-svn-id: http://core.svn.wordpress.org/trunk@37187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 16:43:27 +00:00
Sergey Biryukov
784a00d49c Themes: Account for longer strings in Theme Details bar on Themes screen.
Fixes #27939.
Built from https://develop.svn.wordpress.org/trunk@37219


git-svn-id: http://core.svn.wordpress.org/trunk@37185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 13:59:26 +00:00
Sergey Biryukov
4109e8b9f8 Plugins: Properly wrap long tab names to a second line in plugin details modal.
Fixes #33221.
Built from https://develop.svn.wordpress.org/trunk@37218


git-svn-id: http://core.svn.wordpress.org/trunk@37184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 13:18:27 +00:00
Sergey Biryukov
f760d05a63 Theme Editor: Add embed.php to file descriptions.
Props ramiy.
Fixes #36551.
Built from https://develop.svn.wordpress.org/trunk@37217


git-svn-id: http://core.svn.wordpress.org/trunk@37183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 12:47:27 +00:00
Aaron Jorbin
262f3f2f7e Update grunt-contrib-uglify from ~0.10.0 to ~1.0.1
This changes every JS file in WordPress, so we need to test everything.

Props netweb.
See #36520.

Built from https://develop.svn.wordpress.org/trunk@37212


git-svn-id: http://core.svn.wordpress.org/trunk@37178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 16:10:37 +00:00
John Blackbourn
56cc4bc79c Docs: Clarify possible types passed to the themes_api_result filter.
See #32246

Built from https://develop.svn.wordpress.org/trunk@37209


git-svn-id: http://core.svn.wordpress.org/trunk@37175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 01:43:28 +00:00
Sergey Biryukov
4074bcc6a1 Bootstrap/Load: Allow for ABSPATH to be defined outside of wp-load.php, e.g. in a script loaded via auto_prepend_file.
Props barry.
Fixes #26592.
Built from https://develop.svn.wordpress.org/trunk@37207


git-svn-id: http://core.svn.wordpress.org/trunk@37173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 17:53:28 +00:00
Konstantin Obenland
5e22b71909 Themes: Fix single theme modal on collapsed menu.
Prevents the modal from being displayed off screen, when there is only one
theme available and the menu is collapsed.

Props hardeepasrani for initial patch.
Fixes #36504.


Built from https://develop.svn.wordpress.org/trunk@37205


git-svn-id: http://core.svn.wordpress.org/trunk@37171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 12:20:29 +00:00
Jeremy Felt
f74e50d1dd Multisite: Remove theme from network allowed themes when deleted
Previously, a deleted theme would remain in the list of allowed themes until manually cleared. This uses `WP_Theme::network_disable_theme()`, added in [37202].

Fixes #34182.

Built from https://develop.svn.wordpress.org/trunk@37203


git-svn-id: http://core.svn.wordpress.org/trunk@37169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 03:49:26 +00:00
Jeremy Felt
6279ca91de Multisite: Introduce WP_Theme methods to network enable/disable themes.
* `WP_Theme::network_enable_theme()` can be used to enable a theme or array of themes on a network.
* `WP_Theme::network_disable_theme()` can be used to disable a theme or array of themes on a network.
* Use these new methods in the network admin vs direct `update_site_option()` calls.
* Add tests.

Props igmoweb.
Fixes #30594.

Built from https://develop.svn.wordpress.org/trunk@37202


git-svn-id: http://core.svn.wordpress.org/trunk@37168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 03:40:27 +00:00
Jeremy Felt
6cc19b5e2e Multisite: Relocate revoke_super_admin() and grant_super_admin()
Moving these functions to `wp-includes/capabilities.php` allows plugins to access more than just `is_super_admin()` and `get_super_admin()` from the front end without including a file via `wp-admin/`. Add an `is_multisite()` check to prevent use of these on single site environments now that they have left `ms.php`..

Props johnjamesjacoby.
Fixes #21788.

Built from https://develop.svn.wordpress.org/trunk@37200


git-svn-id: http://core.svn.wordpress.org/trunk@37166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 03:35:27 +00:00
Sergey Biryukov
6e54900924 I18N: Remove <kbd> tags from translatable string in wp-admin/options-writing.php.
Add translator comment.

Props ramiy.
Fixes #36249.
Built from https://develop.svn.wordpress.org/trunk@37198


git-svn-id: http://core.svn.wordpress.org/trunk@37164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 02:25:26 +00:00
Sergey Biryukov
77e2737d89 Customizer: Remove the 'appearance' reference from permission error messages added in [33857], [33889], and [33902].
Props Frozzare.
Fixes #36466.
Built from https://develop.svn.wordpress.org/trunk@37197


git-svn-id: http://core.svn.wordpress.org/trunk@37163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 01:58:28 +00:00
Boone Gorges
1e82651504 Pass thumbnail ID to the admin_post_thumbnail_html filter.
Also updates changelog to reflect that `$post->ID` was added in 3.5

Props johnjamesjacoby.
Fixes #36443.
Built from https://develop.svn.wordpress.org/trunk@37196


git-svn-id: http://core.svn.wordpress.org/trunk@37162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 16:18:28 +00:00
Sergey Biryukov
c55e4194f8 Docs: Fix typo in a comment in wp-admin/js/postbox.js.
Props yoavf.
Fixes #36349.
Built from https://develop.svn.wordpress.org/trunk@37195


git-svn-id: http://core.svn.wordpress.org/trunk@37161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 07:29:27 +00:00