Sergey Biryukov
00f110740b
Bootstrap/Load: In wp_magic_quotes()
, revert the type change to string for REQUEST_TIME
and REQUEST_TIME_FLOAT
values, which should retain their proper type.
...
Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.
Props jrf, Veraxus, Rarst.
See #48605 .
Built from https://develop.svn.wordpress.org/trunk@47370
git-svn-id: http://core.svn.wordpress.org/trunk@47157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 18:33:06 +00:00
Sergey Biryukov
1e81c20ff5
Docs: In wp_insert_user()
, correct @type
for rich_editing
, syntax_highlighting
, comment_shortcuts
, and show_admin_bar_front
arguments.
...
Follow-up to [47368].
See #49087 .
Built from https://develop.svn.wordpress.org/trunk@47369
git-svn-id: http://core.svn.wordpress.org/trunk@47156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 18:20:06 +00:00
Sergey Biryukov
2cd5292def
Docs: In wp_insert_user()
, clarify that rich_editing
, syntax_highlighting
, comment_shortcuts
, and show_admin_bar_front
arguments accept true
or false
as a string literal, not boolean.
...
Props garrett-eclipse, audrasjb, valentinbora, bilgilabs, SergeyBiryukov.
Fixes #49087 .
Built from https://develop.svn.wordpress.org/trunk@47368
git-svn-id: http://core.svn.wordpress.org/trunk@47155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 18:16:07 +00:00
Sergey Biryukov
89689e5ba9
Docs: Clarify in WP_Customize_Manager::remove_*()
methods that removing a setting, panel, section, or control does not destroy the class instance or remove its filters.
...
Props dlh, fgiannar, jon81, westonruter.
Fixes #48747 .
Built from https://develop.svn.wordpress.org/trunk@47367
git-svn-id: http://core.svn.wordpress.org/trunk@47154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 17:50:05 +00:00
Sergey Biryukov
5308f570cb
Comments: Restore the fourth parameter of comments_number()
as $post_id
, for consistency with get_comments_number_text()
.
...
The parameter was previously used as the number of comments, marked as deprecated in [5101].
Given that it's been deprecated for the last 13 years, it should be safe to undeprecate and repurpose it for a cleaner function signature, instead of adding a fifth parameter.
Follow-up to [47276].
Fixes #48772 .
Built from https://develop.svn.wordpress.org/trunk@47366
git-svn-id: http://core.svn.wordpress.org/trunk@47153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 17:34:08 +00:00
Sergey Biryukov
b7c69ce058
Widgets: Avoid an overflow issue in widget controls that include <select>
form fields.
...
Props alexischenal, audrasjb, dkarfa.
Fixes #49401 .
Built from https://develop.svn.wordpress.org/trunk@47365
git-svn-id: http://core.svn.wordpress.org/trunk@47152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 17:04:07 +00:00
Sergey Biryukov
d51c720d2f
Docs: Add a reference to WP_Customize_Control::__construct()
for information on accepted arguments in WP_Customize_Manager::add_control()
.
...
Synchronize the documentation between two places, use `WP_Customize_Control::__construct()` as the canonical source.
Props hAmpzter, marekdedic, SergeyBiryukov.
Fixes #48343 .
Built from https://develop.svn.wordpress.org/trunk@47364
git-svn-id: http://core.svn.wordpress.org/trunk@47151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 16:41:07 +00:00
Sergey Biryukov
cfc27d08ce
Docs: Add a reference to WP_Customize_Control::__construct()
for information on accepted arguments to override class property defaults in child classes.
...
Props marcio-zebedeu, marekdedic.
Fixes #48348 .
Built from https://develop.svn.wordpress.org/trunk@47363
git-svn-id: http://core.svn.wordpress.org/trunk@47150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 16:21:07 +00:00
K. Adam White
44e1bbef85
REST API: Correctly infer empty objects passed via query parameters.
...
Permit passing an empty object as the string "?obj=". The type of the passed empty argument is inferred from the registered schema.
Props TimothyBlynJacobs, steffanhalv, schlessera, dd32.
Fixes #42961 .
Built from https://develop.svn.wordpress.org/trunk@47362
git-svn-id: http://core.svn.wordpress.org/trunk@47149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 15:34:07 +00:00
K. Adam White
a5f16272dd
REST API: Permit access to the themes controller if user can edit any post type.
...
Check a more exhaustive list of post type editing caps beyond "edit_post" to ensure custom user roles with access to to specific post types may still use block editor functionality depending on theme features.
Props miyauchi, TimothyBlynJacobs.
Fixes #46723 .
Built from https://develop.svn.wordpress.org/trunk@47361
git-svn-id: http://core.svn.wordpress.org/trunk@47148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 15:20:08 +00:00
K. Adam White
8faf366ab9
REST API: Apply all relevant block rendering filters when rendering block previews.
...
Several filters were introduced to the render_block method since the initial implementation of the block-renderer/ endpoints, causing the output of those endpoints to diverge from the rendered content of blocks on the frontend.
Props kadamwhite, TimothyBlynJacobs, miinasikk.
Fixes #49387 .
Built from https://develop.svn.wordpress.org/trunk@47360
git-svn-id: http://core.svn.wordpress.org/trunk@47147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 15:05:06 +00:00
Sergey Biryukov
67a6527d51
Script Loader: Improve performance of wp_script_is()
for scripts registered with complex dependencies.
...
This switches `WP_Dependencies::recurse_deps()` from recursively checking the same handles over and over again to keep a flattened array of queued items and their dependencies for faster lookup in `WP_Dependencies::query()`.
Props superdav42.
Fixes #46469 .
Built from https://develop.svn.wordpress.org/trunk@47359
git-svn-id: http://core.svn.wordpress.org/trunk@47146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 13:42:05 +00:00
Sergey Biryukov
c60ea3261f
Docs: Add a @since
note for including delete_posts
in default capabilities in get_post_type_capabilities()
.
...
Follow-up to [47357].
See #30991 .
Built from https://develop.svn.wordpress.org/trunk@47358
git-svn-id: http://core.svn.wordpress.org/trunk@47145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 12:55:08 +00:00
Sergey Biryukov
aaccfc063f
Posts, Post Types: Ensure delete_posts
is included in default post type capabilities regardless of map_meta_cap
value.
...
This resolves PHP notices in a few places in core where this capability is checked.
Props Mte90, johnbillion, dipesh.kakadiya, jipmoors, bamadesigner, dd32, johnjamesjacoby, xedin.unknown, flixos90, SergeyBiryukov.
Fixes #30991 .
Built from https://develop.svn.wordpress.org/trunk@47357
git-svn-id: http://core.svn.wordpress.org/trunk@47144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 12:50:06 +00:00
Sergey Biryukov
1a090b3385
Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel.
...
Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830 .
Built from https://develop.svn.wordpress.org/trunk@47356
git-svn-id: http://core.svn.wordpress.org/trunk@47143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 11:14:08 +00:00
Sergey Biryukov
556c6d80d8
Script Loader: Remove unnecessary reference sign from function definitions in script loader.
...
This resolves PHP warnings when extensions like `php_uopz` or `php_tideways_xhprof` are in use.
Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.
Props jqz, killerbishop, Mte90, TJNowell, jorbin, pento, pcarvalho, valentinbora, SergeyBiryukov.
Fixes #44979 .
Built from https://develop.svn.wordpress.org/trunk@47355
git-svn-id: http://core.svn.wordpress.org/trunk@47142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 00:59:06 +00:00
jorgefilipecosta
f616ffb9c1
Block Editor: Update WordPress Packages WordPress 5.4 Beta 3.
...
The following package versions were changed:
@wordpress/block-directory: 1.5.1 -> 1.5.2
@wordpress/block-editor: 3.7.1 -> 3.7.2
@wordpress/block-library: 2.14.1 -> 2.14.2
@wordpress/components: 9.2.1 -> 9.2.2
@wordpress/edit-post: 3.13.1 -> 3.13.2
@wordpress/editor: 9.12.1 -> 9.12.2
@wordpress/format-library: 1.14.1 -> 1.14.2
@wordpress/list-reusable-blocks: 1.13.1 -> 1.13.2
@wordpress/media-utils: 1.7.1 -> 1.7.2
@wordpress/nux: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.1 -> 1.8.2
Fixes #49506 .
Built from https://develop.svn.wordpress.org/trunk@47354
git-svn-id: http://core.svn.wordpress.org/trunk@47141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 00:18:15 +00:00
Sergey Biryukov
3209729f5f
Accessibility: Widgets: Restore missing string in script loader.
...
The string was previously added in [42794] and accidentally removed in [44163].
Props garrett-eclipse, audrasjb.
Fixes #49505 .
Built from https://develop.svn.wordpress.org/trunk@47353
git-svn-id: http://core.svn.wordpress.org/trunk@47140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 23:07:09 +00:00
Andrew Ozz
50be657d81
Build Tools:
...
- Update the DependencyExtractionWebpackPlugin to 2.3.0 and set it to output a single assets file.
- Grunt: copy the assets file to both `SOURCE_DIR` and `BUILD_DIR` as `wp-includes/assets/script-loader-packages.php`.
- "Unignore" the `wp-includes/assets` directory. Its content will be committed similarly to `wp-includes/blocks`.
- Update `wp_default_packages_scripts()` to use the above file. This also removes the hard-coded lists of packages and packages with translations.
Props gziolo, pbearne, johnbillion, isabel_brison, ocean90, azaozz.
Fixes #48154 .
Built from https://develop.svn.wordpress.org/trunk@47352
git-svn-id: http://core.svn.wordpress.org/trunk@47139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 21:22:08 +00:00
K. Adam White
480372b07c
REST API: Fix namespace shadowing issue in route matching logic.
...
Following [47260] a namespace such as "test-ns" prevents any namespace such as "test-ns/v1" from being found when matching routes.
While not best practice, this was an unintentional back-compat break; this patch restores the original behavior.
Props david.binda, TimothyBlynJacobs.
Fixes #48530 .
Built from https://develop.svn.wordpress.org/trunk@47351
git-svn-id: http://core.svn.wordpress.org/trunk@47138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 18:07:08 +00:00
Sergey Biryukov
4aeebf03a5
Menus: Introduce wp_nav_menu_item_custom_fields_customize_template
action that fires at the end of the form field template for nav menu items in the customizer.
...
This brings parity with the `wp_nav_menu_item_custom_fields` action added in [47190] for the Menus screen.
Props celloexpressions.
Fixes #47056 .
Built from https://develop.svn.wordpress.org/trunk@47350
git-svn-id: http://core.svn.wordpress.org/trunk@47137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 14:58:19 +00:00
Sergey Biryukov
735d31ffbb
Coding Standards: Add missing braces to if
conditions and use strict comparison in js/_enqueues/wp/media/editor.js
.
...
Props ankitmaru.
Fixes #49317 .
Built from https://develop.svn.wordpress.org/trunk@47349
git-svn-id: http://core.svn.wordpress.org/trunk@47136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-23 08:58:05 +00:00
Sergey Biryukov
9f8f54bfbb
Built/Test Tools: Ignore the node_modules
folder in Twenty Nineteen when running grunt jshint:themes
.
...
Follow-up to [45060], [46352], [46450].
Fixes #49494 . See #46706 .
Built from https://develop.svn.wordpress.org/trunk@47348
git-svn-id: http://core.svn.wordpress.org/trunk@47135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-23 08:28:06 +00:00
Sergey Biryukov
5a23e3fabd
Docs: Use third-person singular verbs for function descriptions in wp-includes/option.php
, per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47347
git-svn-id: http://core.svn.wordpress.org/trunk@47134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-23 01:07:08 +00:00
Sergey Biryukov
30572ef8ed
Docs: Add a @staticvar
entry for $transports
in WP_Http::_dispatch_request()
.
...
Props utsav72640.
Fixes #48774 .
Built from https://develop.svn.wordpress.org/trunk@47346
git-svn-id: http://core.svn.wordpress.org/trunk@47133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 19:12:06 +00:00
Sergey Biryukov
e0a2660719
I18N: Replace .htaccess
with placeholders in the strings for Site Health custom rules check.
...
Props ramiy.
Fixes #48864 .
Built from https://develop.svn.wordpress.org/trunk@47345
git-svn-id: http://core.svn.wordpress.org/trunk@47132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 18:56:06 +00:00
Sergey Biryukov
b4cea6ae93
I18N: Use a consistent wording for "Unable to write to file" strings.
...
Props ramiy.
Fixes #48862 .
Built from https://develop.svn.wordpress.org/trunk@47344
git-svn-id: http://core.svn.wordpress.org/trunk@47131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 18:33:08 +00:00
desrosj
b92155f273
General: Introduce a pull request template.
...
This ensures that contributors opening a pull request on GitHub for code review have proper guidance.
See https://make.wordpress.org/core/2020/02/21/working-on-trac-tickets-using-github-pull-requests/ and https://meta.trac.wordpress.org/ticket/4903 .
Props noisysocks, desrosj.
Fixes #49489 .
Built from https://develop.svn.wordpress.org/trunk@47342
git-svn-id: http://core.svn.wordpress.org/trunk@47129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 18:25:07 +00:00
Sergey Biryukov
92050d6499
Build/Test Tools: Remove unused ::assertPostHasTerms()
method from tests/term.php
.
...
The associated test was removed in [30241].
See #49485 .
Built from https://develop.svn.wordpress.org/trunk@47341
git-svn-id: http://core.svn.wordpress.org/trunk@47128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 17:06:06 +00:00
Adam Silverstein
2c5ebcee68
Comments: improve styling on mobile for comments marked as spam.
...
Correct an issue where comments marked as spam in a mobile view displayed incorrectly, filling a narrow and very tall column with the notice that a comment was marked as spam.
Props jeremyfelt, lorenzof, mukesh27, razamalik, xkon.
Fixes #48814 .
Built from https://develop.svn.wordpress.org/trunk@47340
git-svn-id: http://core.svn.wordpress.org/trunk@47127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 17:04:08 +00:00
ianbelanger
5a6decf95c
Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied.
...
Fixes the pullquote color setting by adding classes that are more specific to the color options.
Props ianbelanger.
Fixes #49410 .
Built from https://develop.svn.wordpress.org/trunk@47339
git-svn-id: http://core.svn.wordpress.org/trunk@47126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 14:59:09 +00:00
Sergey Biryukov
f0dfe42216
I18N: Replace upload_max_filesize
, php.ini
, MAX_FILE_SIZE
with placeholders in upload error strings.
...
Props ramiy.
Fixes #48869 .
Built from https://develop.svn.wordpress.org/trunk@47330
git-svn-id: http://core.svn.wordpress.org/trunk@47123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 17:18:06 +00:00
TimothyBlynJacobs
5031baa32b
REST API: Don't assume all item schemas have properties.
...
All schema types, not just objects, are permitted as the base type of a resource. A future patch could add validation support for those types, but this fix only prevents a PHP warning from being issued.
Props dhavalkasvala, johnwatkins0, birgire.
Fixes #48785 .
Built from https://develop.svn.wordpress.org/trunk@47328
git-svn-id: http://core.svn.wordpress.org/trunk@47122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 16:58:06 +00:00
ianbelanger
a5cfb704bd
Bundled Themes: Twenty Nineteen Update margins in editor styles to address upcoming block editor margin changes.
...
Fixes the margins in the block editor to address recent changes in block margins.
Props Joen, SergeyBiryukov, kjellr, jffng, allancole.
Fixes #48526 .
Built from https://develop.svn.wordpress.org/trunk@47327
git-svn-id: http://core.svn.wordpress.org/trunk@47121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 16:40:06 +00:00
TimothyBlynJacobs
450d49183b
REST API: Fix links format in OPTIONS requests for non-variable routes.
...
Props nsundberg, johnwatkins0, birgire.
Fixes #49149 .
Built from https://develop.svn.wordpress.org/trunk@47326
git-svn-id: http://core.svn.wordpress.org/trunk@47120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 00:55:05 +00:00
TimothyBlynJacobs
808768224d
REST API: Warn if registering array settings without an items schema.
...
The documentation for register_setting has also been clarified to include all of the supported types and the flexibility of the show_in_rest parameter.
Fixes #42875 .
Props perrywagle, dshanske, kadamwhite.
Built from https://develop.svn.wordpress.org/trunk@47325
git-svn-id: http://core.svn.wordpress.org/trunk@47119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 22:56:07 +00:00
Sergey Biryukov
c15cd5f5c4
Docs: Add missing quote to {@see 'comment_$old_status_to_$new_status'}
hook reference in wp_transition_comment_status()
DocBlock.
...
Props coffee2code.
Fixes #49474 .
Built from https://develop.svn.wordpress.org/trunk@47324
git-svn-id: http://core.svn.wordpress.org/trunk@47118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 13:45:07 +00:00
Sergey Biryukov
511a297fb4
Tests: Correct assertions in test_site_dates_are_gmt()
.
...
`assertSame()` doesn't have the `$delta` parameter, only `assertEquals()` does.
Follow-up to [47313].
See #40364 .
Built from https://develop.svn.wordpress.org/trunk@47318
git-svn-id: http://core.svn.wordpress.org/trunk@47116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 04:40:05 +00:00
Sergey Biryukov
e67b01895b
Posts, Post Types: Discard tags_input
parameter in wp_update_post()
if it's the same as existing post tags.
...
This ensures that `wp_update_post()` does not unintentionally modify post tags if the post has several tags with the same name but different slugs.
Tags should only be modified if `tags_input` parameter was explicitly provided, and is different from the existing tags.
Props kaggdesign, SergeyBiryukov.
Fixes #45121 .
Built from https://develop.svn.wordpress.org/trunk@47317
git-svn-id: http://core.svn.wordpress.org/trunk@47115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 03:52:09 +00:00
Sergey Biryukov
548685b97d
Tests: Use delta comparison in test_site_dates_are_gmt()
to avoid race conditions.
...
See #40364 .
Built from https://develop.svn.wordpress.org/trunk@47313
git-svn-id: http://core.svn.wordpress.org/trunk@47113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 02:43:08 +00:00
Sergey Biryukov
c4a5b98fa0
Build/Test Tools: Keep wp-config.php
file in the build
directory on rebuild, but still copy it over from src
if it also exists there.
...
Follow-up to [47303].
Props afercia, isabel_brison, SergeyBiryukov.
Fixes #49460 .
Built from https://develop.svn.wordpress.org/trunk@47312
git-svn-id: http://core.svn.wordpress.org/trunk@47112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 01:50:05 +00:00
Sergey Biryukov
399c2bf8c6
Tests: Remove an irrelevant tags_input
property assertion from test_get_page_template_property()
.
...
This appears to be a copy/paste from the `test_get_tags_input_property()` test above.
See #45121 .
Built from https://develop.svn.wordpress.org/trunk@47311
git-svn-id: http://core.svn.wordpress.org/trunk@47111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 01:05:09 +00:00
Tammie Lister
152892b04c
Bump version number to beta 2-47310
...
Built from https://develop.svn.wordpress.org/trunk@47310
git-svn-id: http://core.svn.wordpress.org/trunk@47110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 21:29:05 +00:00
Tammie Lister
d55eaec1f7
Bump version number to beta 2
...
Built from https://develop.svn.wordpress.org/trunk@47309
git-svn-id: http://core.svn.wordpress.org/trunk@47109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 21:11:06 +00:00
desrosj
4cc82e180e
Widgets: Revert [47307].
...
Even though the source URL for an attachment is stored in a variable, attachments should still be passed through the `wp_video_shortcode()` function.
Unprops desrosj, spacedmonkey.
See #46718 .
Built from https://develop.svn.wordpress.org/trunk@47308
git-svn-id: http://core.svn.wordpress.org/trunk@47108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 18:19:06 +00:00
desrosj
520fe14f79
Widgets: Remove unnecessary redundant conditional.
...
Props spacedmonkey.
Fixes #46718 .
Built from https://develop.svn.wordpress.org/trunk@47307
git-svn-id: http://core.svn.wordpress.org/trunk@47107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 17:52:06 +00:00
desrosj
447536a0e6
Site Health: Display the REST API test error codes correctly.
...
This change fixes an issue where the error codes associated with failed REST API tests are not being printed to the screen. In addition, the square brackets have been replaced with parentheses for consistency, and the error code (which is much less useful to end-users than the error message itself) has been moved to the end of the line.
This also clarifies the associated translator comments.
Props afercia, desrosj.
Fixes #49426 .
Built from https://develop.svn.wordpress.org/trunk@47306
git-svn-id: http://core.svn.wordpress.org/trunk@47106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 16:48:06 +00:00
Sergey Biryukov
306d804d86
Theme Editor: Disable CodeMirror CSS linting.
...
Being a good idea in theory, in practice it does not always work reliably, may not recognize newer CSS properties, and sometimes displays phantom errors with no particular error message.
A plugin can re-enable CSS linting via the `wp_code_editor_settings` filter.
Props skypressatx, ThemeZee, johnbillion, ianbelanger, ZanderZ, starvoters1, raoulunger, prashantvatsh, SergeyBiryukov.
Fixes #44471 .
Built from https://develop.svn.wordpress.org/trunk@47305
git-svn-id: http://core.svn.wordpress.org/trunk@47105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 15:51:08 +00:00
Andrea Fercia
d1054fcb48
Accessibility: Improve readability by removing unnecessary italic font style.
...
Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided.
Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements.
Removes italic font style from:
- the Quick Edit / Bulk Edit forms
- the Recovery Mode plugin error details
- the Image Editor inline help
Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia.
See #47327 .
Built from https://develop.svn.wordpress.org/trunk@47304
git-svn-id: http://core.svn.wordpress.org/trunk@47104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 15:32:09 +00:00
Sergey Biryukov
bb7880a7ea
Build/Test Tools: Keep wp-config.php
file in the build
directory on rebuild.
...
Props isabel_brison.
Fixes #49460 .
Built from https://develop.svn.wordpress.org/trunk@47303
git-svn-id: http://core.svn.wordpress.org/trunk@47103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 09:27:09 +00:00
jorgefilipecosta
b522d90421
Block Editor: Update WordPress Packages WordPress 5.4 beta 2.
...
The following package versions were changed:
@wordpress/block-directory: 1.5.0 -> 1.5.1
@wordpress/block-editor: 3.7.0 -> 3.7.1
@wordpress/block-library: 2.14.0 -> 2.14.1
@wordpress/components: 9.2.0 -> 9.2.1
@wordpress/edit-post: 3.13.0 -> 3.13.1
@wordpress/editor: 9.12.0 -> 9.12.1
@wordpress/format-library: 1.14.0 -> 1.14.1
@wordpress/list-reusable-blocks: 1.13.0 -> 1.13.1
@wordpress/media-utils: 1.7.0 -> 1.7.1
@wordpress/nux: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.0 -> 1.8.1
Props gziolo, youknowriad, epiqueras, aduth.
Fixes #49458 .
Built from https://develop.svn.wordpress.org/trunk@47302
git-svn-id: http://core.svn.wordpress.org/trunk@47102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 23:02:14 +00:00
jorgefilipecosta
ce3cd1cd91
Block Editor: Add missing package to the default export array.
...
Follow up on https://core.trac.wordpress.org/ticket/49358#comment:12 .
We should add "warning" to the array of packages with default export to avoid the need for developers to use wp.warning.default.
Props gziolo, aduth.
Fixes #49436 .
Built from https://develop.svn.wordpress.org/trunk@47301
git-svn-id: http://core.svn.wordpress.org/trunk@47101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 12:32:05 +00:00
Sergey Biryukov
9de7b1c35e
Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now.
...
Props Clorith, pbiron.
See #47606 , #47085 .
Built from https://develop.svn.wordpress.org/trunk@47300
git-svn-id: http://core.svn.wordpress.org/trunk@47100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 09:59:04 +00:00
Sergey Biryukov
61986acde9
Users: Limit the scope of admin files required in WP_REST_Users_Controller
.
...
This requires only `wp-admin/includes/user.php` for `get_editable_roles()`, instead of `wp-admin/includes/admin.php`.
Follow-up to [43589].
Props johnwatkins0.
Fixes #49450 .
Built from https://develop.svn.wordpress.org/trunk@47299
git-svn-id: http://core.svn.wordpress.org/trunk@47099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 05:33:06 +00:00
Sergey Biryukov
8f877dc875
Docs: Improve inline comments for require_once
calls in WP_REST_Users_Controller
per the documentation standards.
...
Follow-up to [47295].
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47298
git-svn-id: http://core.svn.wordpress.org/trunk@47098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 03:56:06 +00:00
Sergey Biryukov
97380ec1ce
Docs: Fix typo in a comment in WP_REST_Attachments_Controller::create_item()
.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47297
git-svn-id: http://core.svn.wordpress.org/trunk@47097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 03:30:04 +00:00
Sergey Biryukov
1d5d5b3e87
REST API: Restore wp-admin/includes/image.php
requirement in WP_REST_Attachments_Controller::create_item()
.
...
Although the file is already included via the `::insert_attachment()` method, this addresses an inconsistency and corrects a misleading comment.
It also reduces the possibility of a future error in case `::insert_attachment()` is no longer called earlier in `::create_item()` at some point.
Follow-up to [43850] and [44206].
Props luisrivera.
Fixes #49449 .
Built from https://develop.svn.wordpress.org/trunk@47296
git-svn-id: http://core.svn.wordpress.org/trunk@47096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 03:24:07 +00:00
Sergey Biryukov
445e2859ab
Docs: Improve inline comments for require_once()
calls in WP_REST_Attachments_Controller
.
...
See #49449 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47295
git-svn-id: http://core.svn.wordpress.org/trunk@47095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 03:13:05 +00:00
Sergey Biryukov
5875ad981b
Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing.
...
Other inputs are already restored to their previous values in that case.
Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov.
Fixes #43031 .
Built from https://develop.svn.wordpress.org/trunk@47294
git-svn-id: http://core.svn.wordpress.org/trunk@47094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-16 06:27:08 +00:00
Sergey Biryukov
74b90a6b45
Themes: Correct the height of theme actions button container on various screen sizes.
...
Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov.
Fixes #49302 .
Built from https://develop.svn.wordpress.org/trunk@47293
git-svn-id: http://core.svn.wordpress.org/trunk@47093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-15 05:08:05 +00:00
Sergey Biryukov
f147a4003e
Widgets: Hide the "Align" legend in Image Widget display settings, since the associated controls are also hidden.
...
Props audrasjb, fotisps, marcelo2605.
Fixes #48931 .
Built from https://develop.svn.wordpress.org/trunk@47292
git-svn-id: http://core.svn.wordpress.org/trunk@47092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-15 02:50:08 +00:00
Sergey Biryukov
a2b2f63b78
Administration: Allow wp_update_link()
to update the link_owner
field, for consistency with other link fields.
...
Props pbiron, valentinbora, nikhilgupte.
Fixes #41687 .
Built from https://develop.svn.wordpress.org/trunk@47291
git-svn-id: http://core.svn.wordpress.org/trunk@47091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-15 01:55:06 +00:00
Sergey Biryukov
19fd7a0da9
Administration: Correct alignment of form controls inside custom meta boxes.
...
Props audrasjb, dontdream, valentinbora.
Fixes #49013 .
Built from https://develop.svn.wordpress.org/trunk@47289
git-svn-id: http://core.svn.wordpress.org/trunk@47089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-14 00:52:06 +00:00
Sergey Biryukov
e16d70a9d4
Tests: Rename $d
variable in some date/time tests to $format
for clarity.
...
Follow-up to [47287].
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47288
git-svn-id: http://core.svn.wordpress.org/trunk@47088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-14 00:12:11 +00:00
Sergey Biryukov
6b2c63031c
Coding Standards: Rename $d
parameter in various date/time functions to $format
for clarity.
...
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47287
git-svn-id: http://core.svn.wordpress.org/trunk@47087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-14 00:07:07 +00:00
Sergey Biryukov
f7338b347d
Docs: Update @return
tag for wp_allow_comment()
with trash
as a possible return value.
...
Props oakesjosh, jeremyfelt.
Fixes #49206 .
Built from https://develop.svn.wordpress.org/trunk@47286
git-svn-id: http://core.svn.wordpress.org/trunk@47086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-13 17:50:05 +00:00
Sergey Biryukov
57ba9a2906
General: Update Michel Valdrighi's website in license.txt
.
...
Props sebastienserre.
Fixes #49130 .
Built from https://develop.svn.wordpress.org/trunk@47285
git-svn-id: http://core.svn.wordpress.org/trunk@47085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-12 11:54:05 +00:00
Sergey Biryukov
534fcd7b0e
Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list.
...
Props chetan200891, xkon, garrett-eclipse.
Fixes #48431 .
Built from https://develop.svn.wordpress.org/trunk@47284
git-svn-id: http://core.svn.wordpress.org/trunk@47084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-12 11:44:08 +00:00
Sergey Biryukov
b2ecf2c2bc
Privacy: Improve the appearance of privacy request email inputs on mobile.
...
Props garrett-eclipse, xkon.
Fixes #48189 .
Built from https://develop.svn.wordpress.org/trunk@47283
git-svn-id: http://core.svn.wordpress.org/trunk@47083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-12 11:29:10 +00:00
jorgefilipecosta
53f823e21e
Post WordPress 5.4 Beta 1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@47282
git-svn-id: http://core.svn.wordpress.org/trunk@47082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 22:46:09 +00:00
jorgefilipecosta
b24a667b9a
WordPress 5.4 Beta 1.
...
Built from https://develop.svn.wordpress.org/trunk@47281
git-svn-id: http://core.svn.wordpress.org/trunk@47081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 22:20:10 +00:00
Sergey Biryukov
63ed0401a0
Privacy: Revert [47269] for now to address side effects on Multisite installations.
...
See #44176 .
Built from https://develop.svn.wordpress.org/trunk@47280
git-svn-id: http://core.svn.wordpress.org/trunk@47080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 21:48:06 +00:00
Sergey Biryukov
652966a2a5
Privacy: Introduce filters for the headers of all the privacy-related e-mails:
...
* `wp_privacy_personal_data_email_headers`
* `user_request_confirmed_email_headers`
* `user_erasure_complete_email_headers`
* `user_request_action_email_headers`
Props xkon, garrett-eclipse, zaffarn, desrosj.
Fixes #44501 .
Built from https://develop.svn.wordpress.org/trunk@47279
git-svn-id: http://core.svn.wordpress.org/trunk@47079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 21:43:07 +00:00
Sergey Biryukov
e6d01e007c
Privacy: Add a table of contents to Personal Data Export report for easier navigation.
...
Props xkon, garrett-eclipse, birgire, karmatosed.
Fixes #46894 .
Built from https://develop.svn.wordpress.org/trunk@47278
git-svn-id: http://core.svn.wordpress.org/trunk@47078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 21:28:05 +00:00
Sergey Biryukov
cbaf9bf9d1
Coding Standards: Use a strict in_array()
check for reserved names of user data items in wp_user_personal_data_exporter()
.
...
Props azaozz.
Fixes #47509 .
Built from https://develop.svn.wordpress.org/trunk@47277
git-svn-id: http://core.svn.wordpress.org/trunk@47077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 20:55:07 +00:00
Sergey Biryukov
17e563cd9c
Comments: Add a $post_id
parameter to get_comments_number_text()
and comments_number()
.
...
This allow for using these functions outside of the loop.
Props donmhico, garrett-eclipse, Hinjiriyo, imath.
Fixes #48772 .
Built from https://develop.svn.wordpress.org/trunk@47276
git-svn-id: http://core.svn.wordpress.org/trunk@47076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 20:41:05 +00:00
desrosj
be2ec734f2
Upgrade/Install: Enable maintenance mode when plugins are auto-updated.
...
When an attempt is made to update an active plugin automatically, there is the potential currently for two negative scenarios:
- The plugin can be deactivated if the Plugins admin screen is loaded when the plugin update is incomplete, causing a PHP error.
- The WSOD protection could be triggered, sending a false alarm email to the site administrator.
By enabling maintenance mode before an active plugin update is attempted, these scenarios can be avoided.
This change implements the same approach as the `Theme_Upgrader` class of using the `upgrader_pre_install` and `upgrader_post_install` hooks to toggle maintenance mode.
Props desrosj, SergeyBiryukov.
Fixes #49400 .
Built from https://develop.svn.wordpress.org/trunk@47275
git-svn-id: http://core.svn.wordpress.org/trunk@47075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 20:14:05 +00:00
Andrew Ozz
a2accf4db7
Media: Pass through the $unfiltered
param to get_attached_file()
in wp_get_original_image_path()
.
...
Props ianmjones, joemcgill, azaozz.
Fixes #48421 .
Built from https://develop.svn.wordpress.org/trunk@47274
git-svn-id: http://core.svn.wordpress.org/trunk@47074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 19:47:07 +00:00
ianbelanger
4489fb7b36
Bundled Themes: Twenty Sixteen text color setting in pullquote block not applied.
...
Fixes the pullquote color setting by moving `color` from `blockquote p` to `blockquote`. Also adds the border-left to the front-end stylesheet to match the editor. Also adds styles for rtl pullquote.
Props kokkieh, desrosj, mukesh27, khushbu19, disillusia, aliveic, abrightclearweb, SergeyBiryukov.
Fixes #47019 .
Built from https://develop.svn.wordpress.org/trunk@47273
git-svn-id: http://core.svn.wordpress.org/trunk@47073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 19:38:05 +00:00
Sergey Biryukov
ae102b2487
Export: Use correct context for the Posts
label on the Export screen.
...
The string refers to the post type name specifically, not to a generic term to identify a publication on WordPress.
Props audrasjb, jdy68.
Fixes #49306 .
Built from https://develop.svn.wordpress.org/trunk@47272
git-svn-id: http://core.svn.wordpress.org/trunk@47072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 19:35:06 +00:00
jorgefilipecosta
40046869f3
Upload: Fix Plugin and Theme upload form are misaligned.
...
This commit makes sure that when uploading a plugin or theme file, the Install Now button is correctly aligned, and the button does not drops to the next line if filename is long.
Props seedsca, SergeyBiryukov, audrasjb.
Fixes #48859 .
Built from https://develop.svn.wordpress.org/trunk@47271
git-svn-id: http://core.svn.wordpress.org/trunk@47071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 19:18:09 +00:00
Sergey Biryukov
5a29f108e0
Privacy: Introduce wp_privacy_additional_user_data
filter to make it easier to include additional user meta in a personal data export.
...
Props pbiron, xkon, garrett-eclipse, azaozz.
Fixes #47509 .
Built from https://develop.svn.wordpress.org/trunk@47270
git-svn-id: http://core.svn.wordpress.org/trunk@47070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 18:59:05 +00:00
Sergey Biryukov
30c7bb621c
Privacy: Un-map privacy capabilities to make them available to be assigned for custom roles:
...
* `erase_others_personal_data`
* `export_others_personal_data`
* `manage_privacy_options`
Previously mapped to `manage_options` or `manage_network` (on Multisite), these are now added to the Administrator role separately.
Additionally, `manage_privacy_options` is added to the Editor role.
Props garrett-eclipse, xkon, pbiron, desrosj, johnbillion, flixos90, juliobox, lakenh, Ov3rfly, ianatkins.
Fixes #44176 .
Built from https://develop.svn.wordpress.org/trunk@47269
git-svn-id: http://core.svn.wordpress.org/trunk@47069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 18:36:06 +00:00
Sergey Biryukov
bf29d14a69
Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in wp-admin/setup-config.php
.
...
Props ramiy.
Fixes #47043 .
Built from https://develop.svn.wordpress.org/trunk@47268
git-svn-id: http://core.svn.wordpress.org/trunk@47068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 16:48:05 +00:00
Sergey Biryukov
5bf387bb07
Customize: Avoid unnecessary get_theme_mod()
call and premature escaping in get_header_video_url()
.
...
The result is still escaped with `esc_url_raw()` for retrieval, and with `esc_url()` for display in `the_header_video_url()`.
Props dlh, Tkama.
Fixes #40044 .
Built from https://develop.svn.wordpress.org/trunk@47267
git-svn-id: http://core.svn.wordpress.org/trunk@47067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 16:36:06 +00:00
Andrea Fercia
0fcc994a8f
Media: Fix bottom spacing on various Media Modal elements for non-webkit browsers.
...
Implementation of bottom padding in overflow content differs across browsers. See https://github.com/w3c/csswg-drafts/issues/129 . To make bottom spacing consistent across browsers there's the need for an alternate CSS method.
- uses a CSS `after` pseudo element or simply a bottom margin to reserve some bottom spacing
- removes a couple leftovers from [40428]
- fixes an annoying visual glitch where the media modal content is visible behind the bottom toolbar border
Props sabernhardt, afercia.
See #40152 .
Fixes #48378 .
Built from https://develop.svn.wordpress.org/trunk@47266
git-svn-id: http://core.svn.wordpress.org/trunk@47066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 16:32:06 +00:00
K. Adam White
c85c8f5235
REST API: Introduce rest_{$this->post_type}_item_schema filter to enable manipulation of schema values.
...
register_rest_field can be used to add properties to a schema, but no mechanism existed to alter existing properties like "content".
Running the schema through this filter lets plugins append additional sub-properties to existing schema definitions.
Props luisherranz, TimothyBlynJacobs, swissspidy, westonruter, kadamwhite.
Fixes #47779 .
Built from https://develop.svn.wordpress.org/trunk@47265
git-svn-id: http://core.svn.wordpress.org/trunk@47065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 16:28:06 +00:00
ianbelanger
97524fd300
Bundled Themes: Twenty Twenty property border-style is overwritten - coding standard.
...
Fixes coding standard violations in the classic editor stylesheets.
Props ankitmaru.
Fixes #49006 .
Built from https://develop.svn.wordpress.org/trunk@47264
git-svn-id: http://core.svn.wordpress.org/trunk@47064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 16:11:06 +00:00
Sergey Biryukov
76718fbea3
Widgets: Prevent currently active wide widget controls from being partially covered by another widget's controls.
...
The currently active widget controls should always be displayed on top.
Props audrasjb, fervillz, rinkuyadav999, jaydeep23290, ashokrd2013, melchoyce, pento, westonruter, SergeyBiryukov.
Fixes #42001 .
Built from https://develop.svn.wordpress.org/trunk@47263
git-svn-id: http://core.svn.wordpress.org/trunk@47063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 15:26:09 +00:00
antpb
036eca242a
Media: Reset aspect ratio constraints when width and height fields fail numeric validation.
...
Props TBschen, valentinbora.
Fixes #49073 .
Built from https://develop.svn.wordpress.org/trunk@47262
git-svn-id: http://core.svn.wordpress.org/trunk@47062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 04:40:10 +00:00
K. Adam White
12709269c1
REST API: Allow meta to be set when creating a new media record via REST.
...
Props TimothyBlynJacobs, apermo.
Fixes #44567 .
Built from https://develop.svn.wordpress.org/trunk@47261
git-svn-id: http://core.svn.wordpress.org/trunk@47061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 03:39:06 +00:00
K. Adam White
23696bb074
REST API: Match REST API routes on namespace before performing regex checks.
...
Rule out groups of API endpoints by simple namespace string comparison to reduce the number of regex checks necessary when matching a route.
Props TimothyBlynJacobs.
Fixes #48530 .
Built from https://develop.svn.wordpress.org/trunk@47260
git-svn-id: http://core.svn.wordpress.org/trunk@47060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 03:22:05 +00:00
Andrew Ozz
3d126b2dc7
Media: Improve wording for error message on failed post-processing of uploaded images.
...
Props eclev91, desrosj, antpb, azaozz.
Fixes #49280 .
Built from https://develop.svn.wordpress.org/trunk@47259
git-svn-id: http://core.svn.wordpress.org/trunk@47059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 03:20:06 +00:00
K. Adam White
25d8f7240e
REST API: List all core theme feature support details in /themes endpoint response.
...
Fully list which first-party core theme features are supported in the /themes endpoint response. This brings the REST API themes controller's response more in line with the output of get_theme_support().
Props adamboro, apieschel, koke, spacedmonkey, TimothyBlynJacobs.
See #49037 .
Built from https://develop.svn.wordpress.org/trunk@47258
git-svn-id: http://core.svn.wordpress.org/trunk@47058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 02:00:07 +00:00
Sergey Biryukov
9614434049
Media: Improve the preview of transparent images in Image widget by using CSS3 to show a checkered background.
...
Props bahia0019.
Fixes #49237 .
Built from https://develop.svn.wordpress.org/trunk@47257
git-svn-id: http://core.svn.wordpress.org/trunk@47057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 01:47:06 +00:00
Sergey Biryukov
5d00e8f78b
Administration: Move .has-row-actions
class in Recent Comments dashboard widget next to .dashboard-comment-wrap
, for consistency.
...
Follow-up to [47255].
See #42938 .
Built from https://develop.svn.wordpress.org/trunk@47256
git-svn-id: http://core.svn.wordpress.org/trunk@47056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 01:21:05 +00:00
Sergey Biryukov
8c2fb2148b
Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen.
...
Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov.
Fixes #42938 .
Built from https://develop.svn.wordpress.org/trunk@47255
git-svn-id: http://core.svn.wordpress.org/trunk@47055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 01:17:06 +00:00
Sergey Biryukov
055af2b506
Site Health: Improve the wording for PHP update recommendations.
...
Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov.
Fixes #48716 .
Built from https://develop.svn.wordpress.org/trunk@47254
git-svn-id: http://core.svn.wordpress.org/trunk@47054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 00:41:05 +00:00
Sergey Biryukov
ca3366926a
Docs: Improve documentation for tests/phpunit/includes/spy-rest-server.php
.
...
Props andizer.
Fixes #47567 .
Built from https://develop.svn.wordpress.org/trunk@47253
git-svn-id: http://core.svn.wordpress.org/trunk@47053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 00:20:07 +00:00
Sergey Biryukov
984d1c60b5
Comments: Improve the appearance of the Status box on Edit Comment screen.
...
This makes the box more consistent with the Publish meta box in classic editor.
Props birgire, nfmohit, melchoyce, afercia.
Fixes #43587 .
Built from https://develop.svn.wordpress.org/trunk@47252
git-svn-id: http://core.svn.wordpress.org/trunk@47052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 00:06:04 +00:00
Sergey Biryukov
507d056b7e
Media: In media_sideload_image()
, store the original attachment URL in the _source_url
post meta value.
...
Props dshanske, joemcgill, antpb.
Fixes #48164 .
Built from https://develop.svn.wordpress.org/trunk@47251
git-svn-id: http://core.svn.wordpress.org/trunk@47051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 23:47:04 +00:00
jorgefilipecosta
56906bcf59
Block Editor: Update WordPress Packages; Remove navigation block; Add social links block
...
The following package versions were changed:
@wordpress/annotations: 1.11.0 -> 1.12.0
@wordpress/api-fetch: 3.10.0 -> 3.11.0
@wordpress/block-directory: 1.4.0 -> 1.5.0
@wordpress/block-editor: 3.6.0 -> 3.7.0
@wordpress/block-library: 2.13.0 -> 2.14.0
@wordpress/blocks: 6.11.0 -> 6.12.0
@wordpress/components: 9.1.0 -> 9.2.0
@wordpress/core-data: 2.11.0 -> 2.12.0
@wordpress/data: 4.13.0 -> 4.14.0
@wordpress/data-controls: 1.7.0 -> 1.8.0
@wordpress/e2e-test-utils: 4.2.0 -> 4.3.0
@wordpress/edit-post: 3.12.0 -> 3.13.0
@wordpress/editor: 9.11.0 -> 9.12.0
@wordpress/format-library: 1.13.0 -> 1.14.0
@wordpress/icons: 1.0.0 -> 1.1.0
@wordpress/keyboard-shortcuts: 1.0.0 -> 1.1.0
@wordpress/list-reusable-blocks: 1.12.0 -> 1.13.0
@wordpress/media-utils: 1.6.0 -> 1.7.0
@wordpress/notices: 1.12.0 -> 2.0.0
@wordpress/nux: 3.11.0 -> 3.12.0
@wordpress/plugins: 2.11.0 -> 2.12.0
@wordpress/primitives: 1.0.0 -> 1.1.0
@wordpress/rich-text: 3.11.0 -> 3.12.0
@wordpress/server-side-render: 1.7.0 -> 1.8.0
@wordpress/url: 2.10.0 -> 2.11.0
@wordpress/viewport: 2.12.0 -> 2.13.0
The navigation block inclusion was reverted.
The social links block was included.
Props gziolo, youknowriad, mcsf, noisysocks.
Fixes #49397 .
Built from https://develop.svn.wordpress.org/trunk@47250
git-svn-id: http://core.svn.wordpress.org/trunk@47050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 22:33:27 +00:00
Sergey Biryukov
363191d8ee
Docs: Improve documentation for the $attr
parameter of wp_get_attachment_image()
.
...
Props juanfra, Mte90, DrewAPicture, joemcgill, SergeyBiryukov.
Fixes #36661 .
Built from https://develop.svn.wordpress.org/trunk@47249
git-svn-id: http://core.svn.wordpress.org/trunk@47049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 22:03:07 +00:00
Sergey Biryukov
f8f24b49e6
Coding Standards: Fix JSHint issues in [47246].
...
See #44264 .
Built from https://develop.svn.wordpress.org/trunk@47248
git-svn-id: http://core.svn.wordpress.org/trunk@47048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 21:38:08 +00:00
Sergey Biryukov
13922a3210
Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column.
...
With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.
Props xkon, karmatosed.
Fixes #49323 .
Built from https://develop.svn.wordpress.org/trunk@47247
git-svn-id: http://core.svn.wordpress.org/trunk@47047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 21:15:05 +00:00
Sergey Biryukov
5ddf97e142
Privacy: Give progress indication for export and erasure.
...
This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data.
Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire.
Fixes #44264 .
Built from https://develop.svn.wordpress.org/trunk@47246
git-svn-id: http://core.svn.wordpress.org/trunk@47046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 20:19:05 +00:00
Sergey Biryukov
3342aafe5e
Privacy: Rename wp_get_user_request_data()
to wp_get_user_request()
for clarity; deprecate the old function.
...
The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property.
Follow-up to [44606].
Props garrett-eclipse.
Fixes #46302 .
Built from https://develop.svn.wordpress.org/trunk@47245
git-svn-id: http://core.svn.wordpress.org/trunk@47045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 19:57:05 +00:00
ianbelanger
99f402dc62
Bundled Themes: Twenty Twenty post navigation links outside of the container.
...
Fixes a bug where the in-page pagination does not align within the inner container.
Props ataurr, audrasjb, mukesh27.
Fixes #48979 .
Built from https://develop.svn.wordpress.org/trunk@47244
git-svn-id: http://core.svn.wordpress.org/trunk@47044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 19:25:05 +00:00
ianbelanger
598b2889a9
Bundled Themes: Twenty Twenty add WhatsApp to the social icon menu.
...
This adds WhatsApp as an option in the social icon menu.
Props rryyaanndd, audrasjb.
Fixes #49098 .
Built from https://develop.svn.wordpress.org/trunk@47243
git-svn-id: http://core.svn.wordpress.org/trunk@47043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 19:12:05 +00:00
Sergey Biryukov
762140cc6b
Twenty Nineteen: Add the missing inc/helper-functions.php
file.
...
Follow-up to [47214].
Props kjellr, jffng.
Fixes #45984 .
Built from https://develop.svn.wordpress.org/trunk@47242
git-svn-id: http://core.svn.wordpress.org/trunk@47042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 19:07:06 +00:00
ianbelanger
2b52ae5c1b
Bundled Themes: Twenty Twenty Author Bio/Post Meta Width in Cover Template in Mobile.
...
Fixes a bug where the author bio and post meta have no left or right padding in smaller viewports.
Props JarretC.
Fixes #49254 .
Built from https://develop.svn.wordpress.org/trunk@47241
git-svn-id: http://core.svn.wordpress.org/trunk@47041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 18:25:07 +00:00
jorgefilipecosta
76e375434b
Block Editor: Backport inclusion of new editor settings to the core.
...
This commit includes in the core settings for the gradients theme API stabilized in https://github.com/WordPress/gutenberg/pull/20107 , and for the image sizes required for the latest posts feature image https://github.com/WordPress/gutenberg/pull/17151/ .
Props: youknowriad, ryelle.
Fixes #49389 .
Built from https://develop.svn.wordpress.org/trunk@47240
git-svn-id: http://core.svn.wordpress.org/trunk@47040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 17:52:15 +00:00
TimothyBlynJacobs
7019add74e
REST API: Add support for the REDIRECT_HTTP_AUTHORIZATION header.
...
Previously the REST API did not account for server configurations where the Authorization header must be added using ModRewrite. This caused major DUX issues when trying to use custom authentication mechanisms.
Fixes #47077 .
Props dshanske, cklosows.
Built from https://develop.svn.wordpress.org/trunk@47239
git-svn-id: http://core.svn.wordpress.org/trunk@47039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 16:08:16 +00:00
aduth
4bff827833
Script Loader: Add polyfill for window.URL, window.DOMRect.
...
Pending block editor revisions for WordPress 5.4 will make use of `window.URL` and `window.DOMRect`. These are not available in Internet Explorer (or pre-Chromium Edge for `DOMRect`) and must be polyfilled to avoid script errors.
The changes make use of the existing polyfill pattern, and existing `polyfill-library` dependency. The dependency is bumped to the latest version, since the previous version did not include the `DOMRect` polyfill.
Props jorgefilipecosta.
Fixes #49360 .
Built from https://develop.svn.wordpress.org/trunk@47238
git-svn-id: http://core.svn.wordpress.org/trunk@47038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 15:17:07 +00:00
Sergey Biryukov
c14f2b74c0
Privacy: Include session tokens in Personal Data Export.
...
Session tokens contain an IP address and user agent.
Props garrett-eclipse, nickylimjj, lakenh, xkon, rconde.
Fixes #45889 .
Built from https://develop.svn.wordpress.org/trunk@47237
git-svn-id: http://core.svn.wordpress.org/trunk@47037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 05:44:04 +00:00
Sergey Biryukov
346f505a75
Privacy: Include community-events-location
user meta value in Personal Data Export.
...
The value is used by the WordPress Events and News widget to show relevant WP community events.
The location information may include an IP address, location description, and latitude/longitude coordinates.
Props garrett-eclipse, coreymckrill, xkon.
Fixes #43921 .
Built from https://develop.svn.wordpress.org/trunk@47236
git-svn-id: http://core.svn.wordpress.org/trunk@47036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 05:32:06 +00:00
Sergey Biryukov
d98fe66044
Site Health: Move the warning about WP_DEBUG_LOG
being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory.
...
Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon.
Fixes #47985 .
Built from https://develop.svn.wordpress.org/trunk@47235
git-svn-id: http://core.svn.wordpress.org/trunk@47035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 05:16:07 +00:00
Sergey Biryukov
4f151b577e
Administration: Standardize "found in Trash" messages.
...
Props Presskopp, audrasjb.
Fixes #38669 .
Built from https://develop.svn.wordpress.org/trunk@47234
git-svn-id: http://core.svn.wordpress.org/trunk@47034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 04:57:06 +00:00
Sergey Biryukov
a6949956d1
Administration: Capitalize Trash
consistently in various messages and comments.
...
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.
Props garrett-eclipse, aandrewdixon, Presskopp.
Fixes #45317 .
Built from https://develop.svn.wordpress.org/trunk@47233
git-svn-id: http://core.svn.wordpress.org/trunk@47033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 04:12:07 +00:00
Sergey Biryukov
02ae343849
Login and Registration: Clarify the message on "Lost Password" screen.
...
Props pbiron, Presskopp.
Fixes #49346 .
Built from https://develop.svn.wordpress.org/trunk@47232
git-svn-id: http://core.svn.wordpress.org/trunk@47032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 03:50:05 +00:00
Sergey Biryukov
c1fb007ff3
Docs: Add documentation for globals in wp-settings.php
.
...
Props chinteshprajapati.
Fixes #46253 .
Built from https://develop.svn.wordpress.org/trunk@47231
git-svn-id: http://core.svn.wordpress.org/trunk@47031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 03:34:05 +00:00
Sergey Biryukov
32edd58e4c
Docs: Add descriptions for some globals:
...
* `$wp_version`
* `$wp_local_package`
* `$required_php_version`
* `$required_mysql_version`
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47230
git-svn-id: http://core.svn.wordpress.org/trunk@47030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 03:30:06 +00:00
Andrew Ozz
e4f36258f9
Media: Ensure imgareaselect.js is not initialized twice for the same image. May happen when uploading an image into a post and then clicking on Edit Image.
...
Fixes #49262 .
Built from https://develop.svn.wordpress.org/trunk@47229
git-svn-id: http://core.svn.wordpress.org/trunk@47029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 02:54:05 +00:00
Sergey Biryukov
f13044b031
Editor: Add unique classes to .post-attributes-label-wrapper
paragraphs for easier JS or CSS targeting.
...
Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks.
Fixes #44408 .
Built from https://develop.svn.wordpress.org/trunk@47228
git-svn-id: http://core.svn.wordpress.org/trunk@47028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 02:29:06 +00:00
Sergey Biryukov
ddc8ddb294
Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins.
...
Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.
See #meta4706 for the corresponding WordPress.org API change.
Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994 . See #21307 .
Built from https://develop.svn.wordpress.org/trunk@47227
git-svn-id: http://core.svn.wordpress.org/trunk@47027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 02:12:06 +00:00
Sergey Biryukov
95edb66e53
Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure.
...
Props markjaquith, valentinbora.
Fixes #48490 .
Built from https://develop.svn.wordpress.org/trunk@47226
git-svn-id: http://core.svn.wordpress.org/trunk@47026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 01:52:04 +00:00
Sergey Biryukov
9bd75db1fc
Build/Test Tools: Expose port 3306 of MySQL container.
...
This only defines the container port to allow `docker-compose` to choose an ephemeral host port.
Props ocean90, peterwilsoncc.
Fixes #48281 .
Built from https://develop.svn.wordpress.org/trunk@47225
git-svn-id: http://core.svn.wordpress.org/trunk@47025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 21:22:05 +00:00
TimothyBlynJacobs
5ecd61023a
REST API: Introduce selective link embedding.
...
Previously the _embed flag would embed all embeddable links in a response even if only a subset of the links were necessary. Now, a list of link relations can be passed in the _embed parameter to restrict the list of embedded objects.
Props rheinardkorf, adamsilverstein, jnylen0, cklosows, chrisvanpatten, TimothyBlynJacobs.
Fixes #39696 .
Built from https://develop.svn.wordpress.org/trunk@47224
git-svn-id: http://core.svn.wordpress.org/trunk@47024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 20:54:05 +00:00
Aaron Jorbin
b21985f139
General: Fix HTML for get_calendar()
...
The <tfoot> element was allowed to precede the <tbody> element in HTML 5. However, that was changed in HTML 5.1 and <tfoot> must now follow <tbody>.
This removes the tfooot and instead uses a nav element for navigation between months.
Fixes : #39763
Props: isabel_brison, Harry Milatz, audrasjb, abhijitrakas, SergeyBiryukov
Built from https://develop.svn.wordpress.org/trunk@47223
git-svn-id: http://core.svn.wordpress.org/trunk@47023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 20:44:04 +00:00
joedolson
61ce35440c
Editor: Fix incorrect usage of ID attributes on custom fields.
...
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match.
Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964 .
Built from https://develop.svn.wordpress.org/trunk@47222
git-svn-id: http://core.svn.wordpress.org/trunk@47022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 19:41:07 +00:00
joedolson
1dbe25bc0a
Toolbar: Load toolbar in wp_body_open
when available.
...
For accessibility, the visual appearance and source order should match. Moving the toolbar to load in the new hook `wp_body_open` (5.2) fixes a long-standing source order problem.
Props jankimoradiya, afercia, SergeyBiryukov, audrasjb, ocean90, xkon, dinhtungdu.
Fixes #47053 .
Built from https://develop.svn.wordpress.org/trunk@47221
git-svn-id: http://core.svn.wordpress.org/trunk@47021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 18:26:08 +00:00
Sergey Biryukov
9429c8436d
Coding Standards: Correct the get_plugin_page_hook()
check in wp-admin/admin.php
.
...
The condition is meant to check for a non-empty string, however `get_plugin_page_hook()` can return null, in which case the strict check doesn't work as expected.
Follow-up to [47218].
See #48455 , #49222 .
Built from https://develop.svn.wordpress.org/trunk@47220
git-svn-id: http://core.svn.wordpress.org/trunk@47020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 17:08:03 +00:00
Sergey Biryukov
641c632b0c
Coding Standards: Use Yoda conditions where appropriate.
...
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47219
git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:55:09 +00:00
Sergey Biryukov
5e6c949861
Coding Standards: Use Yoda conditions in some wp-admin
files.
...
Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365 , #48455 .
Built from https://develop.svn.wordpress.org/trunk@47218
git-svn-id: http://core.svn.wordpress.org/trunk@47018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:53:06 +00:00
Andrea Fercia
f2edcb4421
Accessibility: Media: Make the toolbar and inline uploader visual order always match the DOM order.
...
Depending on the specific media view, the media UI elements are placed in a
different visual order. This change makes sure their visual order always
matches the DOM order.
Propos syhc, audrasjb, afercia.
See #37188 .
Fixes #48403 .
Built from https://develop.svn.wordpress.org/trunk@47217
git-svn-id: http://core.svn.wordpress.org/trunk@47017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:32:04 +00:00
Sergey Biryukov
f454fc8165
Embeds: Add support for TikTok.
...
Props audrasjb, jblz, peterwilsoncc, felipeloureirosantos.
Fixes #49083 .
Built from https://develop.svn.wordpress.org/trunk@47216
git-svn-id: http://core.svn.wordpress.org/trunk@47016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 04:55:06 +00:00
Sergey Biryukov
e713bf9a88
Site Health: Only get MySQL server information in tests where it's actually needed.
...
This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.
Props xkon, Otto42, Clorith.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47215
git-svn-id: http://core.svn.wordpress.org/trunk@47015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-08 20:10:05 +00:00
Sergey Biryukov
297aa098ae
Twenty Nineteen: Improve code organization in template-functions.php
by moving helper functions into their own file.
...
These functions are moved to `inc/helper-functions.php`:
* `twentynineteen_can_show_post_thumbnail()`
* `twentynineteen_image_filters_enabled()`
* `twentynineteen_get_avatar_size()`
* `twentynineteen_is_comment_by_post_author()`
* `twentynineteen_get_discussion_data()`
* `twentynineteen_hsl_hex()`
Additionally, `twentynineteen_add_dropdown_icons()` is moved to `inc/icon-functions.php` to join `twentynineteen_nav_menu_social_icons()`.
Props akshayar, allancole, grapplerulrich.
Fixes #45984 .
Built from https://develop.svn.wordpress.org/trunk@47214
git-svn-id: http://core.svn.wordpress.org/trunk@47014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-08 13:01:06 +00:00
Sergey Biryukov
7748f7082f
Menus: When adding a label for special pages in wp_setup_nav_menu_item()
, check if get_post_states()
is available, to avoid fatal errors on front end.
...
Fixes #49374 .
Built from https://develop.svn.wordpress.org/trunk@47213
git-svn-id: http://core.svn.wordpress.org/trunk@47013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-08 12:49:07 +00:00
Sergey Biryukov
8fa6586958
Tests: Add a basic test for wp()
function.
...
Props pbearne, donmhico.
Fixes #48844 .
Built from https://develop.svn.wordpress.org/trunk@47212
git-svn-id: http://core.svn.wordpress.org/trunk@47012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-08 05:31:07 +00:00
Sergey Biryukov
b70056dd70
Menus: Use get_post_states()
to denote special pages on the added menu item accordions.
...
Front Page, Posts Page, or Privacy Policy Page should now be marked as such on the added menu items.
Props garrett-eclipse.
Fixes #49374 .
Built from https://develop.svn.wordpress.org/trunk@47211
git-svn-id: http://core.svn.wordpress.org/trunk@47011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 23:46:05 +00:00
Sergey Biryukov
803feb30dd
Docs: Improve description for the $editor_id
parameter of wp_editor()
and _WP_Editors::editor()
.
...
The restictions mentioned for the parameter value should be consistenct.
Props pbiron, SergeyBiryukov.
Fixes #49384 .
Built from https://develop.svn.wordpress.org/trunk@47210
git-svn-id: http://core.svn.wordpress.org/trunk@47010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 23:30:05 +00:00
Sergey Biryukov
01f133ee28
Accessibility: Menus: Make tab panels in Add menu items
section more accessible for keyboard users.
...
Props audrasjb, afercia.
Fixes #49211 .
Built from https://develop.svn.wordpress.org/trunk@47209
git-svn-id: http://core.svn.wordpress.org/trunk@47009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 21:38:06 +00:00
Sergey Biryukov
052b8ebdbe
Accessibility: Customize: Improve focus styles for color picker and media upload button in Customizer.
...
Props audrasjb, timhavinga, afercia, karmatosed.
Fixes #48694 .
Built from https://develop.svn.wordpress.org/trunk@47208
git-svn-id: http://core.svn.wordpress.org/trunk@47008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 21:11:05 +00:00
Sergey Biryukov
b2a1146380
Coding Standards: Adjust coding standards to always omit parentheses for include
/require
statements.
...
These are language constructs, not function calls, so the parentheses are unnecessary.
This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream.
Follow-up to [47198].
Props desrosj, jrf, GaryJ.
Fixes #49376 .
Built from https://develop.svn.wordpress.org/trunk@47207
git-svn-id: http://core.svn.wordpress.org/trunk@47007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 19:16:06 +00:00
John Blackbourn
1f1fd617f5
Posts, Post Types: Add a parameter to the post_locked_dialog
action which contains a reference to the user who holds the lock.
...
Fixes #48443
Built from https://develop.svn.wordpress.org/trunk@47206
git-svn-id: http://core.svn.wordpress.org/trunk@47006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 17:53:06 +00:00
John Blackbourn
71f099fdb0
Taxonomy: Clarify the docs for the return values of the term_exists()
function.
...
Props dotancohen, sathyapulse
Fixes #43345
Built from https://develop.svn.wordpress.org/trunk@47205
git-svn-id: http://core.svn.wordpress.org/trunk@47005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 17:48:09 +00:00
John Blackbourn
701ad95968
Script Loader: Fix a docblock so it points to the correct page on the developer reference.
...
Props joyously, pbiron
Fixes #48503
Built from https://develop.svn.wordpress.org/trunk@47204
git-svn-id: http://core.svn.wordpress.org/trunk@47004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 17:42:06 +00:00
John Blackbourn
352ac8bf35
Posts, Post Types: Introduce a filter which allows the addition of __trashed
suffixes on post slugs to be skipped.
...
Fixes #46433
Built from https://develop.svn.wordpress.org/trunk@47203
git-svn-id: http://core.svn.wordpress.org/trunk@47003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 17:33:06 +00:00
Andrew Ozz
aea25de893
Media: Add link to the original image in the image properties if it was scaled or rotated after uploading.
...
Fixes #49290 .
Built from https://develop.svn.wordpress.org/trunk@47202
git-svn-id: http://core.svn.wordpress.org/trunk@47002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 05:13:05 +00:00
Sergey Biryukov
d1b39f784c
Tests: Revert the dirname( __FILE__ )
replacement in wp-tests-config-sample.php
for now, to avoid breaking unit tests created with WP-CLI scaffold
command.
...
Follow-up to [47198].
Props kaggdesign, danielbachhuber, bwmarkle.
Fixes #48082 , #49377 .
Built from https://develop.svn.wordpress.org/trunk@47201
git-svn-id: http://core.svn.wordpress.org/trunk@47001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 21:51:06 +00:00
Sergey Biryukov
b95cee937e
Tests: Change a few remaining include_once
statements to require_once
, for consistency.
...
See #48082 .
Built from https://develop.svn.wordpress.org/trunk@47200
git-svn-id: http://core.svn.wordpress.org/trunk@47000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 21:42:06 +00:00
jorgefilipecosta
d69005e1d8
Block Editor: Update WordPress Packages.
...
The following package versions were changed:
@wordpress/a11y: 2.6.0 -> 2.7.0
@wordpress/annotations: 1.10.0 -> 1.11.0
@wordpress/api-fetch: 3.9.0 -> 3.10.0
@wordpress/autop: 2.5.1 -> 2.6.0
@wordpress/blob: 2.6.0 -> 2.7.0
@wordpress/block-directory: 1.3.0 -> 1.4.0
@wordpress/block-editor: 3.5.0 -> 3.6.0
@wordpress/block-library: 2.12.0 -> 2.13.0
@wordpress/block-serialization-default-parser: 3.4.1 -> 3.5.0
@wordpress/blocks: 6.10.0 -> 6.11.0
@wordpress/components: 9.0.0 -> 9.1.0
@wordpress/compose: 3.10.0 -> 3.11.0
@wordpress/core-data: 2.10.0 -> 2.11.0
@wordpress/custom-templated-path-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/data: 4.12.0 -> 4.13.0
@wordpress/data-controls: 1.6.0 -> 1.7.0
@wordpress/date: 3.7.0 -> 3.8.0
@wordpress/dependency-extraction-webpack-plugin: 2.1.0 -> 2.2.0
@wordpress/deprecated: 2.6.1 -> 2.7.0
@wordpress/dom: 2.7.0 -> 2.8.0
@wordpress/dom-ready: 2.6.0 -> 2.7.0
@wordpress/e2e-test-utils: 4.1.0 -> 4.2.0
@wordpress/edit-post: 3.11.0 -> 3.12.0
@wordpress/editor: 9.10.0 -> 9.11.0
@wordpress/element: 2.10.0 -> 2.11.0
@wordpress/escape-html: 1.6.0 -> 1.7.0
@wordpress/format-library: 1.12.0 -> 1.13.0
@wordpress/hooks: 2.6.0 -> 2.7.0
@wordpress/html-entities: 2.5.0 -> 2.6.0
@wordpress/i18n: 3.8.0 -> 3.9.0
@wordpress/is-shallow-equal: 1.7.0 -> 1.8.0
@wordpress/keyboard-shortcuts: 0.2.0 -> 1.0.0
@wordpress/keycodes: 2.8.0 -> 2.9.0
@wordpress/library-export-default-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/list-reusable-blocks: 1.11.0 -> 1.12.0
@wordpress/media-utils: 1.5.0 -> 1.6.0
@wordpress/notices: 1.11.0 -> 1.12.0
@wordpress/nux: 3.10.0 -> 3.11.0
@wordpress/plugins: 2.10.0 -> 2.11.0
@wordpress/priority-queue: 1.4.0 -> 1.5.0
@wordpress/redux-routine: 3.6.2 -> 3.7.0
@wordpress/rich-text: 3.10.0 -> 3.11.0
@wordpress/scripts: 6.2.0 -> 7.0.0
@wordpress/server-side-render: 1.6.0 -> 1.7.0
@wordpress/shortcode: 2.5.0 -> 2.6.0
@wordpress/token-list: 1.8.0 -> 1.9.0
@wordpress/url: 2.9.0 -> 2.10.0
@wordpress/viewport: 2.11.0 -> 2.12.0
@wordpress/wordcount: 2.6.2 -> 2.7.0
Added these new packages:
@wordpress/warning
@wordpress/primitives
@wordpress/icons
Re-added keyboard-shortcuts to script loader removed by mistake on revision 47198.
Props gziolo, itsjonq, youknowriad, mcsf, andraganescu.
Fixes #49358 .
Built from https://develop.svn.wordpress.org/trunk@47199
git-svn-id: http://core.svn.wordpress.org/trunk@46999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 21:03:31 +00:00
Sergey Biryukov
47ed56f38f
Code Modernization: Replace dirname( __FILE__ )
calls with __DIR__
magic constant.
...
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.
This commit also includes:
* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
* `wp-admin/admin-header.php`
* `wp-admin/admin-footer.php`
* `wp-includes/version.php`
Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082 .
Built from https://develop.svn.wordpress.org/trunk@47198
git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
Sergey Biryukov
ecb8633dcc
Coding Standards: Move WP_Object_Cache
to wp-includes/class-wp-object-cache.php
.
...
This ensures the file containing the `WP_Object_Cache` class conforms to the coding standards.
For backward compatibility, the new file is included from `wp-includes/cache.php`.
Fixes #49373 . See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47197
git-svn-id: http://core.svn.wordpress.org/trunk@46997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 05:53:06 +00:00
Sergey Biryukov
39e133bce8
Posts, Post Types: Add default menu_icon
values for built-in post types.
...
This allows the icons to be retrieved via `get_post_type_object()`.
Props m.usama.masood, michael.ecklund, SergeyBiryukov.
Fixes #38844 .
Built from https://develop.svn.wordpress.org/trunk@47196
git-svn-id: http://core.svn.wordpress.org/trunk@46996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 22:40:05 +00:00
Sergey Biryukov
9bb7789f07
Tests: In Tests_dbDelta
, only force MyISAM database engine on MySQL versions older than 5.7.
...
Since MySQL 5.7, InnoDB engine supports `FULLTEXT` indexes, so forcing MyISAM is unnecessary.
Follow-up to [47193], which addressed the issue in `Tests_dbDelta::setUp()`, but missed other tests.
Props xkon, joonasvanhatapio, SergeyBiryukov.
Fixes #49367 .
Built from https://develop.svn.wordpress.org/trunk@47195
git-svn-id: http://core.svn.wordpress.org/trunk@46995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 22:07:05 +00:00
Sergey Biryukov
9ed35cf902
Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image".
...
This makes it more consistent with other UI elements in the block editor.
Props mcsf.
Fixes #49371 .
Built from https://develop.svn.wordpress.org/trunk@47194
git-svn-id: http://core.svn.wordpress.org/trunk@46994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 19:09:05 +00:00
Sergey Biryukov
6c1ee98e22
Tests: In Tests_dbDelta::setUp()
, only force MyISAM database engine on MySQL versions older than 5.7.
...
Since MySQL 5.7, InnoDB engine supports `FULLTEXT` indexes, so forcing MyISAM is unnecessary.
Props xkon, joonasvanhatapio, SergeyBiryukov.
Fixes #49367 .
Built from https://develop.svn.wordpress.org/trunk@47193
git-svn-id: http://core.svn.wordpress.org/trunk@46993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 18:21:03 +00:00
ianbelanger
02d01de6c5
Bundled Themes: Twenty Twenty Menu rendering problem Unicode (Bangla).
...
Fixes a bug where certain words break on to a second line in the primary and footer menus, in certain languages.
Props smallprogrammers, Shital Patel, mukesh27, audrasjb.
Fixes #48970 .
Built from https://develop.svn.wordpress.org/trunk@47192
git-svn-id: http://core.svn.wordpress.org/trunk@46992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 15:02:05 +00:00
Sergey Biryukov
0544629460
Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block.
...
Props audrasjb, jeroenrotty.
Fixes #48120 .
Built from https://develop.svn.wordpress.org/trunk@47191
git-svn-id: http://core.svn.wordpress.org/trunk@46991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 08:10:05 +00:00
Sergey Biryukov
44288356e2
Menus: Introduce wp_nav_menu_item_custom_fields
action that fires just before the move buttons of a nav menu item in the menu editor.
...
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056 . See #38904 , #18584 .
Built from https://develop.svn.wordpress.org/trunk@47190
git-svn-id: http://core.svn.wordpress.org/trunk@46990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:43:05 +00:00
Sergey Biryukov
84c43d1863
Docs: Correct type for $item
and $args parameters in
Walker_Nav_Menu_Checklist and
Walker_Nav_Menu_Edit to match the parent
Walker_Nav_Menu` class.
...
Follow-up to [38559], [45537].
See #24587 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47189
git-svn-id: http://core.svn.wordpress.org/trunk@46989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:25:05 +00:00
Sergey Biryukov
c32e05f308
Site Health: Improve focus style for accordion items on Site Health screens.
...
The new style is more consistent with other elements like `.wp-core-ui` buttons.
Props audrasjb, mensmaximus, afercia, melchoyce, Clorith.
Fixes #48578 .
Built from https://develop.svn.wordpress.org/trunk@47188
git-svn-id: http://core.svn.wordpress.org/trunk@46988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:43:04 +00:00
Sergey Biryukov
fa0563c877
Docs: Add a @since
note for [47186].
...
See #48558 .
Built from https://develop.svn.wordpress.org/trunk@47187
git-svn-id: http://core.svn.wordpress.org/trunk@46987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:33:04 +00:00
Sergey Biryukov
4f422b028d
Taxonomy: In register_taxonomy()
, return the registered taxonomy object on success, for consistency with register_post_type()
.
...
Props krynes, SergeyBiryukov.
Fixes #48558 .
Built from https://develop.svn.wordpress.org/trunk@47186
git-svn-id: http://core.svn.wordpress.org/trunk@46986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:26:06 +00:00
Sergey Biryukov
b3f75c66f4
Coding Standards: Fix WPCS issue in [47184].
...
See #49344 .
Built from https://develop.svn.wordpress.org/trunk@47185
git-svn-id: http://core.svn.wordpress.org/trunk@46985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 05:03:05 +00:00
Sergey Biryukov
0561e81ecc
Tests: Allow dbDelta()
tests to (mostly) run on MySQL 8.0.11+.
...
* MySQL 8.0.11 changed the `GeometryCollection` data type name to `GeomCollection`, with the latter being the preferred name.
* MySQL 8.0.17 removed support for the display width attribute for integer data types. Previously, default display width of 20 digits was used: `BIGINT(20)`.
The affected tests now check the MySQL server version and use the appropriate data types.
This leaves one unresolved failure on MySQL 8.0.17+ to be addressed in the future, caused by the same `BIGINT` display width discrepancy coming from `wp_get_db_schema()`.
Props kaggdesign, ottok, jeremyfelt, SergeyBiryukov.
Fixes #44384 , #49344 . See #49364 .
Built from https://develop.svn.wordpress.org/trunk@47184
git-svn-id: http://core.svn.wordpress.org/trunk@46984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 04:30:04 +00:00
Sergey Biryukov
ccdc1db0a9
Tests: Allow wpdb::set_sql_mode()
tests to run on MySQL 8.0.11+.
...
MySQL 8.0.11 removed support for the `NO_AUTO_CREATE_USER` SQL mode, which was used in as an example of a mode compatible with WordPress.
`NO_AUTO_VALUE_ON_ZERO` is now used in the affected tests instead, which is supported on both MySQL 5.7.x and 8.0.x.
Props kaggdesign, jeremyfelt, afragen.
Fixes #44586 . See #49344 .
Built from https://develop.svn.wordpress.org/trunk@47183
git-svn-id: http://core.svn.wordpress.org/trunk@46983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 03:30:05 +00:00
Sergey Biryukov
e2440d55e7
Docs: Clarify that is_page_template()
accepts a template filename, not the Template Name
file header.
...
Props mkaz.
Fixes #49362 .
Built from https://develop.svn.wordpress.org/trunk@47182
git-svn-id: http://core.svn.wordpress.org/trunk@46982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 03:14:06 +00:00
Sergey Biryukov
a16f3f8f13
Posts, Post Types: Fail gracefully when checking whether a single post with an unregistered post status should be displayed in WP_Query::get_posts()
.
...
If the post status is not registered, assume it's not public, but still allow access to users with edit permissions (same as for a protected post status, e.g. `draft`), so that they could recover orphaned content.
Add unit tests.
Follow-up to [47178].
Props roytanck, SergeyBiryukov.
Fixes #48653 .
Built from https://develop.svn.wordpress.org/trunk@47181
git-svn-id: http://core.svn.wordpress.org/trunk@46981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 01:33:05 +00:00
Sergey Biryukov
da6f24fba9
Posts, Post Types: Revert [47179] pending test failures investigation.
...
See #48653 .
Built from https://develop.svn.wordpress.org/trunk@47180
git-svn-id: http://core.svn.wordpress.org/trunk@46980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 23:02:09 +00:00
Sergey Biryukov
73a088f5b6
Posts, Post Types: Fail gracefully when checking whether the post should be displayed in WP_Query::get_posts()
against unregistered post status.
...
If the post status is not registered, assume it's not public.
Follow-up to [47178].
Props roytanck.
See #48653 .
Built from https://develop.svn.wordpress.org/trunk@47179
git-svn-id: http://core.svn.wordpress.org/trunk@46979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 22:22:06 +00:00
Sergey Biryukov
46951e0b17
Posts, Post Types: Fail gracefully when checking mapped cap against unregistered post status.
...
With `map_meta_cap` enabled for a post type, the `read_post` capability for posts with a public status is supposed to be mapped to the post type's `read` capability.
When a post is left in the database after the post status is no longer present, and WP does a `read_post` check against it, a PHP notice was thrown, and the cap check always failed.
As a more graceful fallback, the cap is now mapped onto `edit_others_posts`, which allows highly privileged users to be able to access orphaned content.
A `_doing_it_wrong()` notice is also added, so that developers and site administrators are aware that the cap mapping is failing in the absence of the registered post status.
Follow-up to [34091], which introduced a similar approach to checking mapped caps against an unregistered post type.
Props roytanck, SergeyBiryukov.
Fixes #48653 .
Built from https://develop.svn.wordpress.org/trunk@47178
git-svn-id: http://core.svn.wordpress.org/trunk@46978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 22:15:08 +00:00
Sergey Biryukov
3882b3f567
Coding Standards: Fix WPCS issues in [47175].
...
See #49361 .
Built from https://develop.svn.wordpress.org/trunk@47177
git-svn-id: http://core.svn.wordpress.org/trunk@46977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 21:42:04 +00:00
jorgefilipecosta
d7e321c7c7
Block Editor: Include navigation block server logic.
...
Core did not include the navigation block PHP files.
This commit fixes the issue referred, and now the navigation block is executed on the frontend. The block still does not work as expected and throws an error during frontend execution. That problem is going to be fixed on the next WordPress package update.
This commit adds the file as it is on the npm package used.
Props gziolo.
Fixes #49348 .
Built from https://develop.svn.wordpress.org/trunk@47176
git-svn-id: http://core.svn.wordpress.org/trunk@46976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 20:16:04 +00:00
Sergey Biryukov
d3a9952838
Users: Pass the $reassign
parameter to the remove_user_from_blog
action.
...
Props Tivus.
Fixes #49361 .
Built from https://develop.svn.wordpress.org/trunk@47175
git-svn-id: http://core.svn.wordpress.org/trunk@46975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:43:03 +00:00
Sergey Biryukov
761644c636
Docs: Improve description for add_user_to_blog()
and remove_user_from_blog()
parameters.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47174
git-svn-id: http://core.svn.wordpress.org/trunk@46974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:40:06 +00:00
Sergey Biryukov
be057c4a1c
Users: In remove_user_from_blog()
:
...
* Change default value of the `$blog_id` parameter to match the documented type.
* Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`.
* Add documentation for the return value.
See #49361 .
Built from https://develop.svn.wordpress.org/trunk@47173
git-svn-id: http://core.svn.wordpress.org/trunk@46973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:36:04 +00:00
Sergey Biryukov
e956bbebe1
TinyMCE: Remove duplicate keys and strings from langs/wp-langs-en.js
.
...
Props david.binda.
Fixes #49359 .
Built from https://develop.svn.wordpress.org/trunk@47172
git-svn-id: http://core.svn.wordpress.org/trunk@46972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 16:43:07 +00:00
Sergey Biryukov
143c6a1de8
Database: Add ANSI
to the list of incompatible SQL modes.
...
Starting with MySQL 5.7.5, the `ANSI` mode implies `ONLY_FULL_GROUP_BY`, which is already listed in `wpdb` as incompatible per [27072].
When `ANSI` is enabled on MySQL 5.7.5+, `ONLY_FULL_GROUP_BY` remains enabled even after being "unset" by `wpdb::set_sql_mode()`.
To prevent this, the `ANSI` mode should also be listed as incompatible. It is not enabled on default MySQL installations.
Props jnylen0.
Fixes #48377 .
Built from https://develop.svn.wordpress.org/trunk@47171
git-svn-id: http://core.svn.wordpress.org/trunk@46971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 01:14:07 +00:00
Sergey Biryukov
c289bb59ac
Docs: Improve documentation for WP_Dependencies
, WP_Scripts
, and WP_Styles
methods.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47170
git-svn-id: http://core.svn.wordpress.org/trunk@46970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-03 00:19:03 +00:00
Sergey Biryukov
982a6453c9
Canonical: When removing trailing punctuation from query string arguments, match the whole query var name.
...
Props daveslaughter.
Fixes #49347 .
Built from https://develop.svn.wordpress.org/trunk@47169
git-svn-id: http://core.svn.wordpress.org/trunk@46969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-03 00:14:07 +00:00
gziolo
bfc5248126
Build: Copy block metadata files for dynamic blocks.
...
For dynamic blocks, there are several blocks whose metadata needs to be loaded in PHP. The attributes that are loaded via PHP are not exposed to the ReactNative components when Gutenberg loads the index.js files in the Mobile Apps. To support one master set of metadata that can be used to register in the PHP files and the Javascript files; with this patch, the block.json files are copied over with their corresponding PHP files.
Props chipsnyder and azaozz.
Fixes #49196 .
Built from https://develop.svn.wordpress.org/trunk@47168
git-svn-id: http://core.svn.wordpress.org/trunk@46968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 19:19:04 +00:00
Sergey Biryukov
8163215dc4
Plugins: Remove obsolete plugin_slugs
transient from WP_Plugins_List_Table::prepare_items()
.
...
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].
The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.
Props aftabmuni.
Fixes #49340 .
Built from https://develop.svn.wordpress.org/trunk@47167
git-svn-id: http://core.svn.wordpress.org/trunk@46967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 15:50:04 +00:00
Sergey Biryukov
e79f7f71aa
REST API: Merge "not allowed to create new terms" permission error message with an existing string.
...
Follow-up to [39309], [39313].
See #38857 .
Built from https://develop.svn.wordpress.org/trunk@47166
git-svn-id: http://core.svn.wordpress.org/trunk@46966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 05:41:03 +00:00
Sergey Biryukov
f51b4579d5
Docs: Fix typo in a comment with WP_DEBUG_DISPLAY
description.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47165
git-svn-id: http://core.svn.wordpress.org/trunk@46965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 05:34:05 +00:00
Sergey Biryukov
11fb46d4c6
Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
...
The original script was deprecated in [30338] and removed in [32677].
Props Presskopp, ketuchetan.
Fixes #39448 .
Built from https://develop.svn.wordpress.org/trunk@47164
git-svn-id: http://core.svn.wordpress.org/trunk@46964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 04:15:03 +00:00
Sergey Biryukov
9ce9450bf9
Tests: Adjust XML-RPC unit tests for [47160].
...
Follow-up to [47162].
See #40096 .
Built from https://develop.svn.wordpress.org/trunk@47163
git-svn-id: http://core.svn.wordpress.org/trunk@46963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 04:09:04 +00:00
Sergey Biryukov
11dc73b383
Tests: Adjust XML-RPC unit tests for [47160].
...
See #40096 .
Built from https://develop.svn.wordpress.org/trunk@47162
git-svn-id: http://core.svn.wordpress.org/trunk@46962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 03:32:04 +00:00
Sergey Biryukov
2f58dc5ce9
Docs: Add more specific description for WP_Http::processResponse()
return value.
...
Props marekdedic, takeshifurusato.
Fixes #48351 .
Built from https://develop.svn.wordpress.org/trunk@47161
git-svn-id: http://core.svn.wordpress.org/trunk@46961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 03:27:05 +00:00
Sergey Biryukov
7e331ab235
Post Thumbnails: Make sure get_post_thumbnail_id()
returns an integer, to match the documented return value.
...
This makes the function more consistent with `get_the_ID()` or `wp_get_post_parent_id()`, both returning an integer.
Props 0v3rth3d4wn.
Fixes #40096 .
Built from https://develop.svn.wordpress.org/trunk@47160
git-svn-id: http://core.svn.wordpress.org/trunk@46960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 03:08:04 +00:00
Sergey Biryukov
c94722d9bc
Docs: Improve inline comments in wp-admin/options.php
per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47159
git-svn-id: http://core.svn.wordpress.org/trunk@46959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 02:42:04 +00:00
Sergey Biryukov
a0f8b7003b
Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers.
...
Props tdlewis77, williampatton.
Fixes #42941 .
Built from https://develop.svn.wordpress.org/trunk@47158
git-svn-id: http://core.svn.wordpress.org/trunk@46958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:42:06 +00:00
Sergey Biryukov
8e37999368
Docs: Correct DocBlock formatting for register_setting()
.
...
Document the full list of whitelisted option key names.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47157
git-svn-id: http://core.svn.wordpress.org/trunk@46957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:01:07 +00:00
Sergey Biryukov
deb1886078
Accessibility: Text Changes: Use sentence case for the word Error
in various error messages, instead of all caps.
...
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.
Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656 , #43037 , #42945 .
Built from https://develop.svn.wordpress.org/trunk@47156
git-svn-id: http://core.svn.wordpress.org/trunk@46956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 21:38:04 +00:00
Sergey Biryukov
15a6accec4
Tests: Update the expected message in test_with_draft_post()
.
...
Follow-up to [47154].
See #42945 .
Built from https://develop.svn.wordpress.org/trunk@47155
git-svn-id: http://core.svn.wordpress.org/trunk@46955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 21:13:05 +00:00
Sergey Biryukov
2fe7c95153
Text Changes: Capitalize error messages consistently.
...
Props Presskopp.
Fixes #42945 .
Built from https://develop.svn.wordpress.org/trunk@47154
git-svn-id: http://core.svn.wordpress.org/trunk@46954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:55:05 +00:00
Sergey Biryukov
12a6907123
Text Changes: Add missing periods to some error messages, for consistency.
...
Props Presskopp.
Fixes #42735 .
Built from https://develop.svn.wordpress.org/trunk@47153
git-svn-id: http://core.svn.wordpress.org/trunk@46953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:32:05 +00:00
Sergey Biryukov
21548ad0de
Text Changes: Add missing periods to comment status update notices, for consistency.
...
Props Presskopp.
See #42735 .
Built from https://develop.svn.wordpress.org/trunk@47152
git-svn-id: http://core.svn.wordpress.org/trunk@46952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:29:05 +00:00