Commit Graph

27 Commits

Author SHA1 Message Date
Ryan Boren
f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Andrew Nacin
f5e7edf2f2 Add manual new lines to a string, as double quotes with \n is not optimal due to sprintf-parsing reasons. props SergeyBiryukov, fixes #22486. see #22260.
git-svn-id: http://core.svn.wordpress.org/trunk@22664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:11:42 +00:00
Peter Westwood
1f76fa3703 i18n: Fix the usage of sprintf replacements in the Multisite Network Admin new site page. See #22260.
git-svn-id: http://core.svn.wordpress.org/trunk@22272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-23 11:30:09 +00:00
Ryan Boren
51920e1858 Consolidate some strings. Props pavelevap, SergeyBiryukov. see #21728
git-svn-id: http://core.svn.wordpress.org/trunk@22124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 19:04:34 +00:00
Mark Jaquith
e3dc0220ff Make Multisite work when WordPress is installed in a subdirectory. You can now have WordPress Multisite as an SVN external or a Git submodule! props johnjamesjacoby, evansolomon, duck_, jakemgold, nacin, markjaquith. see #19796
git-svn-id: http://core.svn.wordpress.org/trunk@22042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 06:07:21 +00:00
nacin
eb8e069932 Correct the link to http://codex.wordpress.org/Network_Admin_Sites_Screen in the network admin help sidebars. props Nao. fixes #20607.
git-svn-id: http://core.svn.wordpress.org/trunk@20713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-03 13:34:33 +00:00
nacin
b82ddbd98b Do not break a domain on network/site-new.php across two lines. props SergeyBiryukov, fixes #19895.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-27 19:02:10 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan
8ace5a6b4c Use WP_Screen::add_help_tab(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 02:22:07 +00:00
ryan
81a03236ec Use get_site_url() instead of hard-coding the protocol. Props SergeyBiryukov, exell.christopher. fixes #17466
git-svn-id: http://svn.automattic.com/wordpress/trunk@19211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-08 14:13:42 +00:00
nacin
cece838d8f More s/add_help_sidebar/set_help_sidebar/. fixes #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 21:32:16 +00:00
ryan
366db8c10b Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 05:33:53 +00:00
nacin
43eae59235 Translated strings in attributes require esc_attr(). s/_e/esc_attr_e/g
git-svn-id: http://svn.automattic.com/wordpress/trunk@19028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-20 15:04:46 +00:00
nacin
f2a6d07a9d Add 'Visit Dashboard' and 'Edit Site' links to the site added message on site-new.php. props vegasgeek, SergeyBiryukov. fixes #18047. fixes #17313.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-22 07:17:27 +00:00
ryan
e3418e214e Allow creating sites with IDN domains. Props SergeyBiryukov, wpmuguru. fixes #15554
git-svn-id: http://svn.automattic.com/wordpress/trunk@18473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-26 21:35:39 +00:00
nacin
b1c557fa4b D'oh. Use the proper URL to the multisite support forum. see #15880.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-25 19:21:00 +00:00
nacin
0f2672e53d Move to what will be the new Network Admin Codex page URLs. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-18 18:27:12 +00:00
nacin
31b4959b1b Minor cleanups.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 07:41:38 +00:00
nacin
d0e27b0935 Network Admin contextual help. props andrea_r (!), see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:52:47 +00:00
ryan
f721d88eda Whitespace cleanup. Props sorich87. see #14147
git-svn-id: http://svn.automattic.com/wordpress/trunk@16306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 16:57:22 +00:00
westi
ae213c99ca Generate Human Readable passwords as they are much more userfriendly. Fixes #13324 props Otto42.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 23:31:54 +00:00
nacin
f269b75d7b Network admin multisite checks and docs. see #14435.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 14:27:15 +00:00
nacin
0a943555ef And site-new, too. props PeteMall, see #15174.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 20:31:01 +00:00
nacin
99a5439b44 Add @since to new file. props markmcwilliams. see #15174.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 15:38:50 +00:00
ryan
23bc3f7fe6 Move add site form to site-new.php. see #15174
git-svn-id: http://svn.automattic.com/wordpress/trunk@15886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 13:49:49 +00:00