Commit Graph

28040 Commits

Author SHA1 Message Date
Dominik Schilling
6d83c8c29e Customizer: Add support for the media library in Background Image controls.
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.

props celloexpressions, and ericlewis for docs.
see #21483.
Built from https://develop.svn.wordpress.org/trunk@30309


git-svn-id: http://core.svn.wordpress.org/trunk@30308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 23:52:22 +00:00
Dominik Schilling
8b32164b67 Customizer: Trigger widget-added event when initializing.
Widget controls are now added to the pane dynamically via JavaScript, see #28709.
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.

props westonruter.
fixes #30236.
Built from https://develop.svn.wordpress.org/trunk@30308


git-svn-id: http://core.svn.wordpress.org/trunk@30307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:46:23 +00:00
Dominik Schilling
d21799ee1f Customizer: Use jQuery.fn.toggle() instead of slideUp/slideDown if panel/section/control is not inserted into DOM yet.
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709.

props westonruter.
fixes #30251.
Built from https://develop.svn.wordpress.org/trunk@30307


git-svn-id: http://core.svn.wordpress.org/trunk@30306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:37:22 +00:00
Dominik Schilling
b250062311 Customizer: When navigating around the site within the Customizer preview, update the document title.
props westonruter.
fixes #28542.
Built from https://develop.svn.wordpress.org/trunk@30306


git-svn-id: http://core.svn.wordpress.org/trunk@30305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 22:29:23 +00:00
Ian Stewart
1317409eda Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name.
Props celloexpressions, see #29988


Built from https://develop.svn.wordpress.org/trunk@30305


git-svn-id: http://core.svn.wordpress.org/trunk@30304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:36:23 +00:00
Ian Stewart
87bd82a0ab Twenty Fifteen: simplify the code used to generate screen reader text for the is_home title.
Props davidakennedy, fixes #30305


Built from https://develop.svn.wordpress.org/trunk@30304


git-svn-id: http://core.svn.wordpress.org/trunk@30303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:24:22 +00:00
Ian Stewart
47ec29c1ba Twenty Fifteen: create consistent spacing with embeds and images.
Props afercia, fixes #30286


Built from https://develop.svn.wordpress.org/trunk@30303


git-svn-id: http://core.svn.wordpress.org/trunk@30302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:04:21 +00:00
Ian Stewart
1f2397af34 Twenty Fifteen: simpler CSS by using divs instead of spans for menu descriptions.
Props philiparthurmoore, fixes #30296


Built from https://develop.svn.wordpress.org/trunk@30302


git-svn-id: http://core.svn.wordpress.org/trunk@30301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:02:22 +00:00
Boone Gorges
5fe8fa2b40 Correct grammar error in WP_Date_Query error message.
Props Offereins.
See #25834.
Built from https://develop.svn.wordpress.org/trunk@30301


git-svn-id: http://core.svn.wordpress.org/trunk@30300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 14:56:24 +00:00
Boone Gorges
4cf91d7c1d Improve localization for WP_Date_Query error strings.
* Don't create an extra variable for the string when it's only used once.
* Avoid using `<code>` HTML tags inside of translatable string.
* Improve data types and escaping on sprintfed values.

Props dd32.
Fixes #25834.
Built from https://develop.svn.wordpress.org/trunk@30300


git-svn-id: http://core.svn.wordpress.org/trunk@30299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 13:24:24 +00:00
Gary Pendergast
21467af4db wpdb: When flushing results on a mysqli connection, make sure that wpdb::$dbh is a valid mysqli connection handle.
Fixes a unit test failure introduced in [30297].

Fixes #28155.

Props soulseekah.


Built from https://develop.svn.wordpress.org/trunk@30299


git-svn-id: http://core.svn.wordpress.org/trunk@30298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 02:17:28 +00:00
Boone Gorges
dd61164577 Exclude external-http tests when running phpunit.
The external-http tests are very slow, and `Wp_Http` functionality is fairly
isolated, so the benefits of skipping these tests by default outweigh the
risks.

A `grunt phpunit:external-http` subtask has been added, to ensure that the
tests are executed during exhaustive runs of the test suite, such as in
continuous integration.

Fixes #30304.
Built from https://develop.svn.wordpress.org/trunk@30298


git-svn-id: http://core.svn.wordpress.org/trunk@30297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 14:49:24 +00:00
Gary Pendergast
0013150649 wpdb::flush() was not flushing results correctly when using mysqli.
This change also allows stored procedures or queries made with `mysqli_multi_query()` to be flushed.

Includes unit tests.

Fixes #28155.

Props soulseekah.

Built from https://develop.svn.wordpress.org/trunk@30297


git-svn-id: http://core.svn.wordpress.org/trunk@30296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 05:40:23 +00:00
Andrew Ozz
5f27bdc78d TinyMCE: enable direct calls to _WP_Editors::wp_mce_translation(). When using TinyMCE directly, this makes it easier to load the translation of the default strings. Fixes #30293.
Built from https://develop.svn.wordpress.org/trunk@30296


git-svn-id: http://core.svn.wordpress.org/trunk@30295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:07:22 +00:00
Boone Gorges
383c75db29 Fix PHP notice in Tests_Feed_RSS2::test_items().
A notice was being thrown when `get_the_tags()` returned false, and `foreach()`
was run over that return value.

See [30283].
Built from https://develop.svn.wordpress.org/trunk@30295


git-svn-id: http://core.svn.wordpress.org/trunk@30294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:05:22 +00:00
Andrew Ozz
b3da068590 TinyMCE: remove strings that are not translated before outputting the translations. Fixes #27797.
Built from https://develop.svn.wordpress.org/trunk@30294


git-svn-id: http://core.svn.wordpress.org/trunk@30293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 02:00:22 +00:00
Andrew Ozz
ba10ab197b Heartbeat:
- Use the page visibility API (when available) and document.hasFocus() instead of window.onfocus/onblur. Improves speeding up/slowing down the interval and works for iframes by default.
- Add a setting for minimal interval. Maximum value is 10 min. This overrides all other intervals and cannot be changed after setting it at initialization. Can be used to reduce the frequency of requests on hosts that have low limits for used CPU time, etc.
- Extend the setting of interval to support 120 sec. (60 sec, is still the default).
- Always suspend after one hour of keyboard/mouse/touch inactivity.
Fixes #29779.
Built from https://develop.svn.wordpress.org/trunk@30293


git-svn-id: http://core.svn.wordpress.org/trunk@30292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-10 01:47:24 +00:00
Gary Pendergast
f572927353 WPDB's __get() function should perform strict comparisons against member names
Built from https://develop.svn.wordpress.org/trunk@30292


git-svn-id: http://core.svn.wordpress.org/trunk@30291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-09 12:04:23 +00:00
Aaron Jorbin
2508d31b81 Remove failing Unbalanced tags tests
Patch with tests added to #6297 for use in the future

Props MikeHansenMe for creating patch of current unit test

see #30284

Built from https://develop.svn.wordpress.org/trunk@30291


git-svn-id: http://core.svn.wordpress.org/trunk@30290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 23:15:23 +00:00
Aaron Jorbin
70416f2225 Remove failing shortcode unit tests
Test added to #14050 in case we want to include it in a future fix.

see #30284


Built from https://develop.svn.wordpress.org/trunk@30290


git-svn-id: http://core.svn.wordpress.org/trunk@30289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 22:51:22 +00:00
Aaron Jorbin
2ed6de333b Remove failing uploadfile test in trunk
The test has been added to #11946 and can be readded when that ticket is fixed.

Props MikeHansenMe for creating patch of current unit test

See #30284


Built from https://develop.svn.wordpress.org/trunk@30289


git-svn-id: http://core.svn.wordpress.org/trunk@30288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:56:22 +00:00
Drew Jaynes
3e94d3a931 Fix incorrect documentation in the DocBlocks for get_lastpostmodified() and _get_last_post_time().
Props ericlewis for the initial patch.
Fixes #30249.

Built from https://develop.svn.wordpress.org/trunk@30287


git-svn-id: http://core.svn.wordpress.org/trunk@30287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:08:45 +00:00
Jeremy Felt
112f854021 Move tests for ms_files_rewriting to separate group, ms-files
When the `ms_files_rewriting` flag is enabled, `ms_upload_constants()` is required to properly set upload directory constants. Once this fires, it is impossible to clean up for a non `ms_files_rewriting` test by turning the option back off.

Excluding these tests by default offer a more consistent environment overall. Any tests written for uploaded files in multisite should ideally have a correspondign test in this area.

This commit also moves existing `ms_files_rewriting` tests for `test_switch_upload_dir()`.

Fixes #30256

Built from https://develop.svn.wordpress.org/trunk@30286


git-svn-id: http://core.svn.wordpress.org/trunk@30286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:08:24 +00:00
Boone Gorges
ef442d8224 Remove failing test related to post galleries.
It relied on the old _WPDataset technique, which is no longer used.

The test has been added to #UT30 as a patch, in case anyone wants to make
future use of it.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30285


git-svn-id: http://core.svn.wordpress.org/trunk@30285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 21:02:22 +00:00
Drew Jaynes
92c153aa8c Fix the syntax for some status-related documentation introduced in [30155].
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description

See #30230.

Built from https://develop.svn.wordpress.org/trunk@30284


git-svn-id: http://core.svn.wordpress.org/trunk@30284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:56:22 +00:00
Boone Gorges
77e2821d54 Improve Tests_Feed_RSS2::test_items().
* Better reference to post author, to avoid PHP notices.
* Code styling.
* More reliable checking of tags and categories.

Props kurtpayne.
Fixes #UT32. See #30284.
Built from https://develop.svn.wordpress.org/trunk@30283


git-svn-id: http://core.svn.wordpress.org/trunk@30283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:55:22 +00:00
Boone Gorges
9e5cb0301c Remove failing unit tests from 'canonical' group.
Each removed test has been turned into a patch and posted to the open ticket
that it belongs to.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30282


git-svn-id: http://core.svn.wordpress.org/trunk@30282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:37:22 +00:00
Drew Jaynes
e7b465046a Cross-reference WP_Comment_Query::query() as the location for finding information on default arguments for WP_Comment_Query.
Also updates the return types on `get_comments()` and `get_approved_comments()`, as an integer can also be returned if the `$count` argument is true.

Fixes #30111.

Built from https://develop.svn.wordpress.org/trunk@30281


git-svn-id: http://core.svn.wordpress.org/trunk@30281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:35:22 +00:00
Drew Jaynes
35e509b0c8 Document default arguments for WP_Comment_Query class as a hash notation.
Props boonebgorges, DrewAPicture.
See #30111.

Built from https://develop.svn.wordpress.org/trunk@30280


git-svn-id: http://core.svn.wordpress.org/trunk@30280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:19:23 +00:00
Jeremy Felt
bd3a0b33b1 Use remove_added_uploads() in tearDown() for XMLRPC tests
This cleanup avoids false test failures due to incrementing filenames in the uploads directory.

Fixes #30290

Built from https://develop.svn.wordpress.org/trunk@30279


git-svn-id: http://core.svn.wordpress.org/trunk@30279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 20:18:22 +00:00
Boone Gorges
0b90415e75 In unit tests, use wpmu_delete_user() to delete users when is_multisite().
`wp_delete_user()` doesn't remove the user from the database, which causes all
sorts of problems in certain cases.

Props jeremyfelt.
See [30277], #30017.
Built from https://develop.svn.wordpress.org/trunk@30278


git-svn-id: http://core.svn.wordpress.org/trunk@30278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 19:56:22 +00:00
Boone Gorges
b5b923c347 Share fixtures across 'canonical' automated tests.
Sharing these fixtures results in a speed improvement of almost one minute per
run of the test suite.

My hope is that future WordPress developers will spend this extra minute with
their loved ones, for life on this earth is short, my friends, and the moments
you spend watching WP generate test data can never again be reclaimed from the
grizzled clutches of Time, and none of us are really getting younger, I mean,
geez, have you looked in the mirror lately, Gandalf?

See #30017.
Built from https://develop.svn.wordpress.org/trunk@30277


git-svn-id: http://core.svn.wordpress.org/trunk@30277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 19:29:22 +00:00
Boone Gorges
b6d3190be2 Share fixtures across a number of query-related test classes.
This shaves 10-20 seconds off the running time for the suite.

See #30017.
Built from https://develop.svn.wordpress.org/trunk@30276


git-svn-id: http://core.svn.wordpress.org/trunk@30276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-08 15:30:25 +00:00
Ian Stewart
68a6a69a91 Twenty Fifteen: updates to customize-preview.js missed in r30274.
Props celloexpressions, See #29988.


Built from https://develop.svn.wordpress.org/trunk@30275


git-svn-id: http://core.svn.wordpress.org/trunk@30275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 21:11:25 +00:00
Ian Stewart
fa81522cb2 Twenty Fifteen: add instant updating of color schemes to the customizer with postMessage.
Props celloexpressions, bradyvercher, westonruter, fixes #29988.



Built from https://develop.svn.wordpress.org/trunk@30274


git-svn-id: http://core.svn.wordpress.org/trunk@30274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 20:55:23 +00:00
Ian Stewart
066967be6c Twenty Fifteen: Removing email obfuscation from social links menu.
We really should be doing this in all menus, at which point this becomes core or plugin functionality, not a theme feature.

Closes #30214.


Built from https://develop.svn.wordpress.org/trunk@30273


git-svn-id: http://core.svn.wordpress.org/trunk@30273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:38:21 +00:00
Ian Stewart
c3ec04c532 Twenty Fifteen: adding help text to explain how color changes to header and sidebar are affected by responsive design.
Props iamtakashi, iandstewart, fixes #30165.


Built from https://develop.svn.wordpress.org/trunk@30272


git-svn-id: http://core.svn.wordpress.org/trunk@30272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:31:22 +00:00
Ian Stewart
78c26017c6 Twenty Fifteen: improve naming and documentation of customizer js files to match core filenaming conventions.
Props celloexpressions, fixes #30160.


Built from https://develop.svn.wordpress.org/trunk@30271


git-svn-id: http://core.svn.wordpress.org/trunk@30271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:20:22 +00:00
Ian Stewart
1b0b11b593 Twenty Fifteen: use antispambot to obfuscate email adresses in the social links menu.
Props tywayne, fixes #30214.


Built from https://develop.svn.wordpress.org/trunk@30270


git-svn-id: http://core.svn.wordpress.org/trunk@30270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 16:46:21 +00:00
Ian Stewart
85fd2fa467 Twenty Fifteen: update earlier patch to borders on linked images so we're not affecting the display of linked icons in widgets.
Props iamtakashi, fixes #29963.


Built from https://develop.svn.wordpress.org/trunk@30269


git-svn-id: http://core.svn.wordpress.org/trunk@30269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 16:34:24 +00:00
Boone Gorges
7ca9e7d428 Correct variable name in WP_UnitTestCase::temp_filename().
Built from https://develop.svn.wordpress.org/trunk@30268


git-svn-id: http://core.svn.wordpress.org/trunk@30268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 01:37:21 +00:00
Boone Gorges
88de93790b Unset the default permalink structure after installing Multisite for automated tests.
Most of our unit tests that involve permalinks expect non-pretty permalinks;
this is the default setting for WP. However, when the test suite installs
multisite, `populate_network()` is run before WP recogizes itself as multisite,
which leads to pretty permalinks being set. This breaks a number of unit
tests in ways that are difficult to trace.
Built from https://develop.svn.wordpress.org/trunk@30267


git-svn-id: http://core.svn.wordpress.org/trunk@30267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 01:25:22 +00:00
Boone Gorges
0b1cd9a67a Use assertEqualSets() for some WP_Comment_Query tests.
Built from https://develop.svn.wordpress.org/trunk@30266


git-svn-id: http://core.svn.wordpress.org/trunk@30266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 22:28:25 +00:00
Boone Gorges
c357de63ef Don't force child_of=0 for non-hierarchical taxonomies in get_terms().
This forcing appears to have been introduced to save unnecessary queries, but
(a) in some cases it appeared to be causing *more* queries, and (b) it caused
incorrect results when the 'exclude_tree' param of `get_terms()` called
`get_terms()` on each item in the tree using the 'child_of' param.

Fixes #30275.
Built from https://develop.svn.wordpress.org/trunk@30265


git-svn-id: http://core.svn.wordpress.org/trunk@30265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 21:47:23 +00:00
Boone Gorges
5ce7ae59df Add tests for get_adjacent_post_link() wrappers.
Props MikeHansenMe.
See #29663.
Built from https://develop.svn.wordpress.org/trunk@30264


git-svn-id: http://core.svn.wordpress.org/trunk@30264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 20:17:22 +00:00
Boone Gorges
4743ee9326 In get_adjacent_post(), $excluded_terms should check term_id rather than term_taxonom_id.
See #29663, #22112.
Built from https://develop.svn.wordpress.org/trunk@30263


git-svn-id: http://core.svn.wordpress.org/trunk@30263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-06 20:12:22 +00:00
Ian Stewart
cd0ba24e95 Twenty Fifteen: Our next-previous labels were reversed.
Props iamtakashi, fixes #30265.


Built from https://develop.svn.wordpress.org/trunk@30247


git-svn-id: http://core.svn.wordpress.org/trunk@30247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 20:31:22 +00:00
Scott Taylor
03ea739661 In get_page_children(), only check $page->ancestors once to avoid duplicates when the function recurses. Adds an argument, $ancestors.
Fixes #18962.

Built from https://develop.svn.wordpress.org/trunk@30246


git-svn-id: http://core.svn.wordpress.org/trunk@30246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 20:05:24 +00:00
Scott Taylor
d5a9d63114 Improve wp.media documentation.
Props ericlewis.
See #28459.

Built from https://develop.svn.wordpress.org/trunk@30245


git-svn-id: http://core.svn.wordpress.org/trunk@30245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 19:39:22 +00:00
Scott Taylor
2d1080aed1 Improve wp.Uploader documentation.
Props ericlewis.
See #30260.

Built from https://develop.svn.wordpress.org/trunk@30244


git-svn-id: http://core.svn.wordpress.org/trunk@30244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 19:37:23 +00:00