Scott Taylor
fdaea6b7f2
Eliminate use of extract() in wp_widget_rss_form().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28449
git-svn-id: http://core.svn.wordpress.org/trunk@28276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 15:38:14 +00:00
Scott Taylor
463b7c4620
Eliminate use of extract() in wp_xmlrpc_server::mw_editPost() (MetaWeblog API, y'all).
...
A lot of the extracted variables are overwritten by being explicitly set later.
Only set variables that would otherwise not be present with `compact()` is called.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28448
git-svn-id: http://core.svn.wordpress.org/trunk@28275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 15:19:14 +00:00
Scott Taylor
82d6b94cfe
Eliminate use of extract() in validate_blog_signup():
...
* `$orig_username` does not need to be pulled from `wpmu_validate_user_signup()` as it is not used in this function.
* `$user` does not need to be pulled from `wpmu_validate_blog_signup()` as it is not used in this function.
* For the `wpmu_validate_user_signup()` portion, rename `$result` and `$errors` to $user_result` and `$user_errors` for disambiguation with the blog values below.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28447
git-svn-id: http://core.svn.wordpress.org/trunk@28274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 14:53:15 +00:00
Scott Taylor
bb810c5352
Eliminate use of extract() in validate_user_signup().
...
`$orig_username` does not need to be pulled from `validate_user_form()` as it is not used in this function.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28446
git-svn-id: http://core.svn.wordpress.org/trunk@28273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 14:47:14 +00:00
Scott Taylor
ac93f6742e
Eliminate use of extract() in validate_another_blog_signup().
...
The extracted variables set/overwrite globals. `$user` does not need to be pulled from `validate_blog_form()` as it is not used in this function.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28445
git-svn-id: http://core.svn.wordpress.org/trunk@28272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 14:43:25 +00:00
Sergey Biryukov
5c2d25aa77
Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings.
...
props GaVrA.
fixes #23800 .
Built from https://develop.svn.wordpress.org/trunk@28444
git-svn-id: http://core.svn.wordpress.org/trunk@28271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 11:10:14 +00:00
Sergey Biryukov
abc830ca9d
DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
...
props avryl.
fixes #28279 .
Built from https://develop.svn.wordpress.org/trunk@28443
git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 10:43:14 +00:00
Sergey Biryukov
d970ac80c6
Don't include caption tags in gallery template when there is no caption.
...
props avryl.
fixes #28089 .
Built from https://develop.svn.wordpress.org/trunk@28442
git-svn-id: http://core.svn.wordpress.org/trunk@28269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 21:03:15 +00:00
Scott Taylor
5a5c86139f
Eliminate use of extract() in wp_get_object_terms().
...
There are 3 properties, just set them to variables. They are used too often to warrant a refactor.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28441
git-svn-id: http://core.svn.wordpress.org/trunk@28268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:58:15 +00:00
Scott Taylor
6e8e30bb1e
Eliminate use of extract() in wp_widget_rss_output().
...
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback).
Every other default arg has a default value of `0`.
`items` is expected to always be passed to this function.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28440
git-svn-id: http://core.svn.wordpress.org/trunk@28267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:42:13 +00:00
Scott Taylor
157f811a5e
Eliminate use of extract() in WP_Widget_RSS::widget().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28439
git-svn-id: http://core.svn.wordpress.org/trunk@28266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:36:15 +00:00
Scott Taylor
72fd658cde
In Walker_Category::start_el(), $title might not be set when $args are passed multiple levels into walk_category_tree().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28438
git-svn-id: http://core.svn.wordpress.org/trunk@28265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:14:14 +00:00
Scott Taylor
2a3548fe70
Eliminate use of extract() in wp_allow_comment().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28437
git-svn-id: http://core.svn.wordpress.org/trunk@28264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 18:10:15 +00:00
Scott Taylor
2b125a881b
Eliminate use of extract() in Walker_Category::start_el().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28436
git-svn-id: http://core.svn.wordpress.org/trunk@28263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 17:58:13 +00:00
Scott Taylor
9b210df2b9
Eliminate use of extract() in wp_generate_tag_cloud().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28435
git-svn-id: http://core.svn.wordpress.org/trunk@28262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 17:48:15 +00:00
Scott Taylor
9c8becc1f7
Eliminate use of extract() in wp_list_categories().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28434
git-svn-id: http://core.svn.wordpress.org/trunk@28261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 17:28:14 +00:00
Scott Taylor
67c51361d6
Eliminate use of extract() in default-widgets.php.
...
Props rzen, wonderboymusic.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28433
git-svn-id: http://core.svn.wordpress.org/trunk@28260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 16:33:15 +00:00
Scott Taylor
b788832722
Eliminate use of extract() in wp_dropdown_categories().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28432
git-svn-id: http://core.svn.wordpress.org/trunk@28259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 15:48:14 +00:00
Scott Taylor
78b6f2761d
Eliminate use of extract() in get_comment_reply_link().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28431
git-svn-id: http://core.svn.wordpress.org/trunk@28258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 15:35:15 +00:00
Scott Taylor
11aa170e30
Eliminate use of extract() in WP_Ajax_Response::add(). Just set most of the properties to variables to avoid interpolation churn.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28430
git-svn-id: http://core.svn.wordpress.org/trunk@28257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 15:25:14 +00:00
Scott Taylor
7943f4715a
Eliminate the use of extract() in get_post_reply_link().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28429
git-svn-id: http://core.svn.wordpress.org/trunk@28256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:49:14 +00:00
Scott Taylor
0e2909ce89
Eliminate the use of extract() in wp_list_comments(). All unit tests pass.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28428
git-svn-id: http://core.svn.wordpress.org/trunk@28255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:43:15 +00:00
Scott Taylor
a15d498d1a
Eliminate the use of extract() in wp_update_comment(). All unit tests pass.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28427
git-svn-id: http://core.svn.wordpress.org/trunk@28254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:37:15 +00:00
Scott Taylor
bbcc03a750
Eliminate the use of extract() in wp_check_filetype_and_ext().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28426
git-svn-id: http://core.svn.wordpress.org/trunk@28253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:22:14 +00:00
Scott Taylor
8e98541d5f
Eliminate the use of extract() in wp_mail(). Check the filtered array for each value before re-setting variables.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28425
git-svn-id: http://core.svn.wordpress.org/trunk@28252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:17:15 +00:00
Scott Taylor
f5bd0de275
Eliminate the use of extract() in wp_validate_auth_cookie().
...
Don't do anything fancy here, just set the 4 returned properties to variables. This function is semi-important.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28424
git-svn-id: http://core.svn.wordpress.org/trunk@28251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:11:13 +00:00
Scott Taylor
eb2bbf9c97
Eliminate the use of extract() in get_objects_in_term(). Only one property (order) was extracted.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28423
git-svn-id: http://core.svn.wordpress.org/trunk@28250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:43:16 +00:00
Scott Taylor
80a37d2fcd
Eliminate the use of extract() in WP_Tax_Query::get_sql(). All unit tests still pass.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28422
git-svn-id: http://core.svn.wordpress.org/trunk@28249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:41:14 +00:00
Scott Taylor
e6fad96f5e
Eliminate the use of extract() in the_taxonomies(). Adds unit test.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28421
git-svn-id: http://core.svn.wordpress.org/trunk@28248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:25:14 +00:00
Scott Taylor
ee90a8c17c
Eliminate the use of extract() in wp_dropdown_users().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28420
git-svn-id: http://core.svn.wordpress.org/trunk@28247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:18:15 +00:00
Scott Taylor
ae61a48489
Set @param back to $output, not $html, in the inline filter docs. This was a copy/paste mistake.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28419
git-svn-id: http://core.svn.wordpress.org/trunk@28246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:08:14 +00:00
Scott Taylor
b2d1e73fd5
Eliminate the use of extract() in WP_Upgrader.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28418
git-svn-id: http://core.svn.wordpress.org/trunk@28245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:02:14 +00:00
Scott Taylor
d74272ecf5
Eliminate one of the uses of extract() in wp_handle_upload().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28417
git-svn-id: http://core.svn.wordpress.org/trunk@28244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 04:31:14 +00:00
Scott Taylor
fc59804352
Eliminate one of the uses of extract() in wp_handle_sideload().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28416
git-svn-id: http://core.svn.wordpress.org/trunk@28243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 04:29:15 +00:00
Scott Taylor
c0b0b00e6d
Eliminate use of extract() in get_the_taxonomies(). Adds unit test.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28415
git-svn-id: http://core.svn.wordpress.org/trunk@28242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:51:13 +00:00
Scott Taylor
dcc6cbc04f
Eliminate use of extract() in gallery_shortcode().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28414
git-svn-id: http://core.svn.wordpress.org/trunk@28241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:41:15 +00:00
Scott Taylor
947aa04900
Update the inline docs for add_shortcode() to eliminate suggestion to use extract().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28413
git-svn-id: http://core.svn.wordpress.org/trunk@28240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:28:15 +00:00
Scott Taylor
4b94efd93b
Eliminate use of extract() in wp_xmlrpc_server::blogger_editPost().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28412
git-svn-id: http://core.svn.wordpress.org/trunk@28239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:25:15 +00:00
Scott Taylor
a7a6cb5bef
Eliminate use of extract() in Walker_Category_Checklist::start_el().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28411
git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:14:14 +00:00
Scott Taylor
7ebab48f4c
Eliminate use of extract() in wp_terms_checklist().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28410
git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:09:15 +00:00
Scott Taylor
a75f8137bc
Eliminate use of extract() in wp_star_rating().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28409
git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:57:14 +00:00
Scott Taylor
ff665b2f38
(REALLY) Eliminate use of extract() in wp_insert_link().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28408
git-svn-id: http://core.svn.wordpress.org/trunk@28235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:55:16 +00:00
Scott Taylor
54321f4c6e
Eliminate use of extract() in get_media_item().
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28407
git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:45:15 +00:00
Scott Taylor
5f06d0f50a
Eliminate use of extract() in wp_insert_link().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28406
git-svn-id: http://core.svn.wordpress.org/trunk@28233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:28:14 +00:00
Scott Taylor
9d6eeca015
Eliminate use of extract() in wp_list_bookmarks().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28405
git-svn-id: http://core.svn.wordpress.org/trunk@28232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:18:16 +00:00
Scott Taylor
748765c5ad
Eliminate use of extract() in _walk_bookmarks().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28404
git-svn-id: http://core.svn.wordpress.org/trunk@28231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:05:15 +00:00
Scott Taylor
12a5b389ab
Eliminate use of extract() in get_bookmarks().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28403
git-svn-id: http://core.svn.wordpress.org/trunk@28230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:58:15 +00:00
Scott Taylor
a4a5560b22
Eliminate use of extract() in Walker_Page::start_el().
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28402
git-svn-id: http://core.svn.wordpress.org/trunk@28229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:41:15 +00:00
Scott Taylor
7b8d797355
Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28401
git-svn-id: http://core.svn.wordpress.org/trunk@28228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:22:15 +00:00
Scott Taylor
29d8832625
Eliminate use of extract() in wp_dropdown_pages().
...
Adds unit tests to: `tests/post/template.php`.
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28399
git-svn-id: http://core.svn.wordpress.org/trunk@28227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:12:13 +00:00
