Sergey Biryukov
d8c50c7a12
Menus: Make sure current-menu-parent
and current-menu-ancestor
classes are properly set for parent items of post type archive submenu items.
...
Props mrwweb, ajoah, welcher.
Fixes #39800 .
Built from https://develop.svn.wordpress.org/trunk@41008
git-svn-id: http://core.svn.wordpress.org/trunk@40858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 21:31:44 +00:00
Sergey Biryukov
2ca39ce60d
Docs: Add a @global
entry for $tinymce_version
in _WP_Editors::default_settings()
.
...
Props tejas5989.
Fixes #41244 .
Built from https://develop.svn.wordpress.org/trunk@41007
git-svn-id: http://core.svn.wordpress.org/trunk@40857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 18:55:44 +00:00
James Nylen
1ef845b268
Ensure that wp-api.js
test fixtures do not change with WP_TESTS_*
constants.
...
Previously, changing these constants in `wp-tests-config` would cause PHPUnit to regenerate `wp-api-generated.js` with different values.
This commit uses the existing mechanism to also "freeze" all values that would change as a result of changing these constants.
Fixes #41123 .
Built from https://develop.svn.wordpress.org/trunk@41006
git-svn-id: http://core.svn.wordpress.org/trunk@40856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 09:30:42 +00:00
Sergey Biryukov
30bad141ad
Docs: Add a @global
entry for $wpdb
in WP_Network_Query::get_network_ids()
.
...
Props afzalmultani.
Fixes #41238 .
Built from https://develop.svn.wordpress.org/trunk@41005
git-svn-id: http://core.svn.wordpress.org/trunk@40855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 09:23:42 +00:00
Sergey Biryukov
98458cb6e3
Docs: Add a @global
entry for $wp_post_statuses
in WP_Customize_Nav_Menus::make_auto_draft_status_previewable()
.
...
Props afzalmultani.
See #41238 .
Built from https://develop.svn.wordpress.org/trunk@41004
git-svn-id: http://core.svn.wordpress.org/trunk@40854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 09:21:41 +00:00
Sergey Biryukov
b916e8c727
Docs: Add a @global
entry for $wp
in redirect_canonical()
.
...
Props afzalmultani.
See #41238 .
Built from https://develop.svn.wordpress.org/trunk@41003
git-svn-id: http://core.svn.wordpress.org/trunk@40853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 09:19:43 +00:00
Sergey Biryukov
dbba2af814
Docs: Add a @global
entry for $wp_widget_factory
in WP_Customize_Widgets::get_selective_refreshable_widgets()
.
...
Props jankimoradiya.
Fixes #41243 .
Built from https://develop.svn.wordpress.org/trunk@41002
git-svn-id: http://core.svn.wordpress.org/trunk@40852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 08:23:41 +00:00
Weston Ruter
7b28ff2f2a
Customize: Fix logic to re-expand a newly inserted nav menu section after placeholder section is replaced.
...
Fixes todo from Menu Customizer feature plugin: https://github.com/voldemortensen/menu-customizer/commit/0f4ea4e#diff-daa55fade2253f26ccbe02f71058841cR2330
Amends [32806].
Props greuben.
See #32576 .
Fixes #40997 .
Built from https://develop.svn.wordpress.org/trunk@41001
git-svn-id: http://core.svn.wordpress.org/trunk@40851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-05 00:44:41 +00:00
Weston Ruter
046fb8a987
Widgets: Let Custom HTML widget be "wide" as the Text widget is.
...
Also update `WP_Customize_Widgets::$core_widget_id_bases` with the new list of core widgets.
Props obenland, westonruter.
See #40907 , #40951 .
Built from https://develop.svn.wordpress.org/trunk@41000
git-svn-id: http://core.svn.wordpress.org/trunk@40850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-04 21:01:41 +00:00
Boone Gorges
fa2f4b047a
Avoid PHP notices when checking termmeta capabilities against a non-existent term.
...
Previously, checks like `current_user_can( 'edit_term_meta', $term_id )`
returned the proper value, but generated a PHP notice due to the fact
that `get_term( $term_id )` could, in certain instances, return
`WP_Error` objects.
Props caercam.
Fixes #40891 .
Built from https://develop.svn.wordpress.org/trunk@40999
git-svn-id: http://core.svn.wordpress.org/trunk@40849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-04 19:59:40 +00:00
Drew Jaynes
64cb817527
Docs: Add a missing return notation and to the DocBlock for WP_Session_Tokens::get_instance()
.
...
Also adds an inline reference to the `session_token_manager` hook in the description.
Props Shelob9 for the initial patch.
Fixes #40102 .
Built from https://develop.svn.wordpress.org/trunk@40998
git-svn-id: http://core.svn.wordpress.org/trunk@40848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-04 17:16:42 +00:00
Sergey Biryukov
c6ab84c4c4
General: Always use colon instead of a semicolon in switch()
control structures.
...
Props jrf.
Fixes #41234 .
Built from https://develop.svn.wordpress.org/trunk@40997
git-svn-id: http://core.svn.wordpress.org/trunk@40847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-04 09:52:41 +00:00
Andrew Ozz
8c47285f4e
TinyMCE: fix adding the <!-- more -->
tag when the editor is inline.
...
Props iseulde.
Fixes #41230 .
Built from https://develop.svn.wordpress.org/trunk@40996
git-svn-id: http://core.svn.wordpress.org/trunk@40846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-03 21:41:41 +00:00
Andrew Ozz
dcc372e098
Customizer: improve setting the TinyMCE modals z-index.
...
Props westonruter, greuben.
See #41158 .
Built from https://develop.svn.wordpress.org/trunk@40995
git-svn-id: http://core.svn.wordpress.org/trunk@40845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-03 21:18:44 +00:00
Boone Gorges
dc35b759be
Introduce wp_get_object_terms_args
filter.
...
This filter allows developers to modify the arguments passed to
`wp_get_object_terms()` before the query is run.
Props enrico.sorcinelli.
Fixes #35925 .
Built from https://develop.svn.wordpress.org/trunk@40994
git-svn-id: http://core.svn.wordpress.org/trunk@40844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-02 18:29:42 +00:00
Peter Wilson
2b25a87d1b
Capabilities: Prevent users having the do_not_allow
capability.
...
Meta capabilities use the capability `do_not_allow` to indicate a user should be blocked from performing a particular action. This ensures users can not have the capability as it would cause unexpected behaviour.
Props johnbillion.
Fixes #41059 .
Built from https://develop.svn.wordpress.org/trunk@40993
git-svn-id: http://core.svn.wordpress.org/trunk@40843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-02 05:16:45 +00:00
Sergey Biryukov
6fda2e67b0
Docs: Add a @global
entry for $wp_filter
in wp_start_object_cache()
.
...
Props bhaveshkhadodara.
Fixes #41222 .
Built from https://develop.svn.wordpress.org/trunk@40992
git-svn-id: http://core.svn.wordpress.org/trunk@40842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 22:13:41 +00:00
Andrew Ozz
65f1051697
TinyMCE: respect the Disable the visual editor when writing
user setting and don't output the TinyMCE components when using wp_enqueue_editor()
.
...
Fixes #40960 for trunk.
Built from https://develop.svn.wordpress.org/trunk@40991
git-svn-id: http://core.svn.wordpress.org/trunk@40841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 21:31:47 +00:00
Andrew Ozz
16167ffe41
Text widget: bump the TinyMCE modals z-index to 500001 so they show in the Customizer.
...
Props greuben.
Fixes #41158 for trunk.
Built from https://develop.svn.wordpress.org/trunk@40990
git-svn-id: http://core.svn.wordpress.org/trunk@40840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 20:33:41 +00:00
Drew Jaynes
5c075e5af7
Docs: Remove a few more superfluous @package WordPress
and @subpackage
notations outside of file headers missed in [40988].
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40989
git-svn-id: http://core.svn.wordpress.org/trunk@40839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 17:11:41 +00:00
Drew Jaynes
1d95dcfa2c
Docs: Remove superfluous @package WordPress
and @subpackage
notations used outside of file headers in a variety of core files.
...
Per the inline documentation standards for PHP, there should only be one `@package` and/or `@subpackage` notation per file, and only in the file header.
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40988
git-svn-id: http://core.svn.wordpress.org/trunk@40838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:58:42 +00:00
Drew Jaynes
ae017f435a
Docs: Convert an @uses
tag in the class DocBlock for Walker_Nav_Menu_Edit
to @see
.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40987
git-svn-id: http://core.svn.wordpress.org/trunk@40837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:49:40 +00:00
Drew Jaynes
bd2173f42c
Docs: Remove an unnecessary @package
tag from the DocBlock for post_preview()
.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40986
git-svn-id: http://core.svn.wordpress.org/trunk@40836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:39:41 +00:00
Drew Jaynes
ba40430e89
Docs: Add a valid return type for post_preview()
and improve the DocBlock summary.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40985
git-svn-id: http://core.svn.wordpress.org/trunk@40835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:37:42 +00:00
Boone Gorges
26fcea496d
Introduce most_used
taxonomy label, for text on 'Most Used' metabox tab.
...
Props mdifelice, jlambe.
Fixes #41150 .
Built from https://develop.svn.wordpress.org/trunk@40984
git-svn-id: http://core.svn.wordpress.org/trunk@40834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 14:46:41 +00:00
Drew Jaynes
5fa2de51ef
General: Ensure $description
gets initialized in get_the_archive_description()
if the post type archive conditional is true and the description isn't set.
...
Props henrywright.
See #38487 .
Built from https://develop.svn.wordpress.org/trunk@40983
git-svn-id: http://core.svn.wordpress.org/trunk@40833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 14:23:41 +00:00
Boone Gorges
cb81009729
Allow user searches to match the display_name
field.
...
Props bcole808, pcarvalho.
Fixes #39643 .
Built from https://develop.svn.wordpress.org/trunk@40982
git-svn-id: http://core.svn.wordpress.org/trunk@40832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 14:22:41 +00:00
Boone Gorges
6995731f12
Allow metadata to be updated via wp_update_comment()
.
...
Passing an array of `comment_meta` into `wp_update_comment()` will
now update corresponding metadata. Similar functionality already
exists in `wp_insert_comment()`.
Props dshanske, kraftbj.
Fixes #36784 .
Built from https://develop.svn.wordpress.org/trunk@40981
git-svn-id: http://core.svn.wordpress.org/trunk@40831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 13:36:41 +00:00
Boone Gorges
def98d511a
Users: Allow data to be filtered before updating or creating a user.
...
Props DaveFX.
Fixes #40545 .
Built from https://develop.svn.wordpress.org/trunk@40980
git-svn-id: http://core.svn.wordpress.org/trunk@40830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 13:30:42 +00:00
Boone Gorges
ed9d4b9408
Taxonomy: Ignore cached term value when it doesn't match the queried taxonomy.
...
When a cache entry is found that matches the requested `$term_id`, but
doesn't match an explicitly provided `$taxonomy`, that cache entry
should be ignored.
Props GunGeekATX.
Fixes #40671 .
Built from https://develop.svn.wordpress.org/trunk@40979
git-svn-id: http://core.svn.wordpress.org/trunk@40829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 11:46:41 +00:00
Boone Gorges
848bcf3b28
Introduce $comment_count
param for WP_Query
.
...
This parameter allows querying for posts with a specific value of
`comment_count`. It is also possible to query for posts that match
a `comment_count` comparison by passing an array with 'value' and
'compare' operators (eg `array( 'compare' => '>', 'value' => 5 )`).
Props ramon fincken.
Fixes #28399 .
Built from https://develop.svn.wordpress.org/trunk@40978
git-svn-id: http://core.svn.wordpress.org/trunk@40828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 11:25:44 +00:00
Drew Jaynes
d6f7788935
Remove an unnecessary initialization of $description
due to the else condition in get_the_archive_description()
.
...
See [40976]. See #38487 .
Built from https://develop.svn.wordpress.org/trunk@40977
git-svn-id: http://core.svn.wordpress.org/trunk@40827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 05:19:41 +00:00
Drew Jaynes
f6b5c794bf
General: Add support for the post type archive description to get_the_archive_description()
, and thereby also the_archive_description()
.
...
Props henrywright.
Fixes #38487 .
Built from https://develop.svn.wordpress.org/trunk@40976
git-svn-id: http://core.svn.wordpress.org/trunk@40826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 05:15:46 +00:00
Drew Jaynes
0fe9fb4a16
Link Template: Clarify documentation for the $id
parameter in get_post_permalink()
, get_edit_post_link()
, edit_post_link()
, and get_delete_post_link()
, to reflect that either a post ID or WP_Post
object is accepted.
...
Separately, use `$post` for checking the post status and retrieving the page_uri in `get_post_permalink()` instead of referencing back to the original `$id` parameter.
Props GunGeekATX for the initial patch.
Fixes #40780 .
Built from https://develop.svn.wordpress.org/trunk@40975
git-svn-id: http://core.svn.wordpress.org/trunk@40825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 03:29:42 +00:00
Drew Jaynes
903d23be34
Users: Introduce the manage_users_extra_tablenav
action, fired immediately outside the closing "actions" div in the Users list table tablenav.
...
A similar `manage_posts_extra_tablenav` hook fires in the same location and context in the Posts list table tablenav.
Props GunGeekATX, adamsilverstein.
Fixes #36990 .
Built from https://develop.svn.wordpress.org/trunk@40974
git-svn-id: http://core.svn.wordpress.org/trunk@40824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 03:02:41 +00:00
Drew Jaynes
25370ba481
Docs: Add a @property-read
notation for the read-only WP_Term::$data
property.
...
See [35269], #34348 and #41017 .
Built from https://develop.svn.wordpress.org/trunk@40973
git-svn-id: http://core.svn.wordpress.org/trunk@40823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 17:04:40 +00:00
Drew Jaynes
4b0e64aa8c
Docs: Add missing @since
, @access
, and @global
notations to the DocBlock for WP_Query::parse_search_order()
.
...
Props dixitadusara.
Fixes #41045 .
Built from https://develop.svn.wordpress.org/trunk@40972
git-svn-id: http://core.svn.wordpress.org/trunk@40822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 16:08:44 +00:00
Drew Jaynes
66e6776a5e
Docs: Add full parameter and return documentation for WP_Text_Diff_Renderer_Table::interleave_changed_lines()
.
...
Props coffee2code.
Fixes #38520 .
Built from https://develop.svn.wordpress.org/trunk@40971
git-svn-id: http://core.svn.wordpress.org/trunk@40821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 05:29:41 +00:00
Drew Jaynes
b13aa27cf4
Docs: Use third-person singular verbs in the summaries for wp_unschedule_hook()
and wp_clear_scheduled_hook()
.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40970
git-svn-id: http://core.svn.wordpress.org/trunk@40820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 04:54:41 +00:00
Drew Jaynes
36759db92e
Docs: Clarify accepted types and values for $menu
parameters in several contexts:
...
* `wp_nav_menu()`
* `wp_get_nav_menu_object()` and its filter `wp_get_nav_menu_object`
* `is_nav_menu()`
* `wp_delete_nav_menu()`
* `wp_get_nav_menu_items()`
Props dimadin.
Fixes #38166 .
Built from https://develop.svn.wordpress.org/trunk@40969
git-svn-id: http://core.svn.wordpress.org/trunk@40819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 04:49:40 +00:00
Drew Jaynes
7001a3cce6
Tests: Add @method
notations to factor class DocBlocks as a way to indicate expected return types from factory methods for the benefit of IDEs.
...
Props jdgrimes.
Fixes #37867 .
Built from https://develop.svn.wordpress.org/trunk@40968
git-svn-id: http://core.svn.wordpress.org/trunk@40818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 04:36:41 +00:00
Drew Jaynes
d829ec4cf2
Docs: Provide best practice guidance for achieving parity between $menu_slug
values supplied when adding menu and submenu pages, and later trying to compare those initial values against sanitized screen IDs derived from $menu_slug
.
...
At the heart of the matter, the `$menu_slug` parameter in `add_menu_page()` and `add_submenu_page()` is not sanitized with `sanitize_key()`. When the screen object is later built for the admin page, the screen ID is derived from that `$menu_slug` value, though passed through `sanitize_key()`, which can produce unexpected results in comparison check.
Changing the sanitization code to provide actual parity is out of the question at this juncture, so updating the docs to describe how to avoid this edge case is the next best option.
Props GregRoss.
Fixes #35305 .
Built from https://develop.svn.wordpress.org/trunk@40967
git-svn-id: http://core.svn.wordpress.org/trunk@40817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 04:18:43 +00:00
Drew Jaynes
af5b2ca7f5
Docs: Add more useful summaries to the DocBlocks for boolean $is_*
properties in WP_Query
.
...
Props megane9988 for the initial patch.
Fixes #34726 .
Built from https://develop.svn.wordpress.org/trunk@40966
git-svn-id: http://core.svn.wordpress.org/trunk@40816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 03:44:46 +00:00
Sergey Biryukov
641a4b643f
Cron API: Introduce wp_unschedule_hook()
to clear all events attached to a hook.
...
This complements `wp_clear_scheduled_hook()`, which only clears events attached with specific arguments.
Props arena, mordauk, jrf.
Fixes #18997 .
Built from https://develop.svn.wordpress.org/trunk@40965
git-svn-id: http://core.svn.wordpress.org/trunk@40815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 00:22:44 +00:00
Drew Jaynes
1fb8cbe8de
Docs: Don't reference non-existent hooks inline in the DocBlock descriptions for the following template functions:
...
* `get_index_template()`
* `get_404_template()`
* `get_author_template()`
* `get_category_template()`
* `get_tag_template()`
* `get_taxonomy_template()`
* `get_date_template()`
* `get_home_template()`
* `get_front_page_template()`
* `get_page_template()`
* `get_search_template()`
* `get_single_template()`
* `get_embed_template()`
* `get_singular_template()`
* `get_attachment_template()`
As mentioned when these dynamic hook references were originally fixed in [33274], we can't link to non-existent hooks inline because the Code Reference auto-linker won't pick up on the dynamic-ness of the hook, it'll just try to link to a hook reference that doesn't exist. In these cases, we need to be generic and provide context for the value of `$type`.
See [38418] for where the original fix was reversed. See this changeset for reversing the reversal.
Props donutz, milana_cap.
Fixes #41198 .
Built from https://develop.svn.wordpress.org/trunk@40964
git-svn-id: http://core.svn.wordpress.org/trunk@40814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-29 16:05:41 +00:00
Drew Jaynes
8ccc74c054
Docs: Don't reference non-existent hooks inline in the DocBlock description for get_archive_template()
.
...
Also removes extra curly braces from the dynamic hook references added in [40962] to aid future re-parsing.
See #41198 .
Built from https://develop.svn.wordpress.org/trunk@40963
git-svn-id: http://core.svn.wordpress.org/trunk@40813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-29 15:47:40 +00:00
Drew Jaynes
1e32ebe87d
Docs: Don't reference non-existent hooks inline in the DocBlock description for get_post_type_archive_template()
.
...
Props milana_cap.
See #41198 .
Built from https://develop.svn.wordpress.org/trunk@40962
git-svn-id: http://core.svn.wordpress.org/trunk@40812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-29 15:39:40 +00:00
James Nylen
8f6088ba6e
REST API: Add a filter to allow modifying the response *after* embedded data is added.
...
Fixes #38964 .
Built from https://develop.svn.wordpress.org/trunk@40961
git-svn-id: http://core.svn.wordpress.org/trunk@40811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-29 13:17:43 +00:00
Sergey Biryukov
165807d39f
Administration: In WP_List_Table::comments_bubble()
, replace the mdash with its HTML entity for consistency with the similar code in other list tables.
...
Props afercia.
See #40659 , #32152 .
Built from https://develop.svn.wordpress.org/trunk@40960
git-svn-id: http://core.svn.wordpress.org/trunk@40810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-29 00:04:43 +00:00
Sergey Biryukov
11bae4ded3
Docs: Add a @global
entry for $post
variable in wp_post_preview_js()
.
...
Props avinapatel.
Fixes #41194 .
Built from https://develop.svn.wordpress.org/trunk@40959
git-svn-id: http://core.svn.wordpress.org/trunk@40809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-28 12:55:43 +00:00