Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 14:45:45 +01:00
Code Issues Projects Releases Wiki Activity
25,859 Commits 50 Branches 748 Tags 792 MiB
a81be45d5d
Commit Graph

150 Commits

Author SHA1 Message Date
Andrew Nacin
dfb0e1aaa8 Custom header: Avoid warnings in the process_default_headers() method. 
Merges [28275] to the 3.9 branch.

props obenland.
fixes #27850.

Built from https://develop.svn.wordpress.org/branches/3.9@28277


git-svn-id: http://core.svn.wordpress.org/branches/3.9@28105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:25:16 +00:00
Andrew Nacin
27c422364c Header images: Accessibility and style improvements. Headers no longer jump around when chosen. 
props mcsf, ehg.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@27947


git-svn-id: http://core.svn.wordpress.org/trunk@27777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 15:49:15 +00:00
Andrew Nacin
f320b43587 Custom Headers: Simplify and consolidate the querying of custom headers for the customizer. 
props mcsf.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@27849


git-svn-id: http://core.svn.wordpress.org/trunk@27680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-29 10:53:15 +00:00
Andrew Nacin
a589d9d757 Add header image uploads with cropping to the customizer. 
props mcsf, ehg, gcorne.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@27497


git-svn-id: http://core.svn.wordpress.org/trunk@27339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 04:13:16 +00:00
Andrew Nacin
dce0b9adea Use SSL when linking to WordPress.org. see #27115. 
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:14:15 +00:00
Andrew Ozz
eb1d21d782 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712. 
Built from https://develop.svn.wordpress.org/trunk@27029


git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-24 19:06:15 +00:00
Sergey Biryukov
2f3ebce172 Always show Background Image section heading and the opening table tag on Custom Background screen, to make in consistent with Custom Header and avoid broken markup. 
props obenland.
fixes #26731.
Built from https://develop.svn.wordpress.org/trunk@26878


git-svn-id: http://core.svn.wordpress.org/trunk@26761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-29 08:06:11 +00:00
Drew Jaynes
cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-24 18:57:12 +00:00
Andrew Ozz
8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119 
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 03:53:11 +00:00
Andrew Nacin
5361a8abca Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Andrew Nacin
74488bdcb0 Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-22 17:22:11 +00:00
Drew Jaynes
bd09d15a2c Inline documentation for hooks in wp-admin/custom-header.php. 
Props gizburdt for the initial patch.
Fixes #25443.

Built from https://develop.svn.wordpress.org/trunk@25821


git-svn-id: http://core.svn.wordpress.org/trunk@25733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-16 23:26:10 +00:00
Scott Taylor
31f26dc3ce Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this. 
Props jdgrimes.
See #25160.


Built from https://develop.svn.wordpress.org/trunk@25254


git-svn-id: http://core.svn.wordpress.org/trunk@25222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-05 16:34:09 +00:00
Andrew Nacin
159e67efe2 Only show 'Preview' on the custom header screen if there is something to show. 
props nickmomrik.
fixes #14531.

Built from https://develop.svn.wordpress.org/trunk@25135


git-svn-id: http://core.svn.wordpress.org/trunk@25115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-27 12:27:10 +00:00
Mark Jaquith
fec4b66f5b Sanity checks on image metadata to avoid warnings, etc. 
fixes #23733. props wonderboymusic.

git-svn-id: http://core.svn.wordpress.org/trunk@23873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-29 20:51:35 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Sergey Biryukov
8e32770793 Define the variable before using it. fixes #23181. 
git-svn-id: http://core.svn.wordpress.org/trunk@23337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-23 03:00:20 +00:00
Andrew Nacin
9bba27f4e5 Fix various typos and omissions across a number of help tabs. props DrewAPicture, Ipstenu. see #22451. 
git-svn-id: http://core.svn.wordpress.org/trunk@22812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-22 08:45:15 +00:00
Andrew Nacin
dfb844b64b Remove legacy media uploader bits from custom-header.php and custom-background.php. see #22186, #21390. 
git-svn-id: http://core.svn.wordpress.org/trunk@22778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 17:44:49 +00:00
Andrew Nacin
83eeb80dfb Custom Header: Remove Farbtastic-era "Reset Text Color" button. Show default color when JS is disabled. props DrewAPicture. fixes #22461. 
git-svn-id: http://core.svn.wordpress.org/trunk@22695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-20 01:53:59 +00:00
Andrew Nacin
e14ff50cfb Don't allow non-image uploads for custom headers and backgrounds. props kovshenin. fixes #22149. 
git-svn-id: http://core.svn.wordpress.org/trunk@22521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-10 05:36:37 +00:00
Andrew Nacin
2d13e264a4 URLs should be esc_url(), not esc_attr(). 
git-svn-id: http://core.svn.wordpress.org/trunk@22520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-10 05:30:51 +00:00
Daryl Koopersmith
9af37358a9 Integrate media with the custom header page. fixes #21820, see #21390. 
git-svn-id: http://core.svn.wordpress.org/trunk@22505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-09 11:59:05 +00:00
Ryan Boren
b8140cf35e Update help text for color picker in custom header and background screens. 
Props DrewAPicture
fixes #22393


git-svn-id: http://core.svn.wordpress.org/trunk@22470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-08 19:32:49 +00:00
Ryan Boren
1534fe4978 Don't show "Skip Cropping, Publish Image as Is" button for themes that do not support headers with flexible width or height. Forces too small images to be scaled to fit in the absence of flex support. 
Props MadtownLems, kobenland
fixes #21100


git-svn-id: http://core.svn.wordpress.org/trunk@22468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-08 19:11:46 +00:00
Andrew Nacin
f466722928 Proper button heights on the custom header and background pages. props johnbillion. fixes #22385. 
git-svn-id: http://core.svn.wordpress.org/trunk@22462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-08 01:51:05 +00:00
Andrew Nacin
b9b9ebeeae Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855. 
git-svn-id: http://core.svn.wordpress.org/trunk@22459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 23:54:03 +00:00
Andrew Nacin
0b6cf76853 New color picker, props mattwiebe. see #21206. 
Replaces Farbtastic. May change further in response to user testing.



git-svn-id: http://core.svn.wordpress.org/trunk@22030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 01:57:38 +00:00
Andrew Nacin
c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598. 
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-21 19:34:23 +00:00
Ryan Boren
77fdb14c2c Fix display issues in the custom header screen when height is not specified. Use get_header_image() instead of header_image() so that esc_url() can do its job. Props JarretC, SergeyBiryukov, georgestephanis. fixes #21130 #21433 
git-svn-id: http://core.svn.wordpress.org/trunk@21508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-14 19:24:36 +00:00
Ryan Boren
076868e109 Better instruction text on custom header screen. Props jane, JustinSainton fixes #20992 
git-svn-id: http://core.svn.wordpress.org/trunk@21502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-14 18:32:26 +00:00
ryan
808ce796ae * Introduce remove_header_image(), reset_header_image(), set_header_image(), and get_header_image_data() for Custom_Image_Header. 
* Handle all set/get of header theme mod through these methods.
* Use these methods in the customizer.

Props kovshenin, nacin, SergeyBiryukov, koopersmith.
fixes #20871


git-svn-id: http://core.svn.wordpress.org/trunk@21037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-10 00:32:19 +00:00
ryan
23104564f0 Check context before adding media upload filters. Props SergeyBiryukov. fixes #20819 
git-svn-id: http://core.svn.wordpress.org/trunk@21009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-06 16:48:53 +00:00
ryan
82122d2ba8 Don't show mime type filter links when choosing an image header from the media library. Props SergeyBiryukov, georgestephanis. fixes #20819 
git-svn-id: http://core.svn.wordpress.org/trunk@20982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-04 14:37:57 +00:00
ryan
e6e9f59761 Update custom header help text to reflect recent UI changes. Props SergeyBiryukov, rasheed. fixes #20827 
git-svn-id: http://core.svn.wordpress.org/trunk@20981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-04 14:13:20 +00:00
ryan
9f9ae83e87 Make the Skip Cropping button secondary. Props SergeyBiryukov, nacin. fixes #20815 
git-svn-id: http://core.svn.wordpress.org/trunk@20980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-02 16:57:10 +00:00
nacin
b545454ceb When the current image is the default image, don't show buttons to restore to that image, for both custom headers and backgrounds. props mfields, SergeyBiryukov. fixes #20763. 
git-svn-id: http://core.svn.wordpress.org/trunk@20966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-30 21:58:27 +00:00
ryan
c0339644ea Shears of vigorous pinking. 
git-svn-id: http://core.svn.wordpress.org/trunk@20944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-27 16:25:43 +00:00
nacin
92423061e4 Move from 'Upload Image' to 'Select Image' as this section now includes choosing an image from the media library. see #20737. 
git-svn-id: http://core.svn.wordpress.org/trunk@20885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-24 21:07:39 +00:00
ryan
4cad786961 Improve appearance of "choose from library" link for headers and backgrounds. Props SergeyBiryukov, sabreuse. see #20737 
git-svn-id: http://core.svn.wordpress.org/trunk@20884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-24 21:03:38 +00:00
ryan
17f9635a45 Feature pointers for choosing an image from the library on the custom header and background pages. see #20554 
git-svn-id: http://core.svn.wordpress.org/trunk@20839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-21 20:34:20 +00:00
ryan
15b9961b52 set_url_scheme() for header and background image srcs. see #20702 
git-svn-id: http://core.svn.wordpress.org/trunk@20830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-18 20:22:57 +00:00
ryan
a6894d0b59 Create a new attachment and make a copy of the image when selecting an image from the image library. This prevents orphaning the header if the original attachment is deleted. This also prevents stomping of meta. 
Add a button to skip cropping.

Props SergeyBiryukov
Fixes #20657 #20667


git-svn-id: http://core.svn.wordpress.org/trunk@20806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-16 17:47:55 +00:00
ryan
a0f07732d4 Check wp_crop_image() for a false return value. Don't delete original image if crop not sucessful. Don't delete the original image when wp_crop_image() returns it untouched. Prevents deletion of header image when no cropping is done to the originally uploaded image. Props SergeyBiryukov, westi. fixes #20657 
git-svn-id: http://core.svn.wordpress.org/trunk@20769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-11 16:15:15 +00:00
duck_
ae9ce57153 Fix typo in Custom Header contextual help. Props klagraff. Fixes #20518. 
git-svn-id: http://core.svn.wordpress.org/trunk@20768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-11 07:12:20 +00:00
ryan
7e3010ef46 Use correct translation function. Props kobenland, SergeyBiryukov. fixes #20646 
git-svn-id: http://core.svn.wordpress.org/trunk@20757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-09 21:13:22 +00:00
ryan
9dfe713b5a Don't concatenate translated strings. see #20518 
git-svn-id: http://core.svn.wordpress.org/trunk@20719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-03 22:00:25 +00:00
ryan
1e54f64be5 Custom header contextual help updates. Props TomAuger. see #20518 
git-svn-id: http://core.svn.wordpress.org/trunk@20718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-03 21:54:50 +00:00