Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-09 04:11:10 +01:00
Code Issues Projects Releases Wiki Activity
28,601 Commits 50 Branches 747 Tags 791 MiB
aaae4e9df0
Commit Graph

70 Commits

Author SHA1 Message Date
Scott Taylor
e029005847 Access Modifiers: 
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31078


git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:44:23 +00:00
Sergey Biryukov
483e7a36d7 Use localized format for Last Updated date on Add Plugins screen. 
props tyxla.
fixes #30717.
Built from https://develop.svn.wordpress.org/trunk@31055


git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 01:03:23 +00:00
Andrew Ozz
a445806c6f Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337. 
Built from https://develop.svn.wordpress.org/trunk@30782


git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 23:40:24 +00:00
Scott Taylor
65ab522a51 Improve various @param docs for List Tables. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30679


git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 00:33:23 +00:00
Drew Jaynes
78bb3e5ff5 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*. 
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30648


git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:28:24 +00:00
Dominik Schilling
197f0a30a4 Plugin search: Wrap results in a form to fix pagination's paged input field. 
props jesin, ocean90.
see #18724, for trunk.
Built from https://develop.svn.wordpress.org/trunk@29829


git-svn-id: http://core.svn.wordpress.org/trunk@29594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-03 13:08:16 +00:00
Sergey Biryukov
9bf3007b55 Remove unnecessary CSS overriding on Add Plugins screen. 
props pavelevap.
fixes #29753.
Built from https://develop.svn.wordpress.org/trunk@29775


git-svn-id: http://core.svn.wordpress.org/trunk@29547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-28 20:26:17 +00:00
Helen Hou-Sandí
433210a907 Plugin install: Better styling to accommodate plugin icons. 
fixes #29466.

Built from https://develop.svn.wordpress.org/trunk@29679


git-svn-id: http://core.svn.wordpress.org/trunk@29454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 19:47:16 +00:00
Andrew Nacin
683238567d Plugin install: The sort callback doesn't need to be public. 
props helen.
fixes #28673.

Built from https://develop.svn.wordpress.org/trunk@29666


git-svn-id: http://core.svn.wordpress.org/trunk@29440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-02 06:51:16 +00:00
Andrew Nacin
69204000ca Adjust [29634] so the Upload Plugin button can be shown. see #29236. 
Built from https://develop.svn.wordpress.org/trunk@29637


git-svn-id: http://core.svn.wordpress.org/trunk@29411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-27 02:59:16 +00:00
Andrew Nacin
8f6fbcdc52 Plugin installer: Minor adjustments to aid with discovery. 
fixes #29387.

Built from https://develop.svn.wordpress.org/trunk@29636


git-svn-id: http://core.svn.wordpress.org/trunk@29410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-27 02:53:16 +00:00
Andrew Nacin
ac3dd27737 Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters. 
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.

Built from https://develop.svn.wordpress.org/trunk@29634


git-svn-id: http://core.svn.wordpress.org/trunk@29408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-27 01:32:18 +00:00
Helen Hou-Sandí
b1b7d5f3a2 Only show one search form for the plugin installer. 
The field dropdown now appears in the filter bar only when doing a search.

see #28785.

Built from https://develop.svn.wordpress.org/trunk@29597


git-svn-id: http://core.svn.wordpress.org/trunk@29371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-25 16:03:16 +00:00
Sergey Biryukov
b06652da92 Install Plugins: Don't wp_die() if API can't be reached. 
props johnbillion.
fixes #29361.
Built from https://develop.svn.wordpress.org/trunk@29594


git-svn-id: http://core.svn.wordpress.org/trunk@29368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-25 15:02:17 +00:00
Andrew Nacin
bb4db92621 Plugin install: Add icons to compatible/incompatible. see #29313. 
Built from https://develop.svn.wordpress.org/trunk@29586


git-svn-id: http://core.svn.wordpress.org/trunk@29360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 17:26:15 +00:00
Dominik Schilling
49937c88f9 Plugin compatibility is based on your version of WordPress, not your install. 
fixes #29313.
Built from https://develop.svn.wordpress.org/trunk@29581


git-svn-id: http://core.svn.wordpress.org/trunk@29355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-24 16:14:16 +00:00
Andrew Nacin
0eed9373e2 Introduce plugin icons in the installer. 
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.

Built from https://develop.svn.wordpress.org/trunk@29569


git-svn-id: http://core.svn.wordpress.org/trunk@29343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-21 19:11:17 +00:00
Dominik Schilling
1f20c88b68 Plugin install: Remove columns and screen options. 
fixes #28803.
Built from https://develop.svn.wordpress.org/trunk@29498


git-svn-id: http://core.svn.wordpress.org/trunk@29276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-15 09:38:15 +00:00
Sergey Biryukov
aed71de2d6 Plugin install: Make plugin groups translatable. 
props ocean90 for initial patch.
fixes #29092.
Built from https://develop.svn.wordpress.org/trunk@29477


git-svn-id: http://core.svn.wordpress.org/trunk@29255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 02:31:18 +00:00
Drew Jaynes
647b6d907b Clean up some missing @access tags and other tweaks for 4.0.0-functionality docs. 
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29455


git-svn-id: http://core.svn.wordpress.org/trunk@29233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-09 19:32:16 +00:00
Scott Taylor
320ba69cf7 After [29201], use aria-label instead of aria-labelledby in WP_Plugin_Install_List_Table::display_rows(). 
Props nvwd, DrewAPicture.
Fixes #28853.

Built from https://develop.svn.wordpress.org/trunk@29424


git-svn-id: http://core.svn.wordpress.org/trunk@29202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-07 02:56:15 +00:00
Dominik Schilling
410ca0a29c Plugin install: Improve styling of the no results message. 
see #28753.
Built from https://develop.svn.wordpress.org/trunk@29359


git-svn-id: http://core.svn.wordpress.org/trunk@29135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-02 15:24:16 +00:00
Dominik Schilling
9a9b1791ca Add some braces to [29225]. 
see #28673.
Built from https://develop.svn.wordpress.org/trunk@29350


git-svn-id: http://core.svn.wordpress.org/trunk@29127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 21:04:15 +00:00
Dominik Schilling
12e961cb61 Plugin install: Add missing closing HTML tags. 
props jwenerd.
fixes #29090. see #28673.
Built from https://develop.svn.wordpress.org/trunk@29348


git-svn-id: http://core.svn.wordpress.org/trunk@29125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 20:44:14 +00:00
Andrew Nacin
9e33ac1bee Plugin Install screens: Pass locale and installed plugins to the API, for context. 
props tellyworth.
see #17902.

Built from https://develop.svn.wordpress.org/trunk@29227


git-svn-id: http://core.svn.wordpress.org/trunk@29011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 20:50:15 +00:00
Helen Hou-Sandí
4da975b68f Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673. 
Built from https://develop.svn.wordpress.org/trunk@29225


git-svn-id: http://core.svn.wordpress.org/trunk@29009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 19:35:14 +00:00
Helen Hou-Sandí
a034c2076b Plugin install cards: 
* Move author attribution to its own line.
* Use `esc_url()` where appropriate.
* Better i18n.
* min-height for cards for a more even appearance.
* Show more cards on wide screens.
* Tighten up spacing below the filter bar.

props ocean90, helen. see #28785.

Built from https://develop.svn.wordpress.org/trunk@29219


git-svn-id: http://core.svn.wordpress.org/trunk@29003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 06:08:15 +00:00
Helen Hou-Sandí
02e3a7cbe3 Install Plugins screen: 
* Utilize the (currently-named) filter bar from the Add Themes screen.
* Move the upload link to the h2, also like the Add Themes screen.

see #28673.

Built from https://develop.svn.wordpress.org/trunk@29218


git-svn-id: http://core.svn.wordpress.org/trunk@29002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-18 04:50:15 +00:00
Scott Taylor
d395142fb9 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text. 
Props joedolson.
Fixes #28853.

Built from https://develop.svn.wordpress.org/trunk@29201


git-svn-id: http://core.svn.wordpress.org/trunk@28985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-16 22:50:14 +00:00
Dominik Schilling
d8ffbb19fc Remove plugin_install_details_link filter, which was added in [29047]. 
see #28785.
Built from https://develop.svn.wordpress.org/trunk@29171


git-svn-id: http://core.svn.wordpress.org/trunk@28955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 19:50:14 +00:00
Drew Jaynes
79a4fd8fef Inline documentation for the 'plugin_install_details_link' hook added in [29047] should use a 3-digit, x.x.x-style @since version. 
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29152


git-svn-id: http://core.svn.wordpress.org/trunk@28936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 00:10:15 +00:00
Scott Taylor
176b9b2301 Fix mismatches in access modifiers for WP_List_Table + subclasses. 
Fixes #28843, #28879.

Built from https://develop.svn.wordpress.org/trunk@29137


git-svn-id: http://core.svn.wordpress.org/trunk@28921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-13 22:09:16 +00:00
Scott Taylor
40725e9e67 Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses. 
Props SergeyBiryukov.
See #28843 and [28583].

Built from https://develop.svn.wordpress.org/trunk@29118


git-svn-id: http://core.svn.wordpress.org/trunk@28904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-12 03:27:14 +00:00
Helen Hou-Sandí
a180b44763 Display plugin install results as "cards" rather than in a list table, first run. 
props stephdau, ryelle, tellyworth, melchoyce. see #28785, #28646.


Built from https://develop.svn.wordpress.org/trunk@29047


git-svn-id: http://core.svn.wordpress.org/trunk@28835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-09 20:02:14 +00:00
Andrew Nacin
aeac3e1654 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This. 
fixes #28513.

Built from https://develop.svn.wordpress.org/trunk@28749


git-svn-id: http://core.svn.wordpress.org/trunk@28563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-12 18:09:13 +00:00
Scott Taylor
d28f6344de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28493


git-svn-id: http://core.svn.wordpress.org/trunk@28319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 01:17:15 +00:00
Scott Taylor
530a107ec9 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28388


git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:17:14 +00:00
Sergey Biryukov
f9d5020cb5 Use filtered per_page value in WP_Plugin_Install_List_Table and WP_Theme_Install_List_Table. 
props brasofilo.
fixes #25675.
Built from https://develop.svn.wordpress.org/trunk@27221


git-svn-id: http://core.svn.wordpress.org/trunk@27078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-21 18:30:14 +00:00
Sergey Biryukov
1db81755ac Remove unnecessary sprintf(). props jdgrimes. fixes #25489. 
Built from https://develop.svn.wordpress.org/trunk@26943


git-svn-id: http://core.svn.wordpress.org/trunk@26823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-14 11:18:12 +00:00
Dion Hulse
89dfee993d Replace the Star ratings in the dashboard with dashicons ratings. 
This also moves the ratings to only displaying full, half, or empty stars (ie. 3.0, 3.5, 4.0, no 3.7 ratings - which are rounded).
Fixes #26170

Built from https://develop.svn.wordpress.org/trunk@26380


git-svn-id: http://core.svn.wordpress.org/trunk@26280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-26 02:25:21 +00:00
Drew Jaynes
2befec291f Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php. 
Props naomicbush.
Fixes #25357.

Built from https://develop.svn.wordpress.org/trunk@25630


git-svn-id: http://core.svn.wordpress.org/trunk@25547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-26 02:48:09 +00:00
Dion Hulse
907ca6cd30 Add a filter on the Plugin and Theme installers table listing API args, this allows for plugins to hook in and add custom args to plugins_api() and themes_api() for the Plugin/Theme listing tabls. Fixes #18169 
Built from https://develop.svn.wordpress.org/trunk@25070


git-svn-id: http://core.svn.wordpress.org/trunk@25055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-21 06:52:12 +00:00
Ryan Boren
5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:00:25 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Helen Hou-Sandí
b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665. 
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-20 15:55:32 +00:00
Andrew Nacin
fc5fb63599 Browse and install your wordpress.org plugin favorites from the plugin installer. props Otto42, Japh, DrewAPicture. fixes #22002. 
git-svn-id: http://core.svn.wordpress.org/trunk@22026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 00:47:01 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup. 
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-26 19:57:44 +00:00
ryan
1f3da6568d Update plugin install screens to use the new stars. Add stars-rtl.png. Remove star.png and gray-star.png and add to old files list. 
Props helenyhou
Fixes #20626



git-svn-id: http://core.svn.wordpress.org/trunk@20754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-09 16:27:24 +00:00
ryan
519af69e93 When showing already installed themes in the theme installer list, indicate in the row actions that the theme is installed and offer an update link if updates are available. 
Props SergeyBiryukov
Fixes #20618


git-svn-id: http://core.svn.wordpress.org/trunk@20751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-09 15:01:49 +00:00