Dominik Schilling
aaeab2f3f5
Rest API: Ensure rest_ensure_response()
upgrades WP_HTTP_Response
to WP_REST_Response
.
...
An instance of `WP_HTTP_Response` doesn't ensure that the required methods used in `WP_REST_Server::dispatch()` exist, currently causing a fatal error.
Props ali11007, TimothyBlynJacobs, ocean90.
Fixes #49495 .
Built from https://develop.svn.wordpress.org/trunk@47849
git-svn-id: http://core.svn.wordpress.org/trunk@47625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 14:36:09 +00:00
Sergey Biryukov
b9751d4efe
Coding Standards: Use strict comparison for count()
calls.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47848
git-svn-id: http://core.svn.wordpress.org/trunk@47624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 11:38:08 +00:00
whyisjake
e9282e7389
Bundled Themes: Add missing RTL styles for to fix inconsistent margins on .alignwide
and .alignfull
items.
...
Fixes the inconsistent margins for alignwide and alignfull classes used on Cover Block when it is the first block on a page.
Props kthmd, utz119, nikhilbhansi, and sabernhardt.
Fixes #49435 .
Built from https://develop.svn.wordpress.org/trunk@47846
git-svn-id: http://core.svn.wordpress.org/trunk@47622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 06:23:06 +00:00
Sergey Biryukov
f1114d4507
Coding Standards: Fix WPCS issues in wp-admin/plugin-editor.php
and wp-admin/theme-editor.php
.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47845
git-svn-id: http://core.svn.wordpress.org/trunk@47621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 00:01:10 +00:00
Sergey Biryukov
c0bec847d1
Theme Editor: Remove unused $has_templates
boolean.
...
The variable is a remnant from when the Theme Editor still had the "Templates" heading and is unused in the current logic.
The condition it was a part of would always evaluate to true for a child theme, regardless of the `$has_templates` value.
Props dboy1988.
Fixes #50199 .
Built from https://develop.svn.wordpress.org/trunk@47844
git-svn-id: http://core.svn.wordpress.org/trunk@47620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 23:20:08 +00:00
whyisjake
e7150ae5c7
REST API: Ensure proper namespacing when registering routes.
...
The PR will corerce routes that have a leading slash and throwing a `_doing_it_wrong` notice while ensuring a proper namespace.
Fixes #49749 .
Props TimothyBlynJacobs, skarabeq, afercia.
Built from https://develop.svn.wordpress.org/trunk@47842
git-svn-id: http://core.svn.wordpress.org/trunk@47618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 20:48:08 +00:00
Sergey Biryukov
5850f5f6ef
Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-site-health-auto-updates.php
.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47841
git-svn-id: http://core.svn.wordpress.org/trunk@47617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 17:56:08 +00:00
Sergey Biryukov
64ed8a7355
Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-debug-data.php
.
...
Follow-up to [47550], [47557], [47835].
See #50052 .
Built from https://develop.svn.wordpress.org/trunk@47840
git-svn-id: http://core.svn.wordpress.org/trunk@47616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 17:26:07 +00:00
Sergey Biryukov
443dd105d4
Customize: Move the WordPress logo with a white background to the wp-includes
directory.
...
This ensures that the image used as a default site icon looks good on a dark background.
The image was previously changed in the `wp-admin` directory, but the site icon is now loaded from `wp-includes`.
Follow-up to [36635], [47018], [47564], [47832].
Props ocean90.
Fixes #49798 .
Built from https://develop.svn.wordpress.org/trunk@47838
git-svn-id: http://core.svn.wordpress.org/trunk@47614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-21 09:10:12 +00:00
Peter Wilson
39babb4dfb
KSES: Support the video
element's playsinline
attribute.
...
Allow users without the `unfiltered_html` capability to use the `playsinline` attribute when embedding videos.
Additionally this adds unit tests for passing the video element through kses.
Fixes #50167 . See #29826 .
Built from https://develop.svn.wordpress.org/trunk@47837
git-svn-id: http://core.svn.wordpress.org/trunk@47613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-21 04:54:11 +00:00
Sergey Biryukov
ba03c426db
Docs: Add missing @since
tag for auto_plugin_theme_update_email
filter.
...
See #50052 .
Built from https://develop.svn.wordpress.org/trunk@47836
git-svn-id: http://core.svn.wordpress.org/trunk@47612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 19:33:10 +00:00
whyisjake
661b929e1e
Security: Add user interface to auto-update themes and plugins.
...
Building on core update mechanisms, this adds the ability to enable automatic updates for themes and plugins to the WordPress admin.
Fixes : #50052 .
Props: afercia, afragen, audrasjb, azaozz, bookdude13, davidperonne, desrosj, gmays, gmays, javiercasares, karmatosed, knutsp, mapk, mukesh27, netweb, nicolaskulka, nielsdeblaauw, paaljoachim, passoniate, pbiron, pedromendonca, whodunitagency, whyisjake, wpamitkumar, and xkon.
Built from https://develop.svn.wordpress.org/trunk@47835
git-svn-id: http://core.svn.wordpress.org/trunk@47611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 18:49:09 +00:00
Andrea Fercia
2a86d8d534
Accessibility: Media: Hide the invisible "file input" on media views from assistive technologies.
...
The file input button is visually hidden, but was announced by screen readers in workflows unrelated to file uploads.
It is now hidden from assistive technologies by the means of an `aria-hidden` attribute, as its CSS display property must not be changed to make sure it still works on old browsers.
See #49753 .
Fixes #47611 .
Built from https://develop.svn.wordpress.org/trunk@47834
git-svn-id: http://core.svn.wordpress.org/trunk@47610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 13:33:07 +00:00
Sergey Biryukov
23c4fbeaa0
Customize: Load the default site icon from the wp-includes
directory.
...
Files inside the `wp-admin` directory may not be publicly available.
Follow-up to [36635], [47018].
Props whyisjake, finomeno, ocean90.
Fixes #50131 .
Built from https://develop.svn.wordpress.org/trunk@47832
git-svn-id: http://core.svn.wordpress.org/trunk@47608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 10:36:09 +00:00
Sergey Biryukov
434bee9fc9
Coding Standards: Fix WPCS issues in wp-includes/class-wp-customize-manager.php
.
...
Follow-up to [47819].
Props sorenbronsted.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47821
git-svn-id: http://core.svn.wordpress.org/trunk@47597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-19 08:41:12 +00:00
ianbelanger
bc0e05d6c8
Bundled Themes: Twenty Twenty inconsistent top and bottom margins for .alignwide
and .alignfull
on Chrome vs Safari.
...
Fixes the inconsistent margins for `alignwide` and `alignfull` classes used on Cover Block when it is the first block on a page.
Props kthmd, utz119, nikhilbhansi.
Fixes #49435 .
Built from https://develop.svn.wordpress.org/trunk@47820
git-svn-id: http://core.svn.wordpress.org/trunk@47596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 19:52:07 +00:00
Sergey Biryukov
307725883a
Themes: Prevent installation of themes that require a higher version of PHP or WordPress.
...
Props afragen.
Fixes #49653 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47819
git-svn-id: http://core.svn.wordpress.org/trunk@47595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 16:03:09 +00:00
Sergey Biryukov
54cdfaef59
Themes: Remove extra whitespace from wp-admin/includes/ajax-actions.php
and wp-admin/includes/theme.php
.
...
Follow-up to [47816].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47818
git-svn-id: http://core.svn.wordpress.org/trunk@47594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:55:06 +00:00
Sergey Biryukov
e445642243
Themes: Remove debug call from wp-admin/theme-install.php
.
...
Follow-up to [47816].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47817
git-svn-id: http://core.svn.wordpress.org/trunk@47593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:49:08 +00:00
Sergey Biryukov
b73bbd8139
Themes: Prevent activation and live preview of themes that require a higher version of PHP or WordPress.
...
Props afragen, jorbin, TimothyBlynJacobs, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47816
git-svn-id: http://core.svn.wordpress.org/trunk@47592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:32:10 +00:00
Sergey Biryukov
d528d7a044
Site Health: Use WP_Theme::parent()
in the inactive themes test as a more reliable check that the parent theme exists.
...
This is also more consistent with the other instances of directly referencing `WP_Theme::parent()` properties or methods in core.
Props mukesh27, juanlopez4691, davidbaumwald, afragen, SergeyBiryukov.
Fixes #49934 .
Built from https://develop.svn.wordpress.org/trunk@47815
git-svn-id: http://core.svn.wordpress.org/trunk@47591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 04:38:10 +00:00
Sergey Biryukov
91936df3d1
Coding Standards: Fix WPCS issues in plugin and theme upgrader classes.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47814
git-svn-id: http://core.svn.wordpress.org/trunk@47590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-17 09:39:11 +00:00
Sergey Biryukov
f9b60d3334
Accessibility: Login and Registration: Respect the prefers-reduced-motion
media query for "shake" CSS animation on login failure.
...
This shake should not occur when the user has opted to reduce motion, for example by selecting the "Reduce motion" option in macOS' preferences or unselecting "Show animations in Windows" in Windows' preferences.
Follow-up to [47226].
Props eddystile, johnbillion, sabernhardt, afercia, audrasjb.
Fixes #49723 .
Built from https://develop.svn.wordpress.org/trunk@47813
git-svn-id: http://core.svn.wordpress.org/trunk@47589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 20:25:19 +00:00
TimothyBlynJacobs
cf0bfa3856
Coding Standards: Correct docblock indentation.
...
Fixes PHPCS failure introduced in r47811.
Built from https://develop.svn.wordpress.org/trunk@47812
git-svn-id: http://core.svn.wordpress.org/trunk@47588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 19:56:09 +00:00
TimothyBlynJacobs
1e524e7322
REST API: Add @since entries for rest_validate_value_from_schema().
...
See #49572 , #48818 , #44949 , #50053 , #48820 , #49720 , #42961 , #44975 , #43392 , #38583 .
Built from https://develop.svn.wordpress.org/trunk@47811
git-svn-id: http://core.svn.wordpress.org/trunk@47587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 19:33:09 +00:00
TimothyBlynJacobs
fe00d7f7bf
REST API: Support the JSON Schema pattern keyword.
...
Props jason_the_adams, birgire, sorenbronsted.
Fixes #44949 .
Built from https://develop.svn.wordpress.org/trunk@47810
git-svn-id: http://core.svn.wordpress.org/trunk@47586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 19:03:08 +00:00
TimothyBlynJacobs
26bda18a23
REST API: Check required properties are provided when validating an object.
...
Previously, the WP_REST_Request object validated that top-level properties were defined, but this did not extend to those object's required properties. This adds validation to rest_validate_value_from_schema() directly.
Both the v3 and v4 JSON Schema syntax for required properties is supported.
Props sorenbronsted.
Fixes #48818 .
Built from https://develop.svn.wordpress.org/trunk@47809
git-svn-id: http://core.svn.wordpress.org/trunk@47585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:44:09 +00:00
Sergey Biryukov
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
45f7e68d54
Media: Expose media grid frame via wp-media-grid-ready
trigger for easier customization.
...
Props soulseekah.
Fixes #50185 .
Built from https://develop.svn.wordpress.org/trunk@47807
git-svn-id: http://core.svn.wordpress.org/trunk@47583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 17:25:11 +00:00
Sergey Biryukov
16a8128765
Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-screen.php
.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47802
git-svn-id: http://core.svn.wordpress.org/trunk@47578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-15 18:13:09 +00:00
ianbelanger
e54d8406eb
Bundled Themes: Twenty Eleven & Twenty Twelve dropdown category widget exceeds parent div when strings are long enough.
...
Fixes the width of the category dropdown by limiting the width of `select` items in widgets using `max-width: 100%`.
Props gma992, karmatosed.
Fixes #37926 .
Built from https://develop.svn.wordpress.org/trunk@47801
git-svn-id: http://core.svn.wordpress.org/trunk@47577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-15 16:31:11 +00:00
ianbelanger
b10bd5134c
Bundled Themes: Twenty Twenty version bump.
...
We are releasing a new version of Twenty Twenty today thus we need to bump the version.
Props ianbelanger.
Fixes #50174 .
Built from https://develop.svn.wordpress.org/trunk@47800
git-svn-id: http://core.svn.wordpress.org/trunk@47576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 18:12:07 +00:00
ianbelanger
86b20d5655
Bundled Themes: Twenty Twenty custom post types that don't support authors, shows author box.
...
This fixes the issue where custom post types will show an author box, even if they don't support authors.
Props joyously, donmhico.
Fixes #48803 .
Built from https://develop.svn.wordpress.org/trunk@47799
git-svn-id: http://core.svn.wordpress.org/trunk@47575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 17:17:07 +00:00
Sergey Biryukov
618329a750
Docs: Update Michael Heilemann's URL in a comment in wp-includes/theme-compat/footer.php
.
...
Props ritterml, mukesh27.
Fixes #50171 .
Built from https://develop.svn.wordpress.org/trunk@47798
git-svn-id: http://core.svn.wordpress.org/trunk@47574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 15:33:08 +00:00
Sergey Biryukov
69adb593a2
Themes: Add "Block Editor Patterns" and "Full Site Editing" to the list of WordPress theme features.
...
Follow-up to [meta9876].
Props dingo_d.
Fixes #50164 . See #meta5212.
Built from https://develop.svn.wordpress.org/trunk@47797
git-svn-id: http://core.svn.wordpress.org/trunk@47573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 14:43:08 +00:00
ianbelanger
ceed19f625
Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu.
...
This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]
Props poena, audrasjb, Emlebrun.
Fixes #49893 .
Built from https://develop.svn.wordpress.org/trunk@47796
git-svn-id: http://core.svn.wordpress.org/trunk@47572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 13:48:11 +00:00
ianbelanger
f7539586be
Bundled Themes: Twenty Twenty add icon for g.page links.
...
Adds the option to use a g.page url for the social menu.
Props argentite, mayankmajeji.
Fixes #49088 .
Built from https://develop.svn.wordpress.org/trunk@47795
git-svn-id: http://core.svn.wordpress.org/trunk@47571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 13:05:09 +00:00
Sergey Biryukov
fb0e6531ab
Docs: Add @since
notes for theme features added or removed in get_theme_feature_list()
after its introduction in WordPress 3.1.
...
See #50165 .
Built from https://develop.svn.wordpress.org/trunk@47794
git-svn-id: http://core.svn.wordpress.org/trunk@47570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 12:50:08 +00:00
Sergey Biryukov
04e3fd6995
Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features.
...
These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.
Follow-up to [meta8273].
See #46272 .
Built from https://develop.svn.wordpress.org/trunk@47790
git-svn-id: http://core.svn.wordpress.org/trunk@47566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 09:18:08 +00:00
Sergey Biryukov
5e42a6c9e5
Export: Use correct escaping function for term IDs in <wp:term>
nodes.
...
Follow-up to [34333].
Props DrLightman, marcio-zebedeu.
Fixes #50113 .
Built from https://develop.svn.wordpress.org/trunk@47789
git-svn-id: http://core.svn.wordpress.org/trunk@47565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 07:55:12 +00:00
Sergey Biryukov
9e343ccb33
Coding Standards: Use strict comparison in wp-admin/upgrade.php
.
...
Props mukesh27.
Fixes #50155 .
Built from https://develop.svn.wordpress.org/trunk@47788
git-svn-id: http://core.svn.wordpress.org/trunk@47564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-13 10:10:08 +00:00
Sergey Biryukov
1e813b0275
Coding Standards: Correct db_version
check in wp-admin/admin.php
.
...
Follow-up to [47785].
See #49239 .
Built from https://develop.svn.wordpress.org/trunk@47787
git-svn-id: http://core.svn.wordpress.org/trunk@47563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 20:59:08 +00:00
Sergey Biryukov
bfba3fc458
Docs: Improve documentation for functions in wp-admin/install-helper.php
per the documentation standards.
...
Synchronize descriptions with the functions' counterparts from `wp-admin/includes/upgrade.php`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47786
git-svn-id: http://core.svn.wordpress.org/trunk@47562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 18:40:07 +00:00
Sergey Biryukov
aa69c25d5f
Coding Standards: Use strict comparison in some wp-admin
files.
...
Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239 .
Built from https://develop.svn.wordpress.org/trunk@47785
git-svn-id: http://core.svn.wordpress.org/trunk@47561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 18:32:08 +00:00
ianbelanger
2eef7ee2ac
Bundled Themes: Twenty Twenty anchor links don't work in mobile menu.
...
Modifies the mobile modal menu javascript, so that anchor links will close the modal and scroll to the anchor within the page.
Props Giorgio25b, suzylah, yuhin, samful, bdcstr.
Fixes #48916 .
Built from https://develop.svn.wordpress.org/trunk@47784
git-svn-id: http://core.svn.wordpress.org/trunk@47560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 16:45:11 +00:00
Sergey Biryukov
2517abb4bd
Docs: Add a note that the $protocols
parameter of esc_url_raw()
defaults to return value of wp_allowed_protocols()
.
...
This complements already existing note in `esc_url()`.
Props audrasjb.
Fixes #50147 .
Built from https://develop.svn.wordpress.org/trunk@47783
git-svn-id: http://core.svn.wordpress.org/trunk@47559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-11 20:34:13 +00:00
Sergey Biryukov
3fc1b33d53
Docs: Use 3-digit, x.x.x style semantic versioning for inline comments in populate_options()
.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47782
git-svn-id: http://core.svn.wordpress.org/trunk@47558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-11 17:26:08 +00:00
Sergey Biryukov
7f60aee75a
Tests: Give canonical test fixtures for paginated content more descriptive names.
...
Follow-up to [47727].
See #28081 , #40773 , #45337 .
Built from https://develop.svn.wordpress.org/trunk@47781
git-svn-id: http://core.svn.wordpress.org/trunk@47557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-10 20:31:08 +00:00
Sergey Biryukov
ddd3647d7d
Coding Standards: Rename some files and classes in phpunit/tests/functions/
per the naming conventions.
...
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47780
git-svn-id: http://core.svn.wordpress.org/trunk@47556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-10 12:09:10 +00:00
Peter Wilson
1c4513e5c3
Tests: Add unit tests for _cleanup_header_comment()
.
...
Props pbearne.
Fixes #38101 . See #8497 .
Built from https://develop.svn.wordpress.org/trunk@47779
git-svn-id: http://core.svn.wordpress.org/trunk@47555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-10 05:23:11 +00:00