Commit Graph

122 Commits

Author SHA1 Message Date
Konstantin Obenland
4e7c057a5a Check that current changes can be lost before editing another comment.
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.

Props pareshradadiya, chriscct7.
Fixes #21845.


Built from https://develop.svn.wordpress.org/trunk@32857


git-svn-id: http://core.svn.wordpress.org/trunk@32828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 13:48:25 +00:00
Andrew Ozz
fe427017a5 Fix comments postbox:
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349.
Built from https://develop.svn.wordpress.org/trunk@32495


git-svn-id: http://core.svn.wordpress.org/trunk@32465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 01:22:25 +00:00
Helen Hou-Sandí
3ac1a19529 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

Built from https://develop.svn.wordpress.org/trunk@31996


git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Sergey Biryukov
cd2e63700e Use a more specific selector for comment moderation hotkeys after [31513].
props afercia.
fixes #31545.
Built from https://develop.svn.wordpress.org/trunk@31929


git-svn-id: http://core.svn.wordpress.org/trunk@31908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 13:54:26 +00:00
Scott Taylor
6ffa051689 Replace flagrant instances of .html('') with .empty().
Props OriginalEXE, SergeyBiryukov.
Fixes #27034.

Built from https://develop.svn.wordpress.org/trunk@31690


git-svn-id: http://core.svn.wordpress.org/trunk@31671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 19:44:26 +00:00
Helen Hou-Sandí
b80c5d3e51 Comments: Simplify JS for inline edit and reply.
fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@29662


git-svn-id: http://core.svn.wordpress.org/trunk@29436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 03:57:18 +00:00
Scott Taylor
396e77b643 Use unobtrusive JS for Comment list table row actions.
Props aubreypwd.
Fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@28810


git-svn-id: http://core.svn.wordpress.org/trunk@28618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-23 23:55:16 +00:00
Scott Taylor
d4e46e3f8d Fix double avatars and JS errors when spamming/trashing comments.
Props avryl, SergeyBiryukov.
Fixes #27329.
 

Built from https://develop.svn.wordpress.org/trunk@27759


git-svn-id: http://core.svn.wordpress.org/trunk@27596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:14:15 +00:00
Andrew Nacin
6adabc6e4d Various JSHint fixes. see #26446.
Built from https://develop.svn.wordpress.org/trunk@27131


git-svn-id: http://core.svn.wordpress.org/trunk@26998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 00:52:12 +00:00
Andrew Ozz
2a68f85fa1 Comment moderation shortcuts:
- Fix "toggle checkboxes" (shift+x).
- Add noDisable selector and use it to stop disabling the shortcuts when a select-comment checkbox is focused.
See #26755.
Built from https://develop.svn.wordpress.org/trunk@26889


git-svn-id: http://core.svn.wordpress.org/trunk@26772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-02 00:11:14 +00:00
Andrew Ozz
fda55bd33b Comments moderation screen:
- Don't resize the textarea when replying to long comments.
- Limit the resizing of the textarea when quick-editing long comments to 500px.
Props SergeyBiryukov, fixes #25746.
Built from https://develop.svn.wordpress.org/trunk@26550


git-svn-id: http://core.svn.wordpress.org/trunk@26442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 00:55:10 +00:00
Andrew Nacin
d7423a466e Residual JSHint fixes in common.js and edit-comments.js.
see #25912, #25979.

Built from https://develop.svn.wordpress.org/trunk@26208


git-svn-id: http://core.svn.wordpress.org/trunk@26116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 06:37:09 +00:00
Andrew Nacin
97eff9117b JSHint: Make commentReply a declared global from elsewhere.
props adamsilverstein.
see #25979, [26156].

Built from https://develop.svn.wordpress.org/trunk@26157


git-svn-id: http://core.svn.wordpress.org/trunk@26068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:30:09 +00:00
Andrew Nacin
47559f45bf Avoid jshint errors in edit-comment.js.
props adamsilverstein.
fixes #25979.

Built from https://develop.svn.wordpress.org/trunk@26156


git-svn-id: http://core.svn.wordpress.org/trunk@26067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:10:10 +00:00
Dominik Schilling
c2739d12cc Trim leading whitespace from AJAX responses.
This fixes the warning "$(html) HTML strings must start with '<' character" by jQuery Migrate when adding nav menu items, post custom fields or comment replies.

fixes #23681.
Built from https://develop.svn.wordpress.org/trunk@25546


git-svn-id: http://core.svn.wordpress.org/trunk@25466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 10:51:09 +00:00
Andrew Ozz
cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin
2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot
539bffd7fa Compress scripts/styles: 3.4-beta2-20536.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-19 14:58:27 +00:00
bumpbot
3bf6b4ab5a Compress scripts/styles: 3.4-alpha-20165.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-09 01:45:40 +00:00
bumpbot
570a54053f Compress scripts/styles: 3.4-alpha-19896.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-09 23:30:50 +00:00
bumpbot
f9f2bb6bd9 Compress scripts/styles: 3.4-alpha-19805.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-01 14:43:00 +00:00
nacin
212e7bfc01 '3.4-alpha-19618'
git-svn-id: http://svn.automattic.com/wordpress/trunk@19618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-21 04:22:21 +00:00
duck_
5e3fe22bac Allow "Approve and Reply" background-color animation to complete on the Dashboard. Props ocean90. Fixes #18349.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-15 17:57:53 +00:00
duck_
7ba5b2f7a3 Stop an incorrect comment total being displayed when a trashed/spammed comment is deleted or restored. Fixes #19029.
Also only run getUpdate() when necessary and remove reference to non-existent "span.total-type-count".


git-svn-id: http://svn.automattic.com/wordpress/trunk@19068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-26 08:47:16 +00:00
azaozz
d58e337d24 Use WP_Editor when editing or replying to comments, props ocean90, remove vendor specific selectors from editor-buttons.css, fixes #18348, see #17144
git-svn-id: http://svn.automattic.com/wordpress/trunk@18803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-28 21:07:08 +00:00
duck_
6841d365e5 Don't hide the comment reply or quick edit row if an error is returned. Props ocean90. Fixes #18350.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-07 19:48:25 +00:00
azaozz
6041cd0410 Fix QTags.closeAllTags(), replace 'tb' with 'ed' in quicktags,js to make it clear it is the editor instance not the toolbar, small comments quick edit fixes, see #16695, fixes #15911
git-svn-id: http://svn.automattic.com/wordpress/trunk@18576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-20 19:55:51 +00:00
azaozz
042a03f384 Fix back-compat for quicktags, introduce QTags.addButton(), see #16695
git-svn-id: http://svn.automattic.com/wordpress/trunk@18511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-05 04:09:22 +00:00
azaozz
3713abe855 Remove debug remnants, props scribu, see #16695
git-svn-id: http://svn.automattic.com/wordpress/trunk@18499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-03 10:36:18 +00:00
azaozz
230fb8f3e3 Refactor Quicktags, props garyc40, see #16695
git-svn-id: http://svn.automattic.com/wordpress/trunk@18497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-03 10:11:12 +00:00
ryan
15a6a89eb0 Validation fixes. Props ocean90, xknown. fixes #17364
git-svn-id: http://svn.automattic.com/wordpress/trunk@18114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-02 17:05:55 +00:00
azaozz
b6fff6534a Fix background color for approved comments, props DH-Shredder, fixes #17405
git-svn-id: http://svn.automattic.com/wordpress/trunk@18065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-28 02:30:04 +00:00
azaozz
65f9c441a7 Replace .attr() with .prop() as per jQuery 1.6.1. Also fixes couple places where the JS wasn't working because attr('some', '') does not remove the HTML property now, see #17311
git-svn-id: http://svn.automattic.com/wordpress/trunk@18027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 01:04:12 +00:00
azaozz
7815408b7a Fix Reply and Approve when replying from the comment moderation page, see #15898
git-svn-id: http://svn.automattic.com/wordpress/trunk@17983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-21 17:11:13 +00:00
azaozz
96c6667c5c Don't show the Fullscreen button on the comment edit page, see #17136
git-svn-id: http://svn.automattic.com/wordpress/trunk@17966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-19 07:34:54 +00:00
azaozz
b1fe99c5ce jQuery 1.6.1 and fix for some small bugs that popped up while testing it, props JDTrower, fixes #17311
git-svn-id: http://svn.automattic.com/wordpress/trunk@17907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 22:00:31 +00:00
azaozz
b3a5a78607 Change comment Reply to Approve and Reply and auto-approve the comment if it is in moderation, props DH-Shredder, fixes #15898
git-svn-id: http://svn.automattic.com/wordpress/trunk@17832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-07 04:56:00 +00:00
azaozz
9e4bee6c26 Add quotes to [value="some"] selectors, see #16426
git-svn-id: http://svn.automattic.com/wordpress/trunk@17777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-30 02:15:08 +00:00
ryan
862b5e4da7 Update counts and pagination when trashing and moderating comments. Props garyc40, koopersmith, mdawaffe, nacin. fixes #15530
git-svn-id: http://svn.automattic.com/wordpress/trunk@17354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-22 18:47:42 +00:00
markjaquith
47c8008257 Fix the comments "river." issue 9. props garyc40. see #16262
git-svn-id: http://svn.automattic.com/wordpress/trunk@17344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-21 21:17:12 +00:00
markjaquith
acd8d41b65 Fix inter-page navigating on Edit Comments screen when using keyboard shortcuts. props garyc40. see #16262
git-svn-id: http://svn.automattic.com/wordpress/trunk@17343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-21 20:28:41 +00:00
markjaquith
fb6bed81c7 Several list table JS fixes. restores XHR comment status changes. props garyc40. see #16262
git-svn-id: http://svn.automattic.com/wordpress/trunk@17326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-18 17:32:35 +00:00
ryan
476e468faf Fix comment reply colspan. Props garyc40. fixes #15876
git-svn-id: http://svn.automattic.com/wordpress/trunk@17124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-23 17:21:29 +00:00
ryan
edc2f694ad Fix comment manipulation on edit post screen. Props garyc40. fixes #15876
git-svn-id: http://svn.automattic.com/wordpress/trunk@17113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-22 19:03:43 +00:00
ryan
8a8785c98b Comment reply and quick edit js fixes. Props garyc40. fixes #15908
git-svn-id: http://svn.automattic.com/wordpress/trunk@17089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 17:53:50 +00:00
nacin
60a828c31f Fix placeholder issues when removing comments. props garyc40, fixes #15879.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 15:26:44 +00:00
nacin
dfe2759a06 Don't refill the comment list when undoing a spam action on a comment. props greuben, fixes #15884.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-19 21:14:09 +00:00
scribu
e6d0e7a509 Fix error when trashing a comment on the last page. Props garyc40. Fixes #15500
git-svn-id: http://svn.automattic.com/wordpress/trunk@16911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-14 11:53:31 +00:00
ryan
b9fe49b63d Fix bulk comment keyboard shortcuts. Props duck_. fixes #15571
git-svn-id: http://svn.automattic.com/wordpress/trunk@16647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 16:51:20 +00:00