Commit Graph

29094 Commits

Author SHA1 Message Date
Boone Gorges
eec82f9330 In get_sample_permalink(), override 'future' status before generating permalink.
In [31114], `get_permalink()` was modified to prevent pretty permalinks from
being generated for posts with the 'future' post status. This inadvertently
broke the pretty permalink preview for scheduled posts. The fix is to include
the 'future' status in the list of statuses that `get_sample_permalink()` fakes
as 'publish' before it fetches a permalink.

Props DrewAPicture.
Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@31323


git-svn-id: http://core.svn.wordpress.org/trunk@31304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-02 16:50:22 +00:00
Dominik Schilling
628cec4f1a jQuery UI: Add jquery-ui-core as dependency for jquery-ui-progressbar.
props tyxla.
fixes #31208.
Built from https://develop.svn.wordpress.org/trunk@31322


git-svn-id: http://core.svn.wordpress.org/trunk@31303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-02 10:34:23 +00:00
Boone Gorges
55dafd966b When querying for a specific post, allow posts with a non-public status to be returned as long as that status is specified.
This makes it possible to, for example, retrieve a specific post using the
`p` parameter of `WP_Query`, even if the post is in the Trash, by including
the `post_status=trash` parameter.

Props ebinnion.
Fixes #29167.
Built from https://develop.svn.wordpress.org/trunk@31321


git-svn-id: http://core.svn.wordpress.org/trunk@31302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-01 20:26:25 +00:00
Sergey Biryukov
a82763b7b6 Menus: Don't display "Move" text without direction if there is only one menu item.
props kucrut for initial patch.
fixes #30765.
Built from https://develop.svn.wordpress.org/trunk@31320


git-svn-id: http://core.svn.wordpress.org/trunk@31301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-01 05:29:26 +00:00
Dominik Schilling
5bc0c84c35 i18n tools: Sync makepot.php with i18n.svn.
fixes #31193.
Built from https://develop.svn.wordpress.org/trunk@31319


git-svn-id: http://core.svn.wordpress.org/trunk@31300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 22:02:23 +00:00
Sergey Biryukov
f824de609d Reduce the size of the WordPress logo tap target on log in screen on mobile, to avoid unexpected redirect away from the form.
props mzak.
fixes #31185.
Built from https://develop.svn.wordpress.org/trunk@31318


git-svn-id: http://core.svn.wordpress.org/trunk@31299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 21:32:22 +00:00
Andrew Ozz
0a668f1586 Separate the tests for IE conditional comments support in WP_Scripts. Props valendesigns, see 16024.
Built from https://develop.svn.wordpress.org/trunk@31317


git-svn-id: http://core.svn.wordpress.org/trunk@31298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 20:41:22 +00:00
Sergey Biryukov
7d99c51b3b Themes: Remove a Chrome workaround that causes theme screenshots to look too crisp and no longer appears to be relevant.
props mzak.
fixes #26584.
Built from https://develop.svn.wordpress.org/trunk@31316


git-svn-id: http://core.svn.wordpress.org/trunk@31297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 20:39:25 +00:00
Dominik Schilling
9d227201eb i18n tools: Exclude wp-includes/class-pop3.php in wp_frontend().
The external library uses the underscore alias for the native gettext() function. Makepot extracts these strings too, which results in having 25 unused translations.

fixes #31179.
Built from https://develop.svn.wordpress.org/trunk@31315


git-svn-id: http://core.svn.wordpress.org/trunk@31296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 20:28:23 +00:00
Dominik Schilling
befce33421 i18n tools: Tabs, not spaces for indentation.
Built from https://develop.svn.wordpress.org/trunk@31314


git-svn-id: http://core.svn.wordpress.org/trunk@31295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 19:52:23 +00:00
Boone Gorges
f345a72c58 Prevent terms in a show_in_quick_edit=false taxonomy from being updated by a faked AJAX request.
The UI for these taxonomies was hidden in [31308], but it remained possible to
send a direct POST request to the `inline-edit` endpoint to bypass the
restriction. The current changeset fixes this.

Props meloniq.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31313


git-svn-id: http://core.svn.wordpress.org/trunk@31294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 19:38:24 +00:00
Boone Gorges
ca30c725a0 Improve support for ordering WP_Query results by postmeta.
`WP_Meta_Query` clauses now support a 'name' parameter. When building a
`WP_Query` object, the value of 'orderby' can reference this 'name', so that
it's possible to order by any clause in a meta_query, not just the first one
(as when using 'orderby=meta_value'). This improvement also makes it possible
to order by multiple meta query clauses (or by any other eligible field plus
a meta query clause), using the array syntax for 'orderby' introduced in [29027].

Props Funkatronic, boonebgorges.
Fixes #31045.
Built from https://develop.svn.wordpress.org/trunk@31312


git-svn-id: http://core.svn.wordpress.org/trunk@31293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 15:48:24 +00:00
Sergey Biryukov
3c416b8c87 Remove redundant parameter.
see #30753.
Built from https://develop.svn.wordpress.org/trunk@31311


git-svn-id: http://core.svn.wordpress.org/trunk@31292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 02:12:22 +00:00
Sergey Biryukov
c17737b7ac Add a unit test that expects wp_parse_args() to treat 'true' and 'false' in a query string as strings.
props voldemortensen for initial patch.
see #30753.
Built from https://develop.svn.wordpress.org/trunk@31310


git-svn-id: http://core.svn.wordpress.org/trunk@31291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 02:02:23 +00:00
Drew Jaynes
ac4aae99e6 Add changelog entries to the post_gallery and post_playlist hook docs for the $instance variable that was added in [31304].
Props ninnypants for the initial patch.
Fixes #31151.

Built from https://develop.svn.wordpress.org/trunk@31309


git-svn-id: http://core.svn.wordpress.org/trunk@31290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 00:33:22 +00:00
Boone Gorges
e4f8d5e0bc Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases.
See #26948.
Built from https://develop.svn.wordpress.org/trunk@31308


git-svn-id: http://core.svn.wordpress.org/trunk@31289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 19:29:22 +00:00
Boone Gorges
abce542e5f Introduce 'show_in_quick_edit' parameter for register_taxonomy().
Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.

The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.

Props hlashbrooke.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31307


git-svn-id: http://core.svn.wordpress.org/trunk@31288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 19:18:23 +00:00
Boone Gorges
9b0ee1c6f5 Introduce setExpectedDeprecated() and setExpectedIncorrectUsage() methods to `WP_UnitTestCase.
These methods provide a procedural alternative to the `@expectedDeprecated`
and `@expectedIncorrectUsage` test annotations, and parallel PHPUnit's native
`setExpectedException()`.

Props prasoon2211, jdgrimes.
Fixes #28486.
Built from https://develop.svn.wordpress.org/trunk@31306


git-svn-id: http://core.svn.wordpress.org/trunk@31287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 16:48:23 +00:00
Sergey Biryukov
5289e92ef5 Rename $instances to $instance in wp_audio_shortcode() and wp_video_shortcode() for consistency with gallery_shortcode() and wp_playlist_shortcode().
see #31151.
Built from https://develop.svn.wordpress.org/trunk@31305


git-svn-id: http://core.svn.wordpress.org/trunk@31286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 16:06:22 +00:00
Sergey Biryukov
fa86f3ef9c Pass the current shortcode instance ID to post_gallery and post_playlist filters.
props justincwatt.
fixes #31151.
Built from https://develop.svn.wordpress.org/trunk@31304


git-svn-id: http://core.svn.wordpress.org/trunk@31285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 16:02:21 +00:00
Sergey Biryukov
b05014805f Don't display the Help tab reference in Page Attributes meta box if Help tab was removed.
props bananastalktome.
fixes #31164.
Built from https://develop.svn.wordpress.org/trunk@31303


git-svn-id: http://core.svn.wordpress.org/trunk@31284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 15:34:24 +00:00
Boone Gorges
eddf93639b In get_adjacent_post(), return private post if the current user has the capacity to read it.
This mirrors the check that happens post-query in `WP_Query`. See #30911.

Props bswatson.
Fixes #30287.
Built from https://develop.svn.wordpress.org/trunk@31302


git-svn-id: http://core.svn.wordpress.org/trunk@31283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 02:20:23 +00:00
Boone Gorges
1f51936d8c Add unit tests for 'show_option_all' behavior of wp_list_categories().
See #21881.
Built from https://develop.svn.wordpress.org/trunk@31301


git-svn-id: http://core.svn.wordpress.org/trunk@31282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 01:40:23 +00:00
Sergey Biryukov
5ac0568ee3 Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
props tomdxw.
fixes #30927.
Built from https://develop.svn.wordpress.org/trunk@31300


git-svn-id: http://core.svn.wordpress.org/trunk@31281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 21:15:22 +00:00
Boone Gorges
cf68b77790 Add tests for get_category_parents().
See #30415.
Built from https://develop.svn.wordpress.org/trunk@31299


git-svn-id: http://core.svn.wordpress.org/trunk@31280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 20:49:26 +00:00
Dominik Schilling
72229b25c8 Add New User: Remove trailing whitespace from button labels.
fixes #31175.
Built from https://develop.svn.wordpress.org/trunk@31298


git-svn-id: http://core.svn.wordpress.org/trunk@31279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 14:54:21 +00:00
Drew Jaynes
de1f0a0487 Avoid confusion by clarifying an inline comment on logic for performing multisite upgrades.
Props dmchale for the initial patch.
Fixes #30837.

Built from https://develop.svn.wordpress.org/trunk@31297


git-svn-id: http://core.svn.wordpress.org/trunk@31278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:53:21 +00:00
Drew Jaynes
9a17233ca1 Fix an inaccurate summary and description in the DocBlock for wpmu_validate_user_signup().
Props ericlewis.
Fixes #31141.

Built from https://develop.svn.wordpress.org/trunk@31296


git-svn-id: http://core.svn.wordpress.org/trunk@31277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:46:22 +00:00
Drew Jaynes
db993f6598 Add a missing description for the $_diff_threshold property in the WP_Text_Diff_Renderer_Table class.
Props ipm-frommen.
Fixes #31008.

Built from https://develop.svn.wordpress.org/trunk@31295


git-svn-id: http://core.svn.wordpress.org/trunk@31276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:36:22 +00:00
Drew Jaynes
d7a51b3fc2 Add missing descriptions to the $blogid and $siteid property DocBlocks in the wpdb class.
Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31294


git-svn-id: http://core.svn.wordpress.org/trunk@31275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:35:22 +00:00
Drew Jaynes
0f20ecca9c Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/taxonomy.php.
Also adds a few missing parameter descriptions.

Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31293


git-svn-id: http://core.svn.wordpress.org/trunk@31274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:34:22 +00:00
Drew Jaynes
f3033f34c6 Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php
Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31292


git-svn-id: http://core.svn.wordpress.org/trunk@31273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:32:22 +00:00
Andrew Nacin
994b57a190 Update readme recommendations. fixes #31173.
Built from https://develop.svn.wordpress.org/trunk@31291


git-svn-id: http://core.svn.wordpress.org/trunk@31272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 05:10:22 +00:00
Dion Hulse
65e7885c01 HTTP API: Fix an issue where the limit_response_size parameter wasn't working properly with large documents and the cURL transport.
Fixes #31172

Built from https://develop.svn.wordpress.org/trunk@31290


git-svn-id: http://core.svn.wordpress.org/trunk@31271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 03:58:23 +00:00
Boone Gorges
78e5576ed8 Add basic unit tests for get_page_of_comment().
See #11334.
Props jeremyfelt.
Built from https://develop.svn.wordpress.org/trunk@31289


git-svn-id: http://core.svn.wordpress.org/trunk@31270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 02:31:22 +00:00
Boone Gorges
8627216105 When updating the name a hierarchical term with Quick Edit, update the corresponding option in the Parent dropdown.
Props garyc40, rmarks.
Fixes #14565.
Built from https://develop.svn.wordpress.org/trunk@31288


git-svn-id: http://core.svn.wordpress.org/trunk@31269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 01:53:22 +00:00
Boone Gorges
dcca015ffc Don't use term IDs for array indexes when caching object terms.
Uncached results pulled from `wp_get_object_terms()` are zero-indexed (ie 0,
1, 2...). As a result, `get_the_terms()` was returning a strictly different
array when pulling from the cache and when the cache was empty.

Props joshlevinson.
Fixes #31086.
Built from https://develop.svn.wordpress.org/trunk@31287


git-svn-id: http://core.svn.wordpress.org/trunk@31268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-28 20:43:23 +00:00
Boone Gorges
67d36f845d Improve organiation of tax_query and meta_query unit tests.
`meta_query` tests have been moved to `tests/phpunit/tests/query/metaQuery.php` and `tax_query` tests to `tests/phpunit/tests/query/taxQuery.php`. This is an improvement because (a) it better corresponds to the way that other `WP_Query` parameter tests are organized, (b) splitting meta and tax tests into separate classes simplifies the required `@group` annotations, and (c) the tests have nothing to do with posts per se, and so do not belong in the `post` subdirectory.

The tests previously found at `tests/phpunit/tests/query/taxQuery.php` have been moved to `isTerm.php` in the same directory. These tests are related to the `is_*` functions that have to do with taxonomy terms, like `is_category()`.

See #26999.
Built from https://develop.svn.wordpress.org/trunk@31286


git-svn-id: http://core.svn.wordpress.org/trunk@31267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-27 20:04:23 +00:00
Boone Gorges
e199d2420f Ensure that 'hierarchical' is respected in get_terms() when multiple taxonomies are passed.
Previously, attempts to descend the family tree of each term were done using
the first taxonomy in the `$taxonomies` array, with the result that terms not
belonging to that taxonomy were not found and their children not properly
parsed. We fix this bug by fetching each term's taxonomy with the SQL query,
and then using that taxonomy to get the correct children for each term.

Fixes #31118.
Built from https://develop.svn.wordpress.org/trunk@31285


git-svn-id: http://core.svn.wordpress.org/trunk@31266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-26 19:04:21 +00:00
Boone Gorges
af6e0f5c55 Ensure that 'pad_counts' is not discarded when the first of multiple taxonomies passed to get_terms() is non-hierarchical.
See #31118.
Built from https://develop.svn.wordpress.org/trunk@31284


git-svn-id: http://core.svn.wordpress.org/trunk@31265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-26 18:09:22 +00:00
Lance Willett
cfba917080 Twenty Fifteen: move RSS icon style rule lower to prevent it from being overridden by other social icon rules.
Props iamtakashi, fixes #31129.

Built from https://develop.svn.wordpress.org/trunk@31283


git-svn-id: http://core.svn.wordpress.org/trunk@31264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-26 15:58:23 +00:00
Sergey Biryukov
5aadff88f6 Remove duplicate label on installation screen.
props Ankit K Gupta.
fixes #31131.
Built from https://develop.svn.wordpress.org/trunk@31282


git-svn-id: http://core.svn.wordpress.org/trunk@31263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 19:39:23 +00:00
Sergey Biryukov
98da858b40 Revert [30027]. These fields are already sufficiently labeled; duplicate labels can lead to confused behavior for screen readers.
see #31117, #30101.
Built from https://develop.svn.wordpress.org/trunk@31281


git-svn-id: http://core.svn.wordpress.org/trunk@31262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 18:33:22 +00:00
Boone Gorges
5bfab3becd Do not run certain cache-hit tests on multisite.
These tests fail on multisite if run after a test that creates
`wpmu_create_blog()`, because `wpmu_create_blog()` defines `WP_INSTALLING`,
which results in unexpected cache misses. See [28965] for a similar fix.
Built from https://develop.svn.wordpress.org/trunk@31280


git-svn-id: http://core.svn.wordpress.org/trunk@31261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 12:59:23 +00:00
Sergey Biryukov
53a704a67a Fix a typo in [30138].
see #30224.
Built from https://develop.svn.wordpress.org/trunk@31279


git-svn-id: http://core.svn.wordpress.org/trunk@31260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 09:48:21 +00:00
Andrew Nacin
1b8f71041b Allow $autoload in add_option() to receive false.
props dllh.
fixes #31119.

Built from https://develop.svn.wordpress.org/trunk@31278


git-svn-id: http://core.svn.wordpress.org/trunk@31259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 07:51:23 +00:00
Boone Gorges
4b8277237f In Tests_Ajax_ReplytoComment::test_blocked_comment(), don't stop blocking comments until test is complete.
The test uses the `_block_comments()` method to prevent comment inserts from
happening. Since [31263], failed comment inserts lead to the comment content's
being stripped of invalid characters and inserted again. By immediately
unhooking itself after first being run, `_block_comments()` was causing the
INSERT block to work only for the first attempt, while the second attempt was
going through, causing the test to fail. As a fix, we move the
`remove_filter()` call to the class's `tearDown()` method - sufficient for
cleanup, but late enough that *all* comment inserts will be blocked for the
test method in question.

See #21212.
Since [31263], comment INSERT queries that were pseudo-bl
Built from https://develop.svn.wordpress.org/trunk@31277


git-svn-id: http://core.svn.wordpress.org/trunk@31258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 03:39:24 +00:00
Boone Gorges
acef0e2dcc In get_terms(), check hierarchy for all $taxonomies before bailing early from 'parent' or 'child_of'.
There is a pre-check in `get_terms()` that prevents an unnecessary database
query if the 'parent' or 'child_of' parameter is not found in the cached term
hierarchy (since a term without an index in the hierarchy cache has no
descendants). Previously, only the first item in the `$taxonomies` array was
being checked, with the result that an empty array was being erroneously
returned in cases where the 'parent' or 'child_of' term is in a subsequent
taxonomy.

See #31118.
Built from https://develop.svn.wordpress.org/trunk@31276


git-svn-id: http://core.svn.wordpress.org/trunk@31257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 02:46:25 +00:00
Boone Gorges
43fceb39c0 Introduce 'childless' parameter to get_terms().
This new parameter allows developers to limit queried terms to terminal nodes -
ie, those without any descendants.

As part of the improvement, some internal logic in `get_terms()` has been
consolidated. Parameters that resolve to a NOT IN clause containing term IDs
('exclude', 'exclude_tree', and 'childless') are now parsed into a single
"exclusions" array before the SQL clause is generated.

Props theMikeD, horike.
Fixes #29839.
Built from https://develop.svn.wordpress.org/trunk@31275


git-svn-id: http://core.svn.wordpress.org/trunk@31256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-24 18:48:23 +00:00
Sergey Biryukov
15fc97b1cf Quick Edit: Don't save the post if Enter is pressed on the Cancel link.
props afercia.
fixes #30345.
Built from https://develop.svn.wordpress.org/trunk@31274


git-svn-id: http://core.svn.wordpress.org/trunk@31255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-24 15:07:22 +00:00