Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-23 17:48:01 +01:00
Code Issues Projects Releases Wiki Activity
41,859 Commits 50 Branches 749 Tags 806 MiB
aee4324b9e
Commit Graph

29063 Commits

Author SHA1 Message Date
Sergey Biryukov
8d7a19cdc2 Bootstrap/Load: Remove special handling for REQUEST_TIME and REQUEST_TIME_FLOAT server values in wp_magic_quotes(). 
This was intended as a temporary fix until `add_magic_quotes()` is modified to leave non-string values untouched, which has now been done.

Follow-up to [47370], [48205].

See #48605.
Built from https://develop.svn.wordpress.org/trunk@48206


git-svn-id: http://core.svn.wordpress.org/trunk@47975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 21:09:05 +00:00
Sergey Biryukov
d25cc189be Bootstrap/Load: Make sure add_magic_quotes() does not inappropriately recast non-string data types to string. 
Props donmhico, jrf, Veraxus, Rarst.
Fixes #48605.
Built from https://develop.svn.wordpress.org/trunk@48205


git-svn-id: http://core.svn.wordpress.org/trunk@47974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 21:04:02 +00:00
Sergey Biryukov
66591d00ab Code Modernization: Introduce the spread operator in wp-includes/IXR. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props kraftbj.
See #48267, #47678.
Built from https://develop.svn.wordpress.org/trunk@48204


git-svn-id: http://core.svn.wordpress.org/trunk@47973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 18:25:02 +00:00
Sergey Biryukov
3a6eeef571 Posts, Post Types: Return early from WP_Posts_List_Table::formats_dropdown() if the post type does not support post formats. 
This avoids an unnecessary database query for the `post_format` taxonomy.

Props Chouby.
Fixes #50496.
Built from https://develop.svn.wordpress.org/trunk@48203


git-svn-id: http://core.svn.wordpress.org/trunk@47972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:30:07 +00:00
Sergey Biryukov
42f06389c0 Security: Improve the wording of messages in wp_get_auto_update_message(). 
Props burhandodhy, johnbillion, apedog.
Fixes #50489.
Built from https://develop.svn.wordpress.org/trunk@48202


git-svn-id: http://core.svn.wordpress.org/trunk@47971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:18:03 +00:00
Sergey Biryukov
83d20390c6 Networks and Sites: Use a consistent wording when referring to site deletion on Delete Site screen. 
Props burhandodhy, dartiss.
Fixes #50494.
Built from https://develop.svn.wordpress.org/trunk@48201


git-svn-id: http://core.svn.wordpress.org/trunk@47970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:12:02 +00:00
Sergey Biryukov
00a40b1ef2 Docs: Capitalize "ID", when referring to a user ID, term ID, etc. in a more consistent way. 
Follow-up to [48104]

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48200


git-svn-id: http://core.svn.wordpress.org/trunk@47969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:09:04 +00:00
Sergey Biryukov
3336009e34 Docs: Replace "html" and "xhtml" instances in DocBlocks and comments with "HTML" and "XHTML". 
This ensures consistent capitalization where appropriate.

Props navidos, desrosj.
Fixes #50473.
Built from https://develop.svn.wordpress.org/trunk@48199


git-svn-id: http://core.svn.wordpress.org/trunk@47968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 14:02:06 +00:00
Sergey Biryukov
c892c420b7 Docs: Miscellaneous DocBlock corrections. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48198


git-svn-id: http://core.svn.wordpress.org/trunk@47967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 11:53:04 +00:00
Sergey Biryukov
58ad216087 Docs: Improve documentation for optional parameters per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48197


git-svn-id: http://core.svn.wordpress.org/trunk@47966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 11:49:02 +00:00
Sergey Biryukov
ee8e9905c4 Tests: Adjust the test for invalid username in WP_Test_REST_Users_Controller to match the new string. 
Follow-up to [48195].

See #47003.
Built from https://develop.svn.wordpress.org/trunk@48196


git-svn-id: http://core.svn.wordpress.org/trunk@47965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-28 07:51:05 +00:00
Sergey Biryukov
37d48e2f2e Users: Merge two similar error messages about usernames with invalid characters. 
Props ramiy, garrett-eclipse, chetan200891.
Fixes #47003.
Built from https://develop.svn.wordpress.org/trunk@48195


git-svn-id: http://core.svn.wordpress.org/trunk@47964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 23:44:09 +00:00
Sergey Biryukov
5c4290f999 I18N: Remove <kbd> tag from a translatable string on Edit Post screen. 
Props ramiy, tobifjellner.
Fixes #48874.
Built from https://develop.svn.wordpress.org/trunk@48194


git-svn-id: http://core.svn.wordpress.org/trunk@47963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 23:02:03 +00:00
Sergey Biryukov
9439c44b44 Docs: Synchronize some documentation for functions in wp-includes/option.php. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48193


git-svn-id: http://core.svn.wordpress.org/trunk@47962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 16:56:02 +00:00
John Blackbourn
cdd52f8006 Docs: Improvements to the inline docs for metadata related functions. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48192


git-svn-id: http://core.svn.wordpress.org/trunk@47961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 16:34:05 +00:00
Sergey Biryukov
abe112c750 Administration: Correct the URL for "Learn more about getting started" link in "Welcome to WordPress" panel. 
Props hareesh-pillai, johnbillion.
Fixes #50484.
Built from https://develop.svn.wordpress.org/trunk@48191


git-svn-id: http://core.svn.wordpress.org/trunk@47960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 12:45:04 +00:00
Sergey Biryukov
eb468d3e6a Docs: Remove extra spaces from @ticket tag in unit tests. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48190


git-svn-id: http://core.svn.wordpress.org/trunk@47959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 12:04:03 +00:00
Sergey Biryukov
5aa7f46a4f Docs: Improve DocBlocks in wp-includes/theme.php per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48189


git-svn-id: http://core.svn.wordpress.org/trunk@47958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 12:02:03 +00:00
Sergey Biryukov
5771b7dff9 Bootstrap/Load: Make some adjustments to wp_get_environment_type(): 
* Rename the `wp_approved_environment_types` filter to `wp_environment_types`.
* Introduce `WP_ENVIRONMENT_TYPES` system variable and constant to complement the filter.
* Correct the argument type for the `wp_environment_types` filter.
* Cache the result in a static variable to ensure consistent return value.
* Rename the `stage` type to `staging`.

Follow-up to [47919].

Props dlh, dd32, TimothyBlynJacobs, johnbillion, pbiron.
See #33161.
Built from https://develop.svn.wordpress.org/trunk@48188


git-svn-id: http://core.svn.wordpress.org/trunk@47957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-27 10:36:06 +00:00
Sergey Biryukov
cb9c2ae83f Taxonomy: Make sure update_object_term_cache() caches all terms that were not already cached. 
Due to an unintended `break` instruction from a previous iteration, the function cached only one term in each taxonomy.

Follow-up to [48055].

Props Chouby.
Fixes #50352.
Built from https://develop.svn.wordpress.org/trunk@48187


git-svn-id: http://core.svn.wordpress.org/trunk@47956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 22:31:08 +00:00
Sergey Biryukov
3079ab76dc Administration: Add missing comma to the message in "Post via email" section. 
Props kinjaldalwadi, sabernhardt.
Fixes #49238.
Built from https://develop.svn.wordpress.org/trunk@48186


git-svn-id: http://core.svn.wordpress.org/trunk@47955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 19:38:06 +00:00
Sergey Biryukov
40c389c95e Docs: Standardize on "Returning a value from the filter" vs. "Passing a value to the filter". 
The filter is the callback function added with `add_filter()`, therefore the hook passes a value to the filter, and the filter returns a value to change its behaviour.

The documentation is referring to the latter.

Props johnbillion.
See #49572, #16557.
Built from https://develop.svn.wordpress.org/trunk@48185


git-svn-id: http://core.svn.wordpress.org/trunk@47954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 18:49:09 +00:00
John Blackbourn
eb9a6c9690 Docs: Miscellaneous docblock improvements. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48184


git-svn-id: http://core.svn.wordpress.org/trunk@47953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 18:40:04 +00:00
John Blackbourn
dfdee40ed6 Docs: Clarify the description of functions that check for and perform updates. 
See #49572, #50052.
Built from https://develop.svn.wordpress.org/trunk@48183


git-svn-id: http://core.svn.wordpress.org/trunk@47952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 18:34:03 +00:00
desrosj
9ebcf0922c Docs: Reword inline docs for better readability and clarity. 
This improves the wording of the inline documentation for `redirect_guess_404_permalink()` and the related filters introduced in [47878].

Previously [47878,47885]
See #16557.
Built from https://develop.svn.wordpress.org/trunk@48182


git-svn-id: http://core.svn.wordpress.org/trunk@47951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 16:16:04 +00:00
Sergey Biryukov
81447b05ba Twenty Twenty: Correct parameter types and @since version for twentytwenty_svg_icon_color filter. 
Follow-up to [48180].

See #48713.
Built from https://develop.svn.wordpress.org/trunk@48181


git-svn-id: http://core.svn.wordpress.org/trunk@47950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 14:51:06 +00:00
ianbelanger
cc1af8ddb5 Bundled Themes: Twenty Twenty Social Icons Filter. 
Adds a Social Icons Filter to Twenty Twenty that allows for new icons to be added to the theme by filter.

Props JarretC, nielslange, acosmin, desrosj.
Fixes #48713.
Built from https://develop.svn.wordpress.org/trunk@48180


git-svn-id: http://core.svn.wordpress.org/trunk@47949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 14:42:02 +00:00
ellatrix
9a43a62970 Update package-lock.json after [48177] 
Fixes #50481.

Built from https://develop.svn.wordpress.org/trunk@48179


git-svn-id: http://core.svn.wordpress.org/trunk@47948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 14:03:07 +00:00
desrosj
8576abb402 PHP: Bump the recommended version of PHP to 7.4. 
This brings the recommendations in `readme.html` inline with those on https://wordpress.org/about/requirements/.

Props hareesh-pillai.
Fixes #50480.
Built from https://develop.svn.wordpress.org/trunk@48178


git-svn-id: http://core.svn.wordpress.org/trunk@47947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 13:58:02 +00:00
ellatrix
c0db9a2f3d Editor: update JavaScript packages 
Also update default block categories

Props youknowriad, gziolo, aduth.
Fixes #50420, #50278.


Built from https://develop.svn.wordpress.org/trunk@48177


git-svn-id: http://core.svn.wordpress.org/trunk@47946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 13:33:47 +00:00
Sergey Biryukov
cf25273277 Tests: Reformat test_wp_list_pages_discarded_whitespace() for better readability. 
See #50466, #49542.
Built from https://develop.svn.wordpress.org/trunk@48176


git-svn-id: http://core.svn.wordpress.org/trunk@47945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 12:09:10 +00:00
Sergey Biryukov
a55c84380a Docs: Spell "line breaks" in a consistent way. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48175


git-svn-id: http://core.svn.wordpress.org/trunk@47944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 09:30:11 +00:00
Sergey Biryukov
a659c36414 Docs: Add a note that the $br parameter of wpautop() does not affect line breaks within <script>, <style>, and <svg> tags. 
Props stevenlinx.
Fixes #50477.
Built from https://develop.svn.wordpress.org/trunk@48174


git-svn-id: http://core.svn.wordpress.org/trunk@47943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 09:20:11 +00:00
TimothyBlynJacobs
9f14967ff0 REST API: Introduce Block Types endpoint. 
This endpoint allows a user to retrieve the block type definition for all server-side registered block types.

Props spacedmonkey, aduth, gziolo, ocean90, TimothyBlynJacobs.
Fixes #47620.

Built from https://develop.svn.wordpress.org/trunk@48173


git-svn-id: http://core.svn.wordpress.org/trunk@47942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 00:46:07 +00:00
Sergey Biryukov
16b35340f4 Site Health: Improve the error message displayed when activating a plugin that requires a higher version of PHP or WordPress. 
This adds some extra details to the message:

* The current PHP or WordPress version.
* The plugin's minimum required PHP or WordPress version.
* A link to the support documentation on how to update PHP.

Props stuffradio, johnbillion, garrett-eclipse, sabernhardt, williampatton, SergeyBiryukov.
Fixes #48245.
Built from https://develop.svn.wordpress.org/trunk@48172


git-svn-id: http://core.svn.wordpress.org/trunk@47941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-26 00:27:09 +00:00
TimothyBlynJacobs
9dc7058be9 Themes: Introduce register_theme_feature API. 
Currently themes can declare support for a given feature by using add_theme_support(). This commit adds a register_theme_feature() API that allows plugins and WordPress Core to declare a list of available features that themes can support.

The REST API uses this to expose a theme's supported features if the feature has been registered with "show_in_rest" set to true.

Props kadamwhite, spacedmonkey, williampatton, desrosj, TimothyBlynJacobs.
Fixes #49406.

Built from https://develop.svn.wordpress.org/trunk@48171


git-svn-id: http://core.svn.wordpress.org/trunk@47940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 22:13:10 +00:00
Felix Arntz
f18870ae4e Media: Ensure images have dimensions to reduce layout shift and facilitate lazy-loading. 
This changeset ensures that attachment images which are inserted without `width` and `height` attributes still receive them in the frontend, to reduce cumulative layout shift. Adding the dimensions happens as part of the logic for adding `srcset` and `sizes` attributes, which already assume the specific width and height of the respective image.

Images are now only lazy-loaded if they have `width` and `height` attributes present. While missing these attributes itself is what causes layout shifts, lazy-loading such images can make this problem more apparent to the user.

Props adamsilverstein, westonruter.
Fixes #50367. See #44427.

Built from https://develop.svn.wordpress.org/trunk@48170


git-svn-id: http://core.svn.wordpress.org/trunk@47939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 18:45:08 +00:00
desrosj
b83d6bd777 Docs: Remove the custom-header-uploads feature from docs. 
This was deprecated in [20212] in favor of passing `”uploads” => true` to the `custom-header` feature, so it should not be specified as an available feature in the parameter documentation.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48169


git-svn-id: http://core.svn.wordpress.org/trunk@47938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 17:41:08 +00:00
Sergey Biryukov
56342b8e8f Docs: Replace "AJAX" with "Ajax" in DocBlocks and comments, per the spelling glossary. 
Props mukesh27, sabernhardt, SergeyBiryukov.
Fixes #50064.
Built from https://develop.svn.wordpress.org/trunk@48168


git-svn-id: http://core.svn.wordpress.org/trunk@47937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 12:43:07 +00:00
Sergey Biryukov
d38a32bfac Coding Standards: Reformat some long apply_filters_deprecated() and do_action_deprecated() calls for better readability. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48167


git-svn-id: http://core.svn.wordpress.org/trunk@47936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 12:06:07 +00:00
Sergey Biryukov
d10595ce32 Canonical: Move trailing slash handling for robots.txt and sitemaps to a single condition. 
Give the unit test a more descriptive name.

Follow-up to [48153], [48155].

See #48025.
Built from https://develop.svn.wordpress.org/trunk@48166


git-svn-id: http://core.svn.wordpress.org/trunk@47935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 11:41:10 +00:00
Sergey Biryukov
bfafc0aecb Administration: Correct and simplify the logic for asc and desc arguments in WP_List_Table::get_sortable_columns(). 
Setting the initial order didn't work as expected due to reversed logic.

Follow-up to [48151].

See #45089.
Built from https://develop.svn.wordpress.org/trunk@48165


git-svn-id: http://core.svn.wordpress.org/trunk@47934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 11:35:13 +00:00
Sergey Biryukov
178059c1cb Docs: Improve DocBlocks in wp-admin/includes/file.php per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48164


git-svn-id: http://core.svn.wordpress.org/trunk@47933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 09:39:13 +00:00
Sergey Biryukov
f8c59f3152 Docs: Synchronize documentation and variable names in wp_get_(plugin|theme)_file_editable_extensions() for consistency. 
Add missing `@since` tag to `wp_get_theme_file_editable_extensions()`.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48163


git-svn-id: http://core.svn.wordpress.org/trunk@47932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 09:31:15 +00:00
Sergey Biryukov
5162a10959 Docs: Improve DocBlocks in wp-admin/includes/class-wp-list-table.php per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48162


git-svn-id: http://core.svn.wordpress.org/trunk@47931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 08:56:16 +00:00
Mike Schroder
0792fb37db Upgrade/Install: Fix Yoda condition in wp_opcache_invalidate(). 
Fixes linting failure due to Yoda condition in `wp_opcache_invalidate()` following [48160].

See #36455.
Built from https://develop.svn.wordpress.org/trunk@48161


git-svn-id: http://core.svn.wordpress.org/trunk@47930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 07:55:12 +00:00
Mike Schroder
dd11076dc7 Upgrade/Install: Invalidate OPcache for PHP files during updates. 
When files are copied into place, check whether opcode invalidation is available and attempt to invalidate to avoid unintended behavior or fatal errors from themes, plugins, or core.

Introduces `wp_opcache_invalidate()` to allow safe invalidation of PHP files from opcode cache, and a filter, `wp_opcache_invalidate_file` to override the behavior.

Replaces the existing calls to `opcache_invalidate()` in the plugin and theme editors to use the new function.

Thanks to jnylen0 for porting over a patch from ClassicPress that provided much of the approach for what is being committed.

Props nigro.simone, dd32, JasWSInc, szepe.viktor, swissspidy, JanR, asalce, Garavani, pavelevap, pputzer, GregLone, benoitchantre, jadonn, doc987, kraftbj, Krstarica, jnylen0, nextendweb, williampatton, ayeshrajans, joostdevalk, stevenkussmaul, boogah, jorbin, mikeschroder.
Fixes #36455, #50354.
Built from https://develop.svn.wordpress.org/trunk@48160


git-svn-id: http://core.svn.wordpress.org/trunk@47929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 07:15:12 +00:00
gziolo
3f2e7804c4 Editor: Introduce WP_Block and WP_Block_List classes 
Backports functionality added in Gutenberg in the following PRs:
- https://github.com/WordPress/gutenberg/pull/21467
- https://github.com/WordPress/gutenberg/pull/21925
It's a few ideas related to block rendering and the provided block value, which is particularly impactful for work around block context.

Props aduth, TimothyBJacobs, noisysocks, epiqueras, youknowriad, talldanwp, zebulan.
Fixes #49926.


Built from https://develop.svn.wordpress.org/trunk@48159


git-svn-id: http://core.svn.wordpress.org/trunk@47928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-25 05:16:11 +00:00
Andrew Ozz
85d07736bf TinyMCE: Update to 4.9.10. Changelog: https://www.tiny.cloud/docs-4x/changelog/#version4910april232020. 
Props hareesh-pillai, azaozz.
Fixes #50431.
Built from https://develop.svn.wordpress.org/trunk@48158


git-svn-id: http://core.svn.wordpress.org/trunk@47927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-24 22:06:12 +00:00
Sergey Biryukov
0f3fbcf670 Tests: Add a post author to "Parent 1" page fixture in tests/post/listPages.php. 
This avoids indeterminate ordering in `test_wp_list_pages_sort_column()`.

Fixes #50466.
Built from https://develop.svn.wordpress.org/trunk@48157


git-svn-id: http://core.svn.wordpress.org/trunk@47926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-24 15:02:08 +00:00
youknowriad
6d927e494c Block Editor: Add the Block Patterns API. 
Backport WP_Block_Pattern_Categories_Registry, WP_Block_Patterns_Registry
and block patterns registration functions from the Gutenberg repository.

Props ocean90, ellatrix
Fixes #50445.

Built from https://develop.svn.wordpress.org/trunk@48156


git-svn-id: http://core.svn.wordpress.org/trunk@47925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-24 12:59:11 +00:00
whyisjake
a45e10c6dc Canonical: Add tests for trailing slashes for robots.txt. 
See #48025.

Props Toro_Unit, joostdevalk, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@48155


git-svn-id: http://core.svn.wordpress.org/trunk@47924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-24 00:07:13 +00:00
whyisjake
bb7601f6d0 Comments: Allow wp_update_comment() to return WP_Error(). 
The `wp_update_comment_data` filter introduced in 4.7 allows comment data to be filtered before it is updated in the database.

The patch aims to handle `WP_Error` as the filter above return value in a similar manner as is done for `wp_new_comment()`.


Fixes #39732.

Props: enricosorcinelli, swissspidy, gkloveweb, jnylen0, jbpaul17, afercia, SergeyBiryukov, audrasjb, imath, davidbaumwald.

Built from https://develop.svn.wordpress.org/trunk@48154


git-svn-id: http://core.svn.wordpress.org/trunk@47923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-24 00:05:12 +00:00
whyisjake
bb7a531b75 Canonical: Ensure that when permalinks are set to a trailing slash, that robots.txt doesn't. 
Fixes #48025.

Props Toro_Unit, joostdevalk, SergeyBiryukov.


Built from https://develop.svn.wordpress.org/trunk@48153


git-svn-id: http://core.svn.wordpress.org/trunk@47922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 23:44:09 +00:00
whyisjake
4f69c150b7 Cache API: Cache the results of get_uploaded_header_images(). 
Fixes #49446.

Props pbiron, SergeyBiryukov, desrosj.


Built from https://develop.svn.wordpress.org/trunk@48152


git-svn-id: http://core.svn.wordpress.org/trunk@47921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 23:34:06 +00:00
whyisjake
cb553e4747 Administration: Update WP_List_Table::get_sortable_columns() to support asc and desc arguments. 
This makes the API a little more clear, whereas setting `false` used to mean `asc` and `true` meant `desc`, you can now use those directly, while maintaining back-compat.

Fixes #45089.

Props Tkama, SergeyBiryukov, shital-patel, desrosj, birgire, davidbaumwald. 


Built from https://develop.svn.wordpress.org/trunk@48151


git-svn-id: http://core.svn.wordpress.org/trunk@47920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 23:15:10 +00:00
whyisjake
d4f243d9a0 REST API: Ensure depracation errors are called while preloading data with the REST API. 
Fixes #50318.

Props dlh, TimothyBlynJacobs.


Built from https://develop.svn.wordpress.org/trunk@48150


git-svn-id: http://core.svn.wordpress.org/trunk@47919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 23:04:07 +00:00
whyisjake
517f6501df Security: Don't display the plugin auto-update options for mu-plugins or dropins. 
They can't be updated, so we shouldn't be showing the buttons.

Fixes #50459.

Props Chouby, audrasjb, pbiron.


Built from https://develop.svn.wordpress.org/trunk@48149


git-svn-id: http://core.svn.wordpress.org/trunk@47918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 22:58:09 +00:00
Sergey Biryukov
ce784f7ad4 I18N: Include placeholder in translator comments in wp_get_auto_update_message(). 
See #50436, #50052.
Built from https://develop.svn.wordpress.org/trunk@48148


git-svn-id: http://core.svn.wordpress.org/trunk@47917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 22:30:09 +00:00
whyisjake
8dad73a5b6 Security: Remove unnecessary DISABLE_WP_CRON check in plugin and theme automatic updates. 
Fixes #50436.

Props johnbillion, audrasjb, bookdude13, pbiron, arpitgshah.



Built from https://develop.svn.wordpress.org/trunk@48147


git-svn-id: http://core.svn.wordpress.org/trunk@47916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 22:24:09 +00:00
Sergey Biryukov
840d1c796b Accessibility: Administration: Give the link to meetup organizer handbook in the WordPress Events and News dashboard widget a more meaningful label. 
This ensures that the link still makes sense when read out of context by assistive technologies.

Additionally, underline the link per the accessibility coding standards.

Props samful, afercia, williampatton, audrasjb.
Fixes #50338.
Built from https://develop.svn.wordpress.org/trunk@48146


git-svn-id: http://core.svn.wordpress.org/trunk@47915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 21:53:09 +00:00
Sergey Biryukov
a86cfefecb Accessibility: Privacy: Improve the readability of the removed text in Privacy Policy Guide. 
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.

Additionally, replace the legacy `.error` class for "You deactivated this plugin and may no longer need this policy" message with `.notice-info`.

Follow-up to [47147], [48116].

Props afercia, audrasjb.
See #47327, #44621.
Built from https://develop.svn.wordpress.org/trunk@48145


git-svn-id: http://core.svn.wordpress.org/trunk@47914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 20:57:11 +00:00
Sergey Biryukov
dee326a5e4 Accessibility: Site Health: Make the heading text for site health check issues easier to select in Firefox. 
Props afercia, sabernhardt, johnbillion, Clorith, audrasjb.
Fixes #50281.
Built from https://develop.svn.wordpress.org/trunk@48144


git-svn-id: http://core.svn.wordpress.org/trunk@47913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 20:48:10 +00:00
Sergey Biryukov
af0df40f6b Themes: Ensure the Activate button in theme preview overlay on Add Themes screen has a consistent height. 
Props afercia, pravinparmar2404, Toru, mukesh27.
Fixes #50316.
Built from https://develop.svn.wordpress.org/trunk@48143


git-svn-id: http://core.svn.wordpress.org/trunk@47912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 20:13:10 +00:00
desrosj
c5b1a12a55 General: Rename (add|remove)_option_allowed_list() to (add|remove)_allowed_option(). 
The new names make the purpose more clear. It also adds consistency with the `$allowed_options` global variable.

Also in this change, the `wp-deprecated` dependency has been removed from the password strength meter in favor of a `window.console.log()` call to avoid adding 3 dependencies for one deprecated notice.

Props SergeyBiryukov, ocean90, desrosj
Fixes #50413.
Built from https://develop.svn.wordpress.org/trunk@48142


git-svn-id: http://core.svn.wordpress.org/trunk@47911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 18:54:16 +00:00
gziolo
6cf2f816f0 Editor: Introduce new API method that register block from block.json metadata file 
Backports changes added to Gutenberg in:
- https://github.com/WordPress/gutenberg/pull/20794
- https://github.com/WordPress/gutenberg/pull/22519
`register_block_type_from_metadata` function is going to be used to register all blocks on the server using `block.json` metadata files.

Props ocean90, azaozz, aduth, mcsf, jorgefilipecosta, spacedmonkey, nosolosw, swissspidy and noahtallen.
Fixes #50263.


Built from https://develop.svn.wordpress.org/trunk@48141


git-svn-id: http://core.svn.wordpress.org/trunk@47910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 15:45:11 +00:00
Sergey Biryukov
803a05946b Comments: Remove wp_get_include_unapproved_comments_argument() for now. 
The function seems too specific and low-level for an abstraction, is only used in two places, and does not provide a significant benefit in terms of reducing code duplication.

Follow-up to [48133].

See #8973.
Built from https://develop.svn.wordpress.org/trunk@48140


git-svn-id: http://core.svn.wordpress.org/trunk@47909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 13:53:08 +00:00
Sergey Biryukov
5e7dfff3a0 Docs: Use sentence case for comments in tests/kses.php, per the documentation standards. 
Follow-up to [48132].

See #49464, #49572.
Built from https://develop.svn.wordpress.org/trunk@48139


git-svn-id: http://core.svn.wordpress.org/trunk@47908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 11:11:10 +00:00
Sergey Biryukov
f1e9bdd9b5 Docs: Add missing @return description for some theme functions: 
* `get_stylesheet_directory_uri()`
* `get_stylesheet_uri()`
* `get_locale_stylesheet_uri()`

Props stevenlinx.
Fixes #50450.
Built from https://develop.svn.wordpress.org/trunk@48138


git-svn-id: http://core.svn.wordpress.org/trunk@47907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 10:48:09 +00:00
Sergey Biryukov
0a2d2b93e6 Docs: Synchronize descriptions for some theme functions: 
* `get_stylesheet_directory()`
* `get_stylesheet_directory_uri()`
* `get_template_directory()`
* `get_template_directory_uri()`

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48137


git-svn-id: http://core.svn.wordpress.org/trunk@47906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 10:43:09 +00:00
Sergey Biryukov
69d46b2003 I18N: Use underscores instead of dashes and interpolation instead of concatenation in domain-specific gettext hooks, per the coding standards: 
* `gettext_{$domain}`
* `gettext_with_context_{$domain}`
* `ngettext_{$domain}`
* `ngettext_with_context_{$domain}`

Additionally:
* Pass `$domain` parameter to the new hooks, for consistency with their pre-existing counterparts.
* Update documentation to explain the dynamic portion of the filter, for consistency with other dynamic hooks in core.

Follow-up to [48131].

Props swissspidy, knutsp, TimothyBlynJacobs, SergeyBiryukov.
Fixes #49518.
Built from https://develop.svn.wordpress.org/trunk@48136


git-svn-id: http://core.svn.wordpress.org/trunk@47905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 10:02:10 +00:00
whyisjake
07f71058c3 Embeds: Ensure that classic embed support works in the block editor. 
See https://github.com/WordPress/gutenberg/pull/6345

Fixes #45447.

Props swisspidy, pento, audrasjb, aduth, jrchamp, thrijith, TimothyBlynJacobs, whyisjake. 
 

Built from https://develop.svn.wordpress.org/trunk@48135


git-svn-id: http://core.svn.wordpress.org/trunk@47904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 06:08:08 +00:00
whyisjake
a918d853aa Quick/Bulk Edit: Ensure the proper actions is triggered when using the bulk updater. 
If a user selects the top option, then chooses a different option, the top selection takes precedence. This update gives a new name to the bottom action, ensuring the proper update is carried out.

Fixes 46872.

Props clayray, garrett-eclipse, subrataemfluence. 


Built from https://develop.svn.wordpress.org/trunk@48134


git-svn-id: http://core.svn.wordpress.org/trunk@47903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 05:56:08 +00:00
whyisjake
0c91c23277 Comments: Ensure the proper comment count and pages for unapproved comments. 
Previiously, unapproved comments can alter the comment count, returning incorrect page numbers.

Fixes #8973.

Props GregMulhauser, dd32, ryan, mrmist, hakre, solarissmoke, billerickson, ericlewis, SergeyBiryukov, chriscct7, dossy, lukecavanagh, renggo888, jdorner, matjack1, pento, audrasjb, imath, davidbaumwald, whyisjake.  


Built from https://develop.svn.wordpress.org/trunk@48133


git-svn-id: http://core.svn.wordpress.org/trunk@47902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 05:24:10 +00:00
whyisjake
446d06c45d Formatting: Extend wp_kses_hair and wp_kses_hair_parse to allow digits and underscores. 
Fixes a lot of issues around parsing XML/HTML attributes.

Fixes #49464.

See #34406, #48608.

Props codeforest, zodiac1978, johnpgreen, dlh, ayeshrajans, johnpgreen, rilwis, travisnorthcutt, miqrogroove, chriscct7, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@48132


git-svn-id: http://core.svn.wordpress.org/trunk@47901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 05:07:11 +00:00
whyisjake
98fc60aabe I18N: Introduce domain specific i18n gettext hooks. 
Adding context to allow for more specific targeting. New hooks:

* `gettext-{$domain}`
* `gettext_with_context-{$domain}`
* `ngettext-{$domain}`
* `ngettext_with_context-{$domain}`

Fixes #49518.

Props geminilabs, garrett-eclipse, davidbaumwald, johnbillion, whyisjake.



Built from https://develop.svn.wordpress.org/trunk@48131


git-svn-id: http://core.svn.wordpress.org/trunk@47900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 04:43:10 +00:00
noisysocks
e7f9aca8dd Editor: Revert [48119]. 
This commit caused the majority of blocks in the block editor to no longer
register as they reference the old category names.

See #50278.

Built from https://develop.svn.wordpress.org/trunk@48130


git-svn-id: http://core.svn.wordpress.org/trunk@47899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 00:15:11 +00:00
whyisjake
9edf42f215 Administration: Remove unnecessary !important CSS rules from common.css 
Fixes #47569.

Props foack, SergeyBiryukov, davidbaumwald, sabernhardt, isabel_brison, audrasjb. 


Built from https://develop.svn.wordpress.org/trunk@48129


git-svn-id: http://core.svn.wordpress.org/trunk@47898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-23 00:01:07 +00:00
whyisjake
f51cb0a7c5 Media: Ensure that uploaded images get a success notification by users with upload_files capability. 
There was an early `wp_die` that was preventing the success notification from being sent in the upload process. 

Fixes #44581.

Props pbiron, mikeschroder, joemcgill, rebasaurus, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48128


git-svn-id: http://core.svn.wordpress.org/trunk@47897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 23:53:09 +00:00
whyisjake
84f39df101 Privacy: Use relative paths for exported personal data. 
Ensures back-compat while moving to paths off of the /exports directory.

Fixes: #44038.

Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake, davidbaumwald.

Built from https://develop.svn.wordpress.org/trunk@48127


git-svn-id: http://core.svn.wordpress.org/trunk@47896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 22:40:11 +00:00
Sergey Biryukov
f27cb65e1e Administration: Remove the xmlns attribute on the <html> tag. 
The attribute is specific to XHTML and is not needed in HTML5.

Props audrasjb, diddledan, hommealone, joyously, mukesh27, valentinbora, peterwilsoncc, SergeyBiryukov.
Fixes #49126.
Built from https://develop.svn.wordpress.org/trunk@48126


git-svn-id: http://core.svn.wordpress.org/trunk@47895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 21:26:16 +00:00
Sergey Biryukov
89e99f57a2 Site Health: Correct the check of whether the theme directory is writable when the current theme is symlinked into the theme directory. 
This ensures that the check is done on a sub-directory within `WP_CONTENT_DIR`, rather than outside of `ABSPATH`.

Props pbiron, Clorith.
Fixes #48199.
Built from https://develop.svn.wordpress.org/trunk@48125


git-svn-id: http://core.svn.wordpress.org/trunk@47894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 20:15:14 +00:00
desrosj
d0d8ce1adb Docs: Small inline documentation corrections following [48121]. 
Also, remove the `version` argument from the `wp.deprecated()` call in `password-strength-meter.js`. This argument is for specifying the version a feature will be removed, not when the feature was removed.

Props hareesh-pillai.
Fixes #50413.
Built from https://develop.svn.wordpress.org/trunk@48124


git-svn-id: http://core.svn.wordpress.org/trunk@47893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 19:09:11 +00:00
desrosj
35545bee43 Administration: Improve the plugin and theme auto-update emails. 
This makes several improvements to the emails sent to site admins when plugin and theme auto-updates are attempted.

- Emails are now specifically tailored to the three results (success, failed, or mixed).
- Subject lines and body copy for mixed and failed results now correctly convey the importance of double checking the site in question.
- The site’s URL is now included in all emails.
- When failures occur, links to the Plugins and/or Themes pages in the admin are now included so that site owners can easily take action.

Props audrasjb, desrosj, azaozz, garrett-eclipse, paaljoachim, johnbillion, marybaum, pbiron.
Follow up to [47835].
See #50052.
Fixes #50268.
Built from https://develop.svn.wordpress.org/trunk@48123


git-svn-id: http://core.svn.wordpress.org/trunk@47892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 18:18:08 +00:00
desrosj
acc97eae32 General: Reference the correct database version for 5.5.0 upgrades. 
Follow up to [48121].

See #50413.
Built from https://develop.svn.wordpress.org/trunk@48122


git-svn-id: http://core.svn.wordpress.org/trunk@47891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 17:33:08 +00:00
desrosj
4b60af1a6a General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language. 
“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the `$new_whitelist_options` global variable) are removed. A new ticket has been opened to explore renaming the `$new_whitelist_options` variable (#50434).

Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.

Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.

Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900, #50434.
Fixes #50413.
Built from https://develop.svn.wordpress.org/trunk@48121


git-svn-id: http://core.svn.wordpress.org/trunk@47890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 17:26:13 +00:00
Sergey Biryukov
7dbc898342 Plugins: Make the appearance of plugin action links on Add Plugins screen more consistent. 
This ensures that the "More Details" link does not randomly wrap to a second line depending on the length of the button label above.

Props sabernhardt, kharisblank, Otto42, paresh07.
Fixes #48648.
Built from https://develop.svn.wordpress.org/trunk@48120


git-svn-id: http://core.svn.wordpress.org/trunk@47889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 15:30:18 +00:00
ellatrix
2349d1f999 Editor: Update default block categories 
See https://github.com/WordPress/gutenberg/pull/19279.

Props aduth, gziolo.
Fixes #50278.

Built from https://develop.svn.wordpress.org/trunk@48119


git-svn-id: http://core.svn.wordpress.org/trunk@47888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 14:07:10 +00:00
gziolo
85c5bca472 Editor: Remove default "layout" block attribute from WP_Block_Type::get_attributes 
The merging behavior which assigns the `layout` attribute in `WP_Block_Type` gets removed.

Props aduth, TimothyBlynJacobs.
Fixes #50257.


Built from https://develop.svn.wordpress.org/trunk@48118


git-svn-id: http://core.svn.wordpress.org/trunk@47887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 12:22:08 +00:00
gziolo
29ffb31cb3 Blocks: Add context fields to WP_Block_Type 
New block context related fields were added as part of https://github.com/WordPress/gutenberg/pull/22686. This changest backports them to WP_Block_Type class.

Props aduth, spacedmonkey, mcsf, epiqueras.
Fixes #47656.  


Built from https://develop.svn.wordpress.org/trunk@48117


git-svn-id: http://core.svn.wordpress.org/trunk@47886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-22 10:26:14 +00:00
Andrea Fercia
aa98d37cad Accessibility: Improve readability by removing unnecessary italic font style. 
Continues the removal of italic text where unnecessary or where used on whole lines and big chunks of text.
Removes italic type from:
- all the `howto` text e.g. the "Tags" meta box, the "Featured image" meta box, the "Insert/edit link" modal dialog in the Classic Editor 
- the Taxonomies list pages
- the edit Taxonomies pages
- the Menus page
- the Settings pages

Props audrasjb.
See #47327.

Built from https://develop.svn.wordpress.org/trunk@48116


git-svn-id: http://core.svn.wordpress.org/trunk@47885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 18:03:10 +00:00
Andrea Fercia
ae447adaf4 I18N: Restore the "Error:" prefix for error messages. 
Partially reverts [48059] as there's no full consensus on the removal of the text prefix. Further actions should be taken to improve consistency and accessibility of the admin notices. Keeps some improvements to the translatable strings from [48059].

Fixes #47656.

Built from https://develop.svn.wordpress.org/trunk@48115


git-svn-id: http://core.svn.wordpress.org/trunk@47884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 14:00:09 +00:00
Sergey Biryukov
e0d440f77f Posts, Post Types: Avoid a PHP warning when get_the_content() is called outside of the loop. 
This ensures that `$pages` and other globals are only used after they have been set up in `setup_postdata()`.

Follow-up to [44941].

Props tessawatkinsllc, dontdream, spacedmonkey, squarecandy, davidbaumwald, SergeyBiryukov.
Fixes #47824. See #42814.
Built from https://develop.svn.wordpress.org/trunk@48114


git-svn-id: http://core.svn.wordpress.org/trunk@47883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 10:36:07 +00:00
Sergey Biryukov
08d4e7dd69 Posts, Post Types: Simplify test_setup_postdata_loop(). 
The important part here is calling `the_content()` after setting up post data for another post without updating global `$post`.

The `foreach()` loop is not necessary.

Follow-up to [UT1289].

See #47824, #24330.
Built from https://develop.svn.wordpress.org/trunk@48113


git-svn-id: http://core.svn.wordpress.org/trunk@47882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-21 10:30:15 +00:00
TimothyBlynJacobs
88f54b22ba REST API: Add "Link" to the list of exposed cors headers. 
Currently, only the X-WP-Total and X-WP-TotalPages headers are exposed which means that clients have to manually construct the URL to implement pagination instead of using the "prev" and "next" Links.

Additionally, a filter "rest_exposed_cors_headers" is introduced to make it simpler for plugins to expose additional headers.

Props Toro_Unit, ayeshrajans.
Fixes #50369.

Built from https://develop.svn.wordpress.org/trunk@48112


git-svn-id: http://core.svn.wordpress.org/trunk@47881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 23:56:12 +00:00
Sergey Biryukov
19bca10d79 Coding Standards: Replace echo sprintf() with printf(). 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48111


git-svn-id: http://core.svn.wordpress.org/trunk@47880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 13:18:11 +00:00
Sergey Biryukov
be16bb9fba Docs: Remove extra spaces from @param tags. 
Per the documentation standards, `@param` tags should be aligned with each other, but not with the `@return` tag.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48110


git-svn-id: http://core.svn.wordpress.org/trunk@47879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:58:10 +00:00
Sergey Biryukov
b16368c268 Docs: Remove @staticvar tags from core. 
The tag was supported in phpDocumentor 1.x, but is no longer supported in 2.x and 3.x.

Usage of static variables is considered an internal implementation detail and has no information value for someone reading the docs.

Props alishanvr, jrf.
Fixes #50426.
Built from https://develop.svn.wordpress.org/trunk@48109


git-svn-id: http://core.svn.wordpress.org/trunk@47878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:40:12 +00:00
Sergey Biryukov
65724cf380 Docs: Correct DocBlock placement for allow_subdirectory_install filter. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48108


git-svn-id: http://core.svn.wordpress.org/trunk@47877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:24:08 +00:00
Sergey Biryukov
d586e4330d Docs: Miscellaneous DocBlock corrections for email filters in wp-includes/user.php. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48107


git-svn-id: http://core.svn.wordpress.org/trunk@47876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:22:07 +00:00
Sergey Biryukov
3fb623cf76 Docs: Use a hyphen with the "non" prefix in a more consistent way. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48106


git-svn-id: http://core.svn.wordpress.org/trunk@47875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:16:10 +00:00
Sergey Biryukov
26621b3b44 Docs: Miscellaneous DocBlock corrections for plugin and theme installation and updates. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48105


git-svn-id: http://core.svn.wordpress.org/trunk@47874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:14:09 +00:00
Sergey Biryukov
e13c363b17 Docs: Capitalize "ID", when referring to a post ID, term ID, etc. in a more consistent way. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48104


git-svn-id: http://core.svn.wordpress.org/trunk@47873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 12:02:12 +00:00
Sergey Biryukov
58bda42fc8 Docs: Synchronize and correct the documentation for wp_nav_menu() arguments in bundled themes. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48103


git-svn-id: http://core.svn.wordpress.org/trunk@47872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 11:22:10 +00:00
Sergey Biryukov
a576a13246 Docs: Remove an empty line between @param and @return tags, per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48102


git-svn-id: http://core.svn.wordpress.org/trunk@47871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 11:18:09 +00:00
John Blackbourn
afe406b82e Docs: Fix some documentation errors in bundled themes. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48101


git-svn-id: http://core.svn.wordpress.org/trunk@47870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-20 07:24:06 +00:00
John Blackbourn
1a77bb81d8 Docs: Remove unnecessary variables names from @return tags. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48100


git-svn-id: http://core.svn.wordpress.org/trunk@47869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:55:12 +00:00
John Blackbourn
37234874a5 Docs: Misc improvements to inline docs. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48099


git-svn-id: http://core.svn.wordpress.org/trunk@47868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:28:13 +00:00
John Blackbourn
fe823d698f Docs: Corrections and improvements to inline docs related to XML sitemaps. 
See #50117, #49572
Built from https://develop.svn.wordpress.org/trunk@48098


git-svn-id: http://core.svn.wordpress.org/trunk@47867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:26:10 +00:00
John Blackbourn
acb8983ac1 Docs: Corrections and improvements to inline docs related to plugin and theme auto-updates. 
See #50052, #49572
Built from https://develop.svn.wordpress.org/trunk@48097


git-svn-id: http://core.svn.wordpress.org/trunk@47866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:17:07 +00:00
Sergey Biryukov
99d49a0cc3 Build/Test Tools: Replace the banner text from wp-emoji-loader.min.js in formatting.php during build process. 
This ensures that `/*! This file is auto-generated */` comment is not included on front end as part of the inline Emoji detection script.

Follow-up to [41271], [46589].

Props superpoincare, SergeyBiryukov.
Fixes #49861.
Built from https://develop.svn.wordpress.org/trunk@48096


git-svn-id: http://core.svn.wordpress.org/trunk@47865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 22:08:08 +00:00
Sergey Biryukov
82a5d41d9b Help/About: Move "Learn more: Auto-updates documentation" link about "Support", for consistency with other screens. 
Follow-up to [48062].

See #50215.
Built from https://develop.svn.wordpress.org/trunk@48095


git-svn-id: http://core.svn.wordpress.org/trunk@47864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 21:14:08 +00:00
Sergey Biryukov
896436f1b9 Sitemaps: Rename the wp_sitemaps_is_enabled filter to wp_sitemaps_enabled. 
This makes it more consistent with the other filters of the similar purpose.

Props arpitgshah.
Fixes #50428. See #50117.
Built from https://develop.svn.wordpress.org/trunk@48094


git-svn-id: http://core.svn.wordpress.org/trunk@47861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 18:00:07 +00:00
Sergey Biryukov
a15912561e Docs: Document globals in WP_Sitemaps_* classes the same way they are documented in the rest of core. 
See #49572, #50117.
Built from https://develop.svn.wordpress.org/trunk@48093


git-svn-id: http://core.svn.wordpress.org/trunk@47860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 17:56:09 +00:00
Andrew Ozz
aca919f007 Plugins and Themes Auto-Updates: 
- Fix displaying of errors on the Themes screen.
- Correct the classes used for the error messages, and use `notice-alt` as notices are mostly shown on a white background.

Props afercia, azaozz.
Fixes #50405.
Built from https://develop.svn.wordpress.org/trunk@48092


git-svn-id: http://core.svn.wordpress.org/trunk@47859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 16:51:14 +00:00
desrosj
019bc2d244 Docs: Add missing return type for _remove_theme_support(). 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48091


git-svn-id: http://core.svn.wordpress.org/trunk@47858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 14:46:10 +00:00
Sergey Biryukov
0050998801 Filesystem API: Expicitly set directory permissions in WP_Filesystem_SSH2::mkdir(). 
This ensures the permissions are correct after a directory is created with `ssh2_sftp_mkdir()`, which appears to be affected by system `umask` settings.

Props bbrdaric.
Fixes #49218.
Built from https://develop.svn.wordpress.org/trunk@48090


git-svn-id: http://core.svn.wordpress.org/trunk@47857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 10:38:08 +00:00
Sergey Biryukov
527696af3b Coding Standards: Add some space around control structures in WP_Filesystem_* classes for consistency and better readability. 
Additionally, synchronize `$tempfile` and `$temphandle` variable names in `WP_Filesystem_FTPext` and `WP_Filesystem_ftpsockets`.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@48089


git-svn-id: http://core.svn.wordpress.org/trunk@47856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-19 10:36:12 +00:00
whyisjake
1e3d4921fb Privacy: Revert use relative paths for exported personal data. 
Tests need to be updated to pass.

See: #44038.

Unprops: whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48088


git-svn-id: http://core.svn.wordpress.org/trunk@47855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 23:02:10 +00:00
whyisjake
2d514c83d5 Privacy: Use relative paths for exported personal data. 
Ensures back-compat while moving to paths off of the `/exports` directory.

Fixes: #44038.

Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake. 


Built from https://develop.svn.wordpress.org/trunk@48087


git-svn-id: http://core.svn.wordpress.org/trunk@47854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 21:40:14 +00:00
Adam Silverstein
810e9c3c2b Formatting: new filter safecss_filter_attr_allow_css on css parts. 
Enables developers to determine whether a section of CSS should be allowed or discarded. By default, the value will be false if the part contains \ ( & } = or comments. Returning true allows the CSS part to be included in the output.

Replaces the `safe_style_disallowed_chars` filter introduced in r47891.

Props azaozz.
Fixes #37134.


Built from https://develop.svn.wordpress.org/trunk@48086


git-svn-id: http://core.svn.wordpress.org/trunk@47853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 21:01:11 +00:00
Sergey Biryukov
50ffc3843b Docs: Add missing $user_data parameter name to lostpassword_post and lostpassword_errors filter DocBlocks. 
Follow-up to [48084].

See #49521, #49572.
Built from https://develop.svn.wordpress.org/trunk@48085


git-svn-id: http://core.svn.wordpress.org/trunk@47852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 20:29:15 +00:00
Sergey Biryukov
2c19aee6d5 Login and Registration: Introduce lostpassword_errors filter in retrieve_password() for errors encountered on a password reset request. 
This complements the `registration_errors` filter in `register_new_user()`.

Props wpdo5ea, dilipbheda.
Fixes #49521.
Built from https://develop.svn.wordpress.org/trunk@48084


git-svn-id: http://core.svn.wordpress.org/trunk@47851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 20:24:09 +00:00
Sergey Biryukov
05e28b4d7c Coding Standards: Use strict comparison for JS fragment in wp-admin/admin-header.php. 
Props subrataemfluence.
Fixes #45810.
Built from https://develop.svn.wordpress.org/trunk@48083


git-svn-id: http://core.svn.wordpress.org/trunk@47850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 20:08:09 +00:00
Sergey Biryukov
8d3075952e Administration: Combine the styles for <p> and .wp-die-message, instead of duplicating. 
This brings some consistency with `_default_wp_die_handler()`, where they are already combined.

Follow-up to [45909].

See #47580.
Built from https://develop.svn.wordpress.org/trunk@48082


git-svn-id: http://core.svn.wordpress.org/trunk@47849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 15:07:11 +00:00
Sergey Biryukov
168a9df672 Coding Standards: Fix WPCS issues in wp-includes/sitemaps/. 
Some of these were not caught when running `composer lint:errors`, but are fixed when running `phpcbf` directly.

Follow-up to [48072], [48080].

See #49542, #50117.
Built from https://develop.svn.wordpress.org/trunk@48081


git-svn-id: http://core.svn.wordpress.org/trunk@47848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 14:46:09 +00:00
Sergey Biryukov
e1bd050cb9 Coding Standards: Remove unused variable in WP_Sitemaps_Provider::get_sitemap_entries(). 
Follow-up to [48072].

See #49542, #50117.
Built from https://develop.svn.wordpress.org/trunk@48080


git-svn-id: http://core.svn.wordpress.org/trunk@47847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 14:44:07 +00:00
Pascal Birchler
fcd890e546 Sitemaps: Bump $wp_db_version to flush rewrite rules after [48072]. 
Props ocean90.
See #50117.

Built from https://develop.svn.wordpress.org/trunk@48079


git-svn-id: http://core.svn.wordpress.org/trunk@47846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 11:26:17 +00:00
Andrew Ozz
d61790f9dc Fix empty line phpcs error. 
See #50280.
Built from https://develop.svn.wordpress.org/trunk@48078


git-svn-id: http://core.svn.wordpress.org/trunk@47845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 00:46:09 +00:00
Andrew Ozz
7757ad5e94 Plugins and Themes Auto-Updates: allow overriding of the HTML for the auto-update setting link. This will let plugins show better/specific information when they are overriding the auto-update settings, for example "Updates are managed by ... plugin". 
Introduces: `theme_auto_update_setting_html`, `plugin_auto_update_setting_html`, and `theme_auto_update_setting_template` filters.

Props audrasjb, pbiron, azaozz.
Fixes #50280.
Built from https://develop.svn.wordpress.org/trunk@48077


git-svn-id: http://core.svn.wordpress.org/trunk@47844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-18 00:00:13 +00:00
Sergey Biryukov
cb72d22d67 Menus: Check the correct variable in Walker_Nav_Menu_Edit::start_el() when menu item is a taxonomy term. 
Follow-up to [45891].

Props ashour.
Fixes #50415.
Built from https://develop.svn.wordpress.org/trunk@48076


git-svn-id: http://core.svn.wordpress.org/trunk@47843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 19:47:14 +00:00
Sergey Biryukov
d81302511d External Libraries: Update Moment.js to 2.26.0. 
Changelog: https://github.com/moment/moment/compare/2.22.2...2.26.0

This commit also fixes a deprecation warning regarding the usage of `moment.locale()` to set locale properties.

As of Moment.js 2.12.0, `moment.locale()` is deprecated and `moment.updateLocale()` should be used instead.

Additionally, minimize `moment.js` as part of build process to remove the source map reference.

This avoids a `sourceMappingURL` being in the minified file, as we don't ship source maps.

Props yoancutillas, SergeyBiryukov.
Fixes #50408.
Built from https://develop.svn.wordpress.org/trunk@48075


git-svn-id: http://core.svn.wordpress.org/trunk@47842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 17:40:27 +00:00
ianbelanger
1a767ac06f Bundled Themes: Twenty Sixteen table border extends beyond table. 
Fixes issues where tables created by the table block have an extra border on the left side which extends below the table.

Props gsmumbo, mukesh27, JavierCasares.
Fixes #50180.
Built from https://develop.svn.wordpress.org/trunk@48074


git-svn-id: http://core.svn.wordpress.org/trunk@47841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 17:27:09 +00:00
ianbelanger
48eea2481c Bundled Themes: Twenty Nineteen horizontal rule is very narrow. 
Fixes the issue by adding specific styles for the `<hr>` tag.

Props laurelfulford, nielslange, kjellr, samful, leprincenoir.
Fixes #45912.
Built from https://develop.svn.wordpress.org/trunk@48073


git-svn-id: http://core.svn.wordpress.org/trunk@47840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 15:48:09 +00:00
Pascal Birchler
609dd1d14f Sitemaps: Add XML sitemaps functionality to WordPress. 
While web crawlers are able to discover pages from links within the site and from other sites, XML sitemaps supplement this approach by allowing crawlers to quickly and comprehensively identify all URLs included in the sitemap and learn other signals about those URLs using the associated metadata.

See https://make.wordpress.org/core/2020/06/10/merge-announcement-extensible-core-sitemaps/ for more details.

This feature exposes the sitemap index via `/wp-sitemap.xml` and exposes a variety of new filters and hooks for developers to modify the behavior. Users can disable sitemaps completely by turning off search engine visibility in WordPress admin.

This change also introduces a new `esc_xml()` function to escape strings for output in XML, as well as XML support to `wp_kses_normalize_entities()`.

Props Adrian McShane, afragen, adamsilverstein, casiepa, flixos90, garrett-eclipse, joemcgill, kburgoine, kraftbj, milana_cap, pacifika, pbiron, pfefferle, Ruxandra Gradina, swissspidy, szepeviktor, tangrufus, tweetythierry.
Fixes #50117.
See #3670. See #19998.

Built from https://develop.svn.wordpress.org/trunk@48072


git-svn-id: http://core.svn.wordpress.org/trunk@47839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 15:24:07 +00:00
desrosj
689fdc6319 Site Health: Verify PHP version requirements when auto-updating themes. 
Follow up of [47819].
See #49653.
Fixes #50411.
Built from https://develop.svn.wordpress.org/trunk@48071


git-svn-id: http://core.svn.wordpress.org/trunk@47838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 14:48:07 +00:00
Sergey Biryukov
a9a6b25cae Script Loader: Include the script or style handle in _wp_scripts_maybe_doing_it_wrong() message. 
This makes the message more helpful and allows for easier debugging.

Props janthiel.
Fixes #50406.
Built from https://develop.svn.wordpress.org/trunk@48070


git-svn-id: http://core.svn.wordpress.org/trunk@47837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 10:16:08 +00:00
TimothyBlynJacobs
41f70ae5f8 REST API: Only register one block renderer route. 
Every block has a different set of attributes. These attributes are specified as a JSON Schema object. Previously, every block registered its own block renderer route using its attributes for the schema. This allowed for the attributes to be validated using the built in endpoint validation rules. It had the unfortunate side effect, however, of creating a large number of nearly identical REST API routes, one for each dynamic block. Each registered route has a performance impact. As the number of server side blocks goes up, this becomes more and more of an issue.

Now, we register a single block renderer route and dynamically validate the attributes based on the selected block.

Fixes #48079.
Props gziolo, TimothyBlynJacobs.

Built from https://develop.svn.wordpress.org/trunk@48069


git-svn-id: http://core.svn.wordpress.org/trunk@47836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-17 03:22:12 +00:00
Sergey Biryukov
353c9bfc58 Docs: List the expected return type first for size_format() and wp_get_original_referer(). 
Follow-up to [46696], [47060].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48068


git-svn-id: http://core.svn.wordpress.org/trunk@47835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 21:24:07 +00:00
Sergey Biryukov
de59ad23a4 Docs: Consistently include an empty line between @since tag and @see, @link, or @global, per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48067


git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 21:07:14 +00:00
Sergey Biryukov
8fdb0728be Text Changes: Replace "webmaster" with "site admin" in register_new_user(). 
Follow-up to [48049], accidentally reverted in [48059].

Props kebbet.
See #50394.
Built from https://develop.svn.wordpress.org/trunk@48066


git-svn-id: http://core.svn.wordpress.org/trunk@47833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 20:05:10 +00:00
Sergey Biryukov
a8cd3a3e2c Coding Standards: Rename the $clean or $ids variable in several functions to $non_cached_ids for clarity. 
* `_get_non_cached_ids()`
* `update_meta_cache()`
* `update_object_term_cache()`

See #49542.
Built from https://develop.svn.wordpress.org/trunk@48065


git-svn-id: http://core.svn.wordpress.org/trunk@47832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 19:09:08 +00:00
ianbelanger
c5ee065c3a Bundled Themes: Twenty Seventeen pagination links don't appear for home pages. 
Fixes issues where pagination does not work on the page that is set to the home page.

Props dimitris.m, laurelfulford, poena, ianbelanger, samful.
Fixes #39685.
Built from https://develop.svn.wordpress.org/trunk@48064


git-svn-id: http://core.svn.wordpress.org/trunk@47831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 18:40:07 +00:00
Sergey Biryukov
49edaea6f1 Coding Standards: Fix WPCS issues in wp-admin/nav-menus.php. 
Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@48063


git-svn-id: http://core.svn.wordpress.org/trunk@47830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 18:38:08 +00:00
whyisjake
97e2b94f84 Help/About: Add help tabs to provide informations about plugin & themes auto-updates. 
Adds language around how the feature works and includes links to the WordPress HelpHub pages.

Fixes: #50215.
Props: audrasjb, garrett-eclipse, paaljoachim, marybaum, pbiron, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48062


git-svn-id: http://core.svn.wordpress.org/trunk@47829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 17:29:07 +00:00
ianbelanger
5e0879db84 Bundled Themes: Twenty Seventeen Navbar z-index issue. 
Fixes navbar z-index issue by upping the z-index value to 1000 from 7.

Props halgatewood, justnorris, poena, sinatrateam.
Fixes #39384.
Built from https://develop.svn.wordpress.org/trunk@48061


git-svn-id: http://core.svn.wordpress.org/trunk@47828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 17:16:10 +00:00
whyisjake
ed1e6c3d87 Themes: Add additional later escaping to post_class() and body_class() functions. 
Additionally, this adds a few tests to test output.

Fixes #20009.

Props mfields, scribu, azaozz, obenland, dd32, nacin, jrf, jdgrimes, garyj, whyisjake. 
 

Built from https://develop.svn.wordpress.org/trunk@48060


git-svn-id: http://core.svn.wordpress.org/trunk@47827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 16:57:15 +00:00
Andrea Fercia
f83c504b88 I18N: Remove the "Error:" prefix from error messages. 
For a number of years, most of the WordPress error messages have been prefixed with "Error:". However, these messages appear in a context where it's already clear an error occurred. Whether it's an error, a warning, or any other classification, that's not so relevant for users. The content of the message is the relevant part. The "Error:" prefix doesn't add great value while it does add unnecessary complexity for the message readability.

Also, revises some of these messages to improve clarity and removes HTML from translatable strings.

Props garrett-eclipse, ramiy, SergeyBiryukov, afercia, sabernhardt, quadthemes, audrasjb. 
See #47003, #43037, #42945, #15887.
Fixes #47656.

Built from https://develop.svn.wordpress.org/trunk@48059


git-svn-id: http://core.svn.wordpress.org/trunk@47826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 15:35:13 +00:00
desrosj
8f065b688d Build/Test Tools: Prevent double /s when including PHPMailer files. 
`ABSPATH` includes a trailing slash already.

Follow up of [48033].
Props desrosj.
See #50377, #41750.
Built from https://develop.svn.wordpress.org/trunk@48058


git-svn-id: http://core.svn.wordpress.org/trunk@47825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 13:59:12 +00:00
Sergey Biryukov
1f06606aa7 Customize: Introduce get_custom_logo_image_attributes filter for the list of custom logo image attributes. 
Props achbed, dlh, westonruter.
Fixes #36640.
Built from https://develop.svn.wordpress.org/trunk@48057


git-svn-id: http://core.svn.wordpress.org/trunk@47824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 11:49:08 +00:00
whyisjake
bdb1fe0d7e Administration: Remove wp-auth-check from the Heartbeat API. 
As of [27153], wp-auth-check is returned on all heartbeats without the need for data from client-side. This also means that the timing and scheduling of this request data is ineffectual.

Fixes #50305.

Props dsixinetu, azaozz, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48056


git-svn-id: http://core.svn.wordpress.org/trunk@47823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 07:09:09 +00:00
whyisjake
8a6cc1a810 Cache API: Add wp_cache_get_multiple() to core functions. 
* `update_object_term_cache`
* `update_meta_cache`
* `_get_non_cached_ids`

See [47938].

Fixes #50352.

Props spacedmonkey, tillkruss, lukecavanagh. 


Built from https://develop.svn.wordpress.org/trunk@48055


git-svn-id: http://core.svn.wordpress.org/trunk@47822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 06:30:09 +00:00
whyisjake
28c6339400 I18N: Add i18n to size_format(). 
Add translatable strings to the units of the `size_format()` function.

Props Rahe, audrasjb, ocean90.

Fixes #50194.


Built from https://develop.svn.wordpress.org/trunk@48054


git-svn-id: http://core.svn.wordpress.org/trunk@47821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 06:10:08 +00:00
whyisjake
ea8331f00d REST API: Allow queries other than the main query to be is_home. 
Ensure that REST API calls can match the main query of the page. 

See #34373.

Fixes #50213.

Props: dlh, TimothyBlynJacobs, boonebgorges, joemcgill, whyisjake. 


Built from https://develop.svn.wordpress.org/trunk@48053


git-svn-id: http://core.svn.wordpress.org/trunk@47820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 06:04:12 +00:00
whyisjake
ccf534dc48 Code Standards: Cleanup some code spacing. 
See: #37826 and #44286.

Built from https://develop.svn.wordpress.org/trunk@48052


git-svn-id: http://core.svn.wordpress.org/trunk@47819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-16 00:56:08 +00:00
whyisjake
d3c44a690d Menus: Provide menu settings when creating a new menu. 
This simplifies the steps in the process of adding new menus.

Props: garrett-eclipse, audrasjb, ianjvr. 

Built from https://develop.svn.wordpress.org/trunk@48051


git-svn-id: http://core.svn.wordpress.org/trunk@47818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 23:22:06 +00:00
whyisjake
28d29b35f7 Comments: Don't display edit links to trashed post comments. 
If a post is in the trash, the comments bubble won't link to the comments list.

Fixes: #37826.
Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion. 



Built from https://develop.svn.wordpress.org/trunk@48050


git-svn-id: http://core.svn.wordpress.org/trunk@47817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 23:06:08 +00:00
Sergey Biryukov
6aa5788189 Text Changes: Replace "Webmaster" in output messages with more appropriate terms: 
* "All at `###SITENAME###`" in `wp-admin/ms-delete-site.php`, for consistency with other Multisite emails.
* "Site admin" in `register_new_user()`, for clarity.

Props Presskopp, marybaum.
Fixes #50394.
Built from https://develop.svn.wordpress.org/trunk@48049


git-svn-id: http://core.svn.wordpress.org/trunk@47816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 19:41:11 +00:00
desrosj
4cdd79af25 Emoji: Upgrade Twemoji to version 13.0.0. 
🥸

Props kraftbj, desrosj, otto42.
Fixes #50148.
Built from https://develop.svn.wordpress.org/trunk@48048


git-svn-id: http://core.svn.wordpress.org/trunk@47815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 18:04:26 +00:00
ianbelanger
6d914acd6c Bundled Themes: Twenty Nineteen dropcap appears higher than expected in Firefox. 
Fixes the issue by adding moz specific top margin for the dropcap.

Props kjellr, joseph.dickson, maxpertici, samful.
Fixes #45876.
Built from https://develop.svn.wordpress.org/trunk@48047


git-svn-id: http://core.svn.wordpress.org/trunk@47814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 15:13:09 +00:00
desrosj
b8de1549ff Coding Standards: Remove the PHP Compatibility scanning job from the allowed_failures list. 
All pre-existing compatibility warnings and errors as flagged by the PHPCompatibilityWP ruleset have been addressed.

Fixes #49922.
Built from https://develop.svn.wordpress.org/trunk@48046


git-svn-id: http://core.svn.wordpress.org/trunk@47813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 15:04:10 +00:00
desrosj
c4a89f1635 General: Continuing to work towards a passing PHP Compatibility scan. 
- Add `phpcs:ignore` statements to compatibility checks in PHPMailer.
- Remove quotes around the assertion in an `assert()` call. This will trigger a deprecated notice under certain conditions on PHP 7.2.

Props jrf, desrosj.
See #49922, #48033.
Built from https://develop.svn.wordpress.org/trunk@48045


git-svn-id: http://core.svn.wordpress.org/trunk@47812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 14:56:07 +00:00
Sergey Biryukov
942fc4e0fc Networks and Sites: Don't unnecessarily switch to the current blog in get_blog_details(). 
Props arpitgshah, djennez, acsnaterse, joostdevalk, SergeyBiryukov.
Fixes #50391.
Built from https://develop.svn.wordpress.org/trunk@48044


git-svn-id: http://core.svn.wordpress.org/trunk@47811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-15 12:31:11 +00:00
Sergey Biryukov
a1f8dd4972 Posts, Post Types: Introduce default_category_post_types filter. 
The filter allows custom post types associated with the `category` taxonomy to opt in to requiring a default category, same as regular posts.

Props enrico.sorcinelli.
Fixes #43516.
Built from https://develop.svn.wordpress.org/trunk@48043


git-svn-id: http://core.svn.wordpress.org/trunk@47810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 21:42:17 +00:00
Dominik Schilling
893c580831 Users: On the 'Add New User' screen, don't show the roles dropdown if the current user can't promote other users. 
Fixes #50345.
Built from https://develop.svn.wordpress.org/trunk@48042


git-svn-id: http://core.svn.wordpress.org/trunk@47809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 17:03:10 +00:00
Dominik Schilling
9f7a7f8d57 Coding Standards: Fix code indentation in post_submit_meta_box() to improve readability. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48041


git-svn-id: http://core.svn.wordpress.org/trunk@47808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 16:31:08 +00:00
Sergey Biryukov
d776a4d15e Coding Standards: Use strict comparison in js/_enqueues/lib/ajax-response.js. 
Props ankitmaru.
Fixes #50320.
Built from https://develop.svn.wordpress.org/trunk@48040


git-svn-id: http://core.svn.wordpress.org/trunk@47807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 11:28:07 +00:00
Sergey Biryukov
01eb2907a7 Accessibility: Themes: Don't link to the home page in get_custom_logo() when it's displayed on the home page. 
Props Soean, audrasjb, sabernhardt, FlorianBrinkmann, rianrietveld, afercia, joedolson, samful, knutsp, SergeyBiryukov.
See #37011.
Built from https://develop.svn.wordpress.org/trunk@48039


git-svn-id: http://core.svn.wordpress.org/trunk@47806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-14 10:02:11 +00:00
Sergey Biryukov
e6ee3f742e External Libraries: Update Masonry to 4.2.2 and imagesLoaded to 4.1.4. 
Notable changes include dropping support for IE 8 & 9, which are no longer supported by WordPress core either.

Release notes:
https://github.com/desandro/masonry/releases
https://github.com/desandro/imagesloaded/releases

Changelogs:
https://github.com/desandro/masonry/compare/v3.3.2...v4.2.2
https://github.com/desandro/imagesloaded/compare/v3.2.0...v4.1.4

Props pierlo, hareesh-pillai, grapplerulrich, pderksen, desrosj, garrett-eclipse, SergeyBiryukov.
Fixes #37675, #48031.
Built from https://develop.svn.wordpress.org/trunk@48038


git-svn-id: http://core.svn.wordpress.org/trunk@47805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-13 18:53:27 +00:00
Sergey Biryukov
04200b39ce Themes: Ensure the theme slug is set before checking if the theme is installed or active. 
This fixes an issue with every installed theme being marked as active on Themes screen.

The slug is set on Add Themes screen, but not on Themes.

Follow-up to [47924].

Props BackuPs, mukesh27, SergeyBiryukov.
Fixes #50381. See #50334.
Built from https://develop.svn.wordpress.org/trunk@48037


git-svn-id: http://core.svn.wordpress.org/trunk@47804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-13 14:26:07 +00:00
Sergey Biryukov
c7b843302f Coding Standards: Exclude the whole PHPMailer directory from WPCS checks, for consistency with other external libraries in their own directory. 
Follow-up to [48033].

See #41750.
Built from https://develop.svn.wordpress.org/trunk@48036


git-svn-id: http://core.svn.wordpress.org/trunk@47803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-13 12:36:10 +00:00
Sergey Biryukov
aa5017ebb9 External Libraries: Add class aliases for phpmailerException and SMTP to deprecated files to account for the new namespace. 
This ensures backward compatibility with plugins using the old `class-phpmailer.php` or `class-smtp.php` files.

Follow-up to [48033].

Props Otto42.
Fixes #50379. See #41750.
Built from https://develop.svn.wordpress.org/trunk@48035


git-svn-id: http://core.svn.wordpress.org/trunk@47802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 21:42:09 +00:00
TimothyBlynJacobs
afaeaf1529 External Libraries: Skip deprecated file warning for PHPMailer if the API is not loaded. 
In [48033] the "class-phpmailer.php" file was deprecated. In test suites, this file is loaded before WordPress in order to setup a mock PHPMailer instance. This means that for test suites that are still loading that file, they'll experience fatal errors due to the undefined "_deprecated_file" function.

This commit skips issuing the deprecated file warning if the "_deprecated_file" function is not available.

Fixes #50380.

Built from https://develop.svn.wordpress.org/trunk@48034


git-svn-id: http://core.svn.wordpress.org/trunk@47801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 21:10:08 +00:00
desrosj
e4379c5ba8 External Libraries: Upgrade PHPMailer to version 6.1.6. 
Now that WordPress Core supports PHP >= 5.6, the PHPMailer library can be updated to the latest version.

The PHPMailer files now reside in a new directory, `wp-includes/PHPMailer`. These files are copied verbatim from the library upstream and will make updating in the future easier. For backwards compatibility, the old files will remain and trigger deprecated file warnings.

The PHPMailer class is also now under the `PHPMailer\PHPMailer\PHPMailer` namespace. The `PHPMailer` class in the global namespace has been aliased for a seamless transition.

This upgrade also clears up a handful of PHP compatibility issues detailed in #49922.

For a full list of changes, see the PHPMailer GitHub: https://github.com/PHPMailer/PHPMailer/compare/v5.2.27...v6.1.6.

Props Synchro, SergeyBiryukov, desrosj, donmhico, ayeshrajans.
Fixes #41750.
Built from https://develop.svn.wordpress.org/trunk@48033


git-svn-id: http://core.svn.wordpress.org/trunk@47800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 15:47:07 +00:00
ianbelanger
232277586f Bundled Themes: Twenty Nineteen long submenu item titles do not wrap. 
Fixes the issue of long submenu item titles that do not wrap by adding a `max-width: 20rem;` and removing `white-space: nowrap;`.

Props kjellr, mukesh27, mohsinrasool, samful.
Fixes #45866.
Built from https://develop.svn.wordpress.org/trunk@48032


git-svn-id: http://core.svn.wordpress.org/trunk@47799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 15:11:08 +00:00
Sergey Biryukov
4cc11cdbdd Filesystem API: Avoid a PHP notice in WP_Filesystem_Direct::owner() and ::group() methods and their WP_Filesystem_SSH2 counterparts. 
Although not officially documented in the PHP manual, `posix_getpwuid()` and `posix_getgrgid()` can return `false` in some circumstances.

Props logig.
Fixes #50373.
Built from https://develop.svn.wordpress.org/trunk@48031


git-svn-id: http://core.svn.wordpress.org/trunk@47798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-12 12:35:09 +00:00
ianbelanger
99c6adfeaa Bundled Themes: Twenty Seventeen CSS issue when using rowspan in tables. 
Fixes CSS issue when using rowspan in tables. This issue does not apply to the Table Block, just tables inserted as custom html.

Props aussi, subrataemfluence, jainnidhi.
Fixes #44004.
Built from https://develop.svn.wordpress.org/trunk@48028


git-svn-id: http://core.svn.wordpress.org/trunk@47796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-11 17:15:08 +00:00
ianbelanger
5bc4b92551 Bundled Themes: Twenty Seventeen add Telegram and Whatsapp support to Social Media Menu. 
Adds Telegram and Whatsapp support and SVG's to Social Media Menu.

Props cpasqualini, audrasjb, laurelfulford, karmatosed, ibdz.
Fixes #43999.
Built from https://develop.svn.wordpress.org/trunk@48027


git-svn-id: http://core.svn.wordpress.org/trunk@47795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-11 15:31:09 +00:00
Sergey Biryukov
4de0d47792 Canonical: Revert [47937] pending unit tests and further review. 
Props needle.
See #12456.
Built from https://develop.svn.wordpress.org/trunk@48026


git-svn-id: http://core.svn.wordpress.org/trunk@47794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-11 10:55:11 +00:00
whyisjake
c075eec24f Editor: Ensure latest comments can only be viewed from public posts. 
Props: poena, xknown. 

Built from https://develop.svn.wordpress.org/trunk@47984


git-svn-id: http://core.svn.wordpress.org/trunk@47752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 19:20:11 +00:00
ianbelanger
9524b335c7 Bundled Themes: Twenty Twenty and Twenty Nineteen version bump. 
We are releasing new versions of Twenty Twenty & Twenty Nineteen today thus we need to bump the version.

Props ianbelanger.
Fixes #50359.
Built from https://develop.svn.wordpress.org/trunk@47952


git-svn-id: http://core.svn.wordpress.org/trunk@47724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:32:06 +00:00
whyisjake
dda0ccdd18 Administration: Add a new filter to extend set-screen-option. 
Props: xknown, SergeyBiryukov.

Built from https://develop.svn.wordpress.org/trunk@47951


git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:24:51 +00:00
whyisjake
ffc4869c9c Themes: Ensure a broken theme name is returned properly. 
Props: sstoqnov.

Built from https://develop.svn.wordpress.org/trunk@47950


git-svn-id: http://core.svn.wordpress.org/trunk@47722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:23:36 +00:00
whyisjake
10e2a50c52 Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters. 
Props: xknow, vortfu.


Built from https://develop.svn.wordpress.org/trunk@47949


git-svn-id: http://core.svn.wordpress.org/trunk@47721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:22:28 +00:00
whyisjake
7e9267567f Editor: Prevent HTML decoding on by setting the proper editor context. 
Props: sstoqnov.

Built from https://develop.svn.wordpress.org/trunk@47948


git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:21:20 +00:00
whyisjake
2ae3b3b801 Embeds: Ensure that the title attribute is set correctly on embeds. 
Props xknown.

Built from https://develop.svn.wordpress.org/trunk@47947


git-svn-id: http://core.svn.wordpress.org/trunk@47719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 17:20:10 +00:00
Sergey Biryukov
1d95eb63a7 Docs: Add missing documentation for the $group parameter of WP_Object_Cache::get_multiple(). 
Synchronize documentation between `wp_cache_get_multiple()`, its compat version, and the class method.

See #20875.
Built from https://develop.svn.wordpress.org/trunk@47944


git-svn-id: http://core.svn.wordpress.org/trunk@47717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 09:57:09 +00:00
TimothyBlynJacobs
941a31318c REST API: Fix updating "multiple" meta keys with non-string values. 
Previously, the REST API would end up deleting each row of metadata and recreating it unnecessarily. This was caused by a type mismatch where the metadata API would always return a string value, and the REST API operated on a typed value.

The REST API now applies the same sanitization and type casting for "multiple" meta keys and "single" meta keys.

Fixes #49339.
Props renathoc.

Built from https://develop.svn.wordpress.org/trunk@47943


git-svn-id: http://core.svn.wordpress.org/trunk@47716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-10 02:22:13 +00:00
desrosj
38352d2c7a Coding Standards: Cleans up some PHPCS issues introduced in [47938]. 
See #20875.
Built from https://develop.svn.wordpress.org/trunk@47942


git-svn-id: http://core.svn.wordpress.org/trunk@47715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 22:42:12 +00:00
ianbelanger
4e61c5fb0f Bundled Themes: Twenty Twenty number of replies not translatable. 
Fixes the issue by removing the single quote from around the `1` in the elseif conditional of the comments template.

Props Parvand, SergeyBiryukov, desrosj, juliobox, Mista-Flo, benjamingosset, audrasjb, opurockey.
Fixes #49058.
Built from https://develop.svn.wordpress.org/trunk@47941


git-svn-id: http://core.svn.wordpress.org/trunk@47714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 20:02:08 +00:00
ianbelanger
32116649cf Bundled Themes: Twenty Twenty HTML in featured image caption is being escaped. 
Fixes the issue by replacing `esc_html` with `wp_kses_post` in the caption in featured images.

Props pierlo, JavierCasares, audrasjb.
Fixes #49833.
Built from https://develop.svn.wordpress.org/trunk@47940


git-svn-id: http://core.svn.wordpress.org/trunk@47713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:52:07 +00:00
whyisjake
ae76b79f85 Cache API: Include the cache-compat file. 
This was missed during the prior commit.

See [47938].


Built from https://develop.svn.wordpress.org/trunk@47939


git-svn-id: http://core.svn.wordpress.org/trunk@47712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:50:09 +00:00
whyisjake
3e2b649351 Cache API: Introduce wp_cache_get_multi(). 
Many caching backend have support for multiple gets in a single request. This brings that support to core, with a compatability fallback that will loop over requests if needed.

Fixes: #20875.
Props: nacin, tollmanz, wonderboymusic, ryan, jeremyfelt, spacedmonkey, boonebgorges, dd32, rmccue, ocean90, jipmoors, johnjamesjacoby, tillkruess, donmhico, davidbaumwald, SergeyBiryukov, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47938


git-svn-id: http://core.svn.wordpress.org/trunk@47711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:47:13 +00:00
whyisjake
c65334d820 Canonical: Ensure a redirect for posts missing postname in a query with an ID. 
If a site is using `/%post_id%/%postname%/` as permalink structure, and is missing the `postname`, the site  won't redirect to the appropriate URL. This change ensure that the redirect happens.

Fixes: #12456.
Props: Frank.Prendergast, dd32, Otto42, hlanggo, wonderboymusic, atimmer, seth17, calvin_ngan, Niresh12495, anbumz, SergeyBiryukov, donmhico.



Built from https://develop.svn.wordpress.org/trunk@47937


git-svn-id: http://core.svn.wordpress.org/trunk@47710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 19:26:12 +00:00
Sergey Biryukov
f5d5b76f6e Docs: Fix typo in WP_Widget::__construct() and ::WP_Widget() DocBlocks. 
Props SUM1.
Fixes #50348.
Built from https://develop.svn.wordpress.org/trunk@47936


git-svn-id: http://core.svn.wordpress.org/trunk@47709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 15:37:10 +00:00
Sergey Biryukov
c227ed2322 Docs: Improve documentation for is_active_sidebar(). 
The function determines whether the sidebar contains widgets, not that it is loaded on the page.

Props SUM1.
Fixes #50347.
Built from https://develop.svn.wordpress.org/trunk@47935


git-svn-id: http://core.svn.wordpress.org/trunk@47708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 15:31:09 +00:00
ianbelanger
c681e37da7 Bundled Themes: Twenty Fifteen bulleted list block appears too far to the left in the editor. 
Fixes the issue by removing unnecessary margin rules for bulleted lists in the editor.

Props kjellr.
Fixes #50029.
Built from https://develop.svn.wordpress.org/trunk@47934


git-svn-id: http://core.svn.wordpress.org/trunk@47707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 14:10:09 +00:00
ianbelanger
644fb1b931 Bundled Themes: Twenty Twenty uses overly specific selector for button background. 
Fixes the issue by removing `:not(.toogle)` from the `button` selector, as it is not needed.

Props flixos90.
Fixes #50271.
Built from https://develop.svn.wordpress.org/trunk@47933


git-svn-id: http://core.svn.wordpress.org/trunk@47706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 13:52:08 +00:00
Sergey Biryukov
bbdfffdaa1 Networks and Sites: Ensure the site ID in wp_insert_site() is still correct after calling clean_blog_cache(). 
By saving `$wpdb->insert_id` to a variable, we make sure the ID does not change if another database insert is performed on the `clean_site_cache` action.

Props trepmal.
Fixes #50324.
Built from https://develop.svn.wordpress.org/trunk@47932


git-svn-id: http://core.svn.wordpress.org/trunk@47705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 12:41:09 +00:00
Sergey Biryukov
40584118d9 Docs: Document that get_tags() returns a WP_Error object if any of the specified taxonomies do not exist. 
Props coffee2code.
Fixes #50344.
Built from https://develop.svn.wordpress.org/trunk@47930


git-svn-id: http://core.svn.wordpress.org/trunk@47703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-06-09 11:14:12 +00:00