Andrew Ozz
afdb25bd56
TinyMCE wpView sandbox iframes:
...
- Make them transparent.
- Don't load tons of unrelated styles that can break them. This could result in minimal styling mismatch to the front-end, but keeps the views working well and looking good.
Props avryl, fixes #29048 .
Built from https://develop.svn.wordpress.org/trunk@29543
git-svn-id: http://core.svn.wordpress.org/trunk@29319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 21:53:15 +00:00
Andrew Ozz
228c77ca2f
TinyMCE: fix the keycode check when removing the Edit/Delete toolbar from images on keydown, see #28705
...
Built from https://develop.svn.wordpress.org/trunk@29541
git-svn-id: http://core.svn.wordpress.org/trunk@29317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 19:14:16 +00:00
Andrew Ozz
28bcbcb972
Fix typo in the 'wpeditimage' plugin, see #28705
...
Built from https://develop.svn.wordpress.org/trunk@29540
git-svn-id: http://core.svn.wordpress.org/trunk@29316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 18:43:20 +00:00
Andrew Ozz
542e56ac3f
TinyMCE wpView: remove CSS transition for the fake caret. Can have very annoying side effect: the whole page shifts a bit. See #28595 .
...
Built from https://develop.svn.wordpress.org/trunk@29536
git-svn-id: http://core.svn.wordpress.org/trunk@29312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 03:57:17 +00:00
Andrew Ozz
74f6ddc816
TinyMCE wpView: ignore more keys when the caret is around a view. Part props avryl, fixes #29115 .
...
Built from https://develop.svn.wordpress.org/trunk@29535
git-svn-id: http://core.svn.wordpress.org/trunk@29311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-19 03:27:17 +00:00
Andrew Ozz
c0fef55a47
DFW: revert applying the Visual editor body color and background-color for now. Set the color to #333 and the background to transparent. Fixes #28330 .
...
Built from https://develop.svn.wordpress.org/trunk@29533
git-svn-id: http://core.svn.wordpress.org/trunk@29309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 18:23:16 +00:00
Dominik Schilling
a28bc71819
Media Modal: Restore to the previous filter and search error message.
...
fixes #28963 .
Built from https://develop.svn.wordpress.org/trunk@29532
git-svn-id: http://core.svn.wordpress.org/trunk@29308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 16:28:19 +00:00
Scott Taylor
a0f2fe6599
After [29507], move unreachable code from _requery()
to Query.get()
.
...
Built from https://develop.svn.wordpress.org/trunk@29531
git-svn-id: http://core.svn.wordpress.org/trunk@29307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 04:08:15 +00:00
Scott Taylor
36e4e9917b
wpviews: whenever a view is updated or inserted, don't refresh ALL of the views.
...
Props avryl.
Fixes #28788 .
Built from https://develop.svn.wordpress.org/trunk@29530
git-svn-id: http://core.svn.wordpress.org/trunk@29306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 03:59:17 +00:00
Scott Taylor
29a73daa74
Media Grid: Don't show attachment details in the "sidebar" for errors.
...
Props ocean90.
Fixes #29037 .
Built from https://develop.svn.wordpress.org/trunk@29527
git-svn-id: http://core.svn.wordpress.org/trunk@29303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:26:16 +00:00
Scott Taylor
6d342e812f
Media Grid: improve the design of upload errors.
...
Props celloexpressions.
See #29141 .
Built from https://develop.svn.wordpress.org/trunk@29526
git-svn-id: http://core.svn.wordpress.org/trunk@29302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:22:17 +00:00
Scott Taylor
5aee14e9a1
Media Grid: on page load with ?item=
in the URL, if the model is not in the library: fetch it. Defer the triggering of edit:attachment
until the model has been fetched.
...
Fixes #29052 .
Built from https://develop.svn.wordpress.org/trunk@29525
git-svn-id: http://core.svn.wordpress.org/trunk@29301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-18 02:13:16 +00:00
Andrew Ozz
aff2892646
TinyMCE: fix the edit image and wpview buttons on touch screen PCs, fixes #29235 .
...
Built from https://develop.svn.wordpress.org/trunk@29521
git-svn-id: http://core.svn.wordpress.org/trunk@29297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 20:11:15 +00:00
Dominik Schilling
4dc4277a60
Media Grid: Improve position of fixed toolbar at small-screen sizes.
...
see #28842 .
Built from https://develop.svn.wordpress.org/trunk@29517
git-svn-id: http://core.svn.wordpress.org/trunk@29293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 14:03:14 +00:00
Andrew Ozz
ac463e5c71
TinyMCE wpView: add small delay before inserting wpview sandbox iframes into the DOM. Fixes a problem in Firefox that may prevent rendering them. Fixes #29241 .
...
Built from https://develop.svn.wordpress.org/trunk@29513
git-svn-id: http://core.svn.wordpress.org/trunk@29290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 03:43:18 +00:00
Scott Taylor
4d20246173
Media Grid: $.when
expects a splat. Disambiguation: change cache
to refresh
as the arg name for _requery()
.
...
See [29490], #29145 .
Built from https://develop.svn.wordpress.org/trunk@29507
git-svn-id: http://core.svn.wordpress.org/trunk@29284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 19:00:16 +00:00
Andrew Ozz
81815c4d03
Some pre-commit cleanup of media-grid.js and media-views.js
...
Built from https://develop.svn.wordpress.org/trunk@29494
git-svn-id: http://core.svn.wordpress.org/trunk@29272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 01:13:16 +00:00
Scott Taylor
b0c782bf08
Media Grid, support MEDIA_TRASH
: add AYS to bulk actions.
...
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29492
git-svn-id: http://core.svn.wordpress.org/trunk@29270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 19:08:14 +00:00
Scott Taylor
df4cc86671
Media Grid, support MEDIA_TRASH
:
...
* Only use the special `trashAttachment` logic when in `edit-metadata` mode.
* Don't support the `trash` filter in the Add Media modal for now.
* Properly toggle trash/untrash logic in the Attachment Details sidebar
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29491
git-svn-id: http://core.svn.wordpress.org/trunk@29269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:51:19 +00:00
Scott Taylor
571111022e
Media Grid, support MEDIA_TRASH
:
...
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.
Props koop for the knowledge sharing and thought partnership.
See #29145 .
Built from https://develop.svn.wordpress.org/trunk@29490
git-svn-id: http://core.svn.wordpress.org/trunk@29268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 18:31:19 +00:00
Helen Hou-Sandí
5fc736f49e
Media grid bulk selection styling:
...
* Fade content within each attachment item so that focus styling is still clear.
* Less jarring toolbar pinning.
* Tighten up the fade in/out transition.
see #28842 .
Built from https://develop.svn.wordpress.org/trunk@29489
git-svn-id: http://core.svn.wordpress.org/trunk@29267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 07:18:15 +00:00
Scott Taylor
b5922001b4
Remove debug line from [29484].
...
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29485
git-svn-id: http://core.svn.wordpress.org/trunk@29263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-14 00:37:15 +00:00
Scott Taylor
9c08ad236a
Media Grid: add Bulk Selection mode for deleting attachments.
...
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.
See #28842 .
Built from https://develop.svn.wordpress.org/trunk@29484
git-svn-id: http://core.svn.wordpress.org/trunk@29262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 22:45:15 +00:00
Scott Taylor
99a10a450e
Media Grid: treat Edit Image like a mode
, which it is, instead of a state
, which it is not.
...
Fixes #29206 .
Built from https://develop.svn.wordpress.org/trunk@29483
git-svn-id: http://core.svn.wordpress.org/trunk@29261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 19:26:16 +00:00
Scott Taylor
ca03604712
In the Edit Attachment frame, when in Edit Image mode, add a key event for Escape. There are conflicting keydown
handlers that don't propagate the event to the modal properly.
...
Fixes #29121 .
Built from https://develop.svn.wordpress.org/trunk@29481
git-svn-id: http://core.svn.wordpress.org/trunk@29259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 18:15:18 +00:00
Drew Jaynes
d33c807723
Fix some documentation typos in various core files.
...
Props vlajos.
Fixes #29199 .
Built from https://develop.svn.wordpress.org/trunk@29479
git-svn-id: http://core.svn.wordpress.org/trunk@29257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 03:56:17 +00:00
Andrew Ozz
8f2b4fbe9e
Fix the wp-settings-*
cookies used in getUserSetting()/setUserSetting(). They should be set without COOKIE_DOMAIN
to work properly for sub-domains. Fixes #29095 .
...
Built from https://develop.svn.wordpress.org/trunk@29478
git-svn-id: http://core.svn.wordpress.org/trunk@29256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 02:47:16 +00:00
Andrew Ozz
ce14155edf
Media modal: make sure the Close button is focused after attempting to close the onscreen keyboard on touch devices. Props celloexpressions, fixes #29166 .
...
Built from https://develop.svn.wordpress.org/trunk@29473
git-svn-id: http://core.svn.wordpress.org/trunk@29251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 21:58:15 +00:00
Andrew Ozz
2f4bd918b2
TinyMCE: fix the 'editimage' plugin for touch devices. Better attempt to hide the onscreen keyboard when the media modal opens and TinyMCE is in focus. See #28595 , #29166
...
Built from https://develop.svn.wordpress.org/trunk@29471
git-svn-id: http://core.svn.wordpress.org/trunk@29249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-12 04:27:18 +00:00
Andrew Ozz
e75033f21b
TinyMCE: update wpview and editimage plugins for 4.1.3. Add show/hide of the Edit and Delete buttons on views and images on 'touchend'. See #28595 , #29166
...
Built from https://develop.svn.wordpress.org/trunk@29463
git-svn-id: http://core.svn.wordpress.org/trunk@29241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-10 04:22:15 +00:00
Andrew Ozz
efd52cb860
TinyMCE: update to 4.1.3, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt , fixes #29166
...
Built from https://develop.svn.wordpress.org/trunk@29458
git-svn-id: http://core.svn.wordpress.org/trunk@29236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 20:56:15 +00:00
Scott Taylor
1c93f05e2a
Upgrade MediaElement to 2.15.0:
...
* It is required to set `height` on the parent `.wp-video` wrapper for video
* Fixes the play button hover problem in Chrome
* Includes my pull request: https://github.com/johndyer/mediaelement/pull/1273
All changes:
https://github.com/johndyer/mediaelement/compare/2.14.2...master
See #29110 .
Built from https://develop.svn.wordpress.org/trunk@29457
git-svn-id: http://core.svn.wordpress.org/trunk@29235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 20:44:17 +00:00
Scott Taylor
28c22db07d
Video:
...
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal
See #29110 .
Built from https://develop.svn.wordpress.org/trunk@29456
git-svn-id: http://core.svn.wordpress.org/trunk@29234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 19:39:15 +00:00
Andrew Ozz
d11bb9bc50
Media at small screens:
...
- Show the image details/settings as an overlay.
- Better styling for the frame drop-down.
- Remove the multi-select by default on the Insert frame.
See #27423
Built from https://develop.svn.wordpress.org/trunk@29452
git-svn-id: http://core.svn.wordpress.org/trunk@29230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 05:09:16 +00:00
Scott Taylor
5cab03ab29
Add some docs to Customizer JS.
...
Props ericlewis.
See #29157 .
Built from https://develop.svn.wordpress.org/trunk@29451
git-svn-id: http://core.svn.wordpress.org/trunk@29229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 23:31:15 +00:00
Scott Taylor
c6ebc35a00
Add some docs to Customizer JS.
...
Props ericlewis.
See #29157 .
Built from https://develop.svn.wordpress.org/trunk@29450
git-svn-id: http://core.svn.wordpress.org/trunk@29228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 22:10:15 +00:00
Andrew Ozz
13aee01e2b
TinyMCE: don't access the parent window when opening the (iframe based) Help/Keyboard Shortcuts modal. Fixes #20094 .
...
Built from https://develop.svn.wordpress.org/trunk@29449
git-svn-id: http://core.svn.wordpress.org/trunk@29227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 21:18:16 +00:00
Andrew Ozz
b8198ecf64
Media: improve the media modal at small screen sizes and make it usable on phones, first run. Part-props gcorne, see #27423 .
...
Built from https://develop.svn.wordpress.org/trunk@29446
git-svn-id: http://core.svn.wordpress.org/trunk@29224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-08 03:46:17 +00:00
Scott Taylor
ed5d17ab77
Media Grid: remove Router code that doesn't actually ever run.
...
See #29121 .
Built from https://develop.svn.wordpress.org/trunk@29444
git-svn-id: http://core.svn.wordpress.org/trunk@29222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 22:37:16 +00:00
Scott Taylor
1217efe905
Media Grid: remove Router code that doesn't actually ever run.
...
See #29121 .
Built from https://develop.svn.wordpress.org/trunk@29443
git-svn-id: http://core.svn.wordpress.org/trunk@29221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 22:33:15 +00:00
Scott Taylor
34e3377d42
JSHint after [29437].
...
Built from https://develop.svn.wordpress.org/trunk@29439
git-svn-id: http://core.svn.wordpress.org/trunk@29217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:21:16 +00:00
Scott Taylor
8c96874742
Media Grid:
...
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29438
git-svn-id: http://core.svn.wordpress.org/trunk@29216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:01:15 +00:00
Scott Taylor
ccd0499d96
Media Grid: use a media.view.Label
instance in the toolbar for the screen reader text for Search.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29437
git-svn-id: http://core.svn.wordpress.org/trunk@29215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:54:15 +00:00
Helen Hou-Sandí
485229bc64
Revert styling changes to the Attachment Details modal from [29289]. fixes #28844 .
...
Built from https://develop.svn.wordpress.org/trunk@29436
git-svn-id: http://core.svn.wordpress.org/trunk@29214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:32:16 +00:00
Scott Taylor
8593f7b5e9
Media Grid: add screen reader text in a subview on the toolbar, a media.view.Label
instance before media.view.DateFilter
.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29435
git-svn-id: http://core.svn.wordpress.org/trunk@29213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:25:16 +00:00
Scott Taylor
3f17e7040e
Create a new Backbone view, media.view.Label
, which can be used as a subview in things like toolbars, which need screen reader text.
...
Make an initial instance of it for the label for Bulk Actions in Media Grid.
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29434
git-svn-id: http://core.svn.wordpress.org/trunk@29212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 20:09:17 +00:00
Scott Taylor
c5dff42d51
Revert [29428] to avoid errors with Add Media for now.
...
See #29026 .
Built from https://develop.svn.wordpress.org/trunk@29432
git-svn-id: http://core.svn.wordpress.org/trunk@29210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 19:40:15 +00:00
Scott Taylor
afb0b3e4ef
Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
...
Props afercia.
Fixes #29026 .
Built from https://develop.svn.wordpress.org/trunk@29428
git-svn-id: http://core.svn.wordpress.org/trunk@29206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:20:16 +00:00
Scott Taylor
f0f4174ed8
Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322].
...
See #28819 .
Built from https://develop.svn.wordpress.org/trunk@29427
git-svn-id: http://core.svn.wordpress.org/trunk@29205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 05:03:17 +00:00
Scott Taylor
8ed123c97f
In media.view.AttachmentFilters.All
, make uploaded
conditional upon media.view.settings.post.id
and include a new filter: unattached
.
...
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead.
Props ocean90, wonderboymusic.
Fixes #29065 .
Built from https://develop.svn.wordpress.org/trunk@29426
git-svn-id: http://core.svn.wordpress.org/trunk@29204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 04:44:17 +00:00