Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Dion Hulse
1d342fcdc6
Feeds: Replace the RSS2 lastBuildDate
date field with the r
date specifier.
...
See #39141 .
Built from https://develop.svn.wordpress.org/trunk@39614
git-svn-id: http://core.svn.wordpress.org/trunk@39554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 06:42:40 +00:00
Dion Hulse
f794939ed3
Feeds: Do not translate the lastBuildDate
field in RSS feeds.
...
Props stevenkword, dd32.
Fixes #39141
Built from https://develop.svn.wordpress.org/trunk@39613
git-svn-id: http://core.svn.wordpress.org/trunk@39553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-16 06:39:41 +00:00
Rachel Baker
2f263fce99
Feeds: Always return a valid timestamp for the Last-Modified header of comment or post feeds.
...
Fixes bug where an invalid Last-Modified value would be returned in feed requests for sites that had 0 items to return. Comment or post feeds will now return the current timestamp as the Last-Modified header value. Example: a request for the comments feed for a site without any comments.
Replaced use of the local static variable `$cache_lastcommentmodified` to store the modified date in `get_lastcommentmodified()` with the Object Cache API. The `get_lastcommentmodified()` function returns early if there is a cached value and returns `false` if there where no comments found. Introduced `_clear_modified_cache_on_transition_comment_status()` to flush the `lastcommentmodified` cache key when a comment enters or leaves approval status. In `get_lastpostmodified()` return early if there is a cached value and return `false` if there are no posts found.
Props swissspidy, rachelbaker, dllh, leobaiano.
Fixes #38027 .
Built from https://develop.svn.wordpress.org/trunk@38925
git-svn-id: http://core.svn.wordpress.org/trunk@38868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-25 20:48:29 +00:00
Drew Jaynes
9cb5247392
Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.
...
See #36913 .
Built from https://develop.svn.wordpress.org/trunk@37518
git-svn-id: http://core.svn.wordpress.org/trunk@37486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:50:28 +00:00
Scott Taylor
5e9ed67b82
Feeds: <comments>
is optional in RSS2, so don't include it when comments aren't present or open. Same for <wfw:commentRss>
and <slash:comments>
...
Adds unit test.
Props swissspidy, realloc, hakre, sivel.
Fixes #9134 .
Built from https://develop.svn.wordpress.org/trunk@35506
git-svn-id: http://core.svn.wordpress.org/trunk@35470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 17:47:25 +00:00
Konstantin Obenland
c69e96422b
Themes: Improve document title output.
...
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548 .
Deprecates `wp_title()`.
Fixes #31078 .
Built from https://develop.svn.wordpress.org/trunk@35294
git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:21:25 +00:00
Konstantin Obenland
3271513442
Feeds: Revert [32765] because of objections raised in #4575 .
...
Built from https://develop.svn.wordpress.org/trunk@33281
git-svn-id: http://core.svn.wordpress.org/trunk@33253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 19:58:24 +00:00
Aaron Jorbin
cbb6f91a29
Improve lastBuildDate timestamp in rss feeds
...
RSS feed timestamps should reflect the actual timestamps for those RSS feeds rather than the generic timestamp for all posts and all comments.
Props stevenkword.
Fixes #4575 .
Built from https://develop.svn.wordpress.org/trunk@32765
git-svn-id: http://core.svn.wordpress.org/trunk@32736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:37:24 +00:00
Scott Taylor
3ec1d3bf9d
Serve RSS feeds with the proper mime-type: application/rss+xml
. The reason for hacking around browsers by using text/xml
appears to no longer be relevant.
...
Props @chriscct7.
Reverts [11334] and [11358]
Fixes #15110 .
Built from https://develop.svn.wordpress.org/trunk@32468
git-svn-id: http://core.svn.wordpress.org/trunk@32438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 06:39:24 +00:00
John Blackbourn
bdd00b3902
Improve various hook and filter docs so they are correctly parsed for the code reference.
...
Fixes #30558
Props DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30754
git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:32:24 +00:00
Drew Jaynes
de809a5a86
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`
Props rarst for the initial patch.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30538
git-svn-id: http://core.svn.wordpress.org/trunk@30527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:19:23 +00:00
Sergey Biryukov
c321e40016
Introduce 'rss_tag_pre' action, which fires between the xml and rss tags in a feed.
...
props solarissmoke, wonderboymusic, DrewAPicture.
fixes #19017 .
Built from https://develop.svn.wordpress.org/trunk@29014
git-svn-id: http://core.svn.wordpress.org/trunk@28802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-07 10:18:15 +00:00
Drew Jaynes
a48dc6b7ed
Inline documentation for hooks in wp-includes/feed-rss2.php.
...
Props dustyf for the initial patch.
See #25229 .
Built from https://develop.svn.wordpress.org/trunk@25530
git-svn-id: http://core.svn.wordpress.org/trunk@25450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 22:27:09 +00:00
Scott Taylor
d39c01d30e
Consistently wrap author
and excerpt
nodes with CDATA
in feeds.
...
Fixes #18056 .
Built from https://develop.svn.wordpress.org/trunk@25315
git-svn-id: http://core.svn.wordpress.org/trunk@25277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 16:55:09 +00:00
markjaquith
87125fe8b5
Use the_content_feed() when looking for zero-length post content for RSS2 feeds. Now you can have blank posts with content generated by the_content filters. props SergeyBiryukov. fixes #15604
...
git-svn-id: http://core.svn.wordpress.org/trunk@21235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 03:33:01 +00:00
nacin
bdd70470e2
Use the site's locale for the feed language. Provides the same result as language_attributes(). Removes the rss_language option. fixes #13440 . see #5517 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-29 19:56:33 +00:00
nacin
16b1f727af
Specify feed type in the_category_rss() call. props benward, fixes #14451 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-26 20:15:18 +00:00
westi
11f0a387cd
Some more url escaping in feeds. See #13555 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 17:47:29 +00:00
westi
8b4a635d8b
Move the escaping into get_guid() so we don't have to repeat ourselves. See #13555 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 17:27:18 +00:00
westi
b54183ae4c
Escape the guid urls when placing them in feeds and other xml locations. See #13555 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 17:01:21 +00:00
westi
d8490aeea2
Add the generator element in feeds through the {rss2|atom|rdf|rss|opml}_head hooks. Fixes #6947 props sivel.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-13 16:45:16 +00:00
ryan
5224680c4d
Deprecates the_content_rss(). Add the_content_feed() and get_the_content_feed(). Convert places that called the_content_rss() with an excerpt length to the_excerpt_rss(). Remove the rss_excerpt_length option. Use the_content_feed() where the_content() was previously used in feeds. Props Viper007Bond.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-28 14:36:48 +00:00
ryan
70b537d3f2
Force correct feed type for wfw:CommentRss element. Props peaceablewhale. fixes #10016
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-21 16:45:41 +00:00
ryan
a5e73d3b9b
Fix feed autodiscovery. Props peaceablewhale. fixes #9810
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-16 05:15:21 +00:00
westi
83f0f5f9ef
Add slash:comments extension to RSS2 feed to give comment counts for posts. Fixes #4023 props peaceablewhale.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-11 19:42:47 +00:00
ryan
18e6d80bc1
Use lastBuildDate. Props peaceablewhale. fixes #9566
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 20:38:47 +00:00
ryan
191762762a
Remove unneeded spaces. Props Denis-de-Bernardy. fixes #108
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@10952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-16 18:47:41 +00:00
azaozz
3949fb7e90
Add support for automatic feed links in themes, props Viper007Bond, see #8878
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@10377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-19 05:04:58 +00:00
westi
ef8d0a6e30
Add syndication frequency recommendations to rss2 feeds. See #3513 props _ck_.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-11 20:50:41 +00:00
westi
77c0f608c8
Better self links for feeds. Fixes #5238 props andy.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@7244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-11 18:18:22 +00:00
westi
bce8c48d72
Deprecate comments_rss and create_user.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-28 21:47:54 +00:00
ryan
09f2286a41
Some file level phpdoc from darkdragon. fixes #5527
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-25 20:48:01 +00:00
westi
c75ec2b48a
Add atom:self link to rss2 feeds per RSS Best Practices Profile. Fixes #5205 props lexhair and rubys.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-20 10:35:44 +00:00
westi
e9cfb43133
Centralise generator generation, move theme generator generation to wp-head hook. Fixes #5085 , #4803 . props docwhat, Viper007Bond.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-06 06:55:24 +00:00
ryan
9b395107f4
Deprecate permalink_single_rss(). Add the_permalink_rss() with accompanying filter. Props joostdevalk and Otto42. fixes #4654
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@5910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-21 18:27:45 +00:00
rob1n
9ce729e656
Content-Type, not Content-type, as headers are case sensitive. Props foolswisdom and Nazgul. fixes #3545
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@5640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-02 05:21:18 +00:00
rob1n
5b446f7cf7
Show more relevant titles (current category, date, etc.) in feed titles. fixes #1790
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@5132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-29 01:29:09 +00:00
ryan
dbedd143e4
Relocate feed templates to wp-includes. fixes #3846
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@4927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-23 02:50:05 +00:00