Commit Graph

5430 Commits

Author SHA1 Message Date
Aaron Jorbin
8494e6294a Add test image for test_exif_keywords test
[34374] added a test that relies on a new test image. This test image wasn't included in the commit.  This fixes the broken Tests_Image_Meta::test_exif_keywords test.

Props swissspidy, SteveHoneyNZ.
Fixes #33772.


Built from https://develop.svn.wordpress.org/trunk@34448


git-svn-id: http://core.svn.wordpress.org/trunk@34412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 21:43:25 +00:00
John Blackbourn
ca1c40abbc Implement a test for capabilities for a custom post type that uses capability_type => page.
See #17253

Built from https://develop.svn.wordpress.org/trunk@34447


git-svn-id: http://core.svn.wordpress.org/trunk@34411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 21:01:24 +00:00
Scott Taylor
939d9b7395 Remove some unused globals and/or their docs.
See ##33491.

Built from https://develop.svn.wordpress.org/trunk@34446


git-svn-id: http://core.svn.wordpress.org/trunk@34410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:27:25 +00:00
Scott Taylor
d866a40d09 After [34444​], wp_get_shortlink() can call get_queried_object_id() instead of using the $wp_query global.
See #14900.

Built from https://develop.svn.wordpress.org/trunk@34445


git-svn-id: http://core.svn.wordpress.org/trunk@34409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:09:23 +00:00
Scott Taylor
7cbd096c2b Links: use consistent late-escaping in some HTML link-generation functions:
* `post_comments_feed_link()`
* `edit_post_link()`
* `edit_comment_link()`
* `edit_bookmark_link()`
* `rel_canonical()`

Props niallkennedy, wonderboymusic.
Fixes #14900.

Built from https://develop.svn.wordpress.org/trunk@34444


git-svn-id: http://core.svn.wordpress.org/trunk@34408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:06:24 +00:00
Scott Taylor
4cdd0b1688 PINGBACKS: After [34442], switch to is_singular() to check attachments and pages as well.
See #20226.

Built from https://develop.svn.wordpress.org/trunk@34443


git-svn-id: http://core.svn.wordpress.org/trunk@34407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 19:10:29 +00:00
Scott Taylor
3bbd53c717 PINGBACKS: rather than sending the X-Pingback HTTP header on every single request for fun, perhaps only send it on single posts with pings open.
See #20226.

Built from https://develop.svn.wordpress.org/trunk@34442


git-svn-id: http://core.svn.wordpress.org/trunk@34406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 18:47:25 +00:00
Drew Jaynes
32358bbcdd Docs: Actually, the subpackage for Walker_Page should be Template.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34441


git-svn-id: http://core.svn.wordpress.org/trunk@34405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 15:09:24 +00:00
Drew Jaynes
07cb271a45 Docs: Add a file header to wp-includes/widgets/class-wp-widget-text.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Text`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34440


git-svn-id: http://core.svn.wordpress.org/trunk@34404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 15:04:26 +00:00
Drew Jaynes
12196adb29 Docs: Add a file header to wp-includes/widgets/class-wp-widget-tag-cloud.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Tag_Cloud`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34439


git-svn-id: http://core.svn.wordpress.org/trunk@34403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 15:02:26 +00:00
Drew Jaynes
32118a94e5 Docs: Add a file header to wp-includes/widgets/class-wp-widget-search.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Search`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34438


git-svn-id: http://core.svn.wordpress.org/trunk@34402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 15:01:25 +00:00
Drew Jaynes
5cd5252964 Docs: Add a file header to wp-includes/widgets/class-wp-widget-rss.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_RSS`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34437


git-svn-id: http://core.svn.wordpress.org/trunk@34401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:57:26 +00:00
Drew Jaynes
0608fc8dea Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-posts.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Posts`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34436


git-svn-id: http://core.svn.wordpress.org/trunk@34400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:54:25 +00:00
Drew Jaynes
c9ae3bf3e3 Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-comments.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Comments`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34435


git-svn-id: http://core.svn.wordpress.org/trunk@34399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:51:25 +00:00
Drew Jaynes
111144e3fe Docs: Add a file header to wp-includes/widgets/class-wp-widget-pages.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Pages`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34434


git-svn-id: http://core.svn.wordpress.org/trunk@34398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:49:24 +00:00
Drew Jaynes
42c2543175 Docs: Add a file header to wp-includes/widgets/class-wp-widget-meta.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Meta`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34433


git-svn-id: http://core.svn.wordpress.org/trunk@34397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:48:24 +00:00
Drew Jaynes
305ac5d661 Docs: Add a file header to wp-includes/widgets/class-wp-widget-links.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Links`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34432


git-svn-id: http://core.svn.wordpress.org/trunk@34396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:47:25 +00:00
Drew Jaynes
d259fba59f Docs: Clarify the class DocBlock summary for WP_Widget_Categories.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34431


git-svn-id: http://core.svn.wordpress.org/trunk@34395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:45:25 +00:00
Drew Jaynes
06ab88c2e0 Docs: Add a file header to wp-includes/widgets/class-wp-widget-calendar.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Calendar`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34430


git-svn-id: http://core.svn.wordpress.org/trunk@34394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:44:24 +00:00
Drew Jaynes
02084878f0 Docs: Add a missing file header to wp-includes/widgets/class-wp-widget-archives.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Archives`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34429


git-svn-id: http://core.svn.wordpress.org/trunk@34393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:43:24 +00:00
Drew Jaynes
c829d1a9b0 Docs: Clarify the file header summary for wp-includes/widgets/class-wp-nav-menu-widget.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Nav_Menu_Widget`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34428


git-svn-id: http://core.svn.wordpress.org/trunk@34392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:41:25 +00:00
Drew Jaynes
fc3ec39515 Docs: Clarify the file header summary for wp-admin/includes/template-functions.php, introduced in [34241].
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34427


git-svn-id: http://core.svn.wordpress.org/trunk@34391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:37:25 +00:00
Drew Jaynes
b168337aab Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241].
Also adds a missing class DocBlock to `WP_Internal_Pointers`. See [19388].

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34426


git-svn-id: http://core.svn.wordpress.org/trunk@34390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:35:25 +00:00
Drew Jaynes
2a37e00b92 Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241].
Also clarifies the class DocBlock summary for `Walker_Category_Checklist`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34425


git-svn-id: http://core.svn.wordpress.org/trunk@34389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:33:48 +00:00
Sergey Biryukov
8db1c75a7e Remove extra HTML from translatable strings in WP_Comments_List_Table::get_views().
Add a context and translator comments.

Props Tmeister for initial patch.
Fixes #31859.
Built from https://develop.svn.wordpress.org/trunk@34424


git-svn-id: http://core.svn.wordpress.org/trunk@34388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:33:25 +00:00
Drew Jaynes
c7022a334d Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223].
Also clarifies the class DocBlock summary and tags for `WP_Post_Comments_List_Table`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34423


git-svn-id: http://core.svn.wordpress.org/trunk@34387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:31:24 +00:00
Drew Jaynes
d7624168cd Docs: Clarify the class DocBlock summary for WP_Screen.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34422


git-svn-id: http://core.svn.wordpress.org/trunk@34386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:28:24 +00:00
Drew Jaynes
ee97475edb Docs: Add a file header to wp-admin/includes/nav-menus.php.
See [34168]. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34421


git-svn-id: http://core.svn.wordpress.org/trunk@34385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:27:24 +00:00
Drew Jaynes
6e350ff16e Docs: Clarify the file header summary and version for wp-includes/category-template.php.
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34420


git-svn-id: http://core.svn.wordpress.org/trunk@34384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:23:24 +00:00
Drew Jaynes
99420b41b5 Docs: Clarify the file header summary and subpackage for wp-includes/category-functions.php, introduced in [34110].
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34419


git-svn-id: http://core.svn.wordpress.org/trunk@34383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:21:23 +00:00
Drew Jaynes
d5c824beb7 Docs: Clarify the file header for wp-includes/category.php.
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34418


git-svn-id: http://core.svn.wordpress.org/trunk@34382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:20:24 +00:00
Drew Jaynes
653702c408 Docs: Clarify the file header for wp-includes/class-walker-category-dropdown.php, introduced in [34110].
Also clarifies the class DocBlock and tags for `Walker_CategoryDropdown`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34417


git-svn-id: http://core.svn.wordpress.org/trunk@34381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:03:25 +00:00
Drew Jaynes
f6b1952e9a Docs: Clarify the file header summary for wp-includes/class-walker-category.php, introduced in [34110].
Also clarifies the class DocBlock and tags for `Walker_Category`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34416


git-svn-id: http://core.svn.wordpress.org/trunk@34380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:01:25 +00:00
Drew Jaynes
2828e6cc06 Docs: Clarify the file header subpackage for wp-includes/class-walker-page-dropdown.php, introduced in [34109].
Also clarifies the class DocBlock summary and tags for `Walker_PageDropdown`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34415


git-svn-id: http://core.svn.wordpress.org/trunk@34379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:58:24 +00:00
Drew Jaynes
160ae95982 Docs: Clarify the file header summary for wp-includes/class-walker-page.php, introduced in [34109].
Also clarifies the class DocBlock summary for `Walker_Page`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34414


git-svn-id: http://core.svn.wordpress.org/trunk@34378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:54:24 +00:00
Drew Jaynes
58376954c2 Docs: The Widgets subpackage is plural.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34413


git-svn-id: http://core.svn.wordpress.org/trunk@34377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:48:25 +00:00
Drew Jaynes
4ddb22bd09 Docs: The Users subpackage is plural.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34412


git-svn-id: http://core.svn.wordpress.org/trunk@34376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:46:25 +00:00
Drew Jaynes
35977a06e7 Docs: The Comments subpackage is plural.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34411


git-svn-id: http://core.svn.wordpress.org/trunk@34375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:45:26 +00:00
Drew Jaynes
5f6cdc2c3b Docs: The Comment API is singular.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34410


git-svn-id: http://core.svn.wordpress.org/trunk@34374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:44:25 +00:00
Drew Jaynes
8df8fb6046 Docs: The Comment API is singular.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34409


git-svn-id: http://core.svn.wordpress.org/trunk@34373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:43:25 +00:00
Drew Jaynes
f980e7b9bb Docs: Clarify the file header summary for wp-includes/default-widgets.php, the top-level file for bringing in the core widget classes.
Also adds inline DocBlocks for the widget classes now brought in via `require_once()` as of [33843].

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34408


git-svn-id: http://core.svn.wordpress.org/trunk@34372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:36:25 +00:00
Drew Jaynes
df81151f24 Docs: Clarify the file header summary for wp-includes/meta.php, the top-level file for the core Meta API.
Also adds inline DocBlocks for files broken out in #33413 and now brought in via `require_once()`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34407


git-svn-id: http://core.svn.wordpress.org/trunk@34371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:30:24 +00:00
Drew Jaynes
c0f2844618 Docs: Clarify the file header summary for wp-includes/meta-functions.php, introduced in [33761].
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34406


git-svn-id: http://core.svn.wordpress.org/trunk@34370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:27:24 +00:00
Drew Jaynes
0d1dcaa832 Docs: Add a file header to wp-includes/class-wp-meta-query.php, introduced in [33761].
Also clarifies the class DocBlock summary for `WP_Meta_Query`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34405


git-svn-id: http://core.svn.wordpress.org/trunk@34369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:26:23 +00:00
Drew Jaynes
24180ac754 Docs: Clarify the file header summary for wp-includes/taxonomy.php, the top-level file for the core Taxonomy API.
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34404


git-svn-id: http://core.svn.wordpress.org/trunk@34368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:23:25 +00:00
Drew Jaynes
4bcbeb129e Docs: Clarify the file header summary for wp-includes/taxonomy-functions.php, introduced in [33760].
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34403


git-svn-id: http://core.svn.wordpress.org/trunk@34367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:20:27 +00:00
Drew Jaynes
bbe7044030 Docs: Add a file header to wp-includes/class-wp-tax-query.php, introduced in [33760].
Also clarifies the class DocBlock summary and description for `WP_Tax_Query`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34402


git-svn-id: http://core.svn.wordpress.org/trunk@34366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:16:30 +00:00
Drew Jaynes
6069a4b2f6 Docs: Clarify the file header summary for wp-includes/post.php, the top-level file for the Post API.
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34401


git-svn-id: http://core.svn.wordpress.org/trunk@34365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:13:26 +00:00
Drew Jaynes
fc7fa6d2d9 Docs: Clarify the file header summary for wp-includes/post-functions.php, introduced in [33759].
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34400


git-svn-id: http://core.svn.wordpress.org/trunk@34364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:12:24 +00:00
Drew Jaynes
ac975e2b07 Docs: Add a file header to wp-includes/class-wp-post.php, introduced in [33759].
Also clarifies the class DocBlock for `WP_Post`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34399


git-svn-id: http://core.svn.wordpress.org/trunk@34363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:10:24 +00:00
Drew Jaynes
b0749a1a06 Docs: Clarify the file header summary for wp-includes/capabilities.php, which was broken up into multiple files in [33752].
Also adds inline DocBlocks for files now brought in via `require_once()` from this file.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34398


git-svn-id: http://core.svn.wordpress.org/trunk@34362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:06:25 +00:00
Drew Jaynes
51b778fb03 Docs: The User API is singular.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34397


git-svn-id: http://core.svn.wordpress.org/trunk@34361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:03:24 +00:00
Drew Jaynes
3f48878c61 Docs: Clarify the file header summary for wp-includes/capabilities-functions.php, introduced in [33752].
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34396


git-svn-id: http://core.svn.wordpress.org/trunk@34360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 13:01:25 +00:00
Drew Jaynes
521d39b629 Docs: Add a file header to wp-includes/class-wp-role.php, introduced in [33752].
Also adjusts the class DocBlock for `WP_Role`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34395


git-svn-id: http://core.svn.wordpress.org/trunk@34359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 12:59:24 +00:00
Drew Jaynes
4d9fa2d7d2 Docs: Add a file header to wp-includes/class-wp-roles.php, introduced in [33752].
Also adjusts the class DocBlock for `WP_Roles`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@34394


git-svn-id: http://core.svn.wordpress.org/trunk@34358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 12:54:26 +00:00
Drew Jaynes
35246a957f Docs: The User API is singular.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34393


git-svn-id: http://core.svn.wordpress.org/trunk@34357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 12:31:26 +00:00
Drew Jaynes
783876bd1a Docs: The Widget API is singular.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@34392


git-svn-id: http://core.svn.wordpress.org/trunk@34356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 12:28:27 +00:00
Drew Jaynes
e845a6ed97 Docs: Update the file path in the duplicate hook comment for the admin_xml_ns hook in wp-admin/includes/template-functions.php.
The hook was "moved" to the newly-created template-functions.php file via `svn cp` in [34241].

Props dimadin.
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34391


git-svn-id: http://core.svn.wordpress.org/trunk@34355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 10:32:26 +00:00
Drew Jaynes
4e1ca6b1aa Docs: Add a missing access modifier to the declaration for the WP_User::__unset() magic method, introduced in [34380].
Also adds missing documentation to the DocBlock.

Fixes #20043.

Built from https://develop.svn.wordpress.org/trunk@34390


git-svn-id: http://core.svn.wordpress.org/trunk@34354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 10:07:23 +00:00
Drew Jaynes
48213a5842 Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the WP_User::__get() magic method.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34389


git-svn-id: http://core.svn.wordpress.org/trunk@34353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 10:02:24 +00:00
Drew Jaynes
fd82198aad Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the WP_User::__isset() magic method.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34388


git-svn-id: http://core.svn.wordpress.org/trunk@34352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 09:59:24 +00:00
Drew Jaynes
16d8ed44a5 Docs: Add a file header to wp-includes/class-wp-user.php, created in [33752].
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34387


git-svn-id: http://core.svn.wordpress.org/trunk@34351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 09:56:25 +00:00
Drew Jaynes
a88e3e9a1d Docs: Add a changelog entry to WP_Widget_Categories for non-category support, added in [34376].
See #21165. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34386


git-svn-id: http://core.svn.wordpress.org/trunk@34350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 09:50:25 +00:00
Drew Jaynes
89a1bb93e4 Docs: Add a file header to wp-includes/widgets/class-wp-widget-categories.php.
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34385


git-svn-id: http://core.svn.wordpress.org/trunk@34349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 09:48:25 +00:00
Drew Jaynes
c5fede78e0 Docs: Include 'wp-json' in the 4.4.0 changelog entry for the subdirectory_reserved_names filter.
'wp-json' was appended to the reserved names list in [34375].

See #33789. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34384


git-svn-id: http://core.svn.wordpress.org/trunk@34348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 09:44:27 +00:00
Scott Taylor
f9c2a88a8a List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.
Props wonderboymusic, Viper007Bond.
Fixes #21249.

Built from https://develop.svn.wordpress.org/trunk@34383


git-svn-id: http://core.svn.wordpress.org/trunk@34347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 06:06:25 +00:00
Scott Taylor
3c1e05f7c9 Dashboard: 2 submit buttons don't need names.
Props garyc40, gizburdt.
Fixes #16345.

Built from https://develop.svn.wordpress.org/trunk@34382


git-svn-id: http://core.svn.wordpress.org/trunk@34346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 05:45:26 +00:00
Scott Taylor
51115a6816 Widgets: add a static property to WP_Widget_Calendar to ensure that the id attribute is only output once.
Props MikeHansenMe, wonderboymusic.
Fixes #24604.

Built from https://develop.svn.wordpress.org/trunk@34381


git-svn-id: http://core.svn.wordpress.org/trunk@34345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 05:09:24 +00:00
Scott Taylor
eb1e8f41a0 Users: add __unset to WP_User.
Adds unit tests.

Props johnjamesjacoby, MikeHansenMe, wonderboymusic.
Fixes #20043.

Built from https://develop.svn.wordpress.org/trunk@34380


git-svn-id: http://core.svn.wordpress.org/trunk@34344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 05:00:24 +00:00
Scott Taylor
d093242095 Users: clarify the docs for WP_User::__set to make it clear that it does save data in the database.
Props johnpbloch.
Fixes #24255.

Built from https://develop.svn.wordpress.org/trunk@34379


git-svn-id: http://core.svn.wordpress.org/trunk@34343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:56:24 +00:00
Scott Taylor
aa8c76258a After [34374], ensure that $iptc is defined.
See #33772.

Built from https://develop.svn.wordpress.org/trunk@34378


git-svn-id: http://core.svn.wordpress.org/trunk@34342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:49:24 +00:00
Scott Taylor
3c66bd6cb6 Sanitization: when falling back to (wait for it...) $fallback in sanitize_html_class(), sanitize it as well.
Props MikeHansenMe, wonderboymusic.
Fixes #30967.

Built from https://develop.svn.wordpress.org/trunk@34377


git-svn-id: http://core.svn.wordpress.org/trunk@34341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:31:25 +00:00
Scott Taylor
40c15af795 Widgets: Make the categories widget work with custom taxonomies.
Props fonglh, wonderboymusic, DrewAPicture, kucrut.
Fixes #21165.

Built from https://develop.svn.wordpress.org/trunk@34376


git-svn-id: http://core.svn.wordpress.org/trunk@34340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:25:24 +00:00
Scott Taylor
c60b00fc20 Multisite: as a precaution, make wp-json a reserved subdirectory name.
Props austinginder.
Fixes #33789.

Built from https://develop.svn.wordpress.org/trunk@34375


git-svn-id: http://core.svn.wordpress.org/trunk@34339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:21:25 +00:00
Scott Taylor
1d513fe737 Media: In wp_read_image_metadata(), include IPTC Keywords when available in $meta.
Adds unit test.

Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772.

Built from https://develop.svn.wordpress.org/trunk@34374


git-svn-id: http://core.svn.wordpress.org/trunk@34338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:19:24 +00:00
Scott Taylor
e3fcbf5d55 Media: Add new functions, get_the_post_thumbnail_url() and the_post_thumbnail_url().
Adds unit tests.

Props dipesh.kakadiya, swissspidy, atomicjack.
Fixes #33070.

Built from https://develop.svn.wordpress.org/trunk@34373


git-svn-id: http://core.svn.wordpress.org/trunk@34337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:15:24 +00:00
Scott Taylor
2ddc1d2f3a Media: Add a new function, wp_get_attachment_image_url(), which is a shortcut for wp_get_attachment_image_src() - same function signature, but returns just the URL based on $size.
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.

Built from https://develop.svn.wordpress.org/trunk@34372


git-svn-id: http://core.svn.wordpress.org/trunk@34336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:13:27 +00:00
Scott Taylor
39552b63ca Passwords: fix the markup on the Reset Password Form for user-pass1 so the JavaScript operates properly.
Props ldinclaux.
See #33892.
Fixes #33908.

Built from https://develop.svn.wordpress.org/trunk@34371


git-svn-id: http://core.svn.wordpress.org/trunk@34335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 03:57:24 +00:00
Scott Taylor
3ad78c4ec5 Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added.
Fixes #33941.

Built from https://develop.svn.wordpress.org/trunk@34370


git-svn-id: http://core.svn.wordpress.org/trunk@34334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 03:37:25 +00:00
Scott Taylor
62a91851de HTTP: Add some new Cookie helper functions:
* `wp_remote_retrieve_cookies( $response )`
* `wp_remote_retrieve_cookie( $response, $name )`
* `wp_remote_retrieve_cookie_value( $response, $name )`

Adds unit tests.

Props johnbillion.
Fixes #33711.

Built from https://develop.svn.wordpress.org/trunk@34369


git-svn-id: http://core.svn.wordpress.org/trunk@34333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 03:14:25 +00:00
Drew Jaynes
8241813825 Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765].
See #31443. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34368


git-svn-id: http://core.svn.wordpress.org/trunk@34332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 23:13:26 +00:00
Konstantin Obenland
c5a684fc27 Introduce template functions for comment navigation:
* `get_the_comments_navigation()` and `the_comments_navigation()` for navigation to the next and previous page of comments.
* `get_the_comments_pagination()` and `the_comments_pagination()` for paginated navigation between pages of comments. Uses `paginate_comments_links()`.

This reduces the need for themes to define their own sets of comment navigation
functions, like Twenty Fifteen and others.
Completes the navigation template tag API started in #29808 for posts.

Fixes #30589.


Built from https://develop.svn.wordpress.org/trunk@34367


git-svn-id: http://core.svn.wordpress.org/trunk@34331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 16:32:26 +00:00
Scott Taylor
e19e604a74 Docs: is_main_query()'s _doing_it_wrong() notice suggests using WP_Query statically (WP_Query::is_main_query()). Use an alternate syntax: WP_Query->is_main_query(), to not confuse.
Props DrewAPicture, micahwave.
Fixes #25680.

Built from https://develop.svn.wordpress.org/trunk@34366


git-svn-id: http://core.svn.wordpress.org/trunk@34330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 15:31:26 +00:00
Helen Hou-Sandí
dd08157024 Notices: Add styles for use against white backgrounds.
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.

Built from https://develop.svn.wordpress.org/trunk@34365


git-svn-id: http://core.svn.wordpress.org/trunk@34329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 15:26:25 +00:00
Scott Taylor
f4121923da Meta Boxes: In post_categories_meta_box(), convert some spaces to tabs.
Props miyauchi.
Fixes #33945.

Built from https://develop.svn.wordpress.org/trunk@34364


git-svn-id: http://core.svn.wordpress.org/trunk@34328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 15:18:26 +00:00
Drew Jaynes
b336035dac Docs: The $post parameter has been passed to the preview_post_link since 4.0.0.
Fixes a version mixup introduced in [34170].

Props dimadin.
See #24345.

Built from https://develop.svn.wordpress.org/trunk@34363


git-svn-id: http://core.svn.wordpress.org/trunk@34327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 13:17:26 +00:00
Drew Jaynes
bbae198372 Docs: Add a more complete return description for the array of data (or false) returned by image_downsize().
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.

Built from https://develop.svn.wordpress.org/trunk@34362


git-svn-id: http://core.svn.wordpress.org/trunk@34326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 10:22:26 +00:00
Drew Jaynes
e6764f3b19 Docs: Update the docs for WP_User_Query->prepare_query() for ordering by the value of the include argument, allowed since 4.1.
Also adds a changelog entry for the additionally-accepted value.

Props danielbachhuber.
Fixes #33937.

Built from https://develop.svn.wordpress.org/trunk@34361


git-svn-id: http://core.svn.wordpress.org/trunk@34325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 00:47:25 +00:00
John Blackbourn
f38013229b Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors).
Props linuxologos, wonderboymusic
Fixes #19609

Built from https://develop.svn.wordpress.org/trunk@34360


git-svn-id: http://core.svn.wordpress.org/trunk@34324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 17:28:24 +00:00
John Blackbourn
970752a351 Remove the ability to view the term editing screen for taxonomies with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.

Fixes #33938

Built from https://develop.svn.wordpress.org/trunk@34359


git-svn-id: http://core.svn.wordpress.org/trunk@34323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 17:11:25 +00:00
John Blackbourn
86bb996446 Implement some more uses of wp_login_url() in places where wp-login.php is hard-coded.
See #31495

Built from https://develop.svn.wordpress.org/trunk@34358


git-svn-id: http://core.svn.wordpress.org/trunk@34322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 16:54:24 +00:00
John Blackbourn
015349cd6e Revisions are an exception when it comes to the editing UI. The revision post type cannot have its show_ui argument set to true because this allows access to the post type listing, creation, and editing UI, but get_edit_post_link() needs to return a URL for the editing UI for revisions as that's how the revisions UI works.
Fixes #33763

Built from https://develop.svn.wordpress.org/trunk@34357


git-svn-id: http://core.svn.wordpress.org/trunk@34321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 16:38:26 +00:00
Konstantin Obenland
b548119d99 Multisite: Make site status classes available to other elements.
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.


Built from https://develop.svn.wordpress.org/trunk@34356


git-svn-id: http://core.svn.wordpress.org/trunk@34320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 12:53:27 +00:00
Drew Jaynes
b051f0f6c8 Docs: Add a description for the documented use of the $wpdb global in _prime_comment_caches().
See #8071. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34355


git-svn-id: http://core.svn.wordpress.org/trunk@34319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 09:39:23 +00:00
Dominik Schilling
d2414cbd2f Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings.
Props ramiy.
Fixes #31870.
Built from https://develop.svn.wordpress.org/trunk@34354


git-svn-id: http://core.svn.wordpress.org/trunk@34318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 09:11:24 +00:00
John Blackbourn
707f0d9108 Add @since docs for the show_ui argument in register_post_type().
See #33763

Built from https://develop.svn.wordpress.org/trunk@34353


git-svn-id: http://core.svn.wordpress.org/trunk@34317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 09:05:24 +00:00
Dominik Schilling
ca3e65e20e Upgrader: Avoid using an HTML tag in a translation string, add translator comments.
Props ramiy for initial patch. 
Fixes #31860.
Built from https://develop.svn.wordpress.org/trunk@34352


git-svn-id: http://core.svn.wordpress.org/trunk@34316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 08:59:24 +00:00
Dominik Schilling
d5be34186c Theme Compat: Remove two strings from comments-popup.php.
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.
Built from https://develop.svn.wordpress.org/trunk@34351


git-svn-id: http://core.svn.wordpress.org/trunk@34315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 08:49:27 +00:00
Sergey Biryukov
d63bb56030 Pass the current post object to 'page_attributes_meta_box_template' action added in [34340].
Props DrewAPicture.
Fixes #33625.
Built from https://develop.svn.wordpress.org/trunk@34350


git-svn-id: http://core.svn.wordpress.org/trunk@34314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 08:15:28 +00:00
Drew Jaynes
292243944f Docs: Use standardized vernacular in the hook doc summary for the page_attributes_meta_box_template filter, introduced in [34340].
See #33625.

Built from https://develop.svn.wordpress.org/trunk@34349


git-svn-id: http://core.svn.wordpress.org/trunk@34313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 06:38:25 +00:00
Scott Taylor
84da11d918 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload().
Fixes #20523.

Built from https://develop.svn.wordpress.org/trunk@34348


git-svn-id: http://core.svn.wordpress.org/trunk@34312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:52:25 +00:00
Scott Taylor
82709c30d9 The 'get_sample_permalink_html' filter​'s second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with 'get_sample_permalink' filter added in [34309].
Props SergeyBiryukov.	
Fixes #33927.

Built from https://develop.svn.wordpress.org/trunk@34347


git-svn-id: http://core.svn.wordpress.org/trunk@34311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:26:25 +00:00
Scott Taylor
b20e8dbf69 MediaElement, update wp-mediaelement.js:
* create a public `initialize` method on the `wp.mediaelement` namespace
* make it idempotent to prevent nasty side-effects caused by initializing media elements more than once

Props bradyvercher.	
Fixes #32423.

Built from https://develop.svn.wordpress.org/trunk@34346


git-svn-id: http://core.svn.wordpress.org/trunk@34310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:17:24 +00:00
Scott Taylor
cb54b8d5a7 WP Query: Avoid using HTML tags in translation strings, add translator strings.
Props ramiy.	
Fixes #31868.

Built from https://develop.svn.wordpress.org/trunk@34345


git-svn-id: http://core.svn.wordpress.org/trunk@34309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:04:24 +00:00
Scott Taylor
d34b59a5d2 Plugins Admin: Avoid using HTML tags in translation strings, add translator strings.
Props swissspidy, voldemortensen.	
Fixes #32269.

Built from https://develop.svn.wordpress.org/trunk@34344


git-svn-id: http://core.svn.wordpress.org/trunk@34308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:01:24 +00:00
Scott Taylor
beb61ff909 WP Mail: Avoid using HTML tags in translation strings, add translator strings.
Props ramiy.	
Fixes #31871.

Built from https://develop.svn.wordpress.org/trunk@34343


git-svn-id: http://core.svn.wordpress.org/trunk@34307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 02:53:25 +00:00
Scott Taylor
630d3db338 Theme Compat: Avoid using HTML tags in translation strings.
Props ramiy.	
Fixes #31867.

Built from https://develop.svn.wordpress.org/trunk@34342


git-svn-id: http://core.svn.wordpress.org/trunk@34306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 02:47:24 +00:00
Scott Taylor
ebb01aae4c Plugin Editor: Avoid using HTML tags in translation strings and add context.
Props ramiy.	
Fixes #31862.

Built from https://develop.svn.wordpress.org/trunk@34341


git-svn-id: http://core.svn.wordpress.org/trunk@34305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 02:42:25 +00:00
Scott Taylor
89a03563c9 In page_attributes_meta_box(), add an action, 'page_attributes_meta_box_template' to allow callbacks to be performed and HTML to be inserted after the title of the Template section.
Props sgrant.	
Fixes #33625.

Built from https://develop.svn.wordpress.org/trunk@34340


git-svn-id: http://core.svn.wordpress.org/trunk@34304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 02:40:24 +00:00
Scott Taylor
d2578f84d1 MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface:
ccba8d0b6a

Props bradyvercher.
Fixes #33798.

Built from https://develop.svn.wordpress.org/trunk@34339


git-svn-id: http://core.svn.wordpress.org/trunk@34303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 02:31:24 +00:00
Scott Taylor
693692af68 Login: apply the same margin to the top and bottom of the Back to {Blog} link.
Props MikeHansenMe.
Fixes #29249.

Built from https://develop.svn.wordpress.org/trunk@34338


git-svn-id: http://core.svn.wordpress.org/trunk@34302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 01:41:25 +00:00
Drew Jaynes
f93dcf9226 Docs: Add descriptions for $wp_query global phpDoc references in wp-includes/query.php, partially documented in [32620].
Fixes #32139.

Built from https://develop.svn.wordpress.org/trunk@34337


git-svn-id: http://core.svn.wordpress.org/trunk@34301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 00:05:26 +00:00
Scott Taylor
8d2abbffac Feeds/Links: fix feed links for unattached attachments.
Adds unit tests.

Props wonderboymusic, iworks.
Fixes #33693.

Built from https://develop.svn.wordpress.org/trunk@34336


git-svn-id: http://core.svn.wordpress.org/trunk@34300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 20:10:24 +00:00
Scott Taylor
2b3c283040 After [34334], update unit tests.
See #33930.

Built from https://develop.svn.wordpress.org/trunk@34335


git-svn-id: http://core.svn.wordpress.org/trunk@34299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 20:07:24 +00:00
Scott Taylor
518404a166 Site Icon: for consistency, make all 4 HTML tags in wp_site_icon() self-closing.
Props Corphi.
Fixes #33930.

Built from https://develop.svn.wordpress.org/trunk@34334


git-svn-id: http://core.svn.wordpress.org/trunk@34298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 19:07:27 +00:00
Scott Taylor
864b54d46f Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors.
Props westonruter.
Fixes #33732.

Built from https://develop.svn.wordpress.org/trunk@34333


git-svn-id: http://core.svn.wordpress.org/trunk@34297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:53:25 +00:00
Scott Taylor
2c4323fc1c Updates: in Theme list table, set white-space to normal for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens.
Fixes #33831.

Built from https://develop.svn.wordpress.org/trunk@34332


git-svn-id: http://core.svn.wordpress.org/trunk@34296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:43:24 +00:00
Scott Taylor
47fead7a38 Post List Table: 'All' view should be selected when appropriate for paged responses.
Props kraftbj, wonderboymusic.
Fixes #33923.

Built from https://develop.svn.wordpress.org/trunk@34331


git-svn-id: http://core.svn.wordpress.org/trunk@34295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:17:24 +00:00
Scott Taylor
e4f350706c Add a 'menu_id' argument to wp_page_menu() so that fallback menus have the same attributes as wp_nav_menu().
Props lancewillett, ocean90, wonderboymusic.
Fixes #31656.

Built from https://develop.svn.wordpress.org/trunk@34330


git-svn-id: http://core.svn.wordpress.org/trunk@34294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:07:26 +00:00
Scott Taylor
fc8c624a61 Reinstate [34327]. minus the unit test deletion.
Built from https://develop.svn.wordpress.org/trunk@34329


git-svn-id: http://core.svn.wordpress.org/trunk@34293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 17:49:24 +00:00
Scott Taylor
863fd80150 Revert [34327] to fix the accidental deletion of some unit tests.
Built from https://develop.svn.wordpress.org/trunk@34328


git-svn-id: http://core.svn.wordpress.org/trunk@34292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 17:46:24 +00:00
Scott Taylor
003edb6ea7 Export: Add a filer, 'export_wp_filename' to change the filename of the file to download when exporting.
Props MikeHansenMe, wonderboymusic.
Fixes #29500.

Built from https://develop.svn.wordpress.org/trunk@34327


git-svn-id: http://core.svn.wordpress.org/trunk@34291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 17:44:24 +00:00
Scott Taylor
0fd01b9057 Export: allow Media to exported separately from other types.
Props PhilipLakin.
Fixes #32230.

Built from https://develop.svn.wordpress.org/trunk@34326


git-svn-id: http://core.svn.wordpress.org/trunk@34290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:47:25 +00:00
Scott Taylor
28964445d4 Admin: when toggling select/deselect "all" via JS - :visible needs to be bound to not toggle disabled inputs.
Props tywayne.
Fixes #32309.

Built from https://develop.svn.wordpress.org/trunk@34325


git-svn-id: http://core.svn.wordpress.org/trunk@34289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:41:24 +00:00
Scott Taylor
e47963d1e7 Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link.
Props wpdev101.
Fixes #33541.

Built from https://develop.svn.wordpress.org/trunk@34324


git-svn-id: http://core.svn.wordpress.org/trunk@34288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:32:24 +00:00
Scott Taylor
60fadd7bdc List Tables: Ensure that sorting indicators have layout when cell widths are being calculated.
See #27743.

Built from https://develop.svn.wordpress.org/trunk@34323


git-svn-id: http://core.svn.wordpress.org/trunk@34287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:15:24 +00:00
Scott Taylor
6dc9ffc090 Update Core: In list_plugin_updates(), when listing plugin updates related to $core_update_version, don't skip the check for $info->tested.
Props MikeHansenMe.
Fixes #27883.

Built from https://develop.svn.wordpress.org/trunk@34322


git-svn-id: http://core.svn.wordpress.org/trunk@34286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:10:26 +00:00
Konstantin Obenland
8d8252aa89 Menus: Remove whitespace between nav menu items.
Avoids CSS hacks like floating menu items or setting the parent element's
font-size to 0 in order to display nav menus horizontally.

Props jjeaton.
Fixes #27762.


Built from https://develop.svn.wordpress.org/trunk@34321


git-svn-id: http://core.svn.wordpress.org/trunk@34285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 11:40:26 +00:00
Weston Ruter
4ff29f822e Customize: Flesh out phpdoc for WP_Customize_Manager.
* Add missing phpdoc for class member variables.
* Supply missing `@return` descriptions from [34269].
* Add missing `@since` tags.
* Remove unused `$customized` protected class member variable.

Fixes #33898.

Built from https://develop.svn.wordpress.org/trunk@34320


git-svn-id: http://core.svn.wordpress.org/trunk@34284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 06:40:26 +00:00
Scott Taylor
d28e914a06 When applying the 'editable_slug' filter, add a second param that provides more context.
Props MikeSchinkel, jesin.
Fixes #31568.

Built from https://develop.svn.wordpress.org/trunk@34319


git-svn-id: http://core.svn.wordpress.org/trunk@34283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 05:49:24 +00:00
Scott Taylor
170a2cc4be Add a 'clean_user_cache' action at the end of clean_user_cache(). This is mighty similar to clean_post_cache().
Props elliott-stocks, wonderboymusic.
Fixes #31918.

Built from https://develop.svn.wordpress.org/trunk@34318


git-svn-id: http://core.svn.wordpress.org/trunk@34282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 05:41:26 +00:00
Andrew Ozz
1b24c98739 TinyMCE: remove word-break: break-word; from the default editor CSS to prevent irregular spaces when typing in RTL languages.
Props iehsanir, alireza1375, ankit-k-gupta.
Fixes #33868.
Built from https://develop.svn.wordpress.org/trunk@34317


git-svn-id: http://core.svn.wordpress.org/trunk@34281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 23:58:26 +00:00
Dominik Schilling
0891de90e0 Theme Compat: Remove commented out code.
See #31867.
Built from https://develop.svn.wordpress.org/trunk@34316


git-svn-id: http://core.svn.wordpress.org/trunk@34280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 21:38:25 +00:00
Dominik Schilling
33127a3f59 Don't use <code> in translation strings in wp-admin/options.php.
Props ramiy, wonderboymusic.
Fixes #31861.
Built from https://develop.svn.wordpress.org/trunk@34315


git-svn-id: http://core.svn.wordpress.org/trunk@34279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:43:25 +00:00
Dominik Schilling
d1bdd59183 Don't use <code> in translation strings in wp-admin/includes/plugin.php.
Props ramiy.
Fixes #31856.
Built from https://develop.svn.wordpress.org/trunk@34314


git-svn-id: http://core.svn.wordpress.org/trunk@34278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:29:26 +00:00
Dominik Schilling
622d4bd029 Use correct @since tag for wp_ajax_generate_password().
See #33450.
Built from https://develop.svn.wordpress.org/trunk@34313


git-svn-id: http://core.svn.wordpress.org/trunk@34277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:19:25 +00:00
Scott Taylor
c43f72fbfb Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user.
Props adamsilverstein, wonderboymusic.
Fixes #33450.

Built from https://develop.svn.wordpress.org/trunk@34312


git-svn-id: http://core.svn.wordpress.org/trunk@34276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:14:24 +00:00
Scott Taylor
abefb963e7 Media: add a filter, 'mejs_settings', to allow devs to pass more config settings to MediaElement.
Fixes #33506.

Built from https://develop.svn.wordpress.org/trunk@34311


git-svn-id: http://core.svn.wordpress.org/trunk@34275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:00:27 +00:00
Boone Gorges
c6c9f8ad26 Split the comment query.
`WP_Comment_Query` now fetches comments in two stages: (1) a query to get the
IDs of comments matching the query vars, and (2) a query to populate the
objects corresponding to the matched IDs. The two queries are cached
separately, so that sites with persistent object caches will continue to have
complete cache coverage for normal comment queries.

Splitting the query allows our cache strategy to be more modest and precise, as
full comment data is only stored once per comment. It also makes it possible
to introduce logic for paginated threading, which is necessary to address
certain performance problems.

See #8071.
data is only stored once per comment, instead of along with
Built from https://develop.svn.wordpress.org/trunk@34310


git-svn-id: http://core.svn.wordpress.org/trunk@34274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:28:51 +00:00
Scott Taylor
04f7a0da2f Add a 'get_sample_permalink' filter.
Props SergeyBiryukov, wenthemes, JustinSainton.
Fixes #22338.

Built from https://develop.svn.wordpress.org/trunk@34309


git-svn-id: http://core.svn.wordpress.org/trunk@34273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:28:26 +00:00
Scott Taylor
1d0774e784 Add title_reply_before and title_reply_after args to comment_form() to allow the "Leave a Reply" heading level to be changed.
Props tyxla.
Fixes #33775.

Built from https://develop.svn.wordpress.org/trunk@34308


git-svn-id: http://core.svn.wordpress.org/trunk@34272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:18:26 +00:00
Scott Taylor
026bec7990 After [34280], rename menu_tag arg to container, fix docs.
Props DrewAPicture.
Fixes #10968.

Built from https://develop.svn.wordpress.org/trunk@34307


git-svn-id: http://core.svn.wordpress.org/trunk@34271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:05:25 +00:00
Sergey Biryukov
a87885262f Include placeholder in translator comment.
See #31863.
Built from https://develop.svn.wordpress.org/trunk@34306


git-svn-id: http://core.svn.wordpress.org/trunk@34270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:03:25 +00:00
Sergey Biryukov
6a6d8ba4b8 Include placeholder in translator comment.
See #31864.
Built from https://develop.svn.wordpress.org/trunk@34305


git-svn-id: http://core.svn.wordpress.org/trunk@34269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:01:24 +00:00
Sergey Biryukov
7adaef50bb Include placeholders in translator comments.
See #31857.
Built from https://develop.svn.wordpress.org/trunk@34304


git-svn-id: http://core.svn.wordpress.org/trunk@34268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:58:24 +00:00
Scott Taylor
ea0cf44097 Don't use HTML tags in translation strings in edit-tags.php.
Props ramiy.
Fixes #31863.

Built from https://develop.svn.wordpress.org/trunk@34303


git-svn-id: http://core.svn.wordpress.org/trunk@34267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:53:25 +00:00
Scott Taylor
40c45718af Don't use HTML tags in translation strings in wp_ajax_add_user().
Props ramiy.
Fixes #31864.

Built from https://develop.svn.wordpress.org/trunk@34302


git-svn-id: http://core.svn.wordpress.org/trunk@34266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:51:26 +00:00
Sergey Biryukov
8e353f294c Add missing translator comment after [34295].
See #31853.
Built from https://develop.svn.wordpress.org/trunk@34301


git-svn-id: http://core.svn.wordpress.org/trunk@34265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:50:24 +00:00
Sergey Biryukov
569dbcfeab Add missing translator comments after [34294].
See #31852.
Built from https://develop.svn.wordpress.org/trunk@34300


git-svn-id: http://core.svn.wordpress.org/trunk@34264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:46:24 +00:00
Sergey Biryukov
8f0e1e3c72 Add missing translator comment after [34292].
See #31840.
Built from https://develop.svn.wordpress.org/trunk@34299


git-svn-id: http://core.svn.wordpress.org/trunk@34263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:40:24 +00:00
Sergey Biryukov
844586e889 Add missing translator comments after [34293].
See #31851.
Built from https://develop.svn.wordpress.org/trunk@34298


git-svn-id: http://core.svn.wordpress.org/trunk@34262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:39:23 +00:00
Scott Taylor
ec01716bb2 Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin.
Props ramiy.
Fixes #31857.

Built from https://develop.svn.wordpress.org/trunk@34297


git-svn-id: http://core.svn.wordpress.org/trunk@34261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:36:24 +00:00
Scott Taylor
15f2e57a5a Don't use HTML tags in translation strings in wp-admin/includes/update.php.
Props ramiy.
Fixes #31855.

Built from https://develop.svn.wordpress.org/trunk@34296


git-svn-id: http://core.svn.wordpress.org/trunk@34260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:31:25 +00:00
Scott Taylor
20a42701f4 Don't use <code> in translation strings in edit-form-comment.php.
Props ramiy.
Fixes #31853.

Built from https://develop.svn.wordpress.org/trunk@34295


git-svn-id: http://core.svn.wordpress.org/trunk@34259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:28:26 +00:00
Scott Taylor
defb5bbf43 Don't use <code> in translation strings in options-general.php.
Props ramiy, SergeyBiryukov.
Fixes #31852.

Built from https://develop.svn.wordpress.org/trunk@34294


git-svn-id: http://core.svn.wordpress.org/trunk@34258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:24:24 +00:00
Scott Taylor
318cd61abf Don't use <code> in translation strings in wp-admin/includes/schema.php.
Props ramiy.
Fixes #31851.

Built from https://develop.svn.wordpress.org/trunk@34293


git-svn-id: http://core.svn.wordpress.org/trunk@34257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:21:25 +00:00
Scott Taylor
dd6fe1ba32 Network Setup: don't use <code> in translation strings in wp-admin/network files.
Props ramiy.
Fixes #31840.

Built from https://develop.svn.wordpress.org/trunk@34292


git-svn-id: http://core.svn.wordpress.org/trunk@34256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:18:27 +00:00
Aaron Jorbin
10d03c1ab3 Remove support for my-hacks.php
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide


Built from https://develop.svn.wordpress.org/trunk@34291


git-svn-id: http://core.svn.wordpress.org/trunk@34255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 17:06:25 +00:00
Dominik Schilling
f3a62b7714 Theme Editor: Change file descriptions of header.php and footer.php.
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.
Built from https://develop.svn.wordpress.org/trunk@34290


git-svn-id: http://core.svn.wordpress.org/trunk@34254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 16:03:24 +00:00
Sergey Biryukov
b92955b427 Network Admin: Include IDs for users and sites on their respective views.
Props danielbachhuber, wonderboymusic.
Fixes #18661.
Built from https://develop.svn.wordpress.org/trunk@34289


git-svn-id: http://core.svn.wordpress.org/trunk@34253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 15:58:25 +00:00
Drew Jaynes
33a1c0fc16 Docs: Clarify the significance of the $accepted_args parameter value in the documentation for add_filter().
Adds a couple of examples to illustrate callbacks accepting a variable number of arguments.

Fixes #33862.

Built from https://develop.svn.wordpress.org/trunk@34288


git-svn-id: http://core.svn.wordpress.org/trunk@34252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 14:53:28 +00:00
Drew Jaynes
d870f4c9f9 Docs: Fix some syntactical issues in the DocBlock for set_query_var().
Adds descriptions for the global `WP_Query` instance and the `$value` parameter.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34287


git-svn-id: http://core.svn.wordpress.org/trunk@34251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 10:29:25 +00:00
Drew Jaynes
18adeb92fa Docs: Fix some syntactical issues in the documentation for get_queried_object_id().
Adds descriptions for the global `WP_Query` instance and the return.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34286


git-svn-id: http://core.svn.wordpress.org/trunk@34250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 10:27:24 +00:00
Drew Jaynes
7a73dfbfb6 Docs: Fix some syntactical isses in the DocBlock for get_queried_object().
Also add descriptions for the return and the `WP_Query` global.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34285


git-svn-id: http://core.svn.wordpress.org/trunk@34249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 10:21:26 +00:00
Drew Jaynes
05f4e52541 Docs: Add documentation to get_query_var() and WP_Query::get() for the optional $default argument, introduced in 3.9 in [27304].
Props swissspidy.
Fixes #33856.

Built from https://develop.svn.wordpress.org/trunk@34284


git-svn-id: http://core.svn.wordpress.org/trunk@34248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 09:41:27 +00:00
Dion Hulse
9f61845204 HTTP: Update the Root Certificate bundle.
See #30434

Built from https://develop.svn.wordpress.org/trunk@34283


git-svn-id: http://core.svn.wordpress.org/trunk@34247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:43:26 +00:00
Dion Hulse
6113e498fc Updates: FTP: Add a missing PCRE modifer in [34281].
See #16026, #33432x

Built from https://develop.svn.wordpress.org/trunk@34282


git-svn-id: http://core.svn.wordpress.org/trunk@34246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:23:25 +00:00
Dion Hulse
5abc1eaab9 Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE).
Props enshrined, aaroncampbell
Fixes #16026, #33432

Built from https://develop.svn.wordpress.org/trunk@34281


git-svn-id: http://core.svn.wordpress.org/trunk@34245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:20:27 +00:00
Scott Taylor
3ed914175a Add an argument to wp_page_menu(), 'menu_tag', which defaults to div but can be overridden to allow HTML5 tags like nav.
Props paulwilde, stebbiv, wonderboymusic.
Fixes #10968.

Built from https://develop.svn.wordpress.org/trunk@34280


git-svn-id: http://core.svn.wordpress.org/trunk@34244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 06:07:24 +00:00
Weston Ruter
88c1ab7c74 Customize: Fix live previewing of menu changes on subdirectory installs.
Props adamsilverstein, westonruter.
Fixes #33916.

Built from https://develop.svn.wordpress.org/trunk@34278


git-svn-id: http://core.svn.wordpress.org/trunk@34242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 05:47:27 +00:00
Scott Taylor
c1c8b55617 Comments: in wp_rel_nofollow_callback(), account for the fact that a link might already have a rel attribute. Currently, if a link already has a rel, it will result it duplicate attributes on the element with conflicting values.
Adds unit tests.

Props junsuijin, wonderboymusic.
Fixes #9959.

Built from https://develop.svn.wordpress.org/trunk@34277


git-svn-id: http://core.svn.wordpress.org/trunk@34241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 04:36:24 +00:00
Scott Taylor
fe6a7e4baa List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.
Props drozdz.
Fixes #27945.

Built from https://develop.svn.wordpress.org/trunk@34276


git-svn-id: http://core.svn.wordpress.org/trunk@34240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 03:26:26 +00:00
Scott Taylor
9b7b7f6dde Editor: add hide-if-no-js class to <td id="wp-word-count">. Word Count no worky with no JavaScript.
Props chriscct7.
Fixes #33379.

Built from https://develop.svn.wordpress.org/trunk@34275


git-svn-id: http://core.svn.wordpress.org/trunk@34239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 02:32:26 +00:00
Scott Taylor
0708ffe15c In wp-comments-post.php, sanity check a few of the comment inputs that are expected to be a string beford calling string-only functions on them.
Props Kloon.
Fixes #23416.

Built from https://develop.svn.wordpress.org/trunk@34274


git-svn-id: http://core.svn.wordpress.org/trunk@34238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 22:22:25 +00:00
Scott Taylor
a2f15ca7cd Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy.
Props GautamGupta, wonderboymusic.
Fixes #16125.

Built from https://develop.svn.wordpress.org/trunk@34273


git-svn-id: http://core.svn.wordpress.org/trunk@34237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 22:11:24 +00:00
Scott Taylor
c2e1bab509 Canonical: redirect URLs that match an attachment masked on the wrong URL to the attachment link for the matched attachment.
Props solarissmoke.
Fixes #19918.

Built from https://develop.svn.wordpress.org/trunk@34272


git-svn-id: http://core.svn.wordpress.org/trunk@34236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 21:32:24 +00:00
Scott Taylor
48d402a395 Posts List Table: Use a more robust technique for calculating $total_items so that pagination still appears when items are removed on the last page of results and ->max_num_pages decreases.
Props A5hleyRich.
Fixes #29870.

Built from https://develop.svn.wordpress.org/trunk@34271


git-svn-id: http://core.svn.wordpress.org/trunk@34235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 21:18:24 +00:00
Boone Gorges
32887d3dfb Lazy-load comment meta on single post pages.
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.
Built from https://develop.svn.wordpress.org/trunk@34270


git-svn-id: http://core.svn.wordpress.org/trunk@34234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 20:01:24 +00:00
Weston Ruter
93bcd86b2a Customize: Reduce peak memory usage by JSON-encoding settings and controls individually.
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.

Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:

 * `is_ios()`
 * `get_document_title_template()`
 * `get_preview_url()`/`set_preview_url()`
 * `get_return_url()`/`set_return_url()`
 * `get_autofocus()`/`set_autofocus()`
 * `customize_pane_settings()`

Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.

Fixes #33898.

Built from https://develop.svn.wordpress.org/trunk@34269


git-svn-id: http://core.svn.wordpress.org/trunk@34233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 19:42:26 +00:00
Boone Gorges
bb43f72692 Prime comment meta caches in WP_Comment_Query.
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.

`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.

See #16894.
Built from https://develop.svn.wordpress.org/trunk@34268


git-svn-id: http://core.svn.wordpress.org/trunk@34232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 19:30:27 +00:00
Boone Gorges
cdc6bc8ad5 Tell the insert_user_meta filter whether user is being updated.
`insert_user_meta` was introduced in [33708]. This changeset passes the
`$update` parameter to it.

Props tharsheblows, geminorum.
Fixes #31549.
Built from https://develop.svn.wordpress.org/trunk@34266


git-svn-id: http://core.svn.wordpress.org/trunk@34230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 14:35:26 +00:00
Helen Hou-Sandí
48befcf361 Superglobals: Revert [34059] until further notice.
see #33837.

Built from https://develop.svn.wordpress.org/trunk@34265


git-svn-id: http://core.svn.wordpress.org/trunk@34229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 12:33:26 +00:00
Drew Jaynes
e13d18969f Docs: Add a reminder to the DocBlock description for add_query_arg() mentioning that the output is not escaped by default.
Props brentvr for the initial patch. (first props!)
See #33912. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34264


git-svn-id: http://core.svn.wordpress.org/trunk@34228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:39:24 +00:00
Sergey Biryukov
514eb11cf4 Revert unintended change from [34262].
See #33910.
Built from https://develop.svn.wordpress.org/trunk@34263


git-svn-id: http://core.svn.wordpress.org/trunk@34227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:09:28 +00:00
Sergey Biryukov
d91fe61405 Docs: Expand the DocBlock for get_default_post_to_edit().
Props rabmalin.
Fixes #33910.
Built from https://develop.svn.wordpress.org/trunk@34262


git-svn-id: http://core.svn.wordpress.org/trunk@34226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:06:34 +00:00
Scott Taylor
1f3dce8c75 Media: Ensure that HTML5 captions apply the 'img_caption_shortcode_width'.
Props joemcgill.
Fixes #31053.

Built from https://develop.svn.wordpress.org/trunk@34261


git-svn-id: http://core.svn.wordpress.org/trunk@34225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 06:04:24 +00:00
Scott Taylor
f3dd19c6e2 Media: In wp_ajax_send_attachment_to_editor(), the fallback logic for $html should be tucked into an else statement so it isn't run needlessly and overwritten.
Props tychay.
Fixes #32072.

Built from https://develop.svn.wordpress.org/trunk@34260


git-svn-id: http://core.svn.wordpress.org/trunk@34224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:55:25 +00:00
Scott Taylor
63efd92b11 Media: In get_image_send_to_editor(), allow a custom value for $rel.
Props tychay.
Fixes #32074.

Built from https://develop.svn.wordpress.org/trunk@34259


git-svn-id: http://core.svn.wordpress.org/trunk@34223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:46:24 +00:00
Scott Taylor
ad0eb9c442 Media: In wp_prepare_attachment_for_js(), don't call file_exists() and filesize() to retrieve $bytes if the data is already present in $meta. This is how the same code in attachment_submitbox_metadata() already works.
Props polevaultweb.
Fixes #33214.

Built from https://develop.svn.wordpress.org/trunk@34258


git-svn-id: http://core.svn.wordpress.org/trunk@34222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:03:24 +00:00
Scott Taylor
c871986819 Uploader: Fire 'wp_handle_upload' in wp_upload_bits(). Thusly, the filter in wp_xmlrpc_server::mw_newMediaObject() is redundant.
Props dllh.
Fixes #33539.

Built from https://develop.svn.wordpress.org/trunk@34257


git-svn-id: http://core.svn.wordpress.org/trunk@34221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 04:46:25 +00:00
Scott Taylor
58ac764859 Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.

Built from https://develop.svn.wordpress.org/trunk@34256


git-svn-id: http://core.svn.wordpress.org/trunk@34220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 02:30:26 +00:00
Scott Taylor
a87ef29978 In wp_mime_type_icon(), the length of the $wilds array varies depending on what is passed as $mime. Loop over $wilds instead of arbitrarily checking $wilds[0].
Adds unit tests.

Fixes #33012.


Built from https://develop.svn.wordpress.org/trunk@34255


git-svn-id: http://core.svn.wordpress.org/trunk@34219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 00:37:25 +00:00
Scott Taylor
6759f04a24 Media JS: ensure that wp.media.frame (a static reference to the "current" Frame) is reset when a cached frame is opened.
Fixes #33458.

Built from https://develop.svn.wordpress.org/trunk@34254


git-svn-id: http://core.svn.wordpress.org/trunk@34218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 00:10:26 +00:00
Sergey Biryukov
444509e246 Docs: Expand the $comment_approved argument description for 'comment_post' action.
Props cfinke.
Fixes #33903.
Built from https://develop.svn.wordpress.org/trunk@34253


git-svn-id: http://core.svn.wordpress.org/trunk@34217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:30:23 +00:00
Boone Gorges
48b7547a52 Improve consistency of comment notification callback signatures.
Both `wp_new_comment_notify_moderator()` and `wp_new_comment_notify_postauthor()`
now accept a single argument: `$comment_ID`.

Props SergeyBiryukov.
Fixes #33587.
Built from https://develop.svn.wordpress.org/trunk@34252


git-svn-id: http://core.svn.wordpress.org/trunk@34216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:26:24 +00:00
Boone Gorges
85c00bd943 Move new user notification emails to add_action() callbacks.
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.
Built from https://develop.svn.wordpress.org/trunk@34251


git-svn-id: http://core.svn.wordpress.org/trunk@34215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:19:24 +00:00
Boone Gorges
f6fb4653eb Don't notify post authors about spam comments.
[34106] moved post author notification to a hook, and in the process, missed
the 'spam' check. This changeset restores that check.

To make unit testing easier, the notification callbacks have been refactored
to return values: false when various conditions aren't met (eg, approved
comments should not trigger moderation emails), and the return value of the
`wp_notify_*()` function otherwise.

Props cfinke, kraftbj.
See #33587.
Built from https://develop.svn.wordpress.org/trunk@34250


git-svn-id: http://core.svn.wordpress.org/trunk@34214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:00:25 +00:00
Sergey Biryukov
a1050a58dc Add a missing Oxford comma on Export screen.
Props juhise.
Fixes #33906.
Built from https://develop.svn.wordpress.org/trunk@34249


git-svn-id: http://core.svn.wordpress.org/trunk@34213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 21:34:39 +00:00
Boone Gorges
5eae305403 Throw a notice when an invalid tax is passed to wp_insert_post().
Props jdgrimes.
Fixes #25477.
Built from https://develop.svn.wordpress.org/trunk@34248


git-svn-id: http://core.svn.wordpress.org/trunk@34212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 19:25:26 +00:00
Boone Gorges
471fc6d9a5 Allow taxonomies to be non-public.
[13216] introduced the 'public' argument for `register_taxonomy()`. This param
was used to set defaults for 'show_ui' and a number of other params, but it
never did anything itself.

With this changeset, taxonomies registered with `public=false` will no longer
be queryable on the front end, ie via taxonomy archive queries.

Props wpsmith, ocean90, nacin, ericlewis, boonebgorges.
Fixes #21949.
Built from https://develop.svn.wordpress.org/trunk@34247


git-svn-id: http://core.svn.wordpress.org/trunk@34211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 19:05:23 +00:00
Boone Gorges
6153a72796 Failed get_term_by() lookups should always return false.
Previously, we sometimes returned `null`.

Props charlestonsw, tyxla.
Fixes #33281.
Built from https://develop.svn.wordpress.org/trunk@34246


git-svn-id: http://core.svn.wordpress.org/trunk@34210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 18:50:26 +00:00
Scott Taylor
af593128a7 Revert [33925], by-reference array manipulation is breaking comments in some themes.
This implementation is losing its shine.

See #16894.

Built from https://develop.svn.wordpress.org/trunk@34245


git-svn-id: http://core.svn.wordpress.org/trunk@34209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 18:14:25 +00:00
Scott Taylor
956f076095 After [34160], also upgrade objects passed to get_avatar().
See #32619.


Built from https://develop.svn.wordpress.org/trunk@34244


git-svn-id: http://core.svn.wordpress.org/trunk@34208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 17:34:24 +00:00
Sergey Biryukov
bf36b458bb Docs: Update the DocBlock for wp_page_menu() to include 'before', 'after', and 'walker' arguments added in [34200].
Align the `$defaults` array and include the default value for `'show_home'`.

Props stevegrunwell.
Fixes #11095.
Built from https://develop.svn.wordpress.org/trunk@34243


git-svn-id: http://core.svn.wordpress.org/trunk@34207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 16:47:25 +00:00
Sergey Biryukov
dd11460efa Add register_post_type_args filter for changing register_post_type() arguments before further processing.
Does not apply to built-in post types.

Props MikeSchinkel, nickciske, engelen, swissspidy.
Fixes #17447.
Built from https://develop.svn.wordpress.org/trunk@34242


git-svn-id: http://core.svn.wordpress.org/trunk@34206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:47:25 +00:00
Scott Taylor
1e3807c10d wp-admin/includes/template.php is now a loader for 3 files made via svn cp:
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`

This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.

See #33413.

Built from https://develop.svn.wordpress.org/trunk@34241


git-svn-id: http://core.svn.wordpress.org/trunk@34205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:35:23 +00:00
Sergey Biryukov
aee733684b Docs: Synchronize the $timezone parameter description between get_lastpostdate(), get_lastpostmodified(), and _get_last_post_time().
See #17455.
Built from https://develop.svn.wordpress.org/trunk@34240


git-svn-id: http://core.svn.wordpress.org/trunk@34204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:29:39 +00:00
Sergey Biryukov
15b69a0862 Docs: Fix some syntactical issues with the DocBlock for wp_mail_failed action, introduced in [34221].
Fixes #18926.
Built from https://develop.svn.wordpress.org/trunk@34239


git-svn-id: http://core.svn.wordpress.org/trunk@34203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:13:26 +00:00
Sergey Biryukov
d06f5817f8 Docs: Expand the DocBlock for the WP_Theme::get_edit_link() method, introduced in [34084].
Fixes #32376.
Built from https://develop.svn.wordpress.org/trunk@34238


git-svn-id: http://core.svn.wordpress.org/trunk@34202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:01:27 +00:00
Drew Jaynes
b1f176582c Docs: Add changelog entries for parameters where WP_Comment object support was added in [33961].
See #33638. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34237


git-svn-id: http://core.svn.wordpress.org/trunk@34201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 13:52:25 +00:00
Drew Jaynes
4a69b4d275 Docs: Fix some syntactical issues with the DocBlock for the WP_Theme->update property, introduced in [33957].
Adds an `@since`.

See #33491. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34236


git-svn-id: http://core.svn.wordpress.org/trunk@34200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 13:29:25 +00:00
Drew Jaynes
fd60f500c3 Docs: Add a changelog entry for the addition of 'wp-admin', 'wp-content', and 'wp-includes' as reserved names for the subdirectory_reserved_names filter docs.
The new names were introduced in [33952].

See #33615. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34235


git-svn-id: http://core.svn.wordpress.org/trunk@34199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 13:26:26 +00:00
Drew Jaynes
13c25f5f49 Docs: Put "it's" in its place (again).
Props kitchin.
Fixes #33894.

Built from https://develop.svn.wordpress.org/trunk@34234


git-svn-id: http://core.svn.wordpress.org/trunk@34198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 12:46:28 +00:00
Sergey Biryukov
53ac914bd5 Add a comment to strings where the ellipsis cannot be used due to json_encode(), placeholders, or external dependencies.
Fixes #32875.
Built from https://develop.svn.wordpress.org/trunk@34233


git-svn-id: http://core.svn.wordpress.org/trunk@34197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:59:26 +00:00
Sergey Biryukov
19bcadf2a6 Reset Password: Move <div> out of <p> in wp-login.php.
Props ldinclaux.
Fixes #33892.
Built from https://develop.svn.wordpress.org/trunk@34232


git-svn-id: http://core.svn.wordpress.org/trunk@34196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:46:25 +00:00
Sergey Biryukov
4c019c6aee Comments: Fix a fatal error in Comments meta box after [34223].
Props tyxla.
Fixes #33893. See #33413.
Built from https://develop.svn.wordpress.org/trunk@34231


git-svn-id: http://core.svn.wordpress.org/trunk@34195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:37:25 +00:00
Drew Jaynes
faa54e4dc2 Docs: Make a minor adjustment to the description syntax for the optional $comment argument in the DocBlock for comment_link(), introduced in [34071].
See #33638. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34230


git-svn-id: http://core.svn.wordpress.org/trunk@34194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:02:24 +00:00
Drew Jaynes
3c73b53f66 Docs: Remove markdown from the DocBlock summary for WP_List_Table::get_primary_column(), introduced in [34166].
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.

See #33854. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34229


git-svn-id: http://core.svn.wordpress.org/trunk@34193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:51:25 +00:00
Drew Jaynes
c52a7d863e Docs: Add a changelog entry for the switch to using wp_get_attachment_url() instead of the guid for determining the header image URL in Custom_Image_Header::step_3().
The change was introduced in [34188].

See #33319.

Built from https://develop.svn.wordpress.org/trunk@34228


git-svn-id: http://core.svn.wordpress.org/trunk@34192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:43:25 +00:00
Drew Jaynes
4279a9c39e Docs: Improve documentation for the WP_Object_Cache class.
Spaces out parameter documentation for readability, fixes some minor syntactical issues, and adds some missing `@access` tags or reorders tags according to the PHP docs standards.

Also, documents `&$found`, the fourth parameter for the `get()` method, and adds missing parameter and return descriptions for the `_exists()` utility method.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34227


git-svn-id: http://core.svn.wordpress.org/trunk@34191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:03:26 +00:00
Drew Jaynes
5172621c1d Docs: Remove an errant change made to a _deprecated_function() call in wp_cache_reset() introduced in [34225].
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34226


git-svn-id: http://core.svn.wordpress.org/trunk@34190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 09:42:24 +00:00
Drew Jaynes
4e4737685e Docs: Add more complete documentation for top-level object cache functionality.
Adds some `@see` tags for corresponding `WP_Object_Cache` methods to DocBlocks for top-level functions. Also adds a standard description for the `@global` tags, spacing for parameter docs readability, and finally, properly marks optional parameters as such.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@34225


git-svn-id: http://core.svn.wordpress.org/trunk@34189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 09:40:25 +00:00
Drew Jaynes
a7ea95f53a Docs: Add documentation for $object_id, the optional second parameter in current_user_can() and WP_User::has_cap(), and the optional third parameter in map_meta_cap().
This change introduces the vernacular of "meta" vs "primitive" capabilities to core docs, and providing examples for each inline and attempts to make it clear that `$object_id` is really only useful if the passed `$capability` is of the meta cap variety.

Props jliman for the initial patch.
Fixes #32694.

Built from https://develop.svn.wordpress.org/trunk@34224


git-svn-id: http://core.svn.wordpress.org/trunk@34188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 07:36:32 +00:00
Scott Taylor
5920e8eb13 Move WP_Post_Comments_List_Table to its own file.
See #33413.

Built from https://develop.svn.wordpress.org/trunk@34223


git-svn-id: http://core.svn.wordpress.org/trunk@34187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 06:53:24 +00:00
Sergey Biryukov
61bef72b95 Fix a typo in wptexturize() and wp_replace_in_html_tags() comments.
Props bobbingwide.
See #15694.
Built from https://develop.svn.wordpress.org/trunk@34222


git-svn-id: http://core.svn.wordpress.org/trunk@34186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 05:54:26 +00:00
Aaron Jorbin
1bd52ae1aa Fire Action when mail exception is thrown.
new action is wp_mail_failed which contains a WP_Error object with the phpmailerException code, message and an array with the mail information. Plugins can hook in and log when mails fail to send due to a phpmailer issue.

Props soulseekah
Fixes #18926


Built from https://develop.svn.wordpress.org/trunk@34221


git-svn-id: http://core.svn.wordpress.org/trunk@34185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 23:51:23 +00:00
Weston Ruter
628caeb487 Customizer: Smooth animation for closing accordions in the available nav menu items pane.
Props tyxla.
Fixes #33360 for trunk.

Built from https://develop.svn.wordpress.org/trunk@34219


git-svn-id: http://core.svn.wordpress.org/trunk@34183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 23:40:24 +00:00
Boone Gorges
a7e229637e Improve validation of user_login and user_nicename length.
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.

This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).

Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793.
Built from https://develop.svn.wordpress.org/trunk@34218


git-svn-id: http://core.svn.wordpress.org/trunk@34182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 22:14:26 +00:00
Boone Gorges
cfbd3c2cc0 Omit the ORDER BY clause when updating object term cache.
The `ORDER BY` clause was forcing filesorts on large tables, and is
unnecessary, since term order doesn't matter when updating the cache.

Props mbrandys, wonderboymusic.
Fixes #28922.
Built from https://develop.svn.wordpress.org/trunk@34217


git-svn-id: http://core.svn.wordpress.org/trunk@34181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 20:53:33 +00:00
Scott Taylor
4139daea5e Apply the new 'respond_link' filter in comments_popup_link() if $number is 0 before outputting the URL.
Props joedolson.
Fixes #29454.

Built from https://develop.svn.wordpress.org/trunk@34216


git-svn-id: http://core.svn.wordpress.org/trunk@34180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 20:46:35 +00:00
Scott Taylor
8573a86def In WP::parse_request(), don't add query vars of non-viewable post types to WP::public_query_vars. In register_post_type(), don't add query vars of non-viewable post types to WP::public_query_vars.
In `_unregister_post_type()` (unit tests), don't add query vars of non-viewable post types to `WP::public_query_vars`.

Adds unit test.

Fixes #30018.

Built from https://develop.svn.wordpress.org/trunk@34215


git-svn-id: http://core.svn.wordpress.org/trunk@34179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 18:54:30 +00:00
Scott Taylor
d5e02c6129 After [34188], fix unit test for image header.
See #33319.

Built from https://develop.svn.wordpress.org/trunk@34214


git-svn-id: http://core.svn.wordpress.org/trunk@34178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 18:44:48 +00:00
John Blackbourn
a9e5cfddc7 Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded.
See #31495
Props GregLone

Built from https://develop.svn.wordpress.org/trunk@34213


git-svn-id: http://core.svn.wordpress.org/trunk@34177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 17:11:35 +00:00
Scott Taylor
f5edeb11d0 WP_Comment_Query: add comment__in to allowed values for $orderby.
Adds unit tests.

Fixes #33883.

Built from https://develop.svn.wordpress.org/trunk@34212


git-svn-id: http://core.svn.wordpress.org/trunk@34176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 16:35:44 +00:00
Scott Taylor
72651400ba Add parent__in and parent__not_in query vars to WP_Comment_Query.
Adds unit tests.

Fixes #33882.

Built from https://develop.svn.wordpress.org/trunk@34205


git-svn-id: http://core.svn.wordpress.org/trunk@34169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 16:23:39 +00:00
Drew Jaynes
0a4bf88cc9 Docs: Update the hook doc summary for the wp_http_ixr_client_headers filter, introduced in [34164].
The idea is to try to reflect what the filterable value is rather than why it's filterable.

Fixes #24598.

Built from https://develop.svn.wordpress.org/trunk@34203


git-svn-id: http://core.svn.wordpress.org/trunk@34167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 16:16:43 +00:00
Scott Taylor
ff3ae0e747 Don't redirect to the Term list table after submitting the form on the Edit Term page.
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455.

Built from https://develop.svn.wordpress.org/trunk@34202


git-svn-id: http://core.svn.wordpress.org/trunk@34166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 15:59:42 +00:00
Scott Taylor
b07b68490f Allow get_lastpostdate(), get_lastpostmodified(), and _get_last_post_time() to accept $post_type and cache separately.
Props _duck, SergeyBiryukov.
See #17455.

Built from https://develop.svn.wordpress.org/trunk@34201


git-svn-id: http://core.svn.wordpress.org/trunk@34165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 15:25:31 +00:00
Scott Taylor
4a34994e54 Allow wp_page_menu() to accept 'walker', 'before', and 'after' to allow custom markup.
Fixes #11095.

Built from https://develop.svn.wordpress.org/trunk@34200


git-svn-id: http://core.svn.wordpress.org/trunk@34164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 15:06:30 +00:00
Scott Taylor
57d2420ae5 Similar to #33386, don't use guid when retrieving URL for a cropped header image in the Customizer.
Props polevaultweb.
Fixes #33319.

Built from https://develop.svn.wordpress.org/trunk@34188


git-svn-id: http://core.svn.wordpress.org/trunk@34156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 14:46:32 +00:00
Sergey Biryukov
80165bfc4a Comments: When setting the colspan value for inline edit/reply, make sure it's actually a table and the value is not empty.
Props afercia.
Fixes #33596.
Built from https://develop.svn.wordpress.org/trunk@34179


git-svn-id: http://core.svn.wordpress.org/trunk@34147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 13:44:34 +00:00
John Blackbourn
a5a8ae45a6 Remove outdated references to the preview_post_link filter docs.
See #24345
Props paulwilde

Built from https://develop.svn.wordpress.org/trunk@34178


git-svn-id: http://core.svn.wordpress.org/trunk@34146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 10:32:31 +00:00
John Blackbourn
541dbb2711 Remove the ability to view the post listing screen and post editing screen for post types with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_post_type()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu`, `show_in_nav_menus`, and `show_in_admin_bar` are `false`.

Fixes #33763
Props swissspidy, johnbillion

Built from https://develop.svn.wordpress.org/trunk@34177


git-svn-id: http://core.svn.wordpress.org/trunk@34145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 10:27:29 +00:00
John Blackbourn
caf90ec1c6 Improve the docblocks for the get_preview_post_link() function and the preview_post_link filter.
See #24345

Built from https://develop.svn.wordpress.org/trunk@34176


git-svn-id: http://core.svn.wordpress.org/trunk@34144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:25:25 +00:00
John Blackbourn
9cd91030a6 Correct the value of the preview query variable added by get_preview_post_link().
See #24345
Props kitchin

Built from https://develop.svn.wordpress.org/trunk@34175


git-svn-id: http://core.svn.wordpress.org/trunk@34143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:16:24 +00:00
John Blackbourn
fdb8400379 Place the filter docblock for http_api_transports immediately above the filter.
See #33413
Props dd32

Built from https://develop.svn.wordpress.org/trunk@34174


git-svn-id: http://core.svn.wordpress.org/trunk@34142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:12:25 +00:00
John Blackbourn
1bed706d27 Missed files from [34172].
See #33877

Built from https://develop.svn.wordpress.org/trunk@34173


git-svn-id: http://core.svn.wordpress.org/trunk@34141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:09:24 +00:00
John Blackbourn
ec0544e053 Initialise $_SERVER[ 'REMOTE_ADDR' ] during the test bootstrap so individual tests need not.
Fixes #33877
Fixes #25162

Built from https://develop.svn.wordpress.org/trunk@34172


git-svn-id: http://core.svn.wordpress.org/trunk@34140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 08:05:28 +00:00
Scott Taylor
ab6d1fa247 Use get_attached_file() in attachment_submitbox_metadata().
Props kitchin.
Fixes #33386.

Built from https://develop.svn.wordpress.org/trunk@34171


git-svn-id: http://core.svn.wordpress.org/trunk@34139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:18:25 +00:00
Scott Taylor
54829b6305 Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL.
Props TomHarrigan, wonderboymusic.
Fixes #24345.

Built from https://develop.svn.wordpress.org/trunk@34170


git-svn-id: http://core.svn.wordpress.org/trunk@34138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:15:25 +00:00