Gary Pendergast
4b1ff1c298
Media: Update the media bulk action labels for consistency.
...
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675 .
Built from https://develop.svn.wordpress.org/trunk@45147
git-svn-id: http://core.svn.wordpress.org/trunk@44956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:54:52 +00:00
Gary Pendergast
9292802d92
Twenty Seventeeen: Fix MediaElement control hover colours in the customiser.
...
When selecting custom colour schemes in the customiser, the hover colour is incorrectly applied to MediaElement controls.
Props xkon, ianbelanger.
Fixes #40843 .
Built from https://develop.svn.wordpress.org/trunk@45146
git-svn-id: http://core.svn.wordpress.org/trunk@44955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:38:51 +00:00
Gary Pendergast
5b8db48734
Site Health: Remove animated ellipsis from the status loading indicator.
...
This animation wasn't particularly reliable across browsers.
Props Clorith, afercia.
Fixes #46684 .
Built from https://develop.svn.wordpress.org/trunk@45145
git-svn-id: http://core.svn.wordpress.org/trunk@44954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:29:51 +00:00
Gary Pendergast
8c8c1f8984
Widgets: Add rel="noopener noreferrer"
to links with target="_blank"
in the Image widget.
...
Props audrasjb, welcher, afercia.
Fixes #43280 .
Built from https://develop.svn.wordpress.org/trunk@45144
git-svn-id: http://core.svn.wordpress.org/trunk@44953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:23:51 +00:00
Gary Pendergast
822e8b1a95
Widgets: Add rel="noopener noreferrer"
to links with target="_blank"
in the Text and HTML widgets.
...
Props audrasjb, birgire, mukesh27.
Fixes #46421 .
Built from https://develop.svn.wordpress.org/trunk@45143
git-svn-id: http://core.svn.wordpress.org/trunk@44952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:18:52 +00:00
Gary Pendergast
f584cc2f67
Privacy: Remove the privacy changes bubble.
...
This notification was a little too intrustive, and suffered from being difficult to dismiss.
Props garrett-eclipse, xkon, ianbelanger.
Fixes #46819 .
Built from https://develop.svn.wordpress.org/trunk@45142
git-svn-id: http://core.svn.wordpress.org/trunk@44951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:12:51 +00:00
Gary Pendergast
a932e9921b
Menus: Add rel="noopener"
to target="_blank"
links by default in menus.
...
This expands upon `rel="noopener"` being previously added to links in the content.
Props audrasjb, welcher.
Fixes #43290 .
Built from https://develop.svn.wordpress.org/trunk@45141
git-svn-id: http://core.svn.wordpress.org/trunk@44950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:06:52 +00:00
Gary Pendergast
4487551344
Help: Update support forum links.
...
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/ .
Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790 .
Built from https://develop.svn.wordpress.org/trunk@45140
git-svn-id: http://core.svn.wordpress.org/trunk@44949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 22:59:56 +00:00
Gary Pendergast
affceae936
Blocks: Allow for nested the_content
calls within do_blocks()
.
...
When `do_blocks()` is run, it sets up some special handling of the `wpautop` filter, as we don't want `wpautop` to run on block content, but we do want it to be available for subsequent runs of `the_content`, which may be happening on non-block content.
As we set this up before rendering dynamic blocks, however, a dynamic block choosing to run `the_content` will cause unintentially structural deficiences in this particular recursive block tower.
Moving this handling to after dynamic blocks are rendered makes our tower lean a little less.
Props aldavigdis, pento.
Fixes #45495 .
Built from https://develop.svn.wordpress.org/trunk@45139
git-svn-id: http://core.svn.wordpress.org/trunk@44948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 06:54:54 +00:00
Gary Pendergast
95df8fa792
Block Editor: Update packages to bring a selection of bugfixes in.
...
Props iseulde, kjellr, aduth, 0mirka00, mcsf, nosolosw, gziolo, jasmussen, talldanwp, notnownikki, swissspidy, jorgefilipecosta, noisysocks.
See https://github.com/WordPress/gutenberg/pull/14796 .
Fixes #46801 .
Built from https://develop.svn.wordpress.org/trunk@45138
git-svn-id: http://core.svn.wordpress.org/trunk@44947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 06:37:57 +00:00
Gary Pendergast
9a80e2095b
Text Changes: Tweak the wording of email notification subjects.
...
This change brings more coherence between the subject lines of the various emails WordPress will send.
Props ramiy, pento.
Fixes #37940 .
Built from https://develop.svn.wordpress.org/trunk@45137
git-svn-id: http://core.svn.wordpress.org/trunk@44946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 06:17:51 +00:00
Gary Pendergast
f6128eb7e6
Post Formats: Remove the post format icons from the post list table.
...
Props mukesh27, melchoyce, karmatosed, afercia, mapk.
Fixes #46591 .
Built from https://develop.svn.wordpress.org/trunk@45136
git-svn-id: http://core.svn.wordpress.org/trunk@44945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 06:04:50 +00:00
Gary Pendergast
cbdffc4a1e
HTTP: Add support for the host-only
flag to Wp_Http_Cookie
.
...
Props soulseekah.
Fixes #43231 .
Built from https://develop.svn.wordpress.org/trunk@45135
git-svn-id: http://core.svn.wordpress.org/trunk@44944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 05:32:51 +00:00
Gary Pendergast
a125989772
Emoji: Update Twemoji to version 12.0.0.
...
Props pento, superpoincare.
Fixes #46404 , #46805 .
Built from https://develop.svn.wordpress.org/trunk@45134
git-svn-id: http://core.svn.wordpress.org/trunk@44943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 05:22:51 +00:00
Gary Pendergast
625d1694a3
Canonical: Ensure redirect query keys are URL encoded.
...
This prevents an infinite redirect loop when a request containing URL-encoded characters triggers `is_404()`.
Props soulseekah, wrwrwr0.
Fixes #43745 .
Built from https://develop.svn.wordpress.org/trunk@45133
git-svn-id: http://core.svn.wordpress.org/trunk@44942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 01:10:55 +00:00
Sergey Biryukov
965941ab3a
Twenty Nineteen: Fix inconsistent tab/space indentation in style files.
...
Props iamdmitrymayorov, mukesh27.
Fixes #46821 .
Built from https://develop.svn.wordpress.org/trunk@45132
git-svn-id: http://core.svn.wordpress.org/trunk@44941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 06:18:51 +00:00
Sergey Biryukov
78340f315d
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/color-picker.css
.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45131
git-svn-id: http://core.svn.wordpress.org/trunk@44940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:54:50 +00:00
Sergey Biryukov
c33b18b721
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/about.css
.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45130
git-svn-id: http://core.svn.wordpress.org/trunk@44939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:51:51 +00:00
Sergey Biryukov
7eafd6d81a
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/customize-nav-menus.css
.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45129
git-svn-id: http://core.svn.wordpress.org/trunk@44938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:49:51 +00:00
Sergey Biryukov
7eecc96e2d
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/site-health.css
.
...
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45128
git-svn-id: http://core.svn.wordpress.org/trunk@44937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:44:50 +00:00
Sergey Biryukov
7639acc7b7
Docs: Fix typo in a comment in editor/dfw.js
.
...
Props garrett-eclipse, mattnyeus.
Fixes #46485 .
Built from https://develop.svn.wordpress.org/trunk@45127
git-svn-id: http://core.svn.wordpress.org/trunk@44936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:39:50 +00:00
Sergey Biryukov
94b3dcc605
Bundled Themes: Link to an updated documentation on post thumbnails on developer.wordpress.org, instead of Codex.
...
Props samanehmirrajabi.
Fixes #46823 .
Built from https://develop.svn.wordpress.org/trunk@45126
git-svn-id: http://core.svn.wordpress.org/trunk@44935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-07 05:23:51 +00:00
John Blackbourn
9ab303dbdf
Bootstrap/Load: Ignore wp-content/fatal-error-handler.php
and wp-content/php-error.php
from version control.
...
See #44458
Built from https://develop.svn.wordpress.org/trunk@45125
git-svn-id: http://core.svn.wordpress.org/trunk@44934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 18:43:51 +00:00
Sergey Biryukov
3215ab96ce
Twenty Twelve: Correct linear-gradient
direction argument syntax.
...
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.
Props: ianbelanger, joyously, man4toman.
Fixes #46786 .
Built from https://develop.svn.wordpress.org/trunk@45124
git-svn-id: http://core.svn.wordpress.org/trunk@44933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:17:50 +00:00
Sergey Biryukov
95d13df56d
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/nav-menus.css
.
...
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45123
git-svn-id: http://core.svn.wordpress.org/trunk@44932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:10:51 +00:00
Sergey Biryukov
5810543816
PHPCS: Fix WPCS violation in [45119].
...
See #46809 .
Built from https://develop.svn.wordpress.org/trunk@45122
git-svn-id: http://core.svn.wordpress.org/trunk@44931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:02:52 +00:00
Sergey Biryukov
80e638ad0e
Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.
...
Props Clorith, earnjam.
Fixes #46789 .
Built from https://develop.svn.wordpress.org/trunk@45121
git-svn-id: http://core.svn.wordpress.org/trunk@44930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 16:00:51 +00:00
Sergey Biryukov
d36c01909a
Site Health: Use a consistent heading and description when referring to Info and Status pages.
...
Props chetan200891, afercia.
Fixes #46728 .
Built from https://develop.svn.wordpress.org/trunk@45120
git-svn-id: http://core.svn.wordpress.org/trunk@44929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 15:42:52 +00:00
Sergey Biryukov
4d3fb9b22b
Site Health: Restore backticks in "Copy to clipboard" functionality, accidentally removed in [45044].
...
The backticks ensure that the data is formatted accordingly on pasting whenever possible.
Props Clorith.
Fixes #46809 .
Built from https://develop.svn.wordpress.org/trunk@45119
git-svn-id: http://core.svn.wordpress.org/trunk@44928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 15:36:51 +00:00
Sergey Biryukov
a431028795
Site Health: Display a correct error message for a failing request in wp_version_check()
test.
...
Props Clorith, axaak.
Fixes #46814 .
Built from https://develop.svn.wordpress.org/trunk@45118
git-svn-id: http://core.svn.wordpress.org/trunk@44927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-06 15:28:50 +00:00
Felix Arntz
5754da106b
Administration: Improve user experience and clarify when in recovery mode.
...
This changeset introduces several changes around usability when recovery mode is active:
* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.
Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608 .
Built from https://develop.svn.wordpress.org/trunk@45117
git-svn-id: http://core.svn.wordpress.org/trunk@44926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 17:00:52 +00:00
Felix Arntz
52354f3f0b
Bootstrap/Load: Do not redefine constants because tests don't like it.
...
See #46045 .
Built from https://develop.svn.wordpress.org/trunk@45116
git-svn-id: http://core.svn.wordpress.org/trunk@44925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 15:53:50 +00:00
Felix Arntz
5d2c761568
Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated.
...
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.
Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812 .
Built from https://develop.svn.wordpress.org/trunk@45115
git-svn-id: http://core.svn.wordpress.org/trunk@44924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 15:33:52 +00:00
Felix Arntz
6d58109b09
Bootstrap/Load: Ensure WP_Fatal_Error_Handler
does not conflict with existing mechanisms treating fatal errors.
...
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.
Furthermore this applies to breaking a plugin or theme when editing from the backend.
Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045 , #46751 .
Built from https://develop.svn.wordpress.org/trunk@45114
git-svn-id: http://core.svn.wordpress.org/trunk@44923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 15:20:55 +00:00
Pascal Birchler
ec05cd3168
Site Health: Remove unused $wp_config_path
variable.
...
Discovered and fixed during WordCamp London 2019 contributor day.
Props m_uysl.
Fixes #46808 .
Built from https://develop.svn.wordpress.org/trunk@45113
git-svn-id: http://core.svn.wordpress.org/trunk@44922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 11:09:51 +00:00
tellyworth
23fe2800cc
Upgrade/Install: Add more context in signature verify failures.
...
This includes version numbers and signature counts in error reports, to help diagnose isolated failures that have no apparent cause.
Props dd32.
See #39309 .
Built from https://develop.svn.wordpress.org/trunk@45112
git-svn-id: http://core.svn.wordpress.org/trunk@44921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-05 05:20:51 +00:00
Andrew Ozz
4601e178e5
Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0.
...
Fixes #46645 .
Built from https://develop.svn.wordpress.org/trunk@45111
git-svn-id: http://core.svn.wordpress.org/trunk@44920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-04 21:54:53 +00:00
desrosj
adbaba7d56
Site Health: Ensure the user locale is listed in debug information.
...
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.
Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/
Props: Clorith, desrosj.
Fixes #46694 .
Built from https://develop.svn.wordpress.org/trunk@45110
git-svn-id: http://core.svn.wordpress.org/trunk@44919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-04 21:24:52 +00:00
desrosj
fc2c675582
Twenty Eleven: Correct linear-gradient
direction argument syntax.
...
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.
Props: ianbelanger, Malae, man4toman.
Fixes #46770 .
Built from https://develop.svn.wordpress.org/trunk@45109
git-svn-id: http://core.svn.wordpress.org/trunk@44918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-04 18:26:52 +00:00
Sergey Biryukov
4ee7d453fa
Site Health: Use wp_get_upload_dir()
instead of wp_upload_dir()
, remove duplicate call.
...
Props m_uysl.
Fixes #46729 .
Built from https://develop.svn.wordpress.org/trunk@45108
git-svn-id: http://core.svn.wordpress.org/trunk@44917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 11:20:51 +00:00
Sergey Biryukov
991eb4258d
Site Health: Use correct property for database-related messages.
...
Props mukesh27, birgire.
Fixes #46783 .
Built from https://develop.svn.wordpress.org/trunk@45107
git-svn-id: http://core.svn.wordpress.org/trunk@44916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 11:01:53 +00:00
Sergey Biryukov
ef948cbfd6
PHPCS: Fix WPCS violations in [45104].
...
See #46645 .
Built from https://develop.svn.wordpress.org/trunk@45106
git-svn-id: http://core.svn.wordpress.org/trunk@44915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 02:14:51 +00:00
Sergey Biryukov
5d0bd0ec47
Site Health: Use a consistent verbiage for the suggestion to remove inactive plugins and themes.
...
Props garrett-eclipse, marybaum, Clorith.
Fixes #46735 .
Built from https://develop.svn.wordpress.org/trunk@45105
git-svn-id: http://core.svn.wordpress.org/trunk@44914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-03 02:01:51 +00:00
Andrew Ozz
2cdc22aded
Site health:
...
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.
Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645 .
Built from https://develop.svn.wordpress.org/trunk@45104
git-svn-id: http://core.svn.wordpress.org/trunk@44913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 23:33:53 +00:00
Sergey Biryukov
1909df67a7
Docs: Remove an empty line between @param
and @return
in the tests added in [45101], per documentation coding standards.
...
See #45029 .
Built from https://develop.svn.wordpress.org/trunk@45103
git-svn-id: http://core.svn.wordpress.org/trunk@44912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:22:50 +00:00
Sergey Biryukov
0c92764023
Site Health: Use an established pattern for numbered placeholders in translator comments in WP_Debug_Data
.
...
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45102
git-svn-id: http://core.svn.wordpress.org/trunk@44911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:18:52 +00:00
Sergey Biryukov
cbbe38c09c
Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema
filter are not overridden by subclasses.
...
Add unit tests missed in [45100].
Props Toro_Unit, birgire.
See #45029 .
Built from https://develop.svn.wordpress.org/trunk@45101
git-svn-id: http://core.svn.wordpress.org/trunk@44910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:15:51 +00:00
Sergey Biryukov
2931a2d95e
Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema
filter are not overridden by subclasses.
...
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.
Props Toro_Unit, birgire.
Fixes #45029 .
Built from https://develop.svn.wordpress.org/trunk@45100
git-svn-id: http://core.svn.wordpress.org/trunk@44909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:13:52 +00:00
Sergey Biryukov
f7357d3957
Site Health: i18n audit, take 1.
...
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.
Props ocean90, SergeyBiryukov.
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45099
git-svn-id: http://core.svn.wordpress.org/trunk@44908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 21:32:53 +00:00
Sergey Biryukov
5291f46c8a
Docs: Fix typo in a comment in unzip_file()
.
...
Props mukesh27.
Fixes #46766 .
Built from https://develop.svn.wordpress.org/trunk@45098
git-svn-id: http://core.svn.wordpress.org/trunk@44907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 13:34:53 +00:00