Commit Graph

97 Commits

Author SHA1 Message Date
Drew Jaynes
22adda2aa0 Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation.
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.

Props ramiy.
See #37748.

Built from https://develop.svn.wordpress.org/trunk@38307


git-svn-id: http://core.svn.wordpress.org/trunk@38248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 18:25:31 +00:00
Aaron Jorbin
b3b32f22a1 Updates: Improve experience for Bulk Actions when FTP is dismissed.
Before this change, when a bulk update was canceled due dismissing the FTP credentials modal, part of the actions didn't get canceled.  This meant the "There is a new version of…” notices become blank and the updates you had checked became unchecked.  Now, the notices remain and you are essentially returned to the screen you had before. Strings are also updated to improve ARIA usage.

Fixes #37563.
Props ocean90, swissspidy, obenland, afercia.


Built from https://develop.svn.wordpress.org/trunk@38221


git-svn-id: http://core.svn.wordpress.org/trunk@38162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-09 01:14:28 +00:00
Dominik Schilling
868804db15 Plugins: Improve Ajax search of new plugins.
Fixes a few accessibility issues, restores the "Search Results" tab and the search type selector, and improves compatibility with older browsers.

Props rahulsprajapati, swissspidy, adamsilverstein, ocean90
See #37233.
Built from https://develop.svn.wordpress.org/trunk@38119


git-svn-id: http://core.svn.wordpress.org/trunk@38060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-20 16:32:31 +00:00
Sergey Biryukov
0be3a84ad0 I18N: After [38057], consistently use a context for other instances of Activate %s, Network Activate %s, and Delete %s strings.
See #37290.
Built from https://develop.svn.wordpress.org/trunk@38071


git-svn-id: http://core.svn.wordpress.org/trunk@38012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-16 23:20:29 +00:00
Konstantin Obenland
8c82515ab6 Update/Install: Shiny Updates v2.
Gone are the days of isolation and feelings of "meh", brought on by The Bleak Screen of Sadness. For a shiny knight has arrived to usher our plugins and themes along their arduous journey of installation, updates, and the inevitable fate of ultimate deletion.

Props swissspidy, adamsilverstein, mapk, afragen, ocean90, ryelle, j-falk, michael-arestad, melchoyce, DrewAPicture, AdamSoucie, ethitter, pento, dd32, kraftbj, Ipstenu, jorbin, afercia, stephdau, paulwilde, jipmoors, khag7, svovaf, jipmoors, obenland.
Fixes #22029, #25828, #31002, #31529, #31530, #31773, #33637, #35032.


Built from https://develop.svn.wordpress.org/trunk@37714


git-svn-id: http://core.svn.wordpress.org/trunk@37680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-15 16:37:29 +00:00
Drew Jaynes
c3055cc190 Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37488


git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:01:30 +00:00
Aaron Jorbin
bd7ffca854 Add Nonce to updating wporg_favorites user meta field
Built from https://develop.svn.wordpress.org/trunk@37145


git-svn-id: http://core.svn.wordpress.org/trunk@37112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 18:36:26 +00:00
Andrea Fercia
fd1f45a7cf Accessibility: Improve accessibility for the Plugin details modal.
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.
Built from https://develop.svn.wordpress.org/trunk@36964


git-svn-id: http://core.svn.wordpress.org/trunk@36932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:37:26 +00:00
Andrea Fercia
ecdcae565e Plugins: Remove an unused variable after [35953].
Fixes #35050.
Built from https://develop.svn.wordpress.org/trunk@36581


git-svn-id: http://core.svn.wordpress.org/trunk@36548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-18 21:33:25 +00:00
Dominik Schilling
8b781dfaa7 Updates: Prevent further actions if an update button is disabled.
Props adamsilverstein, afercia.
Fixes #35257.
Built from https://develop.svn.wordpress.org/trunk@36558


git-svn-id: http://core.svn.wordpress.org/trunk@36525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-17 19:42:26 +00:00
Pascal Birchler
ded3a1d72f Plugins: Make sure the 'Beta testing' tab is first in the plugin installer.
This makes feature plugins more discoverable for people running development builds.

Fixes #29631.
Built from https://develop.svn.wordpress.org/trunk@36297


git-svn-id: http://core.svn.wordpress.org/trunk@36264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 09:07:26 +00:00
Sergey Biryukov
7270205975 Remove redundant title attribute from wp_star_rating(). Hide the visible number of ratings from assistive technologies.
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.

Props afercia.
Fixes #35141.
Built from https://develop.svn.wordpress.org/trunk@36092


git-svn-id: http://core.svn.wordpress.org/trunk@36057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 00:48:27 +00:00
Andrea Fercia
c69481a410 Accessibility: Remove title attributes from the Plugin Cards on the Plugin install screen.
Fixes #35050.
Built from https://develop.svn.wordpress.org/trunk@35953


git-svn-id: http://core.svn.wordpress.org/trunk@35917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 22:33:28 +00:00
Drew Jaynes
8a386cb24f Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35241


git-svn-id: http://core.svn.wordpress.org/trunk@35207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 15:13:25 +00:00
Andrea Fercia
6ec8174ca1 Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.
Fixes #33818.
Built from https://develop.svn.wordpress.org/trunk@35009


git-svn-id: http://core.svn.wordpress.org/trunk@34974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:17:26 +00:00
Scott Taylor
0c2b2a0e3d List Tables/WP_Screen: in WP_Screen, add methods to store, retrieve, and render screen reader text, primarily used by list table screens.
These additions are based on an audit and recommendations by the Accessibility team. #a11y'all

Props afercia.
Fixes #32147.

Built from https://develop.svn.wordpress.org/trunk@34891


git-svn-id: http://core.svn.wordpress.org/trunk@34856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 01:28:25 +00:00
Scott Taylor
da1c938a5c Plugins: on the Install page, move the name of each plugin into the <h4> to accommodate screen readers.
Props afercia, ChrisMKindred.
Fixes #32400.

Built from https://develop.svn.wordpress.org/trunk@34760


git-svn-id: http://core.svn.wordpress.org/trunk@34725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 04:16:27 +00:00
Scott Taylor
f9c2a88a8a List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.
Props wonderboymusic, Viper007Bond.
Fixes #21249.

Built from https://develop.svn.wordpress.org/trunk@34383


git-svn-id: http://core.svn.wordpress.org/trunk@34347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 06:06:25 +00:00
Scott Taylor
6a08b00632 Add @access annotations to methods that have no doc block in wp-admin/includes/*.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:32:24 +00:00
Scott Taylor
c6a4512b1b Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor
b56b9b3e5c Add @global annotations for wp-admin/*.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Dion Hulse
02403eadd1 Plugins Browser: Replace the download count with the number of Active installs of the plugin.
Fixes #31865

Built from https://develop.svn.wordpress.org/trunk@31990


git-svn-id: http://core.svn.wordpress.org/trunk@31969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 23:49:27 +00:00
Aaron Jorbin
3ac2f91922 Update aria-label when doing a shiny plugin update
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails

props mehulkaklotar, afercia
Fixes #31722



Built from https://develop.svn.wordpress.org/trunk@31982


git-svn-id: http://core.svn.wordpress.org/trunk@31961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 05:31:26 +00:00
Dion Hulse
cc903c3422 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121

Built from https://develop.svn.wordpress.org/trunk@31862


git-svn-id: http://core.svn.wordpress.org/trunk@31841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 02:14:27 +00:00
Gary Pendergast
9c69213f2b Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820


Built from https://develop.svn.wordpress.org/trunk@31333


git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 04:19:23 +00:00
Drew Jaynes
d41e669efe Ensure the correct list of default tabs for the Plugin Install screen are documented.
Props stevenkword.
Fixes #31017.

Built from https://develop.svn.wordpress.org/trunk@31244


git-svn-id: http://core.svn.wordpress.org/trunk@31225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:44:22 +00:00
Scott Taylor
71f9bc3f42 Add a private field to WP_Plugin_Install_List_Table, $error.
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31164


git-svn-id: http://core.svn.wordpress.org/trunk@31145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:19:22 +00:00
Scott Taylor
e029005847 Access Modifiers:
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31078


git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:44:23 +00:00
Sergey Biryukov
483e7a36d7 Use localized format for Last Updated date on Add Plugins screen.
props tyxla.
fixes #30717.
Built from https://develop.svn.wordpress.org/trunk@31055


git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 01:03:23 +00:00
Andrew Ozz
a445806c6f Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337.
Built from https://develop.svn.wordpress.org/trunk@30782


git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:40:24 +00:00
Scott Taylor
65ab522a51 Improve various @param docs for List Tables.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30679


git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 00:33:23 +00:00
Drew Jaynes
78bb3e5ff5 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30648


git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:28:24 +00:00
Dominik Schilling
197f0a30a4 Plugin search: Wrap results in a form to fix pagination's paged input field.
props jesin, ocean90.
see #18724, for trunk.
Built from https://develop.svn.wordpress.org/trunk@29829


git-svn-id: http://core.svn.wordpress.org/trunk@29594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-03 13:08:16 +00:00
Sergey Biryukov
9bf3007b55 Remove unnecessary CSS overriding on Add Plugins screen.
props pavelevap.
fixes #29753.
Built from https://develop.svn.wordpress.org/trunk@29775


git-svn-id: http://core.svn.wordpress.org/trunk@29547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-28 20:26:17 +00:00
Helen Hou-Sandí
433210a907 Plugin install: Better styling to accommodate plugin icons.
fixes #29466.

Built from https://develop.svn.wordpress.org/trunk@29679


git-svn-id: http://core.svn.wordpress.org/trunk@29454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 19:47:16 +00:00
Andrew Nacin
683238567d Plugin install: The sort callback doesn't need to be public.
props helen.
fixes #28673.

Built from https://develop.svn.wordpress.org/trunk@29666


git-svn-id: http://core.svn.wordpress.org/trunk@29440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 06:51:16 +00:00
Andrew Nacin
69204000ca Adjust [29634] so the Upload Plugin button can be shown. see #29236.
Built from https://develop.svn.wordpress.org/trunk@29637


git-svn-id: http://core.svn.wordpress.org/trunk@29411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 02:59:16 +00:00
Andrew Nacin
8f6fbcdc52 Plugin installer: Minor adjustments to aid with discovery.
fixes #29387.

Built from https://develop.svn.wordpress.org/trunk@29636


git-svn-id: http://core.svn.wordpress.org/trunk@29410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 02:53:16 +00:00
Andrew Nacin
ac3dd27737 Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters.
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.

Built from https://develop.svn.wordpress.org/trunk@29634


git-svn-id: http://core.svn.wordpress.org/trunk@29408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-27 01:32:18 +00:00
Helen Hou-Sandí
b1b7d5f3a2 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.

Built from https://develop.svn.wordpress.org/trunk@29597


git-svn-id: http://core.svn.wordpress.org/trunk@29371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 16:03:16 +00:00
Sergey Biryukov
b06652da92 Install Plugins: Don't wp_die() if API can't be reached.
props johnbillion.
fixes #29361.
Built from https://develop.svn.wordpress.org/trunk@29594


git-svn-id: http://core.svn.wordpress.org/trunk@29368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:02:17 +00:00
Andrew Nacin
bb4db92621 Plugin install: Add icons to compatible/incompatible. see #29313.
Built from https://develop.svn.wordpress.org/trunk@29586


git-svn-id: http://core.svn.wordpress.org/trunk@29360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:26:15 +00:00
Dominik Schilling
49937c88f9 Plugin compatibility is based on your version of WordPress, not your install.
fixes #29313.
Built from https://develop.svn.wordpress.org/trunk@29581


git-svn-id: http://core.svn.wordpress.org/trunk@29355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:14:16 +00:00
Andrew Nacin
0eed9373e2 Introduce plugin icons in the installer.
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.

Built from https://develop.svn.wordpress.org/trunk@29569


git-svn-id: http://core.svn.wordpress.org/trunk@29343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-21 19:11:17 +00:00
Dominik Schilling
1f20c88b68 Plugin install: Remove columns and screen options.
fixes #28803.
Built from https://develop.svn.wordpress.org/trunk@29498


git-svn-id: http://core.svn.wordpress.org/trunk@29276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-15 09:38:15 +00:00
Sergey Biryukov
aed71de2d6 Plugin install: Make plugin groups translatable.
props ocean90 for initial patch.
fixes #29092.
Built from https://develop.svn.wordpress.org/trunk@29477


git-svn-id: http://core.svn.wordpress.org/trunk@29255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 02:31:18 +00:00
Drew Jaynes
647b6d907b Clean up some missing @access tags and other tweaks for 4.0.0-functionality docs.
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29455


git-svn-id: http://core.svn.wordpress.org/trunk@29233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-09 19:32:16 +00:00
Scott Taylor
320ba69cf7 After [29201], use aria-label instead of aria-labelledby in WP_Plugin_Install_List_Table::display_rows().
Props nvwd, DrewAPicture.
Fixes #28853.

Built from https://develop.svn.wordpress.org/trunk@29424


git-svn-id: http://core.svn.wordpress.org/trunk@29202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 02:56:15 +00:00
Dominik Schilling
410ca0a29c Plugin install: Improve styling of the no results message.
see #28753.
Built from https://develop.svn.wordpress.org/trunk@29359


git-svn-id: http://core.svn.wordpress.org/trunk@29135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 15:24:16 +00:00
Dominik Schilling
9a9b1791ca Add some braces to [29225].
see #28673.
Built from https://develop.svn.wordpress.org/trunk@29350


git-svn-id: http://core.svn.wordpress.org/trunk@29127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 21:04:15 +00:00