Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-10-29 23:09:44 +01:00
Code Issues Projects Releases Wiki Activity
48,190 Commits 50 Branches 747 Tags 780 MiB
b80ce60f70
Commit Graph

27 Commits

Author SHA1 Message Date
Sergey Biryukov
b80ce60f70 Coding Standards: Use pre-increment/decrement for stand-alone statements. 
Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:
* [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators]
* [https://github.com/WordPress/WordPress-Coding-Standards/pull/2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators]

Props jrf.
See #59161, #58831.
Built from https://develop.svn.wordpress.org/trunk@56549


git-svn-id: http://core.svn.wordpress.org/trunk@56061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2023-09-09 09:28:26 +00:00
Sergey Biryukov
803426a023 Coding Standards: Use strict comparison in bundled themes' PHP files. 
This addresses all the remaining WPCS warnings in bundled themes.

Includes using the correct type when checking the number of comments, as `get_comments_number()` returns a numeric string, not an integer.

Follow-up to [41285], [44562], [47941].

Props aristath, poena, afercia, SergeyBiryukov.
See #56791.
Built from https://develop.svn.wordpress.org/trunk@55420


git-svn-id: http://core.svn.wordpress.org/trunk@54953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2023-02-24 06:23:23 +00:00
audrasjb
30e6820f0e Twenty Ten: Fixes brace indentation in loop-attachment template. 
Props mukesh27.
See #57210, #56791.

Built from https://develop.svn.wordpress.org/trunk@54882


git-svn-id: http://core.svn.wordpress.org/trunk@54434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2022-11-26 22:03:11 +00:00
audrasjb
84729259de Twenty Ten: Escape get_author_posts_url() where appropriate in functions.php file. 
This changeset adds missing escaping to some instances of `get_author_posts_url()` used in Twenty Ten, as per WordPress Coding Standards.

Props hztyfoon, robinwpdeveloper, mukesh27, rudlinkon, SergeyBiryukov, jakariaistauk.
Fixes #56674.

Built from https://develop.svn.wordpress.org/trunk@54344


git-svn-id: http://core.svn.wordpress.org/trunk@53903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2022-09-28 12:40:15 +00:00
Sergey Biryukov
64b193980a Bundled Themes: Remove redundant semicolons after closing curly brackets. 
Includes a few minor indentation fixes.

Props jrf.
See #53359.
Built from https://develop.svn.wordpress.org/trunk@51553


git-svn-id: http://core.svn.wordpress.org/trunk@51164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2021-08-05 13:25:58 +00:00
Sergey Biryukov
e4dfced545 Twenty Ten: Correct $post_title variable name in loop-attachment.php. 
Follow-up to [45609] / #47632.

Props sabernhardt.
Fixes #52121.
Built from https://develop.svn.wordpress.org/trunk@49840


git-svn-id: http://core.svn.wordpress.org/trunk@49559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-12-19 20:45:05 +00:00
Sergey Biryukov
a2d42351c5 Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 
Standardize on "Go to..." as a more appropriate option for most cases.

Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes #47235.
Built from https://develop.svn.wordpress.org/trunk@49539


git-svn-id: http://core.svn.wordpress.org/trunk@49277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 10:53:10 +00:00
Sergey Biryukov
1f85e7484f Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards. 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@48782


git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-08-11 00:34:08 +00:00
Sergey Biryukov
001ffe81fb Docs: Improve inline comments per the documentation standards. 
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:45:18 +00:00
Sergey Biryukov
e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation. 
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-03 00:41:05 +00:00
Sergey Biryukov
ac10f9b9e4 Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article. 
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45675


git-svn-id: http://core.svn.wordpress.org/trunk@45486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 22:46:55 +00:00
Gary Pendergast
c71bc1513e Coding Standards: Add missing translator comments to the default themes. 
All default themes now have translator comments for all strings with placeholders!

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45609


git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 01:10:00 +00:00
Sergey Biryukov
37f04694d5 Bundled Themes: Use consistent HTML comments after closing HTML tags. 
Props iamdmitrymayorov.
Fixes #46871.
Built from https://develop.svn.wordpress.org/trunk@45209


git-svn-id: http://core.svn.wordpress.org/trunk@45018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 01:30:53 +00:00
Aaron Jorbin
71cf332e65 Replace usages of basename() with wp_basename() in order to support multibyte filenames 
This is focused on the pieces of code that touch media files and the tests that support them. `basename` isn't multibyte compatible out of the box. See http://php.net/basename and https://bugs.php.net/bug.php?id=62119.

See #43170.
Props Viper007Bond.

Built from https://develop.svn.wordpress.org/trunk@44785


git-svn-id: http://core.svn.wordpress.org/trunk@44617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-01 20:58:52 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Dominik Schilling
64fc7294b6 Use HTTPS URLs for codex.wordpress.org. 
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-12 21:29:32 +00:00
Lance Willett
ff5628169e Twenty Ten: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31266


git-svn-id: http://core.svn.wordpress.org/trunk@31247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-22 00:42:44 +00:00
Sergey Biryukov
fd16ae485b Avoid a PHP notice in bundled themes if no images were found. 
props nabil_kadimi.
fixes #28361.
Built from https://develop.svn.wordpress.org/trunk@28585


git-svn-id: http://core.svn.wordpress.org/trunk@28410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 10:55:30 +00:00
Lance Willett
9e869b472f Twenty Ten: correct attribute escaping in the attachment template. Props philiparthurmoore, see #28251. 
Built from https://develop.svn.wordpress.org/trunk@28463


git-svn-id: http://core.svn.wordpress.org/trunk@28290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 22:44:15 +00:00
Lance Willett
6268f714e0 Twenty Ten: update code comments to reflect WP inline docs standards. Props DrewAPicture, closes #25256. 
Built from https://develop.svn.wordpress.org/trunk@25627


git-svn-id: http://core.svn.wordpress.org/trunk@25544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-25 17:04:10 +00:00
ryan
9f5c80eb92 Use one space, not two, after trailing punctuation. Prop Zeo. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-16 17:13:16 +00:00
ryan
dd64f17ab7 More consistent attribute escaping. Props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-10 19:18:51 +00:00
azaozz
853d1ab1a2 Implement rel="author" in Twenty Eleven and Twenty Ten, props joostdevalk, fixes #17722 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-08 02:02:09 +00:00
nacin
73b17f9ef0 Add twentyten_attachment_height filter. props lancewillett, fixes #14402. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-15 01:12:00 +00:00
nacin
27cb70434a Twenty Ten code cleanups. props lancewillett, fixes #15476. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-19 05:37:47 +00:00
nacin
e4d81b8e9a Use get_template_part() for single.php, attachment.php, page.php, and our page template in Twenty Ten. Introduces loop-page/single/attachment.php. props koopersmith, fixes #15078. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-09 09:17:42 +00:00