Sergey Biryukov
ac434b5c39
Pass $post to 'protected_title_format' and 'private_title_format' filters.
...
props johnjamesjacoby, DrewAPicture.
fixes #23724 .
Built from https://develop.svn.wordpress.org/trunk@28571
git-svn-id: http://core.svn.wordpress.org/trunk@28396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-24 06:48:16 +00:00
Drew Jaynes
3e0521c2cf
Add inline documentation for the option_none_value
argument added to wp_dropdown_users|categories()
in [28564].
...
Fixes #16625 .
Built from https://develop.svn.wordpress.org/trunk@28570
git-svn-id: http://core.svn.wordpress.org/trunk@28395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-24 05:39:15 +00:00
Drew Jaynes
a1955d78ee
Use three-digit x.x.x style version for @deprecated
phpDoc tags.
...
See #18298 .
Built from https://develop.svn.wordpress.org/trunk@28569
git-svn-id: http://core.svn.wordpress.org/trunk@28394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-24 05:23:14 +00:00
Andrew Ozz
f7186fb198
TinyMCE: update to 4.0.26. Includes fixes for the 'paste' plugin (paste from Word/Excel, paste in WebKit/Blink), show/hide/isHidden in inline mode, drag/drop in tables and in Safari, and others. Fixes #28342 , #28016 , #28250 and #28067
...
Built from https://develop.svn.wordpress.org/trunk@28568
git-svn-id: http://core.svn.wordpress.org/trunk@28393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-24 01:44:15 +00:00
Andrew Ozz
8bc84c0441
wpView: fix selecting a view's text string in Safari, props gcorne, fixes #28088
...
Built from https://develop.svn.wordpress.org/trunk@28565
git-svn-id: http://core.svn.wordpress.org/trunk@28391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 20:56:14 +00:00
Scott Taylor
53ea68e838
wp_dropdown_pages()
allows option_none_value
to be passed. Add that arg to the $defaults
for wp_dropdown_users()
and wp_dropdown_categories()
as well.
...
Props solarissmoke.
Fixes #16625 .
Built from https://develop.svn.wordpress.org/trunk@28564
git-svn-id: http://core.svn.wordpress.org/trunk@28390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 20:47:15 +00:00
Scott Taylor
b75c79500b
Replaces all uses of TEMPLATEPATH
and STYLESHEETPATH
in core with get_template_directory()
and get_stylesheet_directory()
.
...
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.
Props obenland, aaroncampbell.
Fixes #18298 .
Built from https://develop.svn.wordpress.org/trunk@28563
git-svn-id: http://core.svn.wordpress.org/trunk@28389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 20:12:15 +00:00
Scott Taylor
44c4b365a0
When adding queries to tax_query
: if the query's field
is term_taxonomy_id
, don't require taxonomy
to be specified. In WP_Tax_Query::transform_query()
, $query['taxonomy']
is never checked for the 'term_taxonomy_id' case
because 'term_taxonomy_id' is the primary key being looked up.
...
Adds unit tests.
Props helen.
Fixes #25284 .
Built from https://develop.svn.wordpress.org/trunk@28562
git-svn-id: http://core.svn.wordpress.org/trunk@28388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 19:59:14 +00:00
Scott Taylor
f50d5233f3
Truly check for ! empty()
instead of falsey ''
when determining whether to add LIMIT
clause to SQL in wp_get_archives()
.
...
Props jjeaton for the initial patch.
Fixes #27834 .
Built from https://develop.svn.wordpress.org/trunk@28560
git-svn-id: http://core.svn.wordpress.org/trunk@28386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 18:28:14 +00:00
Scott Taylor
3214d6d325
Read the src
attribute for the [embed]
shortcode if the shortcode's body is empty.
...
These work:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0 "]`
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0 "][/embed]`
If you do:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0 "]http://any-other-url.com[/embed] `
... "http://any-other-url.com " will be the URL that is parsed.
Props kovshenin, aaroncampbell for making initial patches.
Fixes #24456 .
Built from https://develop.svn.wordpress.org/trunk@28559
git-svn-id: http://core.svn.wordpress.org/trunk@28385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 18:06:13 +00:00
Scott Taylor
e8181b0934
Allow get_comments_number()
to officially accept $post
or $post_id
. Adds unit tests.
...
Props coffee2code, JanHenkG.
Fixes #26240 .
Built from https://develop.svn.wordpress.org/trunk@28558
git-svn-id: http://core.svn.wordpress.org/trunk@28384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 17:44:14 +00:00
John Blackbourn
03410a4067
Add CollegeHumor.com oEmbed support. Fixes #24497 . Props johnzanussi.
...
Built from https://develop.svn.wordpress.org/trunk@28557
git-svn-id: http://core.svn.wordpress.org/trunk@28383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 23:47:15 +00:00
Scott Taylor
10e1d66318
Viddler has had a new oEmbed endpoint for at least 10 months. Let us update to it.
...
Props garhdez.
Fixes #24296 .
Built from https://develop.svn.wordpress.org/trunk@28556
git-svn-id: http://core.svn.wordpress.org/trunk@28382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 23:17:15 +00:00
Scott Taylor
fe044c84f7
Support Polldaddy's short URL format as a whitelisted oEmbed provider.
...
Props donncha.
Fixes #28283 .
Built from https://develop.svn.wordpress.org/trunk@28555
git-svn-id: http://core.svn.wordpress.org/trunk@28381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 23:13:14 +00:00
Scott Taylor
ee43d258c2
Add Issuu to list of whitelisted oEmbed providers.
...
Props issuu.
Fixes #28312 .
Built from https://develop.svn.wordpress.org/trunk@28554
git-svn-id: http://core.svn.wordpress.org/trunk@28380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 21:50:14 +00:00
Scott Taylor
8d4d645629
Fix parsing in wp_match_mime_types()
to allow some mime-types with +
in them to appear in the list of filter links shown above the list table on upload.php
.
...
Props _duck.
Fixes #20672 .
Built from https://develop.svn.wordpress.org/trunk@28553
git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 21:36:15 +00:00
Scott Taylor
e0a57ed96a
Support oEmbed matching for YouTube playlist URLs.
...
Fixes #28125 .
Built from https://develop.svn.wordpress.org/trunk@28552
git-svn-id: http://core.svn.wordpress.org/trunk@28378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 21:12:15 +00:00
Scott Taylor
fcd6920bb8
In is_user_option_local()
, $user_id
is set conditionally, but never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28551
git-svn-id: http://core.svn.wordpress.org/trunk@28377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:18:14 +00:00
Scott Taylor
dd25ef25d9
$count
is set in get_post_galleries()
and never used, relic from PFUI RIP.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28550
git-svn-id: http://core.svn.wordpress.org/trunk@28376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:13:14 +00:00
Scott Taylor
abff6bf6cf
$gallery_div
is set twice in gallery_shortcode()
before it is used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28549
git-svn-id: http://core.svn.wordpress.org/trunk@28375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:12:14 +00:00
Scott Taylor
09046cb2a3
In get_attachment_icon_src()
, $class
is set in 2 conditions but never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28548
git-svn-id: http://core.svn.wordpress.org/trunk@28374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:08:14 +00:00
Scott Taylor
c5ba45a11b
break
is unreachable in WP_Theme::translate_header()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28547
git-svn-id: http://core.svn.wordpress.org/trunk@28373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:05:14 +00:00
Scott Taylor
6177a39971
In WP_Customize_Manager::register_controls()
, $menu_locations
is set and never used.
...
Built from https://develop.svn.wordpress.org/trunk@28546
git-svn-id: http://core.svn.wordpress.org/trunk@28372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 19:01:15 +00:00
Sergey Biryukov
fdaa694ac7
Remove unnecessary array_reverse() from wp_get_post_revisions().
...
WP_Query properly handles multiple 'orderby' values since [28541].
fixes #26042 .
Built from https://develop.svn.wordpress.org/trunk@28543
git-svn-id: http://core.svn.wordpress.org/trunk@28369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:51:14 +00:00
Scott Taylor
e4bc49c244
Because PHP can be configured without --filter
, it is not 100% safe to use filter_var()
. This is problematic for casting "false"
to false
, as PHP always casts it to true
. FILTER_VALIDATE_BOOLEAN
fixes this, but it may not be available.
...
Add a new function, `wp_validate_boolean()`, to replace `filter_var( $var, FILTER_VALIDATE_BOOLEAN )`.
Fixes #28170 .
Built from https://develop.svn.wordpress.org/trunk@28542
git-svn-id: http://core.svn.wordpress.org/trunk@28368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:34:15 +00:00
Scott Taylor
333083debe
Apply order
to each passed value for orderby
in WP_Query
:
...
* Since `orderby` in `WP_Query` can accept space-delimited sets, yet only one `order` value: when multiple values are passed (and `DESC` is the order), the default sort order `ASC` is being applied to all values before the last in the set.
* There is a unit test that sporadically fails since 3.6 in `tests/post/revision` due to multiple posts having the same `post_date` from being added so rapidly
* When ordering revisions in `wp_get_post_revisions()`, order by `post_date ID`
* Change the `order` value in `wp_get_post_revisions()` to `ASC`. This will produce SQL like: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID ASC`. Previously, this would have produced SQL like: `ORDER BY $wpdb->posts.post_date DESC`, and with the addition of ` ID`: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID DESC`. Clearly, wrong. The original SQL produced: `ORDER BY $wpdb->posts.post_date DESC`. As such, return the reversions in reverse order using `array_reverse()`. Not doing so would break "Preview Changes."
* Add unit tests to assert that all of this works.
* All existing unit tests pass with the change to ordering multiple `orderby`s in `WP_Query`.
* In the future, we should support independent `order` for each `orderby`, see #17065 .
Props SergeyBiryukov, wonderboymusic.
Fixes #26042 .
Built from https://develop.svn.wordpress.org/trunk@28541
git-svn-id: http://core.svn.wordpress.org/trunk@28367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:19:13 +00:00
Sergey Biryukov
9b9b8ec413
Use correct variable. see [28534], [28538].
...
see #22400 .
Built from https://develop.svn.wordpress.org/trunk@28540
git-svn-id: http://core.svn.wordpress.org/trunk@28366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:40:14 +00:00
Scott Taylor
b8d469600b
These functions import $wpdb
but do not use it.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28539
git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:37:14 +00:00
Sergey Biryukov
f4646b47e7
Remove redundant assignment. see [28379], [28534].
...
see #22400 .
Built from https://develop.svn.wordpress.org/trunk@28538
git-svn-id: http://core.svn.wordpress.org/trunk@28364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:35:13 +00:00
Scott Taylor
62f9e7636d
Fix some bad UI recursion in wp_get_archives()
caused by [28379]. It appears that $afterafter
was appropriately named.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28534
git-svn-id: http://core.svn.wordpress.org/trunk@28360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-20 23:09:16 +00:00
Scott Taylor
affe27e5d1
WP_Query
was only missing one access modifier.
...
Add access modifier (`public`) to applicable class methods/members of `WP_Rewrite`. I am not brave enough to set some of the `var`s to `private` without more testing.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28533
git-svn-id: http://core.svn.wordpress.org/trunk@28359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:41:13 +00:00
Scott Taylor
49af14fde0
WP_Date_Query
was only missing one access modifier.
...
Add access modifier (`public`) to all default widgets' class methods.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28532
git-svn-id: http://core.svn.wordpress.org/trunk@28358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:30:17 +00:00
Scott Taylor
7de0b2b2c8
Upgrade _WP_List_Table_Compat
to PHP5-style constructor.
...
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28531
git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:20:17 +00:00
Scott Taylor
ab6d069f59
Add access modifiers to WP_User_Query
.
...
Add magic methods for BC: __get(), __set(), __isset(), __unset(), and
__call().
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28528
git-svn-id: http://core.svn.wordpress.org/trunk@28354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 15:48:15 +00:00
Scott Taylor
146810ed8f
Add public
access modifier to methods/members of WP_Widget
and WP_Widget_Factory
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28527
git-svn-id: http://core.svn.wordpress.org/trunk@28353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 15:42:13 +00:00
Scott Taylor
fd5e6b5f6b
In wpdb
, make some things explicitly public
. Do not set anything to private
. This would instantly blow up hyperdb
in the wild.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28526
git-svn-id: http://core.svn.wordpress.org/trunk@28352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 15:36:13 +00:00
Scott Taylor
e8812f9d8a
Add access modifiers to WP_Text_Diff_Renderer_Table
that are compatible with its parent class. Some of the inline docs suggest access that, if implemented, would produce fatal errors.
...
Add magic methods for BC: __get(), __set(), __isset(), __unset(), and __call().
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28525
git-svn-id: http://core.svn.wordpress.org/trunk@28351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 15:23:14 +00:00
Scott Taylor
85f73cf458
Classes that have __set()
also need __isset()
and __unset()
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28524
git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:52:14 +00:00
Scott Taylor
949cfd7a34
Add missing access modifiers to methods in WP_Query
. Add magic methods for __get()
, __set()
, __isset()
, __unset()
, and __call()
.
...
Add unit test for magic methods.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28523
git-svn-id: http://core.svn.wordpress.org/trunk@28349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:49:16 +00:00
Scott Taylor
b539c1cd76
Add missing access modifiers to methods in WP_Meta_Query
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28522
git-svn-id: http://core.svn.wordpress.org/trunk@28348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:35:14 +00:00
Scott Taylor
821246b4ae
Some classes with __get()
method also need __set()
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28521
git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:31:15 +00:00
Scott Taylor
2e9ce6fc87
Fix fatal error in unit test.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28520
git-svn-id: http://core.svn.wordpress.org/trunk@28346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:25:14 +00:00
Scott Taylor
40fab485aa
Add missing access modifiers to methods in WP_Comment_Query
. Add a magic __call()
method for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28519
git-svn-id: http://core.svn.wordpress.org/trunk@28345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:19:14 +00:00
Scott Taylor
5030fdef62
Add missing access modifiers to methods in WP_Scripts
and WP_Styles
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28518
git-svn-id: http://core.svn.wordpress.org/trunk@28344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:17:14 +00:00
Scott Taylor
f998ac39d3
Add missing access modifiers to methods in WP_Dependencies
and _WP_Dependency
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28517
git-svn-id: http://core.svn.wordpress.org/trunk@28343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:14:14 +00:00
Scott Taylor
dc24cef605
Add missing access modifiers to methods in WP
and WP_MatchesMapRegex
. Add magic __call()
and __get()
methods to WP_MatchesMapRegex
for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28516
git-svn-id: http://core.svn.wordpress.org/trunk@28342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:12:14 +00:00
Scott Taylor
25a70283e1
Add missing access modifiers to methods in wp_xmlrpc_server
. Add a magic __call()
method for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28515
git-svn-id: http://core.svn.wordpress.org/trunk@28341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:09:13 +00:00
Scott Taylor
dfa4de15fa
Add missing access modifiers to methods/members in Walker
and subclasses. Add a magic __get()
method.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28514
git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:00:15 +00:00
Scott Taylor
df8a090193
Add missing access modifiers to methods/members in WP_Image_Editor_*
classes.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28513
git-svn-id: http://core.svn.wordpress.org/trunk@28339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:53:14 +00:00
Scott Taylor
dd25163346
Add access modifiers to methods/members in WP_HTTP_IXR_Client
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28512
git-svn-id: http://core.svn.wordpress.org/trunk@28338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:51:15 +00:00
Scott Taylor
72d096b007
Add access modifiers to methods/members in WP_Error
. Add a magic __get()
method for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28511
git-svn-id: http://core.svn.wordpress.org/trunk@28337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:50:14 +00:00
Scott Taylor
aabcfd658b
Add access modifiers to methods/members in WP_Embed
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28510
git-svn-id: http://core.svn.wordpress.org/trunk@28336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:47:14 +00:00
Scott Taylor
3c209b6f56
Add missing access modifiers to methods/members in WP_Customize_*
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28509
git-svn-id: http://core.svn.wordpress.org/trunk@28335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:45:16 +00:00
Scott Taylor
4938497b3a
Add access modifier to methods/members in WP_Ajax_Response
. Adds a magic __get()
method for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28508
git-svn-id: http://core.svn.wordpress.org/trunk@28334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:41:14 +00:00
Scott Taylor
27e8d17be2
Add access modifier to methods/members in WP_oEmbed
. Adds a magic __call()
method for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28507
git-svn-id: http://core.svn.wordpress.org/trunk@28333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:37:13 +00:00
Scott Taylor
d6e5fcab4d
Add access modifier to methods of HTTP classes. There are no new private or protected methods, so no need for __call()
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28506
git-svn-id: http://core.svn.wordpress.org/trunk@28332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:34:15 +00:00
Scott Taylor
35fb2e48e0
Add access modifiers to methods/members in WP_Feed_Cache
, WP_SimplePie_File
, and WP_Feed_Cache_Transient
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28505
git-svn-id: http://core.svn.wordpress.org/trunk@28331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:27:15 +00:00
Scott Taylor
ddfb1e20d2
Add access modifiers to methods/members in Walker_Category
and Walker_CategoryDropdown
.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28504
git-svn-id: http://core.svn.wordpress.org/trunk@28330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:23:14 +00:00
Scott Taylor
f172ef8ce2
Add access modifiers to methods/members in WP_Roles
. Add a magic __call()
method for BC.
...
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28503
git-svn-id: http://core.svn.wordpress.org/trunk@28329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:20:14 +00:00
Scott Taylor
d9cd56f9ad
Add access modifiers to methods/members in WP_Object_Cache
. Add a magic __get()
method for BC.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28502
git-svn-id: http://core.svn.wordpress.org/trunk@28328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:16:15 +00:00
Scott Taylor
5d72cd4949
In wp_list_bookmarks()
, $categorize
should now be $r['categorize]
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28501
git-svn-id: http://core.svn.wordpress.org/trunk@28327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:11:14 +00:00
Scott Taylor
2f513d3320
Fix some hackificator
odds and ends in wp-admin
:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Drew Jaynes
c7c563532b
Improve inline documentation of default arguments for the_title_attribute()
.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@28498
git-svn-id: http://core.svn.wordpress.org/trunk@28324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 02:28:14 +00:00
Scott Taylor
b9afafffe3
hackificator
complains if you call include 'file.php'
without the parens, needs to be include( 'file.php' )
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28479
git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 20:52:15 +00:00
Drew Jaynes
11dd3443a2
Improve inline documentation for default arguments in wp_get_archives()
.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@28476
git-svn-id: http://core.svn.wordpress.org/trunk@28303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 17:20:15 +00:00
Scott Taylor
87730b879f
Eliminate the use of extract()
in MO::import_from_reader()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28472
git-svn-id: http://core.svn.wordpress.org/trunk@28299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 17:21:14 +00:00
Scott Taylor
f4661c6659
Eliminate the use of extract()
in get_pages()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28471
git-svn-id: http://core.svn.wordpress.org/trunk@28298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 17:12:15 +00:00
Scott Taylor
1bd4118799
Eliminate the use of extract()
in wp_insert_attachment()
.
...
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28470
git-svn-id: http://core.svn.wordpress.org/trunk@28297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 16:54:14 +00:00
Scott Taylor
73a9ba7428
Eliminate the use of extract()
in wp_insert_post()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28469
git-svn-id: http://core.svn.wordpress.org/trunk@28296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 15:53:15 +00:00
Scott Taylor
eea7052df8
Eliminate the use of extract()
in wp_delete_term()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28466
git-svn-id: http://core.svn.wordpress.org/trunk@28293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 14:55:14 +00:00
Scott Taylor
bec9993f38
Eliminate the use of extract()
in get_terms()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28465
git-svn-id: http://core.svn.wordpress.org/trunk@28292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 14:47:14 +00:00
Scott Taylor
c1b5670a00
Eliminate the use of extract()
in wp_insert_term()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28464
git-svn-id: http://core.svn.wordpress.org/trunk@28291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 14:16:14 +00:00
Scott Taylor
66c3f62a54
Eliminate use of extract()
in wp_update_term()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28461
git-svn-id: http://core.svn.wordpress.org/trunk@28288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 21:29:13 +00:00
Scott Taylor
a39aecc9b1
The cache key for comments in WP_Comment_Query::query()
needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) )
instead of compact( array_keys( $defaults ) )
. The latter assumes all of those variables are still floating around.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28460
git-svn-id: http://core.svn.wordpress.org/trunk@28287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 21:09:14 +00:00
Scott Taylor
0aafc8f874
(ACTUALLY) Eliminate use of extract()
in WP_Comment_Query::query()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28459
git-svn-id: http://core.svn.wordpress.org/trunk@28286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 20:52:14 +00:00
Scott Taylor
4f57a231c5
Eliminate use of extract()
in WP_Comment_Query::query()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28458
git-svn-id: http://core.svn.wordpress.org/trunk@28285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 19:33:14 +00:00
Scott Taylor
14ba67c38d
Eliminate use of extract()
in wp_insert_comment()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28457
git-svn-id: http://core.svn.wordpress.org/trunk@28284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:52:16 +00:00
Andrew Ozz
f184243aa3
DFW: fix closing only the wpLink or media modal when pressing Esc.
...
Built from https://develop.svn.wordpress.org/trunk@28455
git-svn-id: http://core.svn.wordpress.org/trunk@28282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:17:14 +00:00
Scott Taylor
877fad9f38
Eliminate use of extract()
in wp_insert_user()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28454
git-svn-id: http://core.svn.wordpress.org/trunk@28281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:15:15 +00:00
Scott Taylor
a25e03f833
In wp_xmlrpc_server::mw_editPost
, also set $post_type = $postdata['post_type']
.
...
See #22400 , [28448].
Built from https://develop.svn.wordpress.org/trunk@28453
git-svn-id: http://core.svn.wordpress.org/trunk@28280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:06:15 +00:00
Scott Taylor
fdaea6b7f2
Eliminate use of extract()
in wp_widget_rss_form()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28449
git-svn-id: http://core.svn.wordpress.org/trunk@28276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 15:38:14 +00:00
Scott Taylor
463b7c4620
Eliminate use of extract()
in wp_xmlrpc_server::mw_editPost()
(MetaWeblog API, y'all).
...
A lot of the extracted variables are overwritten by being explicitly set later.
Only set variables that would otherwise not be present with `compact()` is called.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28448
git-svn-id: http://core.svn.wordpress.org/trunk@28275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 15:19:14 +00:00
Sergey Biryukov
5c2d25aa77
Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings.
...
props GaVrA.
fixes #23800 .
Built from https://develop.svn.wordpress.org/trunk@28444
git-svn-id: http://core.svn.wordpress.org/trunk@28271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 11:10:14 +00:00
Sergey Biryukov
abc830ca9d
DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
...
props avryl.
fixes #28279 .
Built from https://develop.svn.wordpress.org/trunk@28443
git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 10:43:14 +00:00
Sergey Biryukov
d970ac80c6
Don't include caption tags in gallery template when there is no caption.
...
props avryl.
fixes #28089 .
Built from https://develop.svn.wordpress.org/trunk@28442
git-svn-id: http://core.svn.wordpress.org/trunk@28269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 21:03:15 +00:00
Scott Taylor
5a5c86139f
Eliminate use of extract()
in wp_get_object_terms()
.
...
There are 3 properties, just set them to variables. They are used too often to warrant a refactor.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28441
git-svn-id: http://core.svn.wordpress.org/trunk@28268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:58:15 +00:00
Scott Taylor
6e8e30bb1e
Eliminate use of extract()
in wp_widget_rss_output()
.
...
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback).
Every other default arg has a default value of `0`.
`items` is expected to always be passed to this function.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28440
git-svn-id: http://core.svn.wordpress.org/trunk@28267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:42:13 +00:00
Scott Taylor
157f811a5e
Eliminate use of extract()
in WP_Widget_RSS::widget()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28439
git-svn-id: http://core.svn.wordpress.org/trunk@28266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:36:15 +00:00
Scott Taylor
72fd658cde
In Walker_Category::start_el()
, $title
might not be set when $args
are passed multiple levels into walk_category_tree()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28438
git-svn-id: http://core.svn.wordpress.org/trunk@28265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 19:14:14 +00:00
Scott Taylor
2a3548fe70
Eliminate use of extract()
in wp_allow_comment()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28437
git-svn-id: http://core.svn.wordpress.org/trunk@28264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 18:10:15 +00:00
Scott Taylor
2b125a881b
Eliminate use of extract()
in Walker_Category::start_el()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28436
git-svn-id: http://core.svn.wordpress.org/trunk@28263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 17:58:13 +00:00
Scott Taylor
9b210df2b9
Eliminate use of extract()
in wp_generate_tag_cloud()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28435
git-svn-id: http://core.svn.wordpress.org/trunk@28262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 17:48:15 +00:00
Scott Taylor
9c8becc1f7
Eliminate use of extract()
in wp_list_categories()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28434
git-svn-id: http://core.svn.wordpress.org/trunk@28261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 17:28:14 +00:00
Scott Taylor
67c51361d6
Eliminate use of extract()
in default-widgets.php
.
...
Props rzen, wonderboymusic.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28433
git-svn-id: http://core.svn.wordpress.org/trunk@28260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 16:33:15 +00:00
Scott Taylor
b788832722
Eliminate use of extract()
in wp_dropdown_categories()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28432
git-svn-id: http://core.svn.wordpress.org/trunk@28259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 15:48:14 +00:00
Scott Taylor
78b6f2761d
Eliminate use of extract()
in get_comment_reply_link()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28431
git-svn-id: http://core.svn.wordpress.org/trunk@28258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 15:35:15 +00:00
Scott Taylor
11aa170e30
Eliminate use of extract()
in WP_Ajax_Response::add()
. Just set most of the properties to variables to avoid interpolation churn.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28430
git-svn-id: http://core.svn.wordpress.org/trunk@28257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 15:25:14 +00:00
Scott Taylor
7943f4715a
Eliminate the use of extract()
in get_post_reply_link()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28429
git-svn-id: http://core.svn.wordpress.org/trunk@28256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:49:14 +00:00
Scott Taylor
0e2909ce89
Eliminate the use of extract()
in wp_list_comments()
. All unit tests pass.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28428
git-svn-id: http://core.svn.wordpress.org/trunk@28255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:43:15 +00:00
Scott Taylor
a15d498d1a
Eliminate the use of extract()
in wp_update_comment()
. All unit tests pass.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28427
git-svn-id: http://core.svn.wordpress.org/trunk@28254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:37:15 +00:00
Scott Taylor
bbcc03a750
Eliminate the use of extract()
in wp_check_filetype_and_ext()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28426
git-svn-id: http://core.svn.wordpress.org/trunk@28253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:22:14 +00:00
Scott Taylor
8e98541d5f
Eliminate the use of extract()
in wp_mail()
. Check the filtered array for each value before re-setting variables.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28425
git-svn-id: http://core.svn.wordpress.org/trunk@28252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:17:15 +00:00
Scott Taylor
f5bd0de275
Eliminate the use of extract()
in wp_validate_auth_cookie()
.
...
Don't do anything fancy here, just set the 4 returned properties to variables. This function is semi-important.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28424
git-svn-id: http://core.svn.wordpress.org/trunk@28251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:11:13 +00:00
Scott Taylor
eb2bbf9c97
Eliminate the use of extract()
in get_objects_in_term()
. Only one property (order
) was extracted.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28423
git-svn-id: http://core.svn.wordpress.org/trunk@28250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:43:16 +00:00
Scott Taylor
80a37d2fcd
Eliminate the use of extract()
in WP_Tax_Query::get_sql()
. All unit tests still pass.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28422
git-svn-id: http://core.svn.wordpress.org/trunk@28249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:41:14 +00:00
Scott Taylor
e6fad96f5e
Eliminate the use of extract()
in the_taxonomies()
. Adds unit test.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28421
git-svn-id: http://core.svn.wordpress.org/trunk@28248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:25:14 +00:00
Scott Taylor
ee90a8c17c
Eliminate the use of extract()
in wp_dropdown_users()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28420
git-svn-id: http://core.svn.wordpress.org/trunk@28247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:18:15 +00:00
Scott Taylor
ae61a48489
Set @param
back to $output
, not $html
, in the inline filter docs. This was a copy/paste mistake.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28419
git-svn-id: http://core.svn.wordpress.org/trunk@28246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:08:14 +00:00
Scott Taylor
c0b0b00e6d
Eliminate use of extract()
in get_the_taxonomies()
. Adds unit test.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28415
git-svn-id: http://core.svn.wordpress.org/trunk@28242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:51:13 +00:00
Scott Taylor
dcc6cbc04f
Eliminate use of extract()
in gallery_shortcode()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28414
git-svn-id: http://core.svn.wordpress.org/trunk@28241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:41:15 +00:00
Scott Taylor
947aa04900
Update the inline docs for add_shortcode()
to eliminate suggestion to use extract()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28413
git-svn-id: http://core.svn.wordpress.org/trunk@28240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:28:15 +00:00
Scott Taylor
4b94efd93b
Eliminate use of extract()
in wp_xmlrpc_server::blogger_editPost()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28412
git-svn-id: http://core.svn.wordpress.org/trunk@28239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:25:15 +00:00
Scott Taylor
54321f4c6e
Eliminate use of extract()
in get_media_item()
.
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28407
git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:45:15 +00:00
Scott Taylor
9d6eeca015
Eliminate use of extract()
in wp_list_bookmarks()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28405
git-svn-id: http://core.svn.wordpress.org/trunk@28232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:18:16 +00:00
Scott Taylor
748765c5ad
Eliminate use of extract()
in _walk_bookmarks()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28404
git-svn-id: http://core.svn.wordpress.org/trunk@28231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:05:15 +00:00
Scott Taylor
12a5b389ab
Eliminate use of extract()
in get_bookmarks()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28403
git-svn-id: http://core.svn.wordpress.org/trunk@28230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:58:15 +00:00
Scott Taylor
a4a5560b22
Eliminate use of extract()
in Walker_Page::start_el()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28402
git-svn-id: http://core.svn.wordpress.org/trunk@28229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:41:15 +00:00
Scott Taylor
7b8d797355
Eliminate use of extract()
in wp_list_pages()
which, surprisingly, didn't even use any of the extracted variables.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28401
git-svn-id: http://core.svn.wordpress.org/trunk@28228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:22:15 +00:00
Scott Taylor
29d8832625
Eliminate use of extract()
in wp_dropdown_pages()
.
...
Adds unit tests to: `tests/post/template.php`.
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28399
git-svn-id: http://core.svn.wordpress.org/trunk@28227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 01:12:13 +00:00
Scott Taylor
fe2d90ab4f
Eliminate use of extract()
in wp_link_pages()
.
...
Adds unit tests to a new file: `tests/post/template.php`.
There were previously no unit tests for `wp_link_pages()`.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28398
git-svn-id: http://core.svn.wordpress.org/trunk@28226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 00:44:14 +00:00
Scott Taylor
d5acdd82c8
Eliminate use of extract()
in paginate_links()
. Adds unit tests. Moves tests/general/template.php
(which only had one method) to tests/general/paginateLinks.php
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28397
git-svn-id: http://core.svn.wordpress.org/trunk@28225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-14 22:29:14 +00:00
Scott Taylor
e866b5fb82
Eliminate use of extract()
in wp_list_authors()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28392
git-svn-id: http://core.svn.wordpress.org/trunk@28220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 06:02:14 +00:00
Scott Taylor
92d2c60a65
Eliminate use of extract()
in the_title_attribute()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28383
git-svn-id: http://core.svn.wordpress.org/trunk@28211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:48:15 +00:00
Scott Taylor
ef8b813682
Eliminate use of extract()
in trackback_url_list()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28382
git-svn-id: http://core.svn.wordpress.org/trunk@28210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:44:15 +00:00
Scott Taylor
bee6492b9b
Eliminate use of extract()
in wp-includes/theme-compat/comments-popup.php
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28381
git-svn-id: http://core.svn.wordpress.org/trunk@28209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:40:16 +00:00
Scott Taylor
b110c7f887
Eliminate use of extract()
in wp_get_archives()
.
...
Adds unit tests: `tests/functions/getArchives.php`.
All other unit tests pass.
Props MikeHansenMe, wonderboymusic.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28379
git-svn-id: http://core.svn.wordpress.org/trunk@28207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:29:26 +00:00
Drew Jaynes
62b6306739
Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover
filter.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28378
git-svn-id: http://core.svn.wordpress.org/trunk@28206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:29:14 +00:00
Drew Jaynes
08824b6529
Add a complete short description to the get_attached_media
filter documentation.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28377
git-svn-id: http://core.svn.wordpress.org/trunk@28205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:21:14 +00:00
Scott Taylor
f32dbfe62c
Add xps
and oxps
extensions to list of supported document types.
...
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification
Fixes #15697 .
Built from https://develop.svn.wordpress.org/trunk@28372
git-svn-id: http://core.svn.wordpress.org/trunk@28200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 07:19:13 +00:00
Scott Taylor
5682d30b6e
In wp.media.view.Settings::update()
, when handling checkboxes, check for a value of 'false'
in addition to casting value
to boolean. !! 'false'
evaluates to true
.
...
Props adamsilverstein.
Fixes #23954 .
Built from https://develop.svn.wordpress.org/trunk@28371
git-svn-id: http://core.svn.wordpress.org/trunk@28199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 07:03:15 +00:00
Scott Taylor
aeadf0c7cf
Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings
instead of just _wpmejsSettings.pluginPath
.
...
Props Otto42 for the initial patch.
Fixes #25243 .
Built from https://develop.svn.wordpress.org/trunk@28370
git-svn-id: http://core.svn.wordpress.org/trunk@28198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:25:15 +00:00
Scott Taylor
558cf6f86d
In the Attachment Details
section of the media modal, only add box-shadow
to images. Other mime-type icons look strange with an arbitrary border.
...
Props avryl.
Fixes #27949 .
Built from https://develop.svn.wordpress.org/trunk@28369
git-svn-id: http://core.svn.wordpress.org/trunk@28197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:19:14 +00:00
Scott Taylor
60f395e4c2
Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors.
...
Props celloexpressions.
Fixes #27516 .
Built from https://develop.svn.wordpress.org/trunk@28365
git-svn-id: http://core.svn.wordpress.org/trunk@28193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 02:23:14 +00:00
Scott Taylor
37b7f39e95
When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views.
...
Fixes #27971 .
Built from https://develop.svn.wordpress.org/trunk@28364
git-svn-id: http://core.svn.wordpress.org/trunk@28192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 02:07:14 +00:00
Scott Taylor
fb1aab6520
Support loop
for [audio]
and [video]
shortcodes that specify files that are played using MediaElement's Flash plugin bridge.
...
Fixes #27368 .
Built from https://develop.svn.wordpress.org/trunk@28363
git-svn-id: http://core.svn.wordpress.org/trunk@28191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 01:28:15 +00:00
Scott Taylor
5df38694e9
In get_the_author_posts()
, if there is no current $post
, return 0
and bail.
...
Props krogsgard, aaroncampbell.
Fixes #27998 .
Built from https://develop.svn.wordpress.org/trunk@28362
git-svn-id: http://core.svn.wordpress.org/trunk@28190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:26:14 +00:00
Scott Taylor
d06c353995
MediaElement players need clear: both
to play nice with adjacent floated elements.
...
Fixes #27385 .
Built from https://develop.svn.wordpress.org/trunk@28361
git-svn-id: http://core.svn.wordpress.org/trunk@28189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:14:14 +00:00
Scott Taylor
9daf458ff0
Remove the title
attribute from markup generated in wp-includes/category-template.php
:
...
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`
Props joedolson.
Fixes #26557 .
Built from https://develop.svn.wordpress.org/trunk@28359
git-svn-id: http://core.svn.wordpress.org/trunk@28187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 23:57:16 +00:00
Scott Taylor
f22beb987c
First pass at wpview
logic for the [embed]
shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
...
Props avryl, wonderboymusic.
See #28195 .
Built from https://develop.svn.wordpress.org/trunk@28358
git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 23:36:18 +00:00
Drew Jaynes
9098b45e53
Add inline documentation of the default arguments for wp_list_pages()
.
...
Props garza for the initial patches.
Fixes #11338 .
Built from https://develop.svn.wordpress.org/trunk@28357
git-svn-id: http://core.svn.wordpress.org/trunk@28185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 08:02:14 +00:00
Scott Taylor
1daa7d6723
Leverage size_format()
when displaying max_upload_size
:
...
* In `media_upload_form()`
* The `uploader-inline` Underscore template in the media modal.
Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.
Fixes #25643 .
Built from https://develop.svn.wordpress.org/trunk@28343
git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 18:25:14 +00:00
Scott Taylor
3bbed6ceac
audio
, video
, and playlist
shortcodes:
...
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur
See #22400 , #27881 .
Built from https://develop.svn.wordpress.org/trunk@28342
git-svn-id: http://core.svn.wordpress.org/trunk@28170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 17:36:18 +00:00
Scott Taylor
361e3e1ee6
In wpdb
, remove dead code:
...
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28339
git-svn-id: http://core.svn.wordpress.org/trunk@28167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:56:14 +00:00
Scott Taylor
06373a6f32
In WP_Widget::update_callback()
, $sidebars_widgets
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28338
git-svn-id: http://core.svn.wordpress.org/trunk@28166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:52:15 +00:00
Scott Taylor
49251efc74
In wp-includes/theme.php
, break
is unreachable after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28337
git-svn-id: http://core.svn.wordpress.org/trunk@28165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:50:14 +00:00
Scott Taylor
cca9ff329b
In print_admin_styles()
, $zip
is never used after being set. $compress_css
does not need to be imported.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28336
git-svn-id: http://core.svn.wordpress.org/trunk@28164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:47:14 +00:00
Scott Taylor
1ef3438961
In wp_default_scripts()
, $max_upload_size
and its entangled children $max_up
and $max_post
create quite the ternary operator... that is never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28335
git-svn-id: http://core.svn.wordpress.org/trunk@28163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:45:14 +00:00
Scott Taylor
5b6b17fc80
In wp-includes/revision.php
- remove dead code:
...
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28334
git-svn-id: http://core.svn.wordpress.org/trunk@28162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:38:16 +00:00
Scott Taylor
5bc59586da
In WP_Query
, remove duplicate variable setting:
...
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28333
git-svn-id: http://core.svn.wordpress.org/trunk@28161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:43:20 +00:00
Scott Taylor
1aed1f1108
In get_pages()
, $cache
does not need to be reset to an empty array. update_post_cache( $pages )
takes care of priming.
...
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28332
git-svn-id: http://core.svn.wordpress.org/trunk@28160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:39:14 +00:00
Scott Taylor
ef34785160
In wp_get_attachment_link()
, $post_title
is set and then not used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28331
git-svn-id: http://core.svn.wordpress.org/trunk@28159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:35:16 +00:00
Scott Taylor
9a1dcd1a7c
In Walker_Nav_Menu::start_el()
, $class_names
is set twice before it is used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28330
git-svn-id: http://core.svn.wordpress.org/trunk@28158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:33:14 +00:00
Scott Taylor
c96d7fff01
In get_network_by_path()
, $exact_domains
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28329
git-svn-id: http://core.svn.wordpress.org/trunk@28157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:32:16 +00:00
Scott Taylor
b2b25f7326
In update_metadata_by_mid()
, $original_value
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28328
git-svn-id: http://core.svn.wordpress.org/trunk@28156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:29:26 +00:00
Scott Taylor
0910376bfe
In edit_post_link()
, $post_type_obj
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28327
git-svn-id: http://core.svn.wordpress.org/trunk@28155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:27:15 +00:00
Scott Taylor
3d0eed82f8
In paginate_links()
, break
is unreachable after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28326
git-svn-id: http://core.svn.wordpress.org/trunk@28154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:25:15 +00:00
Scott Taylor
de4eaacd89
In wp-includes/functions.php
, remove dead code:
...
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28325
git-svn-id: http://core.svn.wordpress.org/trunk@28153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:23:14 +00:00
Scott Taylor
7eeafa3537
In wp_set_comment_status()
, the default
case returns, so no default value for $status
is needed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28324
git-svn-id: http://core.svn.wordpress.org/trunk@28152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:17:15 +00:00
Scott Taylor
de262f553c
In wp-includes/comment-template.php
, remove dead code:
...
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28323
git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:15:17 +00:00
Scott Taylor
6b80da9d96
In Walker::walk()
and Walker::paged_walk()
, $id_field
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28322
git-svn-id: http://core.svn.wordpress.org/trunk@28150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:09:19 +00:00
Sergey Biryukov
d711c32138
Update deleted site message in ms_site_check().
...
props boonebgorges.
fixes #28150 .
Built from https://develop.svn.wordpress.org/trunk@28321
git-svn-id: http://core.svn.wordpress.org/trunk@28149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:46:15 +00:00
Scott Taylor
013d4dc387
In WP_Image_Editor::get_output_format()
, $file_mime
and $file_ext
are set twice before they are used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28320
git-svn-id: http://core.svn.wordpress.org/trunk@28148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:37:29 +00:00
Scott Taylor
73b102bd84
In wp-includes/class-wp-customize-setting.php
, break
is unreachable after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28319
git-svn-id: http://core.svn.wordpress.org/trunk@28147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:34:14 +00:00
Scott Taylor
0a4af6d45c
In wp-includes/class-wp-admin-bar.php
, break
is unreachabled after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28318
git-svn-id: http://core.svn.wordpress.org/trunk@28146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:29:15 +00:00
Scott Taylor
5bd852c262
In WP_Http_Curl::request()
, $theResponse
is unused. There are other curl_exec()
calls that do not return as well.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28317
git-svn-id: http://core.svn.wordpress.org/trunk@28145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:26:14 +00:00
Scott Taylor
63a210e7c8
In wp-includes/bookmark.php
, remove dead code:
...
* In `get_bookmarks()`, `$cache` is set twice before it is used.
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28316
git-svn-id: http://core.svn.wordpress.org/trunk@28144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:22:16 +00:00
Sergey Biryukov
d70e8a38fa
Add a filter for wp_list_comments() arguments.
...
props greenshady, hlashbrooke.
fixes #19581 .
Built from https://develop.svn.wordpress.org/trunk@28285
git-svn-id: http://core.svn.wordpress.org/trunk@28113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 11:58:14 +00:00
Drew Jaynes
2c00d8f9e3
Where a filter no longer exists, it need not be notated.
...
Fixes #24444 . See r28258.
Built from https://develop.svn.wordpress.org/trunk@28283
git-svn-id: http://core.svn.wordpress.org/trunk@28111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:38:15 +00:00
Andrew Nacin
e239dfad43
Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression.
...
props jeremyfelt.
fixes #27927 .
Built from https://develop.svn.wordpress.org/trunk@28280
git-svn-id: http://core.svn.wordpress.org/trunk@28108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:32:36 +00:00
Andrew Nacin
5b63b112f3
Multisite: Fix case sensitivity regressions in 3.9.
...
props jeremyfelt.
fixes #27866 .
Built from https://develop.svn.wordpress.org/trunk@28276
git-svn-id: http://core.svn.wordpress.org/trunk@28104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:24:14 +00:00
Scott Taylor
9bdbd50ac0
In general-template.php
- remove dead code:
...
* In `get_calendar()`, `$cache` is set twice. The first is useless.
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary.
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28274
git-svn-id: http://core.svn.wordpress.org/trunk@28102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:58:16 +00:00
Andrew Nacin
6295631a4b
Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers.
...
props rzen, ehg.
fixes #27848 .
Built from https://develop.svn.wordpress.org/trunk@28266
git-svn-id: http://core.svn.wordpress.org/trunk@28094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:14:14 +00:00
Scott Taylor
00b03fe04f
Remove duplicate variable setting for $link
in wp_list_authors()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28265
git-svn-id: http://core.svn.wordpress.org/trunk@28093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:52:15 +00:00
Scott Taylor
b663fffe24
Add .dfxp
and .srt
files to mime-type whitelist in wp_get_mime_types()
. They are both captioning formats supported by MediaElement.
...
Props joedolson.
Fixes #27643 .
Built from https://develop.svn.wordpress.org/trunk@28259
git-svn-id: http://core.svn.wordpress.org/trunk@28087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 20:08:16 +00:00
Scott Taylor
511145b418
When $type
is atom
in get_the_category_rss()
, use get_bloginfo_rss( 'url' )
when setting the scheme
attribute for the <category>
node.
...
Props ejdanderson.
Fixes #24444 .
Built from https://develop.svn.wordpress.org/trunk@28258
git-svn-id: http://core.svn.wordpress.org/trunk@28086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 19:05:14 +00:00
Scott Taylor
5e7ac8de94
Remove by-reference modifiers from arguments in wp_remote_retrieve_*
functions.
...
Props jesin.
Fixes #27687 .
Built from https://develop.svn.wordpress.org/trunk@28257
git-svn-id: http://core.svn.wordpress.org/trunk@28085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 18:46:15 +00:00
Scott Taylor
f90a558df4
In WP_Date_Query::get_sql_for_subquery()
, don't parse duplicate parameters - only parse one of w
and week
or month
and monthnum
.
...
Adds unit tests.
Props oso96_2000, ChriCo.
Fixes #25835 .
Built from https://develop.svn.wordpress.org/trunk@28252
git-svn-id: http://core.svn.wordpress.org/trunk@28080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 23:07:14 +00:00
Scott Taylor
a2067a7324
Set the proper value for wp_title()
when is_author()
and is_post_type_archive()
are both true. post_type
should always win due to the precedence indicated in get_queried_object()
.
...
Props mordauk.
Fixes #25398 .
Built from https://develop.svn.wordpress.org/trunk@28251
git-svn-id: http://core.svn.wordpress.org/trunk@28079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 22:21:22 +00:00
Sergey Biryukov
0b08cd7a25
Prevent 'paged-*' from being added to body classes on 404 error pages.
...
props psoluch.
see #16468 .
Built from https://develop.svn.wordpress.org/trunk@28249
git-svn-id: http://core.svn.wordpress.org/trunk@28077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:15 +00:00
Drew Jaynes
a5366db845
Improve inline documentation for the wpdb::$show_errors property.
...
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.
Props ericlewis.
Fixes #16615 .
Built from https://develop.svn.wordpress.org/trunk@28243
git-svn-id: http://core.svn.wordpress.org/trunk@28071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 12:19:15 +00:00
Sergey Biryukov
7214648764
Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu().
...
props Tmeister.
fixes #27745 .
Built from https://develop.svn.wordpress.org/trunk@28242
git-svn-id: http://core.svn.wordpress.org/trunk@28070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:59:14 +00:00
Sergey Biryukov
3ad1c8897c
Correct 'show_in_menu' parameter description in register_taxonomy().
...
fixes #27943 .
Built from https://develop.svn.wordpress.org/trunk@28241
git-svn-id: http://core.svn.wordpress.org/trunk@28069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:29:13 +00:00
Sergey Biryukov
58dcece494
Correct @return value for current_time().
...
props arnee.
fixes #27940 .
Built from https://develop.svn.wordpress.org/trunk@28240
git-svn-id: http://core.svn.wordpress.org/trunk@28068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:25:15 +00:00
Dominik Schilling
c7adbde777
Update jQuery to 1.11.1.
...
fixes #28103 .
Built from https://develop.svn.wordpress.org/trunk@28238
git-svn-id: http://core.svn.wordpress.org/trunk@28066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 09:29:16 +00:00
Sergey Biryukov
d882dc9782
Fix arrow positioning in "Insert/edit link" modal.
...
props avryl, sergej.mueller.
fixes #28096 .
Built from https://develop.svn.wordpress.org/trunk@28236
git-svn-id: http://core.svn.wordpress.org/trunk@28064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 21:21:15 +00:00
Andrew Nacin
ba0168819c
Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets.
...
props gcorne.
props Clorith, jorbin for tests.
see #27907 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@28223
git-svn-id: http://core.svn.wordpress.org/trunk@28051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 03:37:13 +00:00
Andrew Nacin
9f00179c58
Improve TinyMCE string for paste command browser support.
...
props ebinnion.
fixes #27988 .
Built from https://develop.svn.wordpress.org/trunk@28220
git-svn-id: http://core.svn.wordpress.org/trunk@28050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 21:20:14 +00:00
Dominik Schilling
20c10c5e2c
Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.
...
Add tests.
see #27936 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28219
git-svn-id: http://core.svn.wordpress.org/trunk@28049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 20:25:19 +00:00
Dominik Schilling
b6e3942bdd
Revert [28217].
...
Misfired commit for #27936 .
Built from https://develop.svn.wordpress.org/trunk@28218
git-svn-id: http://core.svn.wordpress.org/trunk@28048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 20:18:16 +00:00
Dominik Schilling
1849473907
Recent Posts Widget: Use ob_end_flush()
instead of ob_flush()
.
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28217
git-svn-id: http://core.svn.wordpress.org/trunk@28047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 14:21:15 +00:00
Drew Jaynes
d77e78d685
Clean up duplicate hook notations and adjacency for calls to the wp_signup_location
filter.
...
Also adds braces missed in [25535].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28215
git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:12:14 +00:00
Drew Jaynes
8161668689
Ensure the wp_set_comment_status
action hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28214
git-svn-id: http://core.svn.wordpress.org/trunk@28044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:55:14 +00:00
Drew Jaynes
aa20678c48
Ensure the style_loader_tag
filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28209
git-svn-id: http://core.svn.wordpress.org/trunk@28039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:29:14 +00:00
Drew Jaynes
05537ab967
Ensure the register
filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28208
git-svn-id: http://core.svn.wordpress.org/trunk@28038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:24:15 +00:00
Mark Jaquith
a43313fe12
Use '— Select —' instead of '-- Select --' for nav menus. Looks nicer.
...
see #27878
Built from https://develop.svn.wordpress.org/trunk@28205
git-svn-id: http://core.svn.wordpress.org/trunk@28035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 00:35:25 +00:00
Mark Jaquith
8c830cef80
Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX
...
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.
fixes #27878 for trunk. props westonruter
Built from https://develop.svn.wordpress.org/trunk@28197
git-svn-id: http://core.svn.wordpress.org/trunk@28027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 20:45:31 +00:00
Dominik Schilling
77beef348d
Recent Posts Widget: Use ob_end_flush()
instead of ob_flush()
.
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28195
git-svn-id: http://core.svn.wordpress.org/trunk@28025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 19:48:19 +00:00
John Blackbourn
ab041987d3
Remove some unnecessary abstraction introduced in [28191]. See #27985 .
...
Built from https://develop.svn.wordpress.org/trunk@28194
git-svn-id: http://core.svn.wordpress.org/trunk@28024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 11:55:22 +00:00
Andrew Ozz
5de05f97dd
TinyMCE: update the 'paste' plugin to the latest dev. version. Included changes: 1b7c41cd7b
and 7998b8025d
. See #27909 , for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28192
git-svn-id: http://core.svn.wordpress.org/trunk@28022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 00:59:13 +00:00
John Blackbourn
d6e03df3c9
Avoid an expensive attachment counting query on the post editing screen. See #27985 , for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@28191
git-svn-id: http://core.svn.wordpress.org/trunk@28021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-23 22:05:16 +00:00