Commit Graph

52 Commits

Author SHA1 Message Date
Sergey Biryukov
47ed56f38f Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
Scott Taylor
a3ffebce30 Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38470


git-svn-id: http://core.svn.wordpress.org/trunk@38411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:31:29 +00:00
Scott Taylor
390ceba6c7 Bootstrap: after r38409 and r38410, revert r38402 which reverted r38399.
This fixes the paths in `wp-vendor/` that were including `src`. I want to drop this in so we can find out what else will break.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38411


git-svn-id: http://core.svn.wordpress.org/trunk@38352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 22:32:37 +00:00
Dion Hulse
0e31a46161 Bootstrap: Revert [38399] as it's broken /build/ and subsequently core.svn.wordpress.org.
The generated classmaps reference `/src/` files and operates in the assumption that the base directory is one level above `wp-settings.php`, which it isn't after our build processes are run.

See #36335

Built from https://develop.svn.wordpress.org/trunk@38402


git-svn-id: http://core.svn.wordpress.org/trunk@38343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 14:37:32 +00:00
Scott Taylor
6a529648cf Bootstrap: Autoload classes using a Composer-generated PHP 5.2-compatible Autoloader.
* `wp-admin` and `wp-includes` are scanned for classes to autoload
* Several 3rd-party and Ryan McCue-shaped libraries are excluded when the classmap is generated, see `composer.json`: `autoload.exclude-from-classmap`
* `wp-vendor/autoload_52.php` is included at the top of `wp-settings.php` - no changes need to be made to unit tests to include the autoloader
* An avalanche of `require()` and `require_once()` calls that loaded class files have been removed from the codebase.

The following files have been added to `svn:ignore` - they are not 5.2-compatible and fail during pre-commit:
* src/wp-vendor/autoload.php
* src/wp-vendor/composer/autoload_real.php
* src/wp-vendor/composer/autoload_static.php
* src/wp-vendor/composer/ClassLoader.php

We favor these files instead:
* src/wp-vendor/autoload_52.php
* src/wp-vendor/composer/autoload_real_52.php
* src/wp-vendor/composer/ClassLoader52.php

When new PHP classes are added to the codebase, simply run `composer install` or `composer update` from the project root to update the autoloader.

The future is now.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38399


git-svn-id: http://core.svn.wordpress.org/trunk@38340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 09:15:29 +00:00
Scott Taylor
c99df3a708 XML-RPC: break up class-IXR.php into individual class files.
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38389


git-svn-id: http://core.svn.wordpress.org/trunk@38330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-26 22:08:33 +00:00
Drew Jaynes
9cb5247392 Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37518


git-svn-id: http://core.svn.wordpress.org/trunk@37486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:50:28 +00:00
Dion Hulse
0be2153bfb IXR: Use a strict comparison to ensure that a non-numerically-indexed array is not incorrectly matched as a numeric array.
See #36586

Built from https://develop.svn.wordpress.org/trunk@37244


git-svn-id: http://core.svn.wordpress.org/trunk@37210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-19 06:13:29 +00:00
Dion Hulse
7bc4b19203 XMLRPC: Revert [35509] which caused a change of behviour in at least one XMLRPC client.
XMLRPC has many quirks in it's operation, #16980 being just one of the many, #35185 just became yet another quirk.

See #16980.
Fixes #35185.

Built from https://develop.svn.wordpress.org/trunk@36132


git-svn-id: http://core.svn.wordpress.org/trunk@36098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 04:06:26 +00:00
Scott Taylor
d763eb80b7 XMLRPC: ensure that empty strings are not passed as null, which will then fail isset()
Props solarissmoke.
Fixes #16980.

Built from https://develop.svn.wordpress.org/trunk@35509


git-svn-id: http://core.svn.wordpress.org/trunk@35473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:08:25 +00:00
Dion Hulse
a49062c2db Update variable naming after [35279].
See #29957.

Built from https://develop.svn.wordpress.org/trunk@35364


git-svn-id: http://core.svn.wordpress.org/trunk@35329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 02:01:25 +00:00
Scott Taylor
5d63788d9a XML-RPC: after [35095], change the name of the xmlrpc_memory_limit filter to xmlrpc_chunk_parsing_size.
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35279


git-svn-id: http://core.svn.wordpress.org/trunk@35245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:19:25 +00:00
Scott Taylor
8941648ead XML-RPC: Add a filter, xmlrpc_memory_limit, to allow the value of $xmlrpc_memory_limit to be increased.
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35095


git-svn-id: http://core.svn.wordpress.org/trunk@35060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:01:24 +00:00
Scott Taylor
78d846289f XML-RPC: IXR_Server::output() is notoriously bad at returning the right value for the Content-Length HTTP header. This header is not required, so we will remove it.
"We could of course remove the content-length header as it is not required" was suggested 10 years ago. The IXR library is not maintained. Our release is the latest, which occurred in 2010.

Fixes #2567.

Built from https://develop.svn.wordpress.org/trunk@34571


git-svn-id: http://core.svn.wordpress.org/trunk@34535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 03:11:24 +00:00
Aaron Jorbin
1525010f74 Deprecate php4 style constructors
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982


Built from https://develop.svn.wordpress.org/trunk@32990


git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:27:24 +00:00
Scott Taylor
a0e373ef80 For doc block types, favor bool over the few remaining booleans
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:03:25 +00:00
Andrew Nacin
504eb9aa0d XML-RPC: Send 405 Method Not Allowed for GET requests.
props maxcutler.
fixes #20986.

Built from https://develop.svn.wordpress.org/trunk@31004


git-svn-id: http://core.svn.wordpress.org/trunk@30985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-30 20:41:23 +00:00
Drew Jaynes
13dab23d23 Add missing documentation for the xmlrpc_element_limit hook in wp-includes/class-IXR.php.
Props ankitgadertcampcom, kpdesign.
Fixes #29977.

Built from https://develop.svn.wordpress.org/trunk@30744


git-svn-id: http://core.svn.wordpress.org/trunk@30734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 03:28:22 +00:00
Scott Taylor
bd2521d5ee Fill in the @param types for the args for functions missing them in wp-admin/includes/deprecated.php (pour one out).
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30201


git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
Drew Jaynes
d33c807723 Fix some documentation typos in various core files.
Props vlajos.
Fixes #29199.

Built from https://develop.svn.wordpress.org/trunk@29479


git-svn-id: http://core.svn.wordpress.org/trunk@29257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-13 03:56:17 +00:00
Andrew Nacin
bcb8e53d16 Ignore entities in XML-RPC requests.
props mdawaffe, nacin.

Built from https://develop.svn.wordpress.org/trunk@29404


git-svn-id: http://core.svn.wordpress.org/trunk@29182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-06 17:38:17 +00:00
Andrew Nacin
d86ff4adc4 Allow query strings for servers in IXR_Client and WP_HTTP_IXR_Client.
props cfinke.
fixes #26947.

Built from https://develop.svn.wordpress.org/trunk@27552


git-svn-id: http://core.svn.wordpress.org/trunk@27395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 05:01:14 +00:00
Drew Jaynes
cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Ryan Boren
cb64a77217 Specify the encoding in IXR_Server::output(). Props solarissmoke, sergey.s.betke@novgaro.ru, SergeyBiryukov. fixes #4794
git-svn-id: http://core.svn.wordpress.org/trunk@21531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-15 20:12:00 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin
a773f692ba s/method_exists/is_callable/. props hakre, fixes #14933.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-08 19:27:49 +00:00
nacin
c697ff4926 Initialize a variable. props kapeels for initial patch. fixes #15703.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-07 18:55:13 +00:00
westi
23edf3baa4 Ensure we always have a headers array.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 22:11:16 +00:00
scribu
ec7490bc41 Update Incutio XML-RPC Library to latest version (1.7.4). Props hakre. Fixes #14703
git-svn-id: http://svn.automattic.com/wordpress/trunk@15612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-13 16:36:08 +00:00
westi
1664674948 Don't trim whitespace from sections of the response in IXR_Client. Fixes #12559 props apeatling.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-15 21:04:26 +00:00
nacin
5c8d92d2b1 Check for string, as method may be an array. fixes #10778
git-svn-id: http://svn.automattic.com/wordpress/trunk@13958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-03 07:18:16 +00:00
ryan
38bcfbb49b Reduce memory usage for XML-RPC requests. Props Demitrious Kelly. fixes #10698
git-svn-id: http://svn.automattic.com/wordpress/trunk@12263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-23 16:53:36 +00:00
westi
b6a97077f1 Set the correct header for non POST request to xmlrpc service. Fixes #9093 props joesphscott.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-02-15 10:44:36 +00:00
westi
7d59ed3ba4 Setup an initial value to avoid a Notice. See #8916 props wnorris.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-24 22:22:36 +00:00
westi
4b3d6012aa Make the IXR debug classy. See #8916 props wnorris
git-svn-id: http://svn.automattic.com/wordpress/trunk@10423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-23 22:30:23 +00:00
azaozz
33a8201a89 Fix parse error.not well formed on XMLRPC request, props josephscott, fixes #7794
git-svn-id: http://svn.automattic.com/wordpress/trunk@10318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-06 05:28:53 +00:00
ryan
578c4e7b61 Add support for custom headers in the IXR (XML-RPC) class. Props josephscott. fixes #8145
git-svn-id: http://svn.automattic.com/wordpress/trunk@10313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-05 21:32:04 +00:00
ryan
50269c4845 Add timezone var to IXR_date. Add timezone back to getIso(). Comment WP specific additions. see #7227
git-svn-id: http://svn.automattic.com/wordpress/trunk@8403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-07-22 19:53:03 +00:00
ryan
a890785907 Resurrect 7615. see #7227
git-svn-id: http://svn.automattic.com/wordpress/trunk@8378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-07-19 19:01:35 +00:00
ryan
8831ea942b IXR 0.71. Props jacobsantos. fixes #7227
git-svn-id: http://svn.automattic.com/wordpress/trunk@8376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-07-19 17:56:35 +00:00
westi
b2dd3f0dc4 phpdoc updates for IXR. See #7038 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-14 16:50:55 +00:00
ryan
27167db9c3 Escape faultString in IXR. Props josephscott. fixes #5666 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@7615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-04-07 18:30:51 +00:00
westi
33fffea3f3 Add file level phpdoc to external libraries we use. Fixes #5443 props darkdragon.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-20 22:28:54 +00:00
ryan
321c310717 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:32:58 +00:00
ryan
2f09416258 Trim empty lines. Nothing but newline.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-14 02:25:30 +00:00
ryan
1f2e257074 Add timezone to iso8601 timestamp. Props devlogic. fixes #2036
git-svn-id: http://svn.automattic.com/wordpress/trunk@3279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-12-08 00:08:12 +00:00
matt
aa209f78de Updating IXR to latest, fixes #1400
git-svn-id: http://svn.automattic.com/wordpress/trunk@2622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-06-07 07:39:39 +00:00
saxmatt
5da9bc9933 Trim before decoding - http://mosquito.wordpress.org/view.php?id=654
git-svn-id: http://svn.automattic.com/wordpress/trunk@2139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-01-24 09:53:23 +00:00
saxmatt
01ee685d3c http://mosquito.wordpress.org/view.php?id=708 - Patch from Owen Winkler allowing XML-RPC library to call classes without extending the base class.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-01-18 06:12:23 +00:00
michelvaldrighi
e7d60415cf added timeout and vendor parameters to IXR_Client, could be very useful for weblog_pings
git-svn-id: http://svn.automattic.com/wordpress/trunk@1673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-09-16 17:07:59 +00:00