Commit Graph

26768 Commits

Author SHA1 Message Date
Sergey Biryukov
c1f6c6877c Formatting: Adjust wp_targeted_link_rel() to ensure JSON format is preserved and correct quotes are used when adding the missing rel attribute.
Props birgire, TobiasBg, fierevere, audrasjb, SergeyBiryukov.
Fixes #46316, #47244.
Built from https://develop.svn.wordpress.org/trunk@45348


git-svn-id: http://core.svn.wordpress.org/trunk@45159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 12:10:02 +00:00
Sergey Biryukov
e68fe165ae Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
Props ocean90, tobifjellner.
Fixes #47161.
Built from https://develop.svn.wordpress.org/trunk@45346


git-svn-id: http://core.svn.wordpress.org/trunk@45157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:50:58 +00:00
tellyworth
1d730f20e5 Upgrade/Install: Don't run signature verify on slow 32-bit systems.
The sodium_compat library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.

Props dd32, paragoninitiativeenterprises.
See #47186.

Built from https://develop.svn.wordpress.org/trunk@45345


git-svn-id: http://core.svn.wordpress.org/trunk@45156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 11:06:53 +00:00
tellyworth
b9782736b6 Upgrade/Install: Update sodium_compat to v1.10.0.
This adds a runtime_speed_test() method for estimating if the 32-bit implementation is fast enough for expensive computations.

Props paragoninitiativeenterprises.
See #47186.

Built from https://develop.svn.wordpress.org/trunk@45344


git-svn-id: http://core.svn.wordpress.org/trunk@45155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 10:58:51 +00:00
Andrew Ozz
80aee4ae87 jQuery: bring jquery.js back into the WordPress SVN repo and backport the patch from 3.4.0.
Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45342


git-svn-id: http://core.svn.wordpress.org/trunk@45153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 04:25:54 +00:00
Sergey Biryukov
e06afa8a80 Accessibility: In back-compat code added for get_search_form() in [44956], when checking the (previously boolean) $args value, account for non-strict comparison.
Props dkarfa, sachyya-sachet.
Fixes #47177. See #42057.
Built from https://develop.svn.wordpress.org/trunk@45340


git-svn-id: http://core.svn.wordpress.org/trunk@45151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 02:22:53 +00:00
Sergey Biryukov
00255ae0be Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
Props desrosj, mukesh27.
Fixes #46408.
Built from https://develop.svn.wordpress.org/trunk@45338


git-svn-id: http://core.svn.wordpress.org/trunk@45149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:08:53 +00:00
Sergey Biryukov
cbad1109f4 Site Health: Use correct singular string for plugin and theme version tests.
Props edocev, Presskopp.
Fixes #47264.
Built from https://develop.svn.wordpress.org/trunk@45336


git-svn-id: http://core.svn.wordpress.org/trunk@45147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 01:00:54 +00:00
Sergey Biryukov
4236a3522d I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Fixes #47159.
Built from https://develop.svn.wordpress.org/trunk@45334


git-svn-id: http://core.svn.wordpress.org/trunk@45145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:53:54 +00:00
Sergey Biryukov
a9fc042377 Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
Props dimadin, SergeyBiryukov.
Fixes #47161.
Built from https://develop.svn.wordpress.org/trunk@45331


git-svn-id: http://core.svn.wordpress.org/trunk@45142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 00:07:54 +00:00
Sergey Biryukov
9c1a666249 Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.
Props chesio.
Fixes #47297.
Built from https://develop.svn.wordpress.org/trunk@45328


git-svn-id: http://core.svn.wordpress.org/trunk@45139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 22:08:54 +00:00
desrosj
c6da25fa9a Privacy: Prevent email field for personal data requests from overflowing.
Props anischarolia, ianbelanger, afercia.
Fixes #46961.
Built from https://develop.svn.wordpress.org/trunk@45326


git-svn-id: http://core.svn.wordpress.org/trunk@45137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 20:45:54 +00:00
desrosj
1ef254a465 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.
Built from https://develop.svn.wordpress.org/trunk@45324


git-svn-id: http://core.svn.wordpress.org/trunk@45135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 19:05:53 +00:00
desrosj
ca7c9a8288 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.
Built from https://develop.svn.wordpress.org/trunk@45322


git-svn-id: http://core.svn.wordpress.org/trunk@45133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:30:53 +00:00
desrosj
913516fe5c Build/Test Tools: Upgrade node-sass to 4.12.0.
`node-sass` 4.12 adds support for Node 12. This will prevent errors for anyone running Node 12 locally instead of the LTS version (currently 10.15.3).

Props desrosj, aduth, netweb.
Fixes #47257.
Built from https://develop.svn.wordpress.org/trunk@45321


git-svn-id: http://core.svn.wordpress.org/trunk@45132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:15:55 +00:00
aduth
3c44f9e15a Block Editor: Upgrade WordPress packages to the latest versions.
Updated packages:

 - @wordpress/annotations@1.2.3
 - @wordpress/block-editor@2.0.2
 - @wordpress/block-library@2.4.5
 - @wordpress/blocks@6.2.5
 - @wordpress/components@7.3.2
 - @wordpress/dom@2.2.5
 - @wordpress/e2e-tests@1.1.5
 - @wordpress/edit-post@3.3.5
 - @wordpress/editor@9.2.5
 - @wordpress/format-library@1.4.5
 - @wordpress/list-reusable-blocks@1.3.5
 - @wordpress/nux@3.2.5
 - @wordpress/rich-text@3.2.3

Props: youknowriad, gwwar, iseulde, tfrommen, gziolo.

Fixes #47284.

Built from https://develop.svn.wordpress.org/trunk@45319


git-svn-id: http://core.svn.wordpress.org/trunk@45130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:08:00 +00:00
Andrew Ozz
0b4a421b50 Build tools: fix generating *-rtl.css files in wp-includes/css after grunt --dev was used.
Fixes #47078.
Built from https://develop.svn.wordpress.org/trunk@45317


git-svn-id: http://core.svn.wordpress.org/trunk@45128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 02:25:52 +00:00
Andrew Ozz
762b49653a Update TinyMCE to 4.9.4. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt.
Fixes #47229 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45316


git-svn-id: http://core.svn.wordpress.org/trunk@45127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 23:45:52 +00:00
desrosj
ac095904da Bootstrap/Load: Prevent PHP errors when a drop-in triggers fatal error protection.
When a drop-in (such as `advanced-cache.php`) contains a PHP error, additional PHP errors are caused when displaying the error protection screen because `load_default_textdomain()` and `WP_Error` are not yet available.

Though recovery mode is not supported for `mu-plugins` and drop-ins, fatal error protection is. This change ensures the error screen is displayed when a fatal error is encountered within a drop-in and not a white screen.

Props TimothyBlynJacobs, spacedmonkey, daxelrod.
Fixes #47265.
Built from https://develop.svn.wordpress.org/trunk@45311


git-svn-id: http://core.svn.wordpress.org/trunk@45122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 18:19:51 +00:00
desrosj
5173099abc Administration: Remove duplicate font-face declaration in Dashicons CSS.
This was causing console warnings in some browsers.

Props aduth, joen, afercia, timph, ianbelanger.
Fixes #47183.
Built from https://develop.svn.wordpress.org/trunk@45310


git-svn-id: http://core.svn.wordpress.org/trunk@45121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 16:08:57 +00:00
desrosj
f48f926077 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.
Built from https://develop.svn.wordpress.org/trunk@45309


git-svn-id: http://core.svn.wordpress.org/trunk@45120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 14:26:07 +00:00
desrosj
7d04482650 Site Health: Link to the correct plugin update screen in multisite installs.
Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189.
Built from https://develop.svn.wordpress.org/trunk@45308


git-svn-id: http://core.svn.wordpress.org/trunk@45119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 14:13:05 +00:00
Sergey Biryukov
1a24aaa380 Docs: Add a @see reference to WP_REST_Revisions_Controller in WP_REST_Autosaves_Controller DocBlock.
Props chintan1896.
Fixes #47232.
Built from https://develop.svn.wordpress.org/trunk@45307


git-svn-id: http://core.svn.wordpress.org/trunk@45116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 23:53:57 +00:00
Sergey Biryukov
afb68ae41d Docs: Add @see references to WP_Widget_Media in media widget DocBlocks.
Props iamjaydip.
Fixes #47231.
Built from https://develop.svn.wordpress.org/trunk@45306


git-svn-id: http://core.svn.wordpress.org/trunk@45115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 20:23:06 +00:00
Sergey Biryukov
cbd6fd7a30 Docs: Add missing @see tag to WP_REST_Post_Search_Handler DocBlock.
Props vishitshah.
Fixes #47230.
Built from https://develop.svn.wordpress.org/trunk@45305


git-svn-id: http://core.svn.wordpress.org/trunk@45114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 15:00:07 +00:00
Sergey Biryukov
6860a1d759 Docs: Convert @see reference in WP_REST_Request DocBlock to @link, to avoid a broken link in Developer Reference.
See #47110.
Built from https://develop.svn.wordpress.org/trunk@45304


git-svn-id: http://core.svn.wordpress.org/trunk@45113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-14 14:56:08 +00:00
Sergey Biryukov
b36a31ae14 Docs: Fix typo in wp_mail() description.
Props seedsca.
Fixes #47208.
Built from https://develop.svn.wordpress.org/trunk@45302


git-svn-id: http://core.svn.wordpress.org/trunk@45111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-10 09:53:54 +00:00
Andrea Fercia
1b3b04f354 Accessibility: Improve the "skip links" position for medium and small screens.
Fixes #47065.

Built from https://develop.svn.wordpress.org/trunk@45301


git-svn-id: http://core.svn.wordpress.org/trunk@45110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 21:12:02 +00:00
Andrea Fercia
9cc696fbce Accessibility: Add aria-current to the links in the <nav> elements introduced in [44905].
Also fixes a few translators comments and coding standards.

Props audrasjb.
Fixes #47106.

Built from https://develop.svn.wordpress.org/trunk@45300


git-svn-id: http://core.svn.wordpress.org/trunk@45109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 20:58:54 +00:00
desrosj
dfd4641dc3 Twenty Nineteen: Fix Docblock spelling error.
Props mukesh27.
Fixes #47129.
Built from https://develop.svn.wordpress.org/trunk@45299


git-svn-id: http://core.svn.wordpress.org/trunk@45108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 20:08:55 +00:00
desrosj
d0f46bf73c I18N: Combine similar strings with minor differences.
Props dimadin.
Fixes #47158.
Built from https://develop.svn.wordpress.org/trunk@45298


git-svn-id: http://core.svn.wordpress.org/trunk@45107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 19:48:53 +00:00
desrosj
770323b4de Twenty Nineteen: Remove duplicate code block.
Introduced in [44305].

Props mukesh27, afercia.
Fixes #46455.
Built from https://develop.svn.wordpress.org/trunk@45297


git-svn-id: http://core.svn.wordpress.org/trunk@45106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 18:04:55 +00:00
desrosj
71f9170c08 Administration: Prevent cards on the Tools page from overflowing on small screens.
Props anischarolia, mukesh27.
Fixes #46972.
Built from https://develop.svn.wordpress.org/trunk@45296


git-svn-id: http://core.svn.wordpress.org/trunk@45105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-09 14:56:56 +00:00
desrosj
bfcd57d327 Help/About: Update the 5.2 tagline on Freedoms and Credits.
Props ocean90.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45292


git-svn-id: http://core.svn.wordpress.org/trunk@45101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 20:00:54 +00:00
laurelfulford
678e940ee7 Default Themes: Bump the version numbers and release dates.
Update the theme versions and release dates for the default themes, in time for WordPress 5.2.

The POT files for Twenty Eleven and Twenty Ten have also been updated.

Fixes #47172.


Built from https://develop.svn.wordpress.org/trunk@45289


git-svn-id: http://core.svn.wordpress.org/trunk@45098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 18:49:53 +00:00
desrosj
c4062c75a7 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45287


git-svn-id: http://core.svn.wordpress.org/trunk@45096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-07 17:19:55 +00:00
Andrew Ozz
e464f03549 Fix setup_postdata() to set the (inside the loop) globals before the_post action is fired. Follow-up from #42814 and [44941].
Props david.binda, spacedmonkey, boonebgorges, birgire, jorbin, azaozz.
Fixes #47114 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45285


git-svn-id: http://core.svn.wordpress.org/trunk@45094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-04 21:00:52 +00:00
desrosj
3d84726ae8 Editor: Correct since annotation for the excerpt_allowed_blocks filter.
Props mukesh27, rabmalin.
Fixes #47079.
Built from https://develop.svn.wordpress.org/trunk@45284


git-svn-id: http://core.svn.wordpress.org/trunk@45093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-03 16:54:52 +00:00
desrosj
b431b2ff62 Update the package-lock.json file to 5.3.0.
Built from https://develop.svn.wordpress.org/trunk@45283


git-svn-id: http://core.svn.wordpress.org/trunk@45092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-03 16:52:52 +00:00
Aaron Jorbin
d0364fc65a Trunk is now 5.3 alpha
Built from https://develop.svn.wordpress.org/trunk@45282


git-svn-id: http://core.svn.wordpress.org/trunk@45091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:28:55 +00:00
desrosj
a1f4b046d7 Post WordPress 5.2 RC2 version bump.
Built from https://develop.svn.wordpress.org/trunk@45280


git-svn-id: http://core.svn.wordpress.org/trunk@45089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:13:54 +00:00
desrosj
0aa044f0e1 WordPress 5.2 RC2.
Built from https://develop.svn.wordpress.org/trunk@45279


git-svn-id: http://core.svn.wordpress.org/trunk@45088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 16:04:51 +00:00
desrosj
3360974ad2 Help/About: Polish the About page for 5.2.
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45278


git-svn-id: http://core.svn.wordpress.org/trunk@45087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 15:44:53 +00:00
desrosj
d48b709071 Bootstrap/Load: Ensure recovery link email and related notices are properly translated.
When recovery mode is triggered before the site’s locale has been initialized, the message displayed to the user and the email sent to the site administrator with the recovery mode link are always rendered in `en_US`. This change ensures the site’s locale is used even when an error happens early in the loading process.

Reviewed by swissspidy, SergeyBiryukov, and desrosj.

Props wolly, TimothyBlynJacobs, fierevere.
Fixes #47093.
Built from https://develop.svn.wordpress.org/trunk@45277


git-svn-id: http://core.svn.wordpress.org/trunk@45086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:53:52 +00:00
desrosj
d53659ed71 Help/About: Fix tab display issues.
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.
Built from https://develop.svn.wordpress.org/trunk@45276


git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-02 10:37:51 +00:00
desrosj
6ac1d4ec1a Site Health: Disable recommendations that could be problematic on multisite installs.
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.

For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.

This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite.

Reviewed by jeremyfelt and desrosj.

Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084.
Built from https://develop.svn.wordpress.org/trunk@45275


git-svn-id: http://core.svn.wordpress.org/trunk@45084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-01 18:08:53 +00:00
Aaron Jorbin
e4a0fd4c01 Admin: Add some additional clarity to some about page links
It's important for links to have enough information in them in order to be clearly actionable. Destination and purpose should be clear. For example, `debug` isn't nearly as useful as `learn how to debug issues`.

This was signed off on by chanthaboune and jorbin.

Props afercia.
See: #46901.


Built from https://develop.svn.wordpress.org/trunk@45274


git-svn-id: http://core.svn.wordpress.org/trunk@45083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-30 17:31:55 +00:00
Gary Pendergast
0344202063 Post WordPress 5.2 RC1 version bump
Built from https://develop.svn.wordpress.org/trunk@45273


git-svn-id: http://core.svn.wordpress.org/trunk@45082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 01:23:53 +00:00
Gary Pendergast
754dca460c WordPress 5.2 RC1
Built from https://develop.svn.wordpress.org/trunk@45272


git-svn-id: http://core.svn.wordpress.org/trunk@45081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 01:15:52 +00:00
Gary Pendergast
d86524f09d Admin: Add the text for the WordPress 5.2 About page.
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.


Built from https://develop.svn.wordpress.org/trunk@45271


git-svn-id: http://core.svn.wordpress.org/trunk@45080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-26 00:57:53 +00:00