Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-29 04:28:07 +01:00
Code Issues Projects Releases Wiki Activity
26,504 Commits 50 Branches 749 Tags 806 MiB
c2a3f4fab5
Commit Graph

14153 Commits

Author SHA1 Message Date
Sergey Biryukov
e269d48b99 Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard. 
props ghost1227.
fixes #26754.
Built from https://develop.svn.wordpress.org/trunk@28599


git-svn-id: http://core.svn.wordpress.org/trunk@28424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 13:42:14 +00:00
Sergey Biryukov
13cbcdd1ad Fix SlideShare oEmbed regex. 
props kovshenin.
fixes #28380.
Built from https://develop.svn.wordpress.org/trunk@28597


git-svn-id: http://core.svn.wordpress.org/trunk@28422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 13:32:17 +00:00
Scott Taylor
7e74b8909e RIP Viddler oEmbed support. 
More: https://gigaom.com/2014/02/07/viddler-gets-ready-to-delete-personal-videos/

See #28379.


Built from https://develop.svn.wordpress.org/trunk@28596


git-svn-id: http://core.svn.wordpress.org/trunk@28421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 22:00:14 +00:00
Scott Taylor
c5790a80fc Update the Scribd oEmbed pattern to more actually represent which endpoints from the site are discoverable. 
See #28379.

Built from https://develop.svn.wordpress.org/trunk@28595


git-svn-id: http://core.svn.wordpress.org/trunk@28420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 21:55:14 +00:00
Scott Taylor
987e9905ac When parsing an [embed] shortcode into a TinyMCE view, don't attempt to append any returned <script>s to the editor's <head>. This affects only a few supported endpoints: Issuu and Twitter. 
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28594


git-svn-id: http://core.svn.wordpress.org/trunk@28419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 20:00:15 +00:00
Scott Taylor
cb68638968 For YouTube playlist oEmbed, we need keep BC for wp_oembed_remove_provider() by not changing the existing YouTube endpoint keys. So, rather than merging the rules, the playlist endpoints should be on their own line. 
Props kovshenin.

See #28125, [28552].

Built from https://develop.svn.wordpress.org/trunk@28593


git-svn-id: http://core.svn.wordpress.org/trunk@28418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 18:43:14 +00:00
Sergey Biryukov
12ea0c3045 Pass anchor text to 'edit_post_link' and 'edit_comment_link' filters. 
props kwight.
fixes #28373.
Built from https://develop.svn.wordpress.org/trunk@28590


git-svn-id: http://core.svn.wordpress.org/trunk@28415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 13:43:14 +00:00
Sergey Biryukov
aab2e48fa0 Update documentation for is_new_day(). 
props obenland.
fixes #28333.
Built from https://develop.svn.wordpress.org/trunk@28588


git-svn-id: http://core.svn.wordpress.org/trunk@28413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 11:41:14 +00:00
Sergey Biryukov
f4a6632200 Clean up wp_widget_rss_output(): 
* Fix appending [&hellip;] to $summary.
* Use wp_trim_words() instead of wp_html_excerpt().
* Trim $title before checking if it's empty. props UmeshSingla.
* Use correct escaping function for $title.

fixes #28356.
Built from https://develop.svn.wordpress.org/trunk@28586


git-svn-id: http://core.svn.wordpress.org/trunk@28411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 11:08:14 +00:00
Sergey Biryukov
2b6c8462b3 Avoid a PHP notice in adjacent_image_link() if no images were found. 
props nabil_kadimi.
see #28361.
Built from https://develop.svn.wordpress.org/trunk@28584


git-svn-id: http://core.svn.wordpress.org/trunk@28409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 10:55:16 +00:00
Scott Taylor
8653099a83 In wp_get_object_terms(), before returning terms (and before running them through the 'wp_get_object_terms' filter) - run them through $terms = array_values( array_unique( $terms, SORT_REGULAR ) ). 
There will be "dupes" when the function is called with `'fields' => 'all_with_object_id'`, but the objects will actually be unique due to the `object_id` addition, so they shouldn't be filtered out. 

Adds unit tests. All other unit tests pass.

Fixes #11003.

Built from https://develop.svn.wordpress.org/trunk@28583


git-svn-id: http://core.svn.wordpress.org/trunk@28408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 03:29:14 +00:00
Scott Taylor
714aae91ea Fix some inline docs churn in wp_insert_post() after [28579]. 
Props kpdesign.
See #21963.


Built from https://develop.svn.wordpress.org/trunk@28582


git-svn-id: http://core.svn.wordpress.org/trunk@28407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-27 00:24:15 +00:00
Scott Taylor
3c1723afd7 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.

Built from https://develop.svn.wordpress.org/trunk@28581


git-svn-id: http://core.svn.wordpress.org/trunk@28406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:57:14 +00:00
Scott Taylor
89864b4a5a Don't pass embeds through the_content() when trying to render MCE previews, leverage WP_Embed and do_shortcode() instead. 
Props kovshenin.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28580


git-svn-id: http://core.svn.wordpress.org/trunk@28405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:43:15 +00:00
Scott Taylor
b184336927 Combine wp_insert_attachment() and wp_insert_post(). wp_insert_attachment() becomes a wrapper. Update inline docs. 
Props wonderboymusic, DrewAPicture.
See #21963.

Built from https://develop.svn.wordpress.org/trunk@28579


git-svn-id: http://core.svn.wordpress.org/trunk@28404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:20:13 +00:00
Scott Taylor
f3e71ae45f Add oEmbed support for Mixcloud. 
Props Jayjdk.
Fixes #27169.


Built from https://develop.svn.wordpress.org/trunk@28578


git-svn-id: http://core.svn.wordpress.org/trunk@28403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 23:09:14 +00:00
Scott Taylor
746397f18b Allow the settings view for galleries to be disabled when instantiating wp.media.controller.GalleryEdit. 
Props nd987.
Fixes #23116.

Built from https://develop.svn.wordpress.org/trunk@28577


git-svn-id: http://core.svn.wordpress.org/trunk@28402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-26 22:49:16 +00:00
Andrew Ozz
1ba1b3ec29 TinyMCE: fix saving the editor content on switching Visual -> Text, fixes #28353 
Built from https://develop.svn.wordpress.org/trunk@28576


git-svn-id: http://core.svn.wordpress.org/trunk@28401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 22:47:13 +00:00
Sergey Biryukov
4238d2f53f Fix typo in [28574]. 
see #28360.
Built from https://develop.svn.wordpress.org/trunk@28575


git-svn-id: http://core.svn.wordpress.org/trunk@28400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 16:12:14 +00:00
Sergey Biryukov
ccb6ba9446 Replace $in_same_cat with $in_same_term in adjacent post functions for consistency. 
props ixkaito.
fixes #28360.
Built from https://develop.svn.wordpress.org/trunk@28574


git-svn-id: http://core.svn.wordpress.org/trunk@28399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 16:10:13 +00:00
Sergey Biryukov
de9a9fd8ea Suggest get_current_site() as an alternative for get_current_site_name(). 
props jesin.
fixes #28346.
Built from https://develop.svn.wordpress.org/trunk@28573


git-svn-id: http://core.svn.wordpress.org/trunk@28398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-25 14:32:16 +00:00
Sergey Biryukov
4782165279 Fix inversed logic in Walker_Category::start_el(). see [28359]. 
Correct 'use_desc_for_title' parameter description.

see #26557.
Built from https://develop.svn.wordpress.org/trunk@28572


git-svn-id: http://core.svn.wordpress.org/trunk@28397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 13:42:15 +00:00
Sergey Biryukov
ac434b5c39 Pass $post to 'protected_title_format' and 'private_title_format' filters. 
props johnjamesjacoby, DrewAPicture.
fixes #23724.
Built from https://develop.svn.wordpress.org/trunk@28571


git-svn-id: http://core.svn.wordpress.org/trunk@28396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 06:48:16 +00:00
Drew Jaynes
3e0521c2cf Add inline documentation for the option_none_value argument added to wp_dropdown_users|categories() in [28564]. 
Fixes #16625.

Built from https://develop.svn.wordpress.org/trunk@28570


git-svn-id: http://core.svn.wordpress.org/trunk@28395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 05:39:15 +00:00
Drew Jaynes
a1955d78ee Use three-digit x.x.x style version for @deprecated phpDoc tags. 
See #18298.

Built from https://develop.svn.wordpress.org/trunk@28569


git-svn-id: http://core.svn.wordpress.org/trunk@28394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 05:23:14 +00:00
Andrew Ozz
f7186fb198 TinyMCE: update to 4.0.26. Includes fixes for the 'paste' plugin (paste from Word/Excel, paste in WebKit/Blink), show/hide/isHidden in inline mode, drag/drop in tables and in Safari, and others. Fixes #28342, #28016, #28250 and #28067 
Built from https://develop.svn.wordpress.org/trunk@28568


git-svn-id: http://core.svn.wordpress.org/trunk@28393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-24 01:44:15 +00:00
Andrew Ozz
8bc84c0441 wpView: fix selecting a view's text string in Safari, props gcorne, fixes #28088 
Built from https://develop.svn.wordpress.org/trunk@28565


git-svn-id: http://core.svn.wordpress.org/trunk@28391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 20:56:14 +00:00
Scott Taylor
53ea68e838 wp_dropdown_pages() allows option_none_value to be passed. Add that arg to the $defaults for wp_dropdown_users() and wp_dropdown_categories() as well. 
Props solarissmoke. 
Fixes #16625.

Built from https://develop.svn.wordpress.org/trunk@28564


git-svn-id: http://core.svn.wordpress.org/trunk@28390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 20:47:15 +00:00
Scott Taylor
b75c79500b Replaces all uses of TEMPLATEPATH and STYLESHEETPATH in core with get_template_directory() and get_stylesheet_directory(). 
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.

Built from https://develop.svn.wordpress.org/trunk@28563


git-svn-id: http://core.svn.wordpress.org/trunk@28389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 20:12:15 +00:00
Scott Taylor
44c4b365a0 When adding queries to tax_query: if the query's field is term_taxonomy_id, don't require taxonomy to be specified. In WP_Tax_Query::transform_query(), $query['taxonomy'] is never checked for the 'term_taxonomy_id' case because 'term_taxonomy_id' is the primary key being looked up. 
Adds unit tests.

Props helen.
Fixes #25284.


Built from https://develop.svn.wordpress.org/trunk@28562


git-svn-id: http://core.svn.wordpress.org/trunk@28388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 19:59:14 +00:00
Scott Taylor
f50d5233f3 Truly check for ! empty() instead of falsey '' when determining whether to add LIMIT clause to SQL in wp_get_archives(). 
Props jjeaton for the initial patch.
Fixes #27834.

Built from https://develop.svn.wordpress.org/trunk@28560


git-svn-id: http://core.svn.wordpress.org/trunk@28386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 18:28:14 +00:00
Scott Taylor
3214d6d325 Read the src attribute for the [embed] shortcode if the shortcode's body is empty. 
These work:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]`
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"][/embed]`

If you do:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]http://any-other-url.com[/embed]`

... "http://any-other-url.com" will be the URL that is parsed.

Props kovshenin, aaroncampbell for making initial patches.
Fixes #24456.


Built from https://develop.svn.wordpress.org/trunk@28559


git-svn-id: http://core.svn.wordpress.org/trunk@28385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 18:06:13 +00:00
Scott Taylor
e8181b0934 Allow get_comments_number() to officially accept $post or $post_id. Adds unit tests. 
Props coffee2code, JanHenkG.
Fixes #26240.

Built from https://develop.svn.wordpress.org/trunk@28558


git-svn-id: http://core.svn.wordpress.org/trunk@28384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 17:44:14 +00:00
John Blackbourn
03410a4067 Add CollegeHumor.com oEmbed support. Fixes #24497. Props johnzanussi. 
Built from https://develop.svn.wordpress.org/trunk@28557


git-svn-id: http://core.svn.wordpress.org/trunk@28383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 23:47:15 +00:00
Scott Taylor
10e1d66318 Viddler has had a new oEmbed endpoint for at least 10 months. Let us update to it. 
Props garhdez.
Fixes #24296.

Built from https://develop.svn.wordpress.org/trunk@28556


git-svn-id: http://core.svn.wordpress.org/trunk@28382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 23:17:15 +00:00
Scott Taylor
fe044c84f7 Support Polldaddy's short URL format as a whitelisted oEmbed provider. 
Props donncha.
Fixes #28283.


Built from https://develop.svn.wordpress.org/trunk@28555


git-svn-id: http://core.svn.wordpress.org/trunk@28381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 23:13:14 +00:00
Scott Taylor
ee43d258c2 Add Issuu to list of whitelisted oEmbed providers. 
Props issuu.
Fixes #28312.


Built from https://develop.svn.wordpress.org/trunk@28554


git-svn-id: http://core.svn.wordpress.org/trunk@28380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:50:14 +00:00
Scott Taylor
8d4d645629 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php. 
Props _duck.
Fixes #20672.


Built from https://develop.svn.wordpress.org/trunk@28553


git-svn-id: http://core.svn.wordpress.org/trunk@28379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:36:15 +00:00
Scott Taylor
e0a57ed96a Support oEmbed matching for YouTube playlist URLs. 
Fixes #28125.

Built from https://develop.svn.wordpress.org/trunk@28552


git-svn-id: http://core.svn.wordpress.org/trunk@28378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 21:12:15 +00:00
Scott Taylor
fcd6920bb8 In is_user_option_local(), $user_id is set conditionally, but never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28551


git-svn-id: http://core.svn.wordpress.org/trunk@28377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:18:14 +00:00
Scott Taylor
dd25ef25d9 $count is set in get_post_galleries() and never used, relic from PFUI RIP. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28550


git-svn-id: http://core.svn.wordpress.org/trunk@28376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:13:14 +00:00
Scott Taylor
abff6bf6cf $gallery_div is set twice in gallery_shortcode() before it is used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28549


git-svn-id: http://core.svn.wordpress.org/trunk@28375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:12:14 +00:00
Scott Taylor
09046cb2a3 In get_attachment_icon_src(), $class is set in 2 conditions but never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28548


git-svn-id: http://core.svn.wordpress.org/trunk@28374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:08:14 +00:00
Scott Taylor
c5ba45a11b break is unreachable in WP_Theme::translate_header(). 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28547


git-svn-id: http://core.svn.wordpress.org/trunk@28373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:05:14 +00:00
Scott Taylor
6177a39971 In WP_Customize_Manager::register_controls(), $menu_locations is set and never used. 
Built from https://develop.svn.wordpress.org/trunk@28546


git-svn-id: http://core.svn.wordpress.org/trunk@28372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 19:01:15 +00:00
Sergey Biryukov
fdaa694ac7 Remove unnecessary array_reverse() from wp_get_post_revisions(). 
WP_Query properly handles multiple 'orderby' values since [28541].

fixes #26042.
Built from https://develop.svn.wordpress.org/trunk@28543


git-svn-id: http://core.svn.wordpress.org/trunk@28369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:51:14 +00:00
Scott Taylor
e4bc49c244 Because PHP can be configured without --filter, it is not 100% safe to use filter_var(). This is problematic for casting "false" to false, as PHP always casts it to true. FILTER_VALIDATE_BOOLEAN fixes this, but it may not be available. 
Add a new function, `wp_validate_boolean()`, to replace `filter_var( $var, FILTER_VALIDATE_BOOLEAN )`.

Fixes #28170.


Built from https://develop.svn.wordpress.org/trunk@28542


git-svn-id: http://core.svn.wordpress.org/trunk@28368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:34:15 +00:00
Scott Taylor
333083debe Apply order to each passed value for orderby in WP_Query: 
* Since `orderby` in `WP_Query` can accept space-delimited sets, yet only one `order` value: when multiple values are passed (and `DESC` is the order), the default sort order `ASC` is being applied to all values before the last in the set.
* There is a unit test that sporadically fails since 3.6 in `tests/post/revision` due to multiple posts having the same `post_date` from being added so rapidly
* When ordering revisions in `wp_get_post_revisions()`, order by `post_date ID`
* Change the `order` value in `wp_get_post_revisions()` to `ASC`. This will produce SQL like: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID ASC`. Previously, this would have produced SQL like: `ORDER BY $wpdb->posts.post_date DESC`, and with the addition of ` ID`: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID DESC`. Clearly, wrong. The original SQL produced: `ORDER BY $wpdb->posts.post_date DESC`. As such, return the reversions in reverse order using `array_reverse()`. Not doing so would break "Preview Changes."
* Add unit tests to assert that all of this works.
* All existing unit tests pass with the change to ordering multiple `orderby`s in `WP_Query`.
* In the future, we should support independent `order` for each `orderby`, see #17065.

Props SergeyBiryukov, wonderboymusic.
Fixes #26042.

Built from https://develop.svn.wordpress.org/trunk@28541


git-svn-id: http://core.svn.wordpress.org/trunk@28367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 18:19:13 +00:00
Sergey Biryukov
9b9b8ec413 Use correct variable. see [28534], [28538]. 
see #22400.
Built from https://develop.svn.wordpress.org/trunk@28540


git-svn-id: http://core.svn.wordpress.org/trunk@28366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:40:14 +00:00
Scott Taylor
b8d469600b These functions import $wpdb but do not use it. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28539


git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:37:14 +00:00
Sergey Biryukov
f4646b47e7 Remove redundant assignment. see [28379], [28534]. 
see #22400.
Built from https://develop.svn.wordpress.org/trunk@28538


git-svn-id: http://core.svn.wordpress.org/trunk@28364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-22 17:35:13 +00:00
Scott Taylor
62f9e7636d Fix some bad UI recursion in wp_get_archives() caused by [28379]. It appears that $afterafter was appropriately named. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28534


git-svn-id: http://core.svn.wordpress.org/trunk@28360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-20 23:09:16 +00:00
Scott Taylor
affe27e5d1 WP_Query was only missing one access modifier. 
Add access modifier (`public`) to applicable class methods/members of `WP_Rewrite`. I am not brave enough to set some of the `var`s to `private` without more testing.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28533


git-svn-id: http://core.svn.wordpress.org/trunk@28359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:41:13 +00:00
Scott Taylor
49af14fde0 WP_Date_Query was only missing one access modifier. 
Add access modifier (`public`) to all default widgets' class methods.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28532


git-svn-id: http://core.svn.wordpress.org/trunk@28358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:30:17 +00:00
Scott Taylor
7de0b2b2c8 Upgrade _WP_List_Table_Compat to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28531


git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 17:20:17 +00:00
Scott Taylor
ab6d069f59 Add access modifiers to WP_User_Query. 
Add magic methods for BC: __get(), __set(), __isset(), __unset(), and
__call().

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28528


git-svn-id: http://core.svn.wordpress.org/trunk@28354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 15:48:15 +00:00
Scott Taylor
146810ed8f Add public access modifier to methods/members of WP_Widget and WP_Widget_Factory. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28527


git-svn-id: http://core.svn.wordpress.org/trunk@28353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 15:42:13 +00:00
Scott Taylor
fd5e6b5f6b In wpdb, make some things explicitly public. Do not set anything to private. This would instantly blow up hyperdb in the wild. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28526


git-svn-id: http://core.svn.wordpress.org/trunk@28352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 15:36:13 +00:00
Scott Taylor
e8812f9d8a Add access modifiers to WP_Text_Diff_Renderer_Table that are compatible with its parent class. Some of the inline docs suggest access that, if implemented, would produce fatal errors. 
Add magic methods for BC: __get(), __set(), __isset(), __unset(), and __call().

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28525


git-svn-id: http://core.svn.wordpress.org/trunk@28351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 15:23:14 +00:00
Scott Taylor
85f73cf458 Classes that have __set() also need __isset() and __unset(). 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28524


git-svn-id: http://core.svn.wordpress.org/trunk@28350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:52:14 +00:00
Scott Taylor
949cfd7a34 Add missing access modifiers to methods in WP_Query. Add magic methods for __get(), __set(), __isset(), __unset(), and __call(). 
Add unit test for magic methods.

See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28523


git-svn-id: http://core.svn.wordpress.org/trunk@28349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:49:16 +00:00
Scott Taylor
b539c1cd76 Add missing access modifiers to methods in WP_Meta_Query. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28522


git-svn-id: http://core.svn.wordpress.org/trunk@28348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:35:14 +00:00
Scott Taylor
821246b4ae Some classes with __get() method also need __set(). 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28521


git-svn-id: http://core.svn.wordpress.org/trunk@28347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:31:15 +00:00
Scott Taylor
2e9ce6fc87 Fix fatal error in unit test. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28520


git-svn-id: http://core.svn.wordpress.org/trunk@28346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:25:14 +00:00
Scott Taylor
40fab485aa Add missing access modifiers to methods in WP_Comment_Query. Add a magic __call() method for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28519


git-svn-id: http://core.svn.wordpress.org/trunk@28345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:19:14 +00:00
Scott Taylor
5030fdef62 Add missing access modifiers to methods in WP_Scripts and WP_Styles. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28518


git-svn-id: http://core.svn.wordpress.org/trunk@28344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:17:14 +00:00
Scott Taylor
f998ac39d3 Add missing access modifiers to methods in WP_Dependencies and _WP_Dependency. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28517


git-svn-id: http://core.svn.wordpress.org/trunk@28343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:14:14 +00:00
Scott Taylor
dc24cef605 Add missing access modifiers to methods in WP and WP_MatchesMapRegex. Add magic __call() and __get() methods to WP_MatchesMapRegex for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28516


git-svn-id: http://core.svn.wordpress.org/trunk@28342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:12:14 +00:00
Scott Taylor
25a70283e1 Add missing access modifiers to methods in wp_xmlrpc_server. Add a magic __call() method for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28515


git-svn-id: http://core.svn.wordpress.org/trunk@28341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:09:13 +00:00
Scott Taylor
dfa4de15fa Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:00:15 +00:00
Scott Taylor
df8a090193 Add missing access modifiers to methods/members in WP_Image_Editor_* classes. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28513


git-svn-id: http://core.svn.wordpress.org/trunk@28339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:53:14 +00:00
Scott Taylor
dd25163346 Add access modifiers to methods/members in WP_HTTP_IXR_Client. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28512


git-svn-id: http://core.svn.wordpress.org/trunk@28338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:51:15 +00:00
Scott Taylor
72d096b007 Add access modifiers to methods/members in WP_Error. Add a magic __get() method for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28511


git-svn-id: http://core.svn.wordpress.org/trunk@28337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:50:14 +00:00
Scott Taylor
aabcfd658b Add access modifiers to methods/members in WP_Embed. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28510


git-svn-id: http://core.svn.wordpress.org/trunk@28336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:47:14 +00:00
Scott Taylor
3c209b6f56 Add missing access modifiers to methods/members in WP_Customize_*. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28509


git-svn-id: http://core.svn.wordpress.org/trunk@28335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:45:16 +00:00
Scott Taylor
4938497b3a Add access modifier to methods/members in WP_Ajax_Response. Adds a magic __get() method for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28508


git-svn-id: http://core.svn.wordpress.org/trunk@28334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:41:14 +00:00
Scott Taylor
27e8d17be2 Add access modifier to methods/members in WP_oEmbed. Adds a magic __call() method for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28507


git-svn-id: http://core.svn.wordpress.org/trunk@28333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:37:13 +00:00
Scott Taylor
d6e5fcab4d Add access modifier to methods of HTTP classes. There are no new private or protected methods, so no need for __call(). 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28506


git-svn-id: http://core.svn.wordpress.org/trunk@28332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:34:15 +00:00
Scott Taylor
35fb2e48e0 Add access modifiers to methods/members in WP_Feed_Cache, WP_SimplePie_File, and WP_Feed_Cache_Transient. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28505


git-svn-id: http://core.svn.wordpress.org/trunk@28331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:27:15 +00:00
Scott Taylor
ddfb1e20d2 Add access modifiers to methods/members in Walker_Category and Walker_CategoryDropdown. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28504


git-svn-id: http://core.svn.wordpress.org/trunk@28330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:23:14 +00:00
Scott Taylor
f172ef8ce2 Add access modifiers to methods/members in WP_Roles. Add a magic __call() method for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28503


git-svn-id: http://core.svn.wordpress.org/trunk@28329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:20:14 +00:00
Scott Taylor
d9cd56f9ad Add access modifiers to methods/members in WP_Object_Cache. Add a magic __get() method for BC. 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28502


git-svn-id: http://core.svn.wordpress.org/trunk@28328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:16:15 +00:00
Scott Taylor
5d72cd4949 In wp_list_bookmarks(), $categorize should now be $r['categorize]. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28501


git-svn-id: http://core.svn.wordpress.org/trunk@28327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:11:14 +00:00
Scott Taylor
2f513d3320 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 05:04:16 +00:00
Drew Jaynes
c7c563532b Improve inline documentation of default arguments for the_title_attribute(). 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28498


git-svn-id: http://core.svn.wordpress.org/trunk@28324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 02:28:14 +00:00
Scott Taylor
b9afafffe3 hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28479


git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 20:52:15 +00:00
Drew Jaynes
11dd3443a2 Improve inline documentation for default arguments in wp_get_archives(). 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@28476


git-svn-id: http://core.svn.wordpress.org/trunk@28303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-18 17:20:15 +00:00
Scott Taylor
87730b879f Eliminate the use of extract() in MO::import_from_reader(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28472


git-svn-id: http://core.svn.wordpress.org/trunk@28299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 17:21:14 +00:00
Scott Taylor
f4661c6659 Eliminate the use of extract() in get_pages(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28471


git-svn-id: http://core.svn.wordpress.org/trunk@28298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 17:12:15 +00:00
Scott Taylor
1bd4118799 Eliminate the use of extract() in wp_insert_attachment(). 
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28470


git-svn-id: http://core.svn.wordpress.org/trunk@28297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 16:54:14 +00:00
Scott Taylor
73a9ba7428 Eliminate the use of extract() in wp_insert_post(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28469


git-svn-id: http://core.svn.wordpress.org/trunk@28296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 15:53:15 +00:00
Scott Taylor
eea7052df8 Eliminate the use of extract() in wp_delete_term(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28466


git-svn-id: http://core.svn.wordpress.org/trunk@28293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 14:55:14 +00:00
Scott Taylor
bec9993f38 Eliminate the use of extract() in get_terms(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28465


git-svn-id: http://core.svn.wordpress.org/trunk@28292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 14:47:14 +00:00
Scott Taylor
c1b5670a00 Eliminate the use of extract() in wp_insert_term(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28464


git-svn-id: http://core.svn.wordpress.org/trunk@28291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-17 14:16:14 +00:00
Scott Taylor
66c3f62a54 Eliminate use of extract() in wp_update_term(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28461


git-svn-id: http://core.svn.wordpress.org/trunk@28288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 21:29:13 +00:00
Scott Taylor
a39aecc9b1 The cache key for comments in WP_Comment_Query::query() needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) ) instead of compact( array_keys( $defaults ) ). The latter assumes all of those variables are still floating around. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28460


git-svn-id: http://core.svn.wordpress.org/trunk@28287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 21:09:14 +00:00
Scott Taylor
0aafc8f874 (ACTUALLY) Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28459


git-svn-id: http://core.svn.wordpress.org/trunk@28286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 20:52:14 +00:00
Scott Taylor
4f57a231c5 Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28458


git-svn-id: http://core.svn.wordpress.org/trunk@28285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 19:33:14 +00:00
Scott Taylor
14ba67c38d Eliminate use of extract() in wp_insert_comment(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28457


git-svn-id: http://core.svn.wordpress.org/trunk@28284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:52:16 +00:00
Andrew Ozz
f184243aa3 DFW: fix closing only the wpLink or media modal when pressing Esc. 
Built from https://develop.svn.wordpress.org/trunk@28455


git-svn-id: http://core.svn.wordpress.org/trunk@28282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:17:14 +00:00
Scott Taylor
877fad9f38 Eliminate use of extract() in wp_insert_user(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28454


git-svn-id: http://core.svn.wordpress.org/trunk@28281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:15:15 +00:00
Scott Taylor
a25e03f833 In wp_xmlrpc_server::mw_editPost, also set $post_type = $postdata['post_type']. 
See #22400, [28448].


Built from https://develop.svn.wordpress.org/trunk@28453


git-svn-id: http://core.svn.wordpress.org/trunk@28280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:06:15 +00:00
Scott Taylor
fdaea6b7f2 Eliminate use of extract() in wp_widget_rss_form(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28449


git-svn-id: http://core.svn.wordpress.org/trunk@28276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 15:38:14 +00:00
Scott Taylor
463b7c4620 Eliminate use of extract() in wp_xmlrpc_server::mw_editPost() (MetaWeblog API, y'all). 
A lot of the extracted variables are overwritten by being explicitly set later. 
Only set variables that would otherwise not be present with `compact()` is called.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28448


git-svn-id: http://core.svn.wordpress.org/trunk@28275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 15:19:14 +00:00
Sergey Biryukov
5c2d25aa77 Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings. 
props GaVrA.
fixes #23800.
Built from https://develop.svn.wordpress.org/trunk@28444


git-svn-id: http://core.svn.wordpress.org/trunk@28271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 11:10:14 +00:00
Sergey Biryukov
abc830ca9d DFW: Properly handle Esc key when the content is focused or when switching browser tabs. 
props avryl.
fixes #28279.
Built from https://develop.svn.wordpress.org/trunk@28443


git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 10:43:14 +00:00
Sergey Biryukov
d970ac80c6 Don't include caption tags in gallery template when there is no caption. 
props avryl.
fixes #28089.
Built from https://develop.svn.wordpress.org/trunk@28442


git-svn-id: http://core.svn.wordpress.org/trunk@28269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 21:03:15 +00:00
Scott Taylor
5a5c86139f Eliminate use of extract() in wp_get_object_terms(). 
There are 3 properties, just set them to variables. They are used too often to warrant a refactor.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28441


git-svn-id: http://core.svn.wordpress.org/trunk@28268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 19:58:15 +00:00
Scott Taylor
6e8e30bb1e Eliminate use of extract() in wp_widget_rss_output(). 
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback). 
Every other default arg has a default value of `0`.

`items` is expected to always be passed to this function.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28440


git-svn-id: http://core.svn.wordpress.org/trunk@28267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 19:42:13 +00:00
Scott Taylor
157f811a5e Eliminate use of extract() in WP_Widget_RSS::widget(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28439


git-svn-id: http://core.svn.wordpress.org/trunk@28266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 19:36:15 +00:00
Scott Taylor
72fd658cde In Walker_Category::start_el(), $title might not be set when $args are passed multiple levels into walk_category_tree(). 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28438


git-svn-id: http://core.svn.wordpress.org/trunk@28265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 19:14:14 +00:00
Scott Taylor
2a3548fe70 Eliminate use of extract() in wp_allow_comment(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28437


git-svn-id: http://core.svn.wordpress.org/trunk@28264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 18:10:15 +00:00
Scott Taylor
2b125a881b Eliminate use of extract() in Walker_Category::start_el(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28436


git-svn-id: http://core.svn.wordpress.org/trunk@28263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 17:58:13 +00:00
Scott Taylor
9b210df2b9 Eliminate use of extract() in wp_generate_tag_cloud(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28435


git-svn-id: http://core.svn.wordpress.org/trunk@28262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 17:48:15 +00:00
Scott Taylor
9c8becc1f7 Eliminate use of extract() in wp_list_categories(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28434


git-svn-id: http://core.svn.wordpress.org/trunk@28261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 17:28:14 +00:00
Scott Taylor
67c51361d6 Eliminate use of extract() in default-widgets.php. 
Props rzen, wonderboymusic.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28433


git-svn-id: http://core.svn.wordpress.org/trunk@28260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 16:33:15 +00:00
Scott Taylor
b788832722 Eliminate use of extract() in wp_dropdown_categories(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28432


git-svn-id: http://core.svn.wordpress.org/trunk@28259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 15:48:14 +00:00
Scott Taylor
78b6f2761d Eliminate use of extract() in get_comment_reply_link(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28431


git-svn-id: http://core.svn.wordpress.org/trunk@28258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 15:35:15 +00:00
Scott Taylor
11aa170e30 Eliminate use of extract() in WP_Ajax_Response::add(). Just set most of the properties to variables to avoid interpolation churn. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28430


git-svn-id: http://core.svn.wordpress.org/trunk@28257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 15:25:14 +00:00
Scott Taylor
7943f4715a Eliminate the use of extract() in get_post_reply_link(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28429


git-svn-id: http://core.svn.wordpress.org/trunk@28256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:49:14 +00:00
Scott Taylor
0e2909ce89 Eliminate the use of extract() in wp_list_comments(). All unit tests pass. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28428


git-svn-id: http://core.svn.wordpress.org/trunk@28255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:43:15 +00:00
Scott Taylor
a15d498d1a Eliminate the use of extract() in wp_update_comment(). All unit tests pass. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28427


git-svn-id: http://core.svn.wordpress.org/trunk@28254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:37:15 +00:00
Scott Taylor
bbcc03a750 Eliminate the use of extract() in wp_check_filetype_and_ext(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28426


git-svn-id: http://core.svn.wordpress.org/trunk@28253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:22:14 +00:00
Scott Taylor
8e98541d5f Eliminate the use of extract() in wp_mail(). Check the filtered array for each value before re-setting variables. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28425


git-svn-id: http://core.svn.wordpress.org/trunk@28252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:17:15 +00:00
Scott Taylor
f5bd0de275 Eliminate the use of extract() in wp_validate_auth_cookie(). 
Don't do anything fancy here, just set the 4 returned properties to variables. This function is semi-important.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28424


git-svn-id: http://core.svn.wordpress.org/trunk@28251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:11:13 +00:00
Scott Taylor
eb2bbf9c97 Eliminate the use of extract() in get_objects_in_term(). Only one property (order) was extracted. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28423


git-svn-id: http://core.svn.wordpress.org/trunk@28250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:43:16 +00:00
Scott Taylor
80a37d2fcd Eliminate the use of extract() in WP_Tax_Query::get_sql(). All unit tests still pass. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28422


git-svn-id: http://core.svn.wordpress.org/trunk@28249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:41:14 +00:00
Scott Taylor
e6fad96f5e Eliminate the use of extract() in the_taxonomies(). Adds unit test. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28421


git-svn-id: http://core.svn.wordpress.org/trunk@28248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:25:14 +00:00
Scott Taylor
ee90a8c17c Eliminate the use of extract() in wp_dropdown_users(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28420


git-svn-id: http://core.svn.wordpress.org/trunk@28247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:18:15 +00:00
Scott Taylor
ae61a48489 Set @param back to $output, not $html, in the inline filter docs. This was a copy/paste mistake. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28419


git-svn-id: http://core.svn.wordpress.org/trunk@28246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:08:14 +00:00
Scott Taylor
c0b0b00e6d Eliminate use of extract() in get_the_taxonomies(). Adds unit test. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28415


git-svn-id: http://core.svn.wordpress.org/trunk@28242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:51:13 +00:00
Scott Taylor
dcc6cbc04f Eliminate use of extract() in gallery_shortcode(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28414


git-svn-id: http://core.svn.wordpress.org/trunk@28241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:41:15 +00:00
Scott Taylor
947aa04900 Update the inline docs for add_shortcode() to eliminate suggestion to use extract(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28413


git-svn-id: http://core.svn.wordpress.org/trunk@28240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:28:15 +00:00
Scott Taylor
4b94efd93b Eliminate use of extract() in wp_xmlrpc_server::blogger_editPost(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28412


git-svn-id: http://core.svn.wordpress.org/trunk@28239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:25:15 +00:00
Scott Taylor
54321f4c6e Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28407


git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:45:15 +00:00
Scott Taylor
9d6eeca015 Eliminate use of extract() in wp_list_bookmarks(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28405


git-svn-id: http://core.svn.wordpress.org/trunk@28232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:18:16 +00:00
Scott Taylor
748765c5ad Eliminate use of extract() in _walk_bookmarks(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28404


git-svn-id: http://core.svn.wordpress.org/trunk@28231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:05:15 +00:00
Scott Taylor
12a5b389ab Eliminate use of extract() in get_bookmarks(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28403


git-svn-id: http://core.svn.wordpress.org/trunk@28230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:58:15 +00:00
Scott Taylor
a4a5560b22 Eliminate use of extract() in Walker_Page::start_el(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28402


git-svn-id: http://core.svn.wordpress.org/trunk@28229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:41:15 +00:00
Scott Taylor
7b8d797355 Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28401


git-svn-id: http://core.svn.wordpress.org/trunk@28228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:22:15 +00:00
Scott Taylor
29d8832625 Eliminate use of extract() in wp_dropdown_pages(). 
Adds unit tests to: `tests/post/template.php`. 
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28399


git-svn-id: http://core.svn.wordpress.org/trunk@28227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:12:13 +00:00
Scott Taylor
fe2d90ab4f Eliminate use of extract() in wp_link_pages(). 
Adds unit tests to a new file: `tests/post/template.php`. 
There were previously no unit tests for `wp_link_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28398


git-svn-id: http://core.svn.wordpress.org/trunk@28226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 00:44:14 +00:00
Scott Taylor
d5acdd82c8 Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28397


git-svn-id: http://core.svn.wordpress.org/trunk@28225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-14 22:29:14 +00:00
Scott Taylor
e866b5fb82 Eliminate use of extract() in wp_list_authors(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28392


git-svn-id: http://core.svn.wordpress.org/trunk@28220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 06:02:14 +00:00
Scott Taylor
92d2c60a65 Eliminate use of extract() in the_title_attribute(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28383


git-svn-id: http://core.svn.wordpress.org/trunk@28211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:48:15 +00:00
Scott Taylor
ef8b813682 Eliminate use of extract() in trackback_url_list(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28382


git-svn-id: http://core.svn.wordpress.org/trunk@28210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:44:15 +00:00
Scott Taylor
bee6492b9b Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28381


git-svn-id: http://core.svn.wordpress.org/trunk@28209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:40:16 +00:00
Scott Taylor
b110c7f887 Eliminate use of extract() in wp_get_archives(). 
Adds unit tests: `tests/functions/getArchives.php`. 
All other unit tests pass.

Props MikeHansenMe, wonderboymusic.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28379


git-svn-id: http://core.svn.wordpress.org/trunk@28207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:29:26 +00:00
Drew Jaynes
62b6306739 Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover filter. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28378


git-svn-id: http://core.svn.wordpress.org/trunk@28206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:29:14 +00:00
Drew Jaynes
08824b6529 Add a complete short description to the get_attached_media filter documentation. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28377


git-svn-id: http://core.svn.wordpress.org/trunk@28205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:21:14 +00:00
Scott Taylor
f32dbfe62c Add xps and oxps extensions to list of supported document types. 
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification

Fixes #15697.


Built from https://develop.svn.wordpress.org/trunk@28372


git-svn-id: http://core.svn.wordpress.org/trunk@28200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 07:19:13 +00:00
Scott Taylor
5682d30b6e In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true. 
Props adamsilverstein.
Fixes #23954.


Built from https://develop.svn.wordpress.org/trunk@28371


git-svn-id: http://core.svn.wordpress.org/trunk@28199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 07:03:15 +00:00
Scott Taylor
aeadf0c7cf Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath. 
Props Otto42 for the initial patch.
Fixes #25243.


Built from https://develop.svn.wordpress.org/trunk@28370


git-svn-id: http://core.svn.wordpress.org/trunk@28198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:25:15 +00:00
Scott Taylor
558cf6f86d In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border. 
Props avryl.
Fixes #27949.


Built from https://develop.svn.wordpress.org/trunk@28369


git-svn-id: http://core.svn.wordpress.org/trunk@28197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:19:14 +00:00
Scott Taylor
60f395e4c2 Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors. 
Props celloexpressions.
Fixes #27516.


Built from https://develop.svn.wordpress.org/trunk@28365


git-svn-id: http://core.svn.wordpress.org/trunk@28193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 02:23:14 +00:00
Scott Taylor
37b7f39e95 When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views. 
Fixes #27971.


Built from https://develop.svn.wordpress.org/trunk@28364


git-svn-id: http://core.svn.wordpress.org/trunk@28192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 02:07:14 +00:00
Scott Taylor
fb1aab6520 Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge. 
Fixes #27368.


Built from https://develop.svn.wordpress.org/trunk@28363


git-svn-id: http://core.svn.wordpress.org/trunk@28191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 01:28:15 +00:00
Scott Taylor
5df38694e9 In get_the_author_posts(), if there is no current $post, return 0 and bail. 
Props krogsgard, aaroncampbell.
Fixes #27998.


Built from https://develop.svn.wordpress.org/trunk@28362


git-svn-id: http://core.svn.wordpress.org/trunk@28190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:26:14 +00:00
Scott Taylor
d06c353995 MediaElement players need clear: both to play nice with adjacent floated elements. 
Fixes #27385.


Built from https://develop.svn.wordpress.org/trunk@28361


git-svn-id: http://core.svn.wordpress.org/trunk@28189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:14:14 +00:00
Scott Taylor
9daf458ff0 Remove the title attribute from markup generated in wp-includes/category-template.php: 
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`	

Props joedolson.
Fixes #26557.	


Built from https://develop.svn.wordpress.org/trunk@28359


git-svn-id: http://core.svn.wordpress.org/trunk@28187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:57:16 +00:00
Scott Taylor
f22beb987c First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:36:18 +00:00
Drew Jaynes
9098b45e53 Add inline documentation of the default arguments for wp_list_pages(). 
Props garza for the initial patches.
Fixes #11338.

Built from https://develop.svn.wordpress.org/trunk@28357


git-svn-id: http://core.svn.wordpress.org/trunk@28185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 08:02:14 +00:00
Scott Taylor
1daa7d6723 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 18:25:14 +00:00
Scott Taylor
3bbed6ceac audio, video, and playlist shortcodes: 
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur

See #22400, #27881.


Built from https://develop.svn.wordpress.org/trunk@28342


git-svn-id: http://core.svn.wordpress.org/trunk@28170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 17:36:18 +00:00
Scott Taylor
361e3e1ee6 In wpdb, remove dead code: 
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28339


git-svn-id: http://core.svn.wordpress.org/trunk@28167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:56:14 +00:00
Scott Taylor
06373a6f32 In WP_Widget::update_callback(), $sidebars_widgets is unused. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28338


git-svn-id: http://core.svn.wordpress.org/trunk@28166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:52:15 +00:00
Scott Taylor
49251efc74 In wp-includes/theme.php, break is unreachable after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28337


git-svn-id: http://core.svn.wordpress.org/trunk@28165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:50:14 +00:00
Scott Taylor
cca9ff329b In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28336


git-svn-id: http://core.svn.wordpress.org/trunk@28164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:47:14 +00:00
Scott Taylor
1ef3438961 In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28335


git-svn-id: http://core.svn.wordpress.org/trunk@28163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:45:14 +00:00
Scott Taylor
5b6b17fc80 In wp-includes/revision.php - remove dead code: 
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28334


git-svn-id: http://core.svn.wordpress.org/trunk@28162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:38:16 +00:00
Scott Taylor
5bc59586da In WP_Query, remove duplicate variable setting: 
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28333


git-svn-id: http://core.svn.wordpress.org/trunk@28161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:43:20 +00:00
Scott Taylor
1aed1f1108 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming. 
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28332


git-svn-id: http://core.svn.wordpress.org/trunk@28160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:39:14 +00:00
Scott Taylor
ef34785160 In wp_get_attachment_link(), $post_title is set and then not used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28331


git-svn-id: http://core.svn.wordpress.org/trunk@28159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:35:16 +00:00
Scott Taylor
9a1dcd1a7c In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28330


git-svn-id: http://core.svn.wordpress.org/trunk@28158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:33:14 +00:00
Scott Taylor
c96d7fff01 In get_network_by_path(), $exact_domains is unused. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28329


git-svn-id: http://core.svn.wordpress.org/trunk@28157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:32:16 +00:00
Scott Taylor
b2b25f7326 In update_metadata_by_mid(), $original_value is unused. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28328


git-svn-id: http://core.svn.wordpress.org/trunk@28156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:29:26 +00:00
Scott Taylor
0910376bfe In edit_post_link(), $post_type_obj is unused. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28327


git-svn-id: http://core.svn.wordpress.org/trunk@28155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:27:15 +00:00
Scott Taylor
3d0eed82f8 In paginate_links(), break is unreachable after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28326


git-svn-id: http://core.svn.wordpress.org/trunk@28154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:25:15 +00:00
Scott Taylor
de4eaacd89 In wp-includes/functions.php, remove dead code: 
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28325


git-svn-id: http://core.svn.wordpress.org/trunk@28153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:23:14 +00:00
Scott Taylor
7eeafa3537 In wp_set_comment_status(), the default case returns, so no default value for $status is needed. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28324


git-svn-id: http://core.svn.wordpress.org/trunk@28152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:17:15 +00:00
Scott Taylor
de262f553c In wp-includes/comment-template.php, remove dead code: 
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28323


git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:15:17 +00:00
Scott Taylor
6b80da9d96 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28322


git-svn-id: http://core.svn.wordpress.org/trunk@28150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:09:19 +00:00
Sergey Biryukov
d711c32138 Update deleted site message in ms_site_check(). 
props boonebgorges.
fixes #28150.
Built from https://develop.svn.wordpress.org/trunk@28321


git-svn-id: http://core.svn.wordpress.org/trunk@28149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:46:15 +00:00
Scott Taylor
013d4dc387 In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28320


git-svn-id: http://core.svn.wordpress.org/trunk@28148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:37:29 +00:00
Scott Taylor
73b102bd84 In wp-includes/class-wp-customize-setting.php, break is unreachable after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28319


git-svn-id: http://core.svn.wordpress.org/trunk@28147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:34:14 +00:00
Scott Taylor
0a4af6d45c In wp-includes/class-wp-admin-bar.php, break is unreachabled after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28318


git-svn-id: http://core.svn.wordpress.org/trunk@28146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:29:15 +00:00
Scott Taylor
5bd852c262 In WP_Http_Curl::request(), $theResponse is unused. There are other curl_exec() calls that do not return as well. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28317


git-svn-id: http://core.svn.wordpress.org/trunk@28145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:26:14 +00:00
Scott Taylor
63a210e7c8 In wp-includes/bookmark.php, remove dead code: 
* In `get_bookmarks()`, `$cache` is set twice before it is used. 
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28316


git-svn-id: http://core.svn.wordpress.org/trunk@28144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:22:16 +00:00
Sergey Biryukov
d70e8a38fa Add a filter for wp_list_comments() arguments. 
props greenshady, hlashbrooke.
fixes #19581.
Built from https://develop.svn.wordpress.org/trunk@28285


git-svn-id: http://core.svn.wordpress.org/trunk@28113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 11:58:14 +00:00
Drew Jaynes
2c00d8f9e3 Where a filter no longer exists, it need not be notated. 
Fixes #24444. See r28258.

Built from https://develop.svn.wordpress.org/trunk@28283


git-svn-id: http://core.svn.wordpress.org/trunk@28111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:38:15 +00:00
Andrew Nacin
e239dfad43 Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression. 
props jeremyfelt.
fixes #27927.

Built from https://develop.svn.wordpress.org/trunk@28280


git-svn-id: http://core.svn.wordpress.org/trunk@28108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:32:36 +00:00
Andrew Nacin
5b63b112f3 Multisite: Fix case sensitivity regressions in 3.9. 
props jeremyfelt.
fixes #27866.

Built from https://develop.svn.wordpress.org/trunk@28276


git-svn-id: http://core.svn.wordpress.org/trunk@28104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:24:14 +00:00
Scott Taylor
9bdbd50ac0 In general-template.php - remove dead code: 
* In `get_calendar()`, `$cache` is set twice. The first is useless. 
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary. 
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28274


git-svn-id: http://core.svn.wordpress.org/trunk@28102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:58:16 +00:00
Andrew Nacin
6295631a4b Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers. 
props rzen, ehg.
fixes #27848.

Built from https://develop.svn.wordpress.org/trunk@28266


git-svn-id: http://core.svn.wordpress.org/trunk@28094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:14:14 +00:00
Scott Taylor
00b03fe04f Remove duplicate variable setting for $link in wp_list_authors(). 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28265


git-svn-id: http://core.svn.wordpress.org/trunk@28093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 03:52:15 +00:00
Scott Taylor
b663fffe24 Add .dfxp and .srt files to mime-type whitelist in wp_get_mime_types(). They are both captioning formats supported by MediaElement. 
Props joedolson.
Fixes #27643.


Built from https://develop.svn.wordpress.org/trunk@28259


git-svn-id: http://core.svn.wordpress.org/trunk@28087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 20:08:16 +00:00
Scott Taylor
511145b418 When $type is atom in get_the_category_rss(), use get_bloginfo_rss( 'url' ) when setting the scheme attribute for the <category> node. 
Props ejdanderson.
Fixes #24444.


Built from https://develop.svn.wordpress.org/trunk@28258


git-svn-id: http://core.svn.wordpress.org/trunk@28086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 19:05:14 +00:00
Scott Taylor
5e7ac8de94 Remove by-reference modifiers from arguments in wp_remote_retrieve_* functions. 
Props jesin.
Fixes #27687.


Built from https://develop.svn.wordpress.org/trunk@28257


git-svn-id: http://core.svn.wordpress.org/trunk@28085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 18:46:15 +00:00
Scott Taylor
f90a558df4 In WP_Date_Query::get_sql_for_subquery(), don't parse duplicate parameters - only parse one of w and week or month and monthnum. 
Adds unit tests.

Props oso96_2000, ChriCo.
Fixes #25835.


Built from https://develop.svn.wordpress.org/trunk@28252


git-svn-id: http://core.svn.wordpress.org/trunk@28080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-04 23:07:14 +00:00
Scott Taylor
a2067a7324 Set the proper value for wp_title() when is_author() and is_post_type_archive() are both true. post_type should always win due to the precedence indicated in get_queried_object(). 
Props mordauk.
Fixes #25398.


Built from https://develop.svn.wordpress.org/trunk@28251


git-svn-id: http://core.svn.wordpress.org/trunk@28079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-04 22:21:22 +00:00
Sergey Biryukov
0b08cd7a25 Prevent 'paged-*' from being added to body classes on 404 error pages. 
props psoluch.
see #16468.
Built from https://develop.svn.wordpress.org/trunk@28249


git-svn-id: http://core.svn.wordpress.org/trunk@28077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-04 13:17:15 +00:00
Drew Jaynes
a5366db845 Improve inline documentation for the wpdb::$show_errors property. 
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.

Props ericlewis.
Fixes #16615.

Built from https://develop.svn.wordpress.org/trunk@28243


git-svn-id: http://core.svn.wordpress.org/trunk@28071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 12:19:15 +00:00
Sergey Biryukov
7214648764 Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu(). 
props Tmeister.
fixes #27745.
Built from https://develop.svn.wordpress.org/trunk@28242


git-svn-id: http://core.svn.wordpress.org/trunk@28070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 11:59:14 +00:00
Sergey Biryukov
3ad1c8897c Correct 'show_in_menu' parameter description in register_taxonomy(). 
fixes #27943.
Built from https://develop.svn.wordpress.org/trunk@28241


git-svn-id: http://core.svn.wordpress.org/trunk@28069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 11:29:13 +00:00
Sergey Biryukov
58dcece494 Correct @return value for current_time(). 
props arnee.
fixes #27940.
Built from https://develop.svn.wordpress.org/trunk@28240


git-svn-id: http://core.svn.wordpress.org/trunk@28068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 11:25:15 +00:00
Dominik Schilling
c7adbde777 Update jQuery to 1.11.1. 
fixes #28103.
Built from https://develop.svn.wordpress.org/trunk@28238


git-svn-id: http://core.svn.wordpress.org/trunk@28066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 09:29:16 +00:00
Sergey Biryukov
d882dc9782 Fix arrow positioning in "Insert/edit link" modal. 
props avryl, sergej.mueller.
fixes #28096.
Built from https://develop.svn.wordpress.org/trunk@28236


git-svn-id: http://core.svn.wordpress.org/trunk@28064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-01 21:21:15 +00:00
Andrew Nacin
ba0168819c Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets. 
props gcorne.
props Clorith, jorbin for tests.
see #27907, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28223


git-svn-id: http://core.svn.wordpress.org/trunk@28051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-01 03:37:13 +00:00
Andrew Nacin
9f00179c58 Improve TinyMCE string for paste command browser support. 
props ebinnion.
fixes #27988.

Built from https://develop.svn.wordpress.org/trunk@28220


git-svn-id: http://core.svn.wordpress.org/trunk@28050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 21:20:14 +00:00
Dominik Schilling
20c10c5e2c Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width. 
Add tests.

see #27936 for trunk.
Built from https://develop.svn.wordpress.org/trunk@28219


git-svn-id: http://core.svn.wordpress.org/trunk@28049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 20:25:19 +00:00
Dominik Schilling
b6e3942bdd Revert [28217]. 
Misfired commit for #27936.
Built from https://develop.svn.wordpress.org/trunk@28218


git-svn-id: http://core.svn.wordpress.org/trunk@28048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 20:18:16 +00:00
Dominik Schilling
1849473907 Recent Posts Widget: Use ob_end_flush() instead of ob_flush(). 
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.

props m_i_n.
see #28009 for trunk.

Built from https://develop.svn.wordpress.org/trunk@28217


git-svn-id: http://core.svn.wordpress.org/trunk@28047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 14:21:15 +00:00
Drew Jaynes
d77e78d685 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter. 
Also adds braces missed in [25535].

See #26869.

Built from https://develop.svn.wordpress.org/trunk@28215


git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 07:12:14 +00:00
Drew Jaynes
8161668689 Ensure the wp_set_comment_status action hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28214


git-svn-id: http://core.svn.wordpress.org/trunk@28044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:55:14 +00:00
Drew Jaynes
aa20678c48 Ensure the style_loader_tag filter hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28209


git-svn-id: http://core.svn.wordpress.org/trunk@28039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:29:14 +00:00
Drew Jaynes
05537ab967 Ensure the register filter hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28208


git-svn-id: http://core.svn.wordpress.org/trunk@28038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:24:15 +00:00
Mark Jaquith
a43313fe12 Use '&mdash; Select &mdash;' instead of '-- Select --' for nav menus. Looks nicer. 
see #27878
Built from https://develop.svn.wordpress.org/trunk@28205


git-svn-id: http://core.svn.wordpress.org/trunk@28035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 00:35:25 +00:00
Mark Jaquith
8c830cef80 Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX 
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.

fixes #27878 for trunk. props westonruter
Built from https://develop.svn.wordpress.org/trunk@28197


git-svn-id: http://core.svn.wordpress.org/trunk@28027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-24 20:45:31 +00:00
Dominik Schilling
77beef348d Recent Posts Widget: Use ob_end_flush() instead of ob_flush(). 
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.

props m_i_n.
see #28009 for trunk.

Built from https://develop.svn.wordpress.org/trunk@28195


git-svn-id: http://core.svn.wordpress.org/trunk@28025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-24 19:48:19 +00:00
John Blackbourn
ab041987d3 Remove some unnecessary abstraction introduced in [28191]. See #27985. 
Built from https://develop.svn.wordpress.org/trunk@28194


git-svn-id: http://core.svn.wordpress.org/trunk@28024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-24 11:55:22 +00:00
Andrew Ozz
5de05f97dd TinyMCE: update the 'paste' plugin to the latest dev. version. Included changes: 1b7c41cd7b and 7998b8025d. See #27909, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28192


git-svn-id: http://core.svn.wordpress.org/trunk@28022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-24 00:59:13 +00:00
John Blackbourn
d6e03df3c9 Avoid an expensive attachment counting query on the post editing screen. See #27985, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28191


git-svn-id: http://core.svn.wordpress.org/trunk@28021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-23 22:05:16 +00:00
Andrew Ozz
7b4d339454 TinyMCE: when adding a caption to an image that is in a paragraph with other text, move the caption node above the paragraph instead of below. See #27922, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28190


git-svn-id: http://core.svn.wordpress.org/trunk@28020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-23 20:42:14 +00:00
Andrew Ozz
3eb1616925 Drag/drop on the editor to upload: don't trigger the uploader when selected test is being dragged from one window to another. See #27880, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28189


git-svn-id: http://core.svn.wordpress.org/trunk@28019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-23 20:35:13 +00:00
Andrew Ozz
c621255236 Run WP_Editors::enqueue_scripts() on admin_print_footer_scripts priority 1 (later), instead of admin_footer. Fixes incompatibility with the customizer. Props feedmeastraycat, see #27853, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28187


git-svn-id: http://core.svn.wordpress.org/trunk@28018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 22:41:14 +00:00
Andrew Ozz
f81a107cee TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected, see #27847, for trunk. 
Built from https://develop.svn.wordpress.org/trunk@28185


git-svn-id: http://core.svn.wordpress.org/trunk@28016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 21:11:14 +00:00
Scott Taylor
6deb34ebb3 Alter the layout of the checkboxes in the modal view for Audio/Video Details to allow translations more room to breathe. 
See #27893.


Built from https://develop.svn.wordpress.org/trunk@28184


git-svn-id: http://core.svn.wordpress.org/trunk@28015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 20:29:14 +00:00
Scott Taylor
0b1272e445 Persisting <track> elements as the body of a [video] shortcode in MCE Views: 
* When generating the view's HTML, ensure that the shortcode's `content` is added to the model
* Add a `PostProcess` event in the `wpview` plugin to properly return the shortcode when the editor mode is toggled, ensuring that elements in the body are not dropped.

Props azaozz, wonderboymusic.
See #27915.



Built from https://develop.svn.wordpress.org/trunk@28183


git-svn-id: http://core.svn.wordpress.org/trunk@28014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 18:21:16 +00:00
Scott Taylor
55becc0dfd Refinements for asynchronous rendering in wp.mce.media.PlaylistView: 
* Add `visibility: hidden` as an inline style to `<audio>` tags, there is a race with the stylesheet which can get enqueued in the body and loaded in the footer.
* When creating new instances of `MediaElementPlayer`, always push them onto a stack. Lone views can be responsible for multiple instances of the same shortcode on render.
* Rename `wp.media.mixin.unsetPlayer()` to `wp.media.mixin.unsetPlayers()` to reflect the above.
* Call `wp.media.mixin.unsetPlayers()` on the view's `unbind()` method, instead of inline in the `render()` method
* Make sure `WPPlaylistView` is instantiated for each editor instance
* Ensure that the `No Items Found` view state is not rendered when attachments actually do exist.

Props gcorne, wonderboymusic.
See #27899.



Built from https://develop.svn.wordpress.org/trunk@28182


git-svn-id: http://core.svn.wordpress.org/trunk@28013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 17:53:16 +00:00
Andrew Nacin
a6eedd18b2 TinyMCE: Restore old wordpress_adv_hidden editor parameter to enable force-showing the kitchen sink. 
props azaozz.
see #27963, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28181


git-svn-id: http://core.svn.wordpress.org/trunk@28012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 13:50:14 +00:00
Andrew Nacin
1613157773 Editor: Shrink the font size for the chosen format so it fits in more locales. 
props SergeyBiryukov.
see #27903, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28180


git-svn-id: http://core.svn.wordpress.org/trunk@28011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-22 13:24:15 +00:00
Scott Taylor
baf754ce35 Use the proper translated string for Video Playlist "drag info" - the text displayed above the playlist's sortable attachments. 
See #27937.


Built from https://develop.svn.wordpress.org/trunk@28178


git-svn-id: http://core.svn.wordpress.org/trunk@28009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-21 19:37:14 +00:00
Andrew Nacin
30eadc1801 Remove version string from Thickbox so it assumes the WP core version. Bust some caches. 
props celloexpressions.
see #27861, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28176


git-svn-id: http://core.svn.wordpress.org/trunk@28007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-21 05:07:15 +00:00
Scott Taylor
c5c18d3848 Add calc() rules for max-width of playlist caption. 
Props celloexpressions.
See #27923.


Built from https://develop.svn.wordpress.org/trunk@28174


git-svn-id: http://core.svn.wordpress.org/trunk@28005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-20 05:10:15 +00:00
Scott Taylor
3a903b40af Support RTL properly when displaying playlists. 
Props SergeyBiryukov.
See #27924.


Built from https://develop.svn.wordpress.org/trunk@28173


git-svn-id: http://core.svn.wordpress.org/trunk@28004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-20 04:27:14 +00:00
Scott Taylor
ec563e82ed Properly account for text overflow in .wp-playlist-caption by adding display: block. 
Props celloexpressions.
See #27923.


Built from https://develop.svn.wordpress.org/trunk@28172


git-svn-id: http://core.svn.wordpress.org/trunk@28003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-20 04:25:15 +00:00
Scott Taylor
fd65d355a2 Add a compatibility layer in wp-playlist.js to avoid VM errors from MediaElement's plugin bridge in the TinyMCE views for playlists by suppressing playback for files whose mime-type is not supported in the user's browser natively. 
This is similar to how audio and video shortcodes are handled: file types are whitelisted for native playback.

See #27892.


Built from https://develop.svn.wordpress.org/trunk@28171


git-svn-id: http://core.svn.wordpress.org/trunk@28002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-20 03:53:15 +00:00
Andrew Nacin
ea8635a465 Customizer: Correct reference to the 'Add new image' button. 
props jjeaton.
see #27890, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28170


git-svn-id: http://core.svn.wordpress.org/trunk@28001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 19:45:14 +00:00
Scott Taylor
d9cf41cfcf Don't show textareas that have "hidden" as a class in the media modal. 
See #27915.


Built from https://develop.svn.wordpress.org/trunk@28169


git-svn-id: http://core.svn.wordpress.org/trunk@28000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:34:17 +00:00
Andrew Nacin
f6387ec25a Properly translate 'Select Poster Image'. 
props dimadin.
see #27845, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28168


git-svn-id: http://core.svn.wordpress.org/trunk@27999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:28:15 +00:00
Andrew Nacin
f81deab036 Fix logic inversion in [28124] to ensure widgets stay with themes during a theme switch. 
fixes #27897.

Built from https://develop.svn.wordpress.org/trunk@28161


git-svn-id: http://core.svn.wordpress.org/trunk@27992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:12:15 +00:00
Scott Taylor
b7b2f53aa4 Don't set the poster image for videos in a playlist if the image is the video mime-type icon blown up. 
See #27892.


Built from https://develop.svn.wordpress.org/trunk@28158


git-svn-id: http://core.svn.wordpress.org/trunk@27989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-18 17:39:15 +00:00
Andrew Nacin
50b3b36420 Trunk is now 4.0-alpha. 
Built from https://develop.svn.wordpress.org/trunk@28157


git-svn-id: http://core.svn.wordpress.org/trunk@27988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 19:38:16 +00:00
Andrew Nacin
0e85a93967 WordPress 3.9. 
Built from https://develop.svn.wordpress.org/trunk@28153


git-svn-id: http://core.svn.wordpress.org/trunk@27984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 18:01:28 +00:00
Mark Jaquith
4c85eb0dbf Prevent customizer header image list from listing user images twice when no theme-specified images exist 
fixes #27839. props mcsf
Built from https://develop.svn.wordpress.org/trunk@28152


git-svn-id: http://core.svn.wordpress.org/trunk@27983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 18:01:15 +00:00
Andrew Nacin
e3a4c57563 Final about page. 
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713, #27837.

Built from https://develop.svn.wordpress.org/trunk@28150


git-svn-id: http://core.svn.wordpress.org/trunk@27981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 17:40:14 +00:00
Mark Jaquith
b9eb0f72e3 Ensure that wp.media.view.settings.post is set before accessing the post's id 
Avoids JS error in cases where media-editor is loaded individually
instead of with the whole `wp_enqueue_media()` process.

fixes #27836. props nacin
Built from https://develop.svn.wordpress.org/trunk@28149


git-svn-id: http://core.svn.wordpress.org/trunk@27980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 15:26:15 +00:00
Andrew Nacin
2bc282957c Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.

Built from https://develop.svn.wordpress.org/trunk@28145


git-svn-id: http://core.svn.wordpress.org/trunk@27976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:38:14 +00:00
Andrew Nacin
a8cefa836d Graceful failures for TinyMCE views of video/audio playlists. 
props gcorne.
fixes #27821.

Built from https://develop.svn.wordpress.org/trunk@28144


git-svn-id: http://core.svn.wordpress.org/trunk@27975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:23:15 +00:00
Andrew Nacin
dbca0c5e15 Widgets: Remove create_function() from the customizer class. 
props westonruter.
fixes #27805.

Built from https://develop.svn.wordpress.org/trunk@28143


git-svn-id: http://core.svn.wordpress.org/trunk@27974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:11:35 +00:00
Andrew Nacin
efe36dbd5f Add missing string translation in widgets. 
see #27453, #27112.

Built from https://develop.svn.wordpress.org/trunk@28140


git-svn-id: http://core.svn.wordpress.org/trunk@27971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:01:14 +00:00
Andrew Nacin
e8020e91fd Cast wp_count_attachments() before iterating it to avoid a notice when items exist without a mime type. 
props bobbingwide.
fixes #27802.

Built from https://develop.svn.wordpress.org/trunk@28139


git-svn-id: http://core.svn.wordpress.org/trunk@27970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:00:15 +00:00
Andrew Nacin
28760a7d53 3.9-RC2 
Built from https://develop.svn.wordpress.org/trunk@28135


git-svn-id: http://core.svn.wordpress.org/trunk@27966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 08:59:14 +00:00
Andrew Nacin
fa3900168e Allow the API to add text to auto update emails. 
fixes #27812.

Built from https://develop.svn.wordpress.org/trunk@28134


git-svn-id: http://core.svn.wordpress.org/trunk@27965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 08:52:15 +00:00
Drew Jaynes
e8be2a7e1e Inline documentation for three remaining hooks in wp-includes/general-template.php. 
Documents the `login_form_top`, `login_form_middle`, and `login_form_bottom` and filters.

That's 184/184 hook docs files complete. Boom!

Props kpdesign, DrewAPicture.
Fixes #27719.

Built from https://develop.svn.wordpress.org/trunk@28131


git-svn-id: http://core.svn.wordpress.org/trunk@27962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 04:42:16 +00:00
Drew Jaynes
577fe1960a Inline documentation for hooks in wp-includes/general-template.php. 
Props jesin, kpdesign.
See #27719.

Built from https://develop.svn.wordpress.org/trunk@28130


git-svn-id: http://core.svn.wordpress.org/trunk@27961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 04:01:15 +00:00
Andrew Nacin
3b50cf7ec2 Add a TTL to core update checks to allow us to narrow the 12-hour update window. 
props dd32.
fixes #27772.

Built from https://develop.svn.wordpress.org/trunk@28129


git-svn-id: http://core.svn.wordpress.org/trunk@27960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 02:23:16 +00:00
Drew Jaynes
da896b7cf3 Inline documentation for hooks in wp-includes/media.php. 
Props scottlee for the initial patch. Props kpdesign, DrewAPicture.
Fixes #27718.

Built from https://develop.svn.wordpress.org/trunk@28128


git-svn-id: http://core.svn.wordpress.org/trunk@27959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 01:36:14 +00:00
Andrew Nacin
d1e72b8e20 Image Details modal: Remember the last state of the advanced toggle. 
props gcorne.
fixes #27366.

Built from https://develop.svn.wordpress.org/trunk@28125


git-svn-id: http://core.svn.wordpress.org/trunk@27956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 23:56:16 +00:00
Andrew Nacin
6b579e0d59 Customizer: Properly handle widget settings when activating a previewed theme. 
props westonruter, ocean90, gcorne.
fixes #27767.

Built from https://develop.svn.wordpress.org/trunk@28124


git-svn-id: http://core.svn.wordpress.org/trunk@27955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 22:46:16 +00:00
Drew Jaynes
fe6761ccf3 Inline documentation for hooks in wp-includes/class-wp-customize-widgets.php 
Fixes #27531.

Built from https://develop.svn.wordpress.org/trunk@28117


git-svn-id: http://core.svn.wordpress.org/trunk@27948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 18:41:17 +00:00
Andrew Ozz
3de93ccba3 DFW: 
- Add background color and remove the top border from the status bar (at the bottom).
- Fix spinner to always be next to the Save button.
- Remove width: auto; from .mce-fixed-width.
Fixes #27709
Built from https://develop.svn.wordpress.org/trunk@28116


git-svn-id: http://core.svn.wordpress.org/trunk@27947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 08:15:16 +00:00
Andrew Nacin
5ab50ba7d5 TinyMCE: Always load translations, even in English, as we modify some strings. 
Move a setting to after the translations filter, and remove unused strings.

see #24067.

Built from https://develop.svn.wordpress.org/trunk@28112


git-svn-id: http://core.svn.wordpress.org/trunk@27943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 03:23:15 +00:00
Drew Jaynes
9c2a27129c Inline documentation for hooks in wp-includes/link-template.php. 
Props johnbillion, DrewAPicture.
Fixes #27716.

Built from https://develop.svn.wordpress.org/trunk@28111


git-svn-id: http://core.svn.wordpress.org/trunk@27942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 02:13:16 +00:00
Drew Jaynes
ca7ef18e55 Inline documentation for hooks in wp-includes/functions.php. 
Props jesin, GaryJ.
Fixes #27715.

Built from https://develop.svn.wordpress.org/trunk@28109


git-svn-id: http://core.svn.wordpress.org/trunk@27940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:20:14 +00:00
Andrew Nacin
bfe44f07a3 Plupload: Restore 3.8 handles and filenames to avoid breaking plugins. 
fixes #27763.

Built from https://develop.svn.wordpress.org/trunk@28108


git-svn-id: http://core.svn.wordpress.org/trunk@27939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:07:16 +00:00
Andrew Nacin
55b0cd935e Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.

Built from https://develop.svn.wordpress.org/trunk@28107


git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:00:14 +00:00
Drew Jaynes
2d79af0e0a Part II of inline documentation for hooks in wp-includes/post.php. 
Documents all remaining hooks following [28041] and [28042]. Also updates the hash notation style for `wp_insert_post()`.

Props nacin for several hook descriptions.

Fixes #25376.

Built from https://develop.svn.wordpress.org/trunk@28106


git-svn-id: http://core.svn.wordpress.org/trunk@27937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 23:06:14 +00:00
Andrew Nacin
24e51a625d Customizer: Fix header image cropping when working with huge images. Affected Firefox in particular. 
props ehg.
fixes #27790.

Built from https://develop.svn.wordpress.org/trunk@28101


git-svn-id: http://core.svn.wordpress.org/trunk@27932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 18:20:14 +00:00
Andrew Nacin
33515194a0 Customizer: Account for a sidebar with no container to which classes can be added. 
props ocean90.
fixes #27780.

Built from https://develop.svn.wordpress.org/trunk@28100


git-svn-id: http://core.svn.wordpress.org/trunk@27931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 16:41:15 +00:00
Andrew Nacin
ad850a34a4 Add context to string added in [28097]. 
props azaozz.
fixes #27785.

Built from https://develop.svn.wordpress.org/trunk@28099


git-svn-id: http://core.svn.wordpress.org/trunk@27930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 16:35:14 +00:00
Andrew Nacin
23d78b1777 Add missing 'Address' string for TinyMCE. 
props pavelevap, ocean90.
fixes #27785.

Built from https://develop.svn.wordpress.org/trunk@28097


git-svn-id: http://core.svn.wordpress.org/trunk@27928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 16:21:15 +00:00
Andrew Nacin
41d2a7f82b RTL for login screen. 
props yoavf.
fixes #27784.

Built from https://develop.svn.wordpress.org/trunk@28096


git-svn-id: http://core.svn.wordpress.org/trunk@27927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 16:06:14 +00:00
Andrew Ozz
0df02eb8ea Add hooks to the wpeditimage tinymce plugin and to the image details portion of the media modal. 
- Add wp.media.events which is intended to be a global media event bus.
- Add a post-render event to the ImageDetails view that third-party code can leverage to add subviews.
- Performance improvement for the initialization of the PostImage model.
- A bit more markup to the image details template to make it easier to add a view to the advanced options.
Props gcorne, fixes #27698
Built from https://develop.svn.wordpress.org/trunk@28095


git-svn-id: http://core.svn.wordpress.org/trunk@27926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 04:02:15 +00:00
Andrew Ozz
dc52e17417 RTL for TinyMCE: 
- Add _dir: 'rtl' to the TinyMCE translation object.
- Fix editor.css for RTL.
- Fix the Edit and Delete buttons position for wpview and images.
- For _mce_set_direction(), update documentation and fix adding the 'ltr' button.
Fixes #27773
Built from https://develop.svn.wordpress.org/trunk@28094


git-svn-id: http://core.svn.wordpress.org/trunk@27925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-13 00:23:15 +00:00
Andrew Nacin
5ca6bdf7c2 Add an explanation for 'Paste from Word' in the 'Paste from Text' dialog. 
fixes #27777. see #27160.

Built from https://develop.svn.wordpress.org/trunk@28091


git-svn-id: http://core.svn.wordpress.org/trunk@27922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:48:28 +00:00
Andrew Ozz
1a538353fc Update the TinyMCE paste plugin to the latest development version. It includes a fix for pasting from Word: removes inline comments and change tracking. 
Changeset: f8cffdf342
Fixes #27771
Built from https://develop.svn.wordpress.org/trunk@28089


git-svn-id: http://core.svn.wordpress.org/trunk@27920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:01:14 +00:00
Andrew Nacin
91971b28a7 User Query: Don't blindly re-append new meta queries for capabilities. 
fixes #21119.

Built from https://develop.svn.wordpress.org/trunk@28087


git-svn-id: http://core.svn.wordpress.org/trunk@27918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 19:04:15 +00:00
Andrew Nacin
d50e4bc08c Custom Headers: Allow for longer strings. 
props ehg.
see #27755.

Built from https://develop.svn.wordpress.org/trunk@28086


git-svn-id: http://core.svn.wordpress.org/trunk@27917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 18:40:14 +00:00
Andrew Ozz
191dd168c1 TinyMCE wpViews: 
- Prevent undo steps from being added when the body of a wpview changes.
- Add unbind() to handle cleanup on DOM rebuilding in TinyMCE.
- Ensure that MediaElement's cleanup routine is run on every player in all instances of the editor.
- Initialize the players after some delay to ensure CSS is loaded.
Props gcorne and wonderboymusic, fixes #27389
Built from https://develop.svn.wordpress.org/trunk@28084


git-svn-id: http://core.svn.wordpress.org/trunk@27915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 00:46:14 +00:00
Drew Jaynes
5e51ea9940 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 00:01:15 +00:00
Andrew Nacin
eb54438f17 Translate custom header customize control strings. Remove final added before beta to see what breakage we might cause by refactoring this class. 
see #21785. fixes #27738.

Built from https://develop.svn.wordpress.org/trunk@28082


git-svn-id: http://core.svn.wordpress.org/trunk@27913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 23:25:16 +00:00
Andrew Ozz
68cbde29ca Don't include the non-minified tinymce.js in /build. Load it when running from /src, else load wp-tinymce.js.gz (production) or tinymce.min.js (SCRIPT_DEBUG). Props nacin, fixes #27739 
Built from https://develop.svn.wordpress.org/trunk@28081


git-svn-id: http://core.svn.wordpress.org/trunk@27912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 22:16:14 +00:00
Andrew Nacin
115b91faff Editor: Ensure the link dialog does not display when styles are missing. 
props mattheu.
fixes #27605.

Built from https://develop.svn.wordpress.org/trunk@28071


git-svn-id: http://core.svn.wordpress.org/trunk@27902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 03:09:15 +00:00
Scott Taylor
382577bbb7 Bump MediaElement.js to 2.14.2. Release Notes: 743f446523. 
Fixes #27582.


Built from https://develop.svn.wordpress.org/trunk@28068


git-svn-id: http://core.svn.wordpress.org/trunk@27899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-10 21:32:14 +00:00
Andrew Ozz
c631d144f1 Update TinyMCE to the current development version, 4.0.21.1. Fixes #27744 
Built from https://develop.svn.wordpress.org/trunk@28066


git-svn-id: http://core.svn.wordpress.org/trunk@27898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-10 21:09:16 +00:00
Andrew Nacin
58ca03f8ea XML-RPC: Fix bracing of conditionals around doc blocks. 
props redsweater, DrewAPicture.
fixes #27506.

Built from https://develop.svn.wordpress.org/trunk@28065


git-svn-id: http://core.svn.wordpress.org/trunk@27897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-10 21:04:14 +00:00
Andrew Ozz
a3c725f5b4 TinyMCE Views in IE8 and 7: change deselect event only for old IE, props gcorne, fixes #27546 
Built from https://develop.svn.wordpress.org/trunk@28063


git-svn-id: http://core.svn.wordpress.org/trunk@27895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-09 15:29:17 +00:00
Andrew Ozz
cc694bac21 Fix TinyMCE Views in IE8 and 7: 
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546
Built from https://develop.svn.wordpress.org/trunk@28062


git-svn-id: http://core.svn.wordpress.org/trunk@27894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-09 00:58:15 +00:00
Andrew Ozz
5ca1024284 TinyMCE: make sure vertical resizing and menubar show/hide are set to default for each instance, fixes #27724 
Built from https://develop.svn.wordpress.org/trunk@28059


git-svn-id: http://core.svn.wordpress.org/trunk@27891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 18:58:14 +00:00
Andrew Nacin
3c78339cb7 3.9-RC1 
Built from https://develop.svn.wordpress.org/trunk@28058


git-svn-id: http://core.svn.wordpress.org/trunk@27890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 18:19:15 +00:00
Andrew Nacin
7f001bfe24 Harden HMAC verification. props duck_. 
Built from https://develop.svn.wordpress.org/trunk@28053


git-svn-id: http://core.svn.wordpress.org/trunk@27883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 18:06:16 +00:00
Andrew Nacin
e8da400c69 Don't show featured images for image attachments. Remove abstractions for now. 
fixes #27673.

Built from https://develop.svn.wordpress.org/trunk@28051


git-svn-id: http://core.svn.wordpress.org/trunk@27881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 17:40:28 +00:00
Andrew Nacin
4d6fcfdba1 Escape playlist data in templates. 
props wonderboymusic.
fixes #27710.

Built from https://develop.svn.wordpress.org/trunk@28050


git-svn-id: http://core.svn.wordpress.org/trunk@27880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 17:40:14 +00:00
Scott Taylor
2c963a82f7 Restore GalleryAdd() and GalleryEdit() in media-views.js to ensure back-compat. 
See [27362].


Built from https://develop.svn.wordpress.org/trunk@28048


git-svn-id: http://core.svn.wordpress.org/trunk@27878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 15:54:14 +00:00
Dominik Schilling
ad278c17e0 Move toolbar declaration after the :visible check, like it was before [28019]. 
props kovshenin.
fixes #24859.
Built from https://develop.svn.wordpress.org/trunk@28046


git-svn-id: http://core.svn.wordpress.org/trunk@27876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 11:21:15 +00:00
Andrew Ozz
fd0ae7e406 Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055, #26907, #16284 
Built from https://develop.svn.wordpress.org/trunk@28045


git-svn-id: http://core.svn.wordpress.org/trunk@27875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 08:29:14 +00:00
Dominik Schilling
3f3a1380d2 Widget Customizer: Fix widget filtering. 
props westonruter.
fixes #27451.
Built from https://develop.svn.wordpress.org/trunk@28044


git-svn-id: http://core.svn.wordpress.org/trunk@27874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 08:12:15 +00:00
Andrew Ozz
268092761d DFW: 
- Move the word count and "Just Write" to a fixed bar at the bottom.
- Fix responsive mode to 480px. Narrower screens will have a scroll bar.
- Hide the Help button on screens < 480px, move the Save button to the right, make it bigger to match the others, and other responsive mode fixes.
Fixes #26907, see #27709
Built from https://develop.svn.wordpress.org/trunk@28043


git-svn-id: http://core.svn.wordpress.org/trunk@27873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 07:49:14 +00:00
Drew Jaynes
a55d734f60 Clarify documentation for hooks in sanitize_post_field(). 
* `edit_post_{$field}` pairs with `edit_{$field}`
* `pre_post_{$field}` pairs with `pre_{$field}`
* `post_{$field}` pairs with `{$field}`

As the above pairs' docs are unnecessarily duplicative, the second sets of docs have been removed. Also, the "duplicates" are purposely not marked as such in this case as the hook names differ. Also remove `@deprecated` tags mistakenly left in in [28041].

See #25376.

Built from https://develop.svn.wordpress.org/trunk@28042


git-svn-id: http://core.svn.wordpress.org/trunk@27872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 07:41:14 +00:00
Drew Jaynes
07ee43d6d0 Part I of inline documenation for hooks in wp-includes/post.php. 
Adds docs for the following hooks:
* `get_attached_file`
* `update_attached_file`
* `_wp_relative_upload_path`
* `post_type_labels_{$post_type}`
* `edit_{$field}`
* `{$field_no_prefix}_edit_pre`
* `edit_post_{$field}`
* `pre_{$field}`
* `{$field_no_prefix}_save_pre`
* `pre_post_{$field}`
* `{$field}_pre`
* `$field`
* `post_{$field}`
* `wp_count_posts`
* `wp_count_attachments`
* `post_mime_types`
* `wp_insert_post_empty_content`

See #25376.

Built from https://develop.svn.wordpress.org/trunk@28041


git-svn-id: http://core.svn.wordpress.org/trunk@27871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 06:49:14 +00:00
Andrew Nacin
3ff5c2c954 Media Templates: More escaping rather than interpolation. see #21785. 
Built from https://develop.svn.wordpress.org/trunk@28039


git-svn-id: http://core.svn.wordpress.org/trunk@27869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 05:28:15 +00:00
Andrew Nacin
819da2ac6d Nuke the TinyMCE help dialog as it is duplicated by help tabs. This leaves just Keyboard Shortcuts. 
fixes #27100.

Built from https://develop.svn.wordpress.org/trunk@28032


git-svn-id: http://core.svn.wordpress.org/trunk@27862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 02:32:14 +00:00
Andrew Nacin
c870767d98 Header Images: Add suggested dimensions to the media workflow. 
This updates [28030] to the latest patch.

props gcorne.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@28031


git-svn-id: http://core.svn.wordpress.org/trunk@27861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 01:57:16 +00:00
Andrew Nacin
6b41f728d4 Header Images: Add suggested dimensions to the media workflow. 
props ehg, gcorne.
see #21785.

Built from https://develop.svn.wordpress.org/trunk@28030


git-svn-id: http://core.svn.wordpress.org/trunk@27860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 01:55:15 +00:00
Andrew Nacin
64936ec9b5 TinyMCE help: Break up strings changed in [28027] for ease of changing later. 
Restores a not inaccurate paragraph to reduce churn.

see #27100.

Built from https://develop.svn.wordpress.org/trunk@28028


git-svn-id: http://core.svn.wordpress.org/trunk@27858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 01:19:15 +00:00
Andrew Ozz
06acbdcd5a TinyMCE help modal: 
- Don't load the old tiny_mce_popup.js.
- Add the shortcut for <code> and the second shortcut for link to the shortcuts listing.
- Update some of the text.
See #27100
Built from https://develop.svn.wordpress.org/trunk@28027


git-svn-id: http://core.svn.wordpress.org/trunk@27857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 23:53:15 +00:00
Drew Jaynes
697bef3383 Improve hook docs for the wp_enqueue_editor hook, added in 3.9. 
See #16284, #27700.

Built from https://develop.svn.wordpress.org/trunk@28026


git-svn-id: http://core.svn.wordpress.org/trunk@27856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 23:09:15 +00:00
Andrew Ozz
5ce9ab1293 Fix typo and add more text to the error shown when 'wpdialogs' is not enqueued. Add 'wp_enqueue_editor' action fired when scripts and styles for the editor are being enqueued, fixes #16284 
Built from https://develop.svn.wordpress.org/trunk@28024


git-svn-id: http://core.svn.wordpress.org/trunk@27854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:55:15 +00:00
Scott Taylor
42a66ea424 Make playlist tracks keyboard-accessible. 
Fixes #27644.


Built from https://develop.svn.wordpress.org/trunk@28023


git-svn-id: http://core.svn.wordpress.org/trunk@27853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:28:16 +00:00
Andrew Nacin
1860b6a007 Rename USE_EXT_MYSQL to WP_USE_EXT_MYSQL. see #21663. 
Built from https://develop.svn.wordpress.org/trunk@28022


git-svn-id: http://core.svn.wordpress.org/trunk@27852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:27:15 +00:00
Andrew Nacin
68298460d4 Clean up deprecated format_to_post() docs. see #27700. 
Built from https://develop.svn.wordpress.org/trunk@28021


git-svn-id: http://core.svn.wordpress.org/trunk@27851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:23:14 +00:00
Drew Jaynes
4f818f51a9 More formatting for functions deprecated in 3.9. 
Props kpdesign.
Fixes #27700.

Built from https://develop.svn.wordpress.org/trunk@28020


git-svn-id: http://core.svn.wordpress.org/trunk@27850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:17:15 +00:00
Helen Hou-Sandí
df49618d0e Only show the media library loading spinner if we're scrolled toward the bottom. Prevents the spinner from flashing a second time when first loading the library due to a second query firing after initial load. 
props kovshenin. fixes #24859.

Built from https://develop.svn.wordpress.org/trunk@28019


git-svn-id: http://core.svn.wordpress.org/trunk@27849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:15:15 +00:00
Drew Jaynes
960a45a9cb Even deprecated functions can use a little PHPDoc formatting, time to time. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28018


git-svn-id: http://core.svn.wordpress.org/trunk@27848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:12:16 +00:00
Drew Jaynes
b5ecc00b32 PHPDoc fixes for functionality in wp-includes/wp-db.php added in 3.9. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28016


git-svn-id: http://core.svn.wordpress.org/trunk@27846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 22:02:15 +00:00
Drew Jaynes
5c3c97ead6 PHPDoc fixes for wp_validate_logged_in_cookie(), introduced in 3.9. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28015


git-svn-id: http://core.svn.wordpress.org/trunk@27845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:43:15 +00:00
Drew Jaynes
f52aefd02b Fix PHPDoc formatting for WP_Rewrite::add_endpoint(). 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28014


git-svn-id: http://core.svn.wordpress.org/trunk@27844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:39:15 +00:00
Andrew Ozz
df7b16dda1 TinyMCE: show an error in the console when a plugin attempts to use the 'wpdialogs' plugin but wpdialog.js is not enqueued, fixes #16284 
Built from https://develop.svn.wordpress.org/trunk@28012


git-svn-id: http://core.svn.wordpress.org/trunk@27842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:35:15 +00:00
Drew Jaynes
320b3751a3 Add a missing @since 3.9.0 to the PHPDoc for wp_register_plugin_realpath(). 
See #16953, #27700.

Built from https://develop.svn.wordpress.org/trunk@28011


git-svn-id: http://core.svn.wordpress.org/trunk@27841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:34:14 +00:00
Drew Jaynes
4ed628a7c6 Improve inline documentation for functionality in wp-includes/plugin.php added in 3.9. 
See #14994, #27700.

Built from https://develop.svn.wordpress.org/trunk@28010


git-svn-id: http://core.svn.wordpress.org/trunk@27840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:30:14 +00:00
Andrew Nacin
827b92a9bd Formally deprecate wpmu_current_site(). 
props jeremyfelt.
fixes #27702.

Built from https://develop.svn.wordpress.org/trunk@28009


git-svn-id: http://core.svn.wordpress.org/trunk@27839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:28:16 +00:00
Andrew Nacin
b00e343a25 Gallery Views: Avoid JS errors when image attachments lack metadata. 
props gcorne.
fixes #27691.

Built from https://develop.svn.wordpress.org/trunk@28008


git-svn-id: http://core.svn.wordpress.org/trunk@27838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:25:16 +00:00
Drew Jaynes
684145ca81 Inline documentation fixes related to the determine_current_user filter 
See #26706, #27700.

Built from https://develop.svn.wordpress.org/trunk@28007


git-svn-id: http://core.svn.wordpress.org/trunk@27837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 21:18:15 +00:00
Drew Jaynes
a4f4744a3b Inline documentation improvements in wp-includes/ms-load.php for 3.9 functionality. 
Clarifies some mixed type parameters, spacing and comment style, and language fixes.

See #27700.

Built from https://develop.svn.wordpress.org/trunk@28006


git-svn-id: http://core.svn.wordpress.org/trunk@27836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:59:15 +00:00
Drew Jaynes
eebf49c180 General PHPDoc improvements in wp-includes/media.php for 3.9 functionality. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28004


git-svn-id: http://core.svn.wordpress.org/trunk@27834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:38:15 +00:00
Drew Jaynes
c2e0a4bf46 Space vs tab in function descriptions for wp_underscore_audio_template() and wp_underscore_video_template(). 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28003


git-svn-id: http://core.svn.wordpress.org/trunk@27833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:29:14 +00:00
Andrew Nacin
10b8c92b1e wpdb: Don't pass a second argument to mysqli_fetch_field(). 
props pento.
fixes #27693.

Built from https://develop.svn.wordpress.org/trunk@28002


git-svn-id: http://core.svn.wordpress.org/trunk@27832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:22:28 +00:00
Drew Jaynes
d568e9029d Improve PHPDoc formatting for get_the_permalink(). 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28001


git-svn-id: http://core.svn.wordpress.org/trunk@27831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:22:15 +00:00
Drew Jaynes
35fb93858a Use suggested language conventions in the hook docs description for the theme_page_templates filter. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@28000


git-svn-id: http://core.svn.wordpress.org/trunk@27830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:18:14 +00:00
Andrew Nacin
0b5729216d Don't try to resolve symlinks for single-file plugins. plugins_url() should not be used in this context anyway. 
props rmccue.
fixes #16953.

Built from https://develop.svn.wordpress.org/trunk@27999


git-svn-id: http://core.svn.wordpress.org/trunk@27829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:15:15 +00:00
Dominik Schilling
771fcb128a Update Dashicons. 
New icons: `.dashicons-external`, `.dashicons-editor-contract` and `.dashicons-universal-access-alt`.
Updated icons: `.dashicons-code`, `.dashicons-universal-access`, `.dashicons-arrow-x-alt` and `.dashicons-arrow-x-alt2`.
Restores also `.dashicons-post-trash` as an alias for `.dashicons-trash`, which is the new one.

props melchoyce, empireoflight.
see #26936.
Built from https://develop.svn.wordpress.org/trunk@27989


git-svn-id: http://core.svn.wordpress.org/trunk@27819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 17:52:16 +00:00
Scott Taylor
5a67d92611 Browsers other than Firefox need a timeout when parsing audio and video shortcodes into MCE views. 
See [27655].


Built from https://develop.svn.wordpress.org/trunk@27987


git-svn-id: http://core.svn.wordpress.org/trunk@27817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 15:12:15 +00:00
Dominik Schilling
fabc65b787 Widget Customizer: Move WidgetCustomizer to wp.customize.Widgets. First pass. 
see #27690.
Built from https://develop.svn.wordpress.org/trunk@27985


git-svn-id: http://core.svn.wordpress.org/trunk@27815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 09:04:14 +00:00
Dominik Schilling
de2f2f449b Remove trailing whitespace from [27982]. 
Built from https://develop.svn.wordpress.org/trunk@27984


git-svn-id: http://core.svn.wordpress.org/trunk@27814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 09:03:14 +00:00
Andrew Ozz
a6299d337c TinyMCE: couple more small css tweaks for the menubar and tabs in native modals, see #27279 
Built from https://develop.svn.wordpress.org/trunk@27983


git-svn-id: http://core.svn.wordpress.org/trunk@27813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 07:11:15 +00:00
Andrew Ozz
1747c112d1 Add a note that wpView is "experimental", see #26959 
Built from https://develop.svn.wordpress.org/trunk@27982


git-svn-id: http://core.svn.wordpress.org/trunk@27812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 06:59:16 +00:00
Andrew Ozz
2f2e5635cb Heartbeat: no longer "experimental", see #25272 
Built from https://develop.svn.wordpress.org/trunk@27981


git-svn-id: http://core.svn.wordpress.org/trunk@27811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 06:33:16 +00:00
Scott Taylor
10b80870ee Only set the poster attribute automatically for videos when the image does not match the default mime-type icon. wp_prepare_attachment_for_js() is used in multiple contexts. This context requires disambiguation. 
See [27659].


Built from https://develop.svn.wordpress.org/trunk@27980


git-svn-id: http://core.svn.wordpress.org/trunk@27810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 06:20:16 +00:00
Scott Taylor
2c88f6e941 [27640] supported a caption for audio and video shortcodes as part of a UX iteration for the related MCE views. These captions have since be excluded, so the extra code should be removed (it was there for this sole reason). 
See #27320.


Built from https://develop.svn.wordpress.org/trunk@27979


git-svn-id: http://core.svn.wordpress.org/trunk@27809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 06:13:18 +00:00
Andrew Ozz
956301ece7 TinyMCE: 
- Tighten up button styles, add :hover for .mce-active buttons.
- Pad only the first toolbar row and remove the padding in both toolbars if the editor doesn't have a DFW mode.
Part props avryl, see #27279
Built from https://develop.svn.wordpress.org/trunk@27978


git-svn-id: http://core.svn.wordpress.org/trunk@27808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 01:10:15 +00:00
Scott Taylor
7689cc4a74 When dynamically instantiating MediaElementPlayer instances in JS, preload="metadata" is extremely wonky. preload="none" lets the file play right away. 
This has already been addressed for audio|video shortcodes, but also needs to be the case for playlists. When loading a playlist from a DOM cache or via AJAX, and when the sources match those already pre-loaded, the browser will sometimes donkey-punch the HTTP request for the first cached track selected.

Set `preload="none"` for the empty `<audio|video>` tag for playlists.

See commits related to #26779.


Built from https://develop.svn.wordpress.org/trunk@27974


git-svn-id: http://core.svn.wordpress.org/trunk@27804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 21:33:15 +00:00
Dominik Schilling
29b1f9a0de Widget Customizer: Remove leading/trailing whitespace to prevent jQuery migrate warning. 
props gcorne.
fixes #27689.
Built from https://develop.svn.wordpress.org/trunk@27973


git-svn-id: http://core.svn.wordpress.org/trunk@27803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 20:40:15 +00:00
Dominik Schilling
f8d4a00b6a Update TinyMCE help for pasting content. 
props chiragswadia.
see #27100.
Built from https://develop.svn.wordpress.org/trunk@27972


git-svn-id: http://core.svn.wordpress.org/trunk@27802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 19:46:15 +00:00
Dominik Schilling
ed8132dedd Header images: Revert unnecessary tabindex="0" from [27947]. 
see #21785.
Built from https://develop.svn.wordpress.org/trunk@27971


git-svn-id: http://core.svn.wordpress.org/trunk@27801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 19:36:15 +00:00
Dominik Schilling
5f1c818477 Header images: Improve accessibility of Randomize buttons. 
props ehg.
see #27598, #21785.
Built from https://develop.svn.wordpress.org/trunk@27970


git-svn-id: http://core.svn.wordpress.org/trunk@27800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 19:28:16 +00:00
Dominik Schilling
90e62bf6ac Widget Customizer: Minor code cleanup. 
* Remove type hinting from `WP_Customize_Widgets`
* Rename `inject_preview_css` to `print_preview_css`
* Remove stray `@todo`

fixes #27534.
Built from https://develop.svn.wordpress.org/trunk@27968


git-svn-id: http://core.svn.wordpress.org/trunk@27798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 18:54:14 +00:00
Dominik Schilling
1ce1882a8a Fix whitespace around $GLOBALS['_wp_deprecated_widgets_callbacks'] . 
Built from https://develop.svn.wordpress.org/trunk@27967


git-svn-id: http://core.svn.wordpress.org/trunk@27797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 18:50:14 +00:00
Dominik Schilling
598907559c WP_Widget: Introduce is_preview() method. 
With the Widget Customizer it's possible that previewed widgets can leak data outside of Customizer, when the widget uses the cache API.
The Customizer calls the regular update callback which should already refresh the cache. Since cache additions aren't blocked yet the cache can be filled with preview data.
To prevent this issue `WP_Widget::is_preview()` will return true, when `$wp_customize->is_preview()` returns true. If `is_preview()` is true, cache additions are suspended via `wp_suspend_cache_addition()`. Make sure your object cache drop-in has implemented `wp_suspend_cache_addition()`.

`is_preview()` can/should also be used inside `WP_Widget::widget()`, see WP_Widget_Recent_Posts or WP_Widget_Recent_Comments for examples.

For more info see IRC logs: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-04-02&sort=asc#m824279

props westonruter.
fixes #27538.
Built from https://develop.svn.wordpress.org/trunk@27966


git-svn-id: http://core.svn.wordpress.org/trunk@27796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 18:48:16 +00:00
Scott Taylor
3238664215 Revert the changes made to data.title in playlist Underscore templates in [27869]. {{ data.title }} causes the title to be double-encoded on the front end. 
See #27574.


Built from https://develop.svn.wordpress.org/trunk@27960


git-svn-id: http://core.svn.wordpress.org/trunk@27790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 20:06:16 +00:00