John Blackbourn
905460bd5e
Docs: Standardise the type name for booleans and integers.
...
This brings these docs inline with the documentation standards.
Props ravipatel, justinahinon
Fixes #51426
Built from https://develop.svn.wordpress.org/trunk@49120
git-svn-id: http://core.svn.wordpress.org/trunk@48882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-10 20:02:05 +00:00
Sergey Biryukov
897f004a9c
General: Replace older-style PHP type conversion functions with type casts.
...
This improves performance, readability, and consistency throughout core.
* `intval()` → `(int)`
* `strval()` → `(string)`
* `floatval()` → `(float)`
Props ayeshrajans.
Fixes #42918 .
Built from https://develop.svn.wordpress.org/trunk@49108
git-svn-id: http://core.svn.wordpress.org/trunk@48870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-08 21:15:13 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Gary Pendergast
0d23be600e
Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments
violations in the default themes.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45581
git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:23:57 +00:00
Adam Silverstein
18ccaf962e
Bundled Theme: add a wp_body_open
shim for older WordPress versions.
...
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.
Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679 .
Built from https://develop.svn.wordpress.org/trunk@45256
git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 13:04:56 +00:00
Gary Pendergast
7a617078fa
Coding Standards: Upgrade WPCS to 1.2.1.
...
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.
Fixes #45956 .
Built from https://develop.svn.wordpress.org/trunk@44574
git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
David A. Kennedy
ca0274c2ce
Bundled Themes: Allow category display in post preview even when only one category
...
The category is not shown in the preview. And because of how `themename_categorized_blog()` function in each theme returns false for 1 or fewer categories, and in this case it won't show the new category.
The patch uses `is_preview()` to fix that in Twenty Fourteen, Fifteen and Seventeen.
Props lancewillett.
Fixes #39531 .
Built from https://develop.svn.wordpress.org/trunk@40023
git-svn-id: http://core.svn.wordpress.org/trunk@39960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-27 22:09:42 +00:00
Drew Jaynes
64bc6934f1
Add an entry to the changelog for twentyfourteen_post_thumbnail()
noting that it was made 'pluggable'.
...
Fixes #31374 .
Built from https://develop.svn.wordpress.org/trunk@31482
git-svn-id: http://core.svn.wordpress.org/trunk@31463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 10:35:28 +00:00
Lance Willett
5dc3b77be3
Twenty Fourteen: make twentyfourteen_post_thumbnail()
pluggable.
...
Fixes #31374 , props wordpressorru.
Built from https://develop.svn.wordpress.org/trunk@31481
git-svn-id: http://core.svn.wordpress.org/trunk@31462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-19 19:43:28 +00:00
John Blackbourn
64fb3e7175
In Twenty Fourteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised.
...
See #30641
Built from https://develop.svn.wordpress.org/trunk@30796
git-svn-id: http://core.svn.wordpress.org/trunk@30786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 18:57:24 +00:00
Lance Willett
f398bd07ce
Twenty Fourteen: replace ellipses appended to automatically generated excerpts with both ellipses and a "Continue Reading" link to meet accessibility-ready requirements.
...
Props davidakennedy, lancewillett. Fixes #30176 .
Built from https://develop.svn.wordpress.org/trunk@30389
git-svn-id: http://core.svn.wordpress.org/trunk@30386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 18:27:22 +00:00
Lance Willett
d2b903f896
Twenty Fourteen: improve post thumbnail HTML output.
...
* Add `aria-hidden` attribute to reduce verbosity on archive pages.
* Add alt text in archives to avoid confusing link texts, see #30076 for context in Twenty Fifteen.
Props hiwhatsup, joedolson. Fixes #30144 .
Built from https://develop.svn.wordpress.org/trunk@30387
git-svn-id: http://core.svn.wordpress.org/trunk@30384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 18:12:21 +00:00
Lance Willett
e90f45e031
Twenty Fourteen: pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@29169
git-svn-id: http://core.svn.wordpress.org/trunk@28953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 17:49:15 +00:00
Lance Willett
c2f0505bcf
Twenty Fourteen: change hardcoded pagination base to use the WordPress Rewrite object's pagination_base
value instead. Document global variable usage properly.
...
Props SergeyBiryukov, fixes #28405 .
Built from https://develop.svn.wordpress.org/trunk@28645
git-svn-id: http://core.svn.wordpress.org/trunk@28463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-31 18:51:19 +00:00
Lance Willett
a46e7ca3dc
Twenty Fourteen: remove doc block comments for @return void
. See #27098 , props philiparthurmoore.
...
Built from https://develop.svn.wordpress.org/trunk@27595
git-svn-id: http://core.svn.wordpress.org/trunk@27438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:44:14 +00:00
Scott Taylor
6df629fb02
in TwentyFourteen: don't add the has-post-thumbnail
class or print the featured image when viewing an attachment.
...
See #27243 .
Built from https://develop.svn.wordpress.org/trunk@27330
git-svn-id: http://core.svn.wordpress.org/trunk@27182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 21:57:13 +00:00
Lance Willett
3e24cf1636
Twenty Fourteen: remove redundant parentheses and translation wrapper, see #25946 .
...
Built from https://develop.svn.wordpress.org/trunk@26698
git-svn-id: http://core.svn.wordpress.org/trunk@26588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:47:10 +00:00
Lance Willett
63c82dd11d
Twenty Fourteen: remove invalid rel
attributes from post thumbnail output, and fix a CSS typo. See #25946 and #25325 .
...
Built from https://develop.svn.wordpress.org/trunk@26694
git-svn-id: http://core.svn.wordpress.org/trunk@26584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:09:10 +00:00
Lance Willett
7e7666d514
Twenty Fourteen: remove wp_is_mobile()
call from post thumbnail size logic as it's not intended for front-end use. Props kwight, fixes #26221 .
...
Built from https://develop.svn.wordpress.org/trunk@26599
git-svn-id: http://core.svn.wordpress.org/trunk@26489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 03:29:10 +00:00
Lance Willett
abfec528c3
Twenty Fourteen: rename transient all_the_cool_cats
and make sure count is an integer before checking it. Props SergeyBiryukov for initial patch, fixes #26319 .
...
Built from https://develop.svn.wordpress.org/trunk@26572
git-svn-id: http://core.svn.wordpress.org/trunk@26463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 18:24:10 +00:00
Lance Willett
e46662b6ae
Twenty Fourteen: update comment blocks to match inline docs standards. Props DrewAPicture, see #25837 .
...
Built from https://develop.svn.wordpress.org/trunk@26556
git-svn-id: http://core.svn.wordpress.org/trunk@26447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:06:11 +00:00
Lance Willett
9e201fadff
Twenty Fourteen: updates all PHP files to meet new brace style in WP coding standards. Props rickalee for initial patch, fixes #26093 .
...
Built from https://develop.svn.wordpress.org/trunk@26260
git-svn-id: http://core.svn.wordpress.org/trunk@26166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 23:11:10 +00:00
Lance Willett
3c0f497fad
Twenty Fourteen: general cleanup for spacing, inline comments. Props obenland, see #25946 .
...
Built from https://develop.svn.wordpress.org/trunk@26227
git-svn-id: http://core.svn.wordpress.org/trunk@26134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 21:20:09 +00:00
Lance Willett
c8cfe17a02
Twenty Fourteen: simplify and prefix post thumbnail sizes, props obenland. See #25946 .
...
Built from https://develop.svn.wordpress.org/trunk@26152
git-svn-id: http://core.svn.wordpress.org/trunk@26063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 04:50:11 +00:00
Lance Willett
a68971ba3e
Twenty Fourteen: move page templates into their own directory. See #25929 .
...
Built from https://develop.svn.wordpress.org/trunk@26105
git-svn-id: http://core.svn.wordpress.org/trunk@26020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-12 19:03:09 +00:00
Lance Willett
68491fafb3
Twenty Fourteen: full-width page template should display a full-width featured image, except for mobile. Fixes #25925 , props iamtakashi.
...
Built from https://develop.svn.wordpress.org/trunk@26098
git-svn-id: http://core.svn.wordpress.org/trunk@26013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-12 16:47:10 +00:00
Lance Willett
d028b169d2
Twenty Fourteen: remove the pattern image used as a placeholder for featured images. This greatly improves the "first run" experience of the theme and gives it a more general appeal as a blog theme by putting less of a requirement on featured images. Props iamtakashi, fixes #25859 .
...
Built from https://develop.svn.wordpress.org/trunk@26034
git-svn-id: http://core.svn.wordpress.org/trunk@25963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-07 17:29:10 +00:00
Lance Willett
35af8942ab
Twenty Fourteen: add full-width featured images for layouts without a content sidebar, but use wp_is_mobile()
to load smaller-sized images for mobile. Props iamtakashi, fixes #25758 .
...
Built from https://develop.svn.wordpress.org/trunk@26026
git-svn-id: http://core.svn.wordpress.org/trunk@25956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-06 20:40:10 +00:00
Andrew Nacin
d0cfa40983
Add jshintrc to qunit.
...
props jorbin.
see #25187 .
Built from https://develop.svn.wordpress.org/trunk@25992
git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Lance Willett
b761edc198
Twenty Fourteen: fix non-image attachment page layout, props iamtakashi. Fixes #25624 .
...
Built from https://develop.svn.wordpress.org/trunk@25856
git-svn-id: http://core.svn.wordpress.org/trunk@25856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:34 +00:00
Andrew Nacin
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Lance Willett
cde77ec4ea
Twenty Fourteen: fix non-image attachment page layout, props iamtakashi. Fixes #25624 .
...
Built from https://develop.svn.wordpress.org/trunk@25856
git-svn-id: http://core.svn.wordpress.org/trunk@25768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-21 16:35:09 +00:00
Lance Willett
f98e6f60fb
Twenty Fourteen: better logic for featured image HTML output, and add fallback message for focusable anchor elements, for accessibility. Fixes #25325 .
...
Built from https://develop.svn.wordpress.org/trunk@25802
git-svn-id: http://core.svn.wordpress.org/trunk@25714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 23:24:10 +00:00
Lance Willett
eaf78d3f7c
Twenty Fourteen: first pass for updating code comments to reflect WP inline docs standards, see #25257 .
...
Built from https://develop.svn.wordpress.org/trunk@25769
git-svn-id: http://core.svn.wordpress.org/trunk@25682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 22:02:11 +00:00
Lance Willett
66be5edfb5
Twenty Fourteen: remove title attributes for better accessibility. Props sabreuse for original patch, see #25054 .
...
Built from https://develop.svn.wordpress.org/trunk@25743
git-svn-id: http://core.svn.wordpress.org/trunk@25656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:07:09 +00:00
Lance Willett
c78cbb19ce
Twenty Fourteen: allow pages to have featured images, props iamtakashi. Fixes #25325 .
...
Built from https://develop.svn.wordpress.org/trunk@25735
git-svn-id: http://core.svn.wordpress.org/trunk@25648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 21:22:10 +00:00
Lance Willett
7a05f8d19c
Twenty Fourteen: Align post format handling with Twenty Thirteen. Props Frank Klein and obenland, see #24877 .
...
Built from https://develop.svn.wordpress.org/trunk@25088
git-svn-id: http://core.svn.wordpress.org/trunk@25072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 17:03:10 +00:00
Lance Willett
a260ebf932
Twenty Fourteen: Use HTML5 comment markup, props obenland. Fixes #25045 .
...
Built from https://develop.svn.wordpress.org/trunk@25087
git-svn-id: http://core.svn.wordpress.org/trunk@25071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 17:01:08 +00:00
Lance Willett
a872d95778
Twenty Fourteen: second pass at matching code standards achieved with Twenty Thirteen development. See #24858 , props obenland.
...
Built from https://develop.svn.wordpress.org/trunk@25023
git-svn-id: http://core.svn.wordpress.org/trunk@25014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:44 +00:00
Lance Willett
e5c55b09e9
Twenty Fourteen: first pass at matching code standards achieved with Twenty Thirteen development. See #24858 , props obenland.
...
Built from https://develop.svn.wordpress.org/trunk@25021
git-svn-id: http://core.svn.wordpress.org/trunk@25012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:29 +00:00
Lance Willett
7d35419e62
Importing the Further theme, first pass at the new default theme for 2014.
...
A magazine theme with clean, responsive design focused on highlighting featured content prominently on home page.
This is slated for 3.8. Development will occur in trunk for the theme, and in plugins for the nice-to-have features.
Nice-to-have improvements include:
- Add a Contributors page template to highlight authors.
- Easy-to-manage featured content.
- Add support for an Authors widget to highlight authors.
Welcome, Twenty Fourteen né Further. Props iamtakashi, see #24858 .
git-svn-id: http://core.svn.wordpress.org/trunk@24832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 22:55:10 +00:00