John Blackbourn
4548b08236
General: Use interpolation instead of concatenation for all dynamic hook names.
...
This fixes the rendering of the hook names on developer.wordpress.org.
Props keesiemeijer
Fixes #39148
Built from https://develop.svn.wordpress.org/trunk@39600
git-svn-id: http://core.svn.wordpress.org/trunk@39540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-14 04:18:42 +00:00
John Blackbourn
efa99585e3
Posts, Post Types: Ensure is_page_template()
can only return true when viewing a singular post query.
...
Props natereist, dlh
Fixes #39211
Built from https://develop.svn.wordpress.org/trunk@39599
git-svn-id: http://core.svn.wordpress.org/trunk@39539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-14 03:43:43 +00:00
James Nylen
505e135f4c
REST API: Add support for filename search in media endpoint.
...
In [38625], the functionality to search for attachments by filename was added
via the `posts_clauses` filter and the `_filter_query_attachment_filenames()`
function. This moves `_filter_query_attachment_filenames()` from
`wp-admin/includes/post.php` to `wp-includes/post.php` so that it can be
applied in the same manner in the REST API media endpoint.
Props jblz, tyxla.
Fixes #39092 .
Built from https://develop.svn.wordpress.org/trunk@39598
git-svn-id: http://core.svn.wordpress.org/trunk@39538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 14:09:42 +00:00
James Nylen
7cc41e47ac
REST API: Allow sending an empty or no-op comment update.
...
In general, updates that don't actually change anything should succeed.
[39371] added tests for other object types, and this commit fixes empty updates
for comments and adds the missing test.
Fixes #38700 .
Built from https://develop.svn.wordpress.org/trunk@39597
git-svn-id: http://core.svn.wordpress.org/trunk@39537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 13:53:45 +00:00
Gary Pendergast
7d9b5b14b5
Libraries: Update zxcvbn from version 1.0 to 4.4.1
...
This includes masses of bug fixes, as well as tweaks to how passwords are scored.
QUnit tests have been updated to reflect tha scoring changes.
Full changelog: https://github.com/dropbox/zxcvbn/compare/v1.0...v4.4.1
Fixes #31647 .
Built from https://develop.svn.wordpress.org/trunk@39596
git-svn-id: http://core.svn.wordpress.org/trunk@39536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 11:23:42 +00:00
James Nylen
d7ab7fdf5a
REST API: Do not include the password
argument when getting media items
...
Currently, `attachment` is the only post type exposed via the REST API that
does not support password protection, but it's possible for other post types to
remove password support.
Fixes #38977 .
Built from https://develop.svn.wordpress.org/trunk@39595
git-svn-id: http://core.svn.wordpress.org/trunk@39535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 03:51:44 +00:00
James Nylen
0b599cce41
REST API: Do not error on empty JSON body
...
It's fairly common for clients to send `Content-Type: application/json` with an
empty body. While technically not valid JSON, we've historically supported
this behaviour, so it shouldn't cause an error.
Props JPry.
Fixes #39150 .
Built from https://develop.svn.wordpress.org/trunk@39594
git-svn-id: http://core.svn.wordpress.org/trunk@39534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 03:34:41 +00:00
Boone Gorges
aa644128d6
Taxonomy: Use get_term_link()
instead of get_category_link()
in get_term_parents_list()
.
...
`get_category_link()` is a wrapper for `get_term_link()`. Using the
unwrapped function makes more sense semantically (it's taxonomy-
agnostic) and it's also more parsimonious (the `WP_Error` check in
`get_category_link()` is redundant with similar checks just before
in `get_term_link()`).
Props keesiemeijer.
Fixes #17069 .
Built from https://develop.svn.wordpress.org/trunk@39593
git-svn-id: http://core.svn.wordpress.org/trunk@39533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 02:57:41 +00:00
Ryan McCue
20aa5d7150
General: Correctly detect trailing newline when prepending.
...
We need to check that the final line is actually an artifact of explode(), not just an empty input string.
See #37082 .
Built from https://develop.svn.wordpress.org/trunk@39592
git-svn-id: http://core.svn.wordpress.org/trunk@39532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 02:48:41 +00:00
Ryan McCue
fbc00b31ef
General: Remove most uses of create_function()
...
create_function() is equivalent to eval(), and most of our uses can be refactored. This is simpler, more secure, and slightly more performant.
Props sgolemon.
Fixes #37082 .
Built from https://develop.svn.wordpress.org/trunk@39591
git-svn-id: http://core.svn.wordpress.org/trunk@39531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 01:49:39 +00:00
Felix Arntz
6e2d9af8b6
Tests: Use wp_delete_user()
during teardown to delete a single site's user.
...
Fixes failing tests for `get_dashboard_url()`.
Fixes #39065 .
Built from https://develop.svn.wordpress.org/trunk@39590
git-svn-id: http://core.svn.wordpress.org/trunk@39530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 23:18:40 +00:00
Felix Arntz
d784b5552c
Multisite: Replace is_super_admin()
with manage_network
in get_dashboard_url()
.
...
Unit tests for `get_dashboard_url()` have been added.
Props iaaxpage.
Fixes #39065 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39589
git-svn-id: http://core.svn.wordpress.org/trunk@39529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 22:41:39 +00:00
Felix Arntz
f704fc808a
Multisite: Handle capability check for removing oneself via map_meta_cap()
.
...
Site administrators should not be able to remove themselves from a site. This moves the enforcement of this rule from `wp-admin/users.php` to `remove_user_from_blog()` via the `remove_user` capability, which furthermore allows us to get rid of two additional clauses and their `is_super_admin()` checks in `wp-admin/users.php`. A unit test for the new behavior has been added.
Fixes #39063 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39588
git-svn-id: http://core.svn.wordpress.org/trunk@39528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 21:42:42 +00:00
Konstantin Obenland
ee36cf9214
Themes: Add missing square bracket in jQuery selector.
...
Fixes a bug in Safari where the UI wasn't updated after deleting a theme due to
the incomplete selector.
Props Hristo Sg.
Fixes #39246 .
Built from https://develop.svn.wordpress.org/trunk@39586
git-svn-id: http://core.svn.wordpress.org/trunk@39526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 09:32:41 +00:00
Weston Ruter
c9b863fc40
Customize: Prevent navigation in preview when clicking on child elements of preview links that have non-previewable URLs.
...
Fixes #39098 .
Built from https://develop.svn.wordpress.org/trunk@39584
git-svn-id: http://core.svn.wordpress.org/trunk@39524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 08:09:41 +00:00
Dion Hulse
5edd9b03e7
Remove the WordPress version number from readme.html
.
...
See #35554
Built from https://develop.svn.wordpress.org/trunk@39583
git-svn-id: http://core.svn.wordpress.org/trunk@39523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 08:01:39 +00:00
Weston Ruter
8a89a50c69
Customize: Prevent edit shortcut from losing event handler after selective refresh.
...
Props sirbrillig.
See #27403 .
Fixes #39100 .
Built from https://develop.svn.wordpress.org/trunk@39581
git-svn-id: http://core.svn.wordpress.org/trunk@39521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 07:52:43 +00:00
Dion Hulse
0a349c9641
PDF Images: Avoid a PHP Warning when attempting to process a file without an extension.
...
Props chandrapatel for initial patch.
Fixes #39195 .
Built from https://develop.svn.wordpress.org/trunk@39580
git-svn-id: http://core.svn.wordpress.org/trunk@39520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 06:19:41 +00:00
Dion Hulse
883689c816
Taxonomy: Restore the ability to use string-based $args
in wp_get_object_terms()
.
...
Props tyxla.
Fixes #39215
Built from https://develop.svn.wordpress.org/trunk@39578
git-svn-id: http://core.svn.wordpress.org/trunk@39518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 05:47:42 +00:00
Weston Ruter
826a0323a2
Build/Test Tools: Facilitate SVN and Git being co-located in the same directory.
...
Ignore .svn in .gitignore, and ignore .git in svn:ignore.
Fixes #39245 .
Built from https://develop.svn.wordpress.org/trunk@39577
git-svn-id: http://core.svn.wordpress.org/trunk@39517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 05:12:44 +00:00
Dion Hulse
bdf6087450
Bootstrap: Re-initialize any hooks added manually by object-cache.php
.
...
Prior to 3.1 if a object cache dropin wanted to add actions, they needed to use `$wp_filter` directly.
Props jorbin.
Fixes #39132 .
Built from https://develop.svn.wordpress.org/trunk@39565
git-svn-id: http://core.svn.wordpress.org/trunk@39505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-12 01:29:42 +00:00
Peter Wilson
c21907ca1e
Options: Prevent unnecessary SQL updates by update_option
.
...
Previously an option containing an object would trigger an SQL `UPDATE` on all calls to `update_option`, even if the old and new values were identical. This was due to the old and new values having differing resource IDs.
This change compares the old and new values as serialized data to remove the resource ID from the comparison.
Props salcode, bradyvercher, peterwilsoncc.
Fixes #38903 .
Built from https://develop.svn.wordpress.org/trunk@39564
git-svn-id: http://core.svn.wordpress.org/trunk@39504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-11 21:43:43 +00:00
Rachel Baker
d054b9afba
REST API: Allow schema sanitization_callback to be set to null to bypass fallback sanitization functions.
...
The logic in WP_REST_Request->sanitize_params() added in [39091] did not account for `null` or `false` being the sanitization_callback preventing overriding `rest_parse_request_arg()`. This fixes that oversight, allowing the built in sanitization function to be bypassed. See #38593 .
Props kkoppenhaver, rachelbaker, jnylen0.
Fixes #39042 .
Built from https://develop.svn.wordpress.org/trunk@39563
git-svn-id: http://core.svn.wordpress.org/trunk@39503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-11 21:26:43 +00:00
Weston Ruter
9669c60397
Customize: Fix ability to shift-click on placeholder/pre-saved nav menu items in preview to focus on corresponding control.
...
Fixes #39102 .
Built from https://develop.svn.wordpress.org/trunk@39562
git-svn-id: http://core.svn.wordpress.org/trunk@39502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 23:47:41 +00:00
Weston Ruter
57830bf2be
Customize: Deprecate page_home
nav menu item starter content in favor of home_link
; replace usage in Twenty Seventeen.
...
Props celloexpressions, westonruter.
Amends [38991].
See #38615 , #38114 .
Fixes #39104 .
Built from https://develop.svn.wordpress.org/trunk@39561
git-svn-id: http://core.svn.wordpress.org/trunk@39501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 23:39:43 +00:00
Weston Ruter
a366e58135
Customize: Trim whitespace for URLs supplied for external_header_video
to prevent esc_url_raw()
from making them invalid.
...
Props tyxla.
See #38172 .
Fixes #39125 .
Built from https://develop.svn.wordpress.org/trunk@39560
git-svn-id: http://core.svn.wordpress.org/trunk@39500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 07:00:45 +00:00
Weston Ruter
6527c24ab1
Customize: Prevent single quotes (apostrophes) in custom_css
values from unexpectedly causing false positives for unbalanced character validation errors.
...
See #39218 , #35395 .
Fixes #39198 .
Built from https://develop.svn.wordpress.org/trunk@39559
git-svn-id: http://core.svn.wordpress.org/trunk@39499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 06:45:42 +00:00
Weston Ruter
1b96e389c0
Customize: Fix inability to delete nav menus by preventing preview
filters from being added during customize_save
admin ajax request.
...
Also prevent setting `nav_menu_locations[...]` values to `NaN` which gets sent as `null`.
Amends [38810].
See #30937 .
Fixes #39103 .
Built from https://develop.svn.wordpress.org/trunk@39558
git-svn-id: http://core.svn.wordpress.org/trunk@39498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 06:30:46 +00:00
Weston Ruter
f1c383454b
Customize: Prevent scrolling custom_css
textarea to top when pressing tab.
...
Props tyxla, sstoqnov for testing, celloexpressions for testing.
See #38667 .
Fixes #39134 .
Built from https://develop.svn.wordpress.org/trunk@39557
git-svn-id: http://core.svn.wordpress.org/trunk@39497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 00:44:40 +00:00
John Blackbourn
5b15e8c11b
Build/Test Tools: Remove some more randomness.
...
See #37371
Built from https://develop.svn.wordpress.org/trunk@39556
git-svn-id: http://core.svn.wordpress.org/trunk@39496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-10 00:02:41 +00:00
John Blackbourn
da5255777a
Build/Test Tools: Reuse another fixture in the user capability tests.
...
See #38716
Built from https://develop.svn.wordpress.org/trunk@39555
git-svn-id: http://core.svn.wordpress.org/trunk@39495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 23:36:41 +00:00
John Blackbourn
b5f7ab46dd
Build/Test Tools: Remove commented out tests that have existed in an unimplemented state since the dawn of the test infrastructure.
...
See #38716
Built from https://develop.svn.wordpress.org/trunk@39554
git-svn-id: http://core.svn.wordpress.org/trunk@39494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 23:12:41 +00:00
Andrea Fercia
10819d629f
Accessibility: Remove inappropriate content from the Edit Categories and Edit Tags screens headings.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39553
git-svn-id: http://core.svn.wordpress.org/trunk@39493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 20:50:41 +00:00
Andrea Fercia
9d474c8206
Accessibility: Remove inappropriate content from the Edit Comments screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39552
git-svn-id: http://core.svn.wordpress.org/trunk@39492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 18:59:40 +00:00
Andrea Fercia
c05f1dc805
Accessibility: Remove inappropriate content from the Network screens headings.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39551
git-svn-id: http://core.svn.wordpress.org/trunk@39491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 18:57:42 +00:00
Boone Gorges
97fd5ae77c
Docs: Correct param definition for WP_Query::query()
.
...
Props Shelob9.
Fixes #38963 .
Built from https://develop.svn.wordpress.org/trunk@39550
git-svn-id: http://core.svn.wordpress.org/trunk@39490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 16:23:42 +00:00
Boone Gorges
74b6e1ba86
Taxonomy: Introduce get_term_parents_list()
.
...
This new function is a taxonomy-agnostic version of `get_category_parents()`.
Props keesiemeijer, SergeyBiryukov, rafaehlers.
Fixes #17069 .
Built from https://develop.svn.wordpress.org/trunk@39549
git-svn-id: http://core.svn.wordpress.org/trunk@39489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 16:10:42 +00:00
Weston Ruter
d94530e721
Customize: Collapse available nav menu items panel when clicking outside over preview or over existing items.
...
Props rockwell15.
Fixes #38953 .
Built from https://develop.svn.wordpress.org/trunk@39548
git-svn-id: http://core.svn.wordpress.org/trunk@39488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 06:16:40 +00:00
Weston Ruter
d10cde75c6
Customize: Allow (optional) url
parameter to be omitted in intercepted calls to history.pushState()
and history.replaceState()
in customize preview.
...
Fixes issue where calls without the `url` parameter erroneously end up rewriting the location path to `/undefined`.
Props Christian1012, westonruter.
Fixes #39175 .
Built from https://develop.svn.wordpress.org/trunk@39547
git-svn-id: http://core.svn.wordpress.org/trunk@39487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 01:59:41 +00:00
Weston Ruter
592c3fc7d7
Customize: Use esc_url_raw()
instead of wp_json_encode()
to eliminate extraneous slashes when outputting background image URL in CSS url()
.
...
Props tyxla, westonruter.
See #22058 .
Fixes #39145 .
Built from https://develop.svn.wordpress.org/trunk@39546
git-svn-id: http://core.svn.wordpress.org/trunk@39486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-09 01:43:42 +00:00
Weston Ruter
c68f1de5f8
Customize: Use selected user language for edit shortcuts in preview instead of site language.
...
Props ocean90.
Fixes #39009 .
Built from https://develop.svn.wordpress.org/trunk@39545
git-svn-id: http://core.svn.wordpress.org/trunk@39485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-08 19:32:59 +00:00
Boone Gorges
3a0e61e680
Allow apostrophes in email address during wp-login.php registration.
...
See #18039 for a related fix when creating users via the Dashboard.
Props tomdxw.
Fixes #34483 .
Built from https://develop.svn.wordpress.org/trunk@39544
git-svn-id: http://core.svn.wordpress.org/trunk@39484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-08 03:58:45 +00:00
Andrea Fercia
76a5b4f3c2
Accessibility: Remove inappropriate content from the Menus screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39543
git-svn-id: http://core.svn.wordpress.org/trunk@39483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 23:47:43 +00:00
Andrea Fercia
40e303237b
Accessibility: Remove inappropriate content from the old Edit Media screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39542
git-svn-id: http://core.svn.wordpress.org/trunk@39482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 23:30:40 +00:00
Andrea Fercia
2d76e0dfb2
Accessibility: Remove inappropriate content from the Widgets screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39541
git-svn-id: http://core.svn.wordpress.org/trunk@39481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 22:18:40 +00:00
Felix Arntz
da4cc4d9e2
Multisite: Replace is_super_admin()
with update_core
for update permissions.
...
Fixes #39060 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39540
git-svn-id: http://core.svn.wordpress.org/trunk@39480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 22:14:42 +00:00
Felix Arntz
72380176dc
Multisite: Remove redundant is_super_admin()
when checking for edit_others_posts
.
...
The super admin on multisite as well as the administrator on non-multisite both have this capability already. For custom post types using different capabilities this change ensures that only users with that capability have permissions.
Fixes #39059 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39539
git-svn-id: http://core.svn.wordpress.org/trunk@39479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 22:09:42 +00:00
Andrea Fercia
57c2604200
Accessibility: Remove inappropriate content from the Edit User screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39538
git-svn-id: http://core.svn.wordpress.org/trunk@39478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 22:08:43 +00:00
Andrea Fercia
2c227839d4
Accessibility: Remove inappropriate content from the Link Manager screens headings.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39537
git-svn-id: http://core.svn.wordpress.org/trunk@39477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 20:18:46 +00:00
Andrea Fercia
64f63499f8
Accessibility: Remove inappropriate content from the Add Plugins screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39536
git-svn-id: http://core.svn.wordpress.org/trunk@39476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 19:06:41 +00:00
Andrea Fercia
993f895c29
Accessibility: Remove inappropriate content from the Plugins screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39535
git-svn-id: http://core.svn.wordpress.org/trunk@39475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 18:48:40 +00:00
Andrea Fercia
87882d0463
Accessibility: Remove inappropriate content from the Users screen heading.
...
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39534
git-svn-id: http://core.svn.wordpress.org/trunk@39474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 18:29:38 +00:00
Andrea Fercia
710b4431dd
Toolbar: remove some unnecessary CSS lines.
...
They were commented out in `admin-bar.css` since 3 years, see [26770].
Props kafleg, ketuchetan.
Fixes #39137 .
Built from https://develop.svn.wordpress.org/trunk@39533
git-svn-id: http://core.svn.wordpress.org/trunk@39473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 17:45:45 +00:00
Boone Gorges
f882fc1295
Comments: Clean up unused code after [38446].
...
When the direct SQL query was removed in [38446], part of the SQL
concatenation was not removed. This changeset fixes that.
Props david.binda.
Fixes #39142 .
Built from https://develop.svn.wordpress.org/trunk@39532
git-svn-id: http://core.svn.wordpress.org/trunk@39472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 15:52:44 +00:00
John Blackbourn
16371b99d8
Users: Style the super admin message on the user editing screen as a notice, not a success message.
...
Fixes #39131
Built from https://develop.svn.wordpress.org/trunk@39531
git-svn-id: http://core.svn.wordpress.org/trunk@39471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 01:28:40 +00:00
John Blackbourn
042d09001a
Taxonomy: Correct the type for the first parameter of the the_category
filter.
...
See #39130
Built from https://develop.svn.wordpress.org/trunk@39530
git-svn-id: http://core.svn.wordpress.org/trunk@39470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 01:23:42 +00:00
Andrea Fercia
23ac0d0616
Accessibility: Improve keyboard accessibility avoiding confusing tab stops in the Media views.
...
When sections of the media modal are hidden out of view, their controls may be
still focusable and actionable. This completely hides these sections to avoid
unnecessary tab stops and potential confusion for assistive technology users.
Props SergeyBiryukov, afercia.
Fixes #30599 .
Built from https://develop.svn.wordpress.org/trunk@39529
git-svn-id: http://core.svn.wordpress.org/trunk@39469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 23:28:41 +00:00
Andrea Fercia
a9600d1a53
Accessibility: Remove inappropriate content from the Themes screen heading.
...
Props joedolson.
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39528
git-svn-id: http://core.svn.wordpress.org/trunk@39468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 23:12:41 +00:00
Andrea Fercia
c1f59f9fe3
Accessibility: Remove inappropriate content from the Add Themes screen heading.
...
Props joedolson.
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39527
git-svn-id: http://core.svn.wordpress.org/trunk@39467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 22:24:41 +00:00
Andrea Fercia
26ef4bd86d
Accessibility: Remove inappropriate content from the Media Library screens headings.
...
Props joedolson.
See #26601 .
Built from https://develop.svn.wordpress.org/trunk@39526
git-svn-id: http://core.svn.wordpress.org/trunk@39466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 22:18:42 +00:00
Helen Hou-Sandí
ab3bca05c8
About page: Update video and REST API reference URLs.
...
props ocean90, kadamwhite, coffee2code.
see #38616 .
Built from https://develop.svn.wordpress.org/trunk@39522
git-svn-id: http://core.svn.wordpress.org/trunk@39462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 18:24:41 +00:00
Helen Hou-Sandí
9c023fc883
Remove 4.7 cruft from $_old_files
.
...
see #39113 .
Built from https://develop.svn.wordpress.org/trunk@39520
git-svn-id: http://core.svn.wordpress.org/trunk@39460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 17:17:41 +00:00
Helen Hou-Sandí
3dea25bcd9
About page: Bump image versions because CDN caching.
...
props pento.
see #38616 .
Built from https://develop.svn.wordpress.org/trunk@39517
git-svn-id: http://core.svn.wordpress.org/trunk@39457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 07:13:41 +00:00
Joe McGill
da48e4ba1e
About page: Resposive images and CDN media URLs.
...
This adds `srcset` and `sizes` to the about page images, including
art direction, via `<picture>` for the lead Twenty Seventeen image.
This also replaces URLs for all images and feature videos to their
CDN locations on s.w.org.
Props helen, pento, joemcgill.
Fixes #38616 .
Built from https://develop.svn.wordpress.org/trunk@39514
git-svn-id: http://core.svn.wordpress.org/trunk@39454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 06:55:41 +00:00
Helen Hou-Sandí
f336d4c8ea
About page: Imagery and beautification.
...
Still to come: responsive images, optimized videos, and CDN URLs.
props melchoyce, helen, ramiabraham.
see #38616 .
Built from https://develop.svn.wordpress.org/trunk@39512
git-svn-id: http://core.svn.wordpress.org/trunk@39452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 04:01:45 +00:00
Weston Ruter
672b8a61cd
Customize: Prevent infinite full refresh from occurring when selective refresh falls back for a nav menu that has items excluded from rendering via filtering.
...
See #37032 .
Fixes #38612 .
Built from https://develop.svn.wordpress.org/trunk@39510
git-svn-id: http://core.svn.wordpress.org/trunk@39450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-06 02:51:42 +00:00
Dominik Schilling
a5dbd53a46
Comments: Merge a similar string between comments.php, XML-RPC and the REST API comments controller.
...
Props ramiy.
Fixes #39013 .
Built from https://develop.svn.wordpress.org/trunk@39508
git-svn-id: http://core.svn.wordpress.org/trunk@39448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-05 20:16:41 +00:00
Weston Ruter
3b37903106
Customize: Defer populating post_name
for auto-draft
posts in customized state until posts are published.
...
The ultimate `post_name` is stored in postmeta until the post is published. The `get_page_by_path()` function does not exclude `auto-draft` posts. Revert changes to `wp_unique_post_slug()` from [39411] which excluded `auto-draft` posts.
Props westonruter, dlh for testing, helen for testing.
See #38114 , #38928 .
Fixes #39078 .
Built from https://develop.svn.wordpress.org/trunk@39506
git-svn-id: http://core.svn.wordpress.org/trunk@39446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-05 19:33:42 +00:00
Weston Ruter
6a3de4d857
Customize: Ensure changeset_uuid
query param is removed from the customize.php
window's location once a changeset has been published (committed) with starter content.
...
Props westonruter, dlh for testing.
See #30937 .
Fixes #39081 .
Built from https://develop.svn.wordpress.org/trunk@39504
git-svn-id: http://core.svn.wordpress.org/trunk@39444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-05 16:56:42 +00:00
Weston Ruter
97f4180916
Customize: Prevent posts/pages imported via starter content from being dropped when adding post/page stubs via nav menus and the dropdown-pages control.
...
Props westonruter, dlh for testing.
See #38114 , #34923 .
Fixes #39071 .
Built from https://develop.svn.wordpress.org/trunk@39502
git-svn-id: http://core.svn.wordpress.org/trunk@39442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-05 16:47:41 +00:00
Weston Ruter
c9b8a5dbbb
Customize: Ensure textarea
for Custom CSS displays as code (in LTR) when an RTL language is active.
...
See #35395 .
Fixes #39085 .
Built from https://develop.svn.wordpress.org/trunk@39499
git-svn-id: http://core.svn.wordpress.org/trunk@39439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-05 13:55:42 +00:00
David A. Kennedy
f0b2b3f98f
Default Themes: Update version numbers and readme files for 4.7 release
...
Bump version numbers and update readme files for themes with changes. Also updates description for Twenty Seventeen and removes version number for HTML5 shiv for easier updates in the future.
Props davidakennedy.
Fixes #38858 .
Built from https://develop.svn.wordpress.org/trunk@39496
git-svn-id: http://core.svn.wordpress.org/trunk@39436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 23:27:41 +00:00
David A. Kennedy
6f5111d4e7
Twenty Seventeen: Fix CSS specificity problem with CSS feature query for object-fit
...
Previously, the theme's CSS feature query for `object-fit` overrode styles it shouldn't have on interior pages.
This moves the feature query farther down in the stylesheet so it takes precedence in the cascade in supported browsers, and applies the appropriate selector for the interior pages. In browsers that don't support feature queries or `object-fit`, the fallback styles are still applied. The problem was that the rules had the same specificity, so this way, the cascade takes over properly. The transforms and position changes for fallbacks are still needed in browsers that don't support `object-fit` and feature queries.
Props peterwilsoncc, davidakennedy.
Fixes #39073 .
Built from https://develop.svn.wordpress.org/trunk@39495
git-svn-id: http://core.svn.wordpress.org/trunk@39435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 23:12:42 +00:00
John Blackbourn
597627fb92
Role/Capability: Don't assign the delete_site
capability to anyone on single site installs.
...
This capability is not relevant on single site installs; it only applies to deleting a site on a multisite installation.
Fixes #38326
Built from https://develop.svn.wordpress.org/trunk@39494
git-svn-id: http://core.svn.wordpress.org/trunk@39434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 22:07:39 +00:00
Adam Silverstein
113833953d
Docs: Add inline documentation for image-edit.js
.
...
Adds JSDoc DocBlocks to the imageEdit methods.
Props: andizer, rensw90.
Fixes #38748 .
Built from https://develop.svn.wordpress.org/trunk@39493
git-svn-id: http://core.svn.wordpress.org/trunk@39433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 21:35:40 +00:00
Felix Arntz
e72d3d6b5d
Multisite: Replace is_super_admin()
with manage_network
for admin bar permissions.
...
Props iaaxpage.
Fixes #39064 . See #37616 .
Built from https://develop.svn.wordpress.org/trunk@39492
git-svn-id: http://core.svn.wordpress.org/trunk@39432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 21:21:42 +00:00
Rachel Baker
697f079a19
Comments: Merge similar strings between comments.php and the REST API comments controller.
...
Props ramiy.
Fixes #39014 .
Built from https://develop.svn.wordpress.org/trunk@39490
git-svn-id: http://core.svn.wordpress.org/trunk@39430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 20:32:40 +00:00
Rachel Baker
f3b71b49d0
REST API: Merge similar date strings in the revisions and comments controllers.
...
Props ramiy.
Fixes #39016 .
Built from https://develop.svn.wordpress.org/trunk@39488
git-svn-id: http://core.svn.wordpress.org/trunk@39428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 20:25:43 +00:00
James Nylen
87eedbd2f7
REST API: Treat any falsy value as false
in 'rest_allow_anonymous_comments'.
...
Extend the check in 'rest_allow_anonymous_comments' to accept any falsy value
(previously this was an explicit check for `false`).
One possible failure case is that a plugin developer forgets to include a
return value for some code path in their callback for this filter, leading to a
value of `null` which is currently treated like `true`.
Props joehoyle, jnylen0.
Fixes #39010 .
Built from https://develop.svn.wordpress.org/trunk@39487
git-svn-id: http://core.svn.wordpress.org/trunk@39427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 19:30:41 +00:00
John Blackbourn
5ffc6a7fe0
Users: Clarify the return value of get_current_user_id()
for non-logged-in users.
...
Props ovenall
Fixes #39051
Built from https://develop.svn.wordpress.org/trunk@39486
git-svn-id: http://core.svn.wordpress.org/trunk@39426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 19:25:16 +00:00
David A. Kennedy
94506367ac
Twenty Seventeen: Improve display of video header and header image in modern browsers
...
The theme uses a hack to help the video header and header image fill the available space. This centers around `max-width: 1000%;`. It causes visual issues (zooming of the header video or image) for all users though.
This fixes that with CSS Features Queries. The hack remains for browsers that don't support Feature Queries and `object-fit`. Browsers that do support both get a better experience with a more reliable styling of the video and image header container.
Props laurelfulford, peterwilsoncc.
Fixes #39035 .
Built from https://develop.svn.wordpress.org/trunk@39483
git-svn-id: http://core.svn.wordpress.org/trunk@39423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 19:16:42 +00:00
David A. Kennedy
04da99389d
Twenty Seventeen: Add specific font stack for Thai language
...
Improves legability and design for users viewing the theme with Thai language.
Props imnok, netweb, melchoyce.
Fixes #38937 .
Built from https://develop.svn.wordpress.org/trunk@39482
git-svn-id: http://core.svn.wordpress.org/trunk@39422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 19:06:41 +00:00
John Blackbourn
89ef3af655
Build/Test Tools: Correctly set up the current screen during list table tests so that they don't fail when run individually.
...
Props desrosj
Fixes #38761
Built from https://develop.svn.wordpress.org/trunk@39481
git-svn-id: http://core.svn.wordpress.org/trunk@39421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 19:04:43 +00:00
Andrew Nacin
0d983eb0ef
Build/Test Tools: Specify exact node version in package.json.
...
Enforce it in the tests.
see #35105 .
Built from https://develop.svn.wordpress.org/trunk@39478
git-svn-id: http://core.svn.wordpress.org/trunk@39418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 17:32:16 +00:00
Weston Ruter
0a31089bf6
Customize: Ensure a custom_css
post insertion gets an initial post revision.
...
Props georgestephanis, westonruter.
See #30854 , #38672 , #35395 .
Fixes #39032 .
Built from https://develop.svn.wordpress.org/trunk@39477
git-svn-id: http://core.svn.wordpress.org/trunk@39417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 17:31:33 +00:00
Helen Hou-Sandí
27475953bc
Docs: Update an @since
as there will not be a 4.6.2 before 4.7.
...
props boonebgorges.
fixes #37291 . see [38776].
Built from https://develop.svn.wordpress.org/trunk@39475
git-svn-id: http://core.svn.wordpress.org/trunk@39415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-04 17:10:43 +00:00
Andrew Nacin
440838095b
REST API: Register the admin_email setting in single site only.
...
See [39470]. This time including unit test changes.
fixes #38990 .
Built from https://develop.svn.wordpress.org/trunk@39471
git-svn-id: http://core.svn.wordpress.org/trunk@39411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 05:41:41 +00:00
Andrew Nacin
cafb341db6
REST API: Register the admin_email setting in single site only.
...
fixes #38990 .
Built from https://develop.svn.wordpress.org/trunk@39470
git-svn-id: http://core.svn.wordpress.org/trunk@39410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 05:39:42 +00:00
Gary Pendergast
d7e0ae883c
REST API: Site URL setting should not be present on multisite installations.
...
The `siteurl` setting is registered and made available to the REST API. On a multisite installation, this setting is not configurable from the General Settings screen, but due to the above it is configurable from the REST API.
Props peterwilsoncc.
Fixes #39005 .
Built from https://develop.svn.wordpress.org/trunk@39468
git-svn-id: http://core.svn.wordpress.org/trunk@39408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 05:16:44 +00:00
Helen Hou-Sandí
a5e9954f1d
Custom CSS: Change the help link to something better for users.
...
fixes #39015 .
Built from https://develop.svn.wordpress.org/trunk@39466
git-svn-id: http://core.svn.wordpress.org/trunk@39406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 05:11:42 +00:00
Gary Pendergast
cc214a219b
REST API: Capability check for editing a single term should use the singular form.
...
As an extra level of sanity checking, the term ID should be cast as an int in `map_meta_cap()`.
Props johnbillion, nacin, dd32, pento.
See #35614 .
Fixes #39012 .
Built from https://develop.svn.wordpress.org/trunk@39464
git-svn-id: http://core.svn.wordpress.org/trunk@39404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 05:08:41 +00:00
Gary Pendergast
947888d243
Docs: Add missing REST API-related args to register_post_type()
and register_taxonomy()
.
...
These functions now accept the `show_in_rest`, `rest_base`, and `rest_controller_class` args.
Props ketuchetan, rahulsprajapati.
Fixes #39023 .
Built from https://develop.svn.wordpress.org/trunk@39462
git-svn-id: http://core.svn.wordpress.org/trunk@39402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 04:48:42 +00:00
Gary Pendergast
f2a4d010cd
REST API: Use the correct error message when editing a single term.
...
Props ramiy, johnbillion.
Fixes #39017 .
Built from https://develop.svn.wordpress.org/trunk@39460
git-svn-id: http://core.svn.wordpress.org/trunk@39400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 04:42:41 +00:00
Gary Pendergast
e8042cfef7
REST API: Merge similar strings in a comments endpoint parameter description.
...
Props ramiy.
Fixes #39036 .
Built from https://develop.svn.wordpress.org/trunk@39457
git-svn-id: http://core.svn.wordpress.org/trunk@39397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 04:21:39 +00:00
Gary Pendergast
605e2f404a
Load: No-op locale.php
...
After re-adding `locale.php` in [39455], remove the content of the file so that it can't cause errors in the event of something loading it early in the WordPress load process.
See #39027 .
Built from https://develop.svn.wordpress.org/trunk@39456
git-svn-id: http://core.svn.wordpress.org/trunk@39396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 04:16:38 +00:00
Gary Pendergast
623ba7e8c9
Load: Re-add locale.php
.
...
`locale.php` is occasionally included directly by custom external code, so should continue to be available. This behaviour is deprecated.
Partial revert of [38364].
See #37827 , #39027 .
Built from https://develop.svn.wordpress.org/trunk@39455
git-svn-id: http://core.svn.wordpress.org/trunk@39395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 04:07:40 +00:00
Gary Pendergast
3487c1bda8
Load: Re-add session.php
.
...
`session.php` is occasionally included directly by custom external code, so should continue to be available. This behaviour is deprecated.
Partial revert of [38373].
See #36335 , #39027 .
Built from https://develop.svn.wordpress.org/trunk@39453
git-svn-id: http://core.svn.wordpress.org/trunk@39393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 03:51:41 +00:00
Helen Hou-Sandí
f048b66f95
Twenty Seventeen: Improve ARIA for the nav menu.
...
The `onResizeARIA()` function was not very useful and buggy.
props afercia.
fixes #39029 , #39026 .
Built from https://develop.svn.wordpress.org/trunk@39451
git-svn-id: http://core.svn.wordpress.org/trunk@39391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 03:41:41 +00:00
Gary Pendergast
a7ca4b8dde
Load: Re-add class-wp-upgrader-skins.php
.
...
`class-wp-upgrader-skins.php` is occasionally included directly by custom external code, so should continue to be available. This is deprecated in favour of including `class-wp-upgrader.php`, instead.
Revert of [38379].
See #36335 , #39027 .
Built from https://develop.svn.wordpress.org/trunk@39450
git-svn-id: http://core.svn.wordpress.org/trunk@39390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 03:40:41 +00:00
Gary Pendergast
6f1d48cdf3
Load: Re-add class-feed.php
.
...
`class-feed.php` is occasionally included directly by custom external code, so should continue to be available. This is deprecated in favour of calling `fetch_feed()`, however..
Partial revert of [38374].
See #36335 , #39027 .
Built from https://develop.svn.wordpress.org/trunk@39449
git-svn-id: http://core.svn.wordpress.org/trunk@39389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-03 03:30:42 +00:00