Jeremy Felt
1071cbe866
Tests: Use a data provider to test multisite's bootstrap
...
This also helps to get things in order before the introduction of a more testable multisite bootstrap function in #34941 .
A `@todo` has been temporarily removed, to be re-introduced as a working test.
See #36566 .
Built from https://develop.svn.wordpress.org/trunk@37238
git-svn-id: http://core.svn.wordpress.org/trunk@37204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 03:19:26 +00:00
Jeremy Felt
dfd4b974ed
Tests: Use a data provider in get_site_by_path()
tests
...
See #36566 , #34941 .
Built from https://develop.svn.wordpress.org/trunk@37237
git-svn-id: http://core.svn.wordpress.org/trunk@37203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 02:39:27 +00:00
Jeremy Felt
d15e28a173
Tests: Use a data provider to test get_network_by_path()
...
See #36566 , #34941 .
Built from https://develop.svn.wordpress.org/trunk@37236
git-svn-id: http://core.svn.wordpress.org/trunk@37202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 02:01:28 +00:00
Sergey Biryukov
2032e527b3
Docs: Clarify that is_tax()
and WP_Query::is_tax()
return false for built-in taxonomies (category and tag archives).
...
Props theMikeD.
Fixes #36331 .
Built from https://develop.svn.wordpress.org/trunk@37235
git-svn-id: http://core.svn.wordpress.org/trunk@37201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 01:44:26 +00:00
Jeremy Felt
22252115e4
Tests: Share test fixtures in multisite bootstrap tests
...
* Remove unnecessary `setUp` and `tearDown` methods.
* Create networks and sites in `wpSetupBeforeClass` to share throughout.
* Destroy networks and sites in `wpTearDownAfterClass` to unpollute.
See #36566 , #34941 .
Built from https://develop.svn.wordpress.org/trunk@37234
git-svn-id: http://core.svn.wordpress.org/trunk@37200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 01:38:27 +00:00
Jeremy Felt
6040109de6
Tests: Improve get_blog_count()
tests
...
* Use `wp_update_network_counts()` to update the database with the most current data before testing.
* Use `wp_update_network_counts()` to update the database with the most current data after deleting the sites created during the test.
* Create only 1 extra site in each test rather than 4. This shaves several seconds off the test time.
* Stop testing for an extra count now that we update the network counts properly. Previously we looked at `$site_count_start + 9` rather than 8. Now this is `+ 1`, which aligns with the actual number of sites created.
* Test 3 explicit conditions - default, filter applied as `true`, and filter applied as `false`.
* Reset data before testing assertion to avoid a suspended state.
See #36566 .
Built from https://develop.svn.wordpress.org/trunk@37233
git-svn-id: http://core.svn.wordpress.org/trunk@37199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 01:29:26 +00:00
Sergey Biryukov
f79aad8e0c
Theme Editor: After [37217], add other embed templates to file descriptions.
...
Props Frozzare.
Fixes #34561 . See #34561 .
Built from https://develop.svn.wordpress.org/trunk@37232
git-svn-id: http://core.svn.wordpress.org/trunk@37198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-18 01:05:27 +00:00
Andrea Fercia
26148850c5
Accessibility: change the close "X" in the Media "Attach to existing content" modal in a button.
...
Props joedolson.
Fixes #36554 .
Built from https://develop.svn.wordpress.org/trunk@37231
git-svn-id: http://core.svn.wordpress.org/trunk@37197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 16:58:26 +00:00
Andrea Fercia
e38ab38b1f
Accessibility: Customizer, improve UI controls in customize.php
...
- makes the mobile preview/customize toggle a button
- changes the "Close" link hidden text from 'Cancel' to 'Close the Customizer and go back to the previous page'
- adds a missing `type="button"` attribute
- removes unnecessary `keydown` events and `preventDefault()`: buttons don't need a keydown event and when they have a `type="button"` attribute there's no default action to prevent
Props Cheffheid, afercia.
Fixes #31487 .
Built from https://develop.svn.wordpress.org/trunk@37230
git-svn-id: http://core.svn.wordpress.org/trunk@37196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 15:41:27 +00:00
Andrea Fercia
85cac9d47e
Customizer, Site Icon preview: improve alt attributes and text accessibility.
...
Props shahpranaf, TacoVerdo, afercia.
Fixes #36562 .
Built from https://develop.svn.wordpress.org/trunk@37229
git-svn-id: http://core.svn.wordpress.org/trunk@37195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 12:01:27 +00:00
Pascal Birchler
5cbdf22c0f
TinyMCE, inline link: Fix VoiceOver in Safari for search suggestions.
...
Props afercia.
Fixes #36458 .
Built from https://develop.svn.wordpress.org/trunk@37228
git-svn-id: http://core.svn.wordpress.org/trunk@37194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 11:09:28 +00:00
Pascal Birchler
026ed07458
Admin: Fix default avatar handling in Settings -> Discussion.
...
By passing the `force_default` argument to `get_avatar()` instead of using `preg_replace`, we make it easier for developers to override the output.
Props henry.wright.
Fixes #34744 .
Built from https://develop.svn.wordpress.org/trunk@37227
git-svn-id: http://core.svn.wordpress.org/trunk@37193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 10:19:28 +00:00
Jeremy Felt
698ca25fb9
Multisite: Make $current_site
and $current_blog
explicitly global.
...
See #34941 .
Built from https://develop.svn.wordpress.org/trunk@37226
git-svn-id: http://core.svn.wordpress.org/trunk@37192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 05:12:26 +00:00
Boone Gorges
54cf1d2c3d
Query: Allow results to be ordered by post_parent__in
.
...
Props postpostmodern.
Fixes #36515 .
Built from https://develop.svn.wordpress.org/trunk@37225
git-svn-id: http://core.svn.wordpress.org/trunk@37191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 03:17:27 +00:00
Boone Gorges
0e2978a5cd
Tests: Improvements to /post/query test class.
...
* Add `@group` annotation.
* Remove unnecessary `setUp()` method.
Built from https://develop.svn.wordpress.org/trunk@37224
git-svn-id: http://core.svn.wordpress.org/trunk@37190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 03:13:27 +00:00
Jeremy Felt
f6620f7b7f
Options: Do not set network options to autoload in single site
...
When multisite is not configured, the `_site_transient()` and `_site_option()` functions fallback to `_option()` and store network "meta/options" in `wp_options`.
Previously, those calls to `_option()` did not explicitly set the `autoload` parameter and anything assigned as a transient or option at the network level would be set to `autoload` by default, even though autoload is not yet a concept at the network option level.
This changes that behavior and forces the `autoload` setting to `no`. If `autoload` is desired, the single site option functions should be used.
Props thomaswm.
Fixes #22846 .
Built from https://develop.svn.wordpress.org/trunk@37223
git-svn-id: http://core.svn.wordpress.org/trunk@37189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 19:48:27 +00:00
Jeremy Felt
2cc9b6b410
Tests: Run network option tests as single and multisite
...
The `_network_option()` functions are available to all and
internally use `_option()` functions as a fallback. We should
be testing for that scenario as well.
Fixes #36552 .
Built from https://develop.svn.wordpress.org/trunk@37222
git-svn-id: http://core.svn.wordpress.org/trunk@37188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 19:22:27 +00:00
Andrea Fercia
76a6260353
Plugin Install: show the upload form in place rather than sending users to the devoted upload plugin page.
...
Props Ipstenu, ericlewis, michaelarestad.
Fixes #35429 .
Built from https://develop.svn.wordpress.org/trunk@37221
git-svn-id: http://core.svn.wordpress.org/trunk@37187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 16:43:27 +00:00
Boone Gorges
374a489166
In sanitize_post_field()
, only run 'attribute' or 'js' escaping when necessary.
...
Props tfrommen.
Fixes #34900 .
Built from https://develop.svn.wordpress.org/trunk@37220
git-svn-id: http://core.svn.wordpress.org/trunk@37186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 14:51:28 +00:00
Sergey Biryukov
784a00d49c
Themes: Account for longer strings in Theme Details bar on Themes screen.
...
Fixes #27939 .
Built from https://develop.svn.wordpress.org/trunk@37219
git-svn-id: http://core.svn.wordpress.org/trunk@37185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 13:59:26 +00:00
Sergey Biryukov
4109e8b9f8
Plugins: Properly wrap long tab names to a second line in plugin details modal.
...
Fixes #33221 .
Built from https://develop.svn.wordpress.org/trunk@37218
git-svn-id: http://core.svn.wordpress.org/trunk@37184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 13:18:27 +00:00
Sergey Biryukov
f760d05a63
Theme Editor: Add embed.php
to file descriptions.
...
Props ramiy.
Fixes #36551 .
Built from https://develop.svn.wordpress.org/trunk@37217
git-svn-id: http://core.svn.wordpress.org/trunk@37183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 12:47:27 +00:00
Sergey Biryukov
fc9d56c13f
Docs: Fix typo in wp_cache_switch_to_blog()
and WP_Object_Cache::switch_to_blog()
description.
...
Props bobbingwide.
Fixes #36548 .
Built from https://develop.svn.wordpress.org/trunk@37216
git-svn-id: http://core.svn.wordpress.org/trunk@37182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-16 12:37:30 +00:00
Rachel Baker
a0eab11bc1
Comments: Add parameters to edit_comment_link()
to allow specifying a Comment and link class.
...
Matches the parameters for `edit_post_link()`.
Fixes #36538 .
Props flixos90.
Built from https://develop.svn.wordpress.org/trunk@37215
git-svn-id: http://core.svn.wordpress.org/trunk@37181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 20:59:29 +00:00
Sergey Biryukov
7c2ad56158
Docs: Correct description for override_load_textdomain
and override_unload_textdomain
filters.
...
Props dimadin.
Fixes #36537 .
Built from https://develop.svn.wordpress.org/trunk@37214
git-svn-id: http://core.svn.wordpress.org/trunk@37180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 17:19:28 +00:00
Drew Jaynes
994bfb5b26
Docs: Use third-person singular verbs in DocBlock and hook doc summaries in wp-includes/link-template.php.
...
See #30406 .
Built from https://develop.svn.wordpress.org/trunk@37213
git-svn-id: http://core.svn.wordpress.org/trunk@37179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 16:58:27 +00:00
Aaron Jorbin
262f3f2f7e
Update grunt-contrib-uglify from ~0.10.0 to ~1.0.1
...
This changes every JS file in WordPress, so we need to test everything.
Props netweb.
See #36520 .
Built from https://develop.svn.wordpress.org/trunk@37212
git-svn-id: http://core.svn.wordpress.org/trunk@37178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 16:10:37 +00:00
Ella Iseulde Van Dorpe
016562a9b3
Build/Test Tools: Run image tasks only if there are changes
...
See #36528 .
Built from https://develop.svn.wordpress.org/trunk@37211
git-svn-id: http://core.svn.wordpress.org/trunk@37177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 10:19:28 +00:00
John Blackbourn
17be663ad0
Add noindexing to the default wp_die()
handler to avoid unnecessary crawl errors in web search engines.
...
Fixes #34401
Props rodrigosprimo
Built from https://develop.svn.wordpress.org/trunk@37210
git-svn-id: http://core.svn.wordpress.org/trunk@37176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 02:05:27 +00:00
John Blackbourn
56cc4bc79c
Docs: Clarify possible types passed to the themes_api_result
filter.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@37209
git-svn-id: http://core.svn.wordpress.org/trunk@37175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-15 01:43:28 +00:00
Sergey Biryukov
8e498b933d
Comments: Allow for default comment form action, /wp-comments-post.php
, to be changed via the comment_form_defaults
filter.
...
Props cliffseal.
Fixes #26841 .
Built from https://develop.svn.wordpress.org/trunk@37208
git-svn-id: http://core.svn.wordpress.org/trunk@37174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 18:18:29 +00:00
Sergey Biryukov
4074bcc6a1
Bootstrap/Load: Allow for ABSPATH
to be defined outside of wp-load.php
, e.g. in a script loaded via auto_prepend_file
.
...
Props barry.
Fixes #26592 .
Built from https://develop.svn.wordpress.org/trunk@37207
git-svn-id: http://core.svn.wordpress.org/trunk@37173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 17:53:28 +00:00
Sergey Biryukov
acf69202a1
Build Tools: Don't run the build
task twice in grunt prerelease
(it already runs via the precommit:js
task).
...
Props netweb.
Fixes #36489 .
Built from https://develop.svn.wordpress.org/trunk@37206
git-svn-id: http://core.svn.wordpress.org/trunk@37172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 15:39:28 +00:00
Konstantin Obenland
5e22b71909
Themes: Fix single theme modal on collapsed menu.
...
Prevents the modal from being displayed off screen, when there is only one
theme available and the menu is collapsed.
Props hardeepasrani for initial patch.
Fixes #36504 .
Built from https://develop.svn.wordpress.org/trunk@37205
git-svn-id: http://core.svn.wordpress.org/trunk@37171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 12:20:29 +00:00
Jeremy Felt
8d5c62b923
Multisite: Fire a clean_site_cache
action when a site's cache is cleared
...
Props spacedmonkey.
Fixes #36203 .
Built from https://develop.svn.wordpress.org/trunk@37204
git-svn-id: http://core.svn.wordpress.org/trunk@37170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 04:19:27 +00:00
Jeremy Felt
f74e50d1dd
Multisite: Remove theme from network allowed themes when deleted
...
Previously, a deleted theme would remain in the list of allowed themes until manually cleared. This uses `WP_Theme::network_disable_theme()`, added in [37202].
Fixes #34182 .
Built from https://develop.svn.wordpress.org/trunk@37203
git-svn-id: http://core.svn.wordpress.org/trunk@37169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 03:49:26 +00:00
Jeremy Felt
6279ca91de
Multisite: Introduce WP_Theme
methods to network enable/disable themes.
...
* `WP_Theme::network_enable_theme()` can be used to enable a theme or array of themes on a network.
* `WP_Theme::network_disable_theme()` can be used to disable a theme or array of themes on a network.
* Use these new methods in the network admin vs direct `update_site_option()` calls.
* Add tests.
Props igmoweb.
Fixes #30594 .
Built from https://develop.svn.wordpress.org/trunk@37202
git-svn-id: http://core.svn.wordpress.org/trunk@37168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 03:40:27 +00:00
Sergey Biryukov
499763f725
I18N: Add translator comment for a string with a placeholder added in [36806].
...
Keep the comment for the string above too, for additional clarity.
Props christophherr.
Fixes #36493 .
Built from https://develop.svn.wordpress.org/trunk@37201
git-svn-id: http://core.svn.wordpress.org/trunk@37167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 03:39:27 +00:00
Jeremy Felt
6cc19b5e2e
Multisite: Relocate revoke_super_admin()
and grant_super_admin()
...
Moving these functions to `wp-includes/capabilities.php` allows plugins to access more than just `is_super_admin()` and `get_super_admin()` from the front end without including a file via `wp-admin/`. Add an `is_multisite()` check to prevent use of these on single site environments now that they have left `ms.php`..
Props johnjamesjacoby.
Fixes #21788 .
Built from https://develop.svn.wordpress.org/trunk@37200
git-svn-id: http://core.svn.wordpress.org/trunk@37166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 03:35:27 +00:00
Sergey Biryukov
efee62a316
Docs: Reference the correct variable in WP_Ajax_UnitTestCase::_handleAjax()
documentation.
...
Props meitar.
Fixes #36522 .
Built from https://develop.svn.wordpress.org/trunk@37199
git-svn-id: http://core.svn.wordpress.org/trunk@37165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 02:29:26 +00:00
Sergey Biryukov
6e54900924
I18N: Remove <kbd>
tags from translatable string in wp-admin/options-writing.php
.
...
Add translator comment.
Props ramiy.
Fixes #36249 .
Built from https://develop.svn.wordpress.org/trunk@37198
git-svn-id: http://core.svn.wordpress.org/trunk@37164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 02:25:26 +00:00
Sergey Biryukov
77e2737d89
Customizer: Remove the 'appearance' reference from permission error messages added in [33857], [33889], and [33902].
...
Props Frozzare.
Fixes #36466 .
Built from https://develop.svn.wordpress.org/trunk@37197
git-svn-id: http://core.svn.wordpress.org/trunk@37163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-14 01:58:28 +00:00
Boone Gorges
1e82651504
Pass thumbnail ID to the admin_post_thumbnail_html
filter.
...
Also updates changelog to reflect that `$post->ID` was added in 3.5
Props johnjamesjacoby.
Fixes #36443 .
Built from https://develop.svn.wordpress.org/trunk@37196
git-svn-id: http://core.svn.wordpress.org/trunk@37162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 16:18:28 +00:00
Sergey Biryukov
c55e4194f8
Docs: Fix typo in a comment in wp-admin/js/postbox.js
.
...
Props yoavf.
Fixes #36349 .
Built from https://develop.svn.wordpress.org/trunk@37195
git-svn-id: http://core.svn.wordpress.org/trunk@37161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 07:29:27 +00:00
Sergey Biryukov
e081720b67
Docs: Fix typo in get_image_send_to_editor()
description.
...
Props yoavf.
See #36349 .
Built from https://develop.svn.wordpress.org/trunk@37194
git-svn-id: http://core.svn.wordpress.org/trunk@37160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 07:28:28 +00:00
Sergey Biryukov
21bdbc204e
Docs: Fix typo in wp_update_theme()
description.
...
Props yoavf.
See #36349 .
Built from https://develop.svn.wordpress.org/trunk@37193
git-svn-id: http://core.svn.wordpress.org/trunk@37159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 07:27:28 +00:00
Mike Schroder
5102c98ab6
Media: Resolve fatal error on resize with ImageMagick < 6.4.6
...
Improper checking for 'Imagick::ALPHACHANNEL_UNDEFINED' and
'Imagick::ALPHACHANNEL_OPAQUE' caused fatal errors for some users
with Imagick when compiled against ImageMagick < 6.4.6, when these
constants were introduced. Fixes these compatibility checks.
Props gblsm.
Fixes #36501 .
Built from https://develop.svn.wordpress.org/trunk@37192
git-svn-id: http://core.svn.wordpress.org/trunk@37158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 06:18:28 +00:00
Sergey Biryukov
9dcfd91833
I18N: Update translator comments after [37190].
...
See #36496 .
Built from https://develop.svn.wordpress.org/trunk@37191
git-svn-id: http://core.svn.wordpress.org/trunk@37157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 04:30:29 +00:00
Sergey Biryukov
5e31cb45fe
I18N: After [37188], display script
and style
tags in the message as <script>
and <style>
.
...
Props dd32.
See #36496 .
Built from https://develop.svn.wordpress.org/trunk@37190
git-svn-id: http://core.svn.wordpress.org/trunk@37156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 04:16:27 +00:00
Boone Gorges
0b772e928c
Improve testability and coverage of wp_ext2type()
.
...
* Following pattern of `wp_get_mime_types()`, introduce `wp_get_ext_types()` function. New function returns a filtered list of file types with their extensions.
* Use this function in new tests for `wp_ext2type()`.
Props borgesbruno.
Fixes #35987 .
Built from https://develop.svn.wordpress.org/trunk@37189
git-svn-id: http://core.svn.wordpress.org/trunk@37155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-13 03:12:27 +00:00