Commit Graph

14615 Commits

Author SHA1 Message Date
Boone Gorges
cc5eddda74 Allow wp_terms_checklist() to return markup rather than echoing it.
Props kevinlangleyjr.
Fixes #33720.
Built from https://develop.svn.wordpress.org/trunk@33904


git-svn-id: http://core.svn.wordpress.org/trunk@33873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 21:25:25 +00:00
Sergey Biryukov
f0ce1f06ea Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/js/customize-controls.js.
fixes #33685. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33902


git-svn-id: http://core.svn.wordpress.org/trunk@33871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-04 03:40:25 +00:00
Scott Taylor
80a20e5c3d Handle more cases (untrailingslashit, HTTPS urls) for sanitizing an author URL for display in the comments list table.
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.

Built from https://develop.svn.wordpress.org/trunk@33894


git-svn-id: http://core.svn.wordpress.org/trunk@33863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 23:23:24 +00:00
Scott Taylor
e73ee5ac98 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:17:24 +00:00
Helen Hou-Sandí
89de754f0e UI: Restrict textarea resizing to vertical to prevent ugliness.
props tyxla, MatheusFD.
fixes #33400.

Built from https://develop.svn.wordpress.org/trunk@33890


git-svn-id: http://core.svn.wordpress.org/trunk@33859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:05:25 +00:00
Sergey Biryukov
bc8af88903 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/network/site-users.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33888


git-svn-id: http://core.svn.wordpress.org/trunk@33857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 09:03:24 +00:00
Sergey Biryukov
771b29455b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/includes/bookmark.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33887


git-svn-id: http://core.svn.wordpress.org/trunk@33856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:59:24 +00:00
Sergey Biryukov
c4ce11422c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/widgets.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33886


git-svn-id: http://core.svn.wordpress.org/trunk@33855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:56:24 +00:00
Sergey Biryukov
ce05b02a59 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/users.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33885


git-svn-id: http://core.svn.wordpress.org/trunk@33854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:54:24 +00:00
Sergey Biryukov
b4fbbf53cf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/user-new.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33884


git-svn-id: http://core.svn.wordpress.org/trunk@33853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:46:52 +00:00
Scott Taylor
3cad9d8385 After [33723], ensure that $i is properly set before looping.
See #16865.

Built from https://develop.svn.wordpress.org/trunk@33867


git-svn-id: http://core.svn.wordpress.org/trunk@33835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:48:22 +00:00
Sergey Biryukov
bc0a1e1c4b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/themes.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33866


git-svn-id: http://core.svn.wordpress.org/trunk@33834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:45:21 +00:00
Sergey Biryukov
3e0929740e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/press-this.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33865


git-svn-id: http://core.svn.wordpress.org/trunk@33833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:38:21 +00:00
Sergey Biryukov
d5ac2bc41e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/post-new.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33864


git-svn-id: http://core.svn.wordpress.org/trunk@33832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:36:22 +00:00
Sergey Biryukov
a880c5c576 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/options.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33863


git-svn-id: http://core.svn.wordpress.org/trunk@33831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:31:21 +00:00
Sergey Biryukov
5ceecc4eaf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/nav-menus.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33862


git-svn-id: http://core.svn.wordpress.org/trunk@33830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:21:21 +00:00
Sergey Biryukov
b136b074bf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33861


git-svn-id: http://core.svn.wordpress.org/trunk@33829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:15:20 +00:00
Sergey Biryukov
d2919e2d71 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit-comments.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33860


git-svn-id: http://core.svn.wordpress.org/trunk@33828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:04:21 +00:00
Sergey Biryukov
3d1c08a1a5 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/customize.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33857


git-svn-id: http://core.svn.wordpress.org/trunk@33825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 17:05:22 +00:00
Andrea Fercia
f35c176426 Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604].
Fixes #33633.
Built from https://develop.svn.wordpress.org/trunk@33856


git-svn-id: http://core.svn.wordpress.org/trunk@33824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:56:20 +00:00
Sergey Biryukov
cf69e6deb3 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33854


git-svn-id: http://core.svn.wordpress.org/trunk@33822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:29:21 +00:00
Sergey Biryukov
d95417a5e7 Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33853


git-svn-id: http://core.svn.wordpress.org/trunk@33821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:21:21 +00:00
Sergey Biryukov
c3b663ad8d Provide more helful feedback than just “Cheatin’ uh?” for permission errors in wp-admin/edit-tags.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33852


git-svn-id: http://core.svn.wordpress.org/trunk@33820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:06:21 +00:00
John Blackbourn
606b6d15f1 Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL.
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90

Built from https://develop.svn.wordpress.org/trunk@33849


git-svn-id: http://core.svn.wordpress.org/trunk@33817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 11:29:23 +00:00
Jeremy Felt
9666aec8d1 Multisite: Remove duplicate span element output from row actions
Fixes #32961.

Built from https://develop.svn.wordpress.org/trunk@33848


git-svn-id: http://core.svn.wordpress.org/trunk@33816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 21:51:21 +00:00
Sergey Biryukov
32b5726fd4 Merge two similar strings.
props pavelevap.
fixes #33643.
Built from https://develop.svn.wordpress.org/trunk@33842


git-svn-id: http://core.svn.wordpress.org/trunk@33810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 13:46:24 +00:00
Weston Ruter
1413f2edd5 Customizer: Collapse any expanded panel/sections before expanding other panel/sections
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33837


git-svn-id: http://core.svn.wordpress.org/trunk@33805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:42 +00:00
Andrew Ozz
e3f3f470ea Editor, Press This: force a page reload when the user publishes a post and then clicks the back button.
Fixes #23691.
Built from https://develop.svn.wordpress.org/trunk@33836


git-svn-id: http://core.svn.wordpress.org/trunk@33804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:22 +00:00
Sergey Biryukov
43194cea1c Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget.
props MikeHansenMe, DrewAPicture.
fixes #31434.
Built from https://develop.svn.wordpress.org/trunk@33833


git-svn-id: http://core.svn.wordpress.org/trunk@33801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:57:21 +00:00
Sergey Biryukov
a53d6b471f Add 'update_right_now_text' filter for the text displayed in the 'At a Glance' dashboard widget.
props obenland.
fixes #33355.
Built from https://develop.svn.wordpress.org/trunk@33832


git-svn-id: http://core.svn.wordpress.org/trunk@33800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:45:21 +00:00
Drew Jaynes
375d30f699 Docs: Add a duplicate filter comment to the comment_email filter call in WP_Comments_List_Table, introduced in [33829].
See #11566.

Built from https://develop.svn.wordpress.org/trunk@33830


git-svn-id: http://core.svn.wordpress.org/trunk@33798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:22:21 +00:00
Scott Taylor
a5b157ffde Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link(), the internals can be simplified and applied inline.
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33829


git-svn-id: http://core.svn.wordpress.org/trunk@33797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:09:21 +00:00
Scott Taylor
d0a1a47708 Fix warnings after [33826]. Only only one function call needs a global $comment, we shall hamburger it.
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33828


git-svn-id: http://core.svn.wordpress.org/trunk@33796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:59:21 +00:00
Scott Taylor
7ab015c5ab WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set.
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33826


git-svn-id: http://core.svn.wordpress.org/trunk@33794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:42:21 +00:00
Sergey Biryukov
8b1fe986c3 Use wp_html_excerpt() to properly cut comment author URL for display on Comments screen.
props brettz95, solarissmoke.
fixes #15659.
Built from https://develop.svn.wordpress.org/trunk@33825


git-svn-id: http://core.svn.wordpress.org/trunk@33793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:41:21 +00:00
Scott Taylor
7808d5d1fa Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
Fixes #33414. 

Built from https://develop.svn.wordpress.org/trunk@33821


git-svn-id: http://core.svn.wordpress.org/trunk@33789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 17:58:22 +00:00
Sergey Biryukov
5a97ff5206 Bump H3 headings to H2 on Themes screen for better accessibility.
props joehills.
fixes #33560.
Built from https://develop.svn.wordpress.org/trunk@33820


git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:51:21 +00:00
Sergey Biryukov
82a8cec3b3 Bump H3 headings to H2 on Tools screen for better accessibility.
props Cheffheid.
fixes #33607.
Built from https://develop.svn.wordpress.org/trunk@33819


git-svn-id: http://core.svn.wordpress.org/trunk@33787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:32:21 +00:00
Sergey Biryukov
48c82ef14d Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
props Cheffheid.
fixes #33611.
Built from https://develop.svn.wordpress.org/trunk@33818


git-svn-id: http://core.svn.wordpress.org/trunk@33786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:29:21 +00:00
Sergey Biryukov
fb3d54d569 Bump H3 headings to H2 on WordPress Updates screen for better accessibility.
props Cheffheid.
fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@33817


git-svn-id: http://core.svn.wordpress.org/trunk@33785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:26:24 +00:00
Scott Taylor
db11b48627 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table.
Props pavelevap.
Fixes #33515.

Built from https://develop.svn.wordpress.org/trunk@33810


git-svn-id: http://core.svn.wordpress.org/trunk@33778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:10:21 +00:00
Sergey Biryukov
50d4d4a956 Make a period translatable.
props mako09.
fixes #33594.
Built from https://develop.svn.wordpress.org/trunk@33802


git-svn-id: http://core.svn.wordpress.org/trunk@33770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 01:40:21 +00:00
John Blackbourn
6ee45a9606 Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens.
Fixes #32913

Built from https://develop.svn.wordpress.org/trunk@33801


git-svn-id: http://core.svn.wordpress.org/trunk@33769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-29 00:19:24 +00:00
Sergey Biryukov
d10fc64ab5 Network Admin: Hide the bulk actions checkbox for super admins.
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.
Built from https://develop.svn.wordpress.org/trunk@33777


git-svn-id: http://core.svn.wordpress.org/trunk@33745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 03:49:21 +00:00
Helen Hou-Sandí
1f500055a6 Drop the hyphen from e-mail and standardize on email.
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.

Built from https://develop.svn.wordpress.org/trunk@33774


git-svn-id: http://core.svn.wordpress.org/trunk@33742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 03:17:21 +00:00
John Blackbourn
6d7aeeac03 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post.
Fixes #32954
Props boonebgorges, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33773


git-svn-id: http://core.svn.wordpress.org/trunk@33741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 20:57:22 +00:00
Sergey Biryukov
4ae4d94dbb Remove wp-includes/comment-functions.php from the $_old_files array. See [33750].
props rachelbaker.
fixes #33569.
Built from https://develop.svn.wordpress.org/trunk@33772


git-svn-id: http://core.svn.wordpress.org/trunk@33740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 20:40:24 +00:00
John Blackbourn
b9ec4136d9 Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url().
Fixes #32847

Built from https://develop.svn.wordpress.org/trunk@33770


git-svn-id: http://core.svn.wordpress.org/trunk@33738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 17:26:21 +00:00
John Blackbourn
a60d143f7b Correct the hook docs for the user_profile_update_errors action.
Fixes #33537
Props yamchhetri

Built from https://develop.svn.wordpress.org/trunk@33769


git-svn-id: http://core.svn.wordpress.org/trunk@33737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 17:16:21 +00:00
Sergey Biryukov
be59078ef8 Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile.
props peterwilsoncc.
fixes #33419 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33766


git-svn-id: http://core.svn.wordpress.org/trunk@33734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 00:11:21 +00:00