Jeremy Felt
b8ffa8ecb9
Restrict textarea fields in network setup to a max width of 100%.
...
This avoids the content overrunning the screen on mobile devices.
See #32846 .
Built from https://develop.svn.wordpress.org/trunk@33171
git-svn-id: http://core.svn.wordpress.org/trunk@33143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 22:53:25 +00:00
Jeremy Felt
5a59c292e3
s/nestwork/network/ for network dashboard Right Now styles.
...
Fix misspelled ID from [33168]. A reminder to watch your cmd-s when saving a file.
See #32962 .
Built from https://develop.svn.wordpress.org/trunk@33169
git-svn-id: http://core.svn.wordpress.org/trunk@33141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 21:44:25 +00:00
Jeremy Felt
1cd06052ea
Improve formatting of network dashboard's Right Now actions on 320px screens.
...
Prevents default `.subsubsub` change to center alignment and a large font that is applied at 782px.
Fixes #32962 .
Built from https://develop.svn.wordpress.org/trunk@33168
git-svn-id: http://core.svn.wordpress.org/trunk@33140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 21:38:24 +00:00
Dominik Schilling
153511f78f
Password UI: The non-breaking space doesn't need to be translatable. Add some context to password strength strings.
...
see #32589 .
Built from https://develop.svn.wordpress.org/trunk@33166
git-svn-id: http://core.svn.wordpress.org/trunk@33138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 20:48:24 +00:00
Jeremy Felt
4f32f8e00e
Improve styling of .themes-php
header on mobile devices.
...
The Themes page title does not need to be forced to 100% width on smaller devices. This fixes width issues for network admin, site admin, and single site admin theme pages.
See #32846 .
Built from https://develop.svn.wordpress.org/trunk@33165
git-svn-id: http://core.svn.wordpress.org/trunk@33137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 20:07:25 +00:00
Jeremy Felt
8b31074880
Improve styling of #adduser
text inputs on mobile devices.
...
In [26134], `#createuser` inputs were made responsive, but `#adduser` was a straggler. This assigns the proper mobile style to the add user inputs and moves the initial declaration alongside create user for future maintenance ease.
See #32846 .
Built from https://develop.svn.wordpress.org/trunk@33162
git-svn-id: http://core.svn.wordpress.org/trunk@33134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 19:28:25 +00:00
Konstantin Obenland
0a64d94562
Nav menus: Restore menu id in hidden input.
...
`wp-admin/js/nav-menu.js` uses the value as context for quick searches and when
adding menu items.
Reverts [32695], see #31816 .
Fixes #32699 .
Built from https://develop.svn.wordpress.org/trunk@33161
git-svn-id: http://core.svn.wordpress.org/trunk@33133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 06:11:24 +00:00
Jeremy Felt
0dbe4d6c95
Set autocapitalize to none, autocorrect to off for new username inputs on iOS.
...
This corrects both the standard wp-admin new user form and the network new user form.
Props @brad2dabone, @sunnnyratilal.
Fixes #32644 .
Built from https://develop.svn.wordpress.org/trunk@33160
git-svn-id: http://core.svn.wordpress.org/trunk@33132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 02:35:24 +00:00
Andrew Ozz
b99d7d909c
Press This: make the font size in the Text editor similar to the Visual editor. Fix buttons padding.
...
Fixes #32706 .
Built from https://develop.svn.wordpress.org/trunk@33159
git-svn-id: http://core.svn.wordpress.org/trunk@33131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 22:37:24 +00:00
Dominik Schilling
0ca06cd643
Customizer: Force top margin to be zero for a new created nav menu to avoid extra spacing.
...
props valendesigns.
fixes #32662 .
Built from https://develop.svn.wordpress.org/trunk@33157
git-svn-id: http://core.svn.wordpress.org/trunk@33129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 22:18:24 +00:00
Andrew Ozz
9868325217
Press THis: do not change the split button box-shadow on hover.
...
Fixes #32757 .
Built from https://develop.svn.wordpress.org/trunk@33156
git-svn-id: http://core.svn.wordpress.org/trunk@33128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 22:10:25 +00:00
Helen Hou-Sandí
6e73f1282e
List tables: Better accessibility and design for the comments bubble.
...
It is now plain text in the comments list table's "In Response To" column, where it was visually a bit confusing to have the bubble. For other list tables, it now shows a little notification bubble with the number of pending comments. The bubble and notification become plain text in the responsive list table view. It also shows no bubble when there are no comments at all, reducing some of the visual noise.
props picard102, afercia, karinchristen.
fixes #32152 .
Built from https://develop.svn.wordpress.org/trunk@33155
git-svn-id: http://core.svn.wordpress.org/trunk@33127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:44:25 +00:00
Konstantin Obenland
f29e5044cd
Site Icon: Add Customizer UI.
...
Second part of the Site Icon feature after [32994] introduced it for Settings.
Props celloexpressions.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33154
git-svn-id: http://core.svn.wordpress.org/trunk@33126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:33:24 +00:00
Dominik Schilling
75d6c10b01
Customizer: Use a <button>
for the collapse sidebar … button.
...
props afercia.
fixes #32819 .
Built from https://develop.svn.wordpress.org/trunk@33153
git-svn-id: http://core.svn.wordpress.org/trunk@33125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:22:26 +00:00
Dominik Schilling
f0db1e0bb7
Customizer: Replace the plus icon for #available-menu-items .item-add
with a thinner one, see [33126].
...
fixes #32734 .
Built from https://develop.svn.wordpress.org/trunk@33152
git-svn-id: http://core.svn.wordpress.org/trunk@33124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 22:09:25 +00:00
Dominik Schilling
bff15bf681
Customizer: Improve markup for available menu items.
...
* Use lists for available menu items.
* Remove unused template for available item types.
* Hide the type label and title from screen readers and instead include them in the add button.
props celloexpressions, afercia.
fixes #32724 .
Built from https://develop.svn.wordpress.org/trunk@33151
git-svn-id: http://core.svn.wordpress.org/trunk@33123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 22:00:25 +00:00
Dominik Schilling
106b0675b9
Customizer: Use the new dashicon for the Preview/Customize toggle in narrow screens.
...
see #30902 , #28784 .
Built from https://develop.svn.wordpress.org/trunk@33150
git-svn-id: http://core.svn.wordpress.org/trunk@33122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 21:05:25 +00:00
Dominik Schilling
41a8b24a8f
List tables: Remove a black colored separator in Quick Edit for pages.
...
fixes #32842 .
Built from https://develop.svn.wordpress.org/trunk@33149
git-svn-id: http://core.svn.wordpress.org/trunk@33121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 20:57:24 +00:00
Helen Hou-Sandí
70a8c3e83d
List tables: Better focus styling for the row toggle.
...
This circular focus styling could probably be expanded to other areas of the admin.
props hugobaeta.
see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33146
git-svn-id: http://core.svn.wordpress.org/trunk@33118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 19:12:25 +00:00
Jeremy Felt
8431399e2e
Fix missing period in missing site error.
...
Props @ocean90.
See #32934 .
Built from https://develop.svn.wordpress.org/trunk@33145
git-svn-id: http://core.svn.wordpress.org/trunk@33116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:33:25 +00:00
Jeremy Felt
eb26a74073
Avoid PHP notice when attempting to edit a site that does not exist.
...
Show a more explicit error - "The requested site does not exist."
Fixes #32934 .
Built from https://develop.svn.wordpress.org/trunk@33144
git-svn-id: http://core.svn.wordpress.org/trunk@33115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:29:24 +00:00
Jeremy Felt
0bc0b0c917
Do not allow deletion of a super admin user through wpmu_delete_user()
.
...
In step with the UI provided by `wp-admin/network/users.php`, super admin privileges must be removed before a user can be deleted through the API.
Props @johnjamesjacoby, @jeremyfelt.
Fixes #32935 .
Built from https://develop.svn.wordpress.org/trunk@33143
git-svn-id: http://core.svn.wordpress.org/trunk@33114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-09 16:16:25 +00:00
Dominik Schilling
73d57e6c86
Add/Edit User: Move weak password label to the checkbox.
...
props paulwilde.
fixes #32908 .
Built from https://develop.svn.wordpress.org/trunk@33137
git-svn-id: http://core.svn.wordpress.org/trunk@33108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:28:25 +00:00
Dominik Schilling
5fff9d1ef7
Customizer: Use visibility
to hide available widgets and menu items panels from screen readers and to move them out of tab order.
...
props afercia.
fixes #32883 .
Built from https://develop.svn.wordpress.org/trunk@33136
git-svn-id: http://core.svn.wordpress.org/trunk@33107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:21:25 +00:00
Boone Gorges
e8c6340f67
Improvements to responsive styling on my-sites.php.
...
* Ensure that floated elements break to a new line at the end of a row.
* Allow enough vertical space for long site titles.
* Give more breathing room to cells at narrow widths.
Fixes #31685 .
Built from https://develop.svn.wordpress.org/trunk@33135
git-svn-id: http://core.svn.wordpress.org/trunk@33106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 21:02:24 +00:00
Dominik Schilling
28ecfd83c6
Updates: Select All should not be a column header.
...
See #31654 .
props tywayne.
fixes #32905 .
Built from https://develop.svn.wordpress.org/trunk@33133
git-svn-id: http://core.svn.wordpress.org/trunk@33104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:38:25 +00:00
Helen Hou-Sandí
54428b546e
Spinners: Ensure one appears in the lost connection notice.
...
fixes #32914 .
Built from https://develop.svn.wordpress.org/trunk@33132
git-svn-id: http://core.svn.wordpress.org/trunk@33103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:20:24 +00:00
Andrew Ozz
4cd790906f
TinyMCE, Press This: add the wptextpattern
plugin to the Press This editor.
...
See #31441 .
Built from https://develop.svn.wordpress.org/trunk@33128
git-svn-id: http://core.svn.wordpress.org/trunk@33099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 19:53:25 +00:00
Sergey Biryukov
1276096e3a
Menus: Restore visibility of up/down arrows for reordering menu items with JS disabled.
...
props afercia.
fixes #32916 .
Built from https://develop.svn.wordpress.org/trunk@33121
git-svn-id: http://core.svn.wordpress.org/trunk@33092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 06:48:24 +00:00
Helen Hou-Sandí
9c3bc85649
Ensure error messages look like, well, errors.
...
props obenland, rachelbaker.
fixes #32475 .
Built from https://develop.svn.wordpress.org/trunk@33117
git-svn-id: http://core.svn.wordpress.org/trunk@33088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 23:11:24 +00:00
Scott Taylor
0deed4b842
In install_dashboard()
(plugin-install
, FWIW), make sure slug
is populated and degrease the unfortunate whitespace that was present.
...
Props tyxla.
Fixes #32889 .
Built from https://develop.svn.wordpress.org/trunk@33114
git-svn-id: http://core.svn.wordpress.org/trunk@33085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:19:24 +00:00
Konstantin Obenland
2cc8269741
Hide notices introduced in [30505] on about page.
...
See #19237 .
Props jadpm.
Fixes #32625 .
Built from https://develop.svn.wordpress.org/trunk@33113
git-svn-id: http://core.svn.wordpress.org/trunk@33084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 18:47:25 +00:00
Konstantin Obenland
52c2567424
Menus: Respect context when linking to the Customizer.
...
`Manage in Customizer` will now link to menu locations or the menus panel in
the customizer, depending on whether the user is editing menus or managing
locations.
Props rabmalin for initial patch.
Fixes #32852 .
Built from https://develop.svn.wordpress.org/trunk@33112
git-svn-id: http://core.svn.wordpress.org/trunk@33083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:49:24 +00:00
Konstantin Obenland
ee9cb55e1a
Respect the special case of having only one theme.
...
If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the `z-index`, so it can
remain at 10.
Fixes #31544 .
Built from https://develop.svn.wordpress.org/trunk@33111
git-svn-id: http://core.svn.wordpress.org/trunk@33082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:14:25 +00:00
Helen Hou-Sandí
acad0e2008
Better styling for .form-invalid
inputs.
...
props liljimmi.
fixes #32490 .
Built from https://develop.svn.wordpress.org/trunk@33109
git-svn-id: http://core.svn.wordpress.org/trunk@33080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:41:25 +00:00
Helen Hou-Sandí
e5c6186dd4
Menu customizer: Ensure item type doesn't collide with the handle focus glow.
...
props andg, metodiew.
fixes #32813 .
Built from https://develop.svn.wordpress.org/trunk@33107
git-svn-id: http://core.svn.wordpress.org/trunk@33078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:52:25 +00:00
Helen Hou-Sandí
0b046085ae
Show row actions on focus for the dashboard comment list.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@33106
git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:26:24 +00:00
Helen Hou-Sandí
958cde5134
List tables: Ensure special CSS for the title column gets applied.
...
This could have some side effects if a custom list table has a title column with a strong element inside that is not the post title, but that is fairly edge and we can address that if it comes up. Also moves the rules into `list-tables.css`.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@33105
git-svn-id: http://core.svn.wordpress.org/trunk@33076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:21:25 +00:00
Helen Hou-Sandí
81c2f541b0
List tables: Add a fallback for the primary column.
...
Without a primary column defined, nothing shows in the responsive view at all, which is bad.
props mordauk.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@33104
git-svn-id: http://core.svn.wordpress.org/trunk@33075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:12:27 +00:00
Helen Hou-Sandí
df220685a0
List tables: Account for comments being reused on the post edit screen.
...
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.
see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33101
git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:09:24 +00:00
Jeremy Felt
c9027b00ba
Assign proper active class when showing plugin updates in network admin
...
Previously, a plugin would trigger an active class if it was active on the network's main site.
Fixes #32901 .
Built from https://develop.svn.wordpress.org/trunk@33100
git-svn-id: http://core.svn.wordpress.org/trunk@33071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:02:24 +00:00
Helen Hou-Sandí
2d6edf0fe8
List tables: Get rid of double borders for plugins and themes on narrow screens.
...
see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33099
git-svn-id: http://core.svn.wordpress.org/trunk@33070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:49:24 +00:00
Helen Hou-Sandí
6fff730706
List tables: Ensure the no items message appears on narrow screens.
...
fixes #32900 . see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33098
git-svn-id: http://core.svn.wordpress.org/trunk@33069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:30:24 +00:00
Jeremy Felt
3faebf40a6
Remove unused $current_site
global in MS Sites list table
...
Found itself unused after [32719].
See #32434 .
Built from https://develop.svn.wordpress.org/trunk@33097
git-svn-id: http://core.svn.wordpress.org/trunk@33068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:51:25 +00:00
Konstantin Obenland
c9a29b0123
Check for all required caps before (un)sticking a post.
...
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.
Props ericmann, chriscct7.
Fixes #24153 .
Built from https://develop.svn.wordpress.org/trunk@33096
git-svn-id: http://core.svn.wordpress.org/trunk@33067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:41:25 +00:00
Weston Ruter
a62cc940ea
Customizer: Register controls and settings for nav_menu_locations
even when there are no menus yet.
...
This change ensures that the first menu created can be assigned to a location without first saving and reloading the Customizer.
Props markoheijnen.
Fixes #32858 .
Built from https://develop.svn.wordpress.org/trunk@33094
git-svn-id: http://core.svn.wordpress.org/trunk@33065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 19:13:25 +00:00
Andrew Ozz
b2e725eb27
Fix opening closed widget areas when dragging a widget over them.
...
Props polevaultweb. Fixes #13524 .
Built from https://develop.svn.wordpress.org/trunk@33088
git-svn-id: http://core.svn.wordpress.org/trunk@33059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 18:20:24 +00:00
Sergey Biryukov
c543f98ee6
Plugins list table: Add an aria-label
attribute with the plugin name to plugin action links to provide context for screen reader users.
...
props bramd, rianrietveld, afercia.
fixes #26167 .
Built from https://develop.svn.wordpress.org/trunk@33087
git-svn-id: http://core.svn.wordpress.org/trunk@33058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 15:03:25 +00:00
Konstantin Obenland
664b0373dc
Site Icon: Switch to using H1 headings.
...
See #31650 .
Props afercia.
Fixes #32885 .
Built from https://develop.svn.wordpress.org/trunk@33084
git-svn-id: http://core.svn.wordpress.org/trunk@33055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 18:49:27 +00:00
Jeremy Felt
67142f5a2f
Don't autocapitalize or autocorrect domain or path when adding a new site in iOS.
...
Props @ohryan.
Fixes #32646 .
Built from https://develop.svn.wordpress.org/trunk@33082
git-svn-id: http://core.svn.wordpress.org/trunk@33053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:40:25 +00:00
Jeremy Felt
767ed1e9b1
Use the full site URL in choose_primary_blog()
when a user is a member of only one site.
...
Aligns with the output used when a user is a member of multiple sites.
Fixes #32884 .
Built from https://develop.svn.wordpress.org/trunk@33081
git-svn-id: http://core.svn.wordpress.org/trunk@33052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:21:24 +00:00
Jeremy Felt
5ab785b054
Only output Save Changes in My Sites when a user is a member of more than one site.
...
The conditional also checks for the existence of filters that may otherwise alter the HTML in My Sites to include extra form inputs for these users. If a filter is in use, the Save Changes button will display.
Props @Oxymoron, @obenland.
Fixes #32645 .
Built from https://develop.svn.wordpress.org/trunk@33080
git-svn-id: http://core.svn.wordpress.org/trunk@33051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:01:26 +00:00
Sergey Biryukov
ddff6fe471
Don't capitalize words in a sentence after comma.
...
props bjornjohansen, netweb.
fixes #31927 .
Built from https://develop.svn.wordpress.org/trunk@33079
git-svn-id: http://core.svn.wordpress.org/trunk@33050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 00:50:25 +00:00
Dominik Schilling
340f1e121e
Customizer: Fix tabindex
of reorder buttons for menu items with depth 1 and 10.
...
props celloexpressions.
fixes #32767 .
Built from https://develop.svn.wordpress.org/trunk@33077
git-svn-id: http://core.svn.wordpress.org/trunk@33048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 22:21:24 +00:00
Sergey Biryukov
b2299463b6
Plugins list table: Use case-insensitive sorting.
...
props GaryJ.
fixes #32735 .
Built from https://develop.svn.wordpress.org/trunk@33076
git-svn-id: http://core.svn.wordpress.org/trunk@33047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:53:25 +00:00
Konstantin Obenland
cf22cd7d72
Site Icon: Remove date dropdown from media modal.
...
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.
Props ocean90.
Fixes #32860 .
Built from https://develop.svn.wordpress.org/trunk@33075
git-svn-id: http://core.svn.wordpress.org/trunk@33046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:28:24 +00:00
Dominik Schilling
200463d781
Customizer: Improve descriptive text and focus for menu items reorder button.
...
props afercia.
fixes #32725 .
Built from https://develop.svn.wordpress.org/trunk@33074
git-svn-id: http://core.svn.wordpress.org/trunk@33045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:24:25 +00:00
Konstantin Obenland
86499fc07d
Synchronize star ratings of themes and plugins.
...
Makes themes ratings look like plugins ratings already do.
Props helen.
Fixes #32782 .
Built from https://develop.svn.wordpress.org/trunk@33073
git-svn-id: http://core.svn.wordpress.org/trunk@33044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:54:24 +00:00
Boone Gorges
27885cc561
Improve the display of my-sites.php on small screens.
...
Props tryon.
Fixes #31685 .
Built from https://develop.svn.wordpress.org/trunk@33072
git-svn-id: http://core.svn.wordpress.org/trunk@33043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:47:49 +00:00
Weston Ruter
912b434198
Customizer: Fix saving menus with empty names or names that are already used.
...
Adds validation for initially-supplied nav menu name, blocking empty names from being supplied. If later an empty name is supplied and the nav menu is saved, the name "(unnamed)" will be supplied instead and supplied back to the client. If a name is supplied for the menu which is currently used by another menu, then the name conflict is resolved by adding a numerical counter similar to how `post_name` conflicts are resolved. Includes unit tests.
Fixes #32760 .
Built from https://develop.svn.wordpress.org/trunk@33071
git-svn-id: http://core.svn.wordpress.org/trunk@33042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:47:25 +00:00
Dominik Schilling
93a334b361
Customizer: Remove some non-functional code.
...
props afercia.
fixes #32839 .
Built from https://develop.svn.wordpress.org/trunk@33070
git-svn-id: http://core.svn.wordpress.org/trunk@33041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:37:25 +00:00
Dominik Schilling
2ce8d2eea2
Customizer: Accessibility enhancements.
...
* Move tabindex/focus code into `onChangeExpanded` so that it works for cases where `expand()` is called directly.
* Use `visibility: hidden` to hide hidden elements from keyboard focus and screen readers.
props celloexpressions.
fixes #31336 .
Built from https://develop.svn.wordpress.org/trunk@33069
git-svn-id: http://core.svn.wordpress.org/trunk@33040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:19:25 +00:00
Konstantin Obenland
492853a64e
Don't let wp-pointers cover the theme detail modal.
...
Fixes #31544 .
Built from https://develop.svn.wordpress.org/trunk@33068
git-svn-id: http://core.svn.wordpress.org/trunk@33039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 17:05:24 +00:00
Konstantin Obenland
bd974d7bf2
Use a less element-specific class name for links within page titles.
...
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.
Fixes #31650 .
Built from https://develop.svn.wordpress.org/trunk@33067
git-svn-id: http://core.svn.wordpress.org/trunk@33038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 16:42:24 +00:00
Konstantin Obenland
2f383536fc
Check if commentReply
exists before trying to work with it.
...
Fixes a bug that caused the save/publish flow to be interrupted by an AYS.
Introduced in [33024].
See #29457 .
Built from https://develop.svn.wordpress.org/trunk@33066
git-svn-id: http://core.svn.wordpress.org/trunk@33037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 15:32:25 +00:00
Aaron Jorbin
903a12530b
Remove accidental change to embed
...
Reverts about.php change from [33064]
Built from https://develop.svn.wordpress.org/trunk@33065
git-svn-id: http://core.svn.wordpress.org/trunk@33036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 14:30:25 +00:00
Aaron Jorbin
91712711eb
Don't strip newline in esc_url() when protocol is mailto:
...
The mailto protocol is a bit different than the other protocols in that new lines are something you might realistically want to include. Includes tests to make sure that http protocol urls that contain mailto: aren't affected. Tests for stripping newlines in general already exist.
Fixes #31632
Props danielbachhuber
Built from https://develop.svn.wordpress.org/trunk@33064
git-svn-id: http://core.svn.wordpress.org/trunk@33035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 14:28:23 +00:00
Dion Hulse
ceaec85751
Press This: Rewrite WP_Press_This::fetch_source_html()
to utilise the HTTP API better without the need for a local temporary file.
...
This reverts [33061] but keeps it's custom UA string.
See #32864
Built from https://develop.svn.wordpress.org/trunk@33062
git-svn-id: http://core.svn.wordpress.org/trunk@33033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 12:01:25 +00:00
Sergey Biryukov
fc8c36eb97
Press This: Set explicit user agent.
...
props kraftbj.
fixes #32864 .
Built from https://develop.svn.wordpress.org/trunk@33061
git-svn-id: http://core.svn.wordpress.org/trunk@33032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 11:17:24 +00:00
Ella Iseulde Van Dorpe
12fba44414
Editor: refresh word count quicker
...
2 seconds is a bit slow. Debouncing with 1 second means it can only run maximum once per second. In reality it won't run us much. Even people who type slow will usually type faster than 1 character per second.
See #30966 .
Built from https://develop.svn.wordpress.org/trunk@33060
git-svn-id: http://core.svn.wordpress.org/trunk@33031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 09:15:24 +00:00
Dion Hulse
36de491d68
Don't upgrade global tables to utf8mb4 when wp_should_upgrade_global_tables()
says not to.
...
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.
See #32154
Built from https://develop.svn.wordpress.org/trunk@33058
git-svn-id: http://core.svn.wordpress.org/trunk@33029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 05:44:24 +00:00
Dion Hulse
d651de0dac
Introduce wp_should_upgrade_global_tables()
to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines.
...
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk
Built from https://develop.svn.wordpress.org/trunk@33057
git-svn-id: http://core.svn.wordpress.org/trunk@33028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 04:34:24 +00:00
Helen Hou-Sandí
f85306c65a
Toolbar: Allow submenus to be closed with a second tap on touch devices.
...
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.
props stephdau, seanchayes.
see #29906 .
Built from https://develop.svn.wordpress.org/trunk@33056
git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Dion Hulse
cbacb92dae
Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
...
This change does the following things
* Allows utf8mb4 for the MySQL extension
* Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
* Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
* Removes upgrade_420() calling as upgrade_430() will perform those changes now instead
The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again.
Props kovshenin, pento, dd32
Fixes #32127 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33055
git-svn-id: http://core.svn.wordpress.org/trunk@33026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:26:24 +00:00
Konstantin Obenland
a4e803fbd4
Use get_default_comment_status()
globally.
...
Also makes the filter name static and passes the post type for context.
Props valendesigns.
Fixes #31168 .
Built from https://develop.svn.wordpress.org/trunk@33054
git-svn-id: http://core.svn.wordpress.org/trunk@33025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 22:32:25 +00:00
Konstantin Obenland
cd7a40bdc7
Site Icon: Improve responsiveness for small screen devices.
...
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.
Props tyxla for initial patch.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33053
git-svn-id: http://core.svn.wordpress.org/trunk@33024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:16:24 +00:00
Sergey Biryukov
3fb3d2a762
Replace @returns
with @return
in PHP docblocks.
...
props kraftbj.
fixes #32865 .
Built from https://develop.svn.wordpress.org/trunk@33052
git-svn-id: http://core.svn.wordpress.org/trunk@33023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:05:24 +00:00
Konstantin Obenland
0d270f67c2
Site Icon: Skip cropping if image has the correct size.
...
Props jipmoors for initial patch.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33051
git-svn-id: http://core.svn.wordpress.org/trunk@33022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 20:40:25 +00:00
Konstantin Obenland
f2ce96004a
Add missing prefixed attributes, introduced in [33023].
...
See ##32589.
Built from https://develop.svn.wordpress.org/trunk@33050
git-svn-id: http://core.svn.wordpress.org/trunk@33021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 17:40:25 +00:00
Konstantin Obenland
bcf488fc23
Site Icon: Show correct background preview for transparent images.
...
iOS will show transparent parts as black, where as the icon itself stays
transparent when used as a favicon.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33049
git-svn-id: http://core.svn.wordpress.org/trunk@33020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 17:16:26 +00:00
Helen Hou-Sandí
d0e47d56ee
Customizer: Build flips the panel arrow for RTL on our behalf.
...
see #31336 .
Built from https://develop.svn.wordpress.org/trunk@33045
git-svn-id: http://core.svn.wordpress.org/trunk@33016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 01:29:25 +00:00
Konstantin Obenland
a193eb3ec7
Prevent link to customizer from wrpping on small screens.
...
Fixes #32808 .
Built from https://develop.svn.wordpress.org/trunk@33040
git-svn-id: http://core.svn.wordpress.org/trunk@33011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 23:36:26 +00:00
Dominik Schilling
85d7261305
Site icon: Remove option name from $whitelist_options
for the general options screen.
...
The option gets saved in `WP_Site_Icon->set_site_icon()`.
fixes #32859 .
Built from https://develop.svn.wordpress.org/trunk@33037
git-svn-id: http://core.svn.wordpress.org/trunk@33008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 21:41:26 +00:00
Mark Jaquith
504101460f
Slow down on calling zxcvbn if it isn't loaded.
...
see #32589
Built from https://develop.svn.wordpress.org/trunk@33033
git-svn-id: http://core.svn.wordpress.org/trunk@33004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 18:13:24 +00:00
Konstantin Obenland
b4a86c0f50
Add additional escaping to credits page.
...
Props Viper007Bond, gtuk for initial patch.
Fixes #21523 .
Built from https://develop.svn.wordpress.org/trunk@33032
git-svn-id: http://core.svn.wordpress.org/trunk@33003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 17:22:24 +00:00
Mark Jaquith
cb93e24c62
Add a missing "var". see #32589
...
Built from https://develop.svn.wordpress.org/trunk@33031
git-svn-id: http://core.svn.wordpress.org/trunk@33002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 17:16:25 +00:00
Dominik Schilling
78167b8a4c
Customizer: Make reordering menu items via drag and drop easier.
...
Introduce `wpNavMenu.options.targetTolerance` to define a tolerance when dragging items where no margins between the sortable items exists.
props adamsilverstein.
fixes #32821 .
Built from https://develop.svn.wordpress.org/trunk@33030
git-svn-id: http://core.svn.wordpress.org/trunk@33001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:44:24 +00:00
Jeremy Felt
b837d374bf
Trim trailing space from string in site delete confirmation
...
Props yoavf.
Fixes #32853 .
Built from https://develop.svn.wordpress.org/trunk@33029
git-svn-id: http://core.svn.wordpress.org/trunk@33000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:31:25 +00:00
Dominik Schilling
8430848b6d
Customizer: Fix height calculation of placeholders when dragging menu items.
...
props adamsilverstein.
fixes #32857 .
Built from https://develop.svn.wordpress.org/trunk@33028
git-svn-id: http://core.svn.wordpress.org/trunk@32999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:20:26 +00:00
Dominik Schilling
699dbedb03
l10n: Update wp_get_installed_translations()
to support variants of a language.
...
* A variant of a language has its own locale, for example the locale of the formal variant of German is `de_DE_formal`.
* Update `remove_accents()` and some CSS rules to support `de_DE_formal`.
* Add tests for `get_bloginfo( 'language' )`.
* API changes will be deployed over the next few days.
see #28303 .
Built from https://develop.svn.wordpress.org/trunk@33027
git-svn-id: http://core.svn.wordpress.org/trunk@32998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 15:43:24 +00:00
Konstantin Obenland
d9c5529d30
Improve the tone of key/salts recommendation message.
...
Also adds some inline comments to make it easier to understand how it
is determined whether to show the message or not.
Props helen.
Fixes #20779 .
Built from https://develop.svn.wordpress.org/trunk@33026
git-svn-id: http://core.svn.wordpress.org/trunk@32997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 15:39:26 +00:00
Konstantin Obenland
d03ff4b3d9
Close comment quick edit before updating a post.
...
Fixes a bug where the user gets redirected to the All Posts screen, after
updating a post while quick editing a comment.
Props polevaultweb.
Fixes #29457 .
Built from https://develop.svn.wordpress.org/trunk@33024
git-svn-id: http://core.svn.wordpress.org/trunk@32995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:54:24 +00:00
Mark Jaquith
423a1a7ca4
New password change/set UI.
...
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords
see #32589
props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023
git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:48:24 +00:00
Dion Hulse
ebb6aa1d4a
Split upgrade_430()
into two so that split_all_shared_terms()
runs when upgrade_430_fix_comments()
bails early.
...
See [32814], #30261 , [32364], #32165
Built from https://develop.svn.wordpress.org/trunk@33020
git-svn-id: http://core.svn.wordpress.org/trunk@32991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 07:35:24 +00:00
Helen Hou-Sandí
8eb7f71e6b
List tables: A better responsive view.
...
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.
Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.
props Michael Arestad, helen.
see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33016
git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:31:25 +00:00
Helen Hou-Sandí
8f85bb1ac5
Bulk/quick edit: Set the correct colspan.
...
`thead` can contain `td`s now, too.
props afercia.
fixes #31654 .
Built from https://develop.svn.wordpress.org/trunk@33015
git-svn-id: http://core.svn.wordpress.org/trunk@32986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:06:25 +00:00
Konstantin Obenland
e460d37da0
Open closed widget areas when dragging onto them.
...
Allows dropping Widgets into the correct spot of a given sidebar, no matter
whether that sidebar is open or closed. Removes a step from the setup process
for closed sidebars.
Props polevaultweb.
Fixes #13524 .
Built from https://develop.svn.wordpress.org/trunk@33014
git-svn-id: http://core.svn.wordpress.org/trunk@32985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:58:24 +00:00
Konstantin Obenland
ec407bc971
Customizer: Fresh colors for Reorder Done button.
...
When reordering Widgets or Menus, the red colorcould suggest
it would cancel the changes, rather than save them. The blue
suggests it's clickable and is more in line with the Close
link on open Widgets.
Fixes #32811 .
Built from https://develop.svn.wordpress.org/trunk@33012
git-svn-id: http://core.svn.wordpress.org/trunk@32983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:19:24 +00:00
Konstantin Obenland
f18fabc300
Site Icon: Move admin icon filter to its rightful place.
...
The action is unrelated to `WP_Site_Icon` itself.
Props kraftbj.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33011
git-svn-id: http://core.svn.wordpress.org/trunk@32982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 23:26:25 +00:00
Dominik Schilling
7cc9a4c092
Plugins list table: Sort plugins by Name
by default so translated plugin names get correctly sorted.
...
props swissspidy.
fixes #32735 .
Built from https://develop.svn.wordpress.org/trunk@33010
git-svn-id: http://core.svn.wordpress.org/trunk@32981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 22:31:25 +00:00
Andrew Ozz
d986bbbf42
Squish that .png a bit more. See [32994].
...
Built from https://develop.svn.wordpress.org/trunk@33009
git-svn-id: http://core.svn.wordpress.org/trunk@32980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 22:04:25 +00:00
Dominik Schilling
86ebc13446
Remove unnecessary feedback message from WP_Importer::is_user_over_quota()
.
...
fixes #32021 .
Built from https://develop.svn.wordpress.org/trunk@33008
git-svn-id: http://core.svn.wordpress.org/trunk@32979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 20:32:25 +00:00
Konstantin Obenland
aa3cb4ab1d
Use correct panel id for menus when linking to the customizer.
...
Props swissspidy.
Fixes #32808 .
Built from https://develop.svn.wordpress.org/trunk@33004
git-svn-id: http://core.svn.wordpress.org/trunk@32975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 16:24:24 +00:00
Helen Hou-Sandí
e41b7b4f75
Image edit: Consistent whitespace for the side boxes.
...
props tyxla.
fixes #31845 .
Built from https://develop.svn.wordpress.org/trunk@33002
git-svn-id: http://core.svn.wordpress.org/trunk@32973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 15:19:25 +00:00
Konstantin Obenland
38e4211efb
Use existing nomenclature pattern for Site Icon class.
...
Props kraftbj.
Fixes #32834 .
Built from https://develop.svn.wordpress.org/trunk@33001
git-svn-id: http://core.svn.wordpress.org/trunk@32972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 14:37:27 +00:00
Andrew Ozz
b092defb17
Press This:
...
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706 .
Built from https://develop.svn.wordpress.org/trunk@32999
git-svn-id: http://core.svn.wordpress.org/trunk@32970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 03:58:27 +00:00
Konstantin Obenland
36b24b073d
Provide alt text for uploaded header images.
...
The custom header screen will use it rather then the description,
if an alt text is set.
Props francoeurdavid, voldemortensen, valendesigns.
Fixes #27959 .
Built from https://develop.svn.wordpress.org/trunk@32998
git-svn-id: http://core.svn.wordpress.org/trunk@32969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-29 21:32:26 +00:00
Konstantin Obenland
c56a8ae0f7
Introducing Site Icon, favicon management for WordPress.
...
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.
Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@32994
git-svn-id: http://core.svn.wordpress.org/trunk@32965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-29 12:58:25 +00:00
Helen Hou-Sandí
83e33a2ca0
List tables: Bring screen reader text for comments column title to media.
...
see #32152 , [31513].
Built from https://develop.svn.wordpress.org/trunk@32991
git-svn-id: http://core.svn.wordpress.org/trunk@32962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:44:25 +00:00
Aaron Jorbin
1525010f74
Deprecate php4 style constructors
...
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).
This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."
Upstream: https://wiki.php.net/rfc/remove_php4_constructors
Props jdgrimes, netweb, jorbin
See #31982
Built from https://develop.svn.wordpress.org/trunk@32990
git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:27:24 +00:00
Aaron Jorbin
c9307fc95a
Update Grunt dev-dependencies
...
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).
Props wonderboymusic
See #31700
Built from https://develop.svn.wordpress.org/trunk@32988
git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
Konstantin Obenland
0704de88ea
Customizer: Correct position for menu item delete icon in IE8.
...
Props valendesigns.
Fixes #32675 .
Built from https://develop.svn.wordpress.org/trunk@32987
git-svn-id: http://core.svn.wordpress.org/trunk@32958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 11:49:24 +00:00
Aaron Jorbin
4bbf254375
Add missing semicolon
...
Introduced in [32983].
see #32757 .
Built from https://develop.svn.wordpress.org/trunk@32986
git-svn-id: http://core.svn.wordpress.org/trunk@32957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 11:41:24 +00:00
Sergey Biryukov
bff91cfa5b
Menus: Add a Manage in Customizer link, like we did for Widgets screen in [30459].
...
props celloexpressions.
fixes #32808 .
Built from https://develop.svn.wordpress.org/trunk@32985
git-svn-id: http://core.svn.wordpress.org/trunk@32956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 06:08:24 +00:00
Sergey Biryukov
b26accf35a
List tables: Select All should not be a column header.
...
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.
props afercia, valendesigns.
see #31654 .
Built from https://develop.svn.wordpress.org/trunk@32984
git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 05:46:25 +00:00
Andrew Ozz
275fc220ef
Press This:
...
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32983
git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:59:24 +00:00
Sergey Biryukov
9665259675
Customizer: Increase color contrast ratio for menu locations text.
...
props celloexpressions.
fixes #32727 .
Built from https://develop.svn.wordpress.org/trunk@32982
git-svn-id: http://core.svn.wordpress.org/trunk@32953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:45:25 +00:00
Scott Taylor
36513e9d7d
After [32974], tweak some CSS for focus, etc.
...
See #31650 .
Built from https://develop.svn.wordpress.org/trunk@32977
git-svn-id: http://core.svn.wordpress.org/trunk@32948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 23:13:24 +00:00
Weston Ruter
e162bb8940
Customizer: Improve previewing setting changes for show_on_front
, page_on_front
, and page_for_posts
.
...
When changing the `page_on_front` setting (with `show_on_front`), change the previewed URL to be the home URL so that the effect can be seen. When changing `page_for_posts`, change the previewed URL to be the selected page.
Props valendesigns, westonruter.
Fixes #30677 .
Built from https://develop.svn.wordpress.org/trunk@32976
git-svn-id: http://core.svn.wordpress.org/trunk@32947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 19:59:25 +00:00
Konstantin Obenland
77f385e532
Additional style changes to accomodate <h1>
headings.
...
See [32974], #31650 .
Built from https://develop.svn.wordpress.org/trunk@32975
git-svn-id: http://core.svn.wordpress.org/trunk@32946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:51:23 +00:00
Konstantin Obenland
7dc1d06e64
Proper heading for admin screens.
...
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.
Props joedolson, afercia.
Fixes #31650 .
Built from https://develop.svn.wordpress.org/trunk@32974
git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Sergey Biryukov
aa6a58f155
Fix the dismissable notice button focus style, broken in [32475].
...
props afercia.
fixes #32797 .
Built from https://develop.svn.wordpress.org/trunk@32973
git-svn-id: http://core.svn.wordpress.org/trunk@32944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:07:24 +00:00
Dominik Schilling
2ecb586214
Customizer: Add an aria-expanded
attribute to the Add Menu button to improve accessibility.
...
props afercia.
fixes #32791 .
Built from https://develop.svn.wordpress.org/trunk@32971
git-svn-id: http://core.svn.wordpress.org/trunk@32942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 10:05:24 +00:00
Dominik Schilling
2d9a46b973
Customizer: Remove top margin when dragging menu items.
...
The markup was changed in [32889].
props tywayne.
fixes #32745 .
Built from https://develop.svn.wordpress.org/trunk@32970
git-svn-id: http://core.svn.wordpress.org/trunk@32941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 09:47:23 +00:00
Andrew Ozz
7715a50c0b
Press This: fix iOS bug that prevents closing of the split button when tapping outside of it.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32966
git-svn-id: http://core.svn.wordpress.org/trunk@32937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 02:15:24 +00:00
Scott Taylor
8b1286417e
ob_get_contents()
followed by ob_end_clean()
can be replaced by ob_get_clean()
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32965
git-svn-id: http://core.svn.wordpress.org/trunk@32936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:12:24 +00:00
Scott Taylor
a0e373ef80
For doc block types, favor bool
over the few remaining boolean
s
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32964
git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:03:25 +00:00
Scott Taylor
642af1f3f4
Some doc blocks should use bool
instead of true|false
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32963
git-svn-id: http://core.svn.wordpress.org/trunk@32934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 00:45:24 +00:00
Scott Taylor
60b8e86b36
In WP_Filesystem_Base::chdir|chgrp|chmod()
(all mock abstract
methods), modify @return
to include string
so that subclass @return
s match.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32962
git-svn-id: http://core.svn.wordpress.org/trunk@32933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 00:43:24 +00:00
Dominik Schilling
a6b7a691be
Customizer: Prevent dragging menu items above the main heading.
...
Improve targeting for the `sortableItems`, resolving an issue where the first `<li>` in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.
props adamsilverstein.
fixes #32738 .
#wceu
Built from https://develop.svn.wordpress.org/trunk@32955
git-svn-id: http://core.svn.wordpress.org/trunk@32926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 17:11:24 +00:00
Scott Taylor
72bf48f0b9
In Media microtemplates after [32467], use <button>
instead of <a>
for several more non-links.
...
Props afercia.
Fixes #26550 .
Built from https://develop.svn.wordpress.org/trunk@32952
git-svn-id: http://core.svn.wordpress.org/trunk@32923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 05:01:24 +00:00
Scott Taylor
7537240d37
List tables: when post navigation links point to the current page, use <span>
s and text instead of <a>
s.
...
Props afercia.
Fixes #32253 .
Built from https://develop.svn.wordpress.org/trunk@32948
git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 20:32:26 +00:00
Scott Taylor
2518b37222
Admin menu: improve accessibility when collapsed.
...
Props afercia.
Fixes #32346 .
Built from https://develop.svn.wordpress.org/trunk@32946
git-svn-id: http://core.svn.wordpress.org/trunk@32917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:33:26 +00:00
Scott Taylor
587c570efa
After [32796], improve the accessibility and markup for instances of touch_time()
.
...
Props rianrietveld, afercia.
Fixes #31714 .
Built from https://develop.svn.wordpress.org/trunk@32945
git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:30:25 +00:00
Andrew Ozz
7142248743
Press This: better screen reader text for the arrow part of the split button.
...
Props afercia. See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32944
git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:24:25 +00:00
Scott Taylor
7453d12390
Remove unused code from WP_Press_This::html()
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32939
git-svn-id: http://core.svn.wordpress.org/trunk@32910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:38:25 +00:00
Scott Taylor
d9bd43c702
Remove unused code from WP_MS_Sites_List_Table::display_rows()
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32938
git-svn-id: http://core.svn.wordpress.org/trunk@32909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:36:29 +00:00
Andrew Ozz
d3ee649cb9
Press This: support passing i
parameter to add an image src.
...
Props stephdau, azaozz. Fixes #32173 .
Built from https://develop.svn.wordpress.org/trunk@32936
git-svn-id: http://core.svn.wordpress.org/trunk@32907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 03:06:25 +00:00
Andrew Ozz
d4f3428d5f
Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility.
...
Props afercia. See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32934
git-svn-id: http://core.svn.wordpress.org/trunk@32905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 01:55:30 +00:00
John Blackbourn
b5973e92ec
Introduce a no_terms
label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object.
...
Fixes #32150
Props afercia
Built from https://develop.svn.wordpress.org/trunk@32933
git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 00:16:27 +00:00
Scott Taylor
f23199caaa
Remove the whois.arin.net
link from wp_notify_postauthor()
and wp_notify_moderator()
.
...
Also, remove from `edit-form-comment.php` and add a new filter: `edit_comment_misc_actions`.
Props ozh, joedolson, rachelbaker.
Fixes #15281 .
Built from https://develop.svn.wordpress.org/trunk@32929
git-svn-id: http://core.svn.wordpress.org/trunk@32900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 20:56:27 +00:00
Drew Jaynes
e9758d4e48
Fix a typo in the DocBlock for get_plugins()
.
...
Props onnimonni, swissspidy.
Fixes #32758 .
Built from https://develop.svn.wordpress.org/trunk@32927
git-svn-id: http://core.svn.wordpress.org/trunk@32898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 12:22:27 +00:00
Dion Hulse
42fbb6568e
WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923.
...
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548
Built from https://develop.svn.wordpress.org/trunk@32924
git-svn-id: http://core.svn.wordpress.org/trunk@32895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 04:52:25 +00:00
Dion Hulse
8f47efe7dc
WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments
...
Props mnelson4 for initial patch.
Fixes #29548
Built from https://develop.svn.wordpress.org/trunk@32923
git-svn-id: http://core.svn.wordpress.org/trunk@32894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 04:49:25 +00:00
Andrew Ozz
dfaa89d853
Press This: fix spinner position relative to the split button.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32922
git-svn-id: http://core.svn.wordpress.org/trunk@32893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 03:32:25 +00:00
Andrew Ozz
f8cf80e9b1
Press This: ensure proper tab order in the split button. Tweak padding and border color a bit.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32921
git-svn-id: http://core.svn.wordpress.org/trunk@32892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 03:23:27 +00:00
Andrew Ozz
f4109b0c5d
Press This: convert the Preview | Save | Publish buttons to a split button.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32920
git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 02:46:27 +00:00
John Blackbourn
3c7ea03cb0
Correct the title used on the user dashboard.
...
Fixes #32754
Props johnjamesjacoby
Built from https://develop.svn.wordpress.org/trunk@32917
git-svn-id: http://core.svn.wordpress.org/trunk@32888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 00:37:28 +00:00
Scott Taylor
f61501f57f
The query-attachments
AJAX action immediately errors out if the user doesn't have the upload_files
cap. As such, the Customizer shouldn't show buttons that launch the media modal when the user doesn't have the proper permissions to query attachments.
...
See #32654 .
Built from https://develop.svn.wordpress.org/trunk@32913
git-svn-id: http://core.svn.wordpress.org/trunk@32884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 18:20:27 +00:00
Scott Taylor
00de0e6341
In unregister_setting()
, search for $option_name
in a segment of $new_whitelist_options
keyed by $option_group
.
...
Props nofearinc.
Fixes #26479 .
Built from https://develop.svn.wordpress.org/trunk@32905
git-svn-id: http://core.svn.wordpress.org/trunk@32876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:51:26 +00:00
Scott Taylor
b8f49cebee
List table views: fix missing current class for "All" when logged in as an author.
...
Props afercia.
Fixes #32015 .
Built from https://develop.svn.wordpress.org/trunk@32903
git-svn-id: http://core.svn.wordpress.org/trunk@32874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:39:27 +00:00
Helen Hou-Sandí
5a07e4bba4
Add "Scheduled" to post states.
...
props rclations.
fixes #32131 .
Built from https://develop.svn.wordpress.org/trunk@32902
git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 16:07:26 +00:00
Sergey Biryukov
4332d8dfc0
Avoid a PHP notice in WP_Press_This::get_suggested_content()
after [32828].
...
props kraftbj.
fixes #32751 .
Built from https://develop.svn.wordpress.org/trunk@32901
git-svn-id: http://core.svn.wordpress.org/trunk@32872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 15:20:28 +00:00
Andrew Ozz
e4758f42e5
Update the TinyMCE initialization:
...
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425 .
Built from https://develop.svn.wordpress.org/trunk@32899
git-svn-id: http://core.svn.wordpress.org/trunk@32870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-21 22:01:28 +00:00
Dominik Schilling
baeadbb6fb
Customizer: Accessibility improvements for menu item searches.
...
* Add a description and an `aria-describedby` attribute to inform users this is a "live" search.
* Announce the number of search results via `wp.a11y.speak`.
* Use `aria-busy` attribute to stop screen readers announcing content while the "loading more results" is running.
* Increase the search debounce wait interval to 500ms to be consistent with other live searches.
* If a search fails don't call `wp.a11y.speak` with an undefined variable.
props afercia.
see #32720 .
Built from https://develop.svn.wordpress.org/trunk@32891
git-svn-id: http://core.svn.wordpress.org/trunk@32862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:22:25 +00:00
Dominik Schilling
4a13015c98
Customizer: Don't add a menu item twice when using the keyboard.
...
Buttons don't need keyboard events, they natively support keyboard interaction and they just need a click event.
fixes #32665 .
Built from https://develop.svn.wordpress.org/trunk@32890
git-svn-id: http://core.svn.wordpress.org/trunk@32861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:01:25 +00:00
Scott Taylor
92d67bf395
Use valid markup in Walker_Nav_Menu_Edit::start_el()
- replace <d(l|t)>
with <div>
for .menu-item-bar
and .menu-item-handle
.
...
Props sagarjadhav.
Fixes #31817 .
Built from https://develop.svn.wordpress.org/trunk@32879
git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:22:26 +00:00
Scott Taylor
032ea5b132
Add access modifier to WP_Upgrader::clear_destination()
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32871
git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:53:25 +00:00
Scott Taylor
23e02fafce
Edit Post screen messages need to run preview URLs through the preview_post_link
filter.
...
Props pareshradadiya.
Fixes #32191 .
Built from https://develop.svn.wordpress.org/trunk@32870
git-svn-id: http://core.svn.wordpress.org/trunk@32841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:49:25 +00:00
Scott Taylor
86beb35f6d
Use <button>
instead of <a>
for non-link links in Quick Edit.
...
Props afercia.
Fixes #32213 .
Built from https://develop.svn.wordpress.org/trunk@32869
git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:42:27 +00:00
Scott Taylor
cfe78e0e95
Cleanup (ms-)?admin-filters.php
...
Props johnjamesjacoby.
Fixes #32529 .
Built from https://develop.svn.wordpress.org/trunk@32865
git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:18:25 +00:00
Scott Taylor
b212ee67e7
Media Library Bulk Select
button size should be smaller.
...
Props afercia.
Fixes #32325 .
Built from https://develop.svn.wordpress.org/trunk@32862
git-svn-id: http://core.svn.wordpress.org/trunk@32833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:56:27 +00:00
Dominik Schilling
a28586a6d7
Customizer: Improve accessibility of the toggle button in the available menu items panel.
...
Prevents focus lost in Safari because the button was "invisible" until it got focused.
fixes #32709 .
Built from https://develop.svn.wordpress.org/trunk@32859
git-svn-id: http://core.svn.wordpress.org/trunk@32830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 17:24:24 +00:00
Konstantin Obenland
4e7c057a5a
Check that current changes can be lost before editing another comment.
...
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.
Props pareshradadiya, chriscct7.
Fixes #21845 .
Built from https://develop.svn.wordpress.org/trunk@32857
git-svn-id: http://core.svn.wordpress.org/trunk@32828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 13:48:25 +00:00
Ella Iseulde Van Dorpe
fd95002b2a
Editor: restructure word count
...
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.
See #30966 . Fixes #26620 .
Built from https://develop.svn.wordpress.org/trunk@32856
git-svn-id: http://core.svn.wordpress.org/trunk@32827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 10:35:26 +00:00
Dion Hulse
8593dc3172
When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
...
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921
Built from https://develop.svn.wordpress.org/trunk@32854
git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:49:25 +00:00
Dion Hulse
a21f890abb
Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
...
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk
Built from https://develop.svn.wordpress.org/trunk@32852
git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:18:26 +00:00
Dominik Schilling
f5fa907f77
Customizer: Improve accessibility of Add Menu Items button and its panel.
...
props afercia, ocean90.
fixes #32682 .
Built from https://develop.svn.wordpress.org/trunk@32848
git-svn-id: http://core.svn.wordpress.org/trunk@32819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 20:52:24 +00:00
Dominik Schilling
f39edce68d
Autoprefixer for [32844].
...
Built from https://develop.svn.wordpress.org/trunk@32847
git-svn-id: http://core.svn.wordpress.org/trunk@32818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 20:49:26 +00:00
Scott Taylor
09c4444150
Make sure that all Gravatars are generated by get_avatar()
or at least run through apply_filters( 'get_avatar', $avatar )
for the sake of extensibility.
...
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650 .
Built from https://develop.svn.wordpress.org/trunk@32845
git-svn-id: http://core.svn.wordpress.org/trunk@32816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 18:36:25 +00:00
Konstantin Obenland
c1a9c4b7b8
Semanticize Help and Screen Options toggle.
...
Links used as UI controls that are not real links but act as buttons, should be buttons.
Props afercia.
Fixes #32494 .
Built from https://develop.svn.wordpress.org/trunk@32844
git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 16:36:25 +00:00
Konstantin Obenland
81df9bffc5
Use https for Google API external libraries.
...
Google recommends it and users are more likely to have the https version cached in their browser already.
Props rommelxcastro.
Fixes #32552 .
Built from https://develop.svn.wordpress.org/trunk@32843
git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:51:26 +00:00
Konstantin Obenland
d872f38c31
Show the posts meta box by default in Appearance > Menus.
...
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.
Props bcole808.
Fixes #32440 .
Built from https://develop.svn.wordpress.org/trunk@32842
git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:04:26 +00:00
Konstantin Obenland
f7f14ae558
More consistent spacing around the excerpt textarea.
...
Props paulwilde.
Fixes #32242 .
Built from https://develop.svn.wordpress.org/trunk@32841
git-svn-id: http://core.svn.wordpress.org/trunk@32812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 14:19:25 +00:00
Konstantin Obenland
437b1c2b6a
Revert [32834].
...
It's not ready yet and was a product of misusing vim.
See #30729 .
Built from https://develop.svn.wordpress.org/trunk@32835
git-svn-id: http://core.svn.wordpress.org/trunk@32806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:27:25 +00:00
Konstantin Obenland
598f4cc4ca
Emphasise previewing new themes
...
Built from https://develop.svn.wordpress.org/trunk@32834
git-svn-id: http://core.svn.wordpress.org/trunk@32805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:24:27 +00:00
Konstantin Obenland
c9e1e2be9b
Make posts in the 'Most recent' tab of post type meta boxes filterable.
...
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.
Props jpyper, chriscct7.
Fixes #19365 .
Built from https://develop.svn.wordpress.org/trunk@32833
git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:35:28 +00:00
Konstantin Obenland
326c106159
Recommend a user updates keys/salts in maint/repair.php
.
...
Since they are already going into `wp-config.php`, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.
Props nacin, chriscct7.
Fixes #20779 .
Built from https://develop.svn.wordpress.org/trunk@32830
git-svn-id: http://core.svn.wordpress.org/trunk@32801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:07:25 +00:00
Andrew Ozz
bc2630e099
Press This: Check the embeds list against all of the oembed providers.
...
Props stephdau. Fixes #32069 .
Built from https://develop.svn.wordpress.org/trunk@32828
git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 00:12:26 +00:00
Andrew Ozz
b77a3a33f5
Press This: show error message when the user is attempting to add a category that already exists.
...
Fixes #32339 .
Built from https://develop.svn.wordpress.org/trunk@32827
git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:13:26 +00:00
Dominik Schilling
6e44f060ee
Customizer: Remove an overflow: hidden
declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field.
...
props paulwilde.
fixes #32680 .
Built from https://develop.svn.wordpress.org/trunk@32825
git-svn-id: http://core.svn.wordpress.org/trunk@32796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:43:26 +00:00
Dominik Schilling
5864a7ad44
Customizer: Fix keyboard events for the menu items search field.
...
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.
props tywayne.
fixes #32677 .
Built from https://develop.svn.wordpress.org/trunk@32824
git-svn-id: http://core.svn.wordpress.org/trunk@32795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:37:27 +00:00
Dominik Schilling
504db9233b
Customizer: Revert the blue on hover color which was introduced in [32649].
...
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158 .
see #31336 .
Built from https://develop.svn.wordpress.org/trunk@32823
git-svn-id: http://core.svn.wordpress.org/trunk@32794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:07:27 +00:00
Dominik Schilling
a1f7f4fe17
Customizer: Replace usage of calc()
with box-sizing: border-box
.
...
IE8 doesn't support `calc()`.
props afercia.
see #31336 .
fixes #32664 .
Built from https://develop.svn.wordpress.org/trunk@32821
git-svn-id: http://core.svn.wordpress.org/trunk@32792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:35:28 +00:00
Boone Gorges
f62bf61b2c
Bail out of 4.3 term splitting routine when no shared terms are found.
...
Props dd32.
See #30261 .
Built from https://develop.svn.wordpress.org/trunk@32819
git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 11:40:24 +00:00
Ella Iseulde Van Dorpe
1a4c6ad45d
JSHint after [32806]
...
See #32576 .
Built from https://develop.svn.wordpress.org/trunk@32815
git-svn-id: http://core.svn.wordpress.org/trunk@32786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 04:15:26 +00:00
Boone Gorges
290044ef15
Split all shared taxonomy terms on upgrade to 4.3.
...
Dear Shared Terms, Welcome to Splitsville. Population: You.
See #30261 .
Built from https://develop.svn.wordpress.org/trunk@32814
git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 01:53:26 +00:00
Dominik Schilling
ac33d71623
Fix a typo in [32806].
...
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32808
git-svn-id: http://core.svn.wordpress.org/trunk@32779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 23:09:25 +00:00
Dominik Schilling
62e3a0c15c
Add menu management to the Customizer.
...
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/ .
props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32806
git-svn-id: http://core.svn.wordpress.org/trunk@32777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 22:08:26 +00:00
Helen Hou-Sandí
d159cc2272
Media list table: Avoid PHP notices by using the proper variables.
...
Also visually tightens up the row actions.
props tyxla.
fixes #32657 . see #29881 .
Built from https://develop.svn.wordpress.org/trunk@32805
git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 21:33:25 +00:00
Scott Taylor
45d5037a10
Avoid using HTML in translation strings in edit-form-comment.php
.
...
Fixes #31847 .
Built from https://develop.svn.wordpress.org/trunk@32801
git-svn-id: http://core.svn.wordpress.org/trunk@32772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:08:24 +00:00
Scott Taylor
5c6b63d3a6
if
is a statment, not a function.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32800
git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:01:25 +00:00
Scott Taylor
5e14470894
Avoid using <code>
in a translation string.
...
Props ramiy.
Fixes #31848 .
Built from https://develop.svn.wordpress.org/trunk@32799
git-svn-id: http://core.svn.wordpress.org/trunk@32770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:53:27 +00:00
Helen Hou-Sandí
a49c192f37
Media list table: Restore row actions.
...
see #29881 , #32657 .
Built from https://develop.svn.wordpress.org/trunk@32798
git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 19:47:24 +00:00
Helen Hou-Sandí
457456ef25
Comments: Better markup for the edit screen.
...
Previously there were no labels, and since labels can't contain links and the links were of dubious value, we've removed those.
props afercia, DrewAPicture.
fixes #31326 .
Built from https://develop.svn.wordpress.org/trunk@32796
git-svn-id: http://core.svn.wordpress.org/trunk@32767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 18:54:26 +00:00
Boone Gorges
66c1d75c1c
Tag/category conversion link on edit-tags.php should point to specific importer page when cat2tag plugin is active.
...
Props solarissmoke, c3mdigital.
Fixes #16369 .
Built from https://develop.svn.wordpress.org/trunk@32792
git-svn-id: http://core.svn.wordpress.org/trunk@32763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 04:30:26 +00:00
Dion Hulse
faf6383ebd
Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
...
Props mordauk. Fixes #31784
Built from https://develop.svn.wordpress.org/trunk@32784
git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 06:26:25 +00:00
Dion Hulse
c6bb637f89
Updats: Add a filter for the options params for the update being performed.
...
Props nofearinc. Fixes #27754
Built from https://develop.svn.wordpress.org/trunk@32783
git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:35:26 +00:00
Dion Hulse
c726f72ea4
Updates: Allow the update row to include the active border styling post-ajax update.
...
Props TobiasBg. Fixes #32129
Built from https://develop.svn.wordpress.org/trunk@32782
git-svn-id: http://core.svn.wordpress.org/trunk@32753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:13:25 +00:00
Dion Hulse
b881a541bb
Updates: Remove redundant title tags from update outputs.
...
Props afercia. Fixes #32530
Built from https://develop.svn.wordpress.org/trunk@32781
git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 05:09:25 +00:00
Dion Hulse
629545aaf5
Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
...
Props magicroundabout. Fixes #32110 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32780
git-svn-id: http://core.svn.wordpress.org/trunk@32751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 04:28:25 +00:00
Dion Hulse
6eef8a8ff2
Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
...
Fixes #32435 , #32473
Built from https://develop.svn.wordpress.org/trunk@32779
git-svn-id: http://core.svn.wordpress.org/trunk@32750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:48:28 +00:00
Dion Hulse
0eb8bfc464
Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32778
git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:32:27 +00:00
Dion Hulse
04325cd834
Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32777
git-svn-id: http://core.svn.wordpress.org/trunk@32748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:20:28 +00:00
Dion Hulse
a4b4918377
Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32776
git-svn-id: http://core.svn.wordpress.org/trunk@32747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 02:48:28 +00:00
Helen Hou-Sandí
e3ae4f9d7e
Multisite: Use an email input for new user email address.
...
We also need to set novalidate on the form due to some browsers rejecting valid email addresses containing an IDN. We should holistically investigate whether this is still an issue in any major browsers at some point.
props earnjam.
fixes #32643 .
Built from https://develop.svn.wordpress.org/trunk@32774
git-svn-id: http://core.svn.wordpress.org/trunk@32745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:41:27 +00:00
Helen Hou-Sandí
ed46512c20
Reduce form spacing on narrower screens.
...
props liljimmi.
fixes #32489 , #32484 .
Built from https://develop.svn.wordpress.org/trunk@32772
git-svn-id: http://core.svn.wordpress.org/trunk@32743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 20:12:26 +00:00
Andrew Nacin
e7f618d86e
Tweak the first post/page content to get with the times.
...
props chriscct7.
fixes #22474 .
Built from https://develop.svn.wordpress.org/trunk@32768
git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 18:56:50 +00:00
Jeremy Felt
8daec04557
Remove a now unused switch_to_blog()
and restore_current_blog()
in site-info.php
...
Now that we decide when to automatically update `home` and `siteurl`, we no longer need to switch to the site while displaying the form output.
See #32503 .
Built from https://develop.svn.wordpress.org/trunk@32761
git-svn-id: http://core.svn.wordpress.org/trunk@32732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 08:23:26 +00:00
Jeremy Felt
da35c25fb7
Remove the "Update siteurl and home as well" checkbox when editing a site
...
Rather than provide a checkbox to update the `siteurl` and `home` options, we can make an educated decision based on the current state. If the home and/or siteurl domain and path match the existing domain and path of the site, then we update with the new information.
Also, while scheme is not stored in `wp_blogs` along with a site, the scheme of the `home` and `siteurl` options can now be modified via the Site URL setting in `site-info.php` when the `home` and/or `siteurl` options match the existing domain.
Props @hugobaeta, @earnjam, @jeremyfelt.
Fixes #32503 , see #22383 .
Built from https://develop.svn.wordpress.org/trunk@32760
git-svn-id: http://core.svn.wordpress.org/trunk@32731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:52:24 +00:00
Jeremy Felt
186c37a325
Capture domain and path when editing sites on a subdomain network
...
When a network is configured as subdomain, allow for the input of arbitrary domain and path combinations when editing a site rather than just the domain.
This takes a step or two toward #32503 .
Props @scribu, @ericlewis, @jeremyfelt.
See #22383 .
Built from https://develop.svn.wordpress.org/trunk@32759
git-svn-id: http://core.svn.wordpress.org/trunk@32730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 07:09:25 +00:00
Jeremy Felt
f996e163b8
Improve code readability in site-info.php
...
In advance of some other work here, clean up some braces and spaces.
See #22383 .
Built from https://develop.svn.wordpress.org/trunk@32758
git-svn-id: http://core.svn.wordpress.org/trunk@32729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-14 05:01:28 +00:00
Scott Taylor
4348074f3a
In WP_MS_Users_List_Table::display_rows()
:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32757
git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 17:11:26 +00:00
Scott Taylor
3855cfbffd
In WP_MS_Themes_List_Table::display_rows()
:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32756
git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:54:26 +00:00
Scott Taylor
2bdcc71bc0
In WP_MS_Sites_List_Table::display_rows()
:
...
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32755
git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 16:23:25 +00:00
Scott Taylor
ba8cfcab71
In WP_Media_List_Table::display_rows()
:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32754
git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:57:27 +00:00
Scott Taylor
a56576edfe
In WP_Links_List_Table::display_rows()
:
...
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32753
git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:33:25 +00:00
Scott Taylor
b8eb353590
In WP_Posts_List_Table
, move the <th>
markup out of ->column_cb()
.
...
See #29881 , [32740].
Built from https://develop.svn.wordpress.org/trunk@32752
git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:14:24 +00:00
Scott Taylor
18827ed337
In wp_ajax_hidden_columns()
, don't explode()
on an empty string.
...
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.
This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.
Props afercia, wonderboymusic.
Fixes #32466 .
Built from https://develop.svn.wordpress.org/trunk@32751
git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 15:00:25 +00:00
Scott Taylor
da0400e273
In WP_Posts_List_Table::column_title()
, use is_post_type_hierarchical()
instead of $this->hierarchical_display
in the logic to determine whether the_excerpt()
should be called.
...
Fixes #32187 .
Built from https://develop.svn.wordpress.org/trunk@32749
git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:42:26 +00:00
Dominik Schilling
fe31ed1e5f
Nav menu: Allow the sortable items selector in wpNavMenu
to be overridden.
...
props adamsilverstein.
fixes #32633 .
Built from https://develop.svn.wordpress.org/trunk@32745
git-svn-id: http://core.svn.wordpress.org/trunk@32716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:03:25 +00:00
Weston Ruter
40ad21b58b
Fix regressions from [32649] wrt Customizer expanded
and active
state changes for sections.
...
The `args.completeCallback` was not always called when `onChangeExpanded()` was called. And when a section became inactive (`active` state goes to `false`) and it was currently `expanded`, the Customizer panel would then becomes blank as the section was hidden; it needed to `collapse()` the section first before hiding the element.
See #31336 .
Built from https://develop.svn.wordpress.org/trunk@32743
git-svn-id: http://core.svn.wordpress.org/trunk@32714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 22:28:25 +00:00
Scott Taylor
c11e433858
After [32740], in WP_Posts_List_Table::single_row()
- $lock_holder
is checked but unused, so the call to get_userdata()
is unnecessary.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32742
git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:48:26 +00:00
Scott Taylor
c1c7a7c14c
After [32740], correct doc block typo.
...
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32741
git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:29:26 +00:00
Scott Taylor
3f4cadf4aa
Override ->single_row_columns()
in WP_Posts_List_Table
.
...
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.
This list table class is now easier to subclass.
Props joehoyle, wonderboymusic.
See #29881 .
Built from https://develop.svn.wordpress.org/trunk@32740
git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 20:18:24 +00:00
Scott Taylor
d0aa8e4a6e
In WP_Terms_List_Table::display_rows_or_placeholder()
:
...
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32739
git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:55:25 +00:00
Scott Taylor
da4c3d0fe4
In WP_Posts_List_Table::single_row()
:
...
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32738
git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:50:25 +00:00
Scott Taylor
4835310a18
In WP_Media_List_Table::display_rows()
, get_the_terms()
can return WP_Error
, so its return value should be checked before traversing.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32737
git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:45:25 +00:00
Scott Taylor
f88b42be94
In WP_Comments_List_Table::column_comment()
, $post
and $the_comment_status
are unused, as is the $comment_status
global.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32736
git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:39:25 +00:00
Scott Taylor
55b3ec92f4
Fix some malformed doc blocks in Custom_Image_Header
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32735
git-svn-id: http://core.svn.wordpress.org/trunk@32706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:35:26 +00:00
Scott Taylor
ab66fc95bc
Fix some malformed doc blocks in Custom_Background
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32734
git-svn-id: http://core.svn.wordpress.org/trunk@32705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 18:25:25 +00:00
Scott Taylor
d2a00338f6
Don't loosely compare functions that return bool
against a literal bool
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32730
git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:19:27 +00:00
Dion Hulse
c445d60a00
SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions.
...
See #32345
Built from https://develop.svn.wordpress.org/trunk@32726
git-svn-id: http://core.svn.wordpress.org/trunk@32696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 06:31:28 +00:00
Konstantin Obenland
cb39d03501
Improve non-visual feedback for list table items without terms.
...
Props karpstrucking, afercia.
Fixes #32150 .
Built from https://develop.svn.wordpress.org/trunk@32725
git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-11 09:28:31 +00:00
Helen Hou-Sandí
c87224eaf6
List tables: Use a class instead of inline styles for hidden columns.
...
fixes #32608 .
Built from https://develop.svn.wordpress.org/trunk@32724
git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
Helen Hou-Sandí
06ebd0a2aa
List tables:
...
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32723
git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:31:25 +00:00
Helen Hou-Sandí
51b5ed9fa4
List tables: Better primary column back-compat.
...
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.
props kovshenin.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32722
git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:59:30 +00:00
Helen Hou-Sandí
3562ac028d
List tables: Consolidate <td>
output for posts.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32721
git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:01:28 +00:00
Konstantin Obenland
ce16fd8dca
More semantic markup for the post formats metabox.
...
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.
Props joedolson, afercia.
Fixes #26160 .
Built from https://develop.svn.wordpress.org/trunk@32720
git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 09:09:25 +00:00
Jeremy Felt
0e76a2c570
Additional improvement to sites list table display
...
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.
See #32434 .
Built from https://develop.svn.wordpress.org/trunk@32719
git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 07:28:26 +00:00
Jeremy Felt
93ff65e677
Improve information displayed in a network's sites list table
...
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.
Props @ocean90.
Fixes #32434 .
Built from https://develop.svn.wordpress.org/trunk@32718
git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 06:50:25 +00:00
Helen Hou-Sandí
005d937ce2
List tables:
...
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.
props georgestephanis, stephdau.
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@32717
git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 01:46:27 +00:00
Konstantin Obenland
bafb008be1
When inline editing a post, reset password field to be editable by default.
...
The Quick Edit form is cloned and then populated with post-specific data. If the
previous post was private, the password field would continue to be disabled for
the next post.
Props afercia.
Fixes #32259 .
Built from https://develop.svn.wordpress.org/trunk@32716
git-svn-id: http://core.svn.wordpress.org/trunk@32686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 22:02:27 +00:00
Aaron Jorbin
82e8acd70b
Remove Truthy check from DO_NOT_UPGRADE_GLOBAL_TABLES
...
Some, but not all, of the checks for DO_NOT_UPGRADE_GLOBAL_TABLES just check if it is defined, so checking for truthiness could cause the issue to not be fully fixed.
In the words of Colonel Jessep: You can't handle the truth!
Introduced in [32714]
Fixes #32011
Built from https://develop.svn.wordpress.org/trunk@32715
git-svn-id: http://core.svn.wordpress.org/trunk@32685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 22:00:28 +00:00
Aaron Jorbin
d1586725d1
Add error if a user attempts to install WordPress with DO_NOT_UPGRADE_GLOBAL_TABLES defined
...
The install process runs through migrations to global tables, therefore we cannot install WordPress with this constant defined. This error message prevents a false success screen from being seen.
Fixes #32011 .
Props Oxymoron.
Built from https://develop.svn.wordpress.org/trunk@32714
git-svn-id: http://core.svn.wordpress.org/trunk@32684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 17:59:24 +00:00
Konstantin Obenland
6d56231da3
Sort screen options for meta boxes according to the meta box's priority.
...
Props swissspidy.
Fixes #32582 .
Built from https://develop.svn.wordpress.org/trunk@32707
git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 12:35:26 +00:00
Ella Iseulde Van Dorpe
8acda26129
Autoprefixer after autoprefixer-core 5.2 update
...
grunt-autoprefixer requires ^5.1.7, so this was automatically updated.
See #31700 .
Built from https://develop.svn.wordpress.org/trunk@32704
git-svn-id: http://core.svn.wordpress.org/trunk@32674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 20:08:24 +00:00
Helen Hou-Sandí
93b5a9a7fa
Nav menus: Hidden inputs do not need an ID, especially one that's already in use.
...
props sagarjadhav.
fixes #31816 .
Built from https://develop.svn.wordpress.org/trunk@32695
git-svn-id: http://core.svn.wordpress.org/trunk@32665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 15:36:27 +00:00
Konstantin Obenland
c20edc4df5
Remove title attributes in user list tables.
...
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.
Props afercia.
Fixes #32535 .
Built from https://develop.svn.wordpress.org/trunk@32694
git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 08:40:26 +00:00
Konstantin Obenland
5daf12dba4
Text improvements for screen readers in list table paginations.
...
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.
Props afercia, rianrietveld.
Fixes #32028 .
Built from https://develop.svn.wordpress.org/trunk@32693
git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 05:01:25 +00:00