Commit Graph

67 Commits

Author SHA1 Message Date
Andrew Nacin
94555444ab If two revisions were created at the same time, mark the one with the greater ID as current. Also avoid flagging autosaves as current. fixes #24782.
git-svn-id: http://core.svn.wordpress.org/trunk@24730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 14:10:33 +00:00
Andrew Nacin
8d9a830c3c Remove stray character.
git-svn-id: http://core.svn.wordpress.org/trunk@24726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-17 21:09:14 +00:00
Andrew Nacin
18a208af1b Inline docs for admin/includes/revision.php. props DrewAPicture, fixes #24742.
git-svn-id: http://core.svn.wordpress.org/trunk@24722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-17 20:39:35 +00:00
Mark Jaquith
24553b2f03 Improvements to output of revisions author data.
* Do not output "false" if avatars are disabled. props ocean90.
* Cache the author data separately to cut down on calls to `get_the_author_meta()` and `get_avatar()`. props nacin.

Fixes #24743.

git-svn-id: http://core.svn.wordpress.org/trunk@24708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-15 23:01:27 +00:00
Mark Jaquith
e8b9088c5f Revisions: Cleanup, bug fixes, refactoring, polish.
* Hide the tooltip initially.
* Fix a bug with routing.
* Further separate the Slider model and view, refactoring its code.
* More reliance on events than direct calls between areas.
* Smarter background diff loading (single mode). Loads the diffs closest to your position first.
* Removed a bunch of manual templating and `render()` methods. Now relies more on the WP Backbone Views functionality.
* include the requested `id` in `ensure:load`.
* new trigger: `ensure`, for `ensure()` attempts, regardless of whether they are already loaded.
* pass along a promise in both `ensure` and `ensure:load`.
* in `ensure`, remove requests for diffs we aready have

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 14:01:39 +00:00
Mark Jaquith
7cf1702442 Fix a PHP 5.4-ism that slipped in.
git-svn-id: http://core.svn.wordpress.org/trunk@24670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 07:26:11 +00:00
Mark Jaquith
ef8ff9efac Revisions: sort by date, not modified, to match revisions meta box.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 05:41:39 +00:00
Mark Jaquith
13a7d2a743 Revisions: Loading indicator, cleanup, bug fixes.
* Loading indicator when the user is waiting for a trip to the server.
* Bug fixes for diff priming.
* Fix the date display.
* Forget about local comparator, instead order by `modified` on the server.
* Initialize the frame model before the view (this was the source of a LOT of heartache).

git-svn-id: http://core.svn.wordpress.org/trunk@24667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 05:11:56 +00:00
Mark Jaquith
c44ce3b6e6 Revisions: real URLs and preloading of the requested diff.
* Real URLs are being used now, using pushState. `?revision={id}` or `?from={from}&to={to}`.
* Drop the redundant `action=edit` from the URLs (this is the default).
* The initial comparison is preloaded, whether a single revision or a compare-two situation.

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 22:56:48 +00:00
Andrew Nacin
25d9d478ac Compare GMT to GMT. see #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 20:57:47 +00:00
Andrew Nacin
bcd2644d92 Proper translation of '<time> ago' in revisions. props johnbillion, fixes #24721.
git-svn-id: http://core.svn.wordpress.org/trunk@24643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 16:15:18 +00:00
Mark Jaquith
35b08acc8d Pass back dateUnix (a unix timestamp) for better sorting of revisions in Backbone.
Props duck_. See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 19:21:25 +00:00
Daryl Koopersmith
590bf668e9 Revisions: Debounce fetching Diffs when revisions are updated.
Fixes navigation and casting bugs.

See #24425.


git-svn-id: http://core.svn.wordpress.org/trunk@24611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 09:57:58 +00:00
Daryl Koopersmith
2f9ef11796 Revisions: Reduce points where IDs are cast in JS. See #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 07:55:50 +00:00
Dominik Schilling
4fc5e70228 Revisions improvements
* Corrected routing behavior
* Simplified CSS for tooltips
* Compare two mode for RTL
* Support for posts without titles 

props adamsilverstein, ocean90. see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-06 10:48:14 +00:00
Dominik Schilling
2bf327f3b2 Revisions UI: Fix table colgroup (Say what?) for post titles when they haven't been changed. see #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-29 17:45:02 +00:00
Mark Jaquith
77abb9ff01 Cleanup of the revisions screen, both on the PHP API side, and the JS.
* Much simpler PHP API
* Cleaner and more Backbone-y JS API
* Consequently, does batch queries; this now scales up to hundreds of revisions

Currently missing, but much easier considering the cleaned up base:

* Compare two mode
* RTL

props koopersmith, nacin, adamsilverstein, ocean90. see #24425

git-svn-id: http://core.svn.wordpress.org/trunk@24520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-26 21:06:50 +00:00