Commit Graph

37611 Commits

Author SHA1 Message Date
desrosj
e80371660d Build/Test Tools: Create reusable workflow for parsing .version-support-*.json files.
This extracts the logic responsible for parsing the `.version-support-*.json` files and returning a list of supported PHP and MySQL versions for a given branch of WordPress into a reusable workflow so that other workflows can make use of the functionality without repeating code.

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59452


git-svn-id: http://core.svn.wordpress.org/trunk@58838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 17:00:21 +00:00
desrosj
b29834538e Bundled Theme: Pin schema version to rest of Twenty Twenty-Five.
All JSON files in the theme should be pinned to the appropriate schema version, not just `theme.json`.

Follow up to [59448].

Props im3dabasia1, poena.
Fixes #62455.
Built from https://develop.svn.wordpress.org/trunk@59451


git-svn-id: http://core.svn.wordpress.org/trunk@58837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 13:50:18 +00:00
cbravobernal
261373653c HTML API: Prevent fragment creation on close tag.
Prevent fragments from being created at tag closers.

Follow-up to [59444].

Props jonsurrell, bernhard-reiter.
Fixes #62357.

Built from https://develop.svn.wordpress.org/trunk@59450


git-svn-id: http://core.svn.wordpress.org/trunk@58836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 12:52:19 +00:00
mikachan
e0d58b3987 Editor: Warn about empty templates on the frontend for logged in users.
Adds a new function, `wp_render_empty_block_template_warning`, that renders a warning for logged-in users when a block template is empty.

Reviewed by get_dave, richtabor.
Props vcanales, mikachan, peterwilsoncc, richtabor, get_dave, mrfoxtalbot, matveb, arielmaidana, seifradwane, annezazu.
Fixes #62053.
Built from https://develop.svn.wordpress.org/trunk@59449


git-svn-id: http://core.svn.wordpress.org/trunk@58835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-22 10:57:19 +00:00
desrosj
04111ef54f Bundled Theme: Pin a theme.json schema version to Twenty Twenty-Five.
Each theme’s `theme.json` schema version should be pinned to the version that was valid at the time it was released.

Props im3dabasia1, poena, mukesh27.
Fixes #62455.
Built from https://develop.svn.wordpress.org/trunk@59448


git-svn-id: http://core.svn.wordpress.org/trunk@58834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-21 19:02:23 +00:00
Bernhard Reiter
ff3fde39ee HTML API: Add method to create fragment at node.
HTML Fragment parsing always happens with a context node, which may impact how a fragment of HTML is parsed. HTML Fragment Processors can be instantiated with a `BODY` context node via `WP_HTML_Processor::create_fragment( $html )`.

This changeset adds a static method called `create_fragment_at_current_node( string $html_fragment )`. It can only be called when the processor is paused at a `#tag`, with some additional constraints:

- The opening and closing tags must appear in the HTML input (no virtual tokens).
- No "self-contained" elements are allowed ( `IFRAME`, `SCRIPT`, `TITLE`, etc.).

If successful, the method will return a `WP_HTML_Processor` instance whose context is inherited from the node that the method was called from.

Props jonsurrell, bernhard-reiter, gziolo.
Fixes #62357.
Built from https://develop.svn.wordpress.org/trunk@59444


git-svn-id: http://core.svn.wordpress.org/trunk@58830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-21 13:29:18 +00:00
John Blackbourn
8f1dc00b4d Build/Test Tools: Improve the error message shown when fetching Twemoji fails.
This allows the full error message to be shown from the connection attempt instead of a generic error message.

Fixes #62382

Built from https://develop.svn.wordpress.org/trunk@59443


git-svn-id: http://core.svn.wordpress.org/trunk@58829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-21 13:18:19 +00:00
Joe McGill
134e355f13 Editor: Avoid unnecessary array_merge in WP_Style_Engine::parse_block_styles().
This adds an `! empty()` check for classnames and declarations to avoid calling array_merge() with an empty value.

Props mukesh27, ramonopoly, aaronrobertshaw.
Fixes #62317.

Built from https://develop.svn.wordpress.org/trunk@59442


git-svn-id: http://core.svn.wordpress.org/trunk@58828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 21:29:22 +00:00
desrosj
37c8e1ae21 Build/Test Tools: Correctly check for Dependabot.
This updates the conditions added in [59370] to skip unnecessary pull request comments when Dependabot is the opening contributor to check for the correct `github.actor` value.

Follow up to [59380].

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59441


git-svn-id: http://core.svn.wordpress.org/trunk@58827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 18:10:23 +00:00
desrosj
6efab4c237 Editor: update npm packages in trunk for 6.7.1.
Syncs Editor packages for WordPress 6.7.1 RC1. Includes the following PRs:

- https://github.com/WordPress/gutenberg/pull/66945
- https://github.com/WordPress/gutenberg/pull/66889
- https://github.com/WordPress/gutenberg/pull/67139 

Reviewed by desrosj.
Merges [59437] to trunk.

Props mmaattiiaass, ramonopoly, mamaduka, get_dave, poena, ntsekouras, mcsf, jsnajdr, 0mirka00, desrosj, joemcgill, cbravobernal, azaozz, room34, mayanktripathi32, im3dabasia1, jonsurrell.
Fixes #62478, #62447. 
Built from https://develop.svn.wordpress.org/trunk@59438


git-svn-id: http://core.svn.wordpress.org/trunk@58824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 16:20:31 +00:00
Sergey Biryukov
d37c855db1 I18N: Adjust translator comments in nav-menu.js.
Includes:
* Moving the comments directly above `wp.i18n._x()` so that they can be picked up properly.
* Simplifying the context to avoid unnecessarily translating the string twice for the same use case.
* Using the established translator comments format for consistency.

Follow-up to [59428].

See #62402.
Built from https://develop.svn.wordpress.org/trunk@59431


git-svn-id: http://core.svn.wordpress.org/trunk@58817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 11:22:19 +00:00
desrosj
c557605794 i18n: Account for load_*_textdomain() after JIT loading.
When `load_*_textdomain()` functions are called after WordPress has already attempted just-in-time loading of translations, nothing happens. 

This updates the related logic to retry translation loading when a custom path is set to ensure all translations are available.

Additionally, this also fixes cases where an `en_US.mo` file is provided with non-English strings to override the default language.

Follow up to [59157].

Props swissspidy, peterwilsoncc, desrosj, apermo, sergeybiryukov, wildworks, tigriweb, twvania, looswebstudio, stimul, audrasjb, finntown, bluantinoo, timwhitlock, albigdd.
See #62337.
Built from https://develop.svn.wordpress.org/trunk@59430


git-svn-id: http://core.svn.wordpress.org/trunk@58816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 02:50:24 +00:00
desrosj
85928dc39a Options, Meta APIs: Ensure duplicate salts are properly flagged.
Improvements were made in 6.7 to ensure that salts stored in the database were primed more efficiently.

The logic added to accomplish this suffered from an edge case where array indexes were unexpectedly missing when `wp_salt()` was called recursively.

Follow up to [58837].

Props juliobox, ankitkumarshah, dilipbheda, johnbillion, joemcgill, desrosj.
Fixes #62424.
Built from https://develop.svn.wordpress.org/trunk@59427


git-svn-id: http://core.svn.wordpress.org/trunk@58813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-20 01:39:19 +00:00
joedolson
41226f1164 Menus: i18n: Fix untranslatable strings in nav-menu.js.
Wrap three untranslatable strings in nav menus in JS translation functions.

Follow up to [59265].

Props juliemoynat, swissspidy, yogeshbhutkar, sergeybiryukov, desrosj, tobifjellner, audrasjb, joedolson.
Fixes #62402.
Built from https://develop.svn.wordpress.org/trunk@59426


git-svn-id: http://core.svn.wordpress.org/trunk@58812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 23:25:20 +00:00
Sergey Biryukov
e8741c53c8 Toolbar: Allow the Learn WordPress link to be localized.
The Learn WordPress website is supposed to automatically redirect to the correct locale according to the browser's language settings, however that may not work as expected in some cases.

This commit brings consistency with the other WordPress.org links, which can be localized as appropriate.

Follow-up to [56720].

Props timse201, ruturajraval2305, yogeshbhutkar, ajayghaghretiya-multidots, swissspidy, sabernhardt, im3dabasia1, mukesh27.
Fixes #62459.
Built from https://develop.svn.wordpress.org/trunk@59425


git-svn-id: http://core.svn.wordpress.org/trunk@58811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 22:18:21 +00:00
joedolson
70842372b1 Login: Revert selector change in login heading CSS.
In [59138], the login screens were updated to change the `h1` heading from the logo to screen-reader hidden text. Along with that HTML change, we changed the CSS selectors from `.login h1` to `.login .wp-login-logo`. This unnecessary change increased specificity and broke the CSS selectors used by a wide variety of plugins to replace the login logo.

Commit reverts the change in selector back to using the `.login h1` pattern.

Props leecollings, sabernhardt, im3dabasia1, roytanck, sailpete, joedolson. 
Fixes #62410.
Built from https://develop.svn.wordpress.org/trunk@59424


git-svn-id: http://core.svn.wordpress.org/trunk@58810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 21:24:22 +00:00
czapla
d54b7924ef HTML API: Use case insensitive tag_name comparison in ::next_tag.
The HTML API `::next_tag` method now performs case-insensitive matching when searching for tags by name. For example, searching for 'DIV' will match both '<div>' and '<DIV>' tags.

Props jonsurrell, dmsnell.
Fixes #62427.

Built from https://develop.svn.wordpress.org/trunk@59422


git-svn-id: http://core.svn.wordpress.org/trunk@58808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 16:05:17 +00:00
youknowriad
e09a15b011 Admin Color Scheme: Update the highlight color in the Modern color scheme.
In the Modern color scheme, the font color on hover in the admin bar is bright green. However, in the WordPress.org site itself, the color used is Blueberry 2. This commits aligns both colors on the more balanced Blueberry color.

Props fushar, Joen.
Fixes #62219.
Built from https://develop.svn.wordpress.org/trunk@59419


git-svn-id: http://core.svn.wordpress.org/trunk@58805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 08:02:16 +00:00
ramonopoly
70b4a18c97 Theme JSON: include block style variations in path only output of get_block_nodes
An `$include_node_paths_only` option to `get_block_nodes()` was introduced to improve performance.

When set to `true`, this option tells the function to only return paths, and not selectors, for consumers that only needed paths to style values.

For one of the conditional blocks, block style variations wasn't included.

This commit adds them to the array of paths following the existing model `$node[]['path' => [], 'variations' => ['path' => []]]`.

Follow-up to [61858].

Props aaronrobertshaw, ramonopoly.
Fixes #62399.



Built from https://develop.svn.wordpress.org/trunk@59418


git-svn-id: http://core.svn.wordpress.org/trunk@58804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-19 04:44:19 +00:00
Sergey Biryukov
c6e76c3c5b Users: Correct “Add New User” page reference on Network Settings screen.
Follow-up to [56515].

Props timse201.
Fixes #62458.
Built from https://develop.svn.wordpress.org/trunk@59417


git-svn-id: http://core.svn.wordpress.org/trunk@58803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 23:38:20 +00:00
czapla
c0baa82edc Interactivity API: Remove redundant server state from Interactivity Router
Remove the workaround for a bug that was fixed in https://github.com/WordPress/gutenberg/pull/66183. Previously, if the store was not initialized with a minimal navigation object, the interactivity-router script module would error.

Props jonsurrell, czapla, gziolo.
Fixes 62465#.

Built from https://develop.svn.wordpress.org/trunk@59416


git-svn-id: http://core.svn.wordpress.org/trunk@58802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 20:06:24 +00:00
Felix Arntz
a7dda35133 Media: Avoid images with sizes=auto to be displayed downsized in supporting browsers.
Based on the user agent stylesheet rules outlined in https://html.spec.whatwg.org/multipage/rendering.html#img-contain-size, images that have `sizes=auto` while applying `width: auto` or `width: fit-content` would be constrained to only 300px width.

This changeset overrides said user agent stylesheet rule with a much larger constraint, to avoid the problem.

Additionally, it introduces a filter `wp_img_tag_add_auto_sizes` which can be used to opt out of the functionality, as an additional measure.

Props joemcgill, flixos90, dooperweb, SirLouen, azaozz, mukesh27, apermo.
Fixes #62413.
See #61847, #62345.

Built from https://develop.svn.wordpress.org/trunk@59415


git-svn-id: http://core.svn.wordpress.org/trunk@58801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 19:52:19 +00:00
Andrew Ozz
6813017f32 Editor: Fix the JS to select, save, and update categories on the old Edit Post screen.
Props: charleslf, im3dabasia1, desrosj, dhruvang21, Zargarov, sainathpoojary, azaozz
Fixes: #62440
Built from https://develop.svn.wordpress.org/trunk@59414


git-svn-id: http://core.svn.wordpress.org/trunk@58800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 19:33:18 +00:00
desrosj
2c691c2fbd Media: Avoid running expensive logic twice using GD.
Support for uploading AVIF was added in [57524]. A new block of conditional logic was added determine which function should be used to create the new image file that resulted in these expensive functions being run twice.

This combines the two conditional logic to ensure the appropriate function is only run once regardless of format.

Props adamsilverstein, glynnquelch.
Fixes #62331.
Built from https://develop.svn.wordpress.org/trunk@59413


git-svn-id: http://core.svn.wordpress.org/trunk@58799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 18:05:18 +00:00
desrosj
74b593f2d2 Editor: Use sentence casing for “Call to action”.
This is more consistent with other strings and occurrences of this string.

Props juanfra, joen, narenin, mukesh27.
See #62414.
Built from https://develop.svn.wordpress.org/trunk@59412


git-svn-id: http://core.svn.wordpress.org/trunk@58798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 17:35:17 +00:00
cbravobernal
72a29cef78 HTML API: Fix normalized doctype pub/sys identifier quotes.
Changeset [59399] fixed missing DOCTYPEs in normalized HTML output. It missed an edge case where public and system identifiers may contain double quotes, in which case they must be quoted with single quotes.

This commit addresses that issue and adds tests.

Follow-up to [59399].

Props jonsurrell, luisherranz, apermo.
Fixes #62396.

Built from https://develop.svn.wordpress.org/trunk@59410


git-svn-id: http://core.svn.wordpress.org/trunk@58796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 13:07:17 +00:00
joedolson
5a2559365d Customizer: Fix layout issues in customizer accordions.
Adjust some CSS characteristics in the customizer accordions to avoid a slight horizontal scroll, allow the chevron icon to be part of the clickable control surface, and resolve a pre-existing padding issue allowing overflow on accordion headings.

Follow up to [59224].

Props laurelfulford, wildworks, domainsupport, sabernhardt, rcreators, desrosj, sainathpoojary. 
Fixes #62313, #62335.
Built from https://develop.svn.wordpress.org/trunk@59409


git-svn-id: http://core.svn.wordpress.org/trunk@58795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-18 02:55:20 +00:00
Sergey Biryukov
8f92dfad4d Tests: Add missing @covers tag for fetch_feed() tests.
Includes correcting the test class name as per the naming conventions.

Follow-up to [59382].

See #62280.
Built from https://develop.svn.wordpress.org/trunk@59408


git-svn-id: http://core.svn.wordpress.org/trunk@58794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-17 13:44:21 +00:00
Sergey Biryukov
df05a5564f Coding Standards: Escape attachment URL in wp-admin/async-upload.php.
Follow-up to [58279].

Props shyamkariya, pitamdey, nareshbheda, ketanniruke, desrosj.
Fixes #62434.
Built from https://develop.svn.wordpress.org/trunk@59407


git-svn-id: http://core.svn.wordpress.org/trunk@58793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-16 23:15:29 +00:00
Sergey Biryukov
ea47259795 Docs: Add missing commas in a few DocBlocks for various media functions.
Follow-up to [56416].

Props truptikanzariya.
Fixes #62433.
Built from https://develop.svn.wordpress.org/trunk@59406


git-svn-id: http://core.svn.wordpress.org/trunk@58792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-15 21:11:22 +00:00
John Blackbourn
9bc4fadffa Docs: Correct the spelling of silicon in the local development environment readme.
See #62281

Built from https://develop.svn.wordpress.org/trunk@59405


git-svn-id: http://core.svn.wordpress.org/trunk@58791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-14 16:46:20 +00:00
desrosj
ad2f51c90a Build/Test Tools: Correct upgrade testing workflow name.
The reusable upgrade testing workflow was renamed in [58165], but the event `paths` filters were not updated accordingly.

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59403


git-svn-id: http://core.svn.wordpress.org/trunk@58789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 19:13:14 +00:00
desrosj
cf3720d787 Build/Test Tools: Avoid starting the database twice.
The database container is started when the `services` are initially set up. Having a separate step for this sometimes introduces unexpected failures for an unknown reason.

Props johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@59402


git-svn-id: http://core.svn.wordpress.org/trunk@58788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 19:08:20 +00:00
Sergey Biryukov
a20a5a4516 Coding Standards: Consistently escape URLs in wp-admin/themes.php.
Includes:
* Wrapping long lines for better readability.
* Bringing some consistency to the placement of `href` and `aria-label` attributes.
* Adding missing `aria-label` attributes for Live Preview links.

Follow-up to [26726], [52020], [51083].

Props patelketan, sainathpoojary, SergeyBiryukov.
Fixes #62405.
Built from https://develop.svn.wordpress.org/trunk@59400


git-svn-id: http://core.svn.wordpress.org/trunk@58786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 12:27:12 +00:00
Bernhard Reiter
8f5eb7a835 HTML API: Include doctype in full parser serialize.
Output DOCTYPE when calling `WP_HTML_Processor::serialize` on a full document that includes a DOCTYPE.

The DOCTYPE should be included in the serialized/normalized HTML output as it has an impact in how the document is handled, in particular whether the document should be handled in quirks or no-quirks mode.

This only affects the serialization of full parsers at this time because DOCTYPE tokens are currently ignored in all possible fragments. The omission of the DOCTYPE is subtle but can change the serialized document's quirks/no-quirks mode.

Props jonsurrell.
Fixes #62396.
Built from https://develop.svn.wordpress.org/trunk@59399


git-svn-id: http://core.svn.wordpress.org/trunk@58785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 12:20:15 +00:00
cbravobernal
9a99674204 Interactivity API: Allow missing state negation on server
Aligns on the behavior of the negation operator with directives to missing paths in client and in server.

With a directive like the following:
{{{
<div data-wp-bind--hidden="!state.missing.property">
	This should be hidden by the <code>hidden</code> attribute.
</div>
}}}

Both server and client will return with this fix:
{{{
<div data-wp-bind--hidden="!state.missing.property" hidden="">
	This should be hidden by the <code>hidden</code> attribute.
</div>
}}}

Props jonsurrell, luisherranz.
Fixes #62374.


Built from https://develop.svn.wordpress.org/trunk@59398


git-svn-id: http://core.svn.wordpress.org/trunk@58784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 11:19:18 +00:00
desrosj
3ba197a255 Build/Test Tools: Run upgrade tests against 6.7.
Now that 6.7 is generally available, the upgrade tests no longer need to be run against a pre-release version.

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59397


git-svn-id: http://core.svn.wordpress.org/trunk@58783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-13 00:37:19 +00:00
desrosj
d826bdbb7c Build/Test Tools: Prevent orphaned Docker containers.
This updates certain local Docker environment commands to include `--rm`, which instructs `docker compose` to remove the container after running the specified scripts.

Previously only the installation script contained `--rm`. But running `test:php`, `env:start`, or `env:cli` resulted in the container remaining.

Props johnbillion.
Fixes #62395.
Built from https://develop.svn.wordpress.org/trunk@59393


git-svn-id: http://core.svn.wordpress.org/trunk@58779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 17:46:21 +00:00
Bernhard Reiter
0c6d68448b HTML API: Expect closer on foreign content void lookalike elements.
Ensure that `expects_closer` returns `false` on tags that look like void HTML tags, but are actually ''not'' void tags in foreign content.

Props jonsurrell, bernhard-reiter.
Fixes #62363.
Built from https://develop.svn.wordpress.org/trunk@59392


git-svn-id: http://core.svn.wordpress.org/trunk@58778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 12:58:16 +00:00
Bernhard Reiter
0be8a89a8f HTML API: Ensure that full processor can seek to earlier bookmarks.
When the HTML Processor seeks to an earlier place, it returns the the beginning of the document and proceeds forward until it reaches the appropriate location. This requires resetting internal state so that the processor can correctly proceed from the beginning of the document.

The seeking reset logic was not adapted to account for the full processor (i.e. when created via `WP_HTML_Processor::create_full_parser()`). This change updates the seek logic to account for the full and fragment parsers as well as other state that has been introduced in the interim and should be reset.

Props jonsurrell, dmsnell, westonruter, mi5t4n.
Fixes #62290.
Built from https://develop.svn.wordpress.org/trunk@59391


git-svn-id: http://core.svn.wordpress.org/trunk@58777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 10:32:17 +00:00
poena
c05b42ec1e Twenty Twenty: Correct the border style of the pull quote block in the editor.
This change makes the border of the pull quote block visible in the editor when the user selects a border color or thickness,
by setting the default border style to solid.

Props nidhidhandhukiya, ugyensupport, dhruvang21, sabernhardt, divyeshk71, poena.
Fixes #62301.
Built from https://develop.svn.wordpress.org/trunk@59390


git-svn-id: http://core.svn.wordpress.org/trunk@58776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 05:46:19 +00:00
ramonopoly
3712752f76 Mime Types: support uploading wav files in Firefox
When uploading `wav` files in the editor, Chrome and other browsers identify the mime type of the file as `audio/wav`. Firefox, however, identifies the mime type as `audio/x-wav`.

This commit updates the `'wav'` mime type key in `wp_get_mime_types()` to support `x-wav` so that uploading wav files work in Firefox. Previously, the editor reported an unsupported mime type error.

Props imranh920, ramonopoly.
Fixes #61948.



Built from https://develop.svn.wordpress.org/trunk@59389


git-svn-id: http://core.svn.wordpress.org/trunk@58775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-12 00:53:18 +00:00
Sergey Biryukov
417fb21204 Coding Standards: Use esc_url() for comment author URL in Edit Comment form.
Follow-up to [5543], [9436], [11104], [11204], [11739].

Props hiteshhuptechweb, sabernhardt.
Fixes #62373.
Built from https://develop.svn.wordpress.org/trunk@59388


git-svn-id: http://core.svn.wordpress.org/trunk@58774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-11 20:43:19 +00:00
davidbaumwald
e2025a078c Upgrade/Install: Update the $_old_files array for 6.7.
Props pbiron, peterwilsoncc, fazyshah.
Fixes #62150.
Built from https://develop.svn.wordpress.org/trunk@59386


git-svn-id: http://core.svn.wordpress.org/trunk@58772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-11 19:06:18 +00:00
desrosj
883e20e3dd Feeds: Avoid fatal error with empty blog_charset value.
After the SimplePie library was updated to version `1.8.0` in [59141], an edge case has been discovered where a fatal error can encountered if the `blog_charset` option is missing or empty.

In `fetch_feed()`, this option is retrieved using `get_option()` instead of `get_bloginfo( ‘charset’ )`. The latter will detect this scenario and apply a default value of `UTF-8` and is already used interchangeably throughout Core. This switches to `get_bloginfo( ‘charset’ )` instead to prevent this edge case.

Props david.binda, davidbaumwald, SergeyBiryukov, sabernhardt, azaozz, peterwilsoncc.
Fixes #62354.
Built from https://develop.svn.wordpress.org/trunk@59382


git-svn-id: http://core.svn.wordpress.org/trunk@58768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-11 17:50:17 +00:00
Peter Wilson
818baef807 Media: Include image update missed in [59379].
"We missed you", hissed the lovecats.
-- The Cure.

See #62359.


Built from https://develop.svn.wordpress.org/trunk@59380


git-svn-id: http://core.svn.wordpress.org/trunk@58766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-10 22:45:17 +00:00
Peter Wilson
c5bf14f31b Media: Remove dimension suffix from full size converted HEIC images.
Removes the dimension suffix, eg `-1000x1000` from the file name of full size images automatically converted from HEIC to JPEGs by WordPress. Introduces unit tests for the default conversion of images and customized conversion settings via the `image_editor_output_format` filter.

Follow up to [58849], [58942], [59317], [59346], [59366]

Props mukesh27, peterwilsoncc, azaozz, apermo, flixos90, ironprogrammer.
Fixes #62359.
See #53645, #62305.



Built from https://develop.svn.wordpress.org/trunk@59379


git-svn-id: http://core.svn.wordpress.org/trunk@58765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-10 21:41:13 +00:00
Sergey Biryukov
f7fc754220 Docs: Add file header DocBlock for wp-signup.php.
Follow-up to [https://mu.trac.wordpress.org/changeset/543 mu:543], [https://mu.trac.wordpress.org/changeset/557 mu:557], [12603].

Props jdahir0789, apermo, aboelfotoh.
Fixes #62254.
Built from https://develop.svn.wordpress.org/trunk@59378


git-svn-id: http://core.svn.wordpress.org/trunk@58764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-10 21:36:19 +00:00
Sergey Biryukov
8adbd5815c Coding Standards: Ensure cookie expiration value is an integer in wp_update_user().
This addresses an issue in `wp_update_user()`, where `time()` is subtracted from the `$logged_in_cookie['expiration']` of type `string`.

Follow-up to [29043].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59377


git-svn-id: http://core.svn.wordpress.org/trunk@58763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-09 16:30:19 +00:00
Sergey Biryukov
fada226ed4 Coding Standards: Remove unnecessary isset() from xmlrpc.php.
This removes a redundant `isset( $HTTP_RAW_POST_DATA )` from `xmlrpc.php`, as the variable is already set in the code block immediately preceding the affected line.

Follow-up to [3498], [5445], [47926].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59376


git-svn-id: http://core.svn.wordpress.org/trunk@58762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-08 15:52:18 +00:00
Peter Wilson
08fc6012f1 Help/About: Update the about page images for WordPress 6.7.
Updates the about page images with more colourful imagery.

Props sfougnier, fcoveram, Joen, davidbaumwald, ryelle.
Fixes #61961.

Built from https://develop.svn.wordpress.org/trunk@59374


git-svn-id: http://core.svn.wordpress.org/trunk@58760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-08 03:55:19 +00:00
Sergey Biryukov
1a6e117084 Coding Standards: Ensure $current cookie time is int in wp_user_settings().
This addresses an issue where a string (`$current`) is compared to an integer (`$last_saved`). The issue is resolved by casting the results of `preg_replace()` to type `int` when `$current` is defined.

Follow-up to [8784], [10083], [25109].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59373


git-svn-id: http://core.svn.wordpress.org/trunk@58759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-07 23:47:16 +00:00
desrosj
1013750a45 Build/Test Tools: Skip pull request comments for Dependabot.
Currently, Dependabot is configured to open pull requests when updates to 3rd-party GitHub Actions become available.

It does a great job at this. Thank you very much, 🤖 Mr. Dependabot Roboto.

Some of the automated comments for pull requests are not relevant to PRs opened by Dependabot. Despite how good of a robot it is, Dependabot will never open a Trac ticket, so it's pointless to ask for one.

Also, since it’s currently only configured to watch GitHub Actions for updates, there will never be a need to test Dependabot PRs in Playground. If instructed to monitor npm dependencies in the future, this comment can be added back as those packages can directly affect the built software that is distributed.

Props johnbillion.
See #62221.
Built from https://develop.svn.wordpress.org/trunk@59370


git-svn-id: http://core.svn.wordpress.org/trunk@58756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-07 16:23:16 +00:00
get_dave
a9b1b36403 Editor: Update packages for 6.7 RC 4
Syncs @wordpress/* packages to the wp-6.7 npm tag.

Props get_dave, mikachan, gziolo, kevin940726, jonsurrell, jsnajdr
Built from https://develop.svn.wordpress.org/trunk@59368


git-svn-id: http://core.svn.wordpress.org/trunk@58754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-07 15:16:24 +00:00
Felix Arntz
9da71e3d7a Media: Only mark an image as requiring conversion if the output format differs from the input format.
Follow up to [59317] and [59346].

Props adamsilverstein, peterwilsoncc.
See #62305.

Built from https://develop.svn.wordpress.org/trunk@59366


git-svn-id: http://core.svn.wordpress.org/trunk@58752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-06 22:35:18 +00:00
Weston Ruter
ba9fe05e26 HTML API: Improve private method name used by WP_HTML_Processor::next_token().
This renames the private `_next_token` method to `next_visitable_token`. It also removes irrelevant assertions from the unit test.

Follow-up to [59285].

Props dmsnell, jonsurrell, westonruter.
See #62269.

Built from https://develop.svn.wordpress.org/trunk@59364


git-svn-id: http://core.svn.wordpress.org/trunk@58750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-06 19:24:20 +00:00
desrosj
3a4341abf4 Bundled Themes: Sync some minor fixes for Twenty Twenty-Five.
This merges several minor improvements to patterns in Twenty Twenty-Five.

A full list of changes can be found on GitHub: e7612e3cb3...b8c032e43c.

Props juanfra.
Fixes #62351.
Built from https://develop.svn.wordpress.org/trunk@59362


git-svn-id: http://core.svn.wordpress.org/trunk@58748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-06 16:20:16 +00:00
Sergey Biryukov
1920c58314 Editor: Correct the number of arguments for WP_HTML_Tag_Processor::get_tag().
This resolves an issue with `::get_tag()` being called in `WP_Block::replace_html()` with an extra argument, as the method accepts no arguments.

Follow-up to [57514].

Props justlevine, mukesh27.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59361


git-svn-id: http://core.svn.wordpress.org/trunk@58747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-06 12:05:15 +00:00
ramonopoly
16f4229d09 Performance: reuse block metadata in WP_Theme_JSON::get_valid_block_style_variations()
In `WP_Theme_JSON::get_valid_block_style_variations()`, the method was calling `self::get_blocks_metadata()` even though the metadata was already retrieved in the parent function. This update reuses the existing block metadata instead of calling it again.  

A new optional parameter, `$blocks_metadata`, has been added to the function, allowing it to use pre-fetched metadata when available, improving efficiency.  

Fewer `self::get_blocks_metadata()` calls mean faster processing, especially in themes with many blocks.

Props mukesh27, ramonopoly, aaronrobertshaw, flixos90.
Fixes #62291.



Built from https://develop.svn.wordpress.org/trunk@59359


git-svn-id: http://core.svn.wordpress.org/trunk@58745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-06 00:44:15 +00:00
Andrew Ozz
a739bf28a1 Media: Fix variable name in wp_check_filetype_and_ext().
Props peterwilsoncc.
See #62272.
Built from https://develop.svn.wordpress.org/trunk@59358


git-svn-id: http://core.svn.wordpress.org/trunk@58744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-06 00:39:18 +00:00
Sergey Biryukov
f1ea02c64e Coding Standards: Use WP_User_Query::get_results() instead of a private property.
This resolves an issue where the private property `WP_User_Query::$results` is accessed directly in `WP_REST_Users_Controller::get_items()` instead of via the `::get_results()` method.

Follow-up to [38832].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59357


git-svn-id: http://core.svn.wordpress.org/trunk@58743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-05 23:09:20 +00:00
desrosj
67e72c6e74 Build/Test Tools: Add script for generating code coverage report.
This adds documentation for how to generate code coverage reports to the README.md file.

`test:coverage` has also been added as an npm script to make it easier to generate a report using the local Docker environment. The script will generate an HTML, PHP, and text report file.

Props pbearne, hellofromTonya, netweb.
Fixes #53414.
Built from https://develop.svn.wordpress.org/trunk@59356


git-svn-id: http://core.svn.wordpress.org/trunk@58742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-05 20:01:18 +00:00
desrosj
ca1f54722a Build/Test Tools: Run test coverage when PHPunit workflow changes.
[59287] updated the test coverage workflow to make use of the reusable PHPUnit workflow logic to prevent having duplicate code. The workflow should be run when the reusable file is updated to confirm any changes made work as expected.

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59355


git-svn-id: http://core.svn.wordpress.org/trunk@58741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-05 18:12:18 +00:00
desrosj
7a5309da64 Build/Test Tools: Update 3rd-party GitHub Actions.
This updates the following GitHub Actions to their latest versions:
- `wow-actions/welcome`
- `actions/setup-node`
- `actions/cache`

See #62221.
Built from https://develop.svn.wordpress.org/trunk@59354


git-svn-id: http://core.svn.wordpress.org/trunk@58740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-05 18:02:20 +00:00
desrosj
a78846dcd0 Bundled Themes: Update Twenty Twenty-Five for 6.7 RC 3.
This merges the latest improvements to the Twenty Twenty-Five theme from GitHub into WordPress-Develop for 6.7 RC 3.

A full list of changes can be found on GitHub: b6f4ee2e57...b5b0475f6a.

Props juanfra.
See #62343.
Built from https://develop.svn.wordpress.org/trunk@59348


git-svn-id: http://core.svn.wordpress.org/trunk@58734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-05 14:02:15 +00:00
get_dave
364a6c50a0 Editor: Update packages for 6.7 RC 3
Syncs @wordpress/* packages to the wp-6.7 npm tag.

Props kevin940726, get_dave, youknowriad

Close #62321.
Built from https://develop.svn.wordpress.org/trunk@59347


git-svn-id: http://core.svn.wordpress.org/trunk@58733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-05 12:59:25 +00:00
Andrew Ozz
310a481b66 Media: Better variable name and some docs fixes for the new wp_get_image_editor_output_format().
Props peterwilsoncc, apermo, azaozz.
See #62305.
Built from https://develop.svn.wordpress.org/trunk@59346


git-svn-id: http://core.svn.wordpress.org/trunk@58732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-05 04:09:18 +00:00
Peter Wilson
e81661e92d Bundled Themes: Bump default theme versions for release with 6.7.
This updates the version of each default theme to the following versions:

* Twenty Ten: 4.3
* Twenty Eleven: 4.8
* Twenty Twelve: 4.4
* Twenty Thirteen: 4.3
* Twenty Fourteen: 4.1
* Twenty Fifteen: 3.9
* Twenty Sixteen: 3.4
* Twenty Seventeen: 3.8
* Twenty Nineteen: 3.0
* Twenty Twenty: 2.8
* Twenty Twenty-One: 2.4
* Twenty Twenty-Two: 1.9
* Twenty Twenty-Three: 1.6
* Twenty Twenty-Four: 1.3

These versions will released in coordination with WordPress 6.7.

Props sh4lin, sabernhardt, mukesh27, chaion07.
Fixes #62034.





Built from https://develop.svn.wordpress.org/trunk@59344


git-svn-id: http://core.svn.wordpress.org/trunk@58730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-04 23:59:20 +00:00
Sergey Biryukov
ea4d309d36 Script Loader: Correct the number of arguments passed to WP_Styles::get_etag().
This fixes an issue with the usage of the new `$wp_styles->get_etag()` method in `wp-admin/load-styles.php`, where `$wp_version` is passed as the first argument instead of `$load` being used as the ''only'' argument.

Follow-up to [58935].

Props justlevine, mukesh27, swissspidy.
See #52217, #61485.
Built from https://develop.svn.wordpress.org/trunk@59341


git-svn-id: http://core.svn.wordpress.org/trunk@58727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-04 15:51:17 +00:00
Sergey Biryukov
5d262aaf83 Coding Standards: Use explicit returns in WP_Site_Health_Auto_Updates::test_*().
This commit corrects several instances of `test_*()` methods potentially returning `void` instead of their documented return types.

Since these methods are public, `null` is used to represent a passed test for backward compatibility with the coercion of the previously-returned `void`. Previous usage of `false` is preserved.

Includes updating some `@return` tags for clarity.

Follow-up to [44986], [46276], [49927].

Props justlevine, apermo, SergeyBiryukov.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59340


git-svn-id: http://core.svn.wordpress.org/trunk@58726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-04 15:25:17 +00:00
kevin940726
b9603f6388 Editor: Update packages for 6.7 RC 3
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag.

Props kevin940726, get_dave.

Close #62321.


Built from https://develop.svn.wordpress.org/trunk@59339


git-svn-id: http://core.svn.wordpress.org/trunk@58725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-04 13:04:31 +00:00
ramonopoly
fd6357ae7b Theme JSON Resolver: remove theme json merge in resolve_theme_file_uris
This commit affects `WP_Theme_JSON_Resolver::resolve_theme_file_uris()`.

When setting resolved URIs in an incoming theme json object, this commit removes the unnecessary call to `WP_Theme_JSON->merge()`. 

Why? `WP_Theme_JSON_Resolver::resolve_theme_file_uris()` only needs to set values for paths in the raw theme json object. It can then return a new theme object based on the updated JSON source. There's no need for a full and possibly expensive merge.

Follow-up to [61588].

Props ramonopoly, aaronrobertshaw, andrewserong.
Fixes #62329.


Built from https://develop.svn.wordpress.org/trunk@59338


git-svn-id: http://core.svn.wordpress.org/trunk@58724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-04 02:34:16 +00:00
Sergey Biryukov
2dfcb9ea56 Coding Standards: Explicitly return false in magic __isset() methods.
This commit fixes an issue where some magic `__isset()` methods were potentially returning `void` (if the prop is not in an allow-listed array of fields) instead of an explicit boolean `false`.

Addressed methods:
* `WP_Comment::__isset()`
* `WP_Query::__isset()`

Follow-up to [28523], [31151], [34583], [34599].

Props justlevine.
See #52217.
Built from https://develop.svn.wordpress.org/trunk@59337


git-svn-id: http://core.svn.wordpress.org/trunk@58723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-03 23:03:19 +00:00
Sergey Biryukov
5ef0c89c61 Docs: Add missing void to DocBlock @return types.
This commit adds missing `void` return types to (parent) methods that can ''explicitly'' return `void` as one of their conditional paths.

Addressed methods:
* `WP_Privacy_Requests_Table::column_status()`
* `WP_Recovery_Mode::handle_error()`
* `WP_Widget::form()` — unlike the others, it's the ''child'' classes that return `void` when the method is correctly implemented.

Note: `@return void` (where `void` is the single type returned) should not be used outside the default bundled themes and the PHP compatibility shims included in WordPress Core, as per the [https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/ documentation standards].

Follow-up to [30382], [42967], [43256], [44973], [45448].

Props justlevine.
See #52217, #62281.
Built from https://develop.svn.wordpress.org/trunk@59336


git-svn-id: http://core.svn.wordpress.org/trunk@58722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-02 15:01:19 +00:00
ramonopoly
3026f3f46d Theme JSON: replace top-level background style objects on merge
This commit fixes an omission in the logic of `WP_Theme_JSON::merge()` where top-level background image style objects are not replaced, rather they are merged. Because background images are self contained objects, their properties are unique and should not be merged. Blocks are already catered for via `WP_Theme_JSON::get_block_nodes()`.

Follow-up to [61858].

Props ramonopoly, andrewserong.
Fixes #62328.



Built from https://develop.svn.wordpress.org/trunk@59335


git-svn-id: http://core.svn.wordpress.org/trunk@58721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-01 05:26:19 +00:00
Sergey Biryukov
91822bf70c Docs: Correct @param type in fix_phpmailer_messageid().
Follow-up to [48033].

Props justlevine.
See #52217, #62281.
Built from https://develop.svn.wordpress.org/trunk@59334


git-svn-id: http://core.svn.wordpress.org/trunk@58720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-11-01 00:10:17 +00:00
Sergey Biryukov
9adf2cf437 Docs: Correct @param tag in untrailingslashit() to match the parameter name.
Follow-up to [54927].

Props justlevine.
See #52217, #62281.
Built from https://develop.svn.wordpress.org/trunk@59333


git-svn-id: http://core.svn.wordpress.org/trunk@58719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-31 23:26:15 +00:00
kevin940726
1522e2f001 Editor: Update packages for 6.7 RC 3
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag.

Props kevin940726, ramonopoly, andrewserong.

Built from https://develop.svn.wordpress.org/trunk@59330


git-svn-id: http://core.svn.wordpress.org/trunk@58716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-31 04:09:28 +00:00
Peter Wilson
74cf68a167 Help/About: Add images to the About page.
Updates the images in the About page source with the final versions on the w.org CDN.

Props ryelle, joen.
See #61961.



Built from https://develop.svn.wordpress.org/trunk@59329


git-svn-id: http://core.svn.wordpress.org/trunk@58715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-31 00:13:18 +00:00
Sergey Biryukov
2a96d5f4e3 Docs: Correct DocBlock formatting in wp-includes/class-wp-theme-json.php.
Follow-up to [52049], [54118], [54162], [55008], [55349], [55959], [55986], [56058], [57496], [58354], [58413].

Props mukesh27, ramonopoly.
See #62279.
Built from https://develop.svn.wordpress.org/trunk@59328


git-svn-id: http://core.svn.wordpress.org/trunk@58714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-30 23:52:17 +00:00
Peter Wilson
f17b845a78 Tests/Build tools: Only fail importer tests if plugin is missing.
Reverts an earlier change to the test suite in which the PHPUnit tests could not run if the importer plugin was not available.

This update allows the test suite to run and will fail importer tests if the plugin is not available. 

Follow up to r59085.

Props peterwilsoncc, azaozz.
See #62325.


Built from https://develop.svn.wordpress.org/trunk@59326


git-svn-id: http://core.svn.wordpress.org/trunk@58712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-30 23:29:19 +00:00
Peter Wilson
844fe5cf06 Taxonomy: Remove count references from WP_Term_Query.
Remove further documentation and a code reference to the unsupported `count` argument within `WP_Term_Query`. 

Follow up to [59261].

Props johnbillion.
Fixes #61094

Built from https://develop.svn.wordpress.org/trunk@59325


git-svn-id: http://core.svn.wordpress.org/trunk@58711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-30 22:34:19 +00:00
Sergey Biryukov
7b9673722e Comments: Use a more precise check for disallowed keys on filtered comment data.
The previous approach of running `wp_allow_comment()` twice could have unintended consequences, e.g. the `check_comment_flood` action was also triggered twice, which might lead to false-positive identification of comment flood in case there is some custom callback hooked to it, which is not expecting identical data seeing twice.

This commit introduces a new function, `wp_check_comment_data()`, to specifically check for disallowed content before and after comment data is filtered.

Follow-up to [59267].

Props david.binda, SergeyBiryukov.
See #61827.
Built from https://develop.svn.wordpress.org/trunk@59319


git-svn-id: http://core.svn.wordpress.org/trunk@58705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-29 15:38:19 +00:00
kevin940726
ccd2ab7f3f Editor: Update packages for 6.7 RC 2
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag.

Props kevin940726, aaronrobertshaw.
See #62309.

Built from https://develop.svn.wordpress.org/trunk@59318


git-svn-id: http://core.svn.wordpress.org/trunk@58704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-29 07:33:25 +00:00
Andrew Ozz
c53b87650b Media: Fix converting of all HEIC/HEIF images to JPEGs after uploading regardless of dimensions.
Props ironprogrammer, adamsilverstein, azaozz.
Fixes #62305.
Built from https://develop.svn.wordpress.org/trunk@59317


git-svn-id: http://core.svn.wordpress.org/trunk@58703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-29 06:01:19 +00:00
ramonopoly
35264ca89c Global styles: preload /global-styles endpoint responses
This commit fixes a regression whereby requests to global styles endpoints were not being preloaded, resulting in several requests being fired clientside unnecessarily.  

For performance reasons, we  preload the requests so that the data is in the editor store and ready to use straight away.  

The outcome is that the editor loads more quickly.

Follow-up to [62042].

Props ellatrix, ramonopoly, apermo, peterwilsoncc.
Fixes #62315.


Built from https://develop.svn.wordpress.org/trunk@59316


git-svn-id: http://core.svn.wordpress.org/trunk@58702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-29 03:13:19 +00:00
Andrew Ozz
152661c1e7 Media: Fix uploading of .heic images.
- Adds support for all HEIC/HEIF mime types: `image/heic`, `image/heif`, `image/heic-sequence`, and `image/heif-sequence`.
- Introduces `wp_is_heic_image_mime_type()`.

Props swissspidy, adamsilverstein, debarghyabanerjee, ironprogrammer, peterwilsoncc, apermo, azaozz.
Fixes #62272.
Built from https://develop.svn.wordpress.org/trunk@59315


git-svn-id: http://core.svn.wordpress.org/trunk@58701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-29 01:12:17 +00:00
Peter Wilson
c09e1c0acd Bundled Themes: Update Twenty Twenty-Five for 6.7 RC 2.
This merges the latest improvements to the Twenty Twenty-Five theme from GitHub into WordPress-Develop for 6.7 RC 2

A full list of changes can be found on GitHub: [7dfa99f15b...b5b0475f6a WordPress/twentytwentyfive@7dfa99f1...b5b0475f].

Props juanfra, poena.
See #62310.



Built from https://develop.svn.wordpress.org/trunk@59314


git-svn-id: http://core.svn.wordpress.org/trunk@58700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-29 00:02:18 +00:00
Sergey Biryukov
52f872f0fc Users: Set correct default value for $user_login in retrieve_password().
This resolves a "passing null to non-nullable" deprecation notice on PHP 8.1+:
{{{
Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
}}}

Follow-up to [50129], [54477].

Props afragen, peterwilsoncc, SergeyBiryukov.
Fixes #62298.
Built from https://develop.svn.wordpress.org/trunk@59312


git-svn-id: http://core.svn.wordpress.org/trunk@58698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-28 20:05:19 +00:00
kevin940726
5c3ffeb549 Editor: Update packages for 6.7 RC 2
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag.

Props kevin940726, peterwilsoncc.
See #62309.

Built from https://develop.svn.wordpress.org/trunk@59307


git-svn-id: http://core.svn.wordpress.org/trunk@58693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-28 04:33:29 +00:00
Peter Wilson
a17aba82df Revisions: Fix typo in navigation help text.
Fixes a typo in the a11y helper text explaining how to navigate revisions. "Change revision by using the left and arrow keys" becomes "Change revision by using the left and right arrow keys".

Follow up to [59225].

Props pedromendonca, sabernhardt, fierevere, swissspidy.
Fixes #62306.



Built from https://develop.svn.wordpress.org/trunk@59306


git-svn-id: http://core.svn.wordpress.org/trunk@58692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-28 00:31:21 +00:00
Sergey Biryukov
787ca6cd53 Tests: Use better domain for HTTP API invalid hostname test.
The previous domain that was used to test for a host whose IPv4 address cannot be resolved, `exampleeeee.com`, got registered and has an A-record now, so it's not invalid anymore.

`.invalid` is intended for use in online construction of domain names that are sure to be invalid and which it is obvious at a glance are invalid.

Reference: [https://datatracker.ietf.org/doc/html/rfc2606#section-2 Reserved Top Level DNS Names: TLDs for Testing, & Documentation Examples].

Follow-up to [52084], [58384], [58388].

Props sippis, johnbillion, MattyRob, swissspidy.
Fixes #62303.
Built from https://develop.svn.wordpress.org/trunk@59293


git-svn-id: http://core.svn.wordpress.org/trunk@58685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-27 19:05:18 +00:00
Sergey Biryukov
2bc86e1ab1 Coding Standards: Correct alignment in dropdown_cats().
Follow-up to [58284].

See #62279.
Built from https://develop.svn.wordpress.org/trunk@59292


git-svn-id: http://core.svn.wordpress.org/trunk@58684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-26 21:45:17 +00:00
Sergey Biryukov
aed49756e0 Docs: Adjust comments about set_time_limit() per the documentation standards.
Includes splitting long comments into multiple lines and moving a few comments above the `function_exists()` check for more consistent placement.

Follow-up to [59039], [59288].

See #62281.
Built from https://develop.svn.wordpress.org/trunk@59291


git-svn-id: http://core.svn.wordpress.org/trunk@58683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-25 20:26:20 +00:00
Peter Wilson
db2845d2a0 Site Health: Update inline docs following refactor of debug data.
Updates the inline docs following the modularization of the `WP_Debug_Data`.

Props kebbet, desrosj, apermo.
Fixes #61648.


Built from https://develop.svn.wordpress.org/trunk@59290


git-svn-id: http://core.svn.wordpress.org/trunk@58682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-25 01:20:17 +00:00
Peter Wilson
c2441a3d71 Bundled Themes: Provide instructions for updating comment block in TT2.
Adds instructions to the Twenty Twenty-Two readme file for updating the comment block from the legacy version to the newer version introduced in WordPress 6.1.

As Twenty Twenty-Two supports WordPress version prior to 6.1, the legacy comment block is used by default.

Props desrosj, jeffpaul, joedolson, mikachan, mrfoxtalbot, mukesh27, poena, ryokuhi, sabernhardt, thrijith.
Fixes #56496.


Built from https://develop.svn.wordpress.org/trunk@59289


git-svn-id: http://core.svn.wordpress.org/trunk@58681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-25 00:23:21 +00:00
Sergey Biryukov
11dfb2d162 Revisions: Set PHP time limit when generating revision diffs vis Ajax.
This aims to avoid hanging PHP processes if a plugin inadvertently attempts to request a large number of revision diffs.

Follow-up to [24520], [24707], [59039].

Props madpeter, lovesoni1999, debarghyabanerjee, pbearne, desrosj, SergeyBiryukov.
Fixes #49291.
Built from https://develop.svn.wordpress.org/trunk@59288


git-svn-id: http://core.svn.wordpress.org/trunk@58680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-25 00:00:20 +00:00
desrosj
269aa32b13 Build/Test Tools: Use the reusable PHPUnit test workflow for coverage.
This updates the Test Coverage workflow to make use of the reusable PHPUnit test workflow to avoid having duplicate code.

`concurrency` has also been configured for the workflow, and 4 test jobs have been consolidated into 2.

Props jrf.
Fixes #62296.
Built from https://develop.svn.wordpress.org/trunk@59287


git-svn-id: http://core.svn.wordpress.org/trunk@58679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-24 15:09:17 +00:00
Peter Wilson
1809b18404 Editor: Update Google Fonts API endpoint for WordPress 6.7.
Updates the Google Fonts API to use the URL `https://s.w.org/images/fonts/wp-6.7/collections/google-fonts-with-preview.json` with an updated collection of fonts available for install.

Props dilip2615, mmaattiiaass, wildworks, dd32.
Fixes #62258.


Built from https://develop.svn.wordpress.org/trunk@59286


git-svn-id: http://core.svn.wordpress.org/trunk@58678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-23 22:39:17 +00:00
Weston Ruter
204d60314b HTML API: Fix extensibility of WP_HTML_Processor::next_token().
Break out logic from the `next_token()` method into a private method which may call itself recursively. This allows for subclasses to override the `next_token()` method and be assured that each call to `next_token()` corresponds with the consumption of one single token. This also parallels how `WP_HTML_Tag_Processor::next_token()` wraps a private `base_class_next_token()` method.

Props westonruter, jonsurrell.
Fixes #62269.

Built from https://develop.svn.wordpress.org/trunk@59285


git-svn-id: http://core.svn.wordpress.org/trunk@58677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-10-23 22:05:17 +00:00