Boone Gorges
3706590afb
Split shared taxonomy terms during term update.
...
When updating an existing taxonomy term that shares its `term_id` with
another term, we generate a new row in `wp_terms` and associate the updated
term_taxonomy_id with the new term. This separates the terms, such that
updating the name of one term does not change the name of any others.
Note that this term splitting only occurs on installations whose database
schemas have been upgraded to version 30133 or higher. Note also that shared
terms are only split when run through `wp_update_term()`, as on edit-tags.php;
we will wait until a future release of WordPress to force the splitting of all
shared taxonomy terms.
Props boonebgorges, rmccue, greuben, garyc40, wonderboymusic, imath, jesin.
Fixes #5809 .
Built from https://develop.svn.wordpress.org/trunk@30241
git-svn-id: http://core.svn.wordpress.org/trunk@30241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 02:03:23 +00:00
Boone Gorges
32db3d1fe5
Do not create shared taxonomy terms.
...
A "shared" term occurs when two entries in the `wp_term_taxonomy` table share a
single `term_id`, and thereby correspond to the same row in `wp_terms`. This
changeset stops the practice of creating shared terms: each new row in
`wp_term_taxonomy` will receive its own row in `wp_terms`. The new strategy
for term creation depends on whether the installation's database schema is up
to date for 4.1:
* If so, terms are allowed to be created with the same slug as an existing term, as long as they are in different taxonomies and do not share a parent. Thus, a new tag with the slug 'wordpress' can exist alongside a category with the slug 'wordpress'.
* If not, new terms will be forced to have unique slugs. Thus, on an installation containing a category with the slug 'wordpress', a new tag 'WordPress' will get the slug 'wordpress-2'.
Fixes #21950 . See #5809 .
Built from https://develop.svn.wordpress.org/trunk@30240
git-svn-id: http://core.svn.wordpress.org/trunk@30240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 01:42:22 +00:00
Boone Gorges
ef13be6f27
Enforce ORDER BY and LIMIT clauses in term_exists()
queries.
...
In case of edge cases where a duplicate term might exist in a replicated
database for a split second, these explicit query clauses ensure that
`term_exists()` will always recognize the oldest matched term as the
canonical one. See [30238] for background.
Props pento.
See #22023 , #5809 .
Built from https://develop.svn.wordpress.org/trunk@30239
git-svn-id: http://core.svn.wordpress.org/trunk@30239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 01:09:21 +00:00
Boone Gorges
4ce9db9ce8
In wp_insert_term()
, clean up accidental duplicate terms after insert.
...
In [30056], the UNIQUE index was removed from the 'slug' column of `wp_terms`.
While we have numerous checks in place to avoid the creation of unwanted
duplicate term+term_taxonomy pairs, it's possible that in certain edge cases -
such as during the lag caused by database replication, or a race condition
involving near-simultaneous creation of more than one term - we'll end up
unwittingly inserting two identical rows.
The current changeset minimizes this risk by introducing a failsafe mechanism
into `wp_insert_term()`. After a term and term_taxonomy are INSERTed, we check
to see whether the term just created is a duplicate of an existing term; if so,
we delete the new one and keep the old one. This prevents problems caused by
replication lag, because SELECT queries that take place after an INSERT will
hit the master database; it mitigates race conditions by enforcing that the
term that was created first (ie, the one with the lowest `term_id`) is
always the "canonical" one.
Props nacin, markjaquith.
See #22023 , #5809 .
Built from https://develop.svn.wordpress.org/trunk@30238
git-svn-id: http://core.svn.wordpress.org/trunk@30238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-05 01:00:24 +00:00
Ian Stewart
1483e80848
Twenty Fifteen: use continue reading links for auto-generated excerpts to provide a readable link for screenreaders.
...
Props davidakennedy, kraftbj, fixes #30135 .
Built from https://develop.svn.wordpress.org/trunk@30237
git-svn-id: http://core.svn.wordpress.org/trunk@30237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 21:19:22 +00:00
Ian Stewart
2047ff9e5a
Twenty Fifteen: Use the new archive template tags and make archive template titling way simpler!
...
Props obenland, fixes #30246 .
Built from https://develop.svn.wordpress.org/trunk@30236
git-svn-id: http://core.svn.wordpress.org/trunk@30236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 21:01:23 +00:00
Ian Stewart
0952952ef7
Twenty Fifteen: adding licensing info for the image used in the screenshot.
...
Props sakinshrestha, fixes #30156 .
Built from https://develop.svn.wordpress.org/trunk@30235
git-svn-id: http://core.svn.wordpress.org/trunk@30235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:55:22 +00:00
Scott Taylor
8fa0755584
Add some docs to wp.media.view.EditorUploader
.
...
Props ericlewis.
See #29951 .
Built from https://develop.svn.wordpress.org/trunk@30234
git-svn-id: http://core.svn.wordpress.org/trunk@30234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:48:23 +00:00
Ian Stewart
d21ea0a251
Twenty Fifteen: Formatting cleanup for documentation, crossing eyes, dotting tees.
...
Props lancewillett, MikeHansenMe, fixes #30149 .
Built from https://develop.svn.wordpress.org/trunk@30233
git-svn-id: http://core.svn.wordpress.org/trunk@30233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:26:23 +00:00
Ian Stewart
e2d03edb0d
Twenty Fifteen: missing spaces for code standards.
...
Props Jayjdk, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30232
git-svn-id: http://core.svn.wordpress.org/trunk@30232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:16:22 +00:00
Ian Stewart
b519db9ffa
Twenty Fifteen: accessible alt text for post thumbnail links.
...
Props joedolson, fixes #30076 .
Built from https://develop.svn.wordpress.org/trunk@30231
git-svn-id: http://core.svn.wordpress.org/trunk@30231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:57:27 +00:00
Ian Stewart
17dbe26df9
Twenty Fifteen: Simplify the header, sidebar, background controls and make customization faster for users to do. This has the added benefit of fixing our bug where hidden header text wasn't being updated on color scheme switch. Nice.
...
Props celloexpressions, iamtakashi, fixes #30164 and #29980 .
Built from https://develop.svn.wordpress.org/trunk@30230
git-svn-id: http://core.svn.wordpress.org/trunk@30230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 18:42:22 +00:00
Ian Stewart
cc9c8edf83
Twenty Fifteen: Crashing chrome if you don't have Noto installed probably isn't the best experience -- removing font kerning.
...
Props iamtakashi, fixes #30195
Built from https://develop.svn.wordpress.org/trunk@30229
git-svn-id: http://core.svn.wordpress.org/trunk@30229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 17:41:21 +00:00
Drew Jaynes
7d56be8521
Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files.
...
Props NikV for the initial patch.
Fixes #29111 .
Built from https://develop.svn.wordpress.org/trunk@30228
git-svn-id: http://core.svn.wordpress.org/trunk@30228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:32:22 +00:00
Drew Jaynes
7081b906f4
Fix a couple of typos in the hook documentation for the $option
filter in wp-admin/includes/class-wp-list-table.php.
...
Props bobbingwide.
Fixes #30229 .
Built from https://develop.svn.wordpress.org/trunk@30227
git-svn-id: http://core.svn.wordpress.org/trunk@30227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 16:05:22 +00:00
Drew Jaynes
d19de136c6
Merge a multi-line comment into a single-line comment in wp-includes/link-template.php.
...
See [30166]. See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30226
git-svn-id: http://core.svn.wordpress.org/trunk@30226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 15:59:23 +00:00
Drew Jaynes
256bea185d
Add parameter and return descriptions to the WP_List_Table::get_pagination_arg()
DocBlock.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30225
git-svn-id: http://core.svn.wordpress.org/trunk@30225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 15:55:23 +00:00
Drew Jaynes
784e162177
Cross reference get_the_archive_title()
and get_the_archive_description()
in the inline documentation for their corresponding template tags.
...
Also define the default values for `$before` and `$after` in the template tag documentation.
See [30223]. See #21995 .
Built from https://develop.svn.wordpress.org/trunk@30224
git-svn-id: http://core.svn.wordpress.org/trunk@30224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 06:52:23 +00:00
John Blackbourn
6a45f46937
Introduce some new template functions for archive titles and descriptions:
...
* `get_the_archive_title()` and `the_archive_title()` for returning/displaying the title of the current term, date, post type, post format, or author archive.
* `get_the_archive_description()` and `the_archive_description()` for returning/displaying the description associated with the current term archive.
Fixes #21995
Props obenland, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30223
git-svn-id: http://core.svn.wordpress.org/trunk@30223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 00:35:22 +00:00
Ian Stewart
7a6ea1e83d
Twenty Fifteen: correct image alignment for RTL.
...
Props iamtakashi, fixes #30239 .
Built from https://develop.svn.wordpress.org/trunk@30222
git-svn-id: http://core.svn.wordpress.org/trunk@30222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 23:12:22 +00:00
Ian Stewart
7dfb040dde
Twenty Fifteen: check if user-selected custom colors are the same as default so we're not duplicating styles.
...
Props iamtakashi, fixes #30234
Built from https://develop.svn.wordpress.org/trunk@30221
git-svn-id: http://core.svn.wordpress.org/trunk@30221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:59:22 +00:00
Ian Stewart
8a930c93a8
Twenty Fifteen: Remove a gap between content and footer when the sidebar is longer than the content.
...
Props iamtakashi, fixes #30228 .
Built from https://develop.svn.wordpress.org/trunk@30220
git-svn-id: http://core.svn.wordpress.org/trunk@30220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:49:44 +00:00
Dominik Schilling
a17fd23e41
Customizer: Bind input
and propertychange
events for range input types.
...
props voldemortensen, westonruter.
fixes #30223 .
Built from https://develop.svn.wordpress.org/trunk@30219
git-svn-id: http://core.svn.wordpress.org/trunk@30219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:49:23 +00:00
Ian Stewart
9a3b7977fd
Twenty Fifteen: escaping for the HTML5 shiv call.
...
Props philiparthurmoore, fixes #30212
Built from https://develop.svn.wordpress.org/trunk@30218
git-svn-id: http://core.svn.wordpress.org/trunk@30218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:47:22 +00:00
Ian Stewart
3a0b05e5b1
Twenty Fifteen: kern everything -- it reads better.
...
Props afercia, fixes #30195 .
Built from https://develop.svn.wordpress.org/trunk@30217
git-svn-id: http://core.svn.wordpress.org/trunk@30217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:43:21 +00:00
Ian Stewart
6be421fb37
Twenty Fifteen: Use new core navigation tags.
...
Props obenland, iamtakashi, fixes #30189
Built from https://develop.svn.wordpress.org/trunk@30216
git-svn-id: http://core.svn.wordpress.org/trunk@30216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:40:23 +00:00
Ian Stewart
fe241e3fdc
Twenty Fifteen: Make sure that the edit link will always be right of it's icon.
...
Props iamtakashi, fixes #30171 .
Built from https://develop.svn.wordpress.org/trunk@30215
git-svn-id: http://core.svn.wordpress.org/trunk@30215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:36:23 +00:00
Dominik Schilling
73b4f6f449
Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP.
...
props westonruter.
fixes #30225 .
Built from https://develop.svn.wordpress.org/trunk@30214
git-svn-id: http://core.svn.wordpress.org/trunk@30214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:35:23 +00:00
Ian Stewart
4b23645ad4
Twenty Fifteen: nicer styles for playlists.
...
Props iamtakashi, fixes #30163
Built from https://develop.svn.wordpress.org/trunk@30213
git-svn-id: http://core.svn.wordpress.org/trunk@30213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:33:23 +00:00
Ian Stewart
cdfbccddb2
Twenty Fifteen: add a fallback icon for social links where we don't have an icon
...
Props iamtakashi, fixes #30148
Built from https://develop.svn.wordpress.org/trunk@30212
git-svn-id: http://core.svn.wordpress.org/trunk@30212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 19:02:22 +00:00
Ian Stewart
c1b360a665
Twenty Fifteen: prevent a flash of visible sub menus before scripts load.
...
Props mattwiebe, aferica, fixes #30056 .
Built from https://develop.svn.wordpress.org/trunk@30211
git-svn-id: http://core.svn.wordpress.org/trunk@30211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:58:23 +00:00
Boone Gorges
7919a6d812
Improve docblocks for get_the_taxonomies()
and the_taxonomies()
.
...
* In `the_taxonomies()`, only document those arguments that are specific to the function. Arguments shared with `get_the_taxonomies()` should be documented in the later function's docblock.
* Add $args hash documentation to `get_the_taxonomies()`.
* Remove the redundant default argument definition in `the_taxonomies()`.
Fixes #27238 .
Built from https://develop.svn.wordpress.org/trunk@30210
git-svn-id: http://core.svn.wordpress.org/trunk@30210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:45 +00:00
Boone Gorges
eec3eea392
Introduce term_template
param to get_the_taxonomies()
.
...
This parameter allows theme and plugin authors to specify the formatting they
would like on the term links as they are parsed into the taxonomy list.
Props hereswhatidid, dlh, davidjlaietta.
See #27238 .
Built from https://develop.svn.wordpress.org/trunk@30209
git-svn-id: http://core.svn.wordpress.org/trunk@30209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:49:24 +00:00
Ian Stewart
a46c99cf78
Twenty Fifteen: make it clear that a link is a link in post and comment meta by underlining it on hover or focus
...
Props morganestes, iamtakashi, fixes #30108
Built from https://develop.svn.wordpress.org/trunk@30208
git-svn-id: http://core.svn.wordpress.org/trunk@30208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 17:01:23 +00:00
Boone Gorges
89526ca7f1
Ignore case when checking string 'false' in wp_validate_boolean()
.
...
Props TobiasBg, kitchin.
Fixes #30238 .
Built from https://develop.svn.wordpress.org/trunk@30207
git-svn-id: http://core.svn.wordpress.org/trunk@30207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:55:23 +00:00
Boone Gorges
99c5817822
Add unit tests for wp_validate_boolean()
.
...
Props TobiasBg.
See #30238 .
Built from https://develop.svn.wordpress.org/trunk@30206
git-svn-id: http://core.svn.wordpress.org/trunk@30206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 15:52:21 +00:00
Boone Gorges
fc4b17a5d2
In in_object_in_term()
, only check numeric string values against term_id.
...
The previous `in_array()` check was playing too loose with mixed types, such
that a string like '10_term_name' would incorrectly match a term_id 10.
Props nobinobi, realloc.
Fixes #29467 .
Built from https://develop.svn.wordpress.org/trunk@30205
git-svn-id: http://core.svn.wordpress.org/trunk@30205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:44 +00:00
Boone Gorges
d2a8ae2544
Add some unit tests for is_object_in_term()
.
...
These tests check a number of the ways that different kinds of values for
`$terms` (integers that match term_id, strings that match term_id or name or
slug) are handled.
See #29467 .
Built from https://develop.svn.wordpress.org/trunk@30204
git-svn-id: http://core.svn.wordpress.org/trunk@30204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 14:25:22 +00:00
Scott Taylor
5e3a64e83d
Correct some types in wp-admin/*
-location files' doc blocks.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30203
git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
Scott Taylor
7d7a8aa0eb
Correct all @return unknown
instances.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30202
git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Scott Taylor
bd2521d5ee
Fill in the @param
types for the args for functions missing them in wp-admin/includes/deprecated.php
(pour one out).
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30201
git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
Scott Taylor
196d85a9f6
Fill in the @param
types for the args for functions missing them in wp-admin/includes/misc.php
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30200
git-svn-id: http://core.svn.wordpress.org/trunk@30200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:01:24 +00:00
Scott Taylor
37f94bdfd0
Fill in the @param
types for the args for functions missing them in wp-admin/includes/plugin.php
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30199
git-svn-id: http://core.svn.wordpress.org/trunk@30199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:59:22 +00:00
Scott Taylor
64167f0845
Fill in the @param
types for the args for functions missing them in wp-admin/includes/post.php
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30198
git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:55:22 +00:00
Scott Taylor
d9d825db72
Fill in the @param
types for the args for functions missing them in wp-admin/includes/taxonomy.php
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30197
git-svn-id: http://core.svn.wordpress.org/trunk@30197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:50:23 +00:00
Scott Taylor
06f49a43a1
Fill in the @param
types for the args for functions missing them in wp-admin/includes/template.php
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30196
git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:45:24 +00:00
Scott Taylor
5a3256c00b
Fill in the @param
types for the args for make_site_theme_from_default()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30195
git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:43:21 +00:00
Scott Taylor
ef944e8c19
Fill in the @param
types for the args for make_site_theme_from_oldschool()
, which is actually the name of a function?
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30194
git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:41:23 +00:00
Scott Taylor
082a1d06ae
Fill in the @param
types for the args for dbDelta()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30193
git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:40:22 +00:00
Scott Taylor
150b4e5157
Fill in the @param
types for the args in WP_Text_Diff_Renderer_Table->interleave_changed_lines()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30192
git-svn-id: http://core.svn.wordpress.org/trunk@30192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:39:22 +00:00
Scott Taylor
3e4ca28eb9
Correct the @param
type for the $query
arg for remove_query_arg()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30191
git-svn-id: http://core.svn.wordpress.org/trunk@30191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:29:22 +00:00
Scott Taylor
8eee18ec0e
Fill in types for the @param
s for wp_comment_reply()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30190
git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:21:22 +00:00
Scott Taylor
63c55ae93c
Correct type in the doc block for get_theme_support()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30189
git-svn-id: http://core.svn.wordpress.org/trunk@30189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:18:22 +00:00
Scott Taylor
3535af5b77
Correct the return value doc block for get_theme_support()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30188
git-svn-id: http://core.svn.wordpress.org/trunk@30188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:17:23 +00:00
Scott Taylor
0eb038d97b
In Custom_Image_Header
:
...
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403].
* Declare `$updated` as a property.
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30187
git-svn-id: http://core.svn.wordpress.org/trunk@30187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:15:22 +00:00
Scott Taylor
a14a4fc9a5
In Custom_Background
, declare $updated
as a property.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30186
git-svn-id: http://core.svn.wordpress.org/trunk@30186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:08:22 +00:00
Scott Taylor
15c062eb79
In wp_audio|video_shortcode()
, make sure that autoplay
and loop
are booleans. Passing 'false'
to them will force them to be active, which is bad.
...
Fixes #29825 .
Built from https://develop.svn.wordpress.org/trunk@30185
git-svn-id: http://core.svn.wordpress.org/trunk@30185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 05:03:21 +00:00
Scott Taylor
a587ebc946
In WP_Tax_Query
, declare $primary_table
and $primary_id_column
as properties.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30184
git-svn-id: http://core.svn.wordpress.org/trunk@30184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:45:22 +00:00
Scott Taylor
2750f0cec7
In WP_Locale
, declare $number_format
as a property.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30183
git-svn-id: http://core.svn.wordpress.org/trunk@30183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:40:22 +00:00
Scott Taylor
a23c230c01
In WP_Comment_Query
, declare $query_vars
and $comments
as properties.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30182
git-svn-id: http://core.svn.wordpress.org/trunk@30182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:08:22 +00:00
Scott Taylor
c598d35e41
Almost every method in wp_xmlrpc_server
can also return IXR_Error
and should be labeled as such. Rehabilitate some return
syntax.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30181
git-svn-id: http://core.svn.wordpress.org/trunk@30181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 03:04:22 +00:00
Scott Taylor
e02c724249
WP_Image_Editor_GD
and WP_Image_Editor_Imagick
should specify type in a doc block for the $image
property, instead of inferring bool
and null
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30180
git-svn-id: http://core.svn.wordpress.org/trunk@30180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:38:23 +00:00
Scott Taylor
a887301869
In WP_HTTP_IXR_Client
:
...
* declare `$scheme` as a property, it doesn't exist on the parent class
* declare `$error` as a property of type `IXR_Error`, instead of it being inferred as `boolean` from the parent class
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30179
git-svn-id: http://core.svn.wordpress.org/trunk@30179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:32:22 +00:00
Scott Taylor
68a67a9b0d
Fix the return docs for WP_Embed->maybe_make_link()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30178
git-svn-id: http://core.svn.wordpress.org/trunk@30178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 02:27:23 +00:00
Jeremy Felt
796ceebb25
Use common core syntax for checking DOING_AJAX
...
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.
props TobiasBg
Fixes #29891
Built from https://develop.svn.wordpress.org/trunk@30177
git-svn-id: http://core.svn.wordpress.org/trunk@30177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 02:24:23 +00:00
Jeremy Felt
00c86aea63
Delete admin_created_user_subject() rather than deprecate
...
As it was never used as anything more than a callback to a filter before the MU merge, and is only available in user-new.php in multisite, it is safe to remove this function entirely.
Fixes #29915
Built from https://develop.svn.wordpress.org/trunk@30176
git-svn-id: http://core.svn.wordpress.org/trunk@30176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 02:07:23 +00:00
Jeremy Felt
c3f51ce97a
Improve layout of test for cached invalid, then valid site details
...
* Rename method to `test_get_blog_details_when_site_does_not_exist()`.
* Always assume `MAX(blog_id)` is 1 and therefore always create a burner.
* Remove tests specific to `wpmu_delete_blog()` and cache, to be handled elsewhere.
* Remove extra asertions.
See #30080 , #23405
Built from https://develop.svn.wordpress.org/trunk@30175
git-svn-id: http://core.svn.wordpress.org/trunk@30175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-02 01:05:22 +00:00
Jeremy Felt
132be9d66d
Split tests for wp_get_sites()
...
Test various arguments for `wp_get_sites()` in a more intentful way rather than in one large test. Leave tests for limit and offset together for convenience.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30174
git-svn-id: http://core.svn.wordpress.org/trunk@30174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:40:22 +00:00
Scott Taylor
783f36f855
In _WP_Editors::editor_settings()
, $str1
and $str2
don't need to be initialized empty.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30173
git-svn-id: http://core.svn.wordpress.org/trunk@30173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:22:22 +00:00
Scott Taylor
303d01869c
Declare the $uploaded_headers
and $default_headers
properties for WP_Customize_Header_Image_Control
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30172
git-svn-id: http://core.svn.wordpress.org/trunk@30172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:18:23 +00:00
Scott Taylor
73c8e4cf10
Declare the $update_count
and $update_current
properties for WP_Upgrader
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30171
git-svn-id: http://core.svn.wordpress.org/trunk@30171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:07:23 +00:00
Scott Taylor
3fc8778359
Declare the $options
property for WP_Upgrader_Skin
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30170
git-svn-id: http://core.svn.wordpress.org/trunk@30170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:03:22 +00:00
Scott Taylor
4d0f66854a
Fix the return value doc for WP_List_Table->get_pagination_arg()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30169
git-svn-id: http://core.svn.wordpress.org/trunk@30169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 23:00:23 +00:00
Scott Taylor
6a109700d0
In wp_ajax_get_tagcloud()
, bail immediately if $_POST['tax']
isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die()
confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30168
git-svn-id: http://core.svn.wordpress.org/trunk@30168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:54:22 +00:00
Scott Taylor
a786fb779c
In wp_ajax_ajax_tag_search()
, bail immediately if $_GET['tax']
isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die()
confuses Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30167
git-svn-id: http://core.svn.wordpress.org/trunk@30167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:48:22 +00:00
Scott Taylor
a79b6fdde3
In get_the_pagination()
, don't pass $links
to _navigation_markup()
if it is not a string - paginate_links()
can return an array
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30166
git-svn-id: http://core.svn.wordpress.org/trunk@30166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:41:23 +00:00
Scott Taylor
892be738b0
Make the docs type for return
in wpmu_create_user()
more specific.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30165
git-svn-id: http://core.svn.wordpress.org/trunk@30165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:33:21 +00:00
Scott Taylor
e41e38183d
In customize.php
, check that $autofocus
is an array
after running wp_unslash()
instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30164
git-svn-id: http://core.svn.wordpress.org/trunk@30164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:17:22 +00:00
Scott Taylor
106da1e9e6
In WP_Meta_Query->get_sql_for_clause()
, the empty initialization of $where
is dead code and can be removed.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30163
git-svn-id: http://core.svn.wordpress.org/trunk@30163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:03:22 +00:00
Scott Taylor
fbd6efdfb8
In _wp_json_convert_string()
, when $use_mb
is false
, perhaps pass a variable that actually exists to wp_check_invalid_utf8()
.
...
Introduced in [30055].
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30162
git-svn-id: http://core.svn.wordpress.org/trunk@30162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 22:00:24 +00:00
Scott Taylor
cd9bb04981
In gallery_shortcode()
, when the link
attribute is equal to file
, make sure to pass $attr
as the 6th (!) argument, not 5th, to wp_get_attachment_link()
.
...
Props bradyvercher.
Fixes #27402 .
Built from https://develop.svn.wordpress.org/trunk@30161
git-svn-id: http://core.svn.wordpress.org/trunk@30161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:47:24 +00:00
Scott Taylor
382d93ddf9
Remove failing unit test after [30090].
...
Fixes #30194 .
Built from https://develop.svn.wordpress.org/trunk@30160
git-svn-id: http://core.svn.wordpress.org/trunk@30160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 21:11:22 +00:00
Scott Taylor
878d074e84
Allow get_pages()
, with child_of
passed to it, to work with interrupted hierarchies.
...
Adds unit test.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30159
git-svn-id: http://core.svn.wordpress.org/trunk@30159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:44:21 +00:00
Scott Taylor
d5e4583475
All duplicate slugs across different post types.
...
Adds unit test.
Props mboynes, nacin.
Fixes #18962 .
Built from https://develop.svn.wordpress.org/trunk@30158
git-svn-id: http://core.svn.wordpress.org/trunk@30158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:37:24 +00:00
Scott Taylor
849a993269
Check $_current_page
before using it in Walker_Page->start_el()
.
...
Props jeremyfelt.
Fixes #26901 .
Built from https://develop.svn.wordpress.org/trunk@30157
git-svn-id: http://core.svn.wordpress.org/trunk@30157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:29:22 +00:00
Scott Taylor
60b73c589c
Display error message when Media Library upload fails.
...
Props gcorne.
Fixes #29891 .
Built from https://develop.svn.wordpress.org/trunk@30156
git-svn-id: http://core.svn.wordpress.org/trunk@30156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:25:23 +00:00
Scott Taylor
be08f576df
Improve some post_status
-related documentation.
...
Props ericlewis.
See #30230 .
Built from https://develop.svn.wordpress.org/trunk@30155
git-svn-id: http://core.svn.wordpress.org/trunk@30155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 20:20:23 +00:00
Scott Taylor
0b9c1be743
In WP_List_Table
, add a property, $modes
, to allow WP_Media_List_Table
to inherit ->view_switcher()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30154
git-svn-id: http://core.svn.wordpress.org/trunk@30154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:56:24 +00:00
Scott Taylor
be707cd614
In wp_xmlrpc_server
methods, for comprehensibility:
...
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30153
git-svn-id: http://core.svn.wordpress.org/trunk@30153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 19:45:25 +00:00
Jeremy Felt
0ba8ceb6ea
Split tests for is_main_site()
...
Break multiple assertions from one method into multiple methods with one assertion each.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30152
git-svn-id: http://core.svn.wordpress.org/trunk@30152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 05:18:22 +00:00
Jeremy Felt
8785f07ee1
Expand and clarify tests for get_blog_post()
...
Remove unnecessary user factory use. Be explicit about test scenarios.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30151
git-svn-id: http://core.svn.wordpress.org/trunk@30151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:47:22 +00:00
Drew Jaynes
09a1f68f07
Fix a couple of spacing and wrapping indents in the WP_Date_Query::__construct()
hash notation.
...
See [30142]. See #28063 .
Built from https://develop.svn.wordpress.org/trunk@30150
git-svn-id: http://core.svn.wordpress.org/trunk@30150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:31:22 +00:00
Drew Jaynes
a929ac44e1
Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140].
...
It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for `update_{$meta_type}_meta`, `update_postmeta`, `updated_{$meta_type}_meta`, and `updated_postmeta`.
Fixes #11683 .
Built from https://develop.svn.wordpress.org/trunk@30149
git-svn-id: http://core.svn.wordpress.org/trunk@30149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:18:23 +00:00
Boone Gorges
8b18debcd0
Clean up 'post-thumbnail' theme support unit tests.
...
* Separate into smaller test methods.
* Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of `current_theme_supports( 'post-thumbnails' )`, but no one ever noticed because the tests had been designed to bail when `_wp_render_title_tag()` did not exist. The failures finally became visible when that function was introduced in [30074].
See #18548 .
Built from https://develop.svn.wordpress.org/trunk@30148
git-svn-id: http://core.svn.wordpress.org/trunk@30148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 04:01:21 +00:00
Lance Willett
df455aa106
Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names.
...
Props slobodanmanic, fixes #28703 .
Built from https://develop.svn.wordpress.org/trunk@30147
git-svn-id: http://core.svn.wordpress.org/trunk@30147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:47:21 +00:00
Lance Willett
c604fd15b0
Twenty Fourteen: fix keyboard focus on Appearance > Header view.
...
Props florianziegler, fixes #29787 .
Built from https://develop.svn.wordpress.org/trunk@30146
git-svn-id: http://core.svn.wordpress.org/trunk@30146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:44:23 +00:00
Lance Willett
609335eef1
Twenty Ten and Eleven: don't display modified excerpt link in wp-admin.
...
Props kraftbj, fixes #30026 .
Built from https://develop.svn.wordpress.org/trunk@30145
git-svn-id: http://core.svn.wordpress.org/trunk@30145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:40:25 +00:00
Boone Gorges
c07582cb64
Improve default argument formatting in WP_Date_Query::__construct()
.
...
Built from https://develop.svn.wordpress.org/trunk@30144
git-svn-id: http://core.svn.wordpress.org/trunk@30144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:29:21 +00:00
Lance Willett
6ddbf3c8bd
Twenty Fourteen: Make featured content in Customizer contextual to the front page.
...
Props celloexpressions, fixes #29578 .
Built from https://develop.svn.wordpress.org/trunk@30143
git-svn-id: http://core.svn.wordpress.org/trunk@30143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:26:21 +00:00
Boone Gorges
92536aae65
Introduced dayofweek_iso
time param for WP_Date_Query
.
...
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.
Props mboynes.
Fixes #28063 .
Built from https://develop.svn.wordpress.org/trunk@30142
git-svn-id: http://core.svn.wordpress.org/trunk@30142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:24:21 +00:00