Commit Graph

4729 Commits

Author SHA1 Message Date
Sergey Biryukov
d2919e2d71 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit-comments.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33860


git-svn-id: http://core.svn.wordpress.org/trunk@33828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:04:21 +00:00
Sergey Biryukov
31b0fe4b6f Set svn:eol-style for the files added in [32806].
see #32576.
Built from https://develop.svn.wordpress.org/trunk@33859


git-svn-id: http://core.svn.wordpress.org/trunk@33827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 17:55:21 +00:00
John Blackbourn
6aad2eb98c Correctly encode spaces in URLs passed to esc_url() instead of removing them.
Fixes #23605
Props enshrined, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33858


git-svn-id: http://core.svn.wordpress.org/trunk@33826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 17:20:21 +00:00
Sergey Biryukov
3d1c08a1a5 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/customize.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33857


git-svn-id: http://core.svn.wordpress.org/trunk@33825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 17:05:22 +00:00
Andrea Fercia
f35c176426 Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604].
Fixes #33633.
Built from https://develop.svn.wordpress.org/trunk@33856


git-svn-id: http://core.svn.wordpress.org/trunk@33824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:56:20 +00:00
John Blackbourn
06c86124ad More unit tests for esc_url() and esc_url_raw().
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33855


git-svn-id: http://core.svn.wordpress.org/trunk@33823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:51:21 +00:00
Sergey Biryukov
cf69e6deb3 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33854


git-svn-id: http://core.svn.wordpress.org/trunk@33822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:29:21 +00:00
Sergey Biryukov
d95417a5e7 Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33853


git-svn-id: http://core.svn.wordpress.org/trunk@33821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:21:21 +00:00
Sergey Biryukov
c3b663ad8d Provide more helful feedback than just “Cheatin’ uh?” for permission errors in wp-admin/edit-tags.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33852


git-svn-id: http://core.svn.wordpress.org/trunk@33820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:06:21 +00:00
John Blackbourn
867a449fee Add some more passing unit tests for esc_url() in preparation for upcoming changes.
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33851


git-svn-id: http://core.svn.wordpress.org/trunk@33819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 14:20:21 +00:00
Boone Gorges
709fde7584 Remove # from @ticket annotation in a unit test.
This improper character was erroneously introduced in [33724].

Props netweb.
Fixes #33532.
Built from https://develop.svn.wordpress.org/trunk@33850


git-svn-id: http://core.svn.wordpress.org/trunk@33818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 13:40:21 +00:00
John Blackbourn
606b6d15f1 Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL.
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90

Built from https://develop.svn.wordpress.org/trunk@33849


git-svn-id: http://core.svn.wordpress.org/trunk@33817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 11:29:23 +00:00
Jeremy Felt
9666aec8d1 Multisite: Remove duplicate span element output from row actions
Fixes #32961.

Built from https://develop.svn.wordpress.org/trunk@33848


git-svn-id: http://core.svn.wordpress.org/trunk@33816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 21:51:21 +00:00
Drew Jaynes
05c7abcf13 Docs: Add missing parameter documentation to the the DocBlock for WP_User::__set().
Props racase for the initial patch.
Fixes #33652.

Built from https://develop.svn.wordpress.org/trunk@33847


git-svn-id: http://core.svn.wordpress.org/trunk@33815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 21:47:21 +00:00
Scott Taylor
0415dd7c53 After [33807], fix unit tests for PHP 5.2
Fixes #17626.

Built from https://develop.svn.wordpress.org/trunk@33846


git-svn-id: http://core.svn.wordpress.org/trunk@33814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 17:04:21 +00:00
Scott Taylor
9f8816c939 De-Jorbin [33814].
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33845


git-svn-id: http://core.svn.wordpress.org/trunk@33813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 15:48:22 +00:00
Sergey Biryukov
bffe6a63ba Make curly quotes in playlist item title translatable.
fixes #33391.
Built from https://develop.svn.wordpress.org/trunk@33844


git-svn-id: http://core.svn.wordpress.org/trunk@33812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 13:50:21 +00:00
Scott Taylor
9b8169bd30 Move widget classes to their own files in wp-includes/widgets:
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.

Built from https://develop.svn.wordpress.org/trunk@33843


git-svn-id: http://core.svn.wordpress.org/trunk@33811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 13:49:21 +00:00
Sergey Biryukov
32b5726fd4 Merge two similar strings.
props pavelevap.
fixes #33643.
Built from https://develop.svn.wordpress.org/trunk@33842


git-svn-id: http://core.svn.wordpress.org/trunk@33810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 13:46:24 +00:00
Scott Taylor
ecf0b82afb Add some JS docs to customize-base.js
Props ericlewis.
Fixes #33639.

Built from https://develop.svn.wordpress.org/trunk@33841


git-svn-id: http://core.svn.wordpress.org/trunk@33809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 04:15:22 +00:00
Scott Taylor
a829ee32ce User Settings: allow dashes in get|set_user_setting() in PHP and get|setUserSetting() in JS.
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.

Fixes #22781.

Built from https://develop.svn.wordpress.org/trunk@33840


git-svn-id: http://core.svn.wordpress.org/trunk@33808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 03:57:21 +00:00
Sergey Biryukov
db71d238dd Correct @since version for [33838].
props JustinSainton.
see #23692.
Built from https://develop.svn.wordpress.org/trunk@33839


git-svn-id: http://core.svn.wordpress.org/trunk@33807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 03:14:21 +00:00
Sergey Biryukov
13540a6b30 Add filters to feed_links() to choose whether to display the links to posts feed and comments feed, separately.
props joostdevalk, juliobox.
fixes #23692.
Built from https://develop.svn.wordpress.org/trunk@33838


git-svn-id: http://core.svn.wordpress.org/trunk@33806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-01 02:46:21 +00:00
Weston Ruter
1413f2edd5 Customizer: Collapse any expanded panel/sections before expanding other panel/sections
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33837


git-svn-id: http://core.svn.wordpress.org/trunk@33805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:42 +00:00
Andrew Ozz
e3f3f470ea Editor, Press This: force a page reload when the user publishes a post and then clicks the back button.
Fixes #23691.
Built from https://develop.svn.wordpress.org/trunk@33836


git-svn-id: http://core.svn.wordpress.org/trunk@33804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:22 +00:00
Andrew Ozz
db0ca19899 TinyMCE: disable the native fullscreen plugin on mobile devices by default.
Props iseulde. Fixes #33137;
Built from https://develop.svn.wordpress.org/trunk@33835


git-svn-id: http://core.svn.wordpress.org/trunk@33803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 22:45:22 +00:00
Andrew Ozz
a231303341 TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content.
Fixes #33477.
Built from https://develop.svn.wordpress.org/trunk@33834


git-svn-id: http://core.svn.wordpress.org/trunk@33802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 22:07:21 +00:00
Sergey Biryukov
43194cea1c Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget.
props MikeHansenMe, DrewAPicture.
fixes #31434.
Built from https://develop.svn.wordpress.org/trunk@33833


git-svn-id: http://core.svn.wordpress.org/trunk@33801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:57:21 +00:00
Sergey Biryukov
a53d6b471f Add 'update_right_now_text' filter for the text displayed in the 'At a Glance' dashboard widget.
props obenland.
fixes #33355.
Built from https://develop.svn.wordpress.org/trunk@33832


git-svn-id: http://core.svn.wordpress.org/trunk@33800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:45:21 +00:00
John Blackbourn
6a0818996d Space out.
Built from https://develop.svn.wordpress.org/trunk@33831


git-svn-id: http://core.svn.wordpress.org/trunk@33799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:25:21 +00:00
Drew Jaynes
375d30f699 Docs: Add a duplicate filter comment to the comment_email filter call in WP_Comments_List_Table, introduced in [33829].
See #11566.

Built from https://develop.svn.wordpress.org/trunk@33830


git-svn-id: http://core.svn.wordpress.org/trunk@33798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:22:21 +00:00
Scott Taylor
a5b157ffde Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link(), the internals can be simplified and applied inline.
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33829


git-svn-id: http://core.svn.wordpress.org/trunk@33797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:09:21 +00:00
Scott Taylor
d0a1a47708 Fix warnings after [33826]. Only only one function call needs a global $comment, we shall hamburger it.
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33828


git-svn-id: http://core.svn.wordpress.org/trunk@33796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:59:21 +00:00
Drew Jaynes
cf7694717b Docs: Clarify the DocBlock summary for wp_create_nonce() to mention that nonce-creation is also now dependent on user tokens, as of [29221].
Also adds a changelog entry for when user tokens were introduced into the nonce-creation process.

Props ericlewis
Fixes #33636.

Built from https://develop.svn.wordpress.org/trunk@33827


git-svn-id: http://core.svn.wordpress.org/trunk@33795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:50:20 +00:00
Scott Taylor
7ab015c5ab WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set.
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33826


git-svn-id: http://core.svn.wordpress.org/trunk@33794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:42:21 +00:00
Sergey Biryukov
8b1fe986c3 Use wp_html_excerpt() to properly cut comment author URL for display on Comments screen.
props brettz95, solarissmoke.
fixes #15659.
Built from https://develop.svn.wordpress.org/trunk@33825


git-svn-id: http://core.svn.wordpress.org/trunk@33793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:41:21 +00:00
Scott Taylor
50d0f8f1ae WP_Widget_Pages::widget() has no reason to set $comment and $comments globals.
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33824


git-svn-id: http://core.svn.wordpress.org/trunk@33792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 20:31:22 +00:00
Scott Taylor
1f1b72b5f5 After [33822], really add those unit tests for wp_count_comments().
See #19903. 

Built from https://develop.svn.wordpress.org/trunk@33823


git-svn-id: http://core.svn.wordpress.org/trunk@33791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 18:51:41 +00:00
Scott Taylor
6ae78f0fe4 Comments: wp_count_comments() can use get_comment_count() internally to makes its DB query, provided that get_comment_count() returns more properties.
Adds/updates unit tests. There were zero (0) unit tests for `wp_count_comments()`.

Fixes #19903. 

Built from https://develop.svn.wordpress.org/trunk@33822


git-svn-id: http://core.svn.wordpress.org/trunk@33790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 18:51:22 +00:00
Scott Taylor
7808d5d1fa Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
Fixes #33414. 

Built from https://develop.svn.wordpress.org/trunk@33821


git-svn-id: http://core.svn.wordpress.org/trunk@33789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 17:58:22 +00:00
Sergey Biryukov
5a97ff5206 Bump H3 headings to H2 on Themes screen for better accessibility.
props joehills.
fixes #33560.
Built from https://develop.svn.wordpress.org/trunk@33820


git-svn-id: http://core.svn.wordpress.org/trunk@33788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:51:21 +00:00
Sergey Biryukov
82a8cec3b3 Bump H3 headings to H2 on Tools screen for better accessibility.
props Cheffheid.
fixes #33607.
Built from https://develop.svn.wordpress.org/trunk@33819


git-svn-id: http://core.svn.wordpress.org/trunk@33787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:32:21 +00:00
Sergey Biryukov
48c82ef14d Bump H3 headings to H2 on Permalink Settings screen for better accessibility.
props Cheffheid.
fixes #33611.
Built from https://develop.svn.wordpress.org/trunk@33818


git-svn-id: http://core.svn.wordpress.org/trunk@33786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:29:21 +00:00
Sergey Biryukov
fb3d54d569 Bump H3 headings to H2 on WordPress Updates screen for better accessibility.
props Cheffheid.
fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@33817


git-svn-id: http://core.svn.wordpress.org/trunk@33785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:26:24 +00:00
Drew Jaynes
4d006fad9e Docs: Bring the file header and class DocBlock summaries for class-wp-widget.php in-line with the intention of the docs standard:
* File headers: _What_ the file is
* Class DocBlocks: What purpose the class serves. Mentioning the class name in the class DocBlock is redundant

See #33413

Built from https://develop.svn.wordpress.org/trunk@33816


git-svn-id: http://core.svn.wordpress.org/trunk@33784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 23:14:21 +00:00
Konstantin Obenland
1e9372b699 Themes: Get the correct theme when template and stylesheet were both passed as arguments.
Fixes a bug where `$new_theme` got set before the second argument was
appropriately handled, causing the `current_theme` option to later always be
updated to the parent theme's name.

Introduced in [21131].

Props obenland, wonderboymusic.
Fixes #32635.


Built from https://develop.svn.wordpress.org/trunk@33815


git-svn-id: http://core.svn.wordpress.org/trunk@33783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 21:45:23 +00:00
Scott Taylor
b35b167cfc Improve/update escaping in default widgets:
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs

Props welcher.
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33814


git-svn-id: http://core.svn.wordpress.org/trunk@33782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 05:38:21 +00:00
Scott Taylor
42f915273d Improve/update escaping in WP_Widget_Pages.
Props welcher.
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33813


git-svn-id: http://core.svn.wordpress.org/trunk@33781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 04:47:22 +00:00
Scott Taylor
848c40c6a7 Add some theme mod unit tests.
Props MikeHansenMe.
See #28637.

Built from https://develop.svn.wordpress.org/trunk@33812


git-svn-id: http://core.svn.wordpress.org/trunk@33780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:43:22 +00:00
Scott Taylor
107a7104bd Fix the doc block syntax for the 'wp_get_current_commenter' filter.
Props dimadin.
Fixes #33304.

Built from https://develop.svn.wordpress.org/trunk@33811


git-svn-id: http://core.svn.wordpress.org/trunk@33779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-30 03:21:20 +00:00