Commit Graph

22791 Commits

Author SHA1 Message Date
Sergey Biryukov
d3a22f538b Docs: Correct the placement of @global tags in wp-includes/admin-bar.php.
Follow-up to [38810], [56209].

Props shailu25, sabernhardt.
See #60021.
Built from https://develop.svn.wordpress.org/trunk@57747


git-svn-id: http://core.svn.wordpress.org/trunk@57248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-03-01 22:43:11 +00:00
joedolson
bee2debbd7 Customize: Accessibility: Label menu subitems when updating menus.
Fix missing subitem indicator when menu items in the Customizer are children of parent menu items & add menu item original title to button text. Adds parity with the admin menu editor and fixes a bug where the button text was 'untitled' if the menu item title had not been edited.

Props designsimply, afercia, celloexpressions, kushang78, joedolson, rcreators.
Fixes #32728.
Built from https://develop.svn.wordpress.org/trunk@57746


git-svn-id: http://core.svn.wordpress.org/trunk@57247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-03-01 16:21:10 +00:00
Pascal Birchler
1692cf3469 Quick/Bulk Edit: Ensure the “All” checkbox is properly toggled in certain scenarios.
When removing a single item from the bulk edit box or when adding more items, the “All” checkboxes at the top and bottom of the posts list table should be properly toggled.

Props hiteshtalpada, oglekler, webcommsat, ugyensupport, chaion07, Toru.
Fixes #59121.
Built from https://develop.svn.wordpress.org/trunk@57745


git-svn-id: http://core.svn.wordpress.org/trunk@57246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-29 22:02:15 +00:00
Sergey Biryukov
bbe1b7338c Tests: Use assertSame() in post meta revisioning tests.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Includes correcting the test class name.

Follow-up to [56714].

See #59655.
Built from https://develop.svn.wordpress.org/trunk@57744


git-svn-id: http://core.svn.wordpress.org/trunk@57245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-29 20:02:16 +00:00
Pascal Birchler
e265c6d012 Interactivity API: Revert [57742] pending a Gutenberg package update.
This function can only be renamed after updating Gutenberg npm packages, as some of the core blocks already use this function.

See #60575.
Built from https://develop.svn.wordpress.org/trunk@57743


git-svn-id: http://core.svn.wordpress.org/trunk@57244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-29 14:30:12 +00:00
Pascal Birchler
fbeaad601c Interactivity API: Rename data_wp_context() to wp_interactivity_data_wp_context().
Increases clarity about where the function belongs to, bringing it in line with other related functions.

Props swissspidy, gziolo, cbravobernal, youknowriad, ankitmaru, westonruter, luisherranz, darerodz.
Fixes #60575.
Built from https://develop.svn.wordpress.org/trunk@57742


git-svn-id: http://core.svn.wordpress.org/trunk@57243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-29 12:28:09 +00:00
Pascal Birchler
2cf42cec66 Privacy: Update default privacy page content to use latest block markup.
Avoids “Updated Block” warnings being logged to the console.

Props 254volkan, swissspidy.
Fixes #60530.
Built from https://develop.svn.wordpress.org/trunk@57741


git-svn-id: http://core.svn.wordpress.org/trunk@57242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-29 12:17:08 +00:00
youknowriad
f67cb7370e Editor: Prevent infinite loops when filtering the font library folder.
Changing the font library is something we expect hosts to perform.
It's important that we make this filter as seemless as possible.
This commit prevents a potential infinite loop caused by calling wp_get_upload_dir() within the font_dir filter.

Props mmaattiiaass, ironprogrammer, costdev, swissspidy.
Fixes #60652.
Built from https://develop.svn.wordpress.org/trunk@57740


git-svn-id: http://core.svn.wordpress.org/trunk@57241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-29 10:17:07 +00:00
youknowriad
12d738c64c Bundled Theme: Fix focus outline in Twenty Twenty-Four in the editor.
Improvements made to the focus outline style for Twenty Twenty-Four caused a regression in the focus outlines of the block editor. This commit solves the regressions by reducing the CSS specificity while keeping the improvements.

Follow-up to [57554].

Props wildworks, poena, sabernhardt, youknowriad, oglekler.
Fixes #60535.
Built from https://develop.svn.wordpress.org/trunk@57739


git-svn-id: http://core.svn.wordpress.org/trunk@57240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-29 10:08:15 +00:00
dmsnell
91e7a067a8 HTML API: Remove superfluous type-coercing empty() check.
When returning modifiable text in the HTML API, if the text segment
coerces to `false` inside `empty()`, then an empty string has been
returned instead of the string itself. For example, the text node in the
following HTML snippet:

{{{
    <div>0</div>
}}}

In this patch the `empty()` check is removed. The purpose of the original
check was to skip further processing if the text content is empty, but
the check is not needed and the additioanl processing is minimal.
Removing the code removes the defect and leaves a cleaner method in its
absence.

Developed in https://github.com/WordPress/wordpress-develop/pull/6199

Follow-up to [57348]
Follow-up to #60170


Built from https://develop.svn.wordpress.org/trunk@57738


git-svn-id: http://core.svn.wordpress.org/trunk@57239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-28 21:15:12 +00:00
Sergey Biryukov
9c91e0e91c Tests: Expand wp_parse_id_list() unit tests.
Includes:
* Moving pre-existing `wp_parse_id_list()` tests to their own file.
* Merging new and pre-existing `wp_parse_slug_list()` tests.
* Using named data provider in `wp_parse_list()` tests.

Follow-up to [25170], [40044], [44546], [57284], [57725].

Props pbearne, mukesh27, SergeyBiryukov.
Fixes #60218. See #60217, #59647.
Built from https://develop.svn.wordpress.org/trunk@57737


git-svn-id: http://core.svn.wordpress.org/trunk@57238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-28 18:11:09 +00:00
costdev
e21be71af2 Plugin Dependencies: Don't assume API response has a slug property.
Previously, `WP_Plugin_Dependencies::get_dependency_api_data()` attempted to set an array key using the `slug` property returned in a Plugins API response. However, the Plugins API response is filterable and may not contain a `slug` property.

Earlier in the method, a local `$slug` variable is used as a key for the same array.

For safety and consistency, this replaces array key references to `$information->slug` with `$slug`.

Follow-up to [57545].

Props pbiron, afragen, swissspidy, costdev.
Fixes #60540.
Built from https://develop.svn.wordpress.org/trunk@57736


git-svn-id: http://core.svn.wordpress.org/trunk@57237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-28 18:04:09 +00:00
Pascal Birchler
542c23092d Tests: Address capitalization and docblock inconsistencies in some test class names.
Follow-up to [57060], [57718], [57725], [57726], [57727], [57728], [57733].

Props swissspidy, costdev.
See #59647.
Built from https://develop.svn.wordpress.org/trunk@57735


git-svn-id: http://core.svn.wordpress.org/trunk@57236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-28 09:46:08 +00:00
Pascal Birchler
fc91a29646 I18N: Improve docs for pomo library classes.
Props subrataemfluence, pento, hrshahin.
Fixes #44424.
Built from https://develop.svn.wordpress.org/trunk@57734


git-svn-id: http://core.svn.wordpress.org/trunk@57235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-28 09:31:12 +00:00
Sergey Biryukov
fb4f209a8c Tests: Correct capitalization and fix typos in some test class names.
Follow-up to [57060], [57718], [57725], [57726], [57727], [57728].

See #59647.
Built from https://develop.svn.wordpress.org/trunk@57733


git-svn-id: http://core.svn.wordpress.org/trunk@57234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 23:07:08 +00:00
hellofromTonya
6ab3caeb71 General: Revert r57698 for WP_List_Util::pluck().
r57698 caused a regression for arrays of objects which have magic methods and dynamic properties. A fix is identified.

However, a deeper dive discovered additional scenarios which will require a different fix.

Reverting gives more time for resolving these scenarios and more soak time to discover if there are others.

Props dd32, jamescollins, swissspidy.
See #59774.
Built from https://develop.svn.wordpress.org/trunk@57732


git-svn-id: http://core.svn.wordpress.org/trunk@57233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 22:38:15 +00:00
Joe McGill
5f2e2f85f7 Docs: Improve docblock for WP_Block_Patterns_Registry::register.
This documents the new `filePath` property supported by `WP_Block_Patterns_Registry::register` and also updates the property name to camel case formatting to be consistent with other block pattern properties.

Props thekt12, spacedmonkey, joemcgill.
See #59532.

Built from https://develop.svn.wordpress.org/trunk@57731


git-svn-id: http://core.svn.wordpress.org/trunk@57232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 21:05:11 +00:00
Aaron Jorbin
845a537170 Site Icon/Customizer: Update strings in customizer to align with options-general.php.
This uses the new strings for alt text and site icon description that were introduced in [57713] as a part of #54370.

The strings are translated in PHP and then use `wp.i18n.sprintf` since the alt text strings live in a PHP file even though they are output as part of a template that is used in JavaScript.

Props westonruter, swissspidy, jorbin.
Fixes #60641.

Built from https://develop.svn.wordpress.org/trunk@57730


git-svn-id: http://core.svn.wordpress.org/trunk@57231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 20:21:14 +00:00
Pascal Birchler
023f523bda Build/Test Tools: Add unit tests for _delete_option_fresh_site().
Props pbearne, costdev, desrosj.
Fixes #57191.
Built from https://develop.svn.wordpress.org/trunk@57729


git-svn-id: http://core.svn.wordpress.org/trunk@57230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 19:09:04 +00:00
Pascal Birchler
a871d84dec Build/Test Tools: Add unit tests for maybe_hash_hex_color().
Props pbearne.
Fixes #60272.
Built from https://develop.svn.wordpress.org/trunk@57728


git-svn-id: http://core.svn.wordpress.org/trunk@57229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 18:53:05 +00:00
Pascal Birchler
0a5ac751d2 Build/Test Tools: Add unit tests for sanitize_hex_color_no_hash().
Props pbearne.
Fixes #60271.
Built from https://develop.svn.wordpress.org/trunk@57727


git-svn-id: http://core.svn.wordpress.org/trunk@57228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 18:51:04 +00:00
Pascal Birchler
49bc4f9e77 Build/Test Tools: Add unit tests for sanitize_hex_color().
Props pbearne.
Fixes #60270.
Built from https://develop.svn.wordpress.org/trunk@57726


git-svn-id: http://core.svn.wordpress.org/trunk@57227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 18:49:12 +00:00
Pascal Birchler
69a2411a72 Build/Test Tools: Add unit tests for wp_parse_slug_list().
Props pbearne.
Fixes #60217.
Built from https://develop.svn.wordpress.org/trunk@57725


git-svn-id: http://core.svn.wordpress.org/trunk@57226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 17:17:09 +00:00
Pascal Birchler
4d821203f6 Build/Test Tools: Add unit tests for absint().
Props pbearne.
Fixes #60101.
Built from https://develop.svn.wordpress.org/trunk@57724


git-svn-id: http://core.svn.wordpress.org/trunk@57225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 17:15:13 +00:00
Pascal Birchler
569bff821c Post WordPress 6.5 Beta 3 version bump.
Built from https://develop.svn.wordpress.org/trunk@57723


git-svn-id: http://core.svn.wordpress.org/trunk@57224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 16:26:09 +00:00
Pascal Birchler
3eed37d157 WordPress 6.5 Beta 3.
Built from https://develop.svn.wordpress.org/trunk@57722


git-svn-id: http://core.svn.wordpress.org/trunk@57223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 16:14:11 +00:00
youknowriad
d3204b3e7e Editor: Update Packages with the latest bug fixes for 6.5 beta 3
It includes all the backports from this Gutenberg PR https://github.com/WordPress/gutenberg/pull/59394/

Props get_dave, youknowriad.
See #60315.
Built from https://develop.svn.wordpress.org/trunk@57721


git-svn-id: http://core.svn.wordpress.org/trunk@57222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 14:48:23 +00:00
youknowriad
e88758878e Font face resolver: print font faces from font families defined in all theme.json origins.
This commit updates the theme.json style generation to allow a font family name to be repeated across theme.json origins (default, theme, custom).

Props mmaattiiaass, hellofromtonya, arthur791004, ironprogrammer.
Fixes #60605.
Built from https://develop.svn.wordpress.org/trunk@57720


git-svn-id: http://core.svn.wordpress.org/trunk@57221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 12:06:10 +00:00
Pascal Birchler
4fbb3d6975 Docs: Improve wording and add missing full stops in a few docblocks.
Props shailu25, sabernhardt.
Fixes #60323.
Built from https://develop.svn.wordpress.org/trunk@57719


git-svn-id: http://core.svn.wordpress.org/trunk@57220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:29:11 +00:00
Pascal Birchler
139a4c2dc8 Build/Test Tools: Add PHPUnit test for the _mce_set_direction function.
The new test checks the functionality of the text direction setting, ensuring it correctly switches between `rtl` and `ltr` options.

Props pbearne, SergeyBiryukov.
Fixes #60219.
Built from https://develop.svn.wordpress.org/trunk@57718


git-svn-id: http://core.svn.wordpress.org/trunk@57219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:25:05 +00:00
Pascal Birchler
29a2c3a05a Editor: add shadow.defaultPresets to appearance tools opt-ins.
Props madhudollu.
Fixes #60633.
Built from https://develop.svn.wordpress.org/trunk@57717


git-svn-id: http://core.svn.wordpress.org/trunk@57218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:22:11 +00:00
youknowriad
9f0595ab4a Editor: Check for null values in Theme JSON to cater for blockGap.
When resolving theme.json preset variables, add a check to make sure the value is not empty before we run it through strpos() and preg_match_all().

Props ramonopoly, mukesh27, get_dave.
Fixes #60613.
Built from https://develop.svn.wordpress.org/trunk@57716


git-svn-id: http://core.svn.wordpress.org/trunk@57217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-27 10:15:13 +00:00
ryelle
f274631e5c Help/About: Update the About page for 6.5.
Introducing the new content & design for the 6.5 About page & related pages. This style is simplified, with no header images, and brings back the illustrations from previous versions for Contribute, Freedoms, and Privacy.

This also includes a fix for heading hierarchy on the Get Involved page.

Props laurlittle, dansoschin, benjamin_zekavica, richtabor, joen, annezazu, swissspidy, marybaum, ryelle, huzaifaalmesbah.
See #60303.


Built from https://develop.svn.wordpress.org/trunk@57715


git-svn-id: http://core.svn.wordpress.org/trunk@57216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 23:51:12 +00:00
Pascal Birchler
8cdbaf4aeb Upgrade/Install: Improve localized strings related to plugin/theme installation and activation.
Adds context to strings where applicable to disambiguate them, coherently throughout the admin. Also improves some of the strings introduced in [57545] to ease localization.

Props swissspidy, costdev.
Fixes #60630. See #22316.
Built from https://develop.svn.wordpress.org/trunk@57714


git-svn-id: http://core.svn.wordpress.org/trunk@57215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 20:35:08 +00:00
Aaron Jorbin
7173bb9a94 Site icon: Polish up Site Icon on the general settings screen.
This fixes a number of issues, chief among them:
- Updates to the site title are reflected in the preview.
- Improve alt text for preview
- Make string describing site icon more succinct.
- Add inline documentation to JavaScript

Props kebbet, jorbin, swissspidy, afercia, mukesh27, alexstine, jameskoster, andraganescu.
Fixes #54370.


Built from https://develop.svn.wordpress.org/trunk@57713


git-svn-id: http://core.svn.wordpress.org/trunk@57214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 20:18:09 +00:00
Sergey Biryukov
0eb0449db0 Twenty Nineteen: Further adjust CSS selectors used to change the primary color.
This aims to make the file, button, quote, pullquote, and search block selectors work on multiple WordPress versions.

Follow-up to [57637].

Props poena, mukesh27.
Fixes #59922.
Built from https://develop.svn.wordpress.org/trunk@57712


git-svn-id: http://core.svn.wordpress.org/trunk@57213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 16:27:12 +00:00
Pascal Birchler
60b72e87d7 Login and Registration: Slash email address when updating an existing user.
Addresses an issue with password reset keys when the email address contains special characters such as apostrophes.

Props emirpprime, rajinsharwar, fnpen, hellofromTonya, oglekler, nicolefurlan.
Fixes #52529.
Built from https://develop.svn.wordpress.org/trunk@57711


git-svn-id: http://core.svn.wordpress.org/trunk@57212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 10:43:06 +00:00
Pascal Birchler
4096795c61 Tests: Update incorrect assertion message added in [57366].
Props david.binda.
Fixes #60358.
Built from https://develop.svn.wordpress.org/trunk@57710


git-svn-id: http://core.svn.wordpress.org/trunk@57211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 10:29:13 +00:00
joedolson
28c8ff0d1b Code Standards: Fix alignment in tests.
Fix variable alignment in changed tests. Follow-up to [r57708]. Because I edited the wrong local copy when I fixed that.

Props joedolson.
See #34668.
Built from https://develop.svn.wordpress.org/trunk@57709


git-svn-id: http://core.svn.wordpress.org/trunk@57210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 01:00:09 +00:00
joedolson
059878b96d Toolbar: Accessibility: Keyboard navigation for screen readers.
Change the admin toolbar to have `role="menu"` and support opening for screen readers. Remove screen reader only log out link and collapse duplicate profile links into one link. This is an imperfect solution to a complex problem in the adminbar, but the lack of screen reader access to submenus is a major accessibility problem, and this fix provides access, even if the mechanism is imperfect.

Screen reader log out added in [21452].

Props abletec, Cheffheid, sabernhardt, alexstine, joedolson, afercia, sparklingrobots, danieltj, swissspidy, netweb, dionysous.
Fixes #34668, #43633.
Built from https://develop.svn.wordpress.org/trunk@57708


git-svn-id: http://core.svn.wordpress.org/trunk@57209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-26 00:52:10 +00:00
Peter Wilson
25ae4b9733 Upgrade/Install: Normalize major versions in is_wp_version_compatible().
Modify `is_wp_version_compatible()` to return the expected result for major WordPress versions formatted as either `x.x` or `x.x.0` (for example `6.5` and `6.5.0`).

The WordPress project currently documents major version numbers in both formats leading to confusion for developers using the `is_wp_version_compatible()` function. As the PHP function `version_compare()` treats `x.x` and `x.x.0` as different version numbers this leads to unexpected results in the WP function.

This change removes a trailing `.0` from major version numbers to account for the WordPress project using the two formats interchangeably.

Props afragen, azaozz, costdev, joemcgill, jorbin, kkmuffme, sessioncookiemonster, swissspidy, wazeter.
Fixes #59448.

Built from https://develop.svn.wordpress.org/trunk@57707


git-svn-id: http://core.svn.wordpress.org/trunk@57208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-25 22:17:13 +00:00
Sergey Biryukov
448030d355 Tests: Use assertSame() in new_admin_email_subject filter test.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [57283].

See #59655.
Built from https://develop.svn.wordpress.org/trunk@57706


git-svn-id: http://core.svn.wordpress.org/trunk@57207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-25 15:27:12 +00:00
Sergey Biryukov
08d311ae83 Tests: Use assertSame() in comment_exists() tests.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [34456], [34460].

Props costdev.
See #59655.
Built from https://develop.svn.wordpress.org/trunk@57705


git-svn-id: http://core.svn.wordpress.org/trunk@57206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-24 19:30:12 +00:00
Pascal Birchler
f5487209cb I18N: Do not set translation controller locale in bootstrap.
Removes the `WP_Translation_Controller::set_locale()` call from `wp-settings.php`, which happened before the current user was loaded.
That caused translations to be missing when the site locale and user locale were different, as the translation was associated with the wrong locale.

Turns out this call was not needed at all, as the locale will be set/updated when calling `load_textdomain()` anyway.

Props oglekler.
See #59656.
Built from https://develop.svn.wordpress.org/trunk@57704


git-svn-id: http://core.svn.wordpress.org/trunk@57205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-24 09:48:13 +00:00
Joe McGill
c5f64356af Editor: Improve PHPUnit tests for block pattern registration.
This is a followup to [57683], which adds additional unit test coverage to ensure block pattern content is not loaded from files during registration, but instead when those patterns are accessed. This also improves the `set_up` and `tear_down` methods for the `Tests_Blocks_wpBlockPattersRegistry` test class to ensure that any modifications made to registered blocks during the tests are reset after each test.

Props thekt12, joemcgill.
See #59532.

Built from https://develop.svn.wordpress.org/trunk@57703


git-svn-id: http://core.svn.wordpress.org/trunk@57204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 16:55:13 +00:00
Pascal Birchler
bad9e9669d Build/Test Tools: Update JSHint config to remove deprecated options.
Removes deprecated options that no longer have any effect, and updates the targeted ES version in line with WordPress’ browser support.

This change mostly allows new code to properly use trailing commas, as added by the Prettier formatter.

Future efforts should rather go towards adopting ESLint for code formatting, see #31823.

Props netweb.
Fixes #28236.
Built from https://develop.svn.wordpress.org/trunk@57702


git-svn-id: http://core.svn.wordpress.org/trunk@57203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 10:38:13 +00:00
Sergey Biryukov
096df041b6 Docs: Add a @since note for $preferred_ext parameter in wp_mime_type_icon().
Follow-up to [57687].

See #31352.
Built from https://develop.svn.wordpress.org/trunk@57701


git-svn-id: http://core.svn.wordpress.org/trunk@57202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 09:43:12 +00:00
gziolo
4084114eab Editor: Add id to the supported Image's binding attributes
Syncs changes from the Gutenberg plugin: https://github.com/WordPress/gutenberg/pull/59194.

Fixes #60577.
Props kevin940726, ankit-k-gupta, sonali844, harshalkadu, gziolo.


Built from https://develop.svn.wordpress.org/trunk@57700


git-svn-id: http://core.svn.wordpress.org/trunk@57201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 09:20:12 +00:00
K. Adam White
9a3210759f Script Loader: Inject wp_remove_surrounding_empty_script_tags function name in returned error string using sprintf.
The name of this function should not be editable by the translator in the internationalized return error string.

Props naoki0h, swissspidy, kirasong.
Fixes #60590.

Built from https://develop.svn.wordpress.org/trunk@57699


git-svn-id: http://core.svn.wordpress.org/trunk@57200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-23 05:45:12 +00:00
hellofromTonya
648cab6abe General: Handle missing field in WP_List_Util::pluck().
Handles when the `$field` (i.e. key or property) is missing in one of the `$input_list` items by checking the key (array) or property (object) exists before using it for assignment.

Resolves the following bugs:

* a PHP warning for undefined key|property.
* `null` being set for that array or object within the returned list.

The changes resolve the issues in both `WP_List_Util::pluck()` (if invoked directly) and `wp_list_pluck()`.

Also includes an additional test for the scenario where the `wp_list_pluck()` `$index_key` is not `null`, the `$field` is missing in one of the `$input_list` items.

Follow-up to [55423], [51663], [42527], [38928].

Props iamarunchaitanyajami, davidbinda, hellofromTonya, helgatheviking.
Fixes #59774.
Built from https://develop.svn.wordpress.org/trunk@57698


git-svn-id: http://core.svn.wordpress.org/trunk@57199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-02-22 21:52:10 +00:00