Commit Graph

21326 Commits

Author SHA1 Message Date
Andrew Nacin
45e3d73a05 Add a sane, inclusive HTML element/attribute schema to TinyMCE.
TinyMCE 3.4.x (shipped with WordPress 3.4.x) had an HTML4-based schema definition, with HTML5 elements added to it. TinyMCE 3.5.x (shipping, again coincidentally, with WordPress 3.5) allows for HTML5 schema support, which also provides for full HTML5 attribute support. The problem is its HTML5 schema excludes all HTML4 elements and attributes that were dropped in the HTML5 spec, which is unacceptable behavior.

This "duck punch" of TinyMCE's Schema.js file creates a new, sane schema. It is TinyMCE's HTML4 and HTML5 schema definitions recursively merged.

Objects are not whitelisted in either schema to allow for embed elements as child nodes, so object, param, and embed remain separately whitelisted in the WordPress TinyMCE plugin. Our attempts to add other attributes in said plugin is now superceded.

props koopersmith, azaozz.
fixes #22790.



git-svn-id: http://core.svn.wordpress.org/trunk@23120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 11:26:25 +00:00
Andrew Nacin
f805463013 Add TinyMCE 3.5.8's Schema.js file in preparation for monkey patching it. see #22790.
git-svn-id: http://core.svn.wordpress.org/trunk@23119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 11:12:51 +00:00
Daryl Koopersmith
a16ff29d7b Ensure iframes in the media modal on the frontend have no borders. props nacin. fixes #22804.
git-svn-id: http://core.svn.wordpress.org/trunk@23118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 10:27:07 +00:00
Ryan Boren
54ac1d939b Make current_user_can_for_blog() safe to run single site.
Props nacin, MarkJaquith
fixes #22803


git-svn-id: http://core.svn.wordpress.org/trunk@23117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 09:53:27 +00:00
Lance Willett
4e22d6fbab Twenty Twelve: set color values to black to ensure full text color contrast in print styles. Props miqrogroove, fixes #22797.
git-svn-id: http://core.svn.wordpress.org/trunk@23116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 01:38:57 +00:00
Bot (Assets)
601825e9d3 Compress scripts/styles: 3.5-RC4-23115.
git-svn-id: http://core.svn.wordpress.org/trunk@23115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 01:15:44 +00:00
Andrew Nacin
801db6b731 Remove trailing comma from JS. props koopersmith, fixes #22800.
git-svn-id: http://core.svn.wordpress.org/trunk@23114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 01:13:04 +00:00
Bot (Assets)
d50dfe71f3 Compress scripts/styles: 3.5-RC4-23113. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@23113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 00:07:33 +00:00
Ryan Boren
cb74a5617a Extend allowed elements for object and embed.
Props azaozz
fixes #22790


git-svn-id: http://core.svn.wordpress.org/trunk@23112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 00:05:54 +00:00
Bot (Assets)
0515e2e6a5 Compress scripts/styles: 3.5-RC4-23111.
git-svn-id: http://core.svn.wordpress.org/trunk@23111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 23:17:49 +00:00
Ryan Boren
eaefa67006 When inserting from URL in the media modal, retain query params and properly insert the caption code.
Props koopersmith
fixes #22796


git-svn-id: http://core.svn.wordpress.org/trunk@23110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 23:12:59 +00:00
Andrew Nacin
a90521652e Final screenshot on the about page for the media manager.
props lessbloat.
props matt for the photos.

fixes #22455.



git-svn-id: http://core.svn.wordpress.org/trunk@23109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 19:49:42 +00:00
Andrew Nacin
ab8e39d6ad 3.5-RC4.
git-svn-id: http://core.svn.wordpress.org/trunk@23108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:45:32 +00:00
Andrew Nacin
72d8ca4770 Use $current_site->path instead of $base in wpmu_validate_blog_signup(), as $base is now dead. props MarkJaquith. fixes #22787. see #19796.
git-svn-id: http://core.svn.wordpress.org/trunk@23107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:43:52 +00:00
Andrew Nacin
cfe6e9ed09 Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786.
git-svn-id: http://core.svn.wordpress.org/trunk@23106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:21:27 +00:00
Andrew Nacin
c665bf6ff3 A neditor is a curious multi-celled organism found deep in the Content Management System "WordPress". It generally subsides on good content. It has an obsession with retina-quality graphical elements, and also has a strong affinity for puns. Occasionally, ACCIDENTAL CAPS LOCK occurs. Some organisms carry British accents; these are prone to changing state but then reverting to their previous state soon after. One has shown superior sleuthing abilities, despite having hardly left its Uni laboratory. Organisms from Australia are usually found deeper in the Content Management System, most of its energy spent on locomotion.
The attitude of a neditor is best described as cranky optimism. Younger organisms are more eager, but quickly tire after working on little sleep. They eventually evolve into the cranky optimism stage in a process that generally takes three to five months.



git-svn-id: http://core.svn.wordpress.org/trunk@23105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:01:11 +00:00
Bot (Assets)
0840b6c36d Compress scripts/styles: 3.5-RC3-23104.
git-svn-id: http://core.svn.wordpress.org/trunk@23104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 08:13:44 +00:00
Andrew Nacin
8b20551951 Image editors: After cropping, request new sizes from the image. If we rely on the values passed in, they may be floats. We must see what the image results in.
Cast in update_size() for sanity.

props DH-Shredder.
fixes #22779.



git-svn-id: http://core.svn.wordpress.org/trunk@23103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 07:56:04 +00:00
Lance Willett
3bb105109b Twenty Twelve: fix skewed gallery thumbnail images in IE8 by adding selectors to match attachment thumbnails and any mix-and-match of full-size and large-size image that may occur in content. Fixes #22782.
git-svn-id: http://core.svn.wordpress.org/trunk@23102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 07:16:31 +00:00
Andrew Nacin
34e2ed377a Break wp_print_media_templates() into wp-includes/media-template.php and lazy-load that file through wp_enqueue_media(). fixes #22778.
git-svn-id: http://core.svn.wordpress.org/trunk@23101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 07:10:20 +00:00
Andrew Nacin
c29cae34d0 Properly apply CSS and an ID attribute to the select files container. props koopersmith. fixes #22780. see #22762.
git-svn-id: http://core.svn.wordpress.org/trunk@23100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 07:00:41 +00:00
Bot (Assets)
395f2b5073 Compress scripts/styles: 3.5-RC3-23099.
git-svn-id: http://core.svn.wordpress.org/trunk@23099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 06:58:33 +00:00
Andrew Nacin
2d9b708b6e Media: When the attachment details view changes to another view or attachment, save compat fields on destroy. (We already do this for non-compat fields.) props koopersmith. fixes #22776.
git-svn-id: http://core.svn.wordpress.org/trunk@23098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 06:56:06 +00:00
Mark Jaquith
1aca97360e Remove the "Describe this ___" string on captions in the attachment details view. WP <3 patches with net red. props helenyhou. fixes #22777
git-svn-id: http://core.svn.wordpress.org/trunk@23097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 06:35:13 +00:00
Mark Jaquith
d5eafd1b1f Present the correct downsized image dimensions in the Media modal when inserting. Introduces a context parameter for image_constrain_size_for_editor() instead of relying on is_admin(). props jond3r, nacin. fixes #22738
git-svn-id: http://core.svn.wordpress.org/trunk@23096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 06:25:39 +00:00
Mark Jaquith
1419b404a8 Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743. props koopersmith, nacin, helenyhou.
git-svn-id: http://core.svn.wordpress.org/trunk@23095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:52:19 +00:00
Mark Jaquith
68524f7c6f Run the attachment_fields_to_save filter even if we don't get the fields we used to get. props nacin. fixes #22774
git-svn-id: http://core.svn.wordpress.org/trunk@23094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:34:17 +00:00
Bot (Assets)
dd4f8b9273 Compress scripts/styles: 3.5-RC3-23093.
git-svn-id: http://core.svn.wordpress.org/trunk@23093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:26:39 +00:00
Daryl Koopersmith
30440dbb66 Add a canonical location for media frames, an alias to fetch attachments, and frame caching to custom header. fixes #22775.
git-svn-id: http://core.svn.wordpress.org/trunk@23092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:06:49 +00:00
Bot (Assets)
c4ef3fe74c Compress scripts/styles: 3.5-RC3-23091. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@23091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 04:58:34 +00:00
Andrew Ozz
449156f3c8 Upgrade to TinyMCE 3.5.8, fixes #22755
git-svn-id: http://core.svn.wordpress.org/trunk@23090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 04:50:31 +00:00
Mark Jaquith
54a390bea9 New method of managing media selections. There is now a "master" selection in the background. props koopersmith. fixes #22725
* This especially helps when you switch between insert/gallery and have non-images selected (as galleries don't support non-images).
* The views now act as filters on the "master" selection, instead of having their own selections that get passed around.

git-svn-id: http://core.svn.wordpress.org/trunk@23089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:55:37 +00:00
Andrew Nacin
08401b9e3c Fix branchhing in edit_post() where attachment_fields_to_save would only run when the alt text was sent. It should run whenever an attachment is saved. props sc0ttclark. fixes #22774.
git-svn-id: http://core.svn.wordpress.org/trunk@23088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:50:31 +00:00
Andrew Nacin
e09094434e Restore captions for non-image attachments. see #22759.
git-svn-id: http://core.svn.wordpress.org/trunk@23087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:36:17 +00:00
Daryl Koopersmith
8efc323e2e Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769.
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:28:21 +00:00
Daryl Koopersmith
c75dc67668 Do not alter the body's overflow attribute when the media modal is opened. Fix image insertion in the visual editor in Firefox. props azaozz. fixes #22765.
git-svn-id: http://core.svn.wordpress.org/trunk@23085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:15:39 +00:00
Bot (Assets)
4f3c1bb8f1 Compress scripts/styles: 3.5-RC3-23084.
git-svn-id: http://core.svn.wordpress.org/trunk@23084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:42:44 +00:00
Andrew Nacin
173806d7a1 Restore the Description field to the media UI in 3.5.
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Andrew Nacin
a13a011265 Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767.
git-svn-id: http://core.svn.wordpress.org/trunk@23082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:51:24 +00:00
Andrew Nacin
ce11438e77 Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764. see #21240, #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@23081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:49:51 +00:00
Bot (Assets)
7dab3d4538 Compress scripts/styles: 3.5-RC3-23080.
git-svn-id: http://core.svn.wordpress.org/trunk@23080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 21:22:59 +00:00
Ryan Boren
52a9a8cb81 Fix uploads in IE9
Props koopersmith
fixes #22762


git-svn-id: http://core.svn.wordpress.org/trunk@23079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 21:21:17 +00:00
Bot (Assets)
5927d8a3db Compress scripts/styles: 3.5-RC3-23078.
git-svn-id: http://core.svn.wordpress.org/trunk@23078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:22:54 +00:00
Andrew Nacin
b1ba49f26e Media: Account for the most obvious and common style conflicts that may occur when the media modal is loaded on the frontend. Tested primarily with P2. props lessbloat, helenyhou. fixes #22752.
git-svn-id: http://core.svn.wordpress.org/trunk@23077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:15:40 +00:00
Andrew Nacin
88f61468b3 Media: Final names for the actions in the dialog sidebar: "Insert from URL" and "Set Featured Image" to go with "Insert Media" and "Create Gallery".
Longer strings (such as a translation) looks excellent when it wraps to another line.

props markjaquith, fixes #22753.



git-svn-id: http://core.svn.wordpress.org/trunk@23076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:07:48 +00:00
Andrew Nacin
c42ae7acb6 Media: Use '%d selected' for the selection string, and offer a comment to translators to help them find a workable solution with this would-be plural string. fixes #22749. see #22229.
git-svn-id: http://core.svn.wordpress.org/trunk@23075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:03:38 +00:00
Andrew Nacin
2763e74dd8 Script loader: Chunk the script names as passed to load-scripts.php into 128-character pieces. Avoids hitting a limit for the length of a single variable, such as suhosin.get.max_value_length which defaults to 512. fixes #22757.
git-svn-id: http://core.svn.wordpress.org/trunk@23074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 18:57:56 +00:00
Bot (Assets)
fb433d2597 Compress scripts/styles: 3.5-RC3-23073.
git-svn-id: http://core.svn.wordpress.org/trunk@23073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:58:32 +00:00
Mark Jaquith
bc8ddb3e64 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Mark Jaquith
298d374b81 Better responsive breakpoints for the Gallery editing screen. props koopersmith. fixes #22741
git-svn-id: http://core.svn.wordpress.org/trunk@23071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:15:42 +00:00