John Blackbourn
905460bd5e
Docs: Standardise the type name for booleans and integers.
...
This brings these docs inline with the documentation standards.
Props ravipatel, justinahinon
Fixes #51426
Built from https://develop.svn.wordpress.org/trunk@49120
git-svn-id: http://core.svn.wordpress.org/trunk@48882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-10 20:02:05 +00:00
Sergey Biryukov
897f004a9c
General: Replace older-style PHP type conversion functions with type casts.
...
This improves performance, readability, and consistency throughout core.
* `intval()` → `(int)`
* `strval()` → `(string)`
* `floatval()` → `(float)`
Props ayeshrajans.
Fixes #42918 .
Built from https://develop.svn.wordpress.org/trunk@49108
git-svn-id: http://core.svn.wordpress.org/trunk@48870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-08 21:15:13 +00:00
Sergey Biryukov
1f85e7484f
Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48782
git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 00:34:08 +00:00
Sergey Biryukov
30e0cf9fcd
Docs: Bundled Themes: Correct DocBlock placement for custom header and background argument filters.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48264
git-svn-id: http://core.svn.wordpress.org/trunk@48033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 13:52:01 +00:00
desrosj
4b60af1a6a
General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.
...
“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”
With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the `$new_whitelist_options` global variable) are removed. A new ticket has been opened to explore renaming the `$new_whitelist_options` variable (#50434 ).
Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.
Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.
Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900 , #50434 .
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48121
git-svn-id: http://core.svn.wordpress.org/trunk@47890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 17:26:13 +00:00
Sergey Biryukov
e13c363b17
Docs: Capitalize "ID", when referring to a post ID, term ID, etc. in a more consistent way.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48104
git-svn-id: http://core.svn.wordpress.org/trunk@47873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:02:12 +00:00
Sergey Biryukov
de59ad23a4
Docs: Consistently include an empty line between @since
tag and @see
, @link
, or @global
, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48067
git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 21:07:14 +00:00
Sergey Biryukov
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
38676936ba
Coding Standards: Use strict type check for in_array()
and array_search()
where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47550
git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov
641c632b0c
Coding Standards: Use Yoda conditions where appropriate.
...
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47219
git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:55:09 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Sergey Biryukov
83187125e4
Bundled Themes: Audit and update version numbers passed to wp_enqueue_script()
to ensure proper cache busting.
...
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981 .
Built from https://develop.svn.wordpress.org/trunk@45768
git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
Sergey Biryukov
ac10f9b9e4
Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article.
...
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771 .
Built from https://develop.svn.wordpress.org/trunk@45675
git-svn-id: http://core.svn.wordpress.org/trunk@45486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 22:46:55 +00:00
Gary Pendergast
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Gary Pendergast
0d23be600e
Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments
violations in the default themes.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45581
git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:23:57 +00:00
Adam Silverstein
18ccaf962e
Bundled Theme: add a wp_body_open
shim for older WordPress versions.
...
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.
Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679 .
Built from https://develop.svn.wordpress.org/trunk@45256
git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 13:04:56 +00:00
Sergey Biryukov
37f04694d5
Bundled Themes: Use consistent HTML comments after closing HTML tags.
...
Props iamdmitrymayorov.
Fixes #46871 .
Built from https://develop.svn.wordpress.org/trunk@45209
git-svn-id: http://core.svn.wordpress.org/trunk@45018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 01:30:53 +00:00
Gary Pendergast
7a617078fa
Coding Standards: Upgrade WPCS to 1.2.1.
...
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.
Fixes #45956 .
Built from https://develop.svn.wordpress.org/trunk@44574
git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Sergey Biryukov
510feac5bb
Twenty Fourteen: Remove redundant @access
and @static
notations from classes.
...
Props birgire.
See #41452 , #42803 , #42505 .
Built from https://develop.svn.wordpress.org/trunk@42749
git-svn-id: http://core.svn.wordpress.org/trunk@42579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:49:30 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Weston Ruter
7af3b92736
Media: Upgrade MediaElement.js from 2.22.0 to 4.2.3.
...
Props rafa8626, grosbouff, westonruter, azaozz, Plastikschnitzer for testing.
See #39686 .
Built from https://develop.svn.wordpress.org/trunk@41198
git-svn-id: http://core.svn.wordpress.org/trunk@41038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-08-01 04:43:51 +00:00
David A. Kennedy
ca0274c2ce
Bundled Themes: Allow category display in post preview even when only one category
...
The category is not shown in the preview. And because of how `themename_categorized_blog()` function in each theme returns false for 1 or fewer categories, and in this case it won't show the new category.
The patch uses `is_preview()` to fix that in Twenty Fourteen, Fifteen and Seventeen.
Props lancewillett.
Fixes #39531 .
Built from https://develop.svn.wordpress.org/trunk@40023
git-svn-id: http://core.svn.wordpress.org/trunk@39960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-27 22:09:42 +00:00
Tammie Lister
9ef40ced2f
Twenty Fourteen: Removes video header support
...
Support was added to test implementation but never completed. This removes the test implementation.
Props davidakennedy
Fixes #38783
Built from https://develop.svn.wordpress.org/trunk@39226
git-svn-id: http://core.svn.wordpress.org/trunk@39166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-14 17:17:31 +00:00
Joe McGill
030bc377dd
Themes: Enable video in custom headers.
...
This adds the ability for themes to add support for videos in custom headers
by passing `'video' => true` as an argument when adding theme support for
custom headers.
Custom video headers are managed through the “Header Visuals” (i.e. “Header Image”)
panel in the Customizer where you can select a video from the media library or set a
URL to an external video (YouTube for now) for use in custom headers.
This introduces several new functions:
`has_header_video()` – Check whether a header video is set or not.
`get_header_video_url()` – Retrieve header video URL for custom header.
`the_header_video_url()` – Display header video URL.
`get_header_video_settings()` – Retrieve header video settings.
`has_custom_header()` – Check whether a custom header is set or not.
`get_custom_header_markup()` – Retrieve the markup for a custom header.
`the_custom_header_markup()` – Print the markup for a custom header.
And a new file, `wp-includes/js/wp-custom-header.js` that handles loading videos
in custom headers.
This also enables video headers in the Twenty Seventeen and Twenty Fourteen themes.
Props davidakennedy, celloexpressions, bradyvercher, laurelfulford, joemcgill.
Fixes #38172 .
Built from https://develop.svn.wordpress.org/trunk@38985
git-svn-id: http://core.svn.wordpress.org/trunk@38928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-27 21:51:31 +00:00
Weston Ruter
f3f84d2f21
Customize: Require opt-in for selective refresh of widgets.
...
* Introduces `customize-selective-refresh-widgets` theme support feature and adds to themes.
* Introduces `customize_selective_refresh` arg for `WP_Widget::$widget_options` and adds to all core widgets.
* Remove `selective_refresh` from being a component that can be removed via `customize_loaded_components` filter.
* Add `WP_Customize_Widgets::get_selective_refreshable_widgets()` and `WP_Customize_Widgets::is_widget_selective_refreshable()`.
* Fix default `selector` for `Partial` instances.
* Implement and improve Masronry sidebar refresh logic in Twenty Thirteen and Twenty Fourteen, including preservation of initial widget position after refresh.
* Re-initialize ME.js when refreshing `Twenty_Fourteen_Ephemera_Widget`.
See #27355 .
Fixes #35855 .
Built from https://develop.svn.wordpress.org/trunk@37040
git-svn-id: http://core.svn.wordpress.org/trunk@37007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-21 21:59:29 +00:00
Weston Ruter
f78775a6db
Customize: Use selective refresh to preview changes to site title and tagline in core themes.
...
Fixes issue where `wptexturize` and other filters fail to apply when previewing changes via `postMessage` transport.
See #27355 .
Fixes #33738 .
Built from https://develop.svn.wordpress.org/trunk@36797
git-svn-id: http://core.svn.wordpress.org/trunk@36764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-01 22:18:26 +00:00
Dominik Schilling
e5ea82d81a
Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
...
Props obrienlabs, thewanderingbrit.
Fixes #34887 .
Built from https://develop.svn.wordpress.org/trunk@36709
git-svn-id: http://core.svn.wordpress.org/trunk@36676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-25 12:53:27 +00:00
Dominik Schilling
64fc7294b6
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@32116
git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Sergey Biryukov
31c11b1f0d
Bundled themes: After [31453], replace current()
with reset()
, which is guaranteed to be the first item.
...
see #31259 , #31260 .
Built from https://develop.svn.wordpress.org/trunk@31842
git-svn-id: http://core.svn.wordpress.org/trunk@31824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 02:04:27 +00:00
Drew Jaynes
64bc6934f1
Add an entry to the changelog for twentyfourteen_post_thumbnail()
noting that it was made 'pluggable'.
...
Fixes #31374 .
Built from https://develop.svn.wordpress.org/trunk@31482
git-svn-id: http://core.svn.wordpress.org/trunk@31463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 10:35:28 +00:00
Lance Willett
5dc3b77be3
Twenty Fourteen: make twentyfourteen_post_thumbnail()
pluggable.
...
Fixes #31374 , props wordpressorru.
Built from https://develop.svn.wordpress.org/trunk@31481
git-svn-id: http://core.svn.wordpress.org/trunk@31462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-19 19:43:28 +00:00
Lance Willett
86a133a79a
Bundled themes: replace array_shift()
with current()
for performance.
...
Props SergeyBiryukov, fixes #31260 .
Built from https://develop.svn.wordpress.org/trunk@31453
git-svn-id: http://core.svn.wordpress.org/trunk@31434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 17:52:27 +00:00
Lance Willett
17f69a89d4
Twenty Fourteen: fix escaping and minor code style issues. See #29127 .
...
Built from https://develop.svn.wordpress.org/trunk@31250
git-svn-id: http://core.svn.wordpress.org/trunk@31231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 19:03:23 +00:00
John Blackbourn
64fb3e7175
In Twenty Fourteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised.
...
See #30641
Built from https://develop.svn.wordpress.org/trunk@30796
git-svn-id: http://core.svn.wordpress.org/trunk@30786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 18:57:24 +00:00
Lance Willett
f398bd07ce
Twenty Fourteen: replace ellipses appended to automatically generated excerpts with both ellipses and a "Continue Reading" link to meet accessibility-ready requirements.
...
Props davidakennedy, lancewillett. Fixes #30176 .
Built from https://develop.svn.wordpress.org/trunk@30389
git-svn-id: http://core.svn.wordpress.org/trunk@30386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 18:27:22 +00:00
Lance Willett
d2b903f896
Twenty Fourteen: improve post thumbnail HTML output.
...
* Add `aria-hidden` attribute to reduce verbosity on archive pages.
* Add alt text in archives to avoid confusing link texts, see #30076 for context in Twenty Fifteen.
Props hiwhatsup, joedolson. Fixes #30144 .
Built from https://develop.svn.wordpress.org/trunk@30387
git-svn-id: http://core.svn.wordpress.org/trunk@30384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 18:12:21 +00:00
Lance Willett
c604fd15b0
Twenty Fourteen: fix keyboard focus on Appearance > Header view.
...
Props florianziegler, fixes #29787 .
Built from https://develop.svn.wordpress.org/trunk@30146
git-svn-id: http://core.svn.wordpress.org/trunk@30146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:44:23 +00:00
Lance Willett
6ddbf3c8bd
Twenty Fourteen: Make featured content in Customizer contextual to the front page.
...
Props celloexpressions, fixes #29578 .
Built from https://develop.svn.wordpress.org/trunk@30143
git-svn-id: http://core.svn.wordpress.org/trunk@30143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:26:21 +00:00
Dominik Schilling
61819a36ea
Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
...
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/ .
props studionashvegas, tareq1988.
fixes #29947 .
Built from https://develop.svn.wordpress.org/trunk@29903
git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Sergey Biryukov
05fb60ae78
Twenty Fourteen: Move custom description for background color and image from sections to controls in the customizer.
...
props jb510.
fixes #29490 .
Built from https://develop.svn.wordpress.org/trunk@29827
git-svn-id: http://core.svn.wordpress.org/trunk@29592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-03 08:43:15 +00:00
Sergey Biryukov
b9357c40eb
Twenty Fourteen: Use correct check for the front page in Featured_Content::pre_get_posts().
...
props kwight.
fixes #29550 .
Built from https://develop.svn.wordpress.org/trunk@29719
git-svn-id: http://core.svn.wordpress.org/trunk@29493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-07 14:23:17 +00:00
Sergey Biryukov
b7c94cee0b
Twenty Fourteen: Remove unused variable after [27120].
...
props michalzuber.
fixes #28928 .
Built from https://develop.svn.wordpress.org/trunk@29210
git-svn-id: http://core.svn.wordpress.org/trunk@28994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 19:09:14 +00:00
Lance Willett
f5fcb58404
Twenty Fourteen: optimize featured content lookup to reduce the number of queries for featured posts. Props Chouby and obenland, closes #26744 .
...
Built from https://develop.svn.wordpress.org/trunk@29174
git-svn-id: http://core.svn.wordpress.org/trunk@28958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 06:44:15 +00:00
Lance Willett
e90f45e031
Twenty Fourteen: pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@29169
git-svn-id: http://core.svn.wordpress.org/trunk@28953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 17:49:15 +00:00
Lance Willett
65c6477bc3
Twenty Fourteen: RTL display adjustment for Custom Header, props yoavf. Fixes #28670 .
...
Built from https://develop.svn.wordpress.org/trunk@29167
git-svn-id: http://core.svn.wordpress.org/trunk@28951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 17:41:15 +00:00
Lance Willett
c2f0505bcf
Twenty Fourteen: change hardcoded pagination base to use the WordPress Rewrite object's pagination_base
value instead. Document global variable usage properly.
...
Props SergeyBiryukov, fixes #28405 .
Built from https://develop.svn.wordpress.org/trunk@28645
git-svn-id: http://core.svn.wordpress.org/trunk@28463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-31 18:51:19 +00:00
Sergey Biryukov
7de1eac464
Twenty Fourteen: Bail early from Featured_Content::hide_featured_term() if term objects are unavailable.
...
fixes #28072 .
Built from https://develop.svn.wordpress.org/trunk@28536
git-svn-id: http://core.svn.wordpress.org/trunk@28362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 09:25:15 +00:00
Sergey Biryukov
9998560152
Twenty Fourteen: Avoid a PHP notice in Ephemera widget.
...
props jartes.
fixes #28055 .
Built from https://develop.svn.wordpress.org/trunk@28248
git-svn-id: http://core.svn.wordpress.org/trunk@28076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 18:46:17 +00:00