Gary Pendergast
f9208ac14e
Tests: Improve REST API tests for categories and tags.
...
Props birgire, SergeyBiryukov.
See #39122 .
Fixes #45077 .
Built from https://develop.svn.wordpress.org/trunk@44510
git-svn-id: http://core.svn.wordpress.org/trunk@44341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:31:51 +00:00
Gary Pendergast
0062616aa7
Build/Tests: Default to running unit tests from src
.
...
This is the actual commit, unlike [44508], which was not.
Props atimmer.
See #44492 .
Fixes #45863 .
Built from https://develop.svn.wordpress.org/trunk@44509
git-svn-id: http://core.svn.wordpress.org/trunk@44340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:14:55 +00:00
Gary Pendergast
e0caaf7628
Build/Tests: Default to running unit tests from src
.
...
This commit also defaults WP-CLI commands to running against `src`, too.
Props atimmer, pento.
See #44492 .
Fixes #45863 .
Built from https://develop.svn.wordpress.org/trunk@44508
git-svn-id: http://core.svn.wordpress.org/trunk@44339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:10:51 +00:00
Dominik Schilling
6503f77539
Build/Tools: Fix typo in phpcs.xml.dist
.
...
See #44366 .
Built from https://develop.svn.wordpress.org/trunk@44507
git-svn-id: http://core.svn.wordpress.org/trunk@44338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:02:53 +00:00
Gary Pendergast
9f25ea37c7
Filesystem: Improve wp_is_stream()
performance.
...
Instead of turning the return value of `stream_get_wrappers()` into a regex to match the scheme, we can instead extract the scheme and search the return value of `stream_get_wrappers()`.
Props schlessera, swissspidy.
Fixes #45553 .
Built from https://develop.svn.wordpress.org/trunk@44506
git-svn-id: http://core.svn.wordpress.org/trunk@44337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 09:51:54 +00:00
Peter Wilson
184c501d5c
Cron: Fix undefined variable notice.
...
Restore `$gmt_time` variable removed in error from [44483].
Props afragen.
Fixes #45870 .
Built from https://develop.svn.wordpress.org/trunk@44505
git-svn-id: http://core.svn.wordpress.org/trunk@44336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 08:37:51 +00:00
Gary Pendergast
f88769fc3b
Block Editor: Obey the AUTOSAVE_INTERVAL
constant.
...
Props youknowriad.
Fixes #45262 .
Built from https://develop.svn.wordpress.org/trunk@44504
git-svn-id: http://core.svn.wordpress.org/trunk@44335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:54:49 +00:00
Gary Pendergast
68f2d8f0af
Docs: Correct the documentation for wp_list_authors()
.
...
The `exclude_admin` argument defaults to `true`, not `false`.
Props haruharuharuby.
Fixes #45120 .
Built from https://develop.svn.wordpress.org/trunk@44503
git-svn-id: http://core.svn.wordpress.org/trunk@44334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:52:50 +00:00
Gary Pendergast
21ff86cf43
Comments: Add new tests missed in [44499].
...
Props dshanske, birgire.
Fixes #44033 .
Built from https://develop.svn.wordpress.org/trunk@44502
git-svn-id: http://core.svn.wordpress.org/trunk@44333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:20:50 +00:00
Gary Pendergast
f9d879905d
Docs: Document the $page_hook
action.
...
Props johnbillion.
Fixes #43643 .
Built from https://develop.svn.wordpress.org/trunk@44501
git-svn-id: http://core.svn.wordpress.org/trunk@44332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:14:51 +00:00
Gary Pendergast
be127956e0
Bundled Themes: Run the pingback_url
through esc_url()
.
...
Twenties Ten through Seventeen have been updated to properly escape the pingback URL. Twenty Nineteen is already escaping the URL.
Props soulseekah, sharaz.
Fixes #43717 .
Built from https://develop.svn.wordpress.org/trunk@44500
git-svn-id: http://core.svn.wordpress.org/trunk@44331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:11:51 +00:00
Gary Pendergast
eeac928d3b
Comments: Add a new is_avatar_comment_type()
function.
...
This function splits the `get_avatar_comment_types` filter out of `get_avatar_data()`.
Props dshanske, birgire.
Fixes #44033 .
Built from https://develop.svn.wordpress.org/trunk@44499
git-svn-id: http://core.svn.wordpress.org/trunk@44330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:00:51 +00:00
Gary Pendergast
05c1030151
Docs: Add docblocks to the members of WP_Widget_Form_Customize_Control
.
...
Props subrataemfluence.
Fixes #44420 .
Built from https://develop.svn.wordpress.org/trunk@44498
git-svn-id: http://core.svn.wordpress.org/trunk@44329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:49:49 +00:00
Gary Pendergast
61dce1d422
Docs: Add docblocks for the PHPUnit factory objects.
...
Props andizer.
Fixes #44521 .
Built from https://develop.svn.wordpress.org/trunk@44497
git-svn-id: http://core.svn.wordpress.org/trunk@44328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:44:49 +00:00
Gary Pendergast
a583725622
Docs: Update Codex references to the Template_Hierarchy
page.
...
https://codex.wordpress.org/Template_Hierarchy redirects to https://developer.wordpress.org/themes/basics/template-hierarchy/ , so we should link to the correct page.
Props kmeze, pento.
Fixes #45222 .
Built from https://develop.svn.wordpress.org/trunk@44496
git-svn-id: http://core.svn.wordpress.org/trunk@44327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:09:51 +00:00
Gary Pendergast
e357f68667
Docs: Add @see WP_Session_Tokens
to the WP_User_Meta_Session_Tokens
docblock.
...
Props utsav72640.
Fixes #45499 .
Built from https://develop.svn.wordpress.org/trunk@44495
git-svn-id: http://core.svn.wordpress.org/trunk@44326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:04:50 +00:00
Gary Pendergast
0b44fae46b
Privacy: Fix a code formatting error introduced in [44491].
...
See #44908 .
Built from https://develop.svn.wordpress.org/trunk@44494
git-svn-id: http://core.svn.wordpress.org/trunk@44325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:33:50 +00:00
Gary Pendergast
47e29ccba9
Privacy: Tweak the wording of the success notice when updating the privacy policy page setting.
...
Props garrett-eclipse.
Fixes #44129 .
Built from https://develop.svn.wordpress.org/trunk@44493
git-svn-id: http://core.svn.wordpress.org/trunk@44324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:19:49 +00:00
Gary Pendergast
099238e3a3
Privacy: Always show the privacy policy guide.
...
Previously, the link to the privacy policy guide would only be displayed when a privacy policy page had been selected, but the guide is generally useful without that.
Props mukesh27, birgire.
Fixes #44871 .
Built from https://develop.svn.wordpress.org/trunk@44492
git-svn-id: http://core.svn.wordpress.org/trunk@44323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:01:50 +00:00
Gary Pendergast
53e40b7fda
Privacy: Remove some unnecessary parameters being passed to wp_update_post()
by wp_generate_user_request_key()
.
...
Props garrett-eclipse.
Fixes #44908 .
Built from https://develop.svn.wordpress.org/trunk@44491
git-svn-id: http://core.svn.wordpress.org/trunk@44322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 03:51:48 +00:00
Gary Pendergast
f7d21862e8
Help/About: Add a lang
attribute to the <html>
tag in readme.html
...
Props audrasjb.
Fixes #44955 .
Built from https://develop.svn.wordpress.org/trunk@44490
git-svn-id: http://core.svn.wordpress.org/trunk@44321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 02:56:51 +00:00
Gary Pendergast
19f9dd29e9
Login: Improve the error message when retrieving a lost password.
...
When an invalid username or email address is entered, the form now displays a better error message.
Props mrtortai, iamfriendly, TomHarrigan, afercia, pento.
Fixes #31788 .
Built from https://develop.svn.wordpress.org/trunk@44489
git-svn-id: http://core.svn.wordpress.org/trunk@44320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 02:06:50 +00:00
tellyworth
942f35446f
Cron API: Make wp-cron.php non-blocking where possible.
...
This should make cron spawning faster by ensuring requests to wp-cron.php return immediately regardless of transport method. It is enabled only on recent PHP versions with fastcgi, due to historical bugs and availability of `fastcgi_finish_request()`. This needs testing on a range of platforms, to help determine if it's safe to use in other contexts also.
Props vnsavage, johnbillion, jnylen0.
See #18738 , #41358
Built from https://develop.svn.wordpress.org/trunk@44488
git-svn-id: http://core.svn.wordpress.org/trunk@44319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 01:07:39 +00:00
Gary Pendergast
fd7086bcdc
Docs: Update the @since
tag for the comment_status_links
filter.
...
Fixes #42379 .
Built from https://develop.svn.wordpress.org/trunk@44487
git-svn-id: http://core.svn.wordpress.org/trunk@44318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 01:06:48 +00:00
Gary Pendergast
c6dea4c784
Embeds: Add Instagram TV support.
...
Props dannydehaan.
Fixes #44557 .
Built from https://develop.svn.wordpress.org/trunk@44486
git-svn-id: http://core.svn.wordpress.org/trunk@44317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 00:24:50 +00:00
Gary Pendergast
0888007275
Admin: Add a "Set up your homepage" link to the Welcome panel.
...
As many WordPress sites use a static homepage rather than a blog, this link gives a natural next step for new sites owners wanting to configure their site in this manner.
Props professor44, joyously, nielslange, mukesh27, melchoyce.
Fixes #45019 .
Built from https://develop.svn.wordpress.org/trunk@44485
git-svn-id: http://core.svn.wordpress.org/trunk@44316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 00:12:49 +00:00
Gary Pendergast
64d846c7c2
Embeds: Polldaddy is now called Crowdsignal.
...
Crowdsignal adds an additional embed URL, survey.fm.
Props donncha.
Fixes #45036 .
Built from https://develop.svn.wordpress.org/trunk@44484
git-svn-id: http://core.svn.wordpress.org/trunk@44315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 23:52:50 +00:00
Peter Wilson
bf3c97de77
Cron API: Add function and filter to return ready cron jobs.
...
Add the function `wp_get_ready_cron_jobs()` to return a modified version of the cron array limited to jobs ready to be run, ie with a timestamp of `time()` or earlier.
The new function includes the filter `pre_get_ready_cron_jobs` to allow for custom cron storage systems. This rounds out the functionality added in #32656 .
Props Pento for code review.
Fixes #45797 .
Built from https://develop.svn.wordpress.org/trunk@44483
git-svn-id: http://core.svn.wordpress.org/trunk@44314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 21:49:49 +00:00
desrosj
cd7b916d55
REST API: Introduce rest_post_search_query
filter.
...
This filter allows the query arguments to be manipulated for a post search query in the REST API.
Props Chouby, swissspidy.
Fixes #45454 .
Built from https://develop.svn.wordpress.org/trunk@44482
git-svn-id: http://core.svn.wordpress.org/trunk@44313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 21:45:48 +00:00
Adam Silverstein
f510ab9e94
Media: improve the human_readable_duration
function and tests.
...
Improve the `human_readable_duration` added in #39667 :
* Remove upper limit.
* More resilient handling: remove negative prefix, trim.
* Correct @since to 5.1.0.
* Adds more test cases and improve inline docs.
Props birgire.
Fixes #39667 .
Built from https://develop.svn.wordpress.org/trunk@44481
git-svn-id: http://core.svn.wordpress.org/trunk@44312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:56:48 +00:00
desrosj
bdaf864ec9
Docs: Improve accuracy of wp_list_sort()
’s $list
parameter description.
...
Props manikmist09.
Fixes #45766 .
Built from https://develop.svn.wordpress.org/trunk@44480
git-svn-id: http://core.svn.wordpress.org/trunk@44311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:54:50 +00:00
desrosj
58d5410ceb
Docs: Fix typos in Twenty Seventeen function descriptions.
...
Props faisal03, mukesh27.
Fixes #45466 .
Built from https://develop.svn.wordpress.org/trunk@44479
git-svn-id: http://core.svn.wordpress.org/trunk@44310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:22:49 +00:00
desrosj
619285c34c
Tests: Add missing test cases for is_serialized_string()
.
...
Also, reorganize these tests into their own class.
Props pbearne.
Fixes #42870 .
Built from https://develop.svn.wordpress.org/trunk@44478
git-svn-id: http://core.svn.wordpress.org/trunk@44309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:05:49 +00:00
desrosj
51155f3989
Docs: Specify missing global
variables used in wp_print_theme_file_tree()
.
...
The `$relative_file` and `$stylesheet` variables are used in the `wp_print_theme_file_tree()` function but were not noted within the inline documentation.
Props mukesh27, desrosj,
Fixes #43682 .
Built from https://develop.svn.wordpress.org/trunk@44477
git-svn-id: http://core.svn.wordpress.org/trunk@44308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 18:33:49 +00:00
Felix Arntz
e08a12d020
General: Make Update PHP notice link customizable.
...
After [42832], [42891] and [43006], this changeset refines the core notice informing about an outdated PHP version:
* The link to the Update PHP information page can now be adjusted using either a `WP_UPDATE_PHP_URL` environment variable, or a new `wp_update_php_url` filter.
* If that URL is different from the default one that points to https://wordpress.org/support/update-php/ or its localized equivalent, a note indicates that the linked resource has not been provided by WordPress itself, and the default URL is still linked to as an additional resource.
* The URL for the default information page has been updated to use the slug `update-php` instead of `upgrade-php`.
* `@since` annotations have been updated.
Going forward, admin areas that display information related to the PHP version should use the new function `wp_get_update_php_url()`.
Props afragen, fierevere, flixos90, markjaquith, miss_jwo, nerrad, pento, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #45686 . See #41191 .
Built from https://develop.svn.wordpress.org/trunk@44476
git-svn-id: http://core.svn.wordpress.org/trunk@44307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 17:27:50 +00:00
desrosj
1f6da37438
Docs: Fix order of parameter type and variable name.
...
The order of the type and variable name in the `param` tags for the `wp_get_default_privacy_policy_content` filter is incorrectly reversed. This moves the two into the correct order.
Props ishitaka, mukesh27.
Fixes #45416 .
Built from https://develop.svn.wordpress.org/trunk@44475
git-svn-id: http://core.svn.wordpress.org/trunk@44306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 17:03:48 +00:00
desrosj
f1ea8f222f
Widgets: Fix custom HTML widget editor content not updating after save.
...
An integer comparison is performed against `control.currentErrorAnnotations`, but `control.currentErrorAnnotations` is actually an array. This fixes that comparison so the content saves correctly.
Props barryceelen.
Fixes #43657 .
Built from https://develop.svn.wordpress.org/trunk@44474
git-svn-id: http://core.svn.wordpress.org/trunk@44305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 16:42:49 +00:00
Gary Pendergast
0f3835d394
Users: Add the pre_count_users
filter.
...
Props spacedmonkey.
Fixes #43693 .
Built from https://develop.svn.wordpress.org/trunk@44473
git-svn-id: http://core.svn.wordpress.org/trunk@44304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:49:50 +00:00
Felix Arntz
ea9286844f
Multisite: Introduce ms-site.php
and ms-network.php
files.
...
By providing distinct files for the site and network APIs, a better overview is provided. Prior to this change, the `ms-blogs.php` file had grown too big, mixing site APIs, network APIs and related legacy APIs that need to be maintained. Since multisite is often used in unexpected ways, backward-compatibility is ensured by including the two new files from `ms-blogs.php`, which previously contained all functions that have been moved to the new files.
This changeset does not contain any functional changes.
Fixes #40647 .
Built from https://develop.svn.wordpress.org/trunk@44472
git-svn-id: http://core.svn.wordpress.org/trunk@44303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:15:49 +00:00
Gary Pendergast
8947acbf9b
Media: Add $attr
to the wp_get_attachment_link
filter.
...
Props danielbachhuber.
Fixes #40155 .
Built from https://develop.svn.wordpress.org/trunk@44471
git-svn-id: http://core.svn.wordpress.org/trunk@44302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:09:49 +00:00
Gary Pendergast
e83f753246
Coding Standards: Fix an error introduced in [44465].
...
See #45748 .
Built from https://develop.svn.wordpress.org/trunk@44470
git-svn-id: http://core.svn.wordpress.org/trunk@44301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:03:50 +00:00
Felix Arntz
0b15142c0b
Multisite: Update @since
tags for site management APIs.
...
Fixes #40364 . Fixes #41333 .
Built from https://develop.svn.wordpress.org/trunk@44469
git-svn-id: http://core.svn.wordpress.org/trunk@44300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:58:49 +00:00
Felix Arntz
321bdfbacf
Multisite: Move site-specific metadata integrations from the wrapper functions to the low-level Meta API functions.
...
This complements the work in [43729] and prepares site metadata for future REST API support.
Props spacedmonkey.
Fixes #45091 . See #44467 .
Built from https://develop.svn.wordpress.org/trunk@44468
git-svn-id: http://core.svn.wordpress.org/trunk@44299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:48:48 +00:00
Felix Arntz
035877708d
Multisite: Update @since
tags for site meta introduction.
...
Fixes #37923 . Fixes #40229 .
Built from https://develop.svn.wordpress.org/trunk@44467
git-svn-id: http://core.svn.wordpress.org/trunk@44298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:18:50 +00:00
Gary Pendergast
952c7253d3
Comments: Improve the Author box in the Edit Comment screen.
...
- Add a border below the heading, to match meta boxes.
- Remove the colons from the input labels.
- Tweak the padding and margins.
Props birgire, abdullahramzan, rhetorical, BODA1982, pento.
Fixes #43586 .
Built from https://develop.svn.wordpress.org/trunk@44466
git-svn-id: http://core.svn.wordpress.org/trunk@44297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:19:50 +00:00
Gary Pendergast
8d2ee69f9d
Users: Use email_exists()
in send_confirmation_on_profile_email()
, instead of a manual query.
...
This gives us caching, and removes the use of the `$wpdb` global.
Props spacedmonkey, pento.
Fixes #45748 .
Built from https://develop.svn.wordpress.org/trunk@44465
git-svn-id: http://core.svn.wordpress.org/trunk@44296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:07:51 +00:00
Gary Pendergast
fe837d19a7
Docs: Fix the @param
type for wp_make_plugin_file_tree()
.
...
`$plugin_editable_files` is an `array`, not a `string`.
Props subrataemfluence.
Fixes #45593 .
Built from https://develop.svn.wordpress.org/trunk@44464
git-svn-id: http://core.svn.wordpress.org/trunk@44295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:02:51 +00:00
Gary Pendergast
5b3e08020b
Docs: Improve the @global
tags in wp-includes/option.php
.
...
Props upadalavipul.
Fixes #45581 .
Built from https://develop.svn.wordpress.org/trunk@44463
git-svn-id: http://core.svn.wordpress.org/trunk@44294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:00:50 +00:00
Gary Pendergast
7d77a6eb04
Docs: Correct the parameters passed to the twentyseventeen_custom_header_args
filter.
...
The documented `$default_text_color` parameter isn't passed, and the `$video` parameter is passed, but not documented.
Props mukesh27.
Fixes #44920 .
Built from https://develop.svn.wordpress.org/trunk@44462
git-svn-id: http://core.svn.wordpress.org/trunk@44293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:56:49 +00:00
Gary Pendergast
54617423e7
Coding Standards: Improve the readability of get_the_modified_author()
.
...
Props promz.
Fixes #44951 .
Built from https://develop.svn.wordpress.org/trunk@44461
git-svn-id: http://core.svn.wordpress.org/trunk@44292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:50:49 +00:00