Sergey Biryukov
9b56e3b7e4
External Libraries: After [37402], replace two more instances of split()
with explode()
in wp-includes/atomlib.php
.
...
Props josephscott.
Fixes #20673 .
Built from https://develop.svn.wordpress.org/trunk@37461
git-svn-id: http://core.svn.wordpress.org/trunk@37429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-19 00:06:28 +00:00
Drew Jaynes
0016e4bb12
Docs: Fix an incorrect Codex link in the file header for wp-includes/cache.php.
...
Introduced in [7990].
Props michaelbeil.
See #36880 .
Built from https://develop.svn.wordpress.org/trunk@37460
git-svn-id: http://core.svn.wordpress.org/trunk@37428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-18 22:07:28 +00:00
Aaron Jorbin
ced4ef2144
Correct usage of @Covers for Tests_Post_Types
...
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with ::. See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers
Introduced in [36768].
Fixes #36867 . See #35985
Built from https://develop.svn.wordpress.org/trunk@37459
git-svn-id: http://core.svn.wordpress.org/trunk@37427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-18 17:14:29 +00:00
Dominik Schilling
9f7856f103
Remove duplicate CSS selectors in forms.css
.
...
Props bassgang.
Fixes #36580 .
Built from https://develop.svn.wordpress.org/trunk@37458
git-svn-id: http://core.svn.wordpress.org/trunk@37426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-18 12:20:29 +00:00
Pascal Birchler
0afb5d0041
Customize: Change attachment condition in the site icon control to prevent errors.
...
Props neverything.
Fixes #36749 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37456
git-svn-id: http://core.svn.wordpress.org/trunk@37424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:39:30 +00:00
Pascal Birchler
d60b748652
Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
...
See #35237 .
Fixes #36838 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37452
git-svn-id: http://core.svn.wordpress.org/trunk@37420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:33:29 +00:00
Aaron Jorbin
6af8a5d48c
Set a whitelist for PHPUnit code coverage.
...
PHPUnit requires a whitelist as of version 5 in order to generate code coverage. See https://github.com/sebastianbergmann/phpunit-documentation/issues/335 .
Fixes #36867 .
Built from https://develop.svn.wordpress.org/trunk@37449
git-svn-id: http://core.svn.wordpress.org/trunk@37417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:23:28 +00:00
Pascal Birchler
eeadf35fa9
Bootstrap/Load: Silence ini_set()
in wp_debug_mode()
.
...
Props SergeyBiryukov.
Fixes #36708 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37448
git-svn-id: http://core.svn.wordpress.org/trunk@37416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:22:28 +00:00
Aaron Jorbin
c4752b1bf9
Correct usage of Covers for Tests_Update_Comment_Count_Now
...
When @covers is used with a plain alphanumeric string, PHPUnit assumes that it is covering a class. If there is no class, it fails and exits rather than continuing to generate coverage. To cover a global function, the name must start with ::. See https://phpunit.de/manual/5.3/en/appendixes.annotations.html#appendixes.annotations.covers
[37445] for trunk
See #35060 , #36867
Built from https://develop.svn.wordpress.org/trunk@37447
git-svn-id: http://core.svn.wordpress.org/trunk@37415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 20:20:27 +00:00
Ella Iseulde Van Dorpe
6e72bc4ec5
TinyMCE: use new non-editable implementation
...
Use TinyMCE's implementation of `contenteditable="false"` for views.
First pass.
See #36434 .
Built from https://develop.svn.wordpress.org/trunk@37446
git-svn-id: http://core.svn.wordpress.org/trunk@37414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 18:49:30 +00:00
Ryan McCue
691d445d68
REST API: Use prepared JSON data correctly.
...
This was modifying a variable that was never used. Oops.
Fixes #36358 .
Props jrf.
Built from https://develop.svn.wordpress.org/trunk@37444
git-svn-id: http://core.svn.wordpress.org/trunk@37412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 03:55:29 +00:00
Boone Gorges
1cfeaada73
Tests: Use factory method to generate fixtures for wp_unique_post_slug()
tests.
...
Props mintindeed.
See #20419 .
Built from https://develop.svn.wordpress.org/trunk@37443
git-svn-id: http://core.svn.wordpress.org/trunk@37411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 01:49:28 +00:00
Helen Hou-Sandí
848501711a
System font: The stack does not work with the font
shorthand property.
...
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37442
git-svn-id: http://core.svn.wordpress.org/trunk@37410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 01:45:27 +00:00
Dominik Schilling
693dfe3453
Editor: Merge two strings.
...
Props pavelevap.
See #27756 .
Built from https://develop.svn.wordpress.org/trunk@37441
git-svn-id: http://core.svn.wordpress.org/trunk@37407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 18:57:29 +00:00
Dominik Schilling
a673a71f94
I18N: In get_translations_for_domain()
check if the global $l10n
was set by _load_textdomain_just_in_time()
before accessing it.
...
Props danielhuesken.
Fixes #34114 .
Built from https://develop.svn.wordpress.org/trunk@37440
git-svn-id: http://core.svn.wordpress.org/trunk@37406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 15:10:29 +00:00
Andrea Fercia
1ae8891261
Accessibility: make the tab order match the visual order in the Edit terms screens.
...
Fixes #35664 .
Built from https://develop.svn.wordpress.org/trunk@37439
git-svn-id: http://core.svn.wordpress.org/trunk@37405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 13:02:29 +00:00
Dominik Schilling
8c0c57b9f9
Version bump.
...
Fixes #36845 .
Built from https://develop.svn.wordpress.org/trunk@37438
git-svn-id: http://core.svn.wordpress.org/trunk@37404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 10:24:30 +00:00
Weston Ruter
dcf6cf3615
Customize: Include shortcut button in Custom Menu widget to edit the selected menu in the Customizer.
...
Clicking on the Edit Menu button focuses on the corresponding nav menu section. Upon collapsing the nav menu section, the focus is returned to the Custom Menu widget instead of taking the user to the menus root panel. In this way, the back button behavior is modified once to serve as breadcrumb/history navigation. The Edit Menu button with the breadcrumb back button behavior greatly reduce the number of UI interactions needed to edit a menu referenced in a Custom Menu widget.
Props celloexpressions, westonruter.
Fixes #32683 .
Built from https://develop.svn.wordpress.org/trunk@37437
git-svn-id: http://core.svn.wordpress.org/trunk@37403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 07:22:30 +00:00
Ryan McCue
6da21bc4f4
HTTP API: Pass array-like object to http_api_debug.
...
This was mistakingly passing the Requests_Response object, which caused fatal errors with debugging tools.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37436
git-svn-id: http://core.svn.wordpress.org/trunk@37402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 06:12:29 +00:00
Joe McGill
bdfd58c8cf
Media: Remove medium_large size from $whitelist_options['media']
in options.php
.
...
The `medium_large_size_w` and `medium_large_size_h` options were added to the
$whitelist_options['media'] in options.php in [35479], which causes both options
to be set to `0` when the media settings are changed. When this occurs, the
medium_large image size will no longer be created when an image is uploaded.
Since these options aren't meant to be updated via the settings UI, they can be
safely removed from the whitelist.
Fixes #36531 .
Built from https://develop.svn.wordpress.org/trunk@37435
git-svn-id: http://core.svn.wordpress.org/trunk@37401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-15 22:38:29 +00:00
Dominik Schilling
944a69df87
Credits: Add a missing closing tag.
...
Props ramiy for initial patch.
Fixes #35911 .
Built from https://develop.svn.wordpress.org/trunk@37434
git-svn-id: http://core.svn.wordpress.org/trunk@37400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-14 18:58:31 +00:00
Dominik Schilling
52d30beb3c
External Libraries: Update jQuery to 1.12.4-pre.
...
This version includes a fix for the media library which didn't open under certain conditions. The issue was tracked upstream as "Specific table CSS style breaks `.is(':visible')`", see https://github.com/jquery/jquery/issues/3065 .
Also fixed: "Element which is not in page is still :visible in IE8", see https://github.com/jquery/jquery/issues/3043 .
Changelog: https://github.com/jquery/jquery/compare/1.12.3...376caf4d
See #36533 .
Built from https://develop.svn.wordpress.org/trunk@37433
git-svn-id: http://core.svn.wordpress.org/trunk@37399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 21:15:27 +00:00
Dominik Schilling
f81b65688a
Upgrader: Add changelog entries for when the classes were moved to its own file.
...
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37432
git-svn-id: http://core.svn.wordpress.org/trunk@37398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 20:59:27 +00:00
Drew Jaynes
b1804afeaf
Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
...
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.
Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.
Props ocean90.
Fixes #36835 .
Built from https://develop.svn.wordpress.org/trunk@37431
git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 18:41:31 +00:00
Ryan McCue
1e40ba291e
HTTP API: Fix compatibility with cURL <7.22
...
Ensure connections are closed after usage to fix an issue with WP.com URLs used in the tests.
Resynched from GitHub at 95518ce.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37430
git-svn-id: http://core.svn.wordpress.org/trunk@37396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 11:15:29 +00:00
Ryan McCue
dee1d583a7
HTTP API: Add browser compatibility hook for 3xx redirects.
...
WordPress erroneously follows browser-style behaviour with 3xx redirects, where a POST to 302 becomes a GET. Requests instead follows the specification and keeps the same method. Requests also exposes a hook to allow changing the behaviour.
[37428] used the wrong method of adding this hook, now corrected.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37429
git-svn-id: http://core.svn.wordpress.org/trunk@37395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 05:11:27 +00:00
Ryan McCue
37f6e6813a
HTTP API: Replace internals with Requests library.
...
Requests is a library very similar to WP_HTTP, with a high level of unit test coverage, and has a common lineage and development team. It also supports parallel requests.
See #33055 .
Built from https://develop.svn.wordpress.org/trunk@37428
git-svn-id: http://core.svn.wordpress.org/trunk@37394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 04:42:28 +00:00
Dominik Schilling
65f5fe6fb2
Widgets: Create WP_Widget_Mock
as a mock of WP_Widget
which can be used for widget tests.
...
You cannot instantiate an abstract class. Not even in WordPress world.
See #35981 .
Built from https://develop.svn.wordpress.org/trunk@37427
git-svn-id: http://core.svn.wordpress.org/trunk@37393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 21:25:27 +00:00
Weston Ruter
b036bf1012
Customize: Clean up media control CSS.
...
Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors.
Props celloexpressions.
Fixes #30618 .
Built from https://develop.svn.wordpress.org/trunk@37426
git-svn-id: http://core.svn.wordpress.org/trunk@37392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 20:23:54 +00:00
Dominik Schilling
97fc82a879
Widgets: Make WP_Widget
a real abstract class.
...
This removes the `die()` call from `WP_Widget::widget()` and converts it to an abstract method.
`WP_Widgets` (later renamed to `WP_Widget`) was introduced in [10764] where the minimum PHP requirement was 4.3, thus no `abstract` was available.
Props johnbillion.
Fixes #35981 .
Built from https://develop.svn.wordpress.org/trunk@37425
git-svn-id: http://core.svn.wordpress.org/trunk@37391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 20:23:28 +00:00
Dominik Schilling
7f1abd441f
Posts: Fire a post_action_{$action}
action for a custom post action request.
...
Props jfarthing84, Mte90, brianvan, sudar, DrewAPicture.
Fixes #27056 .
Built from https://develop.svn.wordpress.org/trunk@37424
git-svn-id: http://core.svn.wordpress.org/trunk@37390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 15:44:28 +00:00
Rachel Baker
00adb457d2
Comments: Add $data
parameter to include the comment data in the edit_comment
action.
...
Props dshanske.
Fixes #36427 .
Built from https://develop.svn.wordpress.org/trunk@37423
git-svn-id: http://core.svn.wordpress.org/trunk@37389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 15:37:27 +00:00
Dominik Schilling
251274abf6
List Tables: Pass the $which
parameter to restrict_manage_posts
and restrict_manage_users
.
...
`$which` contains the location of the extra table nav markup: 'top' or 'bottom'.
Props martin.krcho.
Fixes #35307 .
Built from https://develop.svn.wordpress.org/trunk@37422
git-svn-id: http://core.svn.wordpress.org/trunk@37388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 15:13:27 +00:00
Dominik Schilling
546b031453
Filesystem API: Don't add '.'
to the list of directories which need to be checked/created when extracting a file.
...
Prevents a PHP warning by `WP_Filesystem_Direct::mkdir()` when installing a language pack which doesn't have subdirectories.
Props tfrommen.
Fixes #36570 .
Built from https://develop.svn.wordpress.org/trunk@37421
git-svn-id: http://core.svn.wordpress.org/trunk@37387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 12:40:28 +00:00
Helen Hou-Sandí
a726a9f51f
Admin font: Remove a redundant sans-serif
declaration.
...
props samantha-miller.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37419
git-svn-id: http://core.svn.wordpress.org/trunk@37385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 02:14:28 +00:00
Jeremy Felt
283c367df7
Tests: Set public
to 1
in the default blog factory
...
When no `$meta` arguments are passed to `wpmu_create_blog()`, `public` is set to `0` in the database for new sites. This is fine, but also does not match the default implied when most sites are created via `site-new.php`.
The only current use of the `$meta` argument in the tests is to (re)mark `public` as `0`. All existing tests pass with this change. Tests for `WP_Site_Query` can now rely on better default expectations.
See #36566 .
Built from https://develop.svn.wordpress.org/trunk@37418
git-svn-id: http://core.svn.wordpress.org/trunk@37384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-11 19:22:27 +00:00
Weston Ruter
b074113016
Customize: Remove use of reserved word default
in Underscore template which breaks IE8.
...
Fixes regression introduced in r30712.
Props adamsilverstein.
Fixes #36793 .
Built from https://develop.svn.wordpress.org/trunk@37417
git-svn-id: http://core.svn.wordpress.org/trunk@37383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-11 19:07:30 +00:00
Pascal Birchler
64fb1a9e90
I18N: Add changes missed in [37415].
...
See #34114 .
Built from https://develop.svn.wordpress.org/trunk@37416
git-svn-id: http://core.svn.wordpress.org/trunk@37382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 20:31:27 +00:00
Pascal Birchler
751234a580
I18N: Remove the requirement to call load_plugin_textdomain()
/ load_theme_textdomain()
.
...
By initially scanning the `wp-content/languages` directory and loading available MO files just-in-time, plugins and themes do not need to manually load text domains anymore.
Props swissspidy, ocean90.
Fixes #34114
Built from https://develop.svn.wordpress.org/trunk@37415
git-svn-id: http://core.svn.wordpress.org/trunk@37381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 20:05:29 +00:00
Pascal Birchler
3f6966907b
I18N: Reverse the order of loading plugin and theme translations.
...
`load_theme_textdomain()`, `load_plugin_textdomain()` and `load_muplugin_textdomain()` now try to load the .mo file from the `wp-content/languages` directory first. After the introduction of language packs, translation files are more likely to be located there.
Props swissspidy, sebastian.pisula.
Fixes #34213 .
Built from https://develop.svn.wordpress.org/trunk@37414
git-svn-id: http://core.svn.wordpress.org/trunk@37380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 18:50:27 +00:00
Dominik Schilling
1564bd2c1f
Upgrader: Remove debug cruft.
...
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37413
git-svn-id: http://core.svn.wordpress.org/trunk@37379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 18:32:28 +00:00
Dominik Schilling
a8525b1109
Upgrader: After [37409] move the hook docs for upgrader_process_complete
to WP_Upgrader::run()
.
...
Add changelog entry for [23912].
Part 7/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37412
git-svn-id: http://core.svn.wordpress.org/trunk@37378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 12:20:27 +00:00
Dominik Schilling
5844c585f6
Upgrader: Update wp-admin/includes/class-wp-upgrader.php
to require_once
the new files added in [37406] and [37409].
...
Part 6/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37411
git-svn-id: http://core.svn.wordpress.org/trunk@37377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:59:27 +00:00
Dominik Schilling
23e2a486ae
Upgrader: Update file headers for new files added in [37409].
...
Part 5/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37410
git-svn-id: http://core.svn.wordpress.org/trunk@37376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:52:28 +00:00
Dominik Schilling
14e5d77132
Upgrader: Copy WP_Upgrader
subclasses into one file per class.
...
Part 4/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37409
git-svn-id: http://core.svn.wordpress.org/trunk@37375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:45:42 +00:00
Dominik Schilling
5f1ac9c96d
Upgrader: Update wp-admin/includes/class-wp-upgrader-skins.php
to require_once
the new files added in [37406].
...
Part 3/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37408
git-svn-id: http://core.svn.wordpress.org/trunk@37374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:42:26 +00:00
Dominik Schilling
4b846677ba
Upgrader: Update file headers and class DocBlocks for new files added in [37406].
...
Part 2/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37407
git-svn-id: http://core.svn.wordpress.org/trunk@37373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:31:28 +00:00
Dominik Schilling
bbecb1a485
Upgrader: Copy WP_Upgrader_Skin
and its subclasses into one file per class.
...
Part 1/8.
See #36618 .
Built from https://develop.svn.wordpress.org/trunk@37406
git-svn-id: http://core.svn.wordpress.org/trunk@37372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 11:11:30 +00:00
Weston Ruter
574be8f2a8
Customize: Ensure that wp_setup_nav_menu_item
filter applies consistently on nav_menu_item
setting values.
...
The filter was being applied in `WP_Customize_Nav_Menu_Item_Setting::value()` but not in `WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()`.
Props celloexpressions, westonruter.
Fixes #35203 .
Built from https://develop.svn.wordpress.org/trunk@37405
git-svn-id: http://core.svn.wordpress.org/trunk@37371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-10 06:41:29 +00:00
Dominik Schilling
096d0ccd63
Tests: Don't create unused users in Tests_Ajax_DeleteComment
.
...
Fixes #36616 .
Built from https://develop.svn.wordpress.org/trunk@37404
git-svn-id: http://core.svn.wordpress.org/trunk@37370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-09 19:17:29 +00:00
Sergey Biryukov
ff37a3b730
Docs: Fix typo in a comment in check_and_publish_future_post()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37403
git-svn-id: http://core.svn.wordpress.org/trunk@37369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-08 12:46:29 +00:00
Dominik Schilling
b5718124c3
External Libraries: Replace split()
with explode()
in the deprecated Atom and MagpieRSS files.
...
Before PHP7 `split()` was throwing a deprecated notice, in PHP7 the function is completely removed and throws a fatal error.
Props achbed.
Fixes #20673 .
Built from https://develop.svn.wordpress.org/trunk@37402
git-svn-id: http://core.svn.wordpress.org/trunk@37368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-07 15:59:29 +00:00
Nikolay Bachiyski
c33e975f46
External Libraries: Update plupload from upstream
...
Built from https://develop.svn.wordpress.org/trunk@37383
git-svn-id: http://core.svn.wordpress.org/trunk@37349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 18:02:26 +00:00
Dominik Schilling
a493dc0ab5
External Libraries: Update MediaElement.js from upstream.
...
Built from https://develop.svn.wordpress.org/trunk@37370
git-svn-id: http://core.svn.wordpress.org/trunk@37336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-06 17:51:36 +00:00
Sergey Biryukov
b65cbd6003
Options: After [33738], consistently pass option name as the second parameter to the 'default_option_' . $option
filter in add_option()
and update_option()
.
...
Props dlh.
Fixes #36761 .
Built from https://develop.svn.wordpress.org/trunk@37367
git-svn-id: http://core.svn.wordpress.org/trunk@37333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 20:24:29 +00:00
Drew Jaynes
2459e4e880
Docs: Remove backticks from the DocBlock summary for WP::$request
, added in [37356].
...
Markdown formatting is not supported in DocBlock summaries, per the inline documentation standards for PHP :-)
See #32246 . See #36674 .
Built from https://develop.svn.wordpress.org/trunk@37366
git-svn-id: http://core.svn.wordpress.org/trunk@37332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 20:03:27 +00:00
Jeremy Felt
ced66ed4e7
Multisite: Use the admin-multisite Dashicon for sites
...
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.
Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.
Props Ipstenu, ocean90.
Fixes #36754 .
Built from https://develop.svn.wordpress.org/trunk@37365
git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 17:13:26 +00:00
Jeremy Felt
db3d5a6bea
Revert [37362], which incorrectly changed Dashicons CSS
...
`dashicons.css` is an external-ish library and the change there is incorrect.
See #36754 .
Built from https://develop.svn.wordpress.org/trunk@37364
git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:29:27 +00:00
Helen Hou-Sandí
610215ceb1
Revive grunt-rtlcss
, which does not appear to enjoy syntax errors.
...
props netweb.
see #36753 , #29792 .
Built from https://develop.svn.wordpress.org/trunk@37363
git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:22:27 +00:00
Jeremy Felt
172af4e0ce
Multisite: Use the admin-multisite Dashicon in the admin menu and bar
...
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.
Props Ipstenu.
Fixes #36754 .
Built from https://develop.svn.wordpress.org/trunk@37362
git-svn-id: http://core.svn.wordpress.org/trunk@37328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 04:29:26 +00:00
Helen Hou-Sandí
a800cf654b
Drop Open Sans in the admin in favor of system fonts.
...
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.
At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.
There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.
The style remains registered, as it is almost certainly in use by themes and plugins.
props mattmiklic.
see #36753 .
Built from https://develop.svn.wordpress.org/trunk@37361
git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 22:07:37 +00:00
Boone Gorges
2d37a0ee17
Users: The 'who' parameter should not interfere with 'meta_key' + 'meta_value' in WP_User_Query
.
...
Props adrianosilvaferreira.
Fixes #36724 .
Built from https://develop.svn.wordpress.org/trunk@37360
git-svn-id: http://core.svn.wordpress.org/trunk@37326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 18:57:28 +00:00
Boone Gorges
3c70037d46
Tests: Correct 'meta_query' syntax in test related to WP_User_Query
'who' param.
...
The test, introduced in [32207], used the incorrect syntax for 'meta_query' -
one fewer level of array-nesting than what `WP_Meta_Query` requires. This
slip uncovered a bug introduced into `WP_User_Query` in [30094], whereby
an incorrectly formatted 'meta_query' parameter would be properly parsed by
`WP_User_Query` when passed alongside `who=authors`.
We need to fix the inconsistent syntax in order to resolve #36724 .
See #36724 , #32019 , #23849 , #27026 .
Built from https://develop.svn.wordpress.org/trunk@37359
git-svn-id: http://core.svn.wordpress.org/trunk@37325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 18:49:29 +00:00
Boone Gorges
4f4a45ca1c
Tests: Introduce reset_phpmailer_instance()
function.
...
This function provides a more convenient method for resetting the
PHPMailer instance than the previous technique of reaching into the global.
Props welcher.
Fixes #36658 .
Built from https://develop.svn.wordpress.org/trunk@37358
git-svn-id: http://core.svn.wordpress.org/trunk@37324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 03:49:26 +00:00
Boone Gorges
0469f12d7b
Add tests for is_serialized_string()
.
...
Props borgesbruno.
Fixes #35952 .
Built from https://develop.svn.wordpress.org/trunk@37357
git-svn-id: http://core.svn.wordpress.org/trunk@37323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 03:30:27 +00:00
Eric Lewis
98d5d4919c
Rewrite Rules: Add self-describing variables to rewrite matcher.
...
The rewrite rule matching code in WP::parse_request() used an unclear variable `$request` to represent the requested path (e.g. "2016/05/03") as well as a deceptively named variable `$request_uri`, which actually represents the requested file when an install used PATHINFO links.
Those variables are replaced with `$requested_path` and `$requested_file` respectively for clarity.
Fixes #36674 .
Built from https://develop.svn.wordpress.org/trunk@37356
git-svn-id: http://core.svn.wordpress.org/trunk@37322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-03 19:36:28 +00:00
Drew Jaynes
c7a2b7683b
Docs: Add a missing hook doc for the parse_comment_query
hook, added in [31793].
...
Props flixos90.
See #24826 . Fixes #36740 .
Built from https://develop.svn.wordpress.org/trunk@37355
git-svn-id: http://core.svn.wordpress.org/trunk@37321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-03 16:22:27 +00:00
Boone Gorges
2f66998e3f
date_query
should be a property on WP_Comment_Query
objects.
...
Instead of a local variable.
Props flixos90.
Fixes #36741 .
Built from https://develop.svn.wordpress.org/trunk@37354
git-svn-id: http://core.svn.wordpress.org/trunk@37320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-03 16:15:29 +00:00
Drew Jaynes
ebfc1467bb
Links: Rename the $link_id
parameter in get_link_to_edit()
to $link
to better reflect that it can accept a link ID or object.
...
Props tloureiro for the initial patch.
Fixes #36736 .
Built from https://develop.svn.wordpress.org/trunk@37353
git-svn-id: http://core.svn.wordpress.org/trunk@37319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:43:27 +00:00
Weston Ruter
4113ccfc47
Customize: Handle filtering sidebars_widgets
when the underlying option is non-existent.
...
Fixes warning related to a non-array argument for `array_merge()` in `WP_Customize_Widgets::customize_register()`.
See [37166].
See #36389 .
Fixes #36660 .
Built from https://develop.svn.wordpress.org/trunk@37352
git-svn-id: http://core.svn.wordpress.org/trunk@37318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:42:28 +00:00
Drew Jaynes
3470faa683
Links: Clarify documentation for the $link_id
parameter to mention that it accepts either an integer or object.
...
Props tloureiro.
See #36736 .
Built from https://develop.svn.wordpress.org/trunk@37351
git-svn-id: http://core.svn.wordpress.org/trunk@37317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 23:40:27 +00:00
Weston Ruter
f98a2ed41d
Customize: Pass WP_Customize_Setting
instance as second argument to customize_value_{$id_base}
filter.
...
Adds parity with setting instance being passed as second argument to `customize_sanitize_{$id}` and `customize_sanitize_js_{$id}`. Allows the actual ID of the (multidimensional) setting value being filtered to be inspected.
Props celloexpressions, westonruter.
Fixes #36452 .
Built from https://develop.svn.wordpress.org/trunk@37350
git-svn-id: http://core.svn.wordpress.org/trunk@37316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 22:42:26 +00:00
Drew Jaynes
5f62db2f21
Comments: Realign parameter documentation in the DocBlocks for comment_author_email_link()
and get_comment_author_email_link()
following [37348].
...
Also adds a missing return description for `get_comment_author_email_link()`.
Props flixos90 for the initial patch.
Fixes #36571 .
Built from https://develop.svn.wordpress.org/trunk@37349
git-svn-id: http://core.svn.wordpress.org/trunk@37315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 20:04:28 +00:00
Drew Jaynes
a6c393828d
Comments: Adjust comment_author_email_link()
and get_comment_author_email_link()
to each accept a new optional fourth parameter, $comment
, which enables overriding the $comment
global.
...
Adds tests.
Props flixos90, boonebgorges, DrewAPicture.
See #36571 .
Built from https://develop.svn.wordpress.org/trunk@37348
git-svn-id: http://core.svn.wordpress.org/trunk@37314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:59:27 +00:00
Weston Ruter
3a37220f2a
Customize: Allow Esc key to collapse the currently-expanded panel, section (or control).
...
Pressing Esc collapses any expanded widget or nav menu item controls, or any control that implements the expanding interface. Also improves alignment between `WidgetControl` and `MenuItemControl`, adding the `expanded` state and associated `expand`/`collapse` methods to nav menu items.
Props purcebr, celloexpressions, westonruter.
Fixes #22237 .
Built from https://develop.svn.wordpress.org/trunk@37347
git-svn-id: http://core.svn.wordpress.org/trunk@37313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:52:28 +00:00
Weston Ruter
a0d7e83beb
Customize: Ensure settings modified during an open save request remain dirty when save request completes.
...
Also disables Save & Publish button while save request is open. After the save request completes, any settings changed during the request can then be saved via an additional click to the button.
Props chandrapatel, westonruter.
Fixes #32941 .
Built from https://develop.svn.wordpress.org/trunk@37346
git-svn-id: http://core.svn.wordpress.org/trunk@37312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 19:13:26 +00:00
Eric Lewis
aba14233d9
Posts: Allow get_page_uri()
to be called without a $page argument.
...
`get_page_uri()` can now be called without an argument, which will return the page URI for the current post in the loop.
Props pollett.
Fixes #26284 .
Built from https://develop.svn.wordpress.org/trunk@37345
git-svn-id: http://core.svn.wordpress.org/trunk@37311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 18:29:29 +00:00
Drew Jaynes
f3a90cd1a6
Tests: Remove debug cruft left over from [34816].
...
See #17078 .
Built from https://develop.svn.wordpress.org/trunk@37344
git-svn-id: http://core.svn.wordpress.org/trunk@37310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 16:24:29 +00:00
Drew Jaynes
6683100d2c
Docs: Improve the class DocBlock for WP_Widget
to clarify which methods "should" vs "must" be overridden by extending sub-classes.
...
Props Frank-Klein.
Fixes #36703 .
Built from https://develop.svn.wordpress.org/trunk@37343
git-svn-id: http://core.svn.wordpress.org/trunk@37309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 04:53:27 +00:00
Drew Jaynes
fe3b007fdd
Docs: Remove inline @see
tags from function, class, and method references in inline docs.
...
Known functions, classes, and methods are now auto-linked in Code Reference pages following #meta1483.
Note: Hook references are still linked via inline `@see` tags due to the unlikelihood of reliably matching for known hooks based on a RegEx pattern.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37342
git-svn-id: http://core.svn.wordpress.org/trunk@37308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-02 04:00:28 +00:00
Dominik Schilling
9354965638
Customize: Increase the target size of the expand/collapse button in the customizer.
...
To improve accessibility on touch devices increase the size of the button in the collapsed view from 24×28 to 44×45 pixel.
Props celloexpressions.
Fixes #36093 .
Built from https://develop.svn.wordpress.org/trunk@37341
git-svn-id: http://core.svn.wordpress.org/trunk@37307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 20:29:27 +00:00
Dominik Schilling
f0962c42ab
Travis CI: Include npm prune
in the before_script
command.
...
Caching of node modules was added in [37058]. `npm prune` removes extraneous packages so the cache contains only current modules.
Props netweb.
Fixes #36490 .
Built from https://develop.svn.wordpress.org/trunk@37340
git-svn-id: http://core.svn.wordpress.org/trunk@37306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 20:04:27 +00:00
Dominik Schilling
823ec71cd6
Customize: Don't auto-close the customizer when a new theme is activated.
...
Props celloexpressions.
Fixes #35320 .
Built from https://develop.svn.wordpress.org/trunk@37339
git-svn-id: http://core.svn.wordpress.org/trunk@37305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 19:54:27 +00:00
Drew Jaynes
664bb85f1b
Docs: Add backtick escaping for two inline code samples in docs.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@37338
git-svn-id: http://core.svn.wordpress.org/trunk@37304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 17:32:26 +00:00
Drew Jaynes
0055c9746c
Docs: Standardize on using ::
for Class::method()
references in WP_Customize_Control` inline docs.
...
See #32246 . See #meta1483.
Built from https://develop.svn.wordpress.org/trunk@37337
git-svn-id: http://core.svn.wordpress.org/trunk@37303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 17:28:27 +00:00
Andrea Fercia
22bae92301
Themes: restore Theme Installer missing spinner.
...
Fixes #36730 .
Built from https://develop.svn.wordpress.org/trunk@37336
git-svn-id: http://core.svn.wordpress.org/trunk@37302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 15:43:27 +00:00
Sergey Biryukov
dc5815146e
Dashboard: Display the comment counts in wp_dashboard_right_now()
in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work.
...
Props afercia.
Fixes #35519 .
Built from https://develop.svn.wordpress.org/trunk@37335
git-svn-id: http://core.svn.wordpress.org/trunk@37301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 11:06:28 +00:00
Sergey Biryukov
49a47bb255
Docs: Document the @return
value of wp_add_trashed_suffix_to_post_name_for_post()
.
...
Props Shelob9.
Fixes #36728 .
Built from https://develop.svn.wordpress.org/trunk@37334
git-svn-id: http://core.svn.wordpress.org/trunk@37300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 10:16:29 +00:00
Weston Ruter
6693acdb24
Widgets: Provide PHP 5.2 fallback for spl_object_hash()
if disabled in logic for registering and unregistering pre-instantiated widgets.
...
Fixes #28216 .
Built from https://develop.svn.wordpress.org/trunk@37333
git-svn-id: http://core.svn.wordpress.org/trunk@37299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 22:36:28 +00:00
Dominik Schilling
4b51bc18cc
Plugins: In plugin_basename()
normalize the file path before unresolving symlinks.
...
`$wp_plugin_paths` contains normalized paths, see `wp_register_plugin_realpath()`.
Props jdgrimes, voldemortensen, flyingdr, ocean90.
Fixes #29154 .
Built from https://develop.svn.wordpress.org/trunk@37332
git-svn-id: http://core.svn.wordpress.org/trunk@37298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 15:09:27 +00:00
Dominik Schilling
697a6d5560
Plugins: In uninstall_plugin()
pass the plugin file to wp_register_plugin_realpath()
.
...
`wp_register_plugin_realpath()` calls `dirname( $file );` to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.
Props andy.
Fixes #36709 .
Built from https://develop.svn.wordpress.org/trunk@37331
git-svn-id: http://core.svn.wordpress.org/trunk@37297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 15:04:27 +00:00
Andrea Fercia
93c8cdbaed
Accessibility: improve the Star Ratings hiding empty elements for assistive technologies.
...
Fixes #36725 .
Built from https://develop.svn.wordpress.org/trunk@37330
git-svn-id: http://core.svn.wordpress.org/trunk@37296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-30 14:33:29 +00:00
Weston Ruter
96104fdd30
Widgets: Allow WP_Widget
subclass instances (objects) to be registered/unregistered in addition to WP_Widget
subclass names (strings).
...
Allows widgets to be registered which rely on dependency injection. Also will allow for new widget types to be created dynamically (e.g. a Recent Posts widget for each registered post type).
See #35990 .
Props mdwheele, PeterRKnight, westonruter.
Fixes #28216 .
Built from https://develop.svn.wordpress.org/trunk@37329
git-svn-id: http://core.svn.wordpress.org/trunk@37295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 18:49:26 +00:00
Scott Taylor
fb82d557cd
Media/Unit Tests: ensure that image sizes are indeed removed when errors are raised before assertions in Tests_Media
.
...
See #36588 .
Built from https://develop.svn.wordpress.org/trunk@37328
git-svn-id: http://core.svn.wordpress.org/trunk@37294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 17:52:29 +00:00
Scott Taylor
188bea204b
Media/Unit Tests: ensure that the GD absrtraction is used for GD unit tests for Images. Some of the procedural GD API functions can still throw ImagickException
, which is fun.
...
See #36588 .
Built from https://develop.svn.wordpress.org/trunk@37327
git-svn-id: http://core.svn.wordpress.org/trunk@37293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 16:16:27 +00:00
Jeremy Felt
2e94a24e25
Multisite: Add the pre_get_blogs_of_user
filter
...
This allows a plugin to short circuit `get_blogs_of_user()` in cases where the default behavior of the function is unnecessary or slow. (e.g. A user is a member of thousands of sites.)
Props jsternberg.
See #31746 , Fixes #36707 .
Built from https://develop.svn.wordpress.org/trunk@37326
git-svn-id: http://core.svn.wordpress.org/trunk@37292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 15:53:28 +00:00
Scott Taylor
5efc557eb8
Comments: pass $comment
to comment_text()
in Walker_Comment::comment()
instead of using a function which can skip the cache.
...
Props rachelbaker.
Fixes #35433 .
Built from https://develop.svn.wordpress.org/trunk@37325
git-svn-id: http://core.svn.wordpress.org/trunk@37291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 15:47:27 +00:00
Boone Gorges
9bf510260f
Query: Discard non-scalar 'm' instead of attempting to sanitize.
...
`WP_Query` discards most non-array date values ('year', 'monthnum', etc) by
casting to integer. Since [25138], the 'm' parameter has been handled
as a string; see #24884 . However, the string-handling introduced in [25138]
blindly attempted to handle arrays and other non-scalar types as strings,
resulting in PHP notices and invalid MySQL syntax.
Props vortfu.
Fixes #36718 .
Built from https://develop.svn.wordpress.org/trunk@37324
git-svn-id: http://core.svn.wordpress.org/trunk@37290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-29 13:15:30 +00:00
Rachel Baker
15eaa665c1
Widgets: When the Inactive Widgets section is hidden also hide the “Clear Inactive Widgets” button description text.
...
Props welcher.
Fixes #35592 .
Built from https://develop.svn.wordpress.org/trunk@37323
git-svn-id: http://core.svn.wordpress.org/trunk@37289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-28 20:40:28 +00:00
Weston Ruter
09860ae46c
Customize: Remove format placeholders from widget templates and selectors, fixing a jQuery selector syntax error and the broken highlight/shift-click behaviors.
...
The issues occur in themes that register sidebars that reference a single format placeholder (`%1$s` and `%2$s`) multiple times, such as in the `id` and `class` attributes for `$before_widget`.
Props martin.krcho, westonruter.
Fixes #36473 .
Built from https://develop.svn.wordpress.org/trunk@37322
git-svn-id: http://core.svn.wordpress.org/trunk@37288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-28 18:20:29 +00:00