Commit Graph

23 Commits

Author SHA1 Message Date
Sergey Biryukov
803426a023 Coding Standards: Use strict comparison in bundled themes' PHP files.
This addresses all the remaining WPCS warnings in bundled themes.

Includes using the correct type when checking the number of comments, as `get_comments_number()` returns a numeric string, not an integer.

Follow-up to [41285], [44562], [47941].

Props aristath, poena, afercia, SergeyBiryukov.
See #56791.
Built from https://develop.svn.wordpress.org/trunk@55420


git-svn-id: http://core.svn.wordpress.org/trunk@54953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-24 06:23:23 +00:00
Sergey Biryukov
0be77d4ebf Bundled Themes: Add / character to <img> tags.
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51473].

Props shital-patel, akabarikalpesh.
See #53870.
Built from https://develop.svn.wordpress.org/trunk@51541


git-svn-id: http://core.svn.wordpress.org/trunk@51152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-04 14:24:02 +00:00
Sergey Biryukov
1f85e7484f Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
See #50768.
Built from https://develop.svn.wordpress.org/trunk@48782


git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 00:34:08 +00:00
Sergey Biryukov
30e0cf9fcd Docs: Bundled Themes: Correct DocBlock placement for custom header and background argument filters.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48264


git-svn-id: http://core.svn.wordpress.org/trunk@48033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 13:52:01 +00:00
Sergey Biryukov
641c632b0c Coding Standards: Use Yoda conditions where appropriate.
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47219


git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:55:09 +00:00
Sergey Biryukov
001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Tammie Lister
9ef40ced2f Twenty Fourteen: Removes video header support
Support was added to test implementation but never completed. This removes the test implementation.

Props davidakennedy
Fixes #38783

Built from https://develop.svn.wordpress.org/trunk@39226


git-svn-id: http://core.svn.wordpress.org/trunk@39166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-14 17:17:31 +00:00
Joe McGill
030bc377dd Themes: Enable video in custom headers.
This adds the ability for themes to add support for videos in custom headers
by passing `'video' => true` as an argument when adding theme support for
custom headers.

Custom video headers are managed through the “Header Visuals” (i.e. “Header Image”)
panel in the Customizer where you can select a video from the media library or set a
URL to an external video (YouTube for now) for use in custom headers.

This introduces several new functions:

`has_header_video()` – Check whether a header video is set or not.
`get_header_video_url()` – Retrieve header video URL for custom header.
`the_header_video_url()` – Display header video URL.
`get_header_video_settings()` – Retrieve header video settings.
`has_custom_header()` – Check whether a custom header is set or not.
`get_custom_header_markup()` – Retrieve the markup for a custom header.
`the_custom_header_markup()` – Print the markup for a custom header.

And a new file, `wp-includes/js/wp-custom-header.js` that handles loading videos
in custom headers.

This also enables video headers in the Twenty Seventeen and Twenty Fourteen themes.

Props davidakennedy, celloexpressions, bradyvercher, laurelfulford, joemcgill.
Fixes #38172.
Built from https://develop.svn.wordpress.org/trunk@38985


git-svn-id: http://core.svn.wordpress.org/trunk@38928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-27 21:51:31 +00:00
Lance Willett
17f69a89d4 Twenty Fourteen: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31250


git-svn-id: http://core.svn.wordpress.org/trunk@31231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 19:03:23 +00:00
Lance Willett
c604fd15b0 Twenty Fourteen: fix keyboard focus on Appearance > Header view.
Props florianziegler, fixes #29787.

Built from https://develop.svn.wordpress.org/trunk@30146


git-svn-id: http://core.svn.wordpress.org/trunk@30146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:44:23 +00:00
Lance Willett
65c6477bc3 Twenty Fourteen: RTL display adjustment for Custom Header, props yoavf. Fixes #28670.
Built from https://develop.svn.wordpress.org/trunk@29167


git-svn-id: http://core.svn.wordpress.org/trunk@28951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 17:41:15 +00:00
Lance Willett
8e352c8187 Twenty Fourteen: remove unneeded !important declarations, and comment the ones we absolutely need to keep around. Fixes #26444.
Built from https://develop.svn.wordpress.org/trunk@26689


git-svn-id: http://core.svn.wordpress.org/trunk@26579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 21:03:11 +00:00
Lance Willett
25ee6100bd Twenty Fourteen: better logic for hide/show title and description, and Customizer handling of the same. Add ID attributes to style blocks. Fixes #26338.
Built from https://develop.svn.wordpress.org/trunk@26668


git-svn-id: http://core.svn.wordpress.org/trunk@26558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 17:30:11 +00:00
Lance Willett
0f3b7b7978 Twenty Fourteen: fix site title color preview in Customizer, props kwight. Closes #26404.
Built from https://develop.svn.wordpress.org/trunk@26619


git-svn-id: http://core.svn.wordpress.org/trunk@26509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 18:42:09 +00:00
Lance Willett
4d6ec7fa96 Twenty Fourteen: re-add the Header Text Customization Option. Props iamtakashi, fixes #26338; see #25540.
Built from https://develop.svn.wordpress.org/trunk@26573


git-svn-id: http://core.svn.wordpress.org/trunk@26464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 18:27:10 +00:00
Lance Willett
e46662b6ae Twenty Fourteen: update comment blocks to match inline docs standards. Props DrewAPicture, see #25837.
Built from https://develop.svn.wordpress.org/trunk@26556


git-svn-id: http://core.svn.wordpress.org/trunk@26447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:06:11 +00:00
Lance Willett
eaf78d3f7c Twenty Fourteen: first pass for updating code comments to reflect WP inline docs standards, see #25257.
Built from https://develop.svn.wordpress.org/trunk@25769


git-svn-id: http://core.svn.wordpress.org/trunk@25682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 22:02:11 +00:00
Lance Willett
5024874876 Twenty Fourteen: remove header text customization options, fixes #25540. Props celloexpressions, obenland.
Built from https://develop.svn.wordpress.org/trunk@25765


git-svn-id: http://core.svn.wordpress.org/trunk@25678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 17:14:09 +00:00
Lance Willett
79bd971194 Twenty Fourteen: merge recent stylesheet changes to RTL, and file miscellaneous CSS cleanup.
RTL still needs more responsive fixes, see #25332 -- and a11y menu fixes, see #25054. 
Built from https://develop.svn.wordpress.org/trunk@25749


git-svn-id: http://core.svn.wordpress.org/trunk@25662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 21:42:09 +00:00
Lance Willett
e5c55b09e9 Twenty Fourteen: first pass at matching code standards achieved with Twenty Thirteen development. See #24858, props obenland.
Built from https://develop.svn.wordpress.org/trunk@25021


git-svn-id: http://core.svn.wordpress.org/trunk@25012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:29 +00:00
Lance Willett
7d35419e62 Importing the Further theme, first pass at the new default theme for 2014.
A magazine theme with clean, responsive design focused on highlighting featured content prominently on home page.

This is slated for 3.8. Development will occur in trunk for the theme, and in plugins for the nice-to-have features.

Nice-to-have improvements include:

- Add a Contributors page template to highlight authors.
- Easy-to-manage featured content.
- Add support for an Authors widget to highlight authors.

Welcome, Twenty Fourteen né Further. Props iamtakashi, see #24858.


git-svn-id: http://core.svn.wordpress.org/trunk@24832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 22:55:10 +00:00