Commit Graph

9 Commits

Author SHA1 Message Date
Sergey Biryukov
6787d4d602 Twenty Nineteen: Improve menu semantics and keyboard navigation.
The menu's original markup included some non-semantic tags and an unnecessary tabindex attribute that made it difficult to navigate via keyboard. 

Props allancole, anevins, kjellr.
Merges [44376] to the 5.0 branch.
Fixes #45713.
Built from https://develop.svn.wordpress.org/branches/5.0@44426


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 16:00:46 +00:00
laurelfulford
b828ba64bb Twenty Nineteen: Make sure links are followed on touchend, not touchstart.
The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.

Props anevins, panchen, kjellr.
Fixes #45510.


Built from https://develop.svn.wordpress.org/branches/5.0@44357


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-21 21:09:47 +00:00
desrosj
08befd9763 Twenty Nineteen: Fixes and improvements.
This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

- Fix the gallery caption link color. https://github.com/WordPress/twentynineteen/pull/687
- Remove left padding from pullquote blocks. https://github.com/WordPress/twentynineteen/pull/690
- Print `skip-link-focus-fix` inline instead of enqueueing as blocking script. https://github.com/WordPress/twentynineteen/pull/47
- Fix and improve some strings with placeholders. https://github.com/WordPress/twentynineteen/pull/217

Props kjellr, allancole, dimadin, westonruter.

See #45424.
Built from https://develop.svn.wordpress.org/branches/5.0@44196


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-15 11:09:56 +00:00
allancole
bf1668333f Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Fix JS errors in customizer caused by menu scripts
- Fix footer menu spacing
- Fix pullquote block borders to follow Gutenberg’s described style
- Fix editor-only styles so they don't appear on the frontend when not needed
- Fix search field widget width on mobile
- Fix :visited .button link colors
- Fix Block toolbar position in the editor
- Fix off-canvas mobile menu to prevent text from overflowing
- Improve column block formatting for the editor and frontend
- Improve CSS optimization for selectors that add `dashes` to multi-level lists
- Improve editor font sizes to use pixels over ems
- Improve styles for galleries in the Classic Editor block
- Improve priority+ more-menu threshold to allow more space for menu-items
- Improve logo size on mobile devices
- Improve customizer color options to present a single, unified color option
- Improve print stylesheet for better spacing and colors
- Add more color options to Gutenberg editor 

Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, jorbin, netweb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins, peterwilsoncc, dannycooper, iCaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, grapplerulrich, ocean90, joshfeck, frankew, AbdulWahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, nao, mayukojpn, enodekciw, ketuchetan, atanasangelovdev, poena, sharaz, artisticasad, mukesh27, burhandodhy, crunnells, aprakasa, themeroots, imonly_ik, tlxo, youthkee, brentswisher, smyoon315, mrahmadawais, desideveloper, Kau-Boy, mor10, mikeyarce, dingo_bastard


Built from https://develop.svn.wordpress.org/branches/5.0@43909


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-19 21:27:51 +00:00
allancole
2a8d718307 Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update changes the following: 

- Improve menu UI to support keyboard navigation in both directions
- Improve more-menu-link visibility when no menu items are hidden
- Improve text-selection custom colors for better contrast and legibility
- Improve support for sticky toolbars in the editor
- Improve table element fonts
- Add .button class support 
- Remove translation escaping
- Fix menu JS to prevent unused touched event listeners
- Fix duplicate more-menu-link issue on selective refresh in the customizer
- Fix editor font-weights for headings
- Fix search form input style
- Fix nested blockquote styles
- Fix download block button style when download text stretches more than one line
- Fix audio block centering issue
- Fix align-full blocks in the editor so they don’t create horizontal scrollbars
- Fix editor to prevent Gutenberg's meta boxes area from overlapping the content

Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, ntwb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins12, peterwilsoncc, DannyCooper, WPprodigy, siriokun, briannaorg, 00travelgirl00, shahjehanali1, ianbelanger79, nadim1992, Ismail-elkorchi, nativeinside, iamchetanp, grappler, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, jasmussen, laurelfulford, mdawaffe, kraftbj, dereksmart, naokomc, mayukojpn, enodekciw, chetansatasiya, ketuchetan, atanas-angelov-dev, carolinan, sharazghouri, artisan-asad, mukeshpanchal27, mukesh27, burhandodhy, @crunnells, aryaprakasa, tlxo, themeroots, whizbangik, yingles, tlxo, youthkee, brentswisher, smy315, ahmadawais, desi-developer, 2ndkauboy, mor10.

Built from https://develop.svn.wordpress.org/branches/5.0@43904


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-16 00:14:49 +00:00
allancole
31692a5f6e Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.
This update applies the following changes:

- Improve menu UI to support keyboard, click and touch interactions
- Improve variable scoping and js performance in menu interaction javascript
- Improve custom-colors for selected text, buttons and menu hover styles
- Improve margins structure for more consistency between editor and frontend
- Improve discussion avatars for simpler wording and better performance
- Improve fonts in list widgets and list blocks 
- Improve comment responsive spacing and avatar display
- Improve various block styles to make them consistent between the editor and frontend
- Add tabbed browsing support for ie11
- Add backwards compatibility support for older versions of WordPress
- Add fallback styles for older versions of WP where Gutenberg is activated and then deactivated (backwards compatibility)
- Add `sizes` attribute for featured images to improve responsive performance
- Add focus-within polyfill
- Add a footer menu for secondary page links
- Fix editor styles to prevent conflicts with plugins that add meta boxes to the editor
- Fix columns block issues on small screens
- Fix empty-space font text cursor issue in Gutenberg editor
- Fix RTL floating styles so that left/right floats are honored
- Fix cover image block margins/padding
- Fix invalid rgba style
- Fix php warning when returning attributes
- Fix gallery widget margins to improve gallery grids
- Fix .entry-content selectors to prevent shortcodes, plugins and other unknown content from breaking the layout
- Remove translation escaping to follow code standards in previous default themes
- Remove custom color output in the fronten header when default color is selected
- Remove fly-out sub-sub-sub-menu behavior on desktop to prevent sub-menus from falling off the screen
- General code clean up and coding standards improvements

Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa, @tlxo, @themeroots, @whizbangik, @yingles, @youthkee, @brentswisher, @smy315, @ahmadawais, @desi-developer.


Built from https://develop.svn.wordpress.org/branches/5.0@43892


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-12 23:20:51 +00:00
allancole
c53ad88930 Importing Twenty Nineteen, our new default theme for 2019, set for 5.0.
Let Gutenberg shine with this simple, fast, and powerful theme. Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa.

Built from https://develop.svn.wordpress.org/branches/5.0@43860


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-11-02 23:53:49 +00:00
allancole
b8cb0e7058 Importing Twenty Nineteen, our new default theme for 2019, set for 5.0.
Let Gutenberg shine with this simple, fast, and powerful theme. Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart.

Built from https://develop.svn.wordpress.org/branches/5.0@43842


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-30 02:15:04 +00:00
allancole
a3ae67bd8f Importing Twenty Nineteen, our new default theme for 2019, set for 5.0.
Let Gutenberg shine with this simple, fast, and powerful theme. Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12.

Built from https://develop.svn.wordpress.org/branches/5.0@43808


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-10-23 15:53:44 +00:00